Re: [Freecol-developers] First Successful Merge Request completed

2015-04-07 Thread winter
Gesendet:Dienstag, 07. April 2015 um 07:43 Uhr Von:Caleb Williams cale...@gmail.com An:FreeCol Developers freecol-developers@lists.sourceforge.net Betreff:Re: [Freecol-developers] First Successful Merge Request completed All: Based on WTs non-public comment on the issue, SFs Git integration seems

Re: [Freecol-developers] First Successful Merge Request completed

2015-04-07 Thread Caleb Williams
:43 Uhr Von: Caleb Williams cale...@gmail.com An: FreeCol Developers freecol-developers@lists.sourceforge.net Betreff: Re: [Freecol-developers] First Successful Merge Request completed All: Based on WT's non-public comment on the issue, SF's Git integration seems problematic to say the least

Re: [Freecol-developers] First Successful Merge Request completed

2015-04-07 Thread Caleb Williams
In response to https://sourceforge.net/p/freecol/git/merge-requests/29/: I took the jar out, as I think, introducing any external dependencies would be worth asking on mailing list in most projects. Thank you. I couldn't figure out how to get that out of the commit (I guess I should have just

Re: [Freecol-developers] First Successful Merge Request completed

2015-04-07 Thread Michael T. Pope
On Tue, 7 Apr 2015 10:15:02 -0500 Caleb Williams cale...@gmail.com wrote: I took the jar out, as I think, introducing any external dependencies would be worth asking on mailing list in most projects. Thank you. I couldn't figure out how to get that out of the commit (I guess I should have just

Re: [Freecol-developers] First Successful Merge Request completed

2015-04-07 Thread Caleb Williams
On Tue, Apr 7, 2015 at 5:04 PM, Michael T. Pope mp...@computer.org wrote: On Tue, 7 Apr 2015 10:15:02 -0500 Caleb Williams cale...@gmail.com wrote: I took the jar out, as I think, introducing any external dependencies would be worth asking on mailing list in most projects. Thank you. I

Re: [Freecol-developers] First Successful Merge Request completed

2015-04-06 Thread Caleb Williams
All: Based on WT's non-public comment on the issue, SF's Git integration seems problematic to say the least. I submitted a few MR's tonight and #29 combines all three, so please push that one of any of them. Sorry for the confusion. You'll notice that the above MR attempts to add

Re: [Freecol-developers] First Successful Merge Request completed

2015-04-05 Thread winter
to see the subpage on SF website. Greetings, wintertime Gesendet:Sonntag, 05. April 2015 um 06:31 Uhr Von:Caleb Williams cale...@gmail.com An:FreeCol Developers freecol-developers@lists.sourceforge.net Betreff:Re: [Freecol-developers] First Successful Merge Request completed Meanwhile

Re: [Freecol-developers] First Successful Merge Request completed

2015-04-05 Thread Michael T. Pope
On Sun, 5 Apr 2015 11:52:40 +0200 win...@genial.ms wrote: I would just keep the request as a reminder for now, to recheck someday. OK. That is making sourceforge useful. I will ignore that MR. Cheers, Mike Pope pgpIdz7IiqaBs.pgp Description: OpenPGP digital signature

Re: [Freecol-developers] First Successful Merge Request completed

2015-04-04 Thread Michael T. Pope
On Thu, 2 Apr 2015 13:35:51 +0200 win...@genial.ms wrote: yesterday I was too tired to write something, though I'd like to tell why I put nearly 2 hours into changing all the logger calls back. When reading the logfile to check my other changed I saw at many places {0} {1} and so on, not

Re: [Freecol-developers] First Successful Merge Request completed

2015-04-04 Thread Caleb Williams
Meanwhile, while I am writing, what is happening with MR#14 folks? You know I have been ignoring that warning, but if you think it can be fixed it would indeed be nice. Mike, Unless wintertime is aware of a more specific issue that I am not aware of, all i know is that the project.xml file

Re: [Freecol-developers] First Successful Merge Request completed

2015-04-02 Thread winter
Hi, yesterday I was too tired to write something, though I'd like to tell why I put nearly 2 hours into changing all the logger calls back. When reading the logfile to check my other changed I saw at many places {0} {1} and so on, not the data values one would want to have there. I wanted to

Re: [Freecol-developers] First Successful Merge Request completed

2015-03-30 Thread winter
Gesendet:Montag, 30. Mrz 2015 um 07:15 Uhr Von:Caleb Williams cale...@gmail.com An:FreeCol Developers freecol-developers@lists.sourceforge.net Betreff:Re: [Freecol-developers] First Successful Merge Request completed On Sun, Mar 29, 2015 at 10:31 PM, Caleb Williams cale...@gmail.com wrote: Hey all

Re: [Freecol-developers] First Successful Merge Request completed

2015-03-30 Thread Caleb Williams
*Gesendet:* Montag, 30. März 2015 um 07:15 Uhr *Von:* Caleb Williams cale...@gmail.com *An:* FreeCol Developers freecol-developers@lists.sourceforge.net *Betreff:* Re: [Freecol-developers] First Successful Merge Request completed On Sun, Mar 29, 2015 at 10:31 PM, Caleb Williams cale...@gmail.com

Re: [Freecol-developers] First Successful Merge Request completed

2015-03-30 Thread Michael T. Pope
On Mon, 30 Mar 2015 01:13:32 -0500 Caleb Williams cale...@gmail.com wrote: Plus it didn't help that I misinterpreted Michael's comment on the merge request. I should probably clarify here (rather than on the merge request) some JavaDoc practices used in FreeCol. Obviously there are two

Re: [Freecol-developers] First Successful Merge Request completed

2015-03-30 Thread Caleb Williams
On Mon, Mar 30, 2015 at 3:06 AM, Michael T. Pope mp...@computer.org wrote: On Mon, 30 Mar 2015 01:13:32 -0500 Caleb Williams cale...@gmail.com wrote: Plus it didn't help that I misinterpreted Michael's comment on the merge request. I should probably clarify here (rather than on the merge

Re: [Freecol-developers] First Successful Merge Request completed

2015-03-30 Thread Caleb Williams
All: Just submitted MR#16. Now that's showing blank too (as in 0 commits). I'm not sure why this is. Doing a search for this issue indicate these errors within SourceForge have been fixed, so it's puzzling. MR#16 should be checked before committing into the SF repository. There are a few changes

[Freecol-developers] First Successful Merge Request completed

2015-03-29 Thread Caleb Williams
Hey all, After a long time of bashing (no pun intended) my head against the SourceForge git wall, I've managed to make a successful merge request. All it should be is slight code clean up involving some of the following (client/gui/panel) files: - Remove unneeded packages - Add @Override