Re: [Ganglia-developers] dev2 and var-run-pidfile

2005-10-18 Thread Martin Knoblauch
--- Seth Alves <[EMAIL PROTECTED]> wrote: > > Martin Knoblauch wrote: > > Mark, > > I have you patch for bugzilla #72 in my local tree now. Two small > > problems: > > a) you need to use "fclose" instead of "close". Definitely a bug. > > oops! I'll fix our copy. > > > b) gcc "-Wall" complain

Re: [Ganglia-developers] dev2 and var-run-pidfile

2005-10-18 Thread Seth Alves
Martin Knoblauch wrote: Mark, I have you patch for bugzilla #72 in my local tree now. Two small problems: a) you need to use "fclose" instead of "close". Definitely a bug. oops! I'll fix our copy. b) gcc "-Wall" complains about an implicit decalration of "getpgid". Apparently "unistd.h" doe

Re: [Ganglia-developers] dev2 and var-run-pidfile

2005-10-18 Thread Martin Knoblauch
--- Mark Ferlatte <[EMAIL PROTECTED]> wrote: > Martin Knoblauch said on Mon, Oct 17, 2005 at 03:58:07AM -0700: > > Hmm. I will look into it again. I do not like it, but it seems > > harmless enough and I think that the disk-metric stuff is broken > > anyway. Please open a bugzilla entry and assi

Re: [Ganglia-developers] dev2 and var-run-pidfile

2005-10-17 Thread Martin Knoblauch
--- Mark Ferlatte <[EMAIL PROTECTED]> wrote: > Martin Knoblauch said on Mon, Oct 17, 2005 at 03:58:07AM -0700: > > Hmm. I will look into it again. I do not like it, but it seems > > harmless enough and I think that the disk-metric stuff is broken > > anyway. Please open a bugzilla entry and assi

Re: [Ganglia-developers] dev2 and var-run-pidfile

2005-10-17 Thread Rick Mohr
On Mon, 17 Oct 2005, Martin Knoblauch wrote: > in my opinion the disk metric stuff needs improvement. I personally > would like to see a user supplied list of partitions to monitor. That would definitely be nice. Right now, I run a cron job that does just that and I turn off all of Ganglia's me

Re: [Ganglia-developers] dev2 and var-run-pidfile

2005-10-17 Thread Mark Ferlatte
Martin Knoblauch said on Mon, Oct 17, 2005 at 03:58:07AM -0700: > Hmm. I will look into it again. I do not like it, but it seems > harmless enough and I think that the disk-metric stuff is broken > anyway. Please open a bugzilla entry and assign to me. For what it's worth, we don't really like

Re: [Ganglia-developers] dev2 and var-run-pidfile

2005-10-17 Thread Martin Knoblauch
Hi Rick, in my opinion the disk metric stuff needs improvement. I personally would like to see a user supplied list of partitions to monitor. But for 3.0.2 I am no going to touch this. The Debian "/dev2" hack may go in, because it is harmless. In any case could you open a bugzilla entry, giv

Re: [Ganglia-developers] dev2 and var-run-pidfile

2005-10-17 Thread Martin Knoblauch
--- Mark Ferlatte <[EMAIL PROTECTED]> wrote: > michael chang said on Fri, Oct 14, 2005 at 04:59:54PM -0400: > > Not to mention the patch seems to abandon everyone else who still > has > > a /dev/xyz setup (includes some debian and ubuntu users). > > Unless we really got the patch wrong, that's n

Re: [Ganglia-developers] dev2 and var-run-pidfile

2005-10-14 Thread Rick Mohr
While we are discussing the behavior of disk metric collection, I should mention that the current function does not properly handle NFS-root filesystems. The first couple lines of /proc/mounts look like: rootfs / rootfs rw 0 0 /dev/root / nfs 0 0 The current logic (at least in 3.0.1) searches f

Re: [Ganglia-developers] dev2 and var-run-pidfile

2005-10-14 Thread Mark Ferlatte
michael chang said on Fri, Oct 14, 2005 at 04:59:54PM -0400: > Not to mention the patch seems to abandon everyone else who still has > a /dev/xyz setup (includes some debian and ubuntu users). Unless we really got the patch wrong, that's not true. It still finds devices in /dev, it just also find

Re: [Ganglia-developers] dev2 and var-run-pidfile

2005-10-14 Thread michael chang
On 10/14/05, Mark Ferlatte <[EMAIL PROTECTED]> wrote: > Martin Knoblauch said on Thu, Oct 13, 2005 at 06:31:30PM -0700: > > to your first problem - I actually suspect a problem with your setup. > > Never seen a "/dev2/" before. Google shows: > > > > http://lists.debian.org/debian-kernel/2005/05/ms

Re: [Ganglia-developers] dev2 and var-run-pidfile

2005-10-14 Thread Seth Alves
Yeah, I didn't really know what the devs would prefer -- take my two-line patch as a way to point out the problem, rather than as the fix I expect to be committed. Mark explained about the pid file in his mail -- when the daemons fork, the init scripts write the wrong pids (generally off by on

Re: [Ganglia-developers] dev2 and var-run-pidfile

2005-10-14 Thread Mark Ferlatte
Martin Knoblauch said on Thu, Oct 13, 2005 at 06:31:30PM -0700: > to your first problem - I actually suspect a problem with your setup. > Never seen a "/dev2/" before. Google shows: > > http://lists.debian.org/debian-kernel/2005/05/msg00319.html It's actually not a problem in our setup, as such

Re: [Ganglia-developers] dev2 and var-run-pidfile

2005-10-13 Thread Martin Knoblauch
Hi Seth, to your first problem - I actually suspect a problem with your setup. Never seen a "/dev2/" before. Google shows: http://lists.debian.org/debian-kernel/2005/05/msg00319.html Also, your fix seems very unportable. What happens when there is a "/dev3/" out there some day? *If* the code ne

[Ganglia-developers] dev2 and var-run-pidfile

2005-10-13 Thread Seth Alves
Hello, I've been experimenting with using ganglios to monitor our machines, and I've run into a couple small problems. The first is that /proc/mounts looks like this for us (debian sarge, 2.6.8-2-686-smp). I don't know why it's /dev2 instead of /dev, our /dev directory is normal, there is n