ISTR we went to typed allocs as part of a transition which not
fully materialised?
Yes. I had plans to replace the call-based GC marker routines with a
generic routine that operates on a type marker stored next to the
object. That enables partial, generational, etc GC.
I actually dislike
)
+++ ChangeLog (working copy)
@@ -1,3 +1,8 @@
+2014-04-24 Laurynas Biveinis laurynas.bivei...@gmail.com
+
+ * MAINTAINERS: Move myself from Reviewers to Write After Approval
+ section.
+
2014-04-21 Rafael Ávila de Espíndola rafael.espind...@gmail.com
* MAINTAINERS (Write After Approval): Delete myself
Mike -
Unfortunately I cannot allocate time for the review of the gengtype
bits right now, and it's not clear when I will be able to.
2013/11/23 Mike Stump mikest...@comcast.net:
Richi has asked the we break the wide-int patch so that the individual port
and front end maintainers can review
* gengtype.c (create_user_defined_type): Ensure that the kind
is set to TYPE_USER_STRUCT, fixing a bug seen when an incomplete
declaration is seen before the GTY((user)) marking.
This is OK, thank you.
--
Laurynas
2013/5/6 Jeff Law l...@redhat.com:
On 05/03/2013 06:48 PM, David Malcolm wrote:
+static int indent_amount = 0;
+static int had_recent_newline = 0;
Any clean way to do this without the global state? I have to ask given
you're generally working on removing global state. Seems to take a
+2013-05-03 David Malcolm dmalc...@redhat.com
+
+ * gengtype-state.c: (indent_amount): New variable,
+ (had_recent_newline): likewise
+ (write_new_line): New function
+ (write_any_indent): likewise
+ (write_open_paren): likewise
+ (write_close_paren):
Diego -
I will need a global reviewer to approve the patch. Laurynas,
could you take a look to make sure I'm not forgetting to remove
anything?
Cannot find anything.
* gengtype.c (write_enum_defn): Remove. Update all users.
(write_Types_process_field): Remove generation
Folks, Parallel builds contain a race due to a missing dependency
between gengtype-lex.o and $(BCONFIG_H).
This was introduced by the commit:
http://gcc.gnu.org/ml/gcc-patches/2010-11/msg00926.html
.. which injects an include of bconfig.h into the top of
gengtype-lex.c but does not make
=== Approach: Use the Boehm collector.
The general approach is to define allocation and deallocation
functions to the Boehm collector that handle memory within the
PCH range. We would also provide a class to register global
roots at the point of declaration of those roots. We would likely
2012-11-15 Diego Novillo dnovi...@google.com
* gengtype-lex.l (VEC): Remove.
Add characters in the set [\!\\.-].
* gengtype-parse.c (token_names): Remove VEC.
(require_template_declaration): Remove handling of VEC_TOKEN.
(type): Likewise.
- if (s-u.s.line.file != NULL
- || (s-u.s.lang_struct (s-u.s.lang_struct-u.s.bitmap
bitmap)))
+ if (s-u.s.lang_struct (s-u.s.lang_struct-u.s.bitmap bitmap))
{
error_at_line (pos, duplicate definition of '%s %s',
isunion ? union : struct,
Tested on x86_64. OK for trunk?
Looks OK, with some very minor comments and questions below.
static void
-consume_until_semi (bool immediate)
+consume_until_eos (void)
{
- if (immediate token () != ';')
-require (';');
for (;;)
switch (token ())
{
case
Hello Basile -
2012-10-02 Basile Starynkevitch bas...@starynkevitch.net
* gengtype.c (walk_type): Emit mark_hook when inside a
struct of a union member.
Can you send me off-list the gengtype output before and after the fix?
+ const char *structmarkhook = NULL;
GRAMMAR
Support adding a second discriminator. This support is not for
multiple inheritance, but for single inheritance when a second
discriminator is used to further refine it. Look at struct
tree_omp_clause. It contains a sub union. We can represent the
hierarchy like:
struct
Hi -
2012/8/30 Aaron Gray aaronngray.li...@gmail.com:
First of two patches for class'ized cp/parser.c|h gives limited
support for gengtype to parse C++ classes and enums as first class
citizens.
Please sync with Diego to avoid duplicate work and/or conflicting designs.
Thanks,
--
Laurynas
Lawrence -
I don't have an opinion from the rest of compiler point of view, but
gengtype implementation-wise, it certainly looks doable. One minor
comment below -
GRAMMAR
Support adding a second discriminator. This support is not for
multiple inheritance, but for single inheritance when a
Diego -
I have some relatively minor comments. In general, the these changes
and the adjusted GTY doc intro blurb you sent in the other email are
OK with the minor comments addressed and if no objections from global
maintainers.
(walk_type): Set D-IN_PTR_FILED when walking a
Diego -
* doc/gty.texi: Document support for C++ templates and
user-provided markers.
The 1st node in this doc file needs s/C/C++/g and perhaps some more
explanation with an eye on C++.
Sorry. I'm not sure what you are trying to say here.
I'm referring to the very
Diego -
It's all good changes and your plan for future improvements sounds
good, including the part where gengtype is killed with fire.
- Functions should be emitted in files that have access to the
structure where they were defined. I'm not convinced that the
current multiplicity of
Ping?
2012/7/30 Laurynas Biveinis laurynas.bivei...@gmail.com:
I only remembered to add DEF_VEC_A handlgin to gengtype.c a second after
committing the previous patch [1].
Here it is, done as a follow up. With some luck, this will be short-lived
code because of the C++ conversion
Laurynas Biveinis laurynas.bivei...@gmail.com
* gengtype.h (enum gc_vec_type_kind): New.
List individual vector kinds in the token codes.
* gengtype-lex.l: Handle DEF_VEC_A, DEF_VEC_O, DEF_VEC_P,
DEF_VEC_I individually.
* gengtype-parse.c (token_names): Replace
Hi -
See http://gcc.gnu.org/PR53880#c27
Could you please have a look at that problem, and see if you, with all
your GTY-fu, see an easy way out?
It looks like you beat me to it :)
--
Laurynas
Steven -
Bootstrappedtested on powerpc64-unknown-linux-gnu. OK for trunk?
Thanks for working on this. It looks good, couple of minor comments:
Please add an assert that d-have_this_obj == true in
write_types_local_process_field, before the oprintf that outputs
this_obj.
@@ -3444,6 +3449,7 @@
.
Java and libcpp parts are already approved.
Tested on x86_64 linux, no regressions. OK for trunk?
[1] http://gcc.gnu.org/ml/gcc-patches/2012-07/msg01204.html
gcc:
2012-07-27 Laurynas Biveinis laurynas.bivei...@gmail.com
Steven Bosscher ste...@gcc.gnu.org
* gengtype.c
I think it merely points to a bogus GTY annotation, not sure if we want to
gobble this kind of gengtype hacks which only benefit -O0 ...
The annotation is libcpp/include/line-map.h
In the example above x1 (for token +) is going to be the same
as y1. x0 is the spelling location
gcc/lto/ChangeLog:
2012-07-24 Uros Bizjak ubiz...@gmail.com
* lto-tree.h (lang_decl): Add variable_size GTY option.
gcc/go/ChangeLog:
2012-07-24 Uros Bizjak ubiz...@gmail.com
* go-lang.c (lang_decl): Add variable_size GTY option.
gcc/c/ChangeLog:
2012-07-24 Uros
2012/7/24 Steven Bosscher stevenb@gmail.com:
On Tue, Jul 24, 2012 at 12:11 PM, Laurynas Biveinis
laurynas.bivei...@gmail.com wrote:
I think it merely points to a bogus GTY annotation, not sure if we want to
gobble this kind of gengtype hacks which only benefit -O0 ...
This one indeed
...@gmail.com
* include/line-map.h (line_map_macro): Use the atomic GTY option
for the macro_locations field.
gcc/java:
2012-07-24 Laurynas Biveinis laurynas.bivei...@gmail.com
* jcf.h (CPool): Use the atomic GTY option for the tags field.
(bootstrap_method): Likewise
s/arrays of scalar types/arrays of atomic types, add a ChangeLog entry
and the snippet above is approved ;)
Can you commit it along with your fixes? I think it'd be good to keep
this and your fixes together in a single commit.
OK
--
Laurynas
2012/7/4 Jonathan Wakely jwakely@gmail.com:
At some point in the past few weeks it became impossible to build
trunk from a sparse checkout that omits certain directories.
Because I nearly always configure with --enable-languages=c,c++ I use
git's core.sparseCheckout=true config or svn
While adjusting some GTY markers I started getting warnings about '^C' used
but not defined; this looks to be a cut and paste error.
Applying as obvious.
Good catch, thanks for fixing this.
--
Laurynas
2012 m. balandis 10 d. 18:08, Dodji Seketeli do...@redhat.com rašė:
gcc/
* gengtype.c (write_types_process_field): Force second argument
of the call to the PCH object hierarchy walker to be 'x'.
I guess it'd be better if we separated prev_val[3] and constant x
uses to separate
Basile -
I'm quite tempted to start working on a rewrite of gengtype in C++ (using
C++03 standard).
One of the reasons is that gengtype is really in bad shape, and nobody
understands it well. Another reason is that gengtype needs to be enhanced to
accept at least common C++ containers (like
2012/3/2 Diego Novillo dnovi...@google.com:
It already is. We bootstrap in C++ mode. I don't see a problem starting to
move some code to C++. Whether this is a good chunk of code to convert is
another question.
Sorry, I should have been more precise and said not the best first
module choice
I agree that such conversion will have to be done at some point, but
I'm not sure if a big rewrite should happen way before the rest of the
code will start to use gengtype-annotated C++ data structures.
Wait, I don't follow. gengtype supporting C++ data structures is
different than writing
Basile -
2011/10/19 Basile Starynkevitch bas...@starynkevitch.net:
On Wed, Oct 19, 2011 at 04:31:48PM +0300, Laurynas Biveinis wrote:
In the end I believe that it is the patches that talk. Whatever
patches are going to be submitted, reviewed and accepted, that is
going to be GCC's future
2011/10/20 Jan Kratochvil jan.kratoch...@redhat.com:
Hi,
with custom patched dwarf2out.c I got a crash on memory mangled by the garbage
collector. With patched GTY there the crash no longer happened - but I do not
have a reproducer anymore, sorry if it is a bogus patch.
The memory
Basile -
2011/10/18 Basile Starynkevitch bas...@starynkevitch.net:
Still, I find strange that while some very smart nice GCC guys want to get
rid of Ggc,
no patch made into the trunk towards that goal (which I Basile dislike and
don't share,
so don't expect me Basile to work on this.).
2011/10/13 Gary Funck g...@intrepid.com:
On 10/13/11 06:15:31, Laurynas Biveinis wrote:
[...] In your case (correct me if I misunderstood something)
you have one hash table, marking of which will mark more objects
which are required for the correct marking of the second hash table.
GC might
2011/10/11 Gary Funck g...@intrepid.com:
static GTY ((if_marked (tree_map_marked_p),
param_is (struct tree_map)))
htab_t upc_block_factor_for_type;
[...]
upc_block_factor_for_type = htab_create_ggc (512, tree_map_hash,
tree_map_eq,
2011/9/17 Dodji Seketeli do...@redhat.com:
OK, so the patch below extracts a public ggc_alloced_size_for_request
function from the different implementations of the ggc allocator's
interface, and lets new_linemap use that.
libcpp/
* include/line-map.h (struct
2011/8/16 Richard Guenther richard.guent...@gmail.com:
ggc_alloc_zone_vec_rtvec_def is for allocating an array of rtvec_def,
but you want a single (variable sized) rtvec_def, so
ggc_alloc_zone_rtvec_def is the correct function to call.
I'm not so sure about that given the more strongly typing
2011/8/16 Andreas Schwab sch...@redhat.com:
* ggc.h (ggc_alloc_rtvec_sized): Use ggc_alloc_zone_rtvec_def
instead of ggc_alloc_zone_vec_rtvec_def.
Thanks again,
--
Laurynas
On Mon, Aug 15, 2011 at 2:16 PM, 王亮 netcas...@gmail.com wrote:
The size it allocates is
(sizeof (struct rtvec_def) + ((NELT) - 1)) * sizeof (rtx)
Originally, the allocated size is
sizeof (struct rtvec_def) + ((NELT) - 1) * sizeof (rtx)
Yes, this is correct, good catch.
(sizeof
2011/8/15 Andreas Schwab sch...@linux-m68k.org:
I think it was meant to be this:
#define ggc_alloc_rtvec_sized(NELT) \
ggc_alloc_zone_rtvec_def (sizeof (struct rtvec_def) \
+ ((NELT) - 1) * sizeof (rtx),
Pinging yet again...
2011/7/22 Laurynas Biveinis laurynas.bivei...@gmail.com:
PING again...
2011/5/28 Laurynas Biveinis laurynas.bivei...@gmail.com:
PING
http://codereview.appspot.com/4250047
http://gcc.gnu.org/ml/gcc/2011-01/msg00363.html
this patch moves Valgrind header detection from
PING again...
2011/5/28 Laurynas Biveinis laurynas.bivei...@gmail.com:
PING
http://codereview.appspot.com/4250047
http://gcc.gnu.org/ml/gcc/2011-01/msg00363.html
this patch moves Valgrind header detection from valgrind checking to misc
and enables
the latter whenever the former is enabled
2011/7/18 Romain Geissler romain.geiss...@gmail.com:
* gengtype-state.c (#include bconfig.h): #include config.h
with host CC
include bconfig.h if GENERATOR_FILE is defined, config.h otherwise.
* gengtype.c: Likewise
* gengtype-lex.l: Likewise
*
2011/7/6 Basile Starynkevitch bas...@starynkevitch.net:
* doc/plugins.texi (Building GCC plugins): gengtype needs its
gtype.state
Replace than in the patch with as.
I assume it passes make info?
OK with that change, thank you.
--
Laurynas
the branch will be
ready for consideration for 4.7.
2011-06-02 Laurynas Biveinis laurynas.bivei...@gmail.com
* varasm.c (make_decl_rtl): Allocate DECL_RTL in the permanent RTL
memory.
* rtl.c: (_obstack_allocated_p): Declare.
(allocated_in_function_mem_p): New
PING
http://codereview.appspot.com/4250047
http://gcc.gnu.org/ml/gcc/2011-01/msg00363.html
this patch moves Valgrind header detection from valgrind checking to misc
and enables
the latter whenever the former is enabled.
If only misc is enabled, then Valgrind header presence is optional.
I plan
2011/5/19 Nicola Pero nicola.p...@meta-innovation.com:
Ok to go ?
+2011-05-20 Nicola Pero nicola.p...@meta-innovation.com
+
+ * gengtype.c (walk_type): Implemented atomic GTY option.
+ * doc/gty.texi (GTY Options): Document atomic GTY option.
I assume it received the usual
2011/5/16 Nicola Pero nicola.p...@meta-innovation.com:
2011-05-16 Nicola Pero nicola.p...@meta-innovation.com
* gengtype.c (walk_type): Implemented atomic GTY option.
* doc/gty.texi (GTY Options): Document atomic GTY option.
The patch is OK, with difference between skip and
2011-05-15 Dmitry Gorbachev d.g.gorbac...@gmail.com
* gengtype-state.c (read_state_param_structs): Initialize previous.
The logic in the function is OK, is this to silence some false positive warning?
In any case, the patch is OK, I assume you have tested it.
Thanks,
--
Laurynas
2011/5/1 Mark Mitchell m...@codesourcery.com:
The GCC Steering Committee appointed me to the role of GCC Release
Manager on March 22, 2000, as part of the GCC 3.0 release cycle. Eleven
years and umpteen releases later, it's time for me to relinquish that
position.
Mark -
Thank you for your
Thanks Diego, please send me the form. I'll sign it as soon as my
contributions require it.
Don't wait; sign it right away - it might take a while to process it.
--
Laurynas
2011/4/27 Dimitrios Apostolou ji...@gmx.net:
* ggc_internal_alloc_stat() or maybe implementing proper memory management
instead of garbage collection, for hottest caller
This one can easily take much more time than three months. I've been
working in this area, right now I'm working on
Dimitrios -
The patch is OK with a ChangeLog entry. Also a patch to fix the same
in gengtype.c:matching_file_name_substitute is pre-approved (but it
looks like Jeff will beat you to this :)
P.S. I was trying to test gcc on a rare arch (sparc-unknown-linux-gnu) but
unfortunately the
2011/4/17 Nicola Pero nicola.p...@meta-innovation.com:
While reading GCC code, I noticed that in gengtype-state.c
the equality function in a string hashtable is set to strcmp.
But that returns 0 (ie, false for hashtable.c) when the strings
are equal! I can't see how that hashtable would ever
On 04/11/2011 04:35 AM, Basile Starynkevitch wrote:
2011-04-11 Basile Starynkevitch bas...@starynkevitch.net
* gengtype.h (struct input_file_st): Add inpisplugin field.
(type_fileloc): New function.
* gengtype.c
(write_typed_struct_alloc_def): Add gcc_assert.
So what's the plan for the case where you need to change the lifetime of
an object?
Copying it. Frankly at the moment I don't how much trouble does deep
copying from scratch to function entails, as mentioned in your other
e-mail. ATM I am working at separating permanent from function. If it
[Resending with the correct Mike's address, sorry for the spam]
So what's the plan for the case where you need to change the lifetime of
an object?
Copying it. Frankly at the moment I don't how much trouble does deep
copying from scratch to function entails, as mentioned in your other
e-mail.
2011/4/8 Jeff Law l...@redhat.com:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 04/08/11 07:21, Laurynas Biveinis wrote:
2011/4/8 Steven Bosscher stevenb@gmail.com:
* stmt.c (label_rtx): Allocate RTX in permanent RTL memory.
That looks strange, labels should be function
2011/4/8 Basile Starynkevitch bas...@starynkevitch.net:
Actually, the above committed patch is better than nothing, but not
perfect. It happens to generate ggc_alloc macros for things which are
not defined in the plugin (however, this is not a big deal in practice,
since it generates some
2011/4/8 Steven Bosscher stevenb@gmail.com:
* stmt.c (label_rtx): Allocate RTX in permanent RTL memory.
That looks strange, labels should be function specific, except
non-local labels. Maybe you can get away with allocating DECL_NONLOCAL
labels on the permanent rtl obstack?
That's
Fixes a bunch of C testsuite failures. Committed to gc-improv.
2011-04-07 Laurynas Biveinis laurynas.bivei...@gmail.com
* stmt.c (label_rtx): Allocate RTX in permanent RTL memory.
Index: stmt.c
===
--- stmt.c (revision
Hello Basile -
The patch is correct in general. But a few nitpicks:
2011-04-04 Basile Starynkevitch bas...@starynkevitch.net
* gengtype.c (write_typed_alloc_def): Gets extra outf_p argument
and use it.
...: New argument f. Use it instead of header_file.
sharing of CONST_VECTOR rtxes. If that impacts memory usage
too much, a new hash table can be introduced for storing them. That is for
later, though.
Committed to gc-improv.
2011-03-29 Laurynas Biveinis laurynas.bivei...@gmail.com
* rtl.h (use_rtl_permanent_mem): New
2011/3/18 Nicola Pero nicola.p...@meta-innovation.com:
Index: gcc/ChangeLog
===
--- gcc/ChangeLog (revision 171155)
+++ gcc/ChangeLog (working copy)
@@ -1,3 +1,7 @@
+2011-03-18 Nicola Pero
2011/3/7 Basile Starynkevitch bas...@starynkevitch.net:
However, some source files considered by gengtype are outside of $(srcdir)
because they are somewhere else in the GCC source tree.
So most of the source files considered by gengtype are indeed in the
$(srcdir) of the gcc/Makefile.in
2011/2/13 Joseph S. Myers jos...@codesourcery.com:
User-visible improvements relative to 4.5 should also be
documented in gcc-4.6/changes.html if not already mentioned there.
We also have a new section for developer-visible changes which would
be helpful for plugin and out-of-the-tree
2011/2/8 Hans-Peter Nilsson h...@bitrange.com:
On Thu, 27 Jan 2011, Laurynas Biveinis wrote:
Thus I propose to separate the two. To avoid introducing another
--enable-checking option, let's move the annotations to the misc
checking and also enable misc too if valgrind is requested. Both
2011/2/4 Basile Starynkevitch bas...@starynkevitch.net:
An obvious strategy is to use the hardware watchpoint feature of GDB.
However, one cannot nicely put a watchpoint on an address which is not
mmap-ed yet.
Actually, you can do this with a recent enough GDB (7.1 AFAIK). It
will keep
I have just added a new section (approved by Gerald) to the bottom of
http://gcc.gnu.org/gcc-4.6/changes.html
Its intention is to mention noteworthy internal changes, i.e. changes
interesting for, say, maintainers of backends/frontends outside the
tree, and of course plugin developers upgrading
2011/1/27 Richard Guenther richard.guent...@gmail.com:
On Thu, Jan 27, 2011 at 1:23 PM, Laurynas Biveinis
laurynas.bivei...@gmail.com wrote:
The --enable-checking=valgrind does two things. First, it provides
Valgrind annotations for internal GCC allocators so that Valgrind has
a better idea
2011/1/27 H.J. Lu hjl.to...@gmail.com:
I think it is useful. I have run --enable-checking=valgrind once and it
took daays to finish. But I haven't got time analyze the result.
Do you mean, bootstrap + testsuite? IIRC someone submitted a few bug
reports (fixed now) in a row some three
On gc-improv I am working on PCH (mis-)feature that it stores a few
RTXes in a PCH file through tree (think tree_decl_with_rtl). I would
like to keep GTY completely away from RTL and that requires keeping
away RTL from PCH too.
In recent discussions on increasing GCC modularity, were there any
2011/1/28 Basile Starynkevitch bas...@starynkevitch.net:
Its intention is to mention noteworthy internal changes, i.e. changes
interesting for, say, maintainers of backends/frontends outside the
tree, and of course plugin developers upgrading from 4.5 to 4.6.
I am not sure to understand
The --enable-checking=valgrind does two things. First, it provides
Valgrind annotations for internal GCC allocators so that Valgrind has
a better idea about memory blocks which are not supposed to be
accessed. Second, it actually invokes Valgrind on every compiler
invocation. This makes the option
Hi -
2010/11/12 Bingfeng Mei b...@broadcom.com:
Hello,
In our port, I created a new NOTE to preserve pragma info. The
note is generated as follows in expanding builtins.
rtx note = emit_note(NOTE_INSN_LOOPCOUNT_PRAGMA_BEG);
rtx vector = gen_rtx_PARALLEL (VOIDmode,
MAINTAINERS to reflect your appointment.
I've just committed the following:
Index: ChangeLog
===
--- ChangeLog (revision 165606)
+++ ChangeLog (working copy)
@@ -1,3 +1,8 @@
+2010-10-18 Laurynas Biveinis laurynas.bivei...@gmail.com
, their variable_size annotations mask the fact
that c-lang.h does not have it. This is something that really should
be diagnosed by gengtype.
I will apply it to trunk later as obvious.
gcc/ChangeLog:
2010-09-14 Laurynas Biveinis laurynas.bivei...@gmail.com
* c-lang.h (struct lang_type): Add
2010/9/14 Diego Novillo dnovi...@google.com:
Incidentally, this is an issue I would like to address. We need
someone interested in maintaining the GC machinery. Any volunteers?
Laurynas?
Thanks for the suggestion. In fact, I was meaning to apply. But I can
see a few things that need to be
renq...@flyer-1-1:~/src/gcc-4.6-build$ grep -RsInw
ggc_alloc_cleared_lang_type gcc/
gcc/gtype-desc.h:2451:#define ggc_alloc_cleared_lang_type() ((struct
lang_type *)(ggc_internal_cleared_alloc_stat (sizeof (struct
lang_type) MEM_STAT_INFO)))
this definition just doesn't accept any
2010/9/13 Dennis, CHENG Renquan crq...@fedoraproject.org:
On Mon, Sep 13, 2010 at 8:16 PM, Laurynas Biveinis
laurynas.bivei...@gmail.com wrote:
I am the author of how these macros are generated, but somehow I have
missed this thread initially. Could you send me off-list that
gtype-desc.h file
2010/9/6 Basile Starynkevitch bas...@starynkevitch.net:
On Mon, 6 Sep 2010 06:36:48 +0300
Laurynas Biveinis laurynas.bivei...@gmail.com wrote:
2010/9/2 Basile Starynkevitch bas...@starynkevitch.net:
Hello Laurynas, Diego all the list.
A precise question about gengtype (the current trunk
2010/9/2 Basile Starynkevitch bas...@starynkevitch.net:
Hello Laurynas, Diego all the list.
A precise question about gengtype (the current trunk one)
I have the impression that every member of the 'param_structs' variable
in gengtype.c (viewed as a linked list of types linked thru their
2010/8/27 jeremie.salvu...@free.fr:
We think that the enum type_kind discriminates fields union in struct type.
So for TYPE_PARAM_STRUCT we believe that
the param_struct field of union u inside struct type is used. If this is
true, the test s-u.s.line.file != NULL is meaningless when
2010/8/27 jeremie.salvu...@free.fr:
We recompiled GCC-trunk r162692 with the following modification :
In function output_type_enum of gcc/gengtype.c, we replaced
- if (s-kind == TYPE_PARAM_STRUCT s-u.s.line.file != NULL)
+ if (s-kind == TYPE_PARAM_STRUCT s-u.param_struct.line.file !=
2010/8/24 Basile Starynkevitch bas...@starynkevitch.net:
Hello All
Jeremie Salvucci and me Basile are working on improving gengtype. Our
patch is still buggy [curious people might retrieve it from
http://starynkevitch.net/Basile/gengtype-r163335-24august-2010.diff
I was meaning to take a
2010/8/25 Basile Starynkevitch bas...@starynkevitch.net:
I am not at all sure we would be able to sent them separately, in such a
way that gengtype still works correctly with each patch applied one by
one.
It's hard to tell without looking at your patch, but your cleanups do
sound independent.
2010/7/14 Basile Starynkevitch bas...@starynkevitch.net:
I am quite sure that at some point in the past, the mark_hook did work.
But I have the impression that with the current gengtype, they don't.
[...]
Does any one have a working example of mark_hook GTY?
Have you ruled out user errors
Hi,
2010/7/13 Basile Starynkevitch bas...@starynkevitch.net:
The type machinery then provides allocators that take a parameter indicating
an exact size of object being allocated (like malloc does)
and the exemple should better be
Then the objects of struct sorted_fields_type are
Hi,
Sorry for the delayed reply.
Do you think it is only my misunderstanding (as everyone noticed, my
English language is poor since it is not my native language), or a bug
of the gengtype documentation, or a bug in gengtype code? Can several
GTY tags appear for the same union component as I
2010/6/15 Basile Starynkevitch bas...@starynkevitch.net:
/*** NOTE: june 2010.
GCC 4.6 has a new typed garbage collected allocator; so any
GTY-ed struct FOO_ST should be allocated using ggc_alloc_FOO_ST
or ggc_alloc_cleared_FOO_ST.
***/
#if BUILDING_GCC_VERSION =
Hi all,
I've committed the gc-improv code to trunk. The testsuite is still
running, however bootstrap went fine on x86_64/linux. Due to nature of
the changes, any problems should show up as bootstrap compile errors
and on x86_64/linux I don't expect them.
The problems are more (although IMHO not
On x86_64/linux, the merge does not cause any new testsuite
regressions, except the fact that two new testcases were added during
the freeze:
gfortran.dg/proc_ptr_27.f90
g++.dg/cpp0x/decltype23.C
So now I am more or less done with testing, and I am waiting for any
complaints :)
--
Laurynas
2010/6/8 Joern Rennecke amyl...@spamcop.net:
Quoting Laurynas Biveinis laurynas.bivei...@gmail.com:
I forgot in my previous e-mail the actual diff and the ChangeLogs of
the gc-improv merge, attaching now.
Your gcc/gcc/cp/ChangeLog entry starts with 'Likewise.'
I have noticed it before
Hi all,
Just a reminder, as discussed on thread starting at
http://gcc.gnu.org/ml/gcc/2010-06/msg00092.html
--
Laurynas
Hello all -
All the patches from gc-improv merge have been approved. Due to the
scope of the changes, the merge will need trunk freeze. Thus I am
planning to do it next Tuesday, at 7am CEST. The freeze should last
about 2-3 hours.
Alternatively I could also do the merge tomorrow at the same
1 - 100 of 166 matches
Mail list logo
