Re: [PATCH] Hashtable PR96088

2021-05-20 Thread François Dumont via Gcc-patches
On 20/05/21 6:44 pm, Jonathan Wakely wrote: On 06/05/21 22:03 +0200, François Dumont via Libstdc++ wrote: Hi     Considering your feedback on backtrace in debug mode is going to take me some time so here is another one.     Compared to latest submission I've added a _Hash_arg_t partial

Re: [PATCH] Add 3 target hooks for memset

2021-05-20 Thread Bernd Edlinger
On 5/20/21 10:49 PM, H.J. Lu wrote: > On Wed, May 19, 2021 at 5:55 AM H.J. Lu wrote: >> >> On Wed, May 19, 2021 at 2:25 AM Richard Biener >> wrote: >>> >>> On Tue, May 18, 2021 at 9:16 PM H.J. Lu wrote: Add TARGET_READ_MEMSET_VALUE and TARGET_GEN_MEMSET_VALUE to support target

Re: [PATCH] constructor: Elide expand_constructor when can move by pieces is true

2021-05-20 Thread Bernd Edlinger
On 5/20/21 4:03 PM, H.J. Lu wrote: > On Thu, May 20, 2021 at 12:51 AM Richard Biener > wrote: >> >> On Wed, May 19, 2021 at 3:22 PM H.J. Lu wrote: >>> >>> On Wed, May 19, 2021 at 2:33 AM Richard Biener >>> wrote: On Tue, May 18, 2021 at 9:16 PM H.J. Lu wrote: > > When

[committed] libstdc++: Implement LWG 3490 change to drop_while_view::begin()

2021-05-20 Thread Patrick Palka via Gcc-patches
Tested on x86_64-pc-linux-gnu, committed to trunk as obvious. libstdc++-v3/ChangeLog: PR libstdc++/100606 * include/std/ranges (drop_while_view::begin): Assert the precondition added by LWG 3490. --- libstdc++-v3/include/std/ranges | 1 + 1 file changed, 1 insertion(+)

Re: [i386] [PATCH] Fix ICE when lhs is NULL [PR target/100660]

2021-05-20 Thread Hongtao Liu via Gcc-patches
On Thu, May 20, 2021 at 4:30 PM Richard Biener wrote: > > On Thu, May 20, 2021 at 10:15 AM Hongtao Liu wrote: > > > > On Thu, May 20, 2021 at 4:06 PM Richard Biener > > wrote: > > > > > > On Thu, May 20, 2021 at 8:54 AM Hongtao Liu wrote: > > > > > > > > Hi: > > > > In folding

Re: [PATCH] i386: Optimize vpblendvb on inverted mask register to vpblendvb on swapping the order of operand 1 and operand 2. [PR target/99908]

2021-05-20 Thread Hongtao Liu via Gcc-patches
On Thu, May 13, 2021 at 8:43 AM Hongtao Liu wrote: > > On Wed, May 12, 2021 at 8:38 PM Uros Bizjak wrote: > > > > On Wed, May 12, 2021 at 1:42 PM Hongtao Liu wrote: > > > > > > On Wed, May 12, 2021 at 4:36 PM Uros Bizjak wrote: > > > > > > > > On Tue, Apr 27, 2021 at 1:05 PM Hongtao Liu via

Re: [PATCH] Fix vec-splati-runnable.c test.

2021-05-20 Thread Michael Meissner via Gcc-patches
On Thu, May 20, 2021 at 02:31:59PM -0500, will schmidt wrote: > On Tue, 2021-05-18 at 16:49 -0400, Michael Meissner wrote: > > [PATCH] Fix vec-splati-runnable.c test. > > > > hi, > > > > I noticed that the vec-splati-runnable.c did not have an abort after one > > of the tests. If the test was

Re: [PATCH 2/2] Fix xxeval predicates.

2021-05-20 Thread Michael Meissner via Gcc-patches
On Thu, May 20, 2021 at 02:31:08PM -0500, will schmidt wrote: > On Tue, 2021-05-18 at 16:47 -0400, Michael Meissner wrote: > > [PATCH 2/2] Fix xxeval predicates. > > > > In doing the patch to move the XX* built-in functions from altivec.md to > > vsx.md, I noticed that the xxeval built-in

Re: [PATCH 1/2] Move xx* builtins to vsx.md.

2021-05-20 Thread Michael Meissner via Gcc-patches
On Thu, May 20, 2021 at 02:30:24PM -0500, will schmidt wrote: > > +;; XXPERMX built-in function support > > +(define_expand "xxpermx" > > + [(set (match_operand:V2DI 0 "register_operand" "+wa") > > + (unspec:V2DI [(match_operand:V2DI 1 "register_operand" "wa") > > +

Re: [PATCH] Allow __ibm128 on older PowerPC systems.

2021-05-20 Thread Michael Meissner via Gcc-patches
On Thu, May 20, 2021 at 02:29:02PM -0500, will schmidt wrote: > On Tue, 2021-05-18 at 16:36 -0400, Michael Meissner wrote: > > [PATCH] Allow __ibm128 on older PowerPC systems. > > > > Hi, > > > > On January 8th, 2018, I added code to ibm-ldouble.c to use the built-in > > function

Re: [PATCH 2/2] Add IEEE 128-bit fp conditional move on PowerPC.

2021-05-20 Thread Michael Meissner via Gcc-patches
On Thu, May 20, 2021 at 02:27:06PM -0500, will schmidt wrote: > > diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c > > index fdaf12aeda0..ef1ebaaee05 100644 > > --- a/gcc/config/rs6000/rs6000.c > > +++ b/gcc/config/rs6000/rs6000.c > > @@ -15706,8 +15706,8 @@

Re: [PATCH 1/2] Add IEEE 128-bit min/max support on PowerPC.

2021-05-20 Thread Michael Meissner via Gcc-patches
On Thu, May 20, 2021 at 02:25:58PM -0500, will schmidt wrote: > I'd throw the ternary term in there, easier to search for later. > s/?: operations/ternary (?:) operations / Thanks. > So, presumably the float128-minmax-2.c test adds/replaces the power10 > code gen tests that were removed or

[PATCH] libgccjit: Add function to set the initial value of a global variable [PR96089]

2021-05-20 Thread Antoni Boucher via Gcc-patches
Hi. I made this patch to set an arbitrary value to a global variable. This patch suffers from the same issue as inline assembly (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100380), i.e. it segfaults if the `rvalue` is created after the global variable. It seems to be a design issue so I'm not

Re: [PATCH,V3 2/2] dwarf: new dwarf_debuginfo_p predicate

2021-05-20 Thread Indu Bhagat via Gcc-patches
On 5/20/21 2:40 AM, Richard Biener wrote: On Thu, May 13, 2021 at 12:52 AM Indu Bhagat via Gcc-patches wrote: [Changes from V2] - Tested build (make all-gcc) of cross compiler for target triplets containing c6x/mips/powerpc and darwin/cygwin. [End of changes from V2] This patch

Re: [PATCH,V3 1/2] opts: change write_symbols to support bitmasks

2021-05-20 Thread Indu Bhagat via Gcc-patches
On 5/20/21 2:40 AM, Richard Biener wrote: On Thu, May 13, 2021 at 12:53 AM Indu Bhagat via Gcc-patches wrote: [No changes from V2] To support multiple debug formats, we need to move away from explicit enumeration of each individual combination of debug formats. OK. Thanks, Richard.

Re: [PATCH 05/57] rs6000: Add file support and functions for diagnostic support

2021-05-20 Thread Segher Boessenkool
Hi! On Tue, Apr 27, 2021 at 10:32:40AM -0500, Bill Schmidt via Gcc-patches wrote: > * config/rs6000/rs6000-gen-builtins.c (bif_file): New filescope > variable. What makes it interesting that this var has file scope? Did you mean to say it has internal linkage ("is static")? I would

Re: [PATCH 04/57] rs6000: Add initial input files

2021-05-20 Thread Segher Boessenkool
On Tue, Apr 27, 2021 at 10:32:39AM -0500, Bill Schmidt via Gcc-patches wrote: > This patch adds a tiny subset of the built-in and overload descriptions. > * config/rs6000/rs6000-builtin-new.def: New. You'll have to rename this to not have "-new" in the name later, I hope you realise :-)

Re: [PATCH 03/57] rs6000: Initial create of rs6000-gen-builtins.c

2021-05-20 Thread Segher Boessenkool
Hi! On Tue, Apr 27, 2021 at 10:32:38AM -0500, Bill Schmidt via Gcc-patches wrote: > gcc/ > * config/rs6000/rs6000-gen-builtins.c: New. > +[altivec] > + const vsc __builtin_altivec_abs_v16qi (vsc); > +ABS_V16QI absv16qi2 {} > + const vss __builtin_altivec_abs_v8hi (vss); > +

Re: [PATCH 02/57] Support scanning of build-time GC roots in gengtype

2021-05-20 Thread Segher Boessenkool
On Tue, May 11, 2021 at 11:01:22AM -0500, Bill Schmidt wrote: > Hi!  I'd like to ping this specific patch from the series, which is the > only one remaining that affects common code.  I confess that I don't > know whom to ask for a review for gengtype; I didn't get any good ideas > from

Re: [PATCH 02/57] Support scanning of build-time GC roots in gengtype

2021-05-20 Thread Segher Boessenkool
Hi! On Tue, Apr 27, 2021 at 10:32:37AM -0500, Bill Schmidt via Gcc-patches wrote: > --- a/gcc/gengtype-state.c > +++ b/gcc/gengtype-state.c > @@ -1269,7 +1269,7 @@ state_writer::write_state_files_list (void) >int i = 0; >/* Write the list of files with their lang_bitmap. */ >

Re: [PATCH 00/57] Replace the Power target-specific built-in machinery

2021-05-20 Thread Segher Boessenkool
Hi! Just a few small things about this -- I'll reply to more of it later. On Tue, Apr 27, 2021 at 10:32:35AM -0500, Bill Schmidt via Gcc-patches wrote: > The design of the target-specific built-in function support in the > Power back end has not stood the test of time. The machinery is >

[PATCH] PR fortran/100551 - [11/12 Regression] Passing return value to class(*) dummy argument

2021-05-20 Thread Harald Anlauf via Gcc-patches
The fix for PR93924/5 has caused a regression for code such as given in the present PR. This can be remedied by adjusting the check when to invoke the implicit conversion of actual argument to an unlimited polymorphic procedure argument. Regtested on x86_64-pc-linux-gnu. OK for mainline and

[pushed] c++: designators in single-element init lists

2021-05-20 Thread Jason Merrill via Gcc-patches
While looking at PR100489, it occurred to me that places that currently use an initializer-list with a single element to initialize an object of the same type shouldn't do that if the element has a designator. Tested x86_64-pc-linux-gnu, applying to trunk. gcc/cp/ChangeLog: * call.c

[pushed] c++: designated init with anonymous union [PR100489]

2021-05-20 Thread Jason Merrill via Gcc-patches
My patch for PR98463 added an assert that tripped on this testcase, because we ended up with a U CONSTRUCTOR with an initializer for a, which is not a member of U. We need to wrap the a initializer in another CONSTRUCTOR for the anonymous union. There was already support for this in

[PATCH] Add 3 target hooks for memset

2021-05-20 Thread H.J. Lu via Gcc-patches
On Wed, May 19, 2021 at 5:55 AM H.J. Lu wrote: > > On Wed, May 19, 2021 at 2:25 AM Richard Biener > wrote: > > > > On Tue, May 18, 2021 at 9:16 PM H.J. Lu wrote: > > > > > > Add TARGET_READ_MEMSET_VALUE and TARGET_GEN_MEMSET_VALUE to support > > > target instructions to duplicate QImode value

[committed] libstdc++: Do not use static_assert without message in C++11

2021-05-20 Thread Jonathan Wakely via Gcc-patches
libstdc++-v3/ChangeLog: * include/bits/random.tcc (__representable_as_double) (__p1_representable_as_double): Add "" to static asserts. Tested powerpc64le-linux. Committed to trunk. commit 64ba45c76e831914764b70207d69a06f800b43a4 Author: Jonathan Wakely Date: Thu May 20

[committed] libstdc++: Use __builtin_unreachable for constexpr assertions [PR 100676]

2021-05-20 Thread Jonathan Wakely via Gcc-patches
The current implementation of compile-time precondition checks causes compilation to fail by calling a non-constexpr function declared at block scope. This breaks the CUDA compiler, which wraps some libstdc++ headers in a pragma that declares everything as a __host__ __device__ function, but

Re: [PATCH] libgccjit: Add support for types used by atomic builtins [PR96066] [PR96067]

2021-05-20 Thread David Malcolm via Gcc-patches
On Mon, 2021-05-17 at 21:02 -0400, Antoni Boucher via Jit wrote: > Hello. > This patch fixes the issue with using atomic builtins in libgccjit. > Thanks to review it. [...snip...] > diff --git a/gcc/jit/jit-recording.c b/gcc/jit/jit-recording.c > index 117ff70114c..de876ff9fa6 100644 > ---

Re: [PATCH] libgccjit: Add support for TLS variable [PR95415]

2021-05-20 Thread David Malcolm via Gcc-patches
On Tue, 2021-05-18 at 20:43 -0400, Antoni Boucher via Gcc-patches wrote: > Hello. > This patch adds support for TLS variables. > One thing to fix before we merge it is the libgccjit.map file which > contains LIBGCCJIT_ABI_16 instead of LIBGCCJIT_ABI_17. > LIBGCCJIT_ABI_16 was added in one of my

Re: [PATCH] c++: Add new warning options for C++ language mismatches

2021-05-20 Thread Jonathan Wakely via Gcc-patches
On 19/05/21 23:52 +0100, Jonathan Wakely wrote: On 19/05/21 16:08 -0400, Jason Merrill wrote: On 5/19/21 4:05 PM, Jonathan Wakely wrote: Oh, also we have https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93769 which points out a problem with the current wording. Not a very important one, but still

Re: [PATCH] libgccjit: Add support for setting the link section of global variables [PR100688]

2021-05-20 Thread David Malcolm via Gcc-patches
On Thu, 2021-05-20 at 15:29 -0400, David Malcolm wrote: > On Wed, 2021-05-19 at 20:32 -0400, Antoni Boucher via Jit wrote: > > Hello. > > This patch adds support to set the link section of global > > variables. > > I used the ABI 18 because I submitted other patches up to 17. > > Thanks for the

Re: [PATCH] c++: Add new warning options for C++ language mismatches

2021-05-20 Thread Jonathan Wakely via Gcc-patches
On 20/05/21 12:34 -0400, Jason Merrill wrote: On 5/20/21 8:56 AM, Jonathan Wakely wrote: On 19/05/21 16:05 -0400, Jason Merrill wrote: On 5/19/21 3:55 PM, Jonathan Wakely wrote: On 19/05/21 13:26 -0400, Jason Merrill wrote: On 5/19/21 12:46 PM, Jonathan Wakely wrote: On 19/05/21 17:39

Re: [PATCH 2/2] Fix tests when running on power10, PR testsuite/100166

2021-05-20 Thread will schmidt via Gcc-patches
On Tue, 2021-05-18 at 16:59 -0400, Michael Meissner wrote: > [PATCH 2/2] Fix tests when running on power10, PR testsuite/100166 > Hi, > This patch updates the various tests in the testsuite to adjust the test > if power10 code generation is used. > > Some tests would not generate the expected

Re: [PATCH 1/2] Deal with prefixed loads/stores in tests, PR testsuite/100166

2021-05-20 Thread will schmidt via Gcc-patches
On Tue, 2021-05-18 at 16:57 -0400, Michael Meissner wrote: > [PATCH 1/2] Deal with prefixed loads/stores in tests, PR testsuite/100166 > Hi, > This patch updates the various tests in the testsuite to treat plxv > and pstxv as being vector loads/stores. This shows up if you run the > testsuite

Re: [PATCH] c++: Add new warning options for C++ language mismatches

2021-05-20 Thread Jonathan Wakely via Gcc-patches
On 20/05/21 11:25 -0600, Martin Sebor wrote: On 5/20/21 6:56 AM, Jonathan Wakely wrote: On 19/05/21 16:05 -0400, Jason Merrill wrote: On 5/19/21 3:55 PM, Jonathan Wakely wrote: On 19/05/21 13:26 -0400, Jason Merrill wrote: On 5/19/21 12:46 PM, Jonathan Wakely wrote: On 19/05/21 17:39 +0100,

Re: [PATCH] Fix vec-splati-runnable.c test.

2021-05-20 Thread will schmidt via Gcc-patches
On Tue, 2021-05-18 at 16:49 -0400, Michael Meissner wrote: > [PATCH] Fix vec-splati-runnable.c test. > hi, > I noticed that the vec-splati-runnable.c did not have an abort after one > of the tests. If the test was run with optimization, the optimizer could > delete some of the tests and throw

Re: [PATCH 2/2] Fix xxeval predicates.

2021-05-20 Thread will schmidt via Gcc-patches
On Tue, 2021-05-18 at 16:47 -0400, Michael Meissner wrote: > [PATCH 2/2] Fix xxeval predicates. > > In doing the patch to move the XX* built-in functions from altivec.md to > vsx.md, I noticed that the xxeval built-in function used the > altivec_register_operand predicate. Since it takes vsx

Re: [PATCH 1/2] Move xx* builtins to vsx.md.

2021-05-20 Thread will schmidt via Gcc-patches
On Tue, 2021-05-18 at 16:46 -0400, Michael Meissner wrote: > [PATCH 1/2] Move xx* builtins to vsx.md. > Hi, > I noticed that the xx built-in functions (xxspltiw, xxspltidp, xxsplti32dx, > xxeval, xxblend, and xxpermx) were all defined in altivec.md. However, since > the XX instructions can

Re: [PATCH] Change rs6000_const_f32_to_i32 return type.

2021-05-20 Thread will schmidt via Gcc-patches
On Tue, 2021-05-18 at 16:39 -0400, Michael Meissner wrote: > [PATCH] Change rs6000_const_f32_to_i32 return type. > > The function rs6000_const_f32_to_i32 called REAL_VALUE_TO_TARGET_SINGLE > with a long long type and returns it. This patch changes the type to long > which is the proper type for

Re: [PATCH] libgccjit: Add support for setting the link section of global variables [PR100688]

2021-05-20 Thread David Malcolm via Gcc-patches
On Wed, 2021-05-19 at 20:32 -0400, Antoni Boucher via Jit wrote: > Hello. > This patch adds support to set the link section of global variables. > I used the ABI 18 because I submitted other patches up to 17. > Thanks for the review. I didn't see this email until now, and put the review in

Re: [PATCH] Allow __ibm128 on older PowerPC systems.

2021-05-20 Thread will schmidt via Gcc-patches
On Tue, 2021-05-18 at 16:36 -0400, Michael Meissner wrote: > [PATCH] Allow __ibm128 on older PowerPC systems. > Hi, > On January 8th, 2018, I added code to ibm-ldouble.c to use the built-in > function __builtin_pack_ibm128 if long double is IEEE 128-bit and continue to > use

Re: [PATCH] Fix long double tests when default long double is not IBM.

2021-05-20 Thread will schmidt via Gcc-patches
On Tue, 2021-05-18 at 16:32 -0400, Michael Meissner wrote: > [PATCH] Fix long double tests when default long double is not IBM. > Hi, > This patch adds 3 more selections to target-supports.exp to see if we can > force > the compiler to use a particular long double format (IEEE 128-bit, IBM >

Re: [PATCH 2/2] Add IEEE 128-bit fp conditional move on PowerPC.

2021-05-20 Thread will schmidt via Gcc-patches
On Tue, 2021-05-18 at 16:28 -0400, Michael Meissner wrote: > [PATCH 2/2] Add IEEE 128-bit fp conditional move on PowerPC. > Hi, > This patch adds the support for power10 IEEE 128-bit floating point > conditional > move and for automatically generating min/max. > > In this patch, I simplified

Re: [PATCH 1/2] Add IEEE 128-bit min/max support on PowerPC.

2021-05-20 Thread will schmidt via Gcc-patches
On Tue, 2021-05-18 at 16:26 -0400, Michael Meissner wrote: > [PATCH 1/2] Add IEEE 128-bit min/max support on PowerPC. > Hi, > This patch adds the support for the IEEE 128-bit floating point C minimum and > maximum instructions. The next patch will add the support for using the > compare and

Re: [PATCH] libgccjit: Add support for sized integer types, including 128-bit integers [PR95325]

2021-05-20 Thread David Malcolm via Gcc-patches
On Tue, 2021-05-18 at 14:53 +0200, Jakub Jelinek via Jit wrote: > On Tue, May 18, 2021 at 08:23:56AM -0400, Antoni Boucher via Gcc- > patches wrote: > > Hello. > > This patch add support for sized integer types. > > Maybe it should check whether the size of a byte for the current > > platform is 8

Re: [PATCH] i386: Avoid integer logic insns for 32bit and 64bit vector modes [PR100701]

2021-05-20 Thread Richard Biener via Gcc-patches
On May 20, 2021 6:52:17 PM GMT+02:00, Uros Bizjak via Gcc-patches wrote: >Integer logic instructions clobber flags, do not use them for >32bit and 64bit vector modes. We could add a CC clobber before reload and a splitter afterwards into one of the two variants? Not sure if worth the trouble

Re: [RFC] ldist: Recognize rawmemchr loop patterns

2021-05-20 Thread Stefan Schulze Frielinghaus via Gcc-patches
On Thu, May 20, 2021 at 11:24:57AM +0200, Richard Biener wrote: > On Fri, May 7, 2021 at 2:32 PM Stefan Schulze Frielinghaus > wrote: > > > > On Wed, May 05, 2021 at 11:36:41AM +0200, Richard Biener wrote: > > > On Tue, Mar 16, 2021 at 6:13 PM Stefan Schulze Frielinghaus > > > wrote: > > > > > >

Re: [PATCH] libstdc++: Fix access issue in iota_view::_Sentinel [PR100690]

2021-05-20 Thread Jonathan Wakely via Gcc-patches
On Thu, 20 May 2021, 19:35 Patrick Palka via Libstdc++, < libstd...@gcc.gnu.org> wrote: > Tested on x86_64-pc-linux-gnu, does this look OK for trunk/11/10? > Yes/yes/yes Thanks. > > libstdc++-v3/ChangeLog: > > PR libstdc++/100690 > * include/std/ranges

Re: [committed] testuite: Check pthread for omp module testing

2021-05-20 Thread Bernd Edlinger
On 5/19/21 4:58 PM, Kito Cheng wrote: > gcc/testsuite/ChangeLog: > > * g++.dg/modules/omp-1_a.C: Check pthread is available. > * g++.dg/modules/omp-1_b.C: Ditto. > * g++.dg/modules/omp-1_c.C: Ditto. > * g++.dg/modules/omp-2_a.C: Ditto. > * g++.dg/modules/omp-2_b.C:

[PATCH] libstdc++: Fix access issue in iota_view::_Sentinel [PR100690]

2021-05-20 Thread Patrick Palka via Gcc-patches
Tested on x86_64-pc-linux-gnu, does this look OK for trunk/11/10? libstdc++-v3/ChangeLog: PR libstdc++/100690 * include/std/ranges (iota_view::_Sentinel::_M_distance_from): Split out into this member function from ... (iota_view::_Sentinel::operator-): ... here,

Re: [PATCH] c++: Add new warning options for C++ language mismatches

2021-05-20 Thread Martin Sebor via Gcc-patches
On 5/20/21 6:56 AM, Jonathan Wakely wrote: On 19/05/21 16:05 -0400, Jason Merrill wrote: On 5/19/21 3:55 PM, Jonathan Wakely wrote: On 19/05/21 13:26 -0400, Jason Merrill wrote: On 5/19/21 12:46 PM, Jonathan Wakely wrote: On 19/05/21 17:39 +0100, Jonathan Wakely wrote: Jakub pointed out I'd

[PATCH] i386: Avoid integer logic insns for 32bit and 64bit vector modes [PR100701]

2021-05-20 Thread Uros Bizjak via Gcc-patches
Integer logic instructions clobber flags, do not use them for 32bit and 64bit vector modes. 2021-05-20 Uroš Bizjak gcc/ PR target/100701 * config/i386/i386.md (isa): Remove x64_bmi. (enabled): Remove x64_bmi. * config/i386/mmx.md (mmx_andnot3): Remove general register

Re: [PATCH] Hashtable PR96088

2021-05-20 Thread Jonathan Wakely via Gcc-patches
On 06/05/21 22:03 +0200, François Dumont via Libstdc++ wrote: Hi     Considering your feedback on backtrace in debug mode is going to take me some time so here is another one.     Compared to latest submission I've added a _Hash_arg_t partial specialization for std::hash<>. It is not

Re: [PATCH] c++: Add new warning options for C++ language mismatches

2021-05-20 Thread Jason Merrill via Gcc-patches
On 5/20/21 8:56 AM, Jonathan Wakely wrote: On 19/05/21 16:05 -0400, Jason Merrill wrote: On 5/19/21 3:55 PM, Jonathan Wakely wrote: On 19/05/21 13:26 -0400, Jason Merrill wrote: On 5/19/21 12:46 PM, Jonathan Wakely wrote: On 19/05/21 17:39 +0100, Jonathan Wakely wrote: Jakub pointed out I'd

Re: [PATCH] libstdc++: Implement missing P0896 changes to reverse_view [PR100639]

2021-05-20 Thread Jonathan Wakely via Gcc-patches
On 18/05/21 15:52 -0400, Patrick Palka via Libstdc++ wrote: This implements the P0896 changes to reverse_view's member types value_type, difference_type and reference in C++20 mode, which fixes problems taking the reverse_iterator of an iterator with a non-integral difference_type (such as

[PATCH] libstdc++: Support range adaptors with defaultable arguments

2021-05-20 Thread Patrick Palka via Gcc-patches
This adds support for defining range adaptors with defaultable arguments. No such range adaptors have yet been standardized, but range-v3 has a couple, e.g. 'unique' and 'sample' (which are approximately implemented in the added testcase), and it would be good to preemptively support such

Re: [PATCH] Try LTO partial linking. (Was: Speed of compiling gimple-match.c)

2021-05-20 Thread Jan Hubicka
> On Thu, May 20, 2021 at 3:16 PM Richard Biener > wrote: > > > > On Thu, May 20, 2021 at 3:06 PM Martin Liška wrote: > > > > > > On 5/20/21 2:54 PM, Richard Biener wrote: > > > > So why did you go from applying this per-file to multiple files? > > > > > > When I did per-file for

[PATCH, OpenMP 5.0] Improve OpenMP target support for C++ (includes PR92120 v3)

2021-05-20 Thread Chung-Lin Tang
Hi Jakub, the attached patch is a combination of the below patches already pushed to devel/omp/gcc-10, some are kind of transient bug fixes, but listing all for completeness: aadfc984: [PATCH] Target mapping C++ members inside member functions

Re: [PATCH] Fortran/OpenMP: Add support for 'close' in map clause

2021-05-20 Thread Jakub Jelinek via Gcc-patches
On Thu, May 20, 2021 at 04:11:10PM +0200, Marcel Vollweiler wrote: > --- a/gcc/fortran/openmp.c > +++ b/gcc/fortran/openmp.c > @@ -1710,27 +1710,62 @@ gfc_match_omp_clauses (gfc_omp_clauses **cp, const > omp_mask mask, > && gfc_match ("map ( ") == MATCH_YES) > { >

Re: [PATCH] Fortran/OpenMP: Add support for 'close' in map clause

2021-05-20 Thread Marcel Vollweiler
Hi Jakub, Am 20.05.2021 um 10:57 schrieb Jakub Jelinek: On Thu, May 20, 2021 at 10:47:52AM +0200, Marcel Vollweiler wrote: --- a/gcc/fortran/openmp.c +++ b/gcc/fortran/openmp.c @@ -1710,10 +1710,21 @@ gfc_match_omp_clauses (gfc_omp_clauses **cp, const omp_mask mask, && gfc_match

[PATCH] constructor: Elide expand_constructor when can move by pieces is true

2021-05-20 Thread H.J. Lu via Gcc-patches
On Thu, May 20, 2021 at 12:51 AM Richard Biener wrote: > > On Wed, May 19, 2021 at 3:22 PM H.J. Lu wrote: > > > > On Wed, May 19, 2021 at 2:33 AM Richard Biener > > wrote: > > > > > > On Tue, May 18, 2021 at 9:16 PM H.J. Lu wrote: > > > > > > > > When expanding a constant constructor, don't

Re: [PATCH] Simplify option handling for -fsanitize-coverage

2021-05-20 Thread Martin Liška
On 5/20/21 3:26 PM, Bernhard Reutner-Fischer wrote: On 20 May 2021 12:43:17 CEST, "Martin Liška" wrote: /* Given ARG, an unrecognized sanitizer option, return the best matching sanitizer option, or NULL if there isn't one. OPTS is array of candidate sanitizer options. - CODE is

Re: [PATCH] collect2: avoid failure when passing text files in an AIX archive

2021-05-20 Thread David Edelsohn via Gcc-patches
This should not use warning_at because there is no location. There is a separate "warning" diagnostic that should be used. I will test with a correct implementation. Thanks, David On Thu, May 20, 2021 at 4:13 AM CHIGOT, CLEMENT wrote: > > AIX ld allows archives to contain text files by simply

Re: [PATCH] Simplify option handling for -fsanitize-coverage

2021-05-20 Thread Bernhard Reutner-Fischer via Gcc-patches
On 20 May 2021 12:43:17 CEST, "Martin Liška" wrote: > /* Given ARG, an unrecognized sanitizer option, return the best > matching sanitizer option, or NULL if there isn't one. > OPTS is array of candidate sanitizer options. >- CODE is OPT_fsanitize_, OPT_fsanitize_recover_ or >-

Re: [PATCH] Try LTO partial linking. (Was: Speed of compiling gimple-match.c)

2021-05-20 Thread Richard Biener via Gcc-patches
On Thu, May 20, 2021 at 3:16 PM Richard Biener wrote: > > On Thu, May 20, 2021 at 3:06 PM Martin Liška wrote: > > > > On 5/20/21 2:54 PM, Richard Biener wrote: > > > So why did you go from applying this per-file to multiple files? > > > > When I did per-file for {gimple,generic}-match.c I hit

Re: [PATCH] Try LTO partial linking. (Was: Speed of compiling gimple-match.c)

2021-05-20 Thread Richard Biener via Gcc-patches
On Thu, May 20, 2021 at 3:06 PM Martin Liška wrote: > > On 5/20/21 2:54 PM, Richard Biener wrote: > > So why did you go from applying this per-file to multiple files? > > When I did per-file for {gimple,generic}-match.c I hit the following issue > with lto.priv symbols: > >

Re: [PATCH, rs6000] Remove mode promotion of SSA variables

2021-05-20 Thread Segher Boessenkool
Hi! On Thu, May 20, 2021 at 04:29:07PM +0800, HAO CHEN GUI wrote: > On 19/5/2021 下午 9:20, Segher Boessenkool wrote: > >On Wed, May 19, 2021 at 04:36:00PM +0800, HAO CHEN GUI wrote: > >>-/* Define this macro if it is advisable to hold scalars in registers > >>- in a wider mode than that declared

Re: [PATCH] Try LTO partial linking. (Was: Speed of compiling gimple-match.c)

2021-05-20 Thread Martin Liška
On 5/20/21 2:54 PM, Richard Biener wrote: So why did you go from applying this per-file to multiple files? When I did per-file for {gimple,generic}-match.c I hit the following issue with lto.priv symbols: /usr/lib64/gcc/x86_64-suse-linux/10/../../../../x86_64-suse-linux/bin/ld: error:

Re: [PATCH] testsuite: Use libstdc++ macro to check for pthread_cond_clockwait [PR 100655]

2021-05-20 Thread Jonathan Wakely via Gcc-patches
On 20/05/21 13:50 +0100, Jonathan Wakely wrote: Also add dg-shouldfail to ignore failures due to ulimit. gcc/testsuite/ChangeLog: PR testsuite/100655 * g++.dg/tsan/pthread_cond_clockwait.C: Use libstdc++ macro to check for availability of pthread_cond_clockwait. Add

Re: [PATCH 1/2, rs6000] Remove mode promotion for pseudos

2021-05-20 Thread Segher Boessenkool
[ Please send attachments as plain text, not as base64 ] On Thu, May 20, 2021 at 05:49:50PM +0800, HAO CHEN GUI wrote: > * config/rs6000/rs6000-call.c (rs6000_promote_function_mode): > Replace PROMOTE_MODE marco with its content. > diff --git a/gcc/config/rs6000/rs6000-call.c

Re: [PATCH] c++: Add new warning options for C++ language mismatches

2021-05-20 Thread Jonathan Wakely via Gcc-patches
On 19/05/21 16:05 -0400, Jason Merrill wrote: On 5/19/21 3:55 PM, Jonathan Wakely wrote: On 19/05/21 13:26 -0400, Jason Merrill wrote: On 5/19/21 12:46 PM, Jonathan Wakely wrote: On 19/05/21 17:39 +0100, Jonathan Wakely wrote: Jakub pointed out I'd forgotten the spaces before the opening

Re: [PATCH] Try LTO partial linking. (Was: Speed of compiling gimple-match.c)

2021-05-20 Thread Richard Biener via Gcc-patches
On Thu, May 20, 2021 at 2:34 PM Martin Liška wrote: > > Hello. > > I've got a patch candidate that leverages partial linking for a couple of > selected object files. > > I'm sending make all-host- jX results for my machine: > > before: 3m18s (user 32m52s) >

[PATCH] testsuite: Use libstdc++ macro to check for pthread_cond_clockwait [PR 100655]

2021-05-20 Thread Jonathan Wakely via Gcc-patches
Also add dg-shouldfail to ignore failures due to ulimit. gcc/testsuite/ChangeLog: PR testsuite/100655 * g++.dg/tsan/pthread_cond_clockwait.C: Use libstdc++ macro to check for availability of pthread_cond_clockwait. Add dg-shouldfail. Tested x86_64-linux (glibc

committed: Fix PR libstdc++/100361

2021-05-20 Thread Joern Wolfgang Rennecke
commit 66c5f24788652a49b528f14e23e8121ad0935ace (trunk) commit 5f772bd9847cdbf6a7a6d856de87cb65472d56f4 (releases/gcc11) As approved by Jonathan Wakely in the comments to PR libstdc++/100361 . Bootstrapped and regression tested on x86_64-pc-linux.gnu. 2021-05-18 Joern Rennecke libstdc++:

[PATCH] Try LTO partial linking. (Was: Speed of compiling gimple-match.c)

2021-05-20 Thread Martin Liška
Hello. I've got a patch candidate that leverages partial linking for a couple of selected object files. I'm sending make all-host- jX results for my machine: before: 3m18s (user 32m52s)

Re: [PATCH] tree-optimization: Improve spaceship_replacement [PR94589]

2021-05-20 Thread Richard Biener
On Thu, 20 May 2021, Jakub Jelinek wrote: > On Wed, May 19, 2021 at 01:30:31PM -0400, Jason Merrill via Gcc-patches wrote: > > Here, when genericizing lexicographical_compare_three_way, we haven't yet > > walked the operands, so (a == a) still sees ADDR_EXPR , but this is after > > we've changed

[PATCH] tree-optimization: Improve spaceship_replacement [PR94589]

2021-05-20 Thread Jakub Jelinek via Gcc-patches
On Wed, May 19, 2021 at 01:30:31PM -0400, Jason Merrill via Gcc-patches wrote: > Here, when genericizing lexicographical_compare_three_way, we haven't yet > walked the operands, so (a == a) still sees ADDR_EXPR , but this is after > we've changed the type of a to REFERENCE_TYPE. When we try to

Re: [PATCH][libgomp, nvptx] Fix hang in gomp_team_barrier_wait_end

2021-05-20 Thread Tom de Vries
On 5/20/21 11:52 AM, Thomas Schwinge wrote: > Hi Tom! > > First, thanks for looking into this PR99555! > > > I can't comment on the OpenMP/nvptx changes, so just the following: > > On 2021-04-23T18:48:01+0200, Tom de Vries wrote: >> --- a/libgomp/testsuite/libgomp.fortran/task-detach-6.f90 >>

Re: [PATCH][libsanitizer]: Guard cyclades inclusion in sanitizer

2021-05-20 Thread Florian Weimer via Gcc-patches
* Tamar Christina via Gcc-patches: > Hi All, > > libsanitizer: Guard cyclades inclusion in sanitizer > > The Linux kernel has removed the interface to cyclades from > the latest kernel headers[1] due to them being orphaned for the > past 13 years. Nit: The commit subject doesn't match the patch

Re: [PATCH][libsanitizer]: Guard cyclades inclusion in sanitizer

2021-05-20 Thread Jakub Jelinek via Gcc-patches
On Thu, May 20, 2021 at 11:49:03AM +0100, Tamar Christina wrote: > libsanitizer: Guard cyclades inclusion in sanitizer > > The Linux kernel has removed the interface to cyclades from > the latest kernel headers[1] due to them being orphaned for the > past 13 years. > > libsanitizer uses this

Re: [PATCH] Add no_sanitize_coverage attribute.

2021-05-20 Thread Marco Elver via Gcc-patches
On Thu, 20 May 2021 at 11:08, Martin Liška wrote: > On 5/20/21 10:45 AM, Marco Elver wrote: > > On Thu, 20 May 2021 at 10:33, Martin Liška wrote: > >> Hello. > >> > >> The patch implements one missing attribute which can be used for > >> per-function > >> disabling of coverage sanitization. >

[PATCH][libsanitizer]: Guard cyclades inclusion in sanitizer

2021-05-20 Thread Tamar Christina via Gcc-patches
Hi All, libsanitizer: Guard cyclades inclusion in sanitizer The Linux kernel has removed the interface to cyclades from the latest kernel headers[1] due to them being orphaned for the past 13 years. libsanitizer uses this header when compiling against glibc, but glibcs itself doesn't seem to

Re: [PATCH v2] vect: Replace hardcoded weight factor with param

2021-05-20 Thread Kewen.Lin via Gcc-patches
on 2021/5/20 下午6:25, Richard Biener wrote: > On Thu, May 20, 2021 at 12:09 PM Kewen.Lin wrote: >> >> on 2021/5/20 下午5:30, Christophe Lyon wrote: >>> On Thu, 20 May 2021 at 10:52, Kewen.Lin via Gcc-patches >>> wrote: on 2021/5/19 下午6:01, Richard Biener wrote: > On Wed, May 19, 2021

[PATCH] Simplify option handling for -fsanitize-coverage

2021-05-20 Thread Martin Liška
The simplification patch improves option completion and handling of the option. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: * common.opt: Use proper Enum values. * opts.c (COVERAGE_SANITIZER_OPT):

Re: [PATCH v2] vect: Replace hardcoded weight factor with param

2021-05-20 Thread Richard Biener via Gcc-patches
On Thu, May 20, 2021 at 12:09 PM Kewen.Lin wrote: > > on 2021/5/20 下午5:30, Christophe Lyon wrote: > > On Thu, 20 May 2021 at 10:52, Kewen.Lin via Gcc-patches > > wrote: > >> > >> on 2021/5/19 下午6:01, Richard Biener wrote: > >>> On Wed, May 19, 2021 at 11:47 AM Kewen.Lin wrote: > > Hi

Re: [RFC] Using main loop's updated IV as base_address for epilogue vectorization

2021-05-20 Thread Richard Biener
On Mon, 17 May 2021, Andre Vieira (lists) wrote: > Hi, > > So this is my second attempt at finding a way to improve how we generate the > vector IV's and teach the vectorizer to share them between main loop and > epilogues. On IRC we discussed my idea to use the loop's control_iv, but that > was

Re: [PATCH v2] vect: Replace hardcoded weight factor with param

2021-05-20 Thread Kewen.Lin via Gcc-patches
on 2021/5/20 下午5:30, Christophe Lyon wrote: > On Thu, 20 May 2021 at 10:52, Kewen.Lin via Gcc-patches > wrote: >> >> on 2021/5/19 下午6:01, Richard Biener wrote: >>> On Wed, May 19, 2021 at 11:47 AM Kewen.Lin wrote: Hi Richi, on 2021/5/19 下午4:15, Richard Biener wrote: > On

Re: [PATCH][libgomp, nvptx] Fix hang in gomp_team_barrier_wait_end

2021-05-20 Thread Thomas Schwinge
Hi Tom! First, thanks for looking into this PR99555! I can't comment on the OpenMP/nvptx changes, so just the following: On 2021-04-23T18:48:01+0200, Tom de Vries wrote: > --- a/libgomp/testsuite/libgomp.fortran/task-detach-6.f90 > +++ b/libgomp/testsuite/libgomp.fortran/task-detach-6.f90 >

[PATCH 1/2, rs6000] Remove mode promotion for pseudos

2021-05-20 Thread HAO CHEN GUI via Gcc-patches
Hi,    The patch is preparatory for the patch2 - remove mode promotion for pseudos.    The attachments are the patch diff and change log file.     Bootstrapped and tested on powerpc64le-linux and powerpc64-linux (with both m32 and m64) with no regressions. Is this okay for trunk? Any

[PATCH 2/2, rs6000] Remove mode promotion for pseudos

2021-05-20 Thread HAO CHEN GUI via Gcc-patches
Hi,    The patch removes mode promotion for pseudos on rs6000 target.    The attachments are the patch diff and change log file.     Bootstrapped and tested on powerpc64le-linux and powerpc64-linux (with both m32 and m64) with no regressions. Is this okay for trunk? Any recommendations?

Re: [PATCH v2] forwprop: Support vec perm fed by CTOR and CTOR/CST [PR99398]

2021-05-20 Thread Richard Biener
On Thu, 13 May 2021, Kewen.Lin wrote: > Hi Richi, > > Thanks for the review! > > on 2021/5/11 下午9:26, Richard Biener wrote: > > On Fri, 7 May 2021, Kewen.Lin wrote: > > > >> Hi, > >> > >> This patch is to teach forwprop to optimize some cases where the > >> permutated operands of vector

Re: [PATCH,V3 1/2] opts: change write_symbols to support bitmasks

2021-05-20 Thread Richard Biener via Gcc-patches
On Thu, May 13, 2021 at 12:53 AM Indu Bhagat via Gcc-patches wrote: > > [No changes from V2] > > To support multiple debug formats, we need to move away from explicit > enumeration of each individual combination of debug formats. OK. Thanks, Richard. > gcc/c-family/ChangeLog: > > *

Re: [PATCH,V3 2/2] dwarf: new dwarf_debuginfo_p predicate

2021-05-20 Thread Richard Biener via Gcc-patches
On Thu, May 13, 2021 at 12:52 AM Indu Bhagat via Gcc-patches wrote: > > [Changes from V2] > - Tested build (make all-gcc) of cross compiler for target triplets > containing c6x/mips/powerpc and darwin/cygwin. > [End of changes from V2] > > This patch introduces a dwarf_debuginfo_p predicate

Re: [PATCH 2/2] ipa-sra: Improve debug info for removed parameters (PR 93385)

2021-05-20 Thread Richard Biener via Gcc-patches
On Mon, May 10, 2021 at 8:43 PM Martin Jambor wrote: > > On Mon, May 10 2021, Richard Biener wrote: > > On Tue, Apr 27, 2021 at 5:26 PM Martin Jambor wrote: > >> > >> Hi, > >> > >> Whereas the previous patch fixed issues with code left behind after > >> IPA-SRA removed a parameter but only reset

Re: [PATCH v2] vect: Replace hardcoded weight factor with param

2021-05-20 Thread Christophe Lyon via Gcc-patches
On Thu, 20 May 2021 at 10:52, Kewen.Lin via Gcc-patches wrote: > > on 2021/5/19 下午6:01, Richard Biener wrote: > > On Wed, May 19, 2021 at 11:47 AM Kewen.Lin wrote: > >> > >> Hi Richi, > >> > >> on 2021/5/19 下午4:15, Richard Biener wrote: > >>> On Wed, May 19, 2021 at 8:20 AM Kewen.Lin wrote: >

Re: [RFC] ldist: Recognize rawmemchr loop patterns

2021-05-20 Thread Richard Biener via Gcc-patches
On Fri, May 7, 2021 at 2:32 PM Stefan Schulze Frielinghaus wrote: > > On Wed, May 05, 2021 at 11:36:41AM +0200, Richard Biener wrote: > > On Tue, Mar 16, 2021 at 6:13 PM Stefan Schulze Frielinghaus > > wrote: > > > > > > [snip] > > > > > > Please find attached a new version of the patch. A

[PATCH] i386: Add mult-high and shift patterns for 4-byte vectors [PR100637]

2021-05-20 Thread Uros Bizjak via Gcc-patches
2021-05-20 Uroš Bizjak gcc/ PR target/100637 * config/i386/mmx.md (Yv_Yw): Revert adding V4QI and V2HI modes. (*3): Use Yw instad of constrint. (mulv4hi3_highpart): New expander. (*mulv2hi3_highpart): New insn pattern. (mulv2hi3_higpart): New expander. (*v2hi3):

Re: [PATCH] Add no_sanitize_coverage attribute.

2021-05-20 Thread Martin Liška
On 5/20/21 10:45 AM, Marco Elver wrote: On Thu, 20 May 2021 at 10:33, Martin Liška wrote: Hello. The patch implements one missing attribute which can be used for per-function disabling of coverage sanitization. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Thanks

Re: [PATCH] go/100537 - Bootstrap-O3 and bootstrap-debug fail

2021-05-20 Thread guojiufu via Gcc-patches
On 2021-05-18 14:58, Richard Biener wrote: On Mon, 17 May 2021, Ian Lance Taylor wrote: On Mon, May 17, 2021 at 1:17 AM Richard Biener via Gcc-patches wrote: > > On Fri, May 14, 2021 at 11:19 AM guojiufu via Gcc-patches > wrote: > > > > On 2021-05-14 15:39, guojiufu via Gcc-patches wrote: >

Re: [PATCH] Fortran/OpenMP: Add support for 'close' in map clause

2021-05-20 Thread Jakub Jelinek via Gcc-patches
On Thu, May 20, 2021 at 10:47:52AM +0200, Marcel Vollweiler wrote: > --- a/gcc/fortran/openmp.c > +++ b/gcc/fortran/openmp.c > @@ -1710,10 +1710,21 @@ gfc_match_omp_clauses (gfc_omp_clauses **cp, const > omp_mask mask, > && gfc_match ("map ( ") == MATCH_YES) > { >

  1   2   >