[PATCH] Add a new conversion for conditional ternary set into ifcvt [PR106536]

2022-11-22 Thread HAO CHEN GUI via Gcc-patches
Hi, There is a new insn on my target, which has a nested if_then_else and set -1, 0 and 1 according to a comparison. [(set (match_operand:SI 0 "gpc_reg_operand" "=r") (if_then_else:SI (lt (match_operand:CC 1 "cc_reg_operand" "y") (const_int 0))

[PATCH v1] LoongArch: Fixed a compilation failure with '%c' in inline assembly [PR107731].

2022-11-22 Thread Lulu Cheng
gcc/ChangeLog: * config/loongarch/loongarch.cc (loongarch_classify_address): Add precessint for CONST_INT. (loongarch_print_operand): Increase the processing of '%c'. gcc/testsuite/ChangeLog: * gcc.target/loongarch/tst-asm-const.c: Moved to... * gcc.target

Re: [EXTERNAL] Re: [PATCH] Fix autoprofiledbootstrap build

2022-11-22 Thread Jeff Law via Gcc-patches
On 11/22/22 14:20, Eugene Rozenfeld wrote: I took another look at this. We actually collect perf data when building the libraries. So, we have ./prev-gcc/perf.data, ./prev-libcpp/perf.data, ./prev-libiberty/perf.data, etc. But when creating gcov data for -fauto-profile build of cc1plus or c

Re: [PATCH v3] RISC-V modified add3 for large stack frame optimization [PR105733]

2022-11-22 Thread Jeff Law via Gcc-patches
On 11/3/22 18:53, Kevin Lee wrote: This is the identical patch with https://gcc.gnu.org/pipermail/gcc-patches/2022-November/604814.html, but with the correct plaintext format. The loop still seems a bit odd which may point to further improvements that could be made to this patch. Consider

Re: [committed][RISC-V] Fix recent rvv/base/spill testcase failures

2022-11-22 Thread Kito Cheng via Gcc-patches
LGTM, thanks :) On Wed, Nov 23, 2022 at 7:21 AM Jeff Law wrote: > > As Jaiwei noted, many (all?) of the rvv/base/spill tests started failing > after the introduction of shrink-wrapping. > > > The core issue is we're expecting the frame to have a constant size, but > it doesn't. So when using the

Re: [pushed][PATCH v3] LoongArch: Add prefetch instructions.

2022-11-22 Thread chenglulu
Pushed r13-4259. 在 2022/11/16 10:10, Lulu Cheng 写道: v2 -> v3: 1. Remove preldx support. --- Enable sw prefetching at -O3 and higher. Co-Authored-By: xujiahao gcc/ChangeLog: * config/loongarch/constraints.md (ZD): New constraint. * config/l

Re: [PATCH V2] Use subscalar mode to move struct block for parameter

2022-11-22 Thread Jiufu Guo via Gcc-patches
Hi Jeff, Thanks a lot for your comments! Jeff Law writes: > On 11/20/22 20:07, Jiufu Guo wrote: >> Jiufu Guo writes: >> >>> Hi, >>> >>> As mentioned in the previous version patch: >>> https://gcc.gnu.org/pipermail/gcc-patches/2022-October/604646.html >>> The suboptimal code is generated for "a

[PATCH] Change the behavior of predicate check failure on cbranchcc4 operand0 in prepare_cmp_insn

2022-11-22 Thread HAO CHEN GUI via Gcc-patches
Hi, I want to enable "have_cbranchcc4" on rs6000. But not all combinations of comparison codes and sub CC modes are benefited to generate cbranchcc4 insns on rs6000. There is an predicate for operand0 of cbranchcc4 to bypass some combinations. It gets assertion failure in prepare_cmp_insn. I thin

Re: [PATCH] configure: Implement --enable-host-pie

2022-11-22 Thread Marek Polacek via Gcc-patches
On Sun, Nov 20, 2022 at 08:06:55AM -0700, Jeff Law wrote: > > On 11/10/22 19:52, Marek Polacek via Gcc-patches wrote: > > This is a rebased version of the patch I posted in March: > > > > which Alex sort of approved here: > >

Re: [PATCH v4] LoongArch: Optimize immediate load.

2022-11-22 Thread chenglulu
在 2022/11/23 00:44, Xi Ruoyao 写道: While I still can't fully understand the immediate load issue and how this patch fix it, I've tested this patch (alongside the prefetch instruction patch) with bootstrap-ubsan.  And the compiled result of imm-load1.c seems OK. And it's doing correct thing for

Re: [PATCH] i386: Only enable small loop unrolling in backend [PR 107602]

2022-11-22 Thread Hongyu Wang via Gcc-patches
Hi Jeff, > The reversion of the loop-init.cc changes is fine. The x86 maintainers > will need to chime in on the rest. Consider installing the loop-init.cc > reversion immediately as the current state has regressed s390 and > potentially other targets. I've posted a patch in https://gcc.gnu.org

Re: [PATCH] rs6000: Adjust loop_unroll_adjust to match middle-end change [PR 107692]

2022-11-22 Thread Hongyu Wang via Gcc-patches
Hi, Segher and Richard > > Something in your patch was wrong, please fix that (or revert the > > patch). You should not have to touch config/rs6000/ at all. > > Sure something is wrong, but I think there's the opportunity to > simplify rs6000/ and s390x/, the only other two implementors of > the

Re: [PATCH][RFC] Unify MAX_NUM_CHAINS and MAX_CHAIN_LEN to --param uninit-max-predicate-size

2022-11-22 Thread Jeff Law via Gcc-patches
On 9/5/22 07:25, Richard Biener via Gcc-patches wrote: The following exposes the MAX_NUM_CHAINS and MAX_CHAIN_LEN to the user by adding a --param uninit-max-predicate-size and re-doing the limits on the whole predicate expression size rather than limiting the number of OR and AND elements separ

Re: [committed] Fix comment typos noticed by Bernhard

2022-11-22 Thread Jeff Law
On 11/22/22 16:28, Andrew Pinski wrote: On Tue, Nov 22, 2022 at 3:25 PM Jeff Law wrote: Minor comment typo fixes as noticed by Bernhard. Installed onto the trunk, Hmm: - int alternative + int bool That seems wrong and might cause a build failure. Fixed thusly. jeff ps.  I keep thinki

Re: [committed] Fix comment typos noticed by Bernhard

2022-11-22 Thread Jeff Law
On 11/22/22 16:28, Andrew Pinski wrote: On Tue, Nov 22, 2022 at 3:25 PM Jeff Law wrote: Minor comment typo fixes as noticed by Bernhard. Installed onto the trunk, Hmm: - int alternative + int bool That seems wrong and might cause a build failure. Ugh.  Probably will.  I'll double-chec

Re: [committed] Fix comment typos noticed by Bernhard

2022-11-22 Thread Andrew Pinski via Gcc-patches
On Tue, Nov 22, 2022 at 3:25 PM Jeff Law wrote: > > Minor comment typo fixes as noticed by Bernhard. > > > Installed onto the trunk, Hmm: - int alternative + int bool That seems wrong and might cause a build failure. Thanks, Andrew > > > Jeff > >

[committed] Fix comment typos noticed by Bernhard

2022-11-22 Thread Jeff Law
Minor comment typo fixes as noticed by Bernhard. Installed onto the trunk, Jeff commit a03b35a28db262546415e8f16829cbb027a75025 Author: Jeff Law Date: Tue Nov 22 16:22:18 2022 -0700 Fix comment typos noticed by Bernhard gcc/ * tree-ssa-dom.cc (record_edge_info):

[committed][RISC-V] Fix recent rvv/base/spill testcase failures

2022-11-22 Thread Jeff Law
As Jaiwei noted, many (all?) of the rvv/base/spill tests started failing after the introduction of shrink-wrapping. The core issue is we're expecting the frame to have a constant size, but it doesn't.  So when using the to_constant method we abort. The safest thing to do is to set no shrink

Re: [PATCH v2] tree-object-size: Support strndup and strdup

2022-11-22 Thread Siddhesh Poyarekar
On 2022-11-22 15:43, Jeff Law wrote: On 11/21/22 07:27, Siddhesh Poyarekar wrote: On 2022-11-20 10:42, Jeff Law wrote: On 11/4/22 06:48, Siddhesh Poyarekar wrote: Use string length of input to strdup to determine the usable size of the resulting object.  Avoid doing the same for strndup sin

Re: [PATCH] c: Propagate erroneous types to declaration specifiers [PR107805]

2022-11-22 Thread Joseph Myers
On Tue, 22 Nov 2022, Florian Weimer via Gcc-patches wrote: > Without this change, finish_declspecs cannot tell that whether there > was an erroneous type specified, or no type at all. This may result > in additional diagnostics for implicit ints, or missing diagnostics > for multiple types. > >

Re: [PATCH] range-op: Implement floating point division fold_range [PR107569]

2022-11-22 Thread Joseph Myers
On Tue, 22 Nov 2022, Jan-Benedict Glaw wrote: > I'm running a slightly hacked [glibc]/scripts/build-many-glibcs.py to > to CI builds for glibc as well by now (hacked to allow for GCC master > being used) and this GCC commit > (2d5c4a16dd833aa083f13dd3e78e3ef38afe6ebb) triggers glibc's > elf/check-

[committed] analyzer: only look for named functions in root ns [PR107788]

2022-11-22 Thread David Malcolm via Gcc-patches
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to trunk as r13-4249-gec7c796de020cb. gcc/analyzer/ChangeLog: PR analyzer/107788 * known-function-manager.cc (known_function_manager::get_match): Don't look up fndecls by name when they're not in the root

[committed] analyzer: fix ICE on 'bind(INT_CST, ...)' [PR107783]

2022-11-22 Thread David Malcolm via Gcc-patches
This was crashing inside fd_phase_mismatch's ctor with assertion failure when the state was "fd-constant". Fix the ICE by not complaining about constants passed to these APIs. Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to trunk as r13-4248-g64fb291c5839e1. gcc/analyzer

[committed] analyzer: fix 'errno' on Solaris and OS X [PR107807]

2022-11-22 Thread David Malcolm via Gcc-patches
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to trunk as r13-4247-g7c9717fcb5cf94. gcc/analyzer/ChangeLog: PR analyzer/107807 * region-model-impl-calls.cc (register_known_functions): Register "___errno" and "__error" as synonyms for "__errno_locati

[committed] analyzer: eliminate region_model::impl_call_* special cases

2022-11-22 Thread David Malcolm via Gcc-patches
Eliminate all of the remaining special cases in class region_model that handle various specific functions, replacing them with uses of known_function subclasses. Add various type-checks that ought to prevent ICEs for cases where functions match the name of a standard C library or POSIX function, b

Re: [PING] [PATCH RESEND] riscv: improve the cost model for loading a 64bit constant in rv32.

2022-11-22 Thread Jeff Law via Gcc-patches
On 11/17/22 00:32, Lin Sinan via Gcc-patches wrote: The motivation of this patch is to correct the wrong estimation of the number of instructions needed for loading a 64bit constant in rv32 in the current cost model(riscv_interger_cost). According to the current implementation, if a constant re

Re: [PATCH] RISC-V: Add the Zihpm and Zicntr extensions

2022-11-22 Thread Palmer Dabbelt
On Tue, 22 Nov 2022 13:50:28 PST (-0800), jeffreya...@gmail.com wrote: On 11/22/22 08:29, Palmer Dabbelt wrote: On Tue, 22 Nov 2022 07:20:15 PST (-0800), jeffreya...@gmail.com wrote: On 11/20/22 18:36, Kito Cheng wrote: So the idea here is just to define the extension so that it gets defined

Re: [PATCH V2] Use subscalar mode to move struct block for parameter

2022-11-22 Thread Jeff Law via Gcc-patches
On 11/20/22 20:07, Jiufu Guo wrote: Jiufu Guo writes: Hi, As mentioned in the previous version patch: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/604646.html The suboptimal code is generated for "assigning from parameter" or "assigning to return value". This patch enhances the as

[PATCH] Fortran: error recovery on associate with bad selector [PR107577]

2022-11-22 Thread Harald Anlauf via Gcc-patches
Dear all, please find attached an obvious patch by Steve for a technical regression that resulted from improvements in error recovery of bad uses of associate. Regtested on x86_64-pc-linux-gnu. Will commit soon unless there are comments. As a sidenote: the testcase shows that we resolve the ass

[committed] libstdc++: Add workaround for fs::path constraint recursion [PR106201]

2022-11-22 Thread Jonathan Wakely via Gcc-patches
Tested x86_64-linux. Pushed to gcc-12 branch. -- >8 -- This works around a compiler bug where overload resolution attempts implicit conversion to path in order to call a function with a path& parameter. Such conversion would produce a prvalue, which would not be able to bind to the lvalue referen

Re: [PATCH] RISC-V: Add the Zihpm and Zicntr extensions

2022-11-22 Thread Jeff Law via Gcc-patches
On 11/22/22 08:29, Palmer Dabbelt wrote: On Tue, 22 Nov 2022 07:20:15 PST (-0800), jeffreya...@gmail.com wrote: On 11/20/22 18:36, Kito Cheng wrote: So the idea here is just to define the extension so that it gets defined in the ISA strings and passed through to the assembler, right? That

RE: [EXTERNAL] Re: [PATCH] Fix autoprofiledbootstrap build

2022-11-22 Thread Eugene Rozenfeld via Gcc-patches
I took another look at this. We actually collect perf data when building the libraries. So, we have ./prev-gcc/perf.data, ./prev-libcpp/perf.data, ./prev-libiberty/perf.data, etc. But when creating gcov data for -fauto-profile build of cc1plus or cc1 we only use ./prev-gcc/perf.data . So, a be

Re: [PATCH v2] tree-object-size: Support strndup and strdup

2022-11-22 Thread Jeff Law via Gcc-patches
On 11/21/22 07:27, Siddhesh Poyarekar wrote: On 2022-11-20 10:42, Jeff Law wrote: On 11/4/22 06:48, Siddhesh Poyarekar wrote: Use string length of input to strdup to determine the usable size of the resulting object.  Avoid doing the same for strndup since there's a chance that the input ma

Re: [PATCH 2/5] c++: Set the locus of the function result decl

2022-11-22 Thread Jason Merrill via Gcc-patches
On 11/20/22 12:06, Bernhard Reutner-Fischer wrote: Hi Jason! The "meh" of result-decl-plugin-test-2.C should likely be omitted, grokdeclarator would need some changes to add richloc hints and we would not be able to make a reliable guess what to remove precisely. C.f. /* Check all other uses of

Re: [PATCH] Fix count comparison in ipa-cp

2022-11-22 Thread Jeff Law via Gcc-patches
On 11/21/22 14:26, Eugene Rozenfeld via Gcc-patches wrote: The existing comparison was incorrect for non-PRECISE counts (e.g., AFDO): we could end up with a 0 base_count, which could lead to asserts, e.g., in good_cloning_opportunity_p. gcc/ChangeLog: * ipa-cp.cc (ipcp_propagate_stag

Re: [PATCH] Fix autoprofiledbootstrap build

2022-11-22 Thread Jeff Law via Gcc-patches
On 11/21/22 14:57, Eugene Rozenfeld via Gcc-patches wrote: 1. Fix gcov version 2. Don't attempt to create an autoprofile file for cc1 since cc1plus (not cc1) is not invoked when building cc1 3. Fix documentation typo Tested on x86_64-pc-linux-gnu. gcc/ChangeLog: * c/Make-lang.in: Don

Re: [PATCH] testsuite: Fix missing EFFECTIVE_TARGETS variable errors

2022-11-22 Thread Maciej W. Rozycki
On Mon, 21 Nov 2022, Jeff Law wrote: > > gcc/testsuite/ > > * lib/target-supports.exp > > (check_effective_target_mpaired_single): Add `args' argument and > > pass it to `check_no_compiler_messages' replacing > > `-mpaired-single'. > > (add_options_for_mips_loongson_mmi): A

[committed] libstdc++: Replace std::isdigit and std::isxdigit in [PR107817]

2022-11-22 Thread Jonathan Wakely via Gcc-patches
Tested x86_64-linux. Pushed to trunk. -- >8 -- These functions aren't usable in constant expressions. Provide our own implementations, based on __from_chars_alnum_to_val from . libstdc++-v3/ChangeLog: PR libstdc++/107817 * include/std/charconv (__from_chars_alnum_to_val): Add

[committed] libstdc++: Add testcase for fs::path constraint recursion [PR106201]

2022-11-22 Thread Jonathan Wakely via Gcc-patches
Tested x86_64-linux. Pushed to trunk. -- >8 -- libstdc++-v3/ChangeLog: PR libstdc++/106201 * testsuite/27_io/filesystem/iterators/106201.cc: New test. --- .../testsuite/27_io/filesystem/iterators/106201.cc | 12 1 file changed, 12 insertions(+) create mode 100644

Re: [PATCH 2/2] Add a new warning option -Wstrict-flex-arrays.

2022-11-22 Thread Kees Cook via Gcc-patches
On Tue, Nov 22, 2022 at 03:02:04PM +, Qing Zhao wrote: > > > > On Nov 22, 2022, at 9:10 AM, Qing Zhao via Gcc-patches > > wrote: > > > > > > > >> On Nov 22, 2022, at 3:16 AM, Richard Biener wrote: > >> > >> On Mon, 21 Nov 2022, Qing Zhao wrote: > >> > >>> > >>> > On Nov 18, 202

RE: [PATCH 35/35] arm: improve tests for vsetq_lane*

2022-11-22 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Andrea Corallo > Sent: Thursday, November 17, 2022 4:38 PM > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; Andrea Corallo > Subject: [PATCH 35/35] arm: improve tests for vsetq_lane* > > gcc/testsuite/ChangeLog: > > * gcc.ta

RE: [PATCH 33/35] arm: improve tests and fix vrmlaldavhaq*

2022-11-22 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Andrea Corallo > Sent: Thursday, November 17, 2022 4:38 PM > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; Andrea Corallo > Subject: [PATCH 33/35] arm: improve tests and fix vrmlaldavhaq* > > gcc/ChangeLog: > > * config/arm

RE: [PATCH 34/35] arm: improve tests for vrshlq*

2022-11-22 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Andrea Corallo > Sent: Thursday, November 17, 2022 4:38 PM > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; Andrea Corallo > Subject: [PATCH 34/35] arm: improve tests for vrshlq* > > gcc/testsuite/ChangeLog: > > * gcc.target

RE: [PATCH 32/35] arm: improve tests for vqsubq*

2022-11-22 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Andrea Corallo > Sent: Thursday, November 17, 2022 4:38 PM > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; Andrea Corallo > Subject: [PATCH 32/35] arm: improve tests for vqsubq* > > gcc/testsuite/ChangeLog: > > * gcc.target

RE: [PATCH 31/35] arm: improve tests for vqrdmlashq_m*

2022-11-22 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Andrea Corallo > Sent: Thursday, November 17, 2022 4:38 PM > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; Andrea Corallo > Subject: [PATCH 31/35] arm: improve tests for vqrdmlashq_m* > > gcc/testsuite/ChangeLog: > > * gcc.

RE: [PATCH 30/35] arm: improve tests for vqrdmlahq*

2022-11-22 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Andrea Corallo > Sent: Thursday, November 17, 2022 4:38 PM > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; Andrea Corallo > Subject: [PATCH 30/35] arm: improve tests for vqrdmlahq* > > gcc/testsuite/ChangeLog: > > * gcc.tar

RE: [PATCH 29/35] arm: improve tests for vqdmul*

2022-11-22 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Andrea Corallo > Sent: Thursday, November 17, 2022 4:38 PM > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; Andrea Corallo > Subject: [PATCH 29/35] arm: improve tests for vqdmul* > > gcc/testsuite/ChangeLog: > > * gcc.target

RE: [PATCH 28/35] arm: improve tests for vqdmlahq_m*

2022-11-22 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Andrea Corallo > Sent: Thursday, November 17, 2022 4:38 PM > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; Andrea Corallo > Subject: [PATCH 28/35] arm: improve tests for vqdmlahq_m* > > gcc/testsuite/ChangeLog: > > * gcc.ta

RE: [PATCH 27/35] arm: improve tests for vqaddq_m*

2022-11-22 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Andrea Corallo > Sent: Thursday, November 17, 2022 4:38 PM > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; Andrea Corallo > Subject: [PATCH 27/35] arm: improve tests for vqaddq_m* > > gcc/testsuite/ChangeLog: > > * gcc.targ

RE: [PATCH 26/35] arm: improve tests for vmlasq*

2022-11-22 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Andrea Corallo > Sent: Thursday, November 17, 2022 4:38 PM > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; Andrea Corallo > Subject: [PATCH 26/35] arm: improve tests for vmlasq* > > gcc/testsuite/ChangeLog: > > * gcc.target

RE: [PATCH 25/35] arm: improve tests and fix vmlaldavaxq*

2022-11-22 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Andrea Corallo > Sent: Thursday, November 17, 2022 4:38 PM > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; Andrea Corallo > Subject: [PATCH 25/35] arm: improve tests and fix vmlaldavaxq* > > gcc/ChangeLog: > > * config/arm/

RE: [PATCH 24/35] arm: improve tests for vmladavaq*

2022-11-22 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Andrea Corallo > Sent: Thursday, November 17, 2022 4:38 PM > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; Andrea Corallo > Subject: [PATCH 24/35] arm: improve tests for vmladavaq* > > gcc/testsuite/ChangeLog: > > * gcc.tar

RE: [PATCH 22/35] arm: improve tests for vhsubq_m*

2022-11-22 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Andrea Corallo > Sent: Thursday, November 17, 2022 4:38 PM > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; Andrea Corallo > Subject: [PATCH 22/35] arm: improve tests for vhsubq_m* > > gcc/testsuite/ChangeLog: > > * gcc.targ

RE: [PATCH 23/35] arm: improve tests for viwdupq*

2022-11-22 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Andrea Corallo > Sent: Thursday, November 17, 2022 4:38 PM > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; Andrea Corallo > Subject: [PATCH 23/35] arm: improve tests for viwdupq* > > gcc/testsuite/ChangeLog: > > * gcc.targe

RE: [PATCH 20/35] arm: improve tests for vfmasq_m*

2022-11-22 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Andrea Corallo > Sent: Thursday, November 17, 2022 4:38 PM > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; Andrea Corallo > Subject: [PATCH 20/35] arm: improve tests for vfmasq_m* > > gcc/testsuite/ChangeLog: > > * gcc.targ

RE: [PATCH 21/35] arm: improve tests for vhaddq_m*

2022-11-22 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Andrea Corallo > Sent: Thursday, November 17, 2022 4:38 PM > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; Andrea Corallo > Subject: [PATCH 21/35] arm: improve tests for vhaddq_m* > > gcc/testsuite/ChangeLog: > > * gcc.targ

RE: [PATCH 19/35] arm: improve tests and fix vsubq*

2022-11-22 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Andrea Corallo > Sent: Thursday, November 17, 2022 4:38 PM > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; Andrea Corallo > Subject: [PATCH 19/35] arm: improve tests and fix vsubq* > > gcc/ChangeLog: > > * config/arm/mve.md

RE: [PATCH 18/35] arm: improve tests for vmulq*

2022-11-22 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Andrea Corallo > Sent: Thursday, November 17, 2022 4:38 PM > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; Andrea Corallo > Subject: [PATCH 18/35] arm: improve tests for vmulq* > > gcc/testsuite/ChangeLog: > > * gcc.target/

RE: [PATCH 17/35] arm: improve tests and fix vadd*

2022-11-22 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Andrea Corallo > Sent: Thursday, November 17, 2022 4:38 PM > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; Andrea Corallo > Subject: [PATCH 17/35] arm: improve tests and fix vadd* > > gcc/ChangeLog: > > * config/arm/mve.md

RE: [PATCH 16/35] arm: Add integer vector overloading of vsubq_x instrinsic

2022-11-22 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Andrea Corallo > Sent: Thursday, November 17, 2022 4:38 PM > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Earnshaw > ; Stam Markianos-Wright wri...@arm.com> > Subject: [PATCH 16/35] arm: Add integer vector overloading of vsubq_x > instrinsic >

Re: [PATCH v4] LoongArch: Optimize immediate load.

2022-11-22 Thread Xi Ruoyao via Gcc-patches
On Tue, 2022-11-22 at 22:03 +0800, Xi Ruoyao via Gcc-patches wrote: > While I still can't fully understand the immediate load issue and how > this patch fix it, I've tested this patch (alongside the prefetch > instruction patch) with bootstrap-ubsan.  And the compiled result of > imm-load1.c seems

Re: [PATCH] aarch64: Fix test_dfp_17.c for big-endian [PR 107604]

2022-11-22 Thread Christophe Lyon via Gcc-patches
On 11/22/22 12:33, Richard Earnshaw wrote: On 22/11/2022 11:21, Richard Sandiford wrote: Richard Earnshaw via Gcc-patches writes: On 22/11/2022 09:01, Christophe Lyon via Gcc-patches wrote: gcc.target/aarch64/aapcs64/test_dfp_17.c has been failing on big-endian, because the _Decimal32 on

Re: PING^2 [PATCH] Adjust the symbol for SECTION_LINK_ORDER linked_to section [PR99889]

2022-11-22 Thread Richard Sandiford via Gcc-patches
"Kewen.Lin" writes: > Hi Richard, > > Many thanks for your review comments! > on 2022/8/24 16:17, Kewen.Lin via Gcc-patches wrote: > Hi, > > As discussed in PR98125, -fpatchable-function-entry with > SECTION_LINK_ORDER support doesn't work well on powerpc64 > ELFv1 because

RE: [PATCH 5/8]AArch64 aarch64: Make existing V2HF be usable.

2022-11-22 Thread Tamar Christina via Gcc-patches
Ping > -Original Message- > From: Gcc-patches bounces+tamar.christina=arm@gcc.gnu.org> On Behalf Of Tamar > Christina via Gcc-patches > Sent: Friday, November 11, 2022 2:40 PM > To: Richard Sandiford > Cc: gcc-patches@gcc.gnu.org; nd ; Richard Earnshaw > ; Marcus Shawcroft > ; Kyrylo

Re: [PATCH] RISC-V: Add the Zihpm and Zicntr extensions

2022-11-22 Thread Palmer Dabbelt
On Tue, 22 Nov 2022 07:20:15 PST (-0800), jeffreya...@gmail.com wrote: On 11/20/22 18:36, Kito Cheng wrote: So the idea here is just to define the extension so that it gets defined in the ISA strings and passed through to the assembler, right? That will also define arch test marco: https://gi

Re: [PATCH] RISC-V: Add the Zihpm and Zicntr extensions

2022-11-22 Thread Jeff Law via Gcc-patches
On 11/20/22 18:36, Kito Cheng wrote: So the idea here is just to define the extension so that it gets defined in the ISA strings and passed through to the assembler, right? That will also define arch test marco: https://github.com/riscv-non-isa/riscv-c-api-doc/blob/master/riscv-c-api.md#archi

Re: [PATCH] c++: Fix up -fcontract* options

2022-11-22 Thread Jason Merrill via Gcc-patches
On 11/21/22 18:00, Jakub Jelinek wrote: Hi! I've noticed +FAIL: compiler driver --help=c++ option(s): "^ +-.*[^:.]\$" absent from output: " -fcontract-build-level=[off|default|audit] Specify max contract level to generate runtime checks for" error, this is due to missing dot at the end of the

Re: [PATCH 2/2] Add a new warning option -Wstrict-flex-arrays.

2022-11-22 Thread Qing Zhao via Gcc-patches
> On Nov 22, 2022, at 9:10 AM, Qing Zhao via Gcc-patches > wrote: > > > >> On Nov 22, 2022, at 3:16 AM, Richard Biener wrote: >> >> On Mon, 21 Nov 2022, Qing Zhao wrote: >> >>> >>> On Nov 18, 2022, at 11:31 AM, Kees Cook wrote: On Fri, Nov 18, 2022 at 03:19:07PM +,

Re: [PATCH] 8/19 modula2 front end: libgm2 contents

2022-11-22 Thread Gaius Mulley via Gcc-patches
Richard Biener writes: > On Mon, Oct 10, 2022 at 5:35 PM Gaius Mulley via Gcc-patches > wrote: >> >> >> >> This patch set consists of the libgm2 makefile, autoconf sources >> necessary to build the libm2pim, libm2iso, libm2min, libm2cor >> and libm2log. > > This looks OK. Thanks! > I suppose i

Re: [PATCH 1/8]middle-end: Recognize scalar reductions from bitfields and array_refs

2022-11-22 Thread Jeff Law via Gcc-patches
On 11/22/22 04:08, Richard Biener via Gcc-patches wrote: On Tue, 22 Nov 2022, Richard Sandiford wrote: Tamar Christina writes: -Original Message- From: Richard Biener Sent: Tuesday, November 22, 2022 10:59 AM To: Richard Sandiford Cc: Tamar Christina via Gcc-patches ; Tamar Christ

[pushed] c++: don't use strchrnul [PR107781]

2022-11-22 Thread Jason Merrill via Gcc-patches
As Jonathan suggested. Tested x86_64-pc-linux-gnu, applying to trunk. -- 8< -- The contracts implementation was using strchrnul, which is a glibc extension, so bootstrap broke on non-glibc targets. Use C89 strcspn instead. PR c++/107781 gcc/cp/ChangeLog: * contracts.cc (role_

Re: [PATCH] ipa-cp: Do not be too optimistic about self-recursive edges (PR 107661)

2022-11-22 Thread Jan Hubicka via Gcc-patches
> Hi, > > PR 107661 shows that function push_agg_values_for_index_from_edge > should not attempt to optimize self-recursive call graph edges when > called from cgraph_edge_brings_all_agg_vals_for_node. Unlike when > being called from find_aggregate_values_for_callers_subset, we cannot > expect th

Re: [PATCH] AArch64: Add fma_reassoc_width [PR107413]

2022-11-22 Thread Richard Sandiford via Gcc-patches
Wilco Dijkstra writes: > Hi Richard, > >> I guess an obvious question is: if 1 (rather than 2) was the right value >> for cores with 2 FMA pipes, why is 4 the right value for cores with 4 FMA >> pipes? It would be good to clarify how, conceptually, the core property >> should map to the fma_reass

[PATCH] ipa-cp: Do not be too optimistic about self-recursive edges (PR 107661)

2022-11-22 Thread Martin Jambor
Hi, PR 107661 shows that function push_agg_values_for_index_from_edge should not attempt to optimize self-recursive call graph edges when called from cgraph_edge_brings_all_agg_vals_for_node. Unlike when being called from find_aggregate_values_for_callers_subset, we cannot expect that any cloning

Re: [PATCH 2/2] Add a new warning option -Wstrict-flex-arrays.

2022-11-22 Thread Qing Zhao via Gcc-patches
> On Nov 22, 2022, at 3:16 AM, Richard Biener wrote: > > On Mon, 21 Nov 2022, Qing Zhao wrote: > >> >> >>> On Nov 18, 2022, at 11:31 AM, Kees Cook wrote: >>> >>> On Fri, Nov 18, 2022 at 03:19:07PM +, Qing Zhao wrote: Hi, Richard, Honestly, it?s very hard for me to deci

Re: [PATCH v4] LoongArch: Optimize immediate load.

2022-11-22 Thread Xi Ruoyao via Gcc-patches
While I still can't fully understand the immediate load issue and how this patch fix it, I've tested this patch (alongside the prefetch instruction patch) with bootstrap-ubsan. And the compiled result of imm-load1.c seems OK. On Thu, 2022-11-17 at 17:59 +0800, Lulu Cheng wrote: > v1 -> v2: > 1. C

Re: [PATCH] aarch64: Fix test_dfp_17.c for big-endian [PR 107604]

2022-11-22 Thread Richard Earnshaw via Gcc-patches
On 22/11/2022 13:09, Christophe Lyon wrote: On 11/22/22 12:33, Richard Earnshaw wrote: On 22/11/2022 11:21, Richard Sandiford wrote: Richard Earnshaw via Gcc-patches writes: On 22/11/2022 09:01, Christophe Lyon via Gcc-patches wrote: gcc.target/aarch64/aapcs64/test_dfp_17.c has been fa

Re: [PATCH 2/2]AArch64 Support new tbranch optab.

2022-11-22 Thread Richard Sandiford via Gcc-patches
Tamar Christina writes: >> -Original Message- >> From: Richard Sandiford >> Sent: Tuesday, November 15, 2022 11:34 AM >> To: Tamar Christina >> Cc: gcc-patches@gcc.gnu.org; Richard Earnshaw >> ; nd ; Marcus Shawcroft >> >> Subject: Re: [PATCH 2/2]AArch64 Support new tbranch optab. >> >

[PATCH] Remove follow_assert_exprs from overflow_comparison.

2022-11-22 Thread Aldy Hernandez via Gcc-patches
OK pending tests? gcc/ChangeLog: * tree-vrp.cc (overflow_comparison_p_1): Remove follow_assert_exprs. (overflow_comparison_p): Remove use_equiv_p. * tree-vrp.h (overflow_comparison_p): Same. * vr-values.cc (vrp_evaluate_conditional_warnv_with_ops): Remove u

[PATCH] Remove use_equiv_p in vr-values.cc

2022-11-22 Thread Aldy Hernandez via Gcc-patches
With no equivalences, the use_equiv_p argument in various methods in simplify_using_ranges is always false. This means we can remove all calls to compare_names, along with the function. OK pending tests? gcc/ChangeLog: * vr-values.cc (simplify_using_ranges::compare_names): Remove.

[PATCH] Remove ASSERT_EXPR.

2022-11-22 Thread Aldy Hernandez via Gcc-patches
This removes all uses of ASSERT_EXPR except the internal one in ipa-*. OK pending tests? gcc/ChangeLog: * doc/gimple.texi: Remove ASSERT_EXPR references. * fold-const.cc (tree_expr_nonzero_warnv_p): Same. (fold_binary_loc): Same. (tree_expr_nonnegative_warnv_p): S

RE: [PATCH 2/2]AArch64 Support new tbranch optab.

2022-11-22 Thread Tamar Christina via Gcc-patches
> -Original Message- > From: Richard Sandiford > Sent: Tuesday, November 15, 2022 11:34 AM > To: Tamar Christina > Cc: gcc-patches@gcc.gnu.org; Richard Earnshaw > ; nd ; Marcus Shawcroft > > Subject: Re: [PATCH 2/2]AArch64 Support new tbranch optab. > > Tamar Christina writes: > >> ---

Re: [PATCH 2/2] Fortran: add attribute target_clones

2022-11-22 Thread Mikael Morin
Le 21/11/2022 à 23:26, Bernhard Reutner-Fischer a écrit : On Mon, 21 Nov 2022 20:13:40 +0100 Mikael Morin wrote: Hello, Le 09/11/2022 à 20:02, Bernhard Reutner-Fischer via Fortran a écrit : Hi! (...) + if (allow_multiple && gfc_match_char (')') != MATCH_YES) +{ + gfc_error ("exp

Re: [PATCH] aarch64: Fix test_dfp_17.c for big-endian [PR 107604]

2022-11-22 Thread Christophe Lyon via Gcc-patches
On 11/22/22 12:33, Richard Earnshaw wrote: On 22/11/2022 11:21, Richard Sandiford wrote: Richard Earnshaw via Gcc-patches writes: On 22/11/2022 09:01, Christophe Lyon via Gcc-patches wrote: gcc.target/aarch64/aapcs64/test_dfp_17.c has been failing on big-endian, because the _Decimal32 on

Re: [PATCH] d: respect --enable-link-mutex configure option

2022-11-22 Thread Iain Buclaw via Gcc-patches
Excerpts from Martin Liška's message of November 22, 2022 10:41 am: > I noticed the option is ignored because @DO_LINK_MUTEX@ > is not defined in d/Make-lang.in. > > Tested locally before and after the patch. > > Ready to be installed? > Thanks, > Martin > Fine on my end. Thanks! Iain.

[COMMITTED] ada: Accept aspects Global and Depends on abstract subprograms

2022-11-22 Thread Marc Poulhiès via Gcc-patches
From: Piotr Trojanek Aspects Global and Depends are now allowed on abstract subprograms (as substitutes for Global'Class and Depends'Class). This patch implements the recently modified rules SPARK RM 6.1.2(2-3). The behavior for Contract_Cases and aspects on null subprograms stays as it was. gc

[COMMITTED] ada: Disable checking of Elab_Spec procedures in CodePeer_Mode

2022-11-22 Thread Marc Poulhiès via Gcc-patches
From: Ghjuvan Lacambre This commit re-enables the Validate_Subprogram_Calls check that had been disabled in a previous commit and has said check skip over Elab_Spec procedures in CodePeer_Mode. gcc/ada/ * frontend.adb (Frontend): Re-enable Validate_Subprogram_Calls. * exp_ch6.ad

[COMMITTED] ada: Adjust number of errors when removing warning in dead code

2022-11-22 Thread Marc Poulhiès via Gcc-patches
From: Piotr Trojanek When a warning about a runtime exception is emitted for a code in generic instance, we add continuation warnings "in instantiation ..." and only the original message increase the total number of errors. When removing these messages, e.g. after detecting that the code inside

[COMMITTED] ada: Fix formatting glitches in Make_Tag_Assignment

2022-11-22 Thread Marc Poulhiès via Gcc-patches
From: Eric Botcazou gcc/ada/ * exp_ch3.adb (Make_Tag_Assignment): Fix formatting glitches. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/exp_ch3.adb | 40 +--- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/gcc/ada

[COMMITTED] ada: Fix recent assertion failure on GPR2

2022-11-22 Thread Marc Poulhiès via Gcc-patches
From: Eric Botcazou It's the compiler trying to load the nonexistent body of a generic package when trying to inline a call to an expression function of this package that has a pre or post-condition (hence the need for -gnata to trigger the ICE). gcc/ada/ * contracts.adb (Build_Subprogr

[PATCH] c: Propagate erroneous types to declaration specifiers [PR107805]

2022-11-22 Thread Florian Weimer via Gcc-patches
Without this change, finish_declspecs cannot tell that whether there was an erroneous type specified, or no type at all. This may result in additional diagnostics for implicit ints, or missing diagnostics for multiple types. PR c/107805 gcc/c/ * c-decl.cc (declspecs_add_type): Pr

Re: [PATCH] maintainer-scripts/gcc_release: compress xz in parallel

2022-11-22 Thread Richard Sandiford via Gcc-patches
Sam James via Gcc-patches writes: >> On 8 Nov 2022, at 07:14, Sam James wrote: >> >> 1. This should speed up decompression for folks, as parallel xz >> creates a different archive which can be decompressed in parallel. >> >> Note that this different method is enabled by default in a new >>

Re: [PATCH 1/2] symtab: also change RTL decl name

2022-11-22 Thread Jan Hubicka via Gcc-patches
> On Mon, 21 Nov 2022 20:02:49 +0100 > Jan Hubicka wrote: > > > > Hi Honza, Ping. > > > Regtests cleanly for c,fortran,c++,ada,d,go,lto,objc,obj-c++ > > > Ok? > > > I'd need this for attribute target_clones for the Fortran FE. > > Sorry for delay here. > > > > void > > > > @@ -303,6 +301,10 @@

Re: [PATCH 1/2] Fortran: Cleanup struct ext_attr_t

2022-11-22 Thread Mikael Morin
Le 21/11/2022 à 21:34, Bernhard Reutner-Fischer a écrit : On Mon, 21 Nov 2022 12:08:20 +0100 Mikael Morin wrote: * gfortran.h (struct ext_attr_t): Remove middle_end_name. * trans-decl.cc (add_attributes_to_decl): Move building tree_list to ... * decl.cc (gfc_mat

Re: [PATCH] aarch64: Fix test_dfp_17.c for big-endian [PR 107604]

2022-11-22 Thread Richard Earnshaw via Gcc-patches
On 22/11/2022 11:21, Richard Sandiford wrote: Richard Earnshaw via Gcc-patches writes: On 22/11/2022 09:01, Christophe Lyon via Gcc-patches wrote: gcc.target/aarch64/aapcs64/test_dfp_17.c has been failing on big-endian, because the _Decimal32 on-stack argument is not padded in the same dire

Re: [PATCH] Fix wrong array type conversion with different storage order

2022-11-22 Thread Richard Biener via Gcc-patches
On Tue, Nov 22, 2022 at 12:06 PM Eric Botcazou via Gcc-patches wrote: > > Hi, > > when two arrays of scalars have a different storage order in Ada, the > front-end makes sure that the conversion is performed component-wise > so that each component can be reversed. So it's a little bit counter > p

Re: [PATCH] aarch64: Fix test_dfp_17.c for big-endian [PR 107604]

2022-11-22 Thread Richard Sandiford via Gcc-patches
Richard Earnshaw via Gcc-patches writes: > On 22/11/2022 09:01, Christophe Lyon via Gcc-patches wrote: >> gcc.target/aarch64/aapcs64/test_dfp_17.c has been failing on >> big-endian, because the _Decimal32 on-stack argument is not padded in >> the same direction depending on endianness. >> >> This

Re: [PATCH RFA(configure)] c++: provide strchrnul on targets without it [PR107781]

2022-11-22 Thread Jakub Jelinek via Gcc-patches
On Tue, Nov 22, 2022 at 09:41:24AM +0100, Jakub Jelinek via Gcc-patches wrote: > On Mon, Nov 21, 2022 at 06:31:47PM -0500, Jason Merrill via Gcc-patches wrote: > > Tested x86_64-pc-linux-gnu, and also manually changing the > > HAVE_DECL_STRCHRNUL > > flag. OK for trunk? > > > > -- 8< -- > > > >

Re: [PATCH] aarch64: Fix test_dfp_17.c for big-endian [PR 107604]

2022-11-22 Thread Richard Earnshaw via Gcc-patches
On 22/11/2022 09:01, Christophe Lyon via Gcc-patches wrote: gcc.target/aarch64/aapcs64/test_dfp_17.c has been failing on big-endian, because the _Decimal32 on-stack argument is not padded in the same direction depending on endianness. This patch fixes the testcase so that it expects the argum

Re: [PATCH 1/8]middle-end: Recognize scalar reductions from bitfields and array_refs

2022-11-22 Thread Richard Biener via Gcc-patches
On Tue, 22 Nov 2022, Richard Sandiford wrote: > Tamar Christina writes: > >> -Original Message- > >> From: Richard Biener > >> Sent: Tuesday, November 22, 2022 10:59 AM > >> To: Richard Sandiford > >> Cc: Tamar Christina via Gcc-patches ; Tamar > >> Christina ; Richard Biener > >> ; nd

  1   2   >