Re: [gem5-dev] Review Request 2619: cpu: Add L-TAGE branch predictor

On Fri, 6 Mar 2015, Dibakar Gope wrote: On March 4, 2015, 6:54 p.m., Nilay Vaish wrote: OK. I am sorry for not realizing that so many changes would be required to separate out the params just meant for LTAGE. Had I had realized that, I probably would not have asked for it. I think we sho

Re: [gem5-dev] Review Request 2680: cpu: o3: record cpi stacks

On Wed, 4 Mar 2015, Andreas Hansson wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2680/#review5937 --- Should this perhaps be a pr

Re: [gem5-dev] Review Request 2619: cpu: Add L-TAGE branch predictor

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2619/#review5938 --- OK. I am sorry for not realizing that so many changes would be required

[gem5-dev] Review Request 2680: cpu: o3: record cpi stacks

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2680/ --- Review request for Default. Repository: gem5 Description --- Changeset 10735

[gem5-dev] Review Request 2679: cpu: o3: another assert instead of check

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2679/ --- Review request for Default. Repository: gem5 Description --- Changeset 10734

Re: [gem5-dev] Review Request 2619: cpu: Add L-TAGE branch predictor

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2619/#review5936 --- Several lines seem to have more than 80 characters. src/cpu/pred/Branch

[gem5-dev] Review Request 2678: cpu: o3: Remove unused code in iew, add assert instead.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2678/ --- Review request for Default. Repository: gem5 Description --- Changeset 10733

Re: [gem5-dev] Configuration GUI for gem5

So what does the GUI do? Can you drag and drop different components and then connect as required? Or is it that you can just set values for different variables? Can you provide some screen shots? -- Nilay On Tue, 3 Mar 2015, Marcus Johnson via gem5-dev wrote: Hi, I am a senior at Colorado

Re: [gem5-dev] Review Request 2655: config: Fix for 'android' lookup in disk name

I'll push it along with my own patches. -- Nilay On Mon, 2 Mar 2015, Andreas Hansson via gem5-dev wrote: On Feb. 19, 2015, 10:50 p.m., Andreas Hansson wrote: Ship It! Could someone be kind enough to push this? - Andreas --- Thi

Re: [gem5-dev] Review Request 2619: cpu: Add L-TAGE branch predictor

> On Feb. 3, 2015, 9:37 a.m., Andreas Hansson wrote: > > Something is still not quite right with the diffs. > > Dibakar Gope wrote: > I was not using the reviewboard extension. I will re-upload that patch > through mercurial patchqueues soon. Sorry for the slow response. The problem still

[gem5-dev] Review Request 2677: cpu: o3: commit: mark pipeline delay variable as consts

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2677/ --- Review request for Default. Repository: gem5 Description --- Changeset 10713

[gem5-dev] Review Request 2676: cpu: o3: remove unused stat variables.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2676/ --- Review request for Default. Repository: gem5 Description --- Changeset 10712

[gem5-dev] Review Request 2675: cpu: o3: combine if with same condition

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2675/ --- Review request for Default. Repository: gem5 Description --- Changeset 10711

[gem5-dev] Review Request 2674: cpu: o3: remove member variable squashCounter

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2674/ --- Review request for Default. Repository: gem5 Description --- Changeset 10709

[gem5-dev] Review Request 2673: cpu: o3: remove unused function annotateMemoryUnits()

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2673/ --- Review request for Default. Repository: gem5 Description --- Changeset 10708

[gem5-dev] Review Request 2672: x86: implements x87 mult/div instructions

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2672/ --- Review request for Default. Repository: gem5 Description --- Changeset 10707

Re: [gem5-dev] Review Request 2611: cpu: Tidy up the MemTest and make false sharing more obvious

On Sun, 1 Feb 2015, Andreas Hansson wrote: Hi Nilay, I think the “DMA” bit of this tester was broken and rather pointless. In essence the MemTest is only fit for testing false sharing, and that is what it now does. I do not quite understand what a DMA has to do with any of that. Separately we

Re: [gem5-dev] Review Request 2611: cpu: Tidy up the MemTest and make false sharing more obvious

On Sat, 31 Jan 2015, Andreas Hansson wrote: On Jan. 30, 2015, 9:47 p.m., Nilay Vaish wrote: src/cpu/testers/memtest/MemTest.py, line 55 Are you sure this should be dropped? I think the coherence protocols that provide

Re: [gem5-dev] Review Request 2611: cpu: Tidy up the MemTest and make false sharing more obvious

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2611/#review5809 --- src/cpu/testers/memtest/MemTest.py

Re: [gem5-dev] Uncachable memory requests in Ruby

Mohammad, how long does it take for your simulation to hit this problem? If it takes about 10 minutes, I suggest that you come over to the CS building so that I can take a look at your setup. -- Nilay On Sat, 24 Jan 2015, Mohammad Alian wrote: After digging into the issue, I found out that r

Re: [gem5-dev] X86 regression failures

On Fri, 16 Jan 2015, mike upton via gem5-dev wrote: I was trying to run a regression, I am still learning. This is off of a clean build of the top of tree: hg clone http://repo.gem5.org/gem5 I ran: util/regress -j4 --builds X86 and I get a number of failures. * build/X86/tests/opt/qu

[gem5-dev] changeset in gem5: stats: changes due to recent changesets.

changeset cd95d4d51659 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=cd95d4d51659 description: stats: changes due to recent changesets. diffstat: tests/long/fs/10.linux-boot/ref/x86/linux/pc-o3-timing/stats.txt | 2463 +++--- tests/long/

Re: [gem5-dev] Review Request 2600: cpu: fix RetiredStores probe point

On Thu, 8 Jan 2015, Andreas Hansson via gem5-dev wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2600/#review5746 --- Ship it! Nila

Re: [gem5-dev] testing/regression update ETA?

On Tue, 6 Jan 2015, mike upton via gem5-dev wrote: Hi, I believe Ali had a proposal for an update to the testing/regression infrastructure. Is there an ETA for that? I would like to automate testing and regressions across a bunch of ISAs. I have available compute resources, but need some hand

[gem5-dev] changeset in gem5: stats: changes due to recent changesets.

changeset 9ac724889705 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=9ac724889705 description: stats: changes due to recent changesets. diffstat: tests/long/fs/10.linux-boot/ref/alpha/linux/tsunami-minor/config.ini | 4 + tests/long/fs/10

[gem5-dev] changeset in gem5: configs: ruby: removes bug introduced by 05b5...

changeset 64618b7c57b2 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=64618b7c57b2 description: configs: ruby: removes bug introduced by 05b5a6cf3521 diffstat: configs/ruby/Ruby.py | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diffs (24 lines)

Re: [gem5-dev] Review Request 2553: dev: Prevent intel 8254 timer events firing before startup

> On Dec. 5, 2014, 11:45 a.m., Andreas Hansson wrote: > > Look good to me. Do the regressions still pass? > > Cagdas Dirik wrote: > I ran the same tests as I mentioned in r/2545. Please let me know if I > need to test more. > > Cagdas Dirik wrote: > This very likely needs updates simil

Re: [gem5-dev] Review Request 2548: arm: Add unlinkat syscall implementation

Would do it sometime this week. I also need to take a look if there are requests from other users. -- Nilay On Mon, 29 Dec 2014, Andreas Hansson via gem5-dev wrote: On Dec. 5, 2014, 5:45 p.m., Steve Reinhardt wrote: Ship It! mike upton wrote: Is there something blocking this chang

Re: [gem5-dev] Update gem5-stable

I have updated gem5-stable to the version mentioned below. -- Nilay On Thu, 4 Dec 2014, Nilay Vaish wrote: Hello everyone Nearly four months have passed since we updated gem5-stable. I am planning to move it forward on 15th December. The changeset I have on my mind is: changeset: 10436

[gem5-dev] changeset in gem5: Added tag stable_2014_12_14 for changeset bdb...

changeset a0cb57e1c072 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=a0cb57e1c072 description: Added tag stable_2014_12_14 for changeset bdb307e8be54 diffstat: .hgtags | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diffs (8 lines): diff -r 8fc6e7a835d1

Re: [gem5-dev] Review Request 2549: ruby: ruby port: do not check for blocked ports

On Tue, 9 Dec 2014, Brad Beckmann wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2549/#review5657 --- src/mem/ruby/system/RubyPort

Re: [gem5-dev] Review Request 2549: ruby: ruby port: do not check for blocked ports

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2549/ --- (Updated Dec. 9, 2014, 3:15 p.m.) Review request for Default. Summary (updated) -

Re: [gem5-dev] x86 SE kvm functionality (AMD vs Intel)

I also faced problem in getting KVM CPU to run in FS mode. I figured that the following changeset causes problems: author Alexandru Dutu Sun Nov 23 18:01:08 2014 -0800 (2 weeks ago) changeset 10554 fe2e2f06a7c8 I saw the hardware reason 0x8021, but did not try to figure what was

Re: [gem5-dev] KVM CPU when using multiple cores

On Thu, Dec 4, 2014 at 10:03 AM, Andreas Sandberg via gem5-dev < gem5-dev@gem5.org> wrote: On 04/12/14 16:10, Nilay Vaish via gem5-dev wrote: I have been trying to run ht kvm cpu when using multiple cores. With single threaded simulation, the simulation stops making progress if the sim

Re: [gem5-dev] how to post diff files on review board

I think the problem you are experiencing happens when reviewboard is unable to figure out the version of the repo on which to apply your patch. Initially I also used to use the web interface posting reviews. But now I use the reviewboard extension of mercurial. I find it less error prone. Fo

[gem5-dev] Review Request 2551: ruby: slicc: have a static MachineType

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2551/ --- Review request for Default. Repository: gem5 Description --- Changeset 10594

[gem5-dev] Review Request 2550: ruby: slicc: remove support for single machine, multiple types

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2550/ --- Review request for Default. Repository: gem5 Description --- Changeset 10593

[gem5-dev] Update gem5-stable

Hello everyone Nearly four months have passed since we updated gem5-stable. I am planning to move it forward on 15th December. The changeset I have on my mind is: changeset: 10436:bdb307e8be54 user:Andrew Lukefahr date:Sat Oct 11 15:02:22 2014 -0500 summary: sim: drai

Re: [gem5-dev] Protocol Specific Profiling

I am beginning work on this now. On Wed, 3 Dec 2014, Beckmann, Brad wrote: Thanks Nilay for the response. I like the idea of statically defining MachineType and all the associated helper functions. Let's plan on doing that. Brad -Original Message- From: Nilay Vaish [mailto:ni...@

[gem5-dev] KVM CPU when using multiple cores

I have been trying to run ht kvm cpu when using multiple cores. With single threaded simulation, the simulation stops making progress if the simulated system has more than 4 cores. With multi-threaded simulation, I do not see any progress even when two cores are being simulated. For the mult

[gem5-dev] Review Request 2549: ruby: do not try to issue request if port blocked

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2549/ --- Review request for Default. Repository: gem5 Description --- Changeset 10592

Re: [gem5-dev] Review Request 2276: ruby: don't make O3 CPU squash on loads that hit outstanding requests

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2276/#review5621 --- Steve, is it all right to buffer requests in the Sequencer? I am not eve

Re: [gem5-dev] Review Request 2505: arch: Allow named constants as decode case values.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2505/#review5620 --- Ship it! Ship It! - Nilay Vaish On Dec. 3, 2014, 11:56 a.m., Gabe Bla

Re: [gem5-dev] Review Request 2506: x86: Rework opcode parsing to support 3 byte opcodes properly.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2506/#review5619 --- Ship it! Ship It! - Nilay Vaish On Nov. 17, 2014, 6:57 a.m., Gabe Bla

Re: [gem5-dev] Review Request 2548: arm: Add unlinkat syscall implementation

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2548/#review5618 --- src/sim/syscall_emul.hh

Re: [gem5-dev] Review Request 2524: config: Add two options for setting the kernel command line.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2524/#review5617 --- Ship it! Ship It! - Nilay Vaish On Nov. 23, 2014, 7:26 a.m., Gabe Bla

[gem5-dev] changeset in gem5: config: ruby: mi protocol: correct master sla...

changeset fea29fc045ee in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=fea29fc045ee description: config: ruby: mi protocol: correct master slave setting for dma In the MI protocol, the master slave connection between the dma controller and network was

Re: [gem5-dev] Protocol Specific Profiling

On Wed, 3 Dec 2014, Beckmann, Brad wrote: I have more questions/issues on this topic of protocol specific profiling. I do not believe this issues should be fixed by having SLICC understand more STL types. I should have pointed out before that many times it is not one specific protocol that n

Re: [gem5-dev] changeset in gem5: ruby: slicc: change the way configurable memb...

On Tue, 2 Dec 2014, Beckmann, Brad wrote: Hi Nilay, Could you explain the motivation behind this change? What was wrong with the previous notation that data member declarations are separated by commas rather than semi-colons? I think in most places in SLICC we use comma to separate the att

Re: [gem5-dev] Review Request 2541: sim: Make it possible to override the breakpoint length check.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2541/#review5605 --- Ship it! Ship It! - Nilay Vaish On Nov. 25, 2014, 11:47 a.m., Gabe Bl

Re: [gem5-dev] Review Request 2538: misc: Make the GDB register cache accessible in various sized chunks.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2538/#review5604 --- Ship it! Seems fine other than the one comment I have made below. src/

Re: [gem5-dev] Review Request 2528: config: make M5_PATH a real search path

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2528/#review5603 --- Ship it! Ship It! - Nilay Vaish On Nov. 24, 2014, 2:48 a.m., Steve Re

Re: [gem5-dev] Review Request 2524: config: Add two options for setting the kernel command line.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2524/#review5591 --- I do not see much value though, but I am fine with patch. configs/commo

Re: [gem5-dev] Issue with O3 and interrupts

s new instruction at the end. This way I made it work, its a bit hacky solution so there might be some other elegant ways to solve this issue. Hope this can be helpful. Best regards. ________ De: gem5-dev [gem5-dev-boun...@gem5.org] en nombre de Nilay Vaish via gem5-d

Re: [gem5-dev] Review Request 2522: ide: Accept the IDLE (0xe3) ATA command.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2522/#review5590 --- Ship it! dev: ide: in the summary line. - Nilay Vaish On Nov. 22, 201

Re: [gem5-dev] Patches ready to go

On Sat, 29 Nov 2014, Nilay Vaish wrote: The problem is that Andreas has not added a new mem-type to configs/common/MemConfig.py. There should be a GDDR5 entry in the memory aliases map. Joel, add one yourself and provide the added type with --mem-type option. I think everything would work o

Re: [gem5-dev] Patches ready to go

The problem is that Andreas has not added a new mem-type to configs/common/MemConfig.py. There should be a GDDR5 entry in the memory aliases map. Joel, add one yourself and provide the added type with --mem-type option. I think everything would work out fine. -- Nilay On Sat, 29 Nov 2014,

Re: [gem5-dev] Review Request 2503: config: SystemC Gem5Control top level additions

On Tue, 25 Nov 2014, Andreas Hansson wrote: On Nov. 25, 2014, 9:52 p.m., Nilay Vaish wrote: I don't know what are we trying to achieve by interfacing gem5 and SystemC. But the patch seems fine to me. I would think roughly 90% of all the SoC model components in the world are written usin

Re: [gem5-dev] Issue with O3 and interrupts

Ok, I have not seen this problem, but I got the description below. So what's your suggestion on fixing the problem? Should we add a stack of pending interrupts instead of maintaining one single variable? -- Nilay On Wed, 26 Nov 2014, Castillo Villar, Emilio via gem5-dev wrote: Good evening

Re: [gem5-dev] ELF image loader in x86 multiboot

A couple of things that might help. First, I think x86 32-bit support is only available in system call emulation mode. For 32-bit x86 full system, you probably will have to make significant changes to gem5. Second, since you are not able to boot a single kernel, I don't see the point of going

Re: [gem5-dev] Review Request 2523: config: Get rid of some extra spaces around default arguments.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2523/#review5549 --- Ship it! Ship It! - Nilay Vaish On Nov. 23, 2014, 7:25 a.m., Gabe Bla

Re: [gem5-dev] Review Request 2521: ps2: Support translating left and right ALT keys.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2521/#review5548 --- Ship it! Ship It! - Nilay Vaish On Nov. 22, 2014, 1:36 p.m., Gabe Bla

Re: [gem5-dev] Review Request 2519: x86: i8042: Give the keyboard controller a little TLC.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2519/#review5547 --- What's TLC and CL? - Nilay Vaish On Nov. 22, 2014, 1:32 p.m., Gabe Bla

Re: [gem5-dev] Review Request 2520: x86: i8042: Add VNC keyboard input support.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2520/#review5545 --- Ship it! Seems fine. - Nilay Vaish On Nov. 22, 2014, 1:32 p.m., Gabe

Re: [gem5-dev] Review Request 2519: x86: i8042: Give the keyboard controller a little TLC.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2519/#review5544 --- src/dev/x86/i8042.cc

Re: [gem5-dev] Review Request 2517: x86: vnc: Add a VNC server to x86 systems.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2517/#review5543 --- Ship it! Ship It! - Nilay Vaish On Nov. 22, 2014, 11:39 a.m., Gabe Bl

Re: [gem5-dev] Review Request 2499: mem: Clean up packet data allocation

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2499/#review5540 --- src/mem/packet.hh We

Re: [gem5-dev] Review Request 2516: config: Add options to take/resume from SimPoint checkpoints

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2516/#review5539 --- I suggest the additions being made to the Simulation.py file be made by

Re: [gem5-dev] Review Request 2503: config: SystemC Gem5Control top level additions

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2503/#review5538 --- Ship it! I don't know what are we trying to achieve by interfacing gem5

Re: [gem5-dev] Review Request 2495: mem: Add checks and explanation for assertMemInhibit usage

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2495/#review5537 --- src/mem/packet.hh I s

Re: [gem5-dev] Review Request 2494: mem: Assume all dynamic packet data is array allocated

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2494/#review5536 --- Ship it! Ship It! - Nilay Vaish On Nov. 17, 2014, 6:14 a.m., Andreas

Re: [gem5-dev] Protocol Specific Profiling

On Tue, 25 Nov 2014, Beckmann, Brad wrote: Thanks Nilay for the prompt reply. An example of a protocol specific statistic would be if say in a region coherence protocol [Power et al.], I was profiling the latencies of downgrade request-acks and I wanted to do that for the cross-product of req

Re: [gem5-dev] Protocol Specific Profiling

On Mon, 24 Nov 2014, Beckmann, Brad wrote: Hi Nilay, On July 24, 2013 you removed the RubySlice_Profiler.sm, RubySlicc_Profiler_interface.cc and RubySlicc_Profiler_interface.hh files. See changeset 9771:57aac1719f86. By removing those files, you removed the ability to provide protocol spec

Re: [gem5-dev] Review Request 2527: config: ruby: Get rid of an "eval" and an "exec" operating on generated code.

On Sun, 23 Nov 2014, Andreas Hansson via gem5-dev wrote: Hi all, I strongly suggest to not go beyond 2.6 at the moment. All Ubuntu 12.04 machines and RHE6 machines have 2.6 as their default, and that matches with our previous assumptions also regarding gcc etc. I agree with Steve that we ca

Re: [gem5-dev] Review Request 2502: cpu, o3: Ignored invalidate causing same-address load reordering

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2502/#review5523 --- In the last paragraph for the commit message, you metion "second load".

Re: [gem5-dev] Review Request 2501: cpu: Move the packet deallocations out in the O3 CPU

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2501/#review5522 --- Ship it! I don't think "out in" is correct usage. - Nilay Vaish On No

Re: [gem5-dev] Review Request 2527: config: ruby: Get rid of an "eval" and an "exec" operating on generated code.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2527/#review5521 --- Ship it! Ship It! - Nilay Vaish On Nov. 23, 2014, 11:03 a.m., Gabe Bl

Re: [gem5-dev] Review Request 2500: mem: Relax packet src/dest check and shift onus to crossbar

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2500/#review5508 --- Ship it! Ship It! - Nilay Vaish On Nov. 17, 2014, 6:17 a.m., Andreas

Re: [gem5-dev] Review Request 2498: mem: Cleanup Packet::checkFunctional and hasData usage

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2498/#review5506 --- Ship it! src/mem/packet.hh

Re: [gem5-dev] Review Request 2496: mem: Make Request getters const

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2496/#review5501 --- Ship it! Ship It! - Nilay Vaish On Nov. 17, 2014, 6:14 a.m., Andreas

Re: [gem5-dev] Review Request 2497: mem: Make the requests carried by packets const

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2497/#review5502 --- src/mem/cache/cache_impl.hh

[gem5-dev] changeset in gem5: configs: small fix to ruby portion of fs.py a...

changeset b61dc895269a in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=b61dc895269a description: configs: small fix to ruby portion of fs.py and se.py In fs.py the io port controller was being attached to the iobus multiple times. This should be done o

Re: [gem5-dev] Review Request 2513: KVM: Build in most of the KVM stuff even if we're not going to use it.

On Tue, 18 Nov 2014, Steve Reinhardt via gem5-dev wrote: I haven't looked at the code in question, so I'm just going by what I've seen in this email thread. However, it seems like there ought to be some alternative solutions here. I like the general direction Andreas is going, though it would

Re: [gem5-dev] Review Request 2491: mem: Add const getters for write packet data

> On Nov. 18, 2014, 3:32 p.m., Nilay Vaish wrote: > > src/mem/packet.hh, line 860 > > > > > > I think we can keep the function name as getPtr() and rely on the > > compiler to pick the right version. Also how about const_c

Re: [gem5-dev] Review Request 2491: mem: Add const getters for write packet data

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2491/#review5477 --- Ship it! Ship It! - Nilay Vaish On Nov. 17, 2014, 6:13 a.m., Andreas

Re: [gem5-dev] Review Request 2492: mem: Use const pointers for port proxy write functions

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2492/#review5475 --- Ship it! Ship It! - Nilay Vaish On Nov. 17, 2014, 6:14 a.m., Andreas

Re: [gem5-dev] bug? in elf loader

I checked the elf-64 draft and I think you right. But I am not able to understand why do we use p_paddr at all. Should we not be using p_vaddr everywhere? -- Nilay On Tue, 18 Nov 2014, Romana, Alexandre via gem5-dev wrote: Hi everybody, Looks to me like there is a bug/typo in elf_loader.

Re: [gem5-dev] Review Request 2493: mem: Remove redundant Packet::allocate calls

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2493/#review5470 --- Ship it! Ship It! - Nilay Vaish On Nov. 17, 2014, 6:14 a.m., Andreas

Re: [gem5-dev] Review Request 2490: mem: Remove null-check bypassing in Packet::getPtr

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2490/#review5469 --- Overall I am fine with the patch. Can we set the size to 1 when the pref

Re: [gem5-dev] Review Request 2492: mem: Use const pointers for port proxy write functions

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2492/#review5468 --- src/mem/port_proxy.cc

Re: [gem5-dev] Review Request 2491: mem: Add const getters for write packet data

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2491/#review5467 --- src/mem/packet.hh I t

Re: [gem5-dev] Memory directory structure

structures. Why not just use those rather than add a new interconnect subdir? Brad -Original Message- From: gem5-dev [mailto:gem5-dev-boun...@gem5.org] On Behalf Of Nilay Vaish via gem5-dev Sent: Tuesday, November 11, 2014 3:37 PM To: Andreas Hansson via gem5-dev Subject: Re: [gem5-dev] M

Re: [gem5-dev] Memory directory structure

I am fine with the proposed changes. -- Nilay On Tue, 11 Nov 2014, Andreas Hansson via gem5-dev wrote: Hi all, I was contemplating adding a src/mem/ram subdirectory and put the DRAM and SimpleMemory files there. I would also like to propose to move src/mem/protocol and src/mem/slicc into t

[gem5-dev] changeset in gem5: stats: changes to x86 o3 fs and sparc fs regr...

changeset 533ec854b2f1 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=533ec854b2f1 description: stats: changes to x86 o3 fs and sparc fs regression tests. diffstat: tests/long/fs/10.linux-boot/ref/x86/linux/pc-o3-timing/stats.txt | 54 +- tests/long

Re: [gem5-dev] Review Request 2209: ruby: single physical memory in fs mode

On Sun, 9 Nov 2014, George Voicu wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2209/#review5449 --- The connection of the ruby io

Re: [gem5-dev] Review Request 2469: mem: dram ctrl: correct errors due to busBusyUntil variable

As I suggested before, we will keep the timing accesses to ruby and the dram ctrl would be accessed using functional accesses. -- Nilay On Sun, 9 Nov 2014, Andreas Hansson via gem5-dev wrote: Hi Brad, Thanks a lot for the clarification. It seems the cleanest way (although that is probably

Re: [gem5-dev] There seems a bug in ruby/mesi_three_level.py

You should post your changes as patch on the review board (reviews.gem5.org). From the code the below, I am unable to find the lines changed. -- Nilay On Fri, 7 Nov 2014, nifan via gem5-dev wrote: Hi: I believe there is a bug in MESI_Three_Level.py. when I tried to run build/MESI_Three

Re: [gem5-dev] Review Request 2469: mem: dram ctrl: correct errors due to busBusyUntil variable

On Thu, 6 Nov 2014, Andreas Hansson wrote: Hi Nilay, I would really not like us to introduce yet another step in the initialisation process unless it is absolutely necessary. The steps done in the DRAM controller relies on curTick being set correctly, and to the best of my knowledge the first

Re: [gem5-dev] Review Request 2469: mem: dram ctrl: correct errors due to busBusyUntil variable

We want to keep the checkpoint state for caches independent of the protocol being used. To reconstruct the state of caches, therefore, we replay memory accesses to the addresses present in the checkpoint. This can only be done after every component is in a state where they are ready to begin

Re: [gem5-dev] Review Request 2469: mem: dram ctrl: correct errors due to busBusyUntil variable

Ok, in that case, I would add one more stage to the initialization phase so as to allow ruby to restore from a checkpoint. -- Nilay On Thu, 6 Nov 2014, Andreas Hansson wrote: Hi Nilay, I see. The reason that it is set in startup is due to the checkpoints. I would argue that we should not

  1   2   3   >