On July 28, 2014, 12:38 a.m., Andreas Hansson wrote:
Ship It!
Andreas Hansson wrote:
What is the state of this?
It might be worth adding the switch to a regression, either a new one, or as an
intermediate switch in the existing ALPHA twosys regression.
- Andreas
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2305/#review5737
---
src/dev/etherint.hh
http://reviews.gem5.org/r/2305/#comment5101
I
On July 28, 2014, 12:38 a.m., Andreas Hansson wrote:
Ship It!
What is the state of this?
- Andreas
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2305/#review5229
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2305/#review5734
---
Ship it!
Ship It!
- Ali Saidi
On July 24, 2014, 7:44 p.m., Anthony
I made the requested changes, and I've maintained the code and it works ok
with the current repo. However, I didn't receive any other feedback, and
didn't get the requisite two ship its.
Cheers,
Anthony Gutierrez
http://web.eecs.umich.edu/~atgutier
On Mon, Jan 5, 2015 at 6:27 PM, Andreas Hansson
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2305/#review5229
---
Ship it!
Ship It!
- Andreas Hansson
On July 24, 2014, 7:44 p.m.,
On July 22, 2014, 10:12 p.m., Andreas Hansson wrote:
src/dev/etherswitch.cc, line 55
http://reviews.gem5.org/r/2305/diff/2/?file=40411#file40411line55
Not sure what the style guide says about the spacing here, but I've
been using
for (auto i: list)
Does
On July 22, 2014, 10:12 p.m., Andreas Hansson wrote:
src/dev/etherswitch.cc, line 165
http://reviews.gem5.org/r/2305/diff/2/?file=40411#file40411line165
Could merge these
broadcasting() basically checks the number broadcasting, so after decrementing
broadcasting() could change.
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2305/
---
(Updated July 24, 2014, 7:44 p.m.)
Review request for Default.
Repository: gem5
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2305/
---
(Updated July 22, 2014, 6:36 p.m.)
Review request for Default.
Repository: gem5
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2305/#review5223
---
src/dev/etherswitch.cc
http://reviews.gem5.org/r/2305/#comment4773
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2305/#review5182
---
src/dev/Ethernet.py
http://reviews.gem5.org/r/2305/#comment4695
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2305/
---
(Updated June 27, 2014, 6:24 p.m.)
Review request for Default.
Repository: gem5
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2305/
---
Review request for Default.
Repository: gem5
Description
---
Changeset
14 matches
Mail list logo
