Re: [gem5-dev] Review Request 2305: dev: add an ethernet switch model

2015-01-06 Thread Andreas Hansson via gem5-dev
On July 28, 2014, 12:38 a.m., Andreas Hansson wrote: Ship It! Andreas Hansson wrote: What is the state of this? It might be worth adding the switch to a regression, either a new one, or as an intermediate switch in the existing ALPHA twosys regression. - Andreas

Re: [gem5-dev] Review Request 2305: dev: add an ethernet switch model

2015-01-06 Thread Steve Reinhardt via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2305/#review5737 --- src/dev/etherint.hh http://reviews.gem5.org/r/2305/#comment5101 I

Re: [gem5-dev] Review Request 2305: dev: add an ethernet switch model

2015-01-05 Thread Andreas Hansson via gem5-dev
On July 28, 2014, 12:38 a.m., Andreas Hansson wrote: Ship It! What is the state of this? - Andreas --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2305/#review5229

Re: [gem5-dev] Review Request 2305: dev: add an ethernet switch model

2015-01-05 Thread Ali Saidi via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2305/#review5734 --- Ship it! Ship It! - Ali Saidi On July 24, 2014, 7:44 p.m., Anthony

Re: [gem5-dev] Review Request 2305: dev: add an ethernet switch model

2015-01-05 Thread Anthony Gutierrez via gem5-dev
I made the requested changes, and I've maintained the code and it works ok with the current repo. However, I didn't receive any other feedback, and didn't get the requisite two ship its. Cheers, Anthony Gutierrez http://web.eecs.umich.edu/~atgutier On Mon, Jan 5, 2015 at 6:27 PM, Andreas Hansson

Re: [gem5-dev] Review Request 2305: dev: add an ethernet switch model

2014-07-27 Thread Andreas Hansson via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2305/#review5229 --- Ship it! Ship It! - Andreas Hansson On July 24, 2014, 7:44 p.m.,

Re: [gem5-dev] Review Request 2305: dev: add an ethernet switch model

2014-07-24 Thread Anthony Gutierrez via gem5-dev
On July 22, 2014, 10:12 p.m., Andreas Hansson wrote: src/dev/etherswitch.cc, line 55 http://reviews.gem5.org/r/2305/diff/2/?file=40411#file40411line55 Not sure what the style guide says about the spacing here, but I've been using for (auto i: list) Does

Re: [gem5-dev] Review Request 2305: dev: add an ethernet switch model

2014-07-24 Thread Anthony Gutierrez via gem5-dev
On July 22, 2014, 10:12 p.m., Andreas Hansson wrote: src/dev/etherswitch.cc, line 165 http://reviews.gem5.org/r/2305/diff/2/?file=40411#file40411line165 Could merge these broadcasting() basically checks the number broadcasting, so after decrementing broadcasting() could change.

Re: [gem5-dev] Review Request 2305: dev: add an ethernet switch model

2014-07-24 Thread Anthony Gutierrez via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2305/ --- (Updated July 24, 2014, 7:44 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 2305: dev: add an ethernet switch model

2014-07-22 Thread Anthony Gutierrez via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2305/ --- (Updated July 22, 2014, 6:36 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 2305: dev: add an ethernet switch model

2014-07-22 Thread Andreas Hansson via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2305/#review5223 --- src/dev/etherswitch.cc http://reviews.gem5.org/r/2305/#comment4773

Re: [gem5-dev] Review Request 2305: dev: add an ethernet switch model

2014-07-10 Thread Andreas Hansson via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2305/#review5182 --- src/dev/Ethernet.py http://reviews.gem5.org/r/2305/#comment4695

Re: [gem5-dev] Review Request 2305: dev: add an ethernet switch model

2014-06-27 Thread Anthony Gutierrez via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2305/ --- (Updated June 27, 2014, 6:24 p.m.) Review request for Default. Repository: gem5

[gem5-dev] Review Request 2305: dev: add an ethernet switch model

2014-06-26 Thread Anthony Gutierrez via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2305/ --- Review request for Default. Repository: gem5 Description --- Changeset