Re: [gem5-dev] systemc reviews

2018-07-24 Thread Gabe Black
Ok, sounds good. There was one other comment I saw besides the ones about using = delete which I think is also because of what's in the spec. ( https://gem5-review.googlesource.com/c/public/gem5/+/10832). I wanted to point that out specifically just so it doesn't get lost in all the emails I'm

Re: [gem5-dev] systemc reviews

2018-07-23 Thread Jason Lowe-Power
Hey Gabe, This is fine with me. Sorry for putting off reviewing all of these. If there's anything that you think specifically needs to be looked at more closely, let us know. Otherwise, as you said, since this is fairly separate from the rest of gem5 we can be pretty laissez faire about it.

Re: [gem5-dev] systemc reviews

2018-07-16 Thread Gabe Black
Hi folks. Thank you for all your reviewing efforts so far. I know it's not easy considering the scope of the effort, and that the dark inner workings and far reaching expanses of systemc are not familiar to everyone. To keep the review process open to feedback while at the same time ensuring

Re: [gem5-dev] systemc reviews

2018-06-20 Thread Gabe Black
Hello again folks. There are currently 90 pending systemc CLs, and more will be coming. We need to close the incoming vs outgoing gap. On Fri, Jun 15, 2018 at 12:01 PM Jason Lowe-Power wrote: > Hey Boris, > > I think that gerrit always sends the first message when a patch is uploaded > to the

Re: [gem5-dev] systemc reviews

2018-06-15 Thread Jason Lowe-Power
Hey Boris, I think that gerrit always sends the first message when a patch is uploaded to the whole list. Then, when adding comments or updating patches gerrit only sends emails to people that are cc'ed in gerrit. I'm not sure what the behavior is on merges... I'm not sure what an easy way to be

Re: [gem5-dev] systemc reviews

2018-06-15 Thread Boris Shingarov
> If you also want to be on all the reviews, > please let me know. I don't want to unilaterally > bomb people's inboxes if they're not interested. Wait. I am not sure what you are saying here. Are you proposing to *add* so Andreas, Jason and Matthias will receive more emails over those review

Re: [gem5-dev] systemc reviews

2018-06-15 Thread Gabe Black
ev on behalf of Gabe Black < > gabebl...@google.com> > Sent: 15 June 2018 09:55:30 > To: gem5 Developer List > Subject: Re: [gem5-dev] systemc reviews > > Oh, by the way, I've been adding Andreas, Jason and Matthias Jung to all > the systemc reviews I've been posting. I think

Re: [gem5-dev] systemc reviews

2018-06-15 Thread Giacomo Travaglini
Hi Gabe, please consider myself interested on reviewing SystemC patches ?? From: gem5-dev on behalf of Gabe Black Sent: 15 June 2018 09:55:30 To: gem5 Developer List Subject: Re: [gem5-dev] systemc reviews Oh, by the way, I've been adding Andreas, Jason

Re: [gem5-dev] systemc reviews

2018-06-15 Thread Gabe Black
gt;>>> >> > > >>>> There will be very little modification to gem5 proper for this, >> and >> > > so if >> > > >>>> this sort of integration doesn't do what you want you can just >> > ignore >> > > it or >&g

Re: [gem5-dev] systemc reviews

2018-06-15 Thread Gabe Black
gt; > >>>> systemc would be a lot more work that doesn't really gain us > > anything. > > > >>>> > > > >>>> Jason, thanks. Please start with that python CL if you have a > chance > > > since > > > >>>> I think it's abo

Re: [gem5-dev] systemc reviews

2018-06-14 Thread Jason Lowe-Power
t;> Gabe > > >>>> > > >>>> > > >>>> On Fri, Jun 8, 2018 at 7:15 AM Jason Lowe-Power < > ja...@lowepower.com> > > >>>> wrote: > > >>>> > > >>>>> I'll have some time next week to dig into th

Re: [gem5-dev] systemc reviews

2018-06-11 Thread Gabe Black
gt;> Hi Giacomo, Gabe, > >>>>>> > >>>>>> I'm a large supporter of SystemC because its 'the' IEEE standard for > >>>>>> simulation, therefore I support always activities towards that > >>>>> direction. > >&g

Re: [gem5-dev] systemc reviews

2018-06-11 Thread Matthias Jung
kernel >>>>> for >>>>>> gem5 in order to have a proper separation between model and kernel. I >>>>> think >>>>>> its very interesting for many people to use gem5 in their SystemC >>>>>> environment also together with commercia

Re: [gem5-dev] systemc reviews

2018-06-11 Thread Christian Menard
; commercial >>>>> SystemC tools like Synopsys Platform Architect etc. could not be used. >>>>> >>>>> >>>>> Best, >>>>> Matthias >>>>> >>>>> 8. Juni 2018 15:47, "Giacomo Travaglini&quo

Re: [gem5-dev] systemc reviews

2018-06-10 Thread Matthias Jung
gt;>> 8. Juni 2018 15:47, "Giacomo Travaglini" >>>> schrieb: >>>> >>>>> Hi Gabe, >>>>> >>>>> I have had a quick glance at the patches and there's one thing I don't >>>> understand: >>>>> >

Re: [gem5-dev] systemc reviews

2018-06-08 Thread Gabe Black
; I have had a quick glance at the patches and there's one thing I don't >> > understand: >> > > >> > > It seems to me that you are sort of reimplementing the SystemC runtime >> > kernel inside >> > > >> > > gem5 for scratch. >> > > >> > > Is t

Re: [gem5-dev] systemc reviews

2018-06-08 Thread Gabe Black
de > > > > > > gem5 for scratch. > > > > > > Is there a reason for doing it? Can't we just link to the external > > SystemC library > > > > > > and just write some wrappers? > > > > > > Thanks in advance for the clarif

Re: [gem5-dev] systemc reviews

2018-06-08 Thread Jason Lowe-Power
r the clarifications > > > > Giacomo > > > > ____________ > > From: gem5-dev on behalf of Gabe Black < > gabebl...@google.com> > > Sent: 08 June 2018 06:32:52 > > To: gem5 Developer List > > Subject: [gem5-dev] systemc

Re: [gem5-dev] systemc reviews

2018-06-08 Thread Dr.-Ing. Matthias Jung
ppers? > > Thanks in advance for the clarifications > > Giacomo > > > From: gem5-dev on behalf of Gabe Black > > Sent: 08 June 2018 06:32:52 > To: gem5 Developer List > Subject: [gem5-dev] systemc reviews > > Hi folks. I've po

Re: [gem5-dev] systemc reviews

2018-06-08 Thread Giacomo Travaglini
write some wrappers? Thanks in advance for the clarifications Giacomo From: gem5-dev on behalf of Gabe Black Sent: 08 June 2018 06:32:52 To: gem5 Developer List Subject: [gem5-dev] systemc reviews Hi folks. I've posted a lot of systemc reviews recently, and I

[gem5-dev] systemc reviews

2018-06-07 Thread Gabe Black
Hi folks. I've posted a lot of systemc reviews recently, and I expect to keep doing so for the foreseeable future. To keep the pool of pending CLs from growing from a lot to unmanageably a lot please don't let them sit too long if you feel comfortable trying to review them. Alot of these earlier