Re: [m5-dev] Review Request: sim: move iterating over SimObjects into Python.

> That's useful information... most of my motivation for iterChildren() > was to be consistent with other python methods like iteritems(), > iterkeys(), etc., so if that's going away then I'm less motivated to > stick with it.  I haven't played with python3 so I didn't know that. > See, I told you

Re: [m5-dev] Review Request: sim: move iterating over SimObjects into Python.

That's useful information... most of my motivation for iterChildren() was to be consistent with other python methods like iteritems(), iterkeys(), etc., so if that's going away then I'm less motivated to stick with it. I haven't played with python3 so I didn't know that. See, I told you that you w

Re: [m5-dev] Review Request: sim: move iterating over SimObjects into Python.

By the way, I don't hate iterChildren(). I just agree with the python guys who don't feel that the word iter is necessary. (In python3, iteritems doesn't exist anymore, it's just called items). Nate On Fri, Jul 30, 2010 at 10:45 PM, nathan binkert wrote: >> I tried unproxying without sorting

Re: [m5-dev] Review Request: sim: move iterating over SimObjects into Python.

> I tried unproxying without sorting and the regressions passed, so it looks > like you were right that it's unnecessary.  I then got rid of > iterSortedChildren() and replaced the one remaining use with >  for obj in sorted(root.iterChildren(), key=lambda o: o.path()): >      obj.print_ini(ini_f

Re: [m5-dev] Review Request: sim: move iterating over SimObjects into Python.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/27/#review132 --- I tried unproxying without sorting and the regressions passed, so it looks

Re: [m5-dev] Review Request: sim: move iterating over SimObjects into Python.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/27/#review129 --- src/python/m5/SimObject.py

Re: [m5-dev] Review Request: sim: move iterating over SimObjects into Python.

> On 2010-06-28 17:41:44, Nathan Binkert wrote: > > src/python/m5/SimObject.py, line 767 > > > > > > I wonder if Children doesn't quite describe it right since children > > doesn't obviously imply recursion. iterDescendants? (

Re: [m5-dev] Review Request: sim: move iterating over SimObjects into Python.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/27/#review123 --- src/python/m5/SimObject.py

Re: [m5-dev] Review Request: sim: move iterating over SimObjects into Python.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/27/ --- (Updated 2010-07-29 21:42:28.129201) Review request for Default. Summary ---

Re: [m5-dev] Review Request: sim: move iterating over SimObjects into Python.

> On 2010-06-28 17:41:44, Nathan Binkert wrote: > > src/python/m5/stats.py, line 62 > > > > > > Not sure if it matters at all, but you've changed the order of reset. > > Currently, we reset stats and then reset objects. I hope

Re: [m5-dev] Review Request: sim: move iterating over SimObjects into Python.

> On 2010-06-28 17:41:44, Nathan Binkert wrote: > > src/python/m5/SimObject.py, line 767 > > > > > > I wonder if Children doesn't quite describe it right since children > > doesn't obviously imply recursion. iterDescendants? (

Re: [m5-dev] Review Request: sim: move iterating over SimObjects into Python.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/27/#review53 --- src/python/m5/SimObject.py

Re: [m5-dev] Review Request: sim: move iterating over SimObjects into Python.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/27/ --- (Updated 2010-06-27 23:41:59.518566) Review request for Default. Summary ---

[m5-dev] Review Request: sim: move iterating over SimObjects into Python.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/27/ --- Review request for Default. Summary --- sim: move iterating over SimObjects int