Podling request: Gerrit

2015-07-13 Thread Jochen Wiedmann
Hi, I am writing as one of the Mentors of the AsterixDB podling. It recently came to my attention, that there are, in fact, multiple Git repositories, which are used by the project, one of them being located externally of the ASF. I understand the structure to be like this: +--+ C

Re: Podling request: Gerrit

2015-07-13 Thread David Nalley
On Mon, Jul 13, 2015 at 7:24 PM, Jochen Wiedmann wrote: > Hi, > > I am writing as one of the Mentors of the AsterixDB podling. > > It recently came to my attention, that there are, in fact, multiple > Git repositories, which are used by the project, one of them being > located externally of the AS

Re: Podling request: Gerrit

2015-07-13 Thread Roman Shaposhnik
IIRC, the problem with Gerrit workflow is that actually pushes into the repo are actually done by the bot. This runs against ASF's desire to keep push logs that actually make sense. The setup that you're describing (although ASCII art came broken via Gmail) seems to be addressing that very problem

Re: Podling request: Gerrit

2015-07-13 Thread Ian Maxon
To add onto Jochen's comments, even something lesser than a hosted Gerrit instance might suffice. The core issue for integrating our previous Git workflow is that, as I understand it, there's no way to have "robot" committers to ASF git. We previously had Gerrit acting on behalf of whoever submitte

Re: Podling request: Gerrit

2015-07-13 Thread Ian Maxon
> This is a severe problem and needs to be rectified promptly. > How are commits migrating from the external repository to the ASF repository? > We typically end up missing provenance information that is important > in blind mirroring of content. > There's no blind mirroring going on here. What we

Re: Podling request: Gerrit

2015-07-13 Thread David Nalley
On Mon, Jul 13, 2015 at 9:38 PM, Ian Maxon wrote: >> This is a severe problem and needs to be rectified promptly. >> How are commits migrating from the external repository to the ASF repository? >> We typically end up missing provenance information that is important >> in blind mirroring of conten

Re: Podling request: Gerrit

2015-07-13 Thread Ian Maxon
> This is pretty far from what the norm is, and is being proposed by a > podling, so I'd expect some skepticism. Other podlings, have proposed > similar workflows (albeit with extra problems.) and were not allowed > to retain that procedure. I think there's some confusion here about what the workf

Re: Podling request: Gerrit

2015-07-14 Thread David Nalley
On Tue, Jul 14, 2015 at 1:14 AM, Ian Maxon wrote: >> This is pretty far from what the norm is, and is being proposed by a >> podling, so I'd expect some skepticism. Other podlings, have proposed >> similar workflows (albeit with extra problems.) and were not allowed >> to retain that procedure. >

Re: Podling request: Gerrit

2015-07-14 Thread Till Westmann
On 14 Jul 2015, at 15:31, David Nalley wrote: On Tue, Jul 14, 2015 at 1:14 AM, Ian Maxon wrote: We use Gerrit as a tool to do code reviews and to organize the commits, as well as to facilitate easy testing. However that's all it's used for- we still clone from repositories that come downstre

Re: Podling request: Gerrit

2015-07-14 Thread Jake Farrell
Hey Till All commits must occur against the ASF codebase and can not be mirrored over from a different location (this includes Github, Gerrit, etc.). This is a mandate that has come from the board level and is not a negotiable item. Gerrit has been discussed many times before and each time the ans

Re: Podling request: Gerrit

2015-07-14 Thread David Nalley
On Tue, Jul 14, 2015 at 8:08 PM, Till Westmann wrote: > > On 14 Jul 2015, at 15:31, David Nalley wrote: > >> On Tue, Jul 14, 2015 at 1:14 AM, Ian Maxon wrote: >> >>> We use Gerrit as >>> a tool to do code reviews and to organize the commits, as well as to >>> facilitate easy testing. However that

Re: Podling request: Gerrit

2015-07-14 Thread Jochen Wiedmann
On Wed, Jul 15, 2015 at 5:56 AM, David Nalley wrote: > We've explored gerrit 2-3 times in the past 24 months. We have seen > several projects request it over the years. As I've mentioned > elsewhere in this thread, our most recent exploration was in December, > and there are a number of issues th

Re: Podling request: Gerrit

2015-07-15 Thread Jochen Wiedmann
On Wed, Jul 15, 2015 at 10:40 AM, Chris Hillery wrote: > I feel sure that > with an ASF-hosted Gerrit, we wouldn't be able to install any hooks or > plugins, or manage permissions, or anything like that in the way that we > find useful. Not initially, to be sure. But in the medium term, and with

Re: Podling request: Gerrit

2015-07-15 Thread Ian Maxon
> 1. People are not clearly contributing to Apache AsterixDB when > submitting a patch via Gerrit at UCI.edu. Think about Section 5 of > ASLv2. Then what are they submitting a patch for review to, exactly? > 2. The ASF has no record of any contributions that are happening on > the Gerrit instance

Re: Podling request: Gerrit

2015-07-15 Thread Jochen Wiedmann
On Wed, Jul 15, 2015 at 12:13 PM, Ian Maxon wrote: > Then what are they submitting a patch for review to, exactly? That is the question, indeed. And, please, keep in mind that the answer must satisfy not a humble developer with "no red tape" in mind, but a lawyer. >> Second, Gerrit is where ev

Re: Podling request: Gerrit

2015-07-15 Thread Chris Hillery
On Wed, Jul 15, 2015 at 2:04 AM, Jochen Wiedmann wrote: > On Wed, Jul 15, 2015 at 10:40 AM, Chris Hillery > wrote: > > > I feel sure that > > with an ASF-hosted Gerrit, we wouldn't be able to install any hooks or > > plugins, or manage permissions, or anything like that in the way that we > > fi

Re: Podling request: Gerrit

2015-07-15 Thread Chris Hillery
On Mon, Jul 13, 2015 at 5:01 PM, Roman Shaposhnik wrote: > IIRC, the problem with Gerrit workflow is that actually > pushes into the repo are actually done by the bot. That's how we (the Asterix project) had things set up, but it isn't a requirement of Gerrit. In fact we had to kind of duct-tap

Re: Podling request: Gerrit

2015-07-15 Thread Ian Maxon
> That is the question, indeed. And, please, keep in mind that the > answer must satisfy not a humble developer with "no red tape" in mind, > but a lawyer. I guess there's some legal issue I'm ignorant of here then. How would one submit a patch, without cloning from the official mirror, and hence

Re: Podling request: Gerrit

2015-07-15 Thread Jochen Wiedmann
On Wed, Jul 15, 2015 at 12:51 PM, Ian Maxon wrote: > I guess there's some legal issue I'm ignorant of here then. How would > one submit a patch, without cloning from the official mirror, and > hence becoming just as aware of ASF involvement as they would > otherwise? The legal issue at hand is t

Re: Podling request: Gerrit

2015-07-15 Thread Chris Douglas
David- In another conversation, you mentioned Crucible [1] as another tool for code reviews. Is that a viable option? Has anyone on the list had any experience using it? -C [1] https://www.atlassian.com/software/crucible/overview/ On Tue, Jul 14, 2015 at 8:56 PM, David Nalley wrote: > On Tue,

Re: Podling request: Gerrit

2015-07-15 Thread Benson Margulies
I've used crucible. It's horrible. And it comes from Atlassian, which means that infra@ is predisposed against it, as their general feeling is that the Atlassian products are very heavy. - To unsubscribe, e-mail: general-unsubscr.

Re: Podling request: Gerrit

2015-07-15 Thread Ian Maxon
> The legal issue at hand is that one must reasonably assume that the > contributor offers his patch with an implicit license to the ASF for > distribution under the terms of the ASL 2. > > For example, if you add a patch to a Jira issue, then there is a > select box, which allows to express consen

Re: Podling request: Gerrit

2015-07-15 Thread Roman Shaposhnik
On Wed, Jul 15, 2015 at 3:13 AM, Ian Maxon wrote: >> 2. The ASF has no record of any contributions that are happening on >> the Gerrit instance at UCI, until a committer decides to push code to >> the ASF repo. > > I'm afraid I don't understand this point. How is this different than > any other di

Re: Podling request: Gerrit

2015-07-15 Thread Ian Maxon
> In Git (and I'd presume any Git-like DVCS) anything but the push logs > can be spoofed. Having a record of who actually pushed to the repo > is one of the requirement from ASF's standpoint to track chain of custody > for the code that lands in out projects. Understood. That's the very reason why

Re: Podling request: Gerrit

2015-07-15 Thread Mattmann, Chris A (3980)
Wednesday, July 15, 2015 at 1:22 PM To: "general@incubator.apache.org" Subject: Re: Podling request: Gerrit >> In Git (and I'd presume any Git-like DVCS) anything but the push logs >> can be spoofed. Having a record of who actually pushed to the repo >> is one

Re: Podling request: Gerrit

2015-07-15 Thread David Nalley
On Wed, Jul 15, 2015 at 5:48 PM, Mattmann, Chris A (3980) wrote: > Hi Folks, > > Can someone clarify in simple terms what the issue is here? > There's a few issues Chris: 1. Contributions are being submitted, discussed, and accepted externally. No record of the submission, discussion, or accepta

Re: Podling request: Gerrit

2015-07-15 Thread Mattmann, Chris A (3980)
: "general@incubator.apache.org" Subject: Re: Podling request: Gerrit >On Wed, Jul 15, 2015 at 5:48 PM, Mattmann, Chris A (3980) > wrote: >> Hi Folks, >> >> Can someone clarify in simple terms what the issue is here? >> > >There's a few issues Chris: >

Re: Podling request: Gerrit

2015-07-15 Thread Till Westmann
+1 > On Jul 15, 2015, at 9:05 PM, Benson Margulies wrote: > > I've used crucible. It's horrible. And it comes from Atlassian, which > means that infra@ is predisposed against it, as their general feeling > is that the Atlassian products are very heavy. > > --

Re: Podling request: Gerrit

2015-07-15 Thread Till Westmann
> On Jul 15, 2015, at 10:02 PM, Roman Shaposhnik wrote: > > On Wed, Jul 15, 2015 at 3:13 AM, Ian Maxon wrote: >>> 2. The ASF has no record of any contributions that are happening on >>> the Gerrit instance at UCI, until a committer decides to push code to >>> the ASF repo. >> >> I'm afraid I d

Re: Podling request: Gerrit

2015-07-15 Thread Till Westmann
> On Jul 16, 2015, at 12:25 AM, David Nalley wrote: > > On Wed, Jul 15, 2015 at 5:48 PM, Mattmann, Chris A (3980) > wrote: >> Hi Folks, >> >> Can someone clarify in simple terms what the issue is here? >> > > There's a few issues Chris: Let me try to describe this in terms how most members

Re: Podling request: Gerrit

2015-07-15 Thread Roman Shaposhnik
On Wed, Jul 15, 2015 at 4:17 PM, Till Westmann wrote: > >> On Jul 15, 2015, at 10:02 PM, Roman Shaposhnik wrote: >> >> On Wed, Jul 15, 2015 at 3:13 AM, Ian Maxon wrote: 2. The ASF has no record of any contributions that are happening on the Gerrit instance at UCI, until a committer dec

Re: Podling request: Gerrit

2015-07-15 Thread Chris Douglas
On Wed, Jul 15, 2015 at 4:21 PM, Roman Shaposhnik wrote: > As long as there's a human being in the loop reviewing what's going into the > repo I don't think I've got any issues with the process. The ASF needs to establish provenance. It can't do that if a committer pushes code that was posted to

Re: Podling request: Gerrit

2015-07-15 Thread Till Westmann
> On Jul 16, 2015, at 1:21 AM, Roman Shaposhnik wrote: > > On Wed, Jul 15, 2015 at 4:17 PM, Till Westmann > wrote: >> >>> On Jul 15, 2015, at 10:02 PM, Roman Shaposhnik wrote: >>> >>> On Wed, Jul 15, 2015 at 3:13 AM, Ian Maxon wrote: > 2. The ASF has no record o

Re: Podling request: Gerrit

2015-07-15 Thread Roman Shaposhnik
On Wed, Jul 15, 2015 at 4:34 PM, Chris Douglas wrote: > On Wed, Jul 15, 2015 at 4:21 PM, Roman Shaposhnik > wrote: >> As long as there's a human being in the loop reviewing what's going into the >> repo I don't think I've got any issues with the process. > > The ASF needs to establish provenance

Re: Podling request: Gerrit

2015-07-15 Thread Roman Shaposhnik
On Wed, Jul 15, 2015 at 4:42 PM, Till Westmann wrote: > 1) I think that we didn’t ask for an ASF hosted instance. But I also think > that > David’s concern that the absence of the service would disrupt the > development of AsterixDB is valid. And thus it might make sense not to rely > on an insta

Re: Podling request: Gerrit

2015-07-15 Thread Ian Maxon
To meet this, do we simply need the change proposals in Gerrit (i.e. pull requests) to have their patch contents mirrored to a proper ASF mailing list? - Ian On Wed, Jul 15, 2015 at 4:34 PM, Chris Douglas wrote: > On Wed, Jul 15, 2015 at 4:21 PM, Roman Shaposhnik > wrote: >> As long as there's

Re: Podling request: Gerrit

2015-07-15 Thread Ian Maxon
+1. This is basically how I see it as well. On Wed, Jul 15, 2015 at 4:18 PM, Till Westmann wrote: > >> On Jul 16, 2015, at 12:25 AM, David Nalley wrote: >> >> On Wed, Jul 15, 2015 at 5:48 PM, Mattmann, Chris A (3980) >> wrote: >>> Hi Folks, >>> >>> Can someone clarify in simple terms what the i

Re: Podling request: Gerrit

2015-07-15 Thread Mattmann, Chris A (3980)
++ -Original Message- From: Till Westmann Reply-To: "general@incubator.apache.org" Date: Wednesday, July 15, 2015 at 4:18 PM To: "general@incubator.apache.org" Subject: Re: Podling request: Gerrit > >> On Jul

Re: Podling request: Gerrit

2015-07-15 Thread David Nalley
On Wed, Jul 15, 2015 at 7:45 PM, Roman Shaposhnik wrote: > On Wed, Jul 15, 2015 at 4:34 PM, Chris Douglas wrote: >> On Wed, Jul 15, 2015 at 4:21 PM, Roman Shaposhnik >> wrote: >>> As long as there's a human being in the loop reviewing what's going into the >>> repo I don't think I've got any is

Re: Podling request: Gerrit

2015-07-15 Thread David Nalley
Chris: We've discussed Crucible in the past. (There's a ticket or two for it in Jira). We've talked with some folks who run it, who tell us it's pretty sluggish for environments a fraction of the size of the ASF. That said - the other issue is that we have 200 projects. There is very little unifo

Re: Podling request: Gerrit

2015-07-15 Thread David Nalley
On Wed, Jul 15, 2015 at 2:31 AM, Jochen Wiedmann wrote: > On Wed, Jul 15, 2015 at 5:56 AM, David Nalley wrote: > >> We've explored gerrit 2-3 times in the past 24 months. We have seen >> several projects request it over the years. As I've mentioned >> elsewhere in this thread, our most recent exp

Re: Podling request: Gerrit

2015-07-15 Thread David Nalley
On Wed, Jul 15, 2015 at 8:37 PM, Mattmann, Chris A (3980) wrote: > Hi Till, > > We should probably move this discussion on to the > d...@asterixdb.incubator.apache.org list. > > In short, we shouldn’t have situations in which there are contributors > who contributions are “shepherded in” by Apache

Re: Podling request: Gerrit

2015-07-15 Thread Ian Maxon
> I understand that git is a DVCS, but by mirroring the commit content > from one repo to the ASF (albeit via a committer middleman), we > largely make the push records[1] pointless. The push logs are intended to determine the committer either who authored the contribution or is taking responsibil