Re: [Geotools-devel] Online Tests quietly failing (again)

Torben, yes, in October I re-enabled skip.on.failure=false for active online tests because Andrea's fix solved the JNDI problem: http://osgeo-org.1560.x6.nabble.com/Online-tests-td5229255.html As you have noted on several occasions, skip.on.failure=false does not work as desired. I do not like

[Geotools-devel] Online Tests quietly failing (again)

So, it looks like the online oracle tests are not being run, due to an oracle error on set up ("ORA-28001: the password has expired"). I am working with the dbadmin to get oracle working again (hopefully in a way that won't expire). What concerns me is that this did not cause the test to fail, jus

Re: [Geotools-devel] Online tests

On Mon, Oct 12, 2015 at 12:19 AM, Ben Caradoc-Davies wrote: > Andrea, the most recent successful build of geotools-master-online was > with skip.on.failure=false, so your JNDI fix works for all enabled jdbc > online fixtures (postgis, oracle, and, mysql (and h2 of course)). > Good news > > The

Re: [Geotools-devel] Online tests

On 12/10/15 09:48, Ben Caradoc-Davies wrote: > On 11/10/15 19:27, Andrea Aime wrote: >> I've spend quite some time trying to get those pass, but the old >> app-context just won't go away... > Andrea, I saw your commit: > Fixing JDBC JNDI test failures > https://github.com/geotools/geotools/commit/a

Re: [Geotools-devel] Online tests

On 11/10/15 19:27, Andrea Aime wrote: > I've spend quite some time trying to get those pass, but the old > app-context just won't go away... Andrea, I saw your commit: Fixing JDBC JNDI test failures https://github.com/geotools/geotools/commit/ab14a9ac4d8622f9960abdfa8a0158169947b78d This fixes t

Re: [Geotools-devel] Online tests

I have enabled email notifications for geotools-master-online. On 11/10/15 18:10, Ben Caradoc-Davies wrote: > I think email notifications are disabled. -- Ben Caradoc-Davies Director Transient Software Limited New Zealand -

Re: [Geotools-devel] Online tests

ag should be used, and you can re-enable it as soon as >> > the JNDI tests are fixed. >> > >> > I have also disabled sqlserver as this has an unrelated failure. >> > >> > Here is the log of the most recent failing build: >> > >> http://ares.boundlessgeo.c

Re: [Geotools-devel] Online tests

; > > I have also disabled sqlserver as this has an unrelated failure. > > > > Here is the log of the most recent failing build: > > > http://ares.boundlessgeo.com/jenkins/view/geotools/job/geotools-master-online/269/consoleText > > > > Kind regards, > >

Re: [Geotools-devel] Online tests

r-online/269/consoleText > > Kind regards, > Ben. > > > ---- Forwarded Message ---- > Subject: Re: [Geotools-devel] online tests > Date: Sun, 20 Sep 2015 09:08:27 +1200 > From: Ben Caradoc-Davies > To: Ian Turton , Geotools-Devel list > > > Ian, > &

[Geotools-devel] Online tests

Kind regards, Ben. Forwarded Message Subject: Re: [Geotools-devel] online tests Date: Sun, 20 Sep 2015 09:08:27 +1200 From: Ben Caradoc-Davies To: Ian Turton , Geotools-Devel list Ian, I expect JNDI failures if skip.on.failure=false is used. See: http://osgeo-org.1560.x6

Re: [Geotools-devel] online tests

Ian, I expect JNDI failures if skip.on.failure=false is used. See: http://osgeo-org.1560.x6.nabble.com/A-possibly-simple-fix-for-the-postgis-online-test-cases-hidden-failure-td5200948.html http://osgeo-org.1560.x6.nabble.com/Oracle-Tests-failing-on-Jenkins-td5210111.html Online tests work fine

Re: [Geotools-devel] online tests

I got a bit more information, ares was failing its tests (too many open files). See other email for discussion. -- Jody Garnett On 19 September 2015 at 15:52, Ian Turton wrote: > While trying a local build at the code sprint we noticed some DB issues > showing up, so I made the mistake of looki

[Geotools-devel] online tests

While trying a local build at the code sprint we noticed some DB issues showing up, so I made the mistake of looking at the ares online build: JDBC DataStore Support SUCCESS [21.989s] [INFO] ArcSDE DataStore plugin ... SUCCESS [14.013s] [INFO] J

Re: [Geotools-devel] Online Tests

Fixed on master. On 19/02/15 13:07, Ben Caradoc-Davies wrote: > Bugger. Several Oracle tests were not ported and FTBFS. Without > -Doracle, these tests are not even compiled. gt-jdbc-oracle uses > > true > > which is worse than skipTests. > http://maven.apache.org/surefire/maven-surefire-plugin/

Re: [Geotools-devel] Online Tests

Bugger. Several Oracle tests were not ported and FTBFS. Without -Doracle, these tests are not even compiled. gt-jdbc-oracle uses true which is worse than skipTests. http://maven.apache.org/surefire/maven-surefire-plugin/examples/skipping-test.html I will fix it. On 19/02/15 08:59, Ben Caradoc-

Re: [Geotools-devel] Online Tests

Agreed. Unfortunately many are accustomed to following our practices rather than our documented policy. The one thing that have not tested is multithreaded builds. Many ares jobs use -T2 which I found often fail locally. How robust are online database tests with -T2? Kind regards, Ben. On 19/

Re: [Geotools-devel] Online Tests

Torben and Jody, I have conducted a full review and have merged PR 742. While I am averse to last-minute changes, Jody has a compelling argument that this is an investment in the future ease of cherry-picking onto stable. Review details: - Full GeoTools builds (-Dall) with and without -Ponline

Re: [Geotools-devel] Online Tests

While this is a significant change, it only affects test cases and should not affect functionality, so I feel like it is relatively 'safe'. For the API change, I feel like the current naming scheme is what caused issue in the first place; Any jdbc tests simply used the API name with JDBC replaced

Re: [Geotools-devel] Online Tests

I agree that this is a welcome change; how refreshing that our test classes finally conform to our own long standing and well-thought-out policy. One problem is that this is an API change for any external project that reuses these test classes. Another consequence is that every build server wi

Re: [Geotools-devel] Online Tests

Larger picture is we have got some databases setup that ares can see and I would like to set up jobs to run our online tests (seperate nightly online tests using the -Ponline profile). I was just real surprised that the -Ponline profile was not setup for JDBC tests... While we can put off the ren

Re: [Geotools-devel] Online Tests

Hi, well I don't want to block this, so -0 (uncomfortable, but if you want to go ahead do). Cheers Andrea On Wed, Feb 18, 2015 at 5:56 PM, Torben Barsballe < tbarsba...@boundlessgeo.com> wrote: > I aggree that this big a change (at least it is a non-functional change) > is probably a bad idea ri

Re: [Geotools-devel] Online Tests

I aggree that this big a change (at least it is a non-functional change) is probably a bad idea right before a release, but Jody asked if I could get it done in time, so here we are. Andrea: - According to our documentation

Re: [Geotools-devel] Online Tests

Hi The drivers for DB2 have to be installed manually too. Cheers Christian On Wed, Feb 18, 2015 at 5:54 AM, Andrea Aime wrote: > I'm in the "last minute change hater's club" too. What's the damage in > doing it on trunk only after the cut, and backport later, or just do not > backport at al

Re: [Geotools-devel] Online Tests

I'm in the "last minute change hater's club" too. What's the damage in doing it on trunk only after the cut, and backport later, or just do not backport at all if those are considered API? (arguably, the base classes are API as any JDBC store depends on them) Cheers Andrea Il 18/feb/2015 05:29

Re: [Geotools-devel] Online Tests

Wondering why you want to rename then in the first place, isn't controlling their execution with the property file enough? Mind, Oracle and sqlserver need extra steps, you have to manually install the drivers in maven and activate profiles that will make them use the drivers Cheers Andrea Il 17

Re: [Geotools-devel] Online Tests

Torben, I am not convinced that it is a good idea to rename 291 classes on the eve of an RC1 release. We are in a freeze, after all. This proposal certainly merits discussion. Kind regards, Ben. On 18/02/15 14:29, Torben Barsballe wrote: > Here is a pull request that updates *all* classes inhe

Re: [Geotools-devel] Online Tests

Here is a pull request that updates *all* classes inheriting from OnlineTest to end in OnlineTest.java: https://github.com/geotools/geotools/pull/742 Hopefully this is still in time for RC1. Torben On Tue, Feb 17, 2015 at 2:47 PM, Torben Barsballe < tbarsba...@boundlessgeo.com> wrote: > Renaming

Re: [Geotools-devel] Online Tests

Renaming all database tests to end in OnlineTest is easy, and can get done in time for RC1. We should probably also look and see if there are other "Online" tests that should be renamed, but this will likely require a bit of digging and probably won't be ready for RC1. Torben On Tue, Feb 17, 201

Re: [Geotools-devel] Online Tests

Good research, that will be quite the pull request :) Can we get it done in time for RC1? -- Jody Garnett On 17 February 2015 at 14:07, Torben Barsballe wrote: > I am working on getting online database tests set up and runing on > ares/Jenkins. > According to our documentation >

[Geotools-devel] Online Tests

I am working on getting online database tests set up and runing on ares/Jenkins. According to our documentation , any tests requiring an online resurce should end in OnlineTest.java, and will only run under the "-P o

Re: [Geotools-devel] Online tests before release?

That would be excellent! Given the amount of effort invested by you and other core developers in online jdbc unit tests, it would be great to run them more often, for both kinds of database, postgres *and* oracle: http://www.youtube.com/watch?v=cSZfUnCK5qk I could not get even Oracle XE to insta

Re: [Geotools-devel] Online tests before release?

Yes, ideally we would run the jdbc tests continuously or even nightly but unfortunately this is not that simple as it requires database infrastructure to be setup. Straight forward in the postgresql case, not so straight forward in the oracle case. It is on my sort of long term todo list to get th

[Geotools-devel] Online tests before release?

Should we be running online tests, such as those for jdbc plugins, before cutting a release? I don't see Hudson coverage. I still see local failures like this: https://jira.codehaus.org/browse/GEOT-4046 -- Ben Caradoc-Davies Software Engineer CSIRO Earth Science and Resource Engineering Austra

Re: [Geotools-devel] Online tests and jdbc drivers

I think we have to decide how to go on. 1) I sent the db2 license to Adrian and he responded that it is not possible to put the jars in the maven rep. I do not know why but I am not a license expert. 2) Since the oracle jar causes the same problem and there is a workaround described in the deve

Re: [Geotools-devel] Online tests and jdbc drivers

mcr wrote: > I got a positive mail form David. It is possible to put the db2 driver jars > in the maven repository. I did a download since I have a IBM developer > login. Who is able to include these 3 jars in the repo, I would send a > zip file including the jars. > We have a similar problem

Re: [Geotools-devel] Online tests and jdbc drivers

Thanks for the research. We can't distribute that binary in Geotools. So either we lobby IBM to get them to change or we hack a dummy jar like all the other drivers. The latter is liable to be infinitely easier. Someday they will learn. --adrian On Wed, 2008-06-11 at 09:08 -0700, mcr wrote: >

Re: [Geotools-devel] Online tests and jdbc drivers

Attached is the license from the download. At the end the statement is to include thew following in the geotools README or LICENSE File - "CONTAINS Runtime Modules of IBM Data Server Driver for JDBC and SQLJ Version 4.0 (c) Copyright IBM Corporation 2007 All Rights Reserved"

Re: [Geotools-devel] Online tests and jdbc drivers

Hey both, Glad to hear you may have a resolution for this. However, we really can't just operate on "I think"; we are going to have to find the page that gives us permission, and copy the key language into a README or LICENSE file near that jar to show why we think we have the right to distribut

Re: [Geotools-devel] Online tests and jdbc drivers

I got a positive mail form David. It is possible to put the db2 driver jars in the maven repository. I did a download since I have a IBM developer login. Who is able to include these 3 jars in the repo, I would send a zip file including the jars. --- David ---

Re: [Geotools-devel] Online tests and jdbc drivers

mcr a écrit : > 4) Storing BLOBs as File and not in the database. > In my opinion, this works only for small/medium images. In my project the > largest pyramid has 250 tiles (yes, 2.5 millions). All maps together > produce about 10 millions tiles. The deployment platform is an AIX P5 using > 4

Re: [Geotools-devel] Online tests and jdbc drivers

Thanks for your comments. Here are mine 1) Your comments on ResX, ResY, MinX, MinY, MaxX,MaxY. These attributes are in the META Table which has one record for each pyramid level. MinX, MinY, MaxX,MaxY are information for the whole extent of a pyramid level. ResX, ResY are the resolution for the

Re: [Geotools-devel] Online tests and jdbc drivers

Hey, calm down. Since I am the developer of this module I want to get some things clear. 1) This module is intended to give geotools the same capabilities for image handling as ARCSDE does. 2) This module will support any jdbc database capable of handling BLOBs, additionally supporting ths spatia

Re: [Geotools-devel] Online tests and jdbc drivers

Ok, I sent to following mail to Dave - Hi Dave, I am working on this module http://docs.codehaus.org/display/GEOTOOLS/Image+Mosaicing+Pyramidal+JDBC+Plugin Since supporting DB2 is a major issue the following jar files are needed db2jcc.jar db2

Re: [Geotools-devel] Online tests and jdbc drivers

mcr wrote: > Another question regarding this module: > > http://docs.codehaus.org/display/GEOTOOLS/Image+Mosaicing+Pyramidal+JDBC+Plugin > > The Online Tests need the the jdbc jars for oracle,db2,postgis and mysql. > > 1) For Oracle I found > http://docs.codehaus.org/display/GEOT/4+Oracle+Opt

Re: [Geotools-devel] Online tests and jdbc drivers

We can imagine a number of reasons why an JDBC Mosaic other then PostGrid is wanted. It could be lighter, target a wider range of database backend, apply mosaic without the restriction on integral subsampling (this is a balance between memory usage, performance, capability to handle arbitrary sc

Re: [Geotools-devel] Online tests and jdbc drivers

Hey Christian, Glad you are tackling these hard questions and asking around for advice. Thanks for doing that. Unfortunately I can't help you personally since I don't have any answers on your questions but hopefully some else will. cheers, --adrian On Fri, 2008-06-06 at 04:10 -0700, mcr wr

Re: [Geotools-devel] Online tests and jdbc drivers

Ciao Vincent, I already answered this question a couple of months ago, I think Adrian was asking, but I can answer again. Christian Mueller has worked on a plugin since last year and he has been using it in production. Since I think it is ha shame to have a developer which is not contributing code

Re: [Geotools-devel] Online tests and jdbc drivers

Quoting your words one could say that Postgrid is a project that runs outside the GeoTools SVN and which is managed by what seems to be a subset of the geotools developers, hence it is not receiving enough feedback from the remaining geotools developers. Therefore we cannot trust it like we would

[Geotools-devel] Online tests and jdbc drivers

Another question regarding this module: http://docs.codehaus.org/display/GEOTOOLS/Image+Mosaicing+Pyramidal+JDBC+Plugin The Online Tests need the the jdbc jars for oracle,db2,postgis and mysql. 1) For Oracle I found http://docs.codehaus.org/display/GEOT/4+Oracle+Optional+Dependency The d

Re: [Geotools-devel] Online tests und fixtures

mcr wrote: > I am working at a new plugin: > http://docs.codehaus.org/display/GEOTOOLS/Image+Mosaicing+Pyramidal+JDBC+Plugin > > Since I need online tests for postgis,mysql,db2 and oracle I need the > corresponding fixtures. > 1) Are there predefined fixtures? > I don't think so; I think you

[Geotools-devel] Online tests und fixtures

I am working at a new plugin: http://docs.codehaus.org/display/GEOTOOLS/Image+Mosaicing+Pyramidal+JDBC+Plugin Since I need online tests for postgis,mysql,db2 and oracle I need the corresponding fixtures. 1) Are there predefined fixtures ? 2) Since my configuration files are xml files and fix

Re: [Geotools-devel] online tests being run these days?

We tried to set up a good way of running online test so that you could put fixtures in your home directory and have them engage / disengage the tests but that never really caught on. So basically just name your test *OnlineTest and it should engage when you run with the online profile. One thin

[Geotools-devel] online tests being run these days?

Hey all, Are online tests being run these days? I assume that the hudson build server isn't running them as they're probably really extensive. I'd love to integrate the ArcSDE test suite into running online tests so we can get that feedback to the public list. If someone can let me know the set

Re: [Geotools-devel] Online tests

Jody Garnett wrote: > Cory Horner wrote: > >> Any additions, or should we implement? > > Go go go :-D Ok!... I've taken some of the work that Justin and I did in the postgis2 module (regarding online tests) and ported it over to the postgis plugin, and got a single working example going. Some

Re: [Geotools-devel] Online tests

Rob Atkinson wrote: > Thanks guys - getting closer to a true understanding - more questions > inline.. > >>> As long as your module extends the root pom and doesn't override any of >>> the surefire configuration it should just work for you. >> > Does it automatically exclude Online* tests, or do

Re: [Geotools-devel] Online tests

Cory Horner wrote: >> I don't like it ... I love it!! :) >> >> Question though. Does it make sense to split the fixtures up into >> multiple files? Say named the same name as the fixture. I just think >> that removing a file would be easier than editing a single xml file and >> commenting out vario

Re: [Geotools-devel] Online tests

Justin Deoliveira wrote: >I don't like it ... I love it!! :) > >Question though. Does it make sense to split the fixtures up into >multiple files? Say named the same name as the fixture. I just think >that removing a file would be easier than editing a single xml file and >commenting out various f

Re: [Geotools-devel] Online tests

I don't like it ... I love it!! :) Question though. Does it make sense to split the fixtures up into multiple files? Say named the same name as the fixture. I just think that removing a file would be easier than editing a single xml file and commenting out various fixtures. -Justin Cory Horner w

Re: [Geotools-devel] Online tests

Thanks guys - getting closer to a true understanding - more questions inline.. Cory Horner wrote: > Justin Deoliveira wrote: > >> As to actually running the tests there are some docs here at the end of >> the page. >> >> http://docs.codehaus.org/display/GEOT/2.5.7+Testing+with+Maven >> >> As long

Re: [Geotools-devel] Online tests

Justin Deoliveira wrote: >As to actually running the tests there are some docs here at the end of >the page. > >http://docs.codehaus.org/display/GEOT/2.5.7+Testing+with+Maven > >As long as your module extends the root pom and doesn't override any of >the surefire configuration it should just work

Re: [Geotools-devel] Online tests

As to actually running the tests there are some docs here at the end of the page. http://docs.codehaus.org/display/GEOT/2.5.7+Testing+with+Maven As long as your module extends the root pom and doesn't override any of the surefire configuration it should just work for you. -Justin Rob Atkinson w

[Geotools-devel] Online tests

In the last IRC we discussed the process for setting up online tests. Apparently there is an Oracle and a PostGIS instance available - this is enough for me to set up online tests for the Geometryless data store, which is building and testing against GT trunk now. There was no obvious consensus

Re: [Geotools-devel] Online Tests and profile hacking

Justin Deoliveira ha scritto: > Just to chime in with my 2 cents. As a test case writer I would rather > use a naming convention in the test files I create rather then write > code that checks a system property. I have to do the same check in every > single test, what if the property changes, I the

Re: [Geotools-devel] Online Tests and profile hacking

Just to chime in with my 2 cents. As a test case writer I would rather use a naming convention in the test files I create rather then write code that checks a system property. I have to do the same check in every single test, what if the property changes, I then have to change it in every single te

Re: [Geotools-devel] Online Tests and profile hacking

Martin Desruisseaux ha scritto: > Cory Horner a écrit : >> The interactive.tests value seems reasonable to keep, as it is rarely >> used. The extensive.tests value however, seems to logically fit into >> a profile like the others we are discussing... > > The "extensive.tests" or "interactive.te

Re: [Geotools-devel] Online Tests and profile hacking

Cory Horner a écrit : > The interactive.tests value seems reasonable to keep, as it is rarely > used. The extensive.tests value however, seems to logically fit into a > profile like the others we are discussing... The "extensive.tests" or "interactive.tests" are system properties instead of pr

Re: [Geotools-devel] Online Tests and profile hacking

Andrea Aime wrote: > There are 2 environment variables extensives.tests and > >> interactive.tests, but these do not seem to be adopted -- and it >> seems a lot easier to just adopt a naming scheme for extensive tests >> (but interactive.tests could be useful). > > Wrong, they are both used. > E

Re: [Geotools-devel] Online Tests and profile hacking

Cory Horner ha scritto: > Howdy, > > I've just applied a change to the root pom, which sort of brings back > the -o option from maven 1. ... There are 2 environment variables extensives.tests and > interactive.tests, but these do not seem to be adopted -- and it seems a > lot easier to just

Re: [Geotools-devel] Online Tests and profile hacking

Justin Deoliveira wrote: >I just had the same problem in GeoServer while trying to create an "http >test" profile, which is basically the same thing as online tests in >geotools. So what about this. > >1. In the default profile, remove the exclusion of *OnlineTest and >*ExtensiveTest. > >2. Rename

Re: [Geotools-devel] Online Tests and profile hacking

Hi Cory, I just had the same problem in GeoServer while trying to create an "http test" profile, which is basically the same thing as online tests in geotools. So what about this. 1. In the default profile, remove the exclusion of *OnlineTest and *ExtensiveTest. 2. Rename all *OnlineTest 's to *

Re: [Geotools-devel] Online Tests and profile hacking

Justin Deoliveira wrote: >I think it might make more sense to >instead of having an offline profile, To have two profiles online, and >extensive, and keep the current default profile behavious. > >I say this because perhaps I want to make the default profile in my >module something different for w

Re: [Geotools-devel] Online Tests and profile hacking

Hi Cory, Nice work!! However one thing. I think it might make more sense to instead of having an offline profile, To have two profiles online, and extensive, and keep the current default profile behavious. I say this because perhaps I want to make the default profile in my module something differ

[Geotools-devel] Online Tests and profile hacking

Howdy, I've just applied a change to the root pom, which sort of brings back the -o option from maven 1. Rather than always excluding *OnlineTest.java from our suite of test cases, this has been moved to a profile which we have the option of enabling/disabling. At the moment, it is the defaul

Re: [Geotools-devel] Online tests

Ok, done. I also updated the docs. http://www.geotools.org/display/GEOTOOLS/Using+Maven -Justin James Macgill wrote: On 10/12/05, jgarnett <[EMAIL PROTECTED]> wrote: Justin Deoliveira wrote: Hello all, I fixed all the postgis tests and they all run against the database refractions has se

Re: [Geotools-devel] Online tests

On 10/12/05, jgarnett <[EMAIL PROTECTED]> wrote: > Justin Deoliveira wrote: > > Hello all, > > > > I fixed all the postgis tests and they all run against the database > > refractions has set up on www.refractions.net. > > > > I have renamed the tests to *OnlineTest.java as is now the convention. >

Re: [Geotools-devel] Online tests

Justin Deoliveira wrote: Hello all, I fixed all the postgis tests and they all run against the database refractions has set up on www.refractions.net. I have renamed the tests to *OnlineTest.java as is now the convention. However I found it a pain to run because anything named OnlineTest get

[Geotools-devel] Online tests

Hello all, I fixed all the postgis tests and they all run against the database refractions has set up on www.refractions.net. I have renamed the tests to *OnlineTest.java as is now the convention. However I found it a pain to run because anything named OnlineTest gets excluded by default.