Re: [Geotools-devel] Simple proposal on grid coverage clean up

2009-05-15 Thread Simone Giannecchini
I have updated the example, hopefully that makes a bit more cleare the scope of the changes. Simone. --- Ing. Simone Giannecchini GeoSolutions S.A.S. Owner - Software Engineer Via Carignoni 51 55041 Camaiore (LU) Italy phone: +39 0584983027 fax

Re: [Geotools-devel] Simple proposal on grid coverage clean up

2009-05-14 Thread Ben Caradoc-Davies
+1, looks good to me. Simone Giannecchini wrote: > Ciao guys, > I have been putting together this proposal: > > http://docs.codehaus.org/display/GEOTOOLS/GridEnvelope+subclasses+replacing+deprecated+GridRange+subclasses > > to start cleaning up things in geotools coverage module. This time is >

Re: [Geotools-devel] Simple proposal on grid coverage clean up

2009-05-14 Thread Michael Bedward
2009/5/15 Jody Garnett wrote: > Well it is not super important ... can you just talk me through this > second code example: > Like Jody, I'm also confused by the second code example... But I've no problems with supporting the cleanup Simone - thanks. Michael

Re: [Geotools-devel] Simple proposal on grid coverage clean up

2009-05-14 Thread Jody Garnett
Well it is not super important ... can you just talk me through this second code example: import org.geotools.coverage.grid.GeneralGridEnvelope; GridEnvelope2D originalGridRange=... final int w = originalGridRange.getSpan(0); final int maxx = originalGridRange.getHigh(0)+1; GridEnvelope2D origin

Re: [Geotools-devel] Simple proposal on grid coverage clean up

2009-05-14 Thread Simone Giannecchini
Ciao Martin, nice seeing that you are still lurking on this list. I have put the email link on purpose to show that there had been little communication (which is different from no communication at all as you know). Nevertheless, me, likewise the other coverage plugins developers (gabriel, christian

Re: [Geotools-devel] Simple proposal on grid coverage clean up

2009-05-14 Thread Martin Desruisseaux
Hello all Simone Giannecchini a écrit : > to start cleaning up things in geotools coverage module. This time is > the turn of GridRange subclasses which become deprecated all of a > sudden last summer with very little communication. Just for completness for those who read the list, those classes

Re: [Geotools-devel] Simple proposal on grid coverage clean up

2009-05-14 Thread Gabriel Roldan
Hi Simone, thanks for the patch. I've applied it and everything seems to be going well. Also, the timing is just good cause I'm starting to work over http://jira.codehaus.org/browse/GEOS-2748, and need to check how I compute the resulting envelope of a query. all in all the patch works. Gabr

Re: [Geotools-devel] Simple proposal on grid coverage clean up

2009-05-14 Thread Simone Giannecchini
You are right jody, nothing strategic, just clean up. However, I think that making this change clear is quite helpful since it impacts coverage plugins and client applications like GeoServer (and udig as well), therefore I preferred to see if anyone had any problems with it. Simone. --

Re: [Geotools-devel] Simple proposal on grid coverage clean up

2009-05-14 Thread Simone Giannecchini
Ciao Christian, you can try the patch I have sent and let me know. Simone. --- Ing. Simone Giannecchini GeoSolutions S.A.S. Owner - Software Engineer Via Carignoni 51 55041 Camaiore (LU) Italy phone: +39 0584983027 fax: +39 0584983027 mob:

Re: [Geotools-devel] Simple proposal on grid coverage clean up

2009-05-14 Thread Christian Müller
The imagemosaic-jdbc also is influenced. But I am lucky, I have only two references, one of them in tests. Its ok for me. Justin Deoliveira writes: > While knowing very little about coverages I read over the proposal and > it looks good to me. It gets my +1. > > Simone Giannecchini wrote:

Re: [Geotools-devel] Simple proposal on grid coverage clean up

2009-05-14 Thread Simone Giannecchini
Well, ask away so that we can clarify. Simone. --- Ing. Simone Giannecchini GeoSolutions S.A.S. Owner - Software Engineer Via Carignoni 51 55041 Camaiore (LU) Italy phone: +39 0584983027 fax: +39 0584983027 mob:+39 333 8128928 http:/

Re: [Geotools-devel] Simple proposal on grid coverage clean up

2009-05-14 Thread Jody Garnett
I see; in general for this kind of "technical debt" stuff we may not need a change proposal; especially as you are now the module maintainer. There is nothing stratigic here right - just trying to clean up work that was not completed. So while I still do not feel I get it; the reference to a 2d da

Re: [Geotools-devel] Simple proposal on grid coverage clean up

2009-05-14 Thread Simone Giannecchini
Ciao Jody, the problem is that there is not much to understand :-). I am trying to clean up a work left halfway, triggere by an unilateral change in geoapi. To simplify, in the past we where using GridRange implementations then all at a sudden I notice that they were deprecated and replaced with so

Re: [Geotools-devel] Simple proposal on grid coverage clean up

2009-05-14 Thread Justin Deoliveira
While knowing very little about coverages I read over the proposal and it looks good to me. It gets my +1. Simone Giannecchini wrote: > Ciao guys, > I have been putting together this proposal: > > http://docs.codehaus.org/display/GEOTOOLS/GridEnvelope+subclasses+replacing+deprecated+GridRange+su

Re: [Geotools-devel] Simple proposal on grid coverage clean up

2009-05-14 Thread Jody Garnett
I do not feel I understand what this change covers ... what is this data structure used for - I am trying to pick up some context here; it appears as if the replacement is 2d only? GridEnvelope2D Are we not trying for a multiple dimensional expression of range here? rectangle has getWidth and getH

Re: [Geotools-devel] Simple proposal on grid coverage clean up

2009-05-14 Thread Gabriel Roldan
Sounds good to me. So you do have a patch for the arcsde module? if so please send it my way for my to test it cause I don't think your testing included running the arcsde gce tests. Thanks, Gabriel Simone Giannecchini wrote: > Ciao guys, > I have been putting together this proposal: > > ht

[Geotools-devel] Simple proposal on grid coverage clean up

2009-05-14 Thread Simone Giannecchini
Ciao guys, I have been putting together this proposal: http://docs.codehaus.org/display/GEOTOOLS/GridEnvelope+subclasses+replacing+deprecated+GridRange+subclasses to start cleaning up things in geotools coverage module. This time is the turn of GridRange subclasses which become deprecated all of