Change in osmo-bts[master]: loops.h: Fix missing include for struct l1sched_trx

2019-10-25 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15878 ) Change subject: loops.h: Fix missing include for struct l1sched_trx .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: bts-trx: loops.c: Follow BSC CHAN ACT ms power level restrictions

2019-10-25 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15877 ) Change subject: bts-trx: loops.c: Follow BSC CHAN ACT ms power level restrictions .. Patch Set 2: (1 comment)

Change in osmo-bts[master]: cosmetic: bts-trx: document variable and fix typo in ms_power_diff()

2019-10-25 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15876 ) Change subject: cosmetic: bts-trx: document variable and fix typo in ms_power_diff() .. Patch Set 1: Code-Review-1 (1 comment)

Change in osmo-bts[master]: cosmetic: l1sap.c: Fix typo

2019-10-25 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15879 ) Change subject: cosmetic: l1sap.c: Fix typo .. cosmetic: l1sap.c: Fix typo Change-Id: I9fee7be915546cfd11810c74d511beb8ec10d044 ---

Change in osmo-bts[master]: bts-trx: loops.c: Follow BSC CHAN ACT ms power level restrictions

2019-10-25 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15877 ) Change subject: bts-trx: loops.c: Follow BSC CHAN ACT ms power level restrictions .. Patch Set 2: I have the feeling a similar fix

Change in osmo-bts[master]: loops.h: Fix missing include for struct l1sched_trx

2019-10-25 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15878 ) Change subject: loops.h: Fix missing include for struct l1sched_trx .. loops.h: Fix missing include for struct l1sched_trx

Change in osmo-bts[master]: bts-trx: loops.c: Follow BSC CHAN ACT ms power level restrictions

2019-10-25 Thread pespin
Hello fixeria, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/15877 to look at the new patch set (#2). Change subject: bts-trx: loops.c: Follow BSC CHAN ACT ms power level restrictions

Change in osmo-bts[master]: bts-trx: loops.c: Follow BSC CHAN ACT ms power level restrictions

2019-10-25 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15877 ) Change subject: bts-trx: loops.c: Follow BSC CHAN ACT ms power level restrictions .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-bts[master]: cosmetic: bts-trx: document variable and fix typo in ms_power_diff()

2019-10-25 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15876 ) Change subject: cosmetic: bts-trx: document variable and fix typo in ms_power_diff() .. Patch Set 1: Code-Review+2 -- To view,

Change in osmo-bts[master]: bts-trx: loops.c: Follow BSC CHAN ACT ms power level restrictions

2019-10-25 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15877 ) Change subject: bts-trx: loops.c: Follow BSC CHAN ACT ms power level restrictions .. bts-trx: loops.c: Follow BSC CHAN ACT ms power

Change in osmo-bts[master]: cosmetic: bts-trx: document variable and fix typo in ms_power_diff()

2019-10-25 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15876 ) Change subject: cosmetic: bts-trx: document variable and fix typo in ms_power_diff() .. cosmetic: bts-trx: document variable and

Change in osmo-msc[master]: log: RANAP encode: use RANAP message names instead of BSSAP

2019-10-25 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15847 ) Change subject: log: RANAP encode: use RANAP message names instead of BSSAP .. Patch Set 1: (1 comment)

Change in libosmocore[master]: fsm: add osmo_fsm_set_term_stops_actions()

2019-10-25 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15833 ) Change subject: fsm: add osmo_fsm_set_term_stops_actions() .. Patch Set 1: Code-Review+2 (1 comment)

Change in libosmocore[master]: add osmo_fsm_set_dealloc_ctx(), to help with use-after-free

2019-10-25 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15677 ) Change subject: add osmo_fsm_set_dealloc_ctx(), to help with use-after-free .. Patch Set 2: (1 comment)

Change in libosmocore[master]: add osmo_sockaddr_str_is_nonzero()

2019-10-25 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15835 ) Change subject: add osmo_sockaddr_str_is_nonzero() .. Patch Set 2: Code-Review+1 -- To view, visit

Change in libosmocore[master]: gsm0508: add functions to calculate beginning of a block

2019-10-25 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15719 ) Change subject: gsm0508: add functions to calculate beginning of a block .. Patch Set 9: Code-Review+1 -- To view, visit

Change in libosmocore[master]: gsm0508: add functions to calculate beginning of a block

2019-10-25 Thread dexter
Hello fixeria, daniel, laforge, Jenkins Builder, Hoernchen, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/15719 to look at the new patch set (#9). Change subject: gsm0508: add functions to calculate beginning of a block

Build failed in Jenkins: master-simtrace2 » a1=default,a2=default,a3=default,a4=default,osmocom-master-debian9 #548

2019-10-25 Thread jenkins
See Changes: [jsteiger] add/fix mcp23017 i2c gpio expander functions and tests --

Change in osmo-msc[master]: log: RANAP encode: use RANAP message names instead of BSSAP

2019-10-25 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15847 ) Change subject: log: RANAP encode: use RANAP message names instead of BSSAP .. Patch Set 1: Code-Review+1 (1 comment)

Change in simtrace2[master]: add/fix mcp23017 i2c gpio expander functions and tests

2019-10-25 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/15875 ) Change subject: add/fix mcp23017 i2c gpio expander functions and tests .. add/fix mcp23017 i2c gpio expander functions and tests Change-Id:

Change in simtrace2[master]: add/fix mcp23017 i2c gpio expander functions and tests

2019-10-25 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/15875 ) Change subject: add/fix mcp23017 i2c gpio expander functions and tests .. Patch Set 1: Code-Review+2 -- To view, visit

Change in docker-playground[master]: Introduce ttcn3-stp-test

2019-10-25 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/15872 ) Change subject: Introduce ttcn3-stp-test .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmocore[master]: gsm0508: add functions to calculate beginning of a block

2019-10-25 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15719 ) Change subject: gsm0508: add functions to calculate beginning of a block .. Patch Set 8: Code-Review+1 -- To view, visit

Change in libosmocore[master]: gsm0508: add functions to calculate beginning of a block

2019-10-25 Thread dexter
Hello fixeria, daniel, Jenkins Builder, Hoernchen, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/15719 to look at the new patch set (#8). Change subject: gsm0508: add functions to calculate beginning of a block

Build failed in Jenkins: master-simtrace2 » a1=default,a2=default,a3=default,a4=default,osmocom-master-debian9 #547

2019-10-25 Thread jenkins
See -- [...truncated 157.48 KB...] 320 0 0 320 140

Change in libosmocore[master]: Add code coverage support

2019-10-25 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/13496 ) Change subject: Add code coverage support .. Patch Set 6: > Let me know if I have to modify some of the ansible playbooks. I am

Change in libosmocore[master]: Add code coverage support

2019-10-25 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/13496 ) Change subject: Add code coverage support .. Patch Set 6: Code-Review+1 We definitely should move this work forward. -- To

Change in libosmocore[master]: fsm_dealloc_test: enable term_stops_actions

2019-10-25 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15834 ) Change subject: fsm_dealloc_test: enable term_stops_actions .. Patch Set 1: (1 comment)

Change in libosmocore[master]: fsm: add osmo_fsm_set_term_stops_actions()

2019-10-25 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15833 ) Change subject: fsm: add osmo_fsm_set_term_stops_actions() .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmocore[master]: add osmo_fsm_set_dealloc_ctx(), to help with use-after-free

2019-10-25 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15677 ) Change subject: add osmo_fsm_set_dealloc_ctx(), to help with use-after-free .. Patch Set 2: Code-Review+1 -- To view, visit