Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: do not suppress rc of gsup_client_mux_tx()

2019-06-17 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14502 Change subject: libmsc/gsm_09_11.c: do not suppress rc of gsup_client_mux_tx() .. libmsc/gsm_09_11.c: do not suppress rc

Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: do not abuse LOG_TRANS() and early trans allocation

2019-06-17 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/14463 ) Change subject: libmsc/gsm_09_11.c: do not abuse LOG_TRANS() and early trans allocation .. libmsc/gsm_09_11.c: do not abuse

Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: log network-originated session establishment error

2019-06-17 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/14464 ) Change subject: libmsc/gsm_09_11.c: log network-originated session establishment error .. libmsc/gsm_09_11.c: log network

Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: do not abuse LOG_TRANS() in gsm0911_rcv_nc_ss()

2019-06-17 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14501 Change subject: libmsc/gsm_09_11.c: do not abuse LOG_TRANS() in gsm0911_rcv_nc_ss() .. libmsc/gsm_09_11.c: do not abuse LOG_TRANS

Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: properly handle OSMO_GSUP_MSGT_PROC_SS_ERROR

2019-06-17 Thread fixeria
Gerrit-Change-Id: I076d12ef24d7320eda1df1ee4588da7375ef3d9e Gerrit-Change-Number: 14477 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: do not abuse LOG_TRANS() and early trans allocation

2019-06-17 Thread fixeria
-msc Gerrit-Branch: master Gerrit-Change-Id: I4e027b19e8065a39324a1647957cef4066b82ce7 Gerrit-Change-Number: 14463 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset

Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: properly handle OSMO_GSUP_MSGT_PROC_SS_ERROR

2019-06-17 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14477 ) Change subject: libmsc/gsm_09_11.c: properly handle OSMO_GSUP_MSGT_PROC_SS_ERROR .. Patch Set 1: (1 comment) https

Change in ...osmo-bsc[master]: Remove extern declarations of libosmovty symbols

2019-06-18 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14492 ) Change subject: Remove extern declarations of libosmovty symbols .. Patch Set 2: Code-Review+1 -- To view, visit https

Change in ...osmo-msc[master]: tests/msc_vlr: fix: do not pass RAT type to expect_bssap_clear()

2019-06-18 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14514 Change subject: tests/msc_vlr: fix: do not pass RAT type to expect_bssap_clear() .. tests/msc_vlr: fix: do not pass RAT type

Change in ...osmo-ttcn3-hacks[master]: hlr: add create-subscriber-on-demand tests

2019-06-17 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14424 ) Change subject: hlr: add create-subscriber-on-demand tests .. Patch Set 4: Code-Review+2 -- To view, visit https

Change in ...osmo-pcu[master]: decompress_crbb: add length argument for search_runlen

2019-06-22 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14481 ) Change subject: decompress_crbb: add length argument for search_runlen .. Patch Set 2: Code-Review+1 -- To view, visit https

Change in ...osmo-pcu[master]: Encoding: drop struct gprs_rlcmac_bts* from all functions

2019-06-22 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14570 ) Change subject: Encoding: drop struct gprs_rlcmac_bts* from all functions .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in ...osmo-pcu[master]: rlc: replace int with uint16_t

2019-06-22 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14569 ) Change subject: rlc: replace int with uint16_t .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo

Change in ...osmo-pcu[master]: tests/BitcompTest: fix wording in log message

2019-06-22 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14482 ) Change subject: tests/BitcompTest: fix wording in log message .. Patch Set 2: Code-Review+2 -- To view, visit https

Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: implement header version coding

2019-06-22 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14576 Change subject: trx_toolkit/data_msg.py: implement header version coding .. trx_toolkit/data_msg.py: implement header version

Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: add basic class documentation

2019-06-22 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14575 Change subject: trx_toolkit/data_msg.py: add basic class documentation .. trx_toolkit/data_msg.py: add basic class documentation

Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: drop double field initialization

2019-06-22 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14573 Change subject: trx_toolkit/data_msg.py: drop double field initialization .. trx_toolkit/data_msg.py: drop double field

Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: inline both gen_fn() and parse_fn()

2019-06-22 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14574 Change subject: trx_toolkit/data_msg.py: inline both gen_fn() and parse_fn() .. trx_toolkit/data_msg.py: inline both gen_fn

Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: tests: use random reference data

2019-06-22 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14572 Change subject: trx_toolkit/data_msg.py: tests: use random reference data .. trx_toolkit/data_msg.py: tests: use random reference

Change in ...libosmocore[master]: logging: Use reentrant ctime_r instead of ctime

2019-06-13 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14429 ) Change subject: logging: Use reentrant ctime_r instead of ctime .. Patch Set 3: Code-Review+1 (1 comment) https

Change in ...libosmocore[master]: logging: Check return error from time() call

2019-06-12 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14432 ) Change subject: logging: Check return error from time() call .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...libosmocore[master]: logging: Use reentrant ctime_r instead of ctime

2019-06-12 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14429 ) Change subject: logging: Use reentrant ctime_r instead of ctime .. Patch Set 2: Code-Review+1 (1 comment) https

Change in ...libosmocore[master]: vty: command.c: Get rid of huge indentation block

2019-06-12 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14428 ) Change subject: vty: command.c: Get rid of huge indentation block .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...libosmocore[master]: cosmetic: vty: command.c: Use upper case for enum match_type value names

2019-06-12 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14427 ) Change subject: cosmetic: vty: command.c: Use upper case for enum match_type value names .. Patch Set 1: Code-Review+2

Change in ...libosmocore[master]: vty: tests: Verify incomplete optional parameters are passed to vty f...

2019-06-12 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14431 ) Change subject: vty: tests: Verify incomplete optional parameters are passed to vty funcs .. Patch Set 1: Code-Review+2

Change in ...libosmocore[master]: vty: command.c: Get rid of big indentation block

2019-06-12 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14430 ) Change subject: vty: command.c: Get rid of big indentation block .. Patch Set 1: Code-Review-1 (2 comments) https

Change in ...osmo-sgsn[master]: sgsn: Have authentication required on by default

2019-06-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14445 ) Change subject: sgsn: Have authentication required on by default .. Patch Set 2: Code-Review-1 Please see: http

Change in ...libosmocore[master]: vty: command.c: Get rid of big indentation block

2019-06-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14430 ) Change subject: vty: command.c: Get rid of big indentation block .. Patch Set 2: Code-Review+1 (5 comments) My warnings

Change in ...osmo-msc[master]: libvlr: fix sgsn tmsi creation, replace constant with define

2019-06-17 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14448 ) Change subject: libvlr: fix sgsn tmsi creation, replace constant with define .. Patch Set 3: Code-Review+2 -- To view, visit https

Change in ...osmo-msc[master]: libvlr: fix sgsn tmsi creation, replace constant with define

2019-06-17 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14448 ) Change subject: libvlr: fix sgsn tmsi creation, replace constant with define .. Patch Set 3: (1 comment) https

Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: properly handle OSMO_GSUP_MSGT_PROC_SS_ERROR

2019-06-17 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/14477 ) Change subject: libmsc/gsm_09_11.c: properly handle OSMO_GSUP_MSGT_PROC_SS_ERROR .. libmsc/gsm_09_11.c: properly handle

Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: drop rudimentary vsub->cgi.lai.lac check

2019-06-17 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/14465 ) Change subject: libmsc/gsm_09_11.c: drop rudimentary vsub->cgi.lai.lac check .. libmsc/gsm_09_11.c: drop rudimentary v

Change in ...osmo-msc[master]: libmsc/msc_net_init.c: pass pointer to gsm_network directly

2019-06-17 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/14467 ) Change subject: libmsc/msc_net_init.c: pass pointer to gsm_network directly .. libmsc/msc_net_init.c: pass pointer

Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: inform HLR/EUSE if Paging has failed

2019-06-17 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/14475 ) Change subject: libmsc/gsm_09_11.c: inform HLR/EUSE if Paging has failed .. libmsc/gsm_09_11.c: inform HLR/EUSE if Paging

Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: drop meaningless check for concurrent paging

2019-06-17 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/14466 ) Change subject: libmsc/gsm_09_11.c: drop meaningless check for concurrent paging .. libmsc/gsm_09_11.c: drop meaningless

Change in ...osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: introduce TC_mo_ussd_for_unknown_trans

2019-06-17 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14503 Change subject: MSC_Tests.ttcn: introduce TC_mo_ussd_for_unknown_trans .. MSC_Tests.ttcn: introduce

Change in ...osmo-msc[master]: manuals: Update counter/vty documentation

2019-06-17 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14495 ) Change subject: manuals: Update counter/vty documentation .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: msc/expected-results.xml: update SS and SMS related expectations

2019-06-17 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14504 Change subject: msc/expected-results.xml: update SS and SMS related expectations .. msc/expected-results.xml: update SS

Change in ...osmo-hlr[master]: manuals: Update vty documentation

2019-06-17 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14498 ) Change subject: manuals: Update vty documentation .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c

Change in ...osmo-msc[master]: libvlr/vlr.c: do not expire subscribers if periodic LU is disabled

2019-06-19 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14525 Change subject: libvlr/vlr.c: do not expire subscribers if periodic LU is disabled .. libvlr/vlr.c: do not expire subscribers

Change in ...osmo-msc[master]: libmsc/gsm_04_11.c: do not abuse LOG_TRANS() in gsm411_alloc_mt_trans()

2019-06-19 Thread fixeria
Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in ...osmo-msc[master]: libmsc/gsm_04_11.c: do not abuse LOG_TRANS() in gsm411_alloc_mt_trans()

2019-06-19 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14541 Change subject: libmsc/gsm_04_11.c: do not abuse LOG_TRANS() in gsm411_alloc_mt_trans() .. libmsc/gsm_04_11.c: do not abuse

Change in ...osmo-msc[master]: gsm_04_11_gsup.c: fix broken reference counting for vsub

2019-06-19 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14540 Change subject: gsm_04_11_gsup.c: fix broken reference counting for vsub .. gsm_04_11_gsup.c: fix broken reference counting for vsub

Change in ...osmo-ttcn3-hacks[master]: library/RAN_Emulation.ttcnpp: fix: properly handle SAPI / DLCI for RANAP

2019-06-19 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14551 Change subject: library/RAN_Emulation.ttcnpp: fix: properly handle SAPI / DLCI for RANAP .. library/RAN_Emulation.ttcnpp

Change in ...osmo-ttcn3-hacks[master]: library/ranap: enrich both t(s|r)_RANAP_DirectTransfer templates

2019-06-19 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14550 Change subject: library/ranap: enrich both t(s|r)_RANAP_DirectTransfer templates .. library/ranap: enrich both t(s|r

Change in ...osmo-ttcn3-hacks[master]: library/RAN_Emulation.ttcnpp: fix: properly handle SAPI / DLCI for RANAP

2019-06-19 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14551 ) Change subject: library/RAN_Emulation.ttcnpp: fix: properly handle SAPI / DLCI for RANAP .. Patch Set 1: (1 comment

Change in ...osmo-ttcn3-hacks[master]: MSC_Tests_Iu.ttcn: fix TC_iu_lu_and_mo_ussd_mo_release(): use proper ...

2019-06-19 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14553 Change subject: MSC_Tests_Iu.ttcn: fix TC_iu_lu_and_mo_ussd_mo_release(): use proper BSC number .. MSC_Tests_Iu.ttcn: fix

Change in ...osmo-msc[master]: libmsc/ran_msg_iu.c: fix: properly handle SAPI IE of RANAP_DirectTran...

2019-06-19 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14552 Change subject: libmsc/ran_msg_iu.c: fix: properly handle SAPI IE of RANAP_DirectTransfer .. libmsc/ran_msg_iu.c: fix: properly

Change in ...osmo-msc[master]: sms_queue.c: Improve misleading log line

2019-06-20 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14554 ) Change subject: sms_queue.c: Improve misleading log line .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: library/RAN_Emulation.ttcnpp: fix: properly handle SAPI / DLCI for RANAP

2019-06-20 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14551 ) Change subject: library/RAN_Emulation.ttcnpp: fix: properly handle SAPI / DLCI for RANAP .. Set Ready For Review

Change in ...osmo-ttcn3-hacks[master]: library/ranap: enrich both t(s|r)_RANAP_DirectTransfer templates

2019-06-20 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14550 ) Change subject: library/ranap: enrich both t(s|r)_RANAP_DirectTransfer templates .. Set Ready For Review -- To view, visit

Change in ...docker-playground[master]: ttcn3-hlr-test: log to file and gsmtap

2019-06-21 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14563 ) Change subject: ttcn3-hlr-test: log to file and gsmtap .. Patch Set 2: I vote for having GSMTAP logs in all projects

Change in ...libosmo-abis[master]: ipaccess: allow tcp keepalive for ipa clients, add TCP_USER_TIMEOUT

2019-06-21 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14562 ) Change subject: ipaccess: allow tcp keepalive for ipa clients, add TCP_USER_TIMEOUT .. Patch Set 2: Code-Review+1 -- To view

Change in ...libosmocore[master]: bitvec: bitvec_get_uint() should return an unsigned int

2019-06-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14577 ) Change subject: bitvec: bitvec_get_uint() should return an unsigned int .. Patch Set 2: (1 comment) https://gerrit.osmocom.org

Change in ...libosmocore[master]: bitvec: bitvec_get_uint() should return an unsigned int

2019-06-22 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14577 ) Change subject: bitvec: bitvec_get_uint() should return an unsigned int .. Patch Set 2: Code-Review-1 (1 comment) https

Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: implement header version 0x01 coding

2019-06-23 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14579 Change subject: trx_toolkit/data_msg.py: implement header version 0x01 coding .. trx_toolkit/data_msg.py: implement header version

Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: implement header version coding

2019-06-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14576 ) Change subject: trx_toolkit/data_msg.py: implement header version coding .. Set Ready For Review -- To view, visit https

Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: inline both gen_fn() and parse_fn()

2019-06-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14574 ) Change subject: trx_toolkit/data_msg.py: inline both gen_fn() and parse_fn() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: drop double field initialization

2019-06-23 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14573 ) Change subject: trx_toolkit/data_msg.py: drop double field initialization .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: implement header version 0x01 coding

2019-06-23 Thread fixeria
fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmocom-bb/+/14579 ) Change subject: trx_toolkit/data_msg.py: implement header version 0x01 coding .. trx_toolkit/data_msg.py: implement header version

Change in ...osmo-bts[master]: RSL: Fix fixed MS power control in RSL CHAN ACTIV

2019-06-22 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14489 ) Change subject: RSL: Fix fixed MS power control in RSL CHAN ACTIV .. Patch Set 2: Code-Review+1 -- To view, visit https

Change in ...osmo-pcu[master]: decompress_crbb: replace int8_t with uint8_t as length

2019-06-22 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14480 ) Change subject: decompress_crbb: replace int8_t with uint8_t as length .. Patch Set 1: Code-Review-1 (2 comments) https

Change in ...osmocom-bb[master]: trxcon/scheduler: fix bit shift in BSIC / TDMA FN calculation

2019-06-24 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14581 ) Change subject: trxcon/scheduler: fix bit shift in BSIC / TDMA FN calculation .. Patch Set 2: Code-Review+1 -- To view, visit

Change in ...osmocom-bb[master]: trx_toolkit/fake_trx.py: introduce a TRXC command for C/I simulation

2019-06-24 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14586 Change subject: trx_toolkit/fake_trx.py: introduce a TRXC command for C/I simulation .. trx_toolkit/fake_trx.py: introduce a TRXC

Change in ...osmocom-bb[master]: trx_toolkit/fake_trx.py: add basic TRXD version 0x01 support

2019-06-24 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14585 Change subject: trx_toolkit/fake_trx.py: add basic TRXD version 0x01 support .. trx_toolkit/fake_trx.py: add basic TRXD version

Change in ...osmo-pcu[master]: Cosmetic: Osmcoom -> Osmocom

2019-06-24 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14580 ) Change subject: Cosmetic: Osmcoom -> Osmocom .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-

Change in ...osmocom-bb[master]: trxcon/scheduler: fix bit shift in BSIC / TDMA FN calculation

2019-06-24 Thread fixeria
fixeria has uploaded a new patch set (#2) to the change originally created by Hoernchen. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14581 ) Change subject: trxcon/scheduler: fix bit shift in BSIC / TDMA FN calculation

Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: tests: use random reference data

2019-06-24 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14572 ) Change subject: trx_toolkit/data_msg.py: tests: use random reference data .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: legacy flag is only for version 0x00

2019-06-24 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14584 Change subject: trx_toolkit/data_msg.py: legacy flag is only for version 0x00 .. trx_toolkit/data_msg.py: legacy flag is only

Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: add basic class documentation

2019-06-24 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14575 ) Change subject: trx_toolkit/data_msg.py: add basic class documentation .. trx_toolkit/data_msg.py: add basic class

Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: drop double field initialization

2019-06-24 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14573 ) Change subject: trx_toolkit/data_msg.py: drop double field initialization .. trx_toolkit/data_msg.py: drop double field

Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: tests: use random reference data

2019-06-24 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14572 ) Change subject: trx_toolkit/data_msg.py: tests: use random reference data .. trx_toolkit/data_msg.py: tests: use random

Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: inline both gen_fn() and parse_fn()

2019-06-24 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14574 ) Change subject: trx_toolkit/data_msg.py: inline both gen_fn() and parse_fn() .. trx_toolkit/data_msg.py: inline both

Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: add basic class documentation

2019-06-24 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14575 ) Change subject: trx_toolkit/data_msg.py: add basic class documentation .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: hlr: add create-subscriber-on-demand tests

2019-06-12 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14424 ) Change subject: hlr: add create-subscriber-on-demand tests .. Patch Set 3: Code-Review+1 -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: hlr: add Check IMEI tests

2019-06-12 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14402 ) Change subject: hlr: add Check IMEI tests .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c

Change in ...osmo-ttcn3-hacks[master]: hlr: add f_vty_subscr_show_nomatch()

2019-06-12 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14401 ) Change subject: hlr: add f_vty_subscr_show_nomatch() .. Patch Set 3: Code-Review+1 -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: use f_expect_gsup_msg() in f_tc_mt_ussd_for_unknown_s...

2019-06-15 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14459 Change subject: MSC_Tests.ttcn: use f_expect_gsup_msg() in f_tc_mt_ussd_for_unknown_subscr() .. MSC_Tests.ttcn: use

Change in ...osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: introduce TC_proc_ss_for_unknown_session

2019-06-15 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14460 Change subject: MSC_Tests.ttcn: introduce TC_proc_ss_for_unknown_session .. MSC_Tests.ttcn: introduce

Change in ...osmo-ttcn3-hacks[master]: sgsn: add osmo-sgsn.cfg, SGSN_Tests.cfg

2019-06-18 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14505 ) Change subject: sgsn: add osmo-sgsn.cfg, SGSN_Tests.cfg .. Patch Set 1: Code-Review+1 (2 comments) https

Change in ...osmo-ttcn3-hacks[master]: sgsn: add osmo-sgsn.cfg, SGSN_Tests.cfg

2019-06-18 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14505 ) Change subject: sgsn: add osmo-sgsn.cfg, SGSN_Tests.cfg .. Patch Set 2: Code-Review+2 Looks fine and clean now

Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: implement header version coding

2019-07-03 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14576 ) Change subject: trx_toolkit/data_msg.py: implement header version coding .. Patch Set 4: Code-Review+2 -- To view, visit https

Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: introduce header coding version 0x01

2019-07-03 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14579 ) Change subject: trx_toolkit/data_msg.py: introduce header coding version 0x01 .. Patch Set 5: Code-Review+2 -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: library/L1CTL_Types.ttcn: introduce TRAFFIC_{REQ|IND} templates

2019-07-03 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14659 Change subject: library/L1CTL_Types.ttcn: introduce TRAFFIC_{REQ|IND} templates .. library/L1CTL_Types.ttcn: introduce

Change in ...osmo-ttcn3-hacks[master]: library/TRXC_Types.ttcn: add FAKE_CI command for C/I simulation

2019-07-03 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14658 Change subject: library/TRXC_Types.ttcn: add FAKE_CI command for C/I simulation .. library/TRXC_Types.ttcn: add FAKE_CI

Change in ...osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: introduce TC_pcu_data_ind_lqual_cb

2019-07-03 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14660 Change subject: BTS_Tests.ttcn: introduce TC_pcu_data_ind_lqual_cb .. BTS_Tests.ttcn: introduce TC_pcu_data_ind_lqual_cb

Change in ...osmo-trx[master]: Transceiver: Support pulling idle frames in pullRadioVector()

2019-07-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14664 ) Change subject: Transceiver: Support pulling idle frames in pullRadioVector() .. Patch Set 1: Code-Review+1 -- To view, visit

Change in ...osmo-trx[master]: Transceiver: pullRadioVector(): Move initialization of var to start o...

2019-07-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14663 ) Change subject: Transceiver: pullRadioVector(): Move initialization of var to start of function .. Patch Set 1: Code-Review+1

Change in ...osmo-trx[master]: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind

2019-07-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14643 ) Change subject: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind .. Patch Set 2: Code-Review+1 (1 comment

Change in ...osmo-trx[master]: Transceiver: Move calculation of normalized values (rssiOffset) to pu...

2019-07-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14640 ) Change subject: Transceiver: Move calculation of normalized values (rssiOffset) to pullRadioVector() .. Patch Set 2: Code-Review+1

Change in ...osmo-trx[master]: Transceiver: Simplify code on early error return when calling detectA...

2019-07-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14662 ) Change subject: Transceiver: Simplify code on early error return when calling detectAnyBurst .. Patch Set 1: Code-Review+1

Change in ...osmo-trx[master]: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind

2019-07-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14642 ) Change subject: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind .. Patch Set 2: Code-Review+1 -- To view, visit https

Change in ...osmo-trx[master]: Transceiver: Move soft bits normalization to pullRadioVector()

2019-07-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14641 ) Change subject: Transceiver: Move soft bits normalization to pullRadioVector() .. Patch Set 2: Code-Review+1 -- To view, visit

Change in ...osmo-trx[master]: Transceiver: Avoid noise calculation formula in 2 branches in pullRad...

2019-07-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14661 ) Change subject: Transceiver: Avoid noise calculation formula in 2 branches in pullRadioVector .. Patch Set 1: Code-Review+1 (1

Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: request the newest TRXD header version

2019-07-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14611 ) Change subject: osmo-bts-trx/trx_if.c: request the newest TRXD header version .. Patch Set 5: (5 comments) https

Change in ...osmo-trx[master]: Transceiver: replace UDPSocket with libosmocore socket API

2019-07-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14644 ) Change subject: Transceiver: replace UDPSocket with libosmocore socket API .. Patch Set 2: Code-Review+1 -- To view, visit https

Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: introduce TRXD header version handling

2019-07-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14592 ) Change subject: osmo-bts-trx/trx_if.c: introduce TRXD header version handling .. Patch Set 3: (1 comment) https

Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: request the newest TRXD header version

2019-07-04 Thread fixeria
Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: ipse Gerrit-MessageType: newpatchset

Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: implement header version coding

2019-07-03 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14576 ) Change subject: trx_toolkit/data_msg.py: implement header version coding .. trx_toolkit/data_msg.py: implement header

Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: legacy flag is only for version 0x00

2019-07-03 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14584 ) Change subject: trx_toolkit/data_msg.py: legacy flag is only for version 0x00 .. trx_toolkit/data_msg.py: legacy flag

<    1   2   3   4   5   6   7   8   9   10   >