Change in osmo-bsc[master]: gsm_04_80: Avoid using deprecated API

2019-12-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/16476 ) Change subject: gsm_04_80: Avoid using deprecated API .. Patch Set 1: Code-Review+1 > imagine you are a BTS+BSC on a vessel and

Change in libosmocore[master]: ecu_fr: Avoid using deprecated symbols

2019-12-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16473 ) Change subject: ecu_fr: Avoid using deprecated symbols .. Patch Set 1: Code-Review-1 TBH, I don't like this approach... adding

Change in osmo-pcu[master]: tbf_dl.cpp: Fix typo in log line

2019-12-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16484 ) Change subject: tbf_dl.cpp: Fix typo in log line .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo

Change in osmo-bsc[master]: gsm_04_80: Avoid using deprecated API

2019-12-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/16476 ) Change subject: gsm_04_80: Avoid using deprecated API .. Patch Set 1: (1 comment) I am wondering why do we have SS/USSD code

Change in osmo-ttcn3-hacks[master]: bts: Update transmitted MS power as requested by BTS

2019-12-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16480 ) Change subject: bts: Update transmitted MS power as requested by BTS .. Patch Set 2: Code-Review+1 -- To view, visit https

Change in osmo-bts[master]: rach_pass_filter(): Add information about channel type

2019-12-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16481 ) Change subject: rach_pass_filter(): Add information about channel type .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in osmo-ttcn3-hacks[master]: pcu: Fix incorrect FN being send over PCUIF to PCU

2019-12-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16486 ) Change subject: pcu: Fix incorrect FN being send over PCUIF to PCU .. Patch Set 1: Code-Review-1 (1 comment) Fine

Change in osmo-ttcn3-hacks[master]: pcu: TC_mo_ping_pong: Check DL block is sent and ACK it

2019-12-03 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16409 ) Change subject: pcu: TC_mo_ping_pong: Check DL block is sent and ACK it .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: Support PAGING-CS and PAGING-PS on on PTP-BVCI

2019-12-10 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16538 ) Change subject: Support PAGING-CS and PAGING-PS on on PTP-BVCI .. Patch Set 1: Code-Review+1 Any spec. references? -- To view

Change in osmo-ttcn3-hacks[master]: pcu: add TC_paging_cs_from_bts

2019-12-10 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15623 ) Change subject: pcu: add TC_paging_cs_from_bts .. Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks

Change in osmo-pcu[master]: Allow Gb PAGING-PS without P-TMSI

2019-12-10 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16536 ) Change subject: Allow Gb PAGING-PS without P-TMSI .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/16536/1/src

Change in osmo-pcu[master]: Support Gb PAGING-CS

2019-12-10 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16537 ) Change subject: Support Gb PAGING-CS .. Patch Set 1: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/16537/1

Change in osmo-pcu[master]: Allow Gb PAGING-PS without P-TMSI

2019-12-10 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16536 ) Change subject: Allow Gb PAGING-PS without P-TMSI .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/16536/1/src

Change in osmo-pcu[master]: Fix trailing whitespace

2019-12-10 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16535 ) Change subject: Fix trailing whitespace .. Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/16535/1

Change in osmo-pcu[master]: Allow Gb PAGING-PS without P-TMSI

2019-12-10 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16536 ) Change subject: Allow Gb PAGING-PS without P-TMSI .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/16536/1/src

Change in osmo-ttcn3-hacks[master]: library/GSUP_Types.ttcn: fix MSISDN / SMSC coding in SM-RP-OA/DA

2019-12-12 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16565 ) Change subject: library/GSUP_Types.ttcn: fix MSISDN / SMSC coding in SM-RP-OA/DA .. library/GSUP_Types.ttcn: fix MSISDN

Change in osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: fix: verify the contents of SM-RP DA/OA for MO SMS

2019-12-12 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16566 ) Change subject: MSC_Tests.ttcn: fix: verify the contents of SM-RP DA/OA for MO SMS .. MSC_Tests.ttcn: fix: verify

Change in osmo-ttcn3-hacks[master]: msc: introduce f_logp()

2019-12-12 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16562 ) Change subject: msc: introduce f_logp() .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3

Change in osmo-ttcn3-hacks[master]: msc: introduce f_logp()

2019-12-12 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16562 ) Change subject: msc: introduce f_logp() .. Patch Set 1: > Patch Set 1: > > The ongoing discussion is whethe

Change in osmo-ttcn3-hacks[master]: hlr: add tests for GSUP proxy routing

2019-12-12 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16021 ) Change subject: hlr: add tests for GSUP proxy routing .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3

Change in osmo-ttcn3-hacks[master]: msc: add tests for SMS and voice call while Paging

2019-12-12 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16297 ) Change subject: msc: add tests for SMS and voice call while Paging .. Patch Set 4: Code-Review-1 (5 comments) https

Change in osmo-ttcn3-hacks[master]: pcu: add TC_paging_cs_from_bts

2019-12-10 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15623 ) Change subject: pcu: add TC_paging_cs_from_bts .. Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks

Change in osmo-msc[master]: libmsc/gsm_04_11.c: fix: include the length byte in SM-RP-DA

2019-12-10 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16341 ) Change subject: libmsc/gsm_04_11.c: fix: include the length byte in SM-RP-DA .. Patch Set 2: > Patch Set 2: > > don't we

Change in osmo-msc[master]: libmsc/gsm_04_11.c: fix: include the length byte in SM-RP-DA

2019-12-11 Thread fixeria
fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16341 ) Change subject: libmsc/gsm_04_11.c: fix: include the length byte in SM-RP-DA .. Abandoned I just checked out MAP specs. and the code again

Change in libosmocore[master]: core/defs.h: introduce and use OSMO_DEPRECATED_OUTSIDE

2019-12-10 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14864 ) Change subject: core/defs.h: introduce and use OSMO_DEPRECATED_OUTSIDE .. Patch Set 3: (1 comment) This change is ready

Change in osmocom-bb[master]: trx_toolkit/data_msg.py: rewrite unit tests to use unittest framework

2019-12-13 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/16568 ) Change subject: trx_toolkit/data_msg.py: rewrite unit tests to use unittest framework .. trx_toolkit/data_msg.py: rewrite unit

Change in osmocom-bb[master]: trx_toolkit/data_msg.py: rewrite unit tests to use unittest framework

2019-12-13 Thread fixeria
-Change-Number: 16568 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in osmocom-bb[master]: contrib/jenkins.sh: also run unit tests for TRX Toolkit

2019-12-13 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/16567 ) Change subject: contrib/jenkins.sh: also run unit tests for TRX Toolkit .. contrib/jenkins.sh: also run unit tests for TRX

Change in osmo-ttcn3-hacks[master]: library/GSUP_Types.ttcn: fix MSISDN / SMSC coding in SM-RP-OA/DA

2019-12-15 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16565 ) Change subject: library/GSUP_Types.ttcn: fix MSISDN / SMSC coding in SM-RP-OA/DA .. Patch Set 2: This change is ready

Change in osmo-ttcn3-hacks[master]: MSC/BSC_ConnectionHandler: only keep SMSC address in SmsParametersRp

2019-12-15 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16597 ) Change subject: MSC/BSC_ConnectionHandler: only keep SMSC address in SmsParametersRp .. MSC/BSC_ConnectionHandler: only

Change in osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: fix: verify the contents of SM-RP-DA/OA for MO/MT SMS

2019-12-15 Thread fixeria
Gerrit-Change-Id: Ib467eeca6439bc6cce72293fbb5bb48f6d233db9 Gerrit-Change-Number: 16566 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset

Change in osmo-hlr[master]: add libosmo-mslookup abstract client

2019-12-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16202 ) Change subject: add libosmo-mslookup abstract client .. Patch Set 19: Code-Review-1 None of my comments (to patchset #15) has been

Change in docker-playground[master]: pcu-master: Remove non-existent --enable-trx configure option from Do...

2019-12-17 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/16526 ) Change subject: pcu-master: Remove non-existent --enable-trx configure option from Dockerfile .. Patch Set 2: Code-Review

Change in libosmocore[master]: osmo-arfcn: Fix '-h' option

2019-12-03 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16444 ) Change subject: osmo-arfcn: Fix '-h' option .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c

Change in osmo-ttcn3-hacks[master]: pcu: Fix incorrect FN being send over PCUIF to PCU

2019-12-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16486 ) Change subject: pcu: Fix incorrect FN being send over PCUIF to PCU .. Patch Set 1: (1 comment) https://gerrit.osmocom.org

Change in osmo-ttcn3-hacks[master]: pcu: Fix incorrect FN being send over PCUIF to PCU

2019-12-05 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16486 ) Change subject: pcu: Fix incorrect FN being send over PCUIF to PCU .. Patch Set 2: Code-Review+2 -- To view, visit https

Change in osmo-ttcn3-hacks[master]: pcu: Verify contents of data dl blocks originated from emulated SGSN

2019-12-05 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16485 ) Change subject: pcu: Verify contents of data dl blocks originated from emulated SGSN .. Patch Set 3: Code-Review+1 Would

Change in osmo-ttcn3-hacks[master]: pcu: Support sending message to PCU at specific FN

2019-12-05 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16487 ) Change subject: pcu: Support sending message to PCU at specific FN .. Patch Set 3: Code-Review+1 (1 comment) https

Change in osmo-ggsn[master]: contrib/systemd: add systemd-networkd examples from manuals

2019-12-05 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/16511 ) Change subject: contrib/systemd: add systemd-networkd examples from manuals .. contrib/systemd: add systemd-networkd examples from

Change in osmo-ggsn[master]: manuals/configuration.adoc: fix IPv4 address mismatch in <

2019-12-05 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/16510 ) Change subject: manuals/configuration.adoc: fix IPv4 address mismatch in <> .. manuals/configuration.adoc: fix IPv4 a

Change in osmo-ggsn[master]: manuals/configuration.adoc: fix Network Address without prefix length

2019-12-05 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/16509 ) Change subject: manuals/configuration.adoc: fix Network Address without prefix length .. manuals/configuration.adoc: fix Network

Change in osmo-ttcn3-hacks[master]: pcu: Support sending message to PCU at specific FN

2019-12-05 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16487 ) Change subject: pcu: Support sending message to PCU at specific FN .. Patch Set 4: Code-Review+1 -- To view, visit https

Change in osmo-ttcn3-hacks[master]: pcu: send UL CONTROL ACK triggered by DL ACK/NACK

2019-12-05 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16501 ) Change subject: pcu: send UL CONTROL ACK triggered by DL ACK/NACK .. Patch Set 3: Code-Review-1 (1 comment) Sorry, I don't

Change in osmo-ttcn3-hacks[master]: pcu: send UL CONTROL ACK triggered by DL ACK/NACK

2019-12-05 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16501 ) Change subject: pcu: send UL CONTROL ACK triggered by DL ACK/NACK .. Patch Set 3: > Patch Set 3: > > > Patch

Change in osmo-ttcn3-hacks[master]: pcu: Introduce helpers to update AckNackDescription

2019-12-05 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16502 ) Change subject: pcu: Introduce helpers to update AckNackDescription .. Patch Set 3: (4 comments) https

Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_imm_ass_dl_block_retrans

2019-12-05 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16507 ) Change subject: pcu: Introduce test TC_imm_ass_dl_block_retrans .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in libosmocore[master]: gprs_bssgp: Work around gcc-9 claiming "error=stringop-overflow"

2019-12-15 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16608 ) Change subject: gprs_bssgp: Work around gcc-9 claiming "error=stringop-overflow" .. Patch Set 1: Code-Review+1

Change in osmo-msc[master]: gsup: indicate CN-Domain in SendAuthInfo Requests

2019-12-11 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16559 ) Change subject: gsup: indicate CN-Domain in SendAuthInfo Requests .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in osmo-bts[master]: osmo-bts-trx/scheduler: refactor the first frame number calculation

2019-10-19 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15812 ) Change subject: osmo-bts-trx/scheduler: refactor the first frame number calculation .. osmo-bts-trx/scheduler: refactor the first

Change in osmo-bts[master]: osmo-bts-trx/scheduler: fix: print the last frame number in rx_data_fn()

2019-10-19 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15811 ) Change subject: osmo-bts-trx/scheduler: fix: print the last frame number in rx_data_fn() .. osmo-bts-trx/scheduler: fix: print

Change in osmo-trx[master]: vty: Simplify filler burst settings and improve help and readability.

2019-10-19 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15793 ) Change subject: vty: Simplify filler burst settings and improve help and readability. .. Patch Set 3: Code-Review+1 Fine by me

Change in osmo-bts[master]: osmo-bts-trx/scheduler: refactor Uplink measurement processing

2019-10-20 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15807 ) Change subject: osmo-bts-trx/scheduler: refactor Uplink measurement processing .. Patch Set 3: Hi Alexander, > Could you expl

Change in osmo-pcu[master]: Fix assertion hit upon CCCH Paging Request

2019-10-21 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15799 ) Change subject: Fix assertion hit upon CCCH Paging Request .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in osmo-bts[master]: vty.c: don't ignore get_string_value() errors

2019-10-21 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15805 ) Change subject: vty.c: don't ignore get_string_value() errors .. Patch Set 3: Code-Review+2 -- To view, visit https

Change in osmo-bts[master]: vty.c: avoid coverity BAD_SHIFT issues

2019-10-21 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15806 ) Change subject: vty.c: avoid coverity BAD_SHIFT issues .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org

Change in osmo-bts[master]: vty.c: remove assert for always true condition

2019-10-18 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15805 ) Change subject: vty.c: remove assert for always true condition .. Patch Set 1: (1 comment) I would rather use a variable

Change in osmo-bts[master]: vty.c: avoid coverity BAD_SHIFT issues

2019-10-18 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15806 ) Change subject: vty.c: avoid coverity BAD_SHIFT issues .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/15806/1

Change in osmo-bts[master]: osmo-bts-trx/scheduler: refactor Uplink measurement processing

2019-10-21 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15807 ) Change subject: osmo-bts-trx/scheduler: refactor Uplink measurement processing .. Patch Set 3: > We have to keep in mind that

Change in osmo-bts[master]: osmo-bts-trx/scheduler: refactor Uplink measurement processing

2019-10-21 Thread fixeria
fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15807 ) Change subject: osmo-bts-trx/scheduler: refactor Uplink measurement processing .. Abandoned -- To view, visit https://gerrit.osmocom.org/c

Change in osmo-bts[master]: osmo-bts-trx/scheduler: refactor the first frame number calculation

2019-10-21 Thread fixeria
fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15812 ) Change subject: osmo-bts-trx/scheduler: refactor the first frame number calculation .. Abandoned -- To view, visit https

Change in osmo-trx[master]: vty: Simplify filler burst settings and improve help and readability.

2019-10-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15793 ) Change subject: vty: Simplify filler burst settings and improve help and readability. .. Patch Set 1: (4 comments) https

Change in osmo-trx[master]: vty: Don't enable random filler bursts automatically with EDGE.

2019-10-15 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15796 ) Change subject: vty: Don't enable random filler bursts automatically with EDGE. .. Patch Set 1: Code-Review+1 I would CR+2, but I

Change in osmocom-bb[master]: Fix common misspellings and typos

2019-10-15 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/15789 ) Change subject: Fix common misspellings and typos .. Patch Set 1: Code-Review-1 I don't think we should touch a local copy

Change in osmo-bts[master]: remove dummy UL measurement results for lost sacch frames

2019-10-24 Thread fixeria
fixeria has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14762 ) Change subject: remove dummy UL measurement results for lost sacch frames .. Removed Code-Review+1 by fixeria -- To view, visit

Change in osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: fix: move TC_pcu_ptcch to a proper place

2019-10-24 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15869 ) Change subject: BTS_Tests.ttcn: fix: move TC_pcu_ptcch to a proper place .. BTS_Tests.ttcn: fix: move TC_pcu_ptcch

Change in libosmocore[master]: gsm0508: add functions to calculate beginning of a block

2019-10-24 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15719 ) Change subject: gsm0508: add functions to calculate beginning of a block .. Patch Set 6: Code-Review+1 (2 comments) Looks good

Change in osmo-bts[master]: scheduler_trx: use gsm0502_fn_remap() to calculate frame number

2019-10-24 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15757 ) Change subject: scheduler_trx: use gsm0502_fn_remap() to calculate frame number .. Patch Set 3: Code-Review+1 (1 comment) https

Change in libosmocore[master]: vty: Return error if cmd returns CMD_WARNING while reading cfg file

2019-10-24 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15827 ) Change subject: vty: Return error if cmd returns CMD_WARNING while reading cfg file .. Patch Set 2: Code-Review+1 -- To view

Change in libosmocore[master]: fsm_dealloc_test: enable term_stops_actions

2019-10-25 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15834 ) Change subject: fsm_dealloc_test: enable term_stops_actions .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c

Change in libosmocore[master]: Add code coverage support

2019-10-25 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/13496 ) Change subject: Add code coverage support .. Patch Set 6: > Let me know if I have to modify some of the ansible playbooks. I

Change in libosmocore[master]: add osmo_fsm_set_dealloc_ctx(), to help with use-after-free

2019-10-25 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15677 ) Change subject: add osmo_fsm_set_dealloc_ctx(), to help with use-after-free .. Patch Set 2: Code-Review+1 -- To view, visit

Change in libosmocore[master]: fsm: add osmo_fsm_set_term_stops_actions()

2019-10-25 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15833 ) Change subject: fsm: add osmo_fsm_set_term_stops_actions() .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in libosmocore[master]: Add code coverage support

2019-10-25 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/13496 ) Change subject: Add code coverage support .. Patch Set 6: Code-Review+1 We definitely should move this work forward

Change in osmo-bts[master]: osmo-bts-trx/scheduler: refactor Uplink measurement processing

2019-10-18 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15807 ) Change subject: osmo-bts-trx/scheduler: refactor Uplink measurement processing .. osmo-bts-trx/scheduler: refactor Uplink

Change in osmo-bts[master]: osmo-bts-trx/scheduler: refactor Uplink measurement processing

2019-10-18 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15807 ) Change subject: osmo-bts-trx/scheduler: refactor Uplink measurement processing .. Patch Set 2: This change is ready for review

Change in osmo-bts[master]: osmo-bts-trx/scheduler: refactor the first frame number calculation

2019-10-19 Thread fixeria
lp writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iae9a0135595b0c56752723669a4ed2fc91f25785 Gerrit-Change-Number: 15812 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dext

Change in osmo-bts[master]: cosmetic: bts-trx: document variable and fix typo in ms_power_diff()

2019-10-25 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15876 ) Change subject: cosmetic: bts-trx: document variable and fix typo in ms_power_diff() .. Patch Set 1: Code-Review+2 -- To view

Change in osmo-bts[master]: bts-trx: loops.c: Follow BSC CHAN ACT ms power level restrictions

2019-10-25 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15877 ) Change subject: bts-trx: loops.c: Follow BSC CHAN ACT ms power level restrictions .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-bts[master]: osmo-bts-trx/trx_if.c: also print both RSSI and ToA256 for NOPE.ind

2019-11-18 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/16103 ) Change subject: osmo-bts-trx/trx_if.c: also print both RSSI and ToA256 for NOPE.ind .. osmo-bts-trx/trx_if.c: also print both RSSI

Change in osmo-bts[master]: osmo-bts-trx/trx_if.c: fix: always initialize bi->burst_len for NOPE.ind

2019-11-18 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/16102 ) Change subject: osmo-bts-trx/trx_if.c: fix: always initialize bi->burst_len for NOPE.ind .. osmo-bts-trx/trx_if.c: fix: alw

Change in osmo-bts[master]: osmo-bts-trx/trx_if.c: fix: NOPE.ind also contains C/I filed

2019-11-18 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/16104 ) Change subject: osmo-bts-trx/trx_if.c: fix: NOPE.ind also contains C/I filed .. osmo-bts-trx/trx_if.c: fix: NOPE.ind also contains

Change in osmo-bts[master]: osmo-bts-trx/trx_if.c: fix: always initialize bi->burst_len for NOPE.ind

2019-11-18 Thread fixeria
g mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I77f686bf7df385215892e71733a28ff0d90d7222 Gerrit-Change-Number: 16102 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in osmo-bts[master]: scheduler_trx.c: avoid division by zero when calculating BER

2019-11-19 Thread fixeria
fixeria has uploaded a new patch set (#2) to the change originally created by dexter. ( https://gerrit.osmocom.org/c/osmo-bts/+/16067 ) Change subject: scheduler_trx.c: avoid division by zero when calculating BER

Change in osmo-bts[master]: scheduler_trx.c: avoid division by zero when calculating BER

2019-11-18 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16067 ) Change subject: scheduler_trx.c: avoid division by zero when calculating BER .. Patch Set 1: Code-Review-1 (1 comment) The fix

Change in libosmo-netif[master]: osmux_test: don't use color logging

2019-11-20 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/16106 ) Change subject: osmux_test: don't use color logging .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in osmo-bts[master]: osmo-bts-trx/trx_if.c: fix: NOPE.ind also contains C/I field

2019-11-20 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16104 ) Change subject: osmo-bts-trx/trx_if.c: fix: NOPE.ind also contains C/I field .. osmo-bts-trx/trx_if.c: fix: NOPE.ind also contains C/I field

Change in osmo-bsc[master]: bsc: Send MS Power Control msg upon max MS power change

2019-11-20 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/16054 ) Change subject: bsc: Send MS Power Control msg upon max MS power change .. Patch Set 3: Code-Review+1 -- To view, visit https

Change in osmo-bts[master]: scheduler_trx.c: avoid division by zero when calculating BER

2019-11-20 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16067 ) Change subject: scheduler_trx.c: avoid division by zero when calculating BER .. Patch Set 2: Code-Review+2 -- To view, visit https

Change in osmo-bts[master]: scheduler_trx.c: avoid division by zero when calculating BER

2019-11-20 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16067 ) Change subject: scheduler_trx.c: avoid division by zero when calculating BER .. scheduler_trx.c: avoid division by zero when calculating BER

Change in osmo-bsc[master]: bsc: Send MS Power Control msg upon max MS power change

2019-11-20 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/16054 ) Change subject: bsc: Send MS Power Control msg upon max MS power change .. Patch Set 2: Code-Review+1 (2 comments) https

Change in osmo-msc[master]: Fix some typos

2019-11-19 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16074 ) Change subject: Fix some typos .. Patch Set 3: Code-Review+1 (3 comments) https://gerrit.osmocom.org/c/osmo-msc/+/16074/3/doc

Change in osmo-bts[master]: osmo-bts-virtual.cfg: ms-power-control dsp -> osmo

2019-11-19 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16105 ) Change subject: osmo-bts-virtual.cfg: ms-power-control dsp -> osmo .. Patch Set 1: Code-Review+2 -- To view, visit ht

Change in osmo-bts[master]: osmo-bts-trx/trx_if.c: fix: NOPE.ind also contains C/I field

2019-11-20 Thread fixeria
-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset

Change in libosmocore[master]: logging/vty: fix vty_read_file(): do not write warnings to stdin

2019-11-20 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/16143 ) Change subject: logging/vty: fix vty_read_file(): do not write warnings to stdin .. logging/vty: fix vty_read_file(): do

Change in libosmocore[master]: logging/vty: fix: actually ignore deprecated logging commands

2019-11-20 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16140 ) Change subject: logging/vty: fix: actually ignore deprecated logging commands .. Patch Set 2: This change is ready for review

Change in libosmocore[master]: logging/vty: do not print deprecated logging commands to stdout

2019-11-20 Thread fixeria
filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ida35865b1c0bb3d3567918f8e89c6551c6b34103 Gerrit-Change-Number: 16138 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit

Change in libosmocore[master]: logging/vty: do not print deprecated logging commands to stdin

2019-11-20 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16138 ) Change subject: logging/vty: do not print deprecated logging commands to stdin .. Patch Set 1: So that why we always see some

Change in libosmocore[master]: logging/vty: do not print deprecated logging commands to stdin

2019-11-20 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/16138 ) Change subject: logging/vty: do not print deprecated logging commands to stdin .. logging/vty: do not print deprecated logging

Change in libosmocore[master]: logging/vty: fix: actually ignore deprecated commands, do not abort

2019-11-20 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/16140 ) Change subject: logging/vty: fix: actually ignore deprecated commands, do not abort .. logging/vty: fix: actually ignore

Change in libosmocore[master]: logging/vty: use LOG_LEVEL_ARGS in logging_vty_add_deprecated_subsys()

2019-11-20 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/16139 ) Change subject: logging/vty: use LOG_LEVEL_ARGS in logging_vty_add_deprecated_subsys() .. logging/vty: use LOG_LEVEL_ARGS

<    5   6   7   8   9   10   11   12   13   14   >