[PR] HIVE-27810: Backport of HIVE-22593: Dynamically partitioned MM (insert-only ACID) tables don'… [hive]

2023-10-18 Thread via GitHub
Diksha628 opened a new pull request, #4815: URL: https://github.com/apache/hive/pull/4815 …t compact automatically (Karen Coppage via Peter Vary) (cherry picked from commit 1f4a88138a7ddbc8e8e689f976a2d923d71d1e40) ### What changes were proposed in this pull request?

[PR] HIVE-27574: Backport of HIVE-22661: Compaction fails on non bucketed table with data loaded i… [hive]

2023-10-18 Thread via GitHub
Diksha628 opened a new pull request, #4814: URL: https://github.com/apache/hive/pull/4814 …npath (Adam Szita, reviewed by Peter Vary and Laszlo Pinter) (cherry picked from commit 745da5fc4c3b917dd1ba5e81b5975d2d67ba736f) ### What changes were proposed in this pull reques

Re: [PR] HIVE-27731: Iceberg: Perform metadata delete for queries with static filters [hive]

2023-10-18 Thread via GitHub
sonarcloud[bot] commented on PR #4748: URL: https://github.com/apache/hive/pull/4748#issuecomment-1770100121 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27114: Provide a configurable filter for removing useless properties in Partition objects from listPartitions calls [hive]

2023-10-18 Thread via GitHub
sonarcloud[bot] commented on PR #4726: URL: https://github.com/apache/hive/pull/4726#issuecomment-1769852805 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27114: Provide a configurable filter for removing useless properties in Partition objects from listPartitions calls [hive]

2023-10-18 Thread via GitHub
dengzhhu653 commented on code in PR #4726: URL: https://github.com/apache/hive/pull/4726#discussion_r1364801515 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java: ## @@ -4129,6 +4129,8 @@ public List getPartitions(Table tbl) throws HiveException { GetPartit

Re: [PR] HIVE-27346: Getting exception for wildcard (*) search for database and table name [hive]

2023-10-18 Thread via GitHub
dengzhhu653 merged PR #4326: URL: https://github.com/apache/hive/pull/4326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apach

Re: [PR] HIVE-27499: Include optional db/table names in the NotificationEvent … [hive]

2023-10-18 Thread via GitHub
dengzhhu653 commented on code in PR #4569: URL: https://github.com/apache/hive/pull/4569#discussion_r1364763798 ## standalone-metastore/metastore-server/src/main/sql/postgres/upgrade-4.0.0-beta-1-to-4.0.0-beta-2.postgres.sql: ## @@ -1,4 +1,5 @@ SELECT 'Upgrading MetaStore schem

Re: [PR] HIVE-27499: Include optional db/table names in the NotificationEvent … [hive]

2023-10-18 Thread via GitHub
dengzhhu653 commented on code in PR #4569: URL: https://github.com/apache/hive/pull/4569#discussion_r1364763657 ## itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java: ## @@ -117,8 +117,17 @@ * Tests DbNotificationListener when

Re: [PR] HIVE-27114: Provide a configurable filter for removing useless properties in Partition objects from listPartitions calls [hive]

2023-10-18 Thread via GitHub
dengzhhu653 commented on code in PR #4726: URL: https://github.com/apache/hive/pull/4726#discussion_r1364754561 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java: ## @@ -4129,6 +4129,8 @@ public List getPartitions(Table tbl) throws HiveException { GetPartit

Re: [PR] HIVE-27114: Provide a configurable filter for removing useless properties in Partition objects from listPartitions calls [hive]

2023-10-18 Thread via GitHub
dengzhhu653 commented on code in PR #4726: URL: https://github.com/apache/hive/pull/4726#discussion_r1364750582 ## standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java: ## @@ -228,7 +233,7 @@ private void assertPart

Re: [PR] HIVE-27114: Provide a configurable filter for removing useless properties in Partition objects from listPartitions calls [hive]

2023-10-18 Thread via GitHub
dengzhhu653 commented on code in PR #4726: URL: https://github.com/apache/hive/pull/4726#discussion_r1364749729 ## standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java: ## @@ -266,7 +271,9 @@ private void assertCorr

Re: [PR] HIVE-27114: Provide a configurable filter for removing useless properties in Partition objects from listPartitions calls [hive]

2023-10-18 Thread via GitHub
dengzhhu653 commented on code in PR #4726: URL: https://github.com/apache/hive/pull/4726#discussion_r1364746599 ## ql/src/test/org/apache/hadoop/hive/metastore/TestListPartitionsWithXIncludeParams.java: ## @@ -0,0 +1,234 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] HIVE-27731: Iceberg: Perform metadata delete for queries with static filters [hive]

2023-10-18 Thread via GitHub
sonarcloud[bot] commented on PR #4748: URL: https://github.com/apache/hive/pull/4748#issuecomment-1769517512 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] Fixed flaky test testSerDe [hive]

2023-10-18 Thread via GitHub
sonarcloud[bot] commented on PR #4813: URL: https://github.com/apache/hive/pull/4813#issuecomment-1769438647 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27499: Include optional db/table names in the NotificationEvent … [hive]

2023-10-18 Thread via GitHub
saihemanth-cloudera commented on code in PR #4569: URL: https://github.com/apache/hive/pull/4569#discussion_r1364577385 ## standalone-metastore/metastore-server/src/main/sql/mssql/hive-schema-4.0.0-beta-2.mssql.sql: ## @@ -661,6 +661,8 @@ ALTER TABLE NOTIFICATION_LOG ADD CONSTRA

Re: [PR] HIVE-27114: Provide a configurable filter for removing useless properties in Partition objects from listPartitions calls [hive]

2023-10-18 Thread via GitHub
saihemanth-cloudera commented on code in PR #4726: URL: https://github.com/apache/hive/pull/4726#discussion_r1364564914 ## standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java: ## @@ -228,7 +233,7 @@ private void as

Re: [PR] HIVE-27114: Provide a configurable filter for removing useless properties in Partition objects from listPartitions calls [hive]

2023-10-18 Thread via GitHub
saihemanth-cloudera commented on code in PR #4726: URL: https://github.com/apache/hive/pull/4726#discussion_r1364562666 ## standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java: ## @@ -266,7 +271,9 @@ private void as

Re: [PR] HIVE-27114: Provide a configurable filter for removing useless properties in Partition objects from listPartitions calls [hive]

2023-10-18 Thread via GitHub
saihemanth-cloudera commented on code in PR #4726: URL: https://github.com/apache/hive/pull/4726#discussion_r1364547450 ## ql/src/test/org/apache/hadoop/hive/metastore/TestListPartitionsWithXIncludeParams.java: ## @@ -0,0 +1,234 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] HIVE-27663 - implement array_position UDF in Hive [hive]

2023-10-18 Thread via GitHub
sonarcloud[bot] commented on PR #4653: URL: https://github.com/apache/hive/pull/4653#issuecomment-1769309404 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27751 Log Query Compilation summary in an accumulated way [hive]

2023-10-18 Thread via GitHub
sonarcloud[bot] commented on PR #4755: URL: https://github.com/apache/hive/pull/4755#issuecomment-1769234624 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27114: Provide a configurable filter for removing useless properties in Partition objects from listPartitions calls [hive]

2023-10-18 Thread via GitHub
saihemanth-cloudera commented on code in PR #4726: URL: https://github.com/apache/hive/pull/4726#discussion_r1364352377 ## ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java: ## @@ -4129,6 +4129,8 @@ public List getPartitions(Table tbl) throws HiveException { G

[PR] Fixed flaky test testSerDe [hive]

2023-10-18 Thread via GitHub
yesh385 opened a new pull request, #4813: URL: https://github.com/apache/hive/pull/4813 This PR fixes a flaky test called `TestLazyBinaryColumnarSerDe.testSerDe` which can be found [here](https://github.com/apache/hive/blob/master/serde/src/test/org/apache/hadoop/hive/serde2/columnar/TestLa

Re: [PR] HIVE-25351: stddev(), stddev_pop() with CBO enable returning null [hive]

2023-10-18 Thread via GitHub
sonarcloud[bot] commented on PR #4812: URL: https://github.com/apache/hive/pull/4812#issuecomment-1769037522 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27598 - Enhance alter table compact to work for partitioned tabl… [hive]

2023-10-18 Thread via GitHub
sonarcloud[bot] commented on PR #4577: URL: https://github.com/apache/hive/pull/4577#issuecomment-1768981116 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27114: Provide a configurable filter for removing useless properties in Partition objects from listPartitions calls [hive]

2023-10-18 Thread via GitHub
sonarcloud[bot] commented on PR #4726: URL: https://github.com/apache/hive/pull/4726#issuecomment-1768904246 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27786: Iceberg: Eliminate engine.hive.enabled table property. [hive]

2023-10-18 Thread via GitHub
wypoon commented on PR #4793: URL: https://github.com/apache/hive/pull/4793#issuecomment-1768742869 Maybe I'm missing something or my understanding is incorrect, but I don't see how this change enables Hive to read Iceberg tables written by other engines that do not set engine.hive.enabled

Re: [PR] HIVE-27653: Iceberg: Add conflictDetectionFilter to validate concurre… [hive]

2023-10-18 Thread via GitHub
sonarcloud[bot] commented on PR #4761: URL: https://github.com/apache/hive/pull/4761#issuecomment-1768723936 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27762: ObjectStore GetHelper do not need run jdo query if direct sql exception is unrecoverable [hive]

2023-10-18 Thread via GitHub
wecharyu commented on PR #4767: URL: https://github.com/apache/hive/pull/4767#issuecomment-1768719994 Pipeline has passed. @saihemanth-cloudera -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] HIVE-27786: Iceberg: Eliminate engine.hive.enabled table property. [hive]

2023-10-18 Thread via GitHub
wypoon commented on code in PR #4793: URL: https://github.com/apache/hive/pull/4793#discussion_r1364032157 ## iceberg/iceberg-catalog/src/test/java/org/apache/iceberg/hive/HiveTableTest.java: ## @@ -531,7 +531,6 @@ public void testEngineHiveEnabledConfig() throws TException {

[PR] HIVE-25351: stddev(), stddev_pop() with CBO enable returning null [hive]

2023-10-18 Thread via GitHub
mdayakar opened a new pull request, #4812: URL: https://github.com/apache/hive/pull/4812 ### What changes were proposed in this pull request? When CBO is enabled then **_stddev_** and **_variance_** will be simplified with below aggregation functions. _**STDDEV_POP(x)** → SQRT(

Re: [PR] HIVE-27598 - Enhance alter table compact to work for partitioned tabl… [hive]

2023-10-18 Thread via GitHub
tarak271 commented on code in PR #4577: URL: https://github.com/apache/hive/pull/4577#discussion_r1363987714 ## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/InitiatorBase.java: ## @@ -0,0 +1,309 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] HIVE-27731: Iceberg: Perform metadata delete for queries with static filters [hive]

2023-10-18 Thread via GitHub
SourabhBadhya commented on code in PR #4748: URL: https://github.com/apache/hive/pull/4748#discussion_r1363976524 ## ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java: ## @@ -62,7 +72,9 @@ protected void analyze(ASTNode tree, Table table, ASTNode tab

Re: [PR] HIVE-27598 - Enhance alter table compact to work for partitioned tabl… [hive]

2023-10-18 Thread via GitHub
tarak271 commented on code in PR #4577: URL: https://github.com/apache/hive/pull/4577#discussion_r1363965915 ## ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/compact/AlterTableCompactOperation.java: ## @@ -18,27 +18,27 @@ package org.apache.hadoop.hive.ql.ddl.table.

Re: [PR] HIVE-27808: Backport of HIVE-20082, 22170,22331, 24113, 25458 [hive]

2023-10-18 Thread via GitHub
Diksha628 closed pull request #4810: HIVE-27808: Backport of HIVE-20082, 22170,22331, 24113, 25458 URL: https://github.com/apache/hive/pull/4810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] HIVE-27731: Iceberg: Perform metadata delete for queries with static filters [hive]

2023-10-18 Thread via GitHub
deniskuzZ commented on code in PR #4748: URL: https://github.com/apache/hive/pull/4748#discussion_r1363951381 ## ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java: ## @@ -62,7 +72,9 @@ protected void analyze(ASTNode tree, Table table, ASTNode tabName

Re: [PR] HIVE-27731: Iceberg: Perform metadata delete for queries with static filters [hive]

2023-10-18 Thread via GitHub
SourabhBadhya commented on code in PR #4748: URL: https://github.com/apache/hive/pull/4748#discussion_r1363949331 ## ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java: ## @@ -285,6 +296,61 @@ private void reparseAndSuperAnalyze(ASTNode tree, Table mT

Re: [PR] HIVE-27731: Iceberg: Perform metadata delete for queries with static filters [hive]

2023-10-18 Thread via GitHub
deniskuzZ commented on code in PR #4748: URL: https://github.com/apache/hive/pull/4748#discussion_r1363948621 ## ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java: ## @@ -285,6 +296,61 @@ private void reparseAndSuperAnalyze(ASTNode tree, Table mTable

[PR] HIVE-27809: Backport of HIVE-21715: Adding a new partition specified by location (which is empty) leads to Exceptions [hive]

2023-10-18 Thread via GitHub
Diksha628 opened a new pull request, #4811: URL: https://github.com/apache/hive/pull/4811 …pty) leads to Exceptions (Zoltan Haindrich reviewed by Laszlo Bodor, Ashutosh Chauhan) Signed-off-by: Zoltan Haindrich (cherry picked from commit a3f70bf8bf78cf6d5fddb876ec78e6ee0329db4d)

Re: [PR] HIVE-27481: TxnHandler cleanup [hive]

2023-10-18 Thread via GitHub
sonarcloud[bot] commented on PR #4566: URL: https://github.com/apache/hive/pull/4566#issuecomment-1768485080 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27699: Backport of HIVE-25458: Unix_timestamp() with string input give wrong result [hive]

2023-10-18 Thread via GitHub
Diksha628 closed pull request #4713: HIVE-27699: Backport of HIVE-25458: Unix_timestamp() with string input give wrong result URL: https://github.com/apache/hive/pull/4713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] HIVE-27783: Iceberg: Implement Copy-On-Write for Update queries [hive]

2023-10-18 Thread via GitHub
deniskuzZ merged PR #4781: URL: https://github.com/apache/hive/pull/4781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.

Re: [PR] HIVE-27731: Iceberg: Perform metadata delete for queries with static filters [hive]

2023-10-18 Thread via GitHub
SourabhBadhya commented on code in PR #4748: URL: https://github.com/apache/hive/pull/4748#discussion_r1363846683 ## ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java: ## @@ -285,6 +296,61 @@ private void reparseAndSuperAnalyze(ASTNode tree, Table mT

Re: [PR] HIVE-27731: Iceberg: Perform metadata delete for queries with static filters [hive]

2023-10-18 Thread via GitHub
SourabhBadhya commented on code in PR #4748: URL: https://github.com/apache/hive/pull/4748#discussion_r1363846683 ## ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java: ## @@ -285,6 +296,61 @@ private void reparseAndSuperAnalyze(ASTNode tree, Table mT

Re: [PR] HIVE-27731: Iceberg: Perform metadata delete for queries with static filters [hive]

2023-10-18 Thread via GitHub
SourabhBadhya commented on code in PR #4748: URL: https://github.com/apache/hive/pull/4748#discussion_r1363846683 ## ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java: ## @@ -285,6 +296,61 @@ private void reparseAndSuperAnalyze(ASTNode tree, Table mT

[PR] Backport of HIVE-20082, 22170,22331, 24113, 25458 [hive]

2023-10-18 Thread via GitHub
Diksha628 opened a new pull request, #4810: URL: https://github.com/apache/hive/pull/4810 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### Is the chang

Re: [PR] HIVE-27604 : Backport of HIVE-21167 to branch-3 [hive]

2023-10-18 Thread via GitHub
sankarh merged PR #4583: URL: https://github.com/apache/hive/pull/4583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.or

Re: [PR] [HIVE-27804] Implement batching in various getPartition calls which return auth info along with Partition List [hive]

2023-10-18 Thread via GitHub
sonarcloud[bot] commented on PR #4807: URL: https://github.com/apache/hive/pull/4807#issuecomment-1768108533 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27653: Iceberg: Add conflictDetectionFilter to validate concurre… [hive]

2023-10-18 Thread via GitHub
sonarcloud[bot] commented on PR #4761: URL: https://github.com/apache/hive/pull/4761#issuecomment-1768040802 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27731: Iceberg: Perform metadata delete for queries with static filters [hive]

2023-10-18 Thread via GitHub
deniskuzZ commented on code in PR #4748: URL: https://github.com/apache/hive/pull/4748#discussion_r1363439831 ## ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java: ## @@ -285,6 +296,61 @@ private void reparseAndSuperAnalyze(ASTNode tree, Table mTable

Re: [PR] HIVE-27731: Iceberg: Perform metadata delete for queries with static filters [hive]

2023-10-18 Thread via GitHub
SourabhBadhya commented on code in PR #4748: URL: https://github.com/apache/hive/pull/4748#discussion_r1363439716 ## ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java: ## @@ -62,7 +72,9 @@ protected void analyze(ASTNode tree, Table table, ASTNode tab

Re: [PR] HIVE-27731: Iceberg: Perform metadata delete for queries with static filters [hive]

2023-10-18 Thread via GitHub
deniskuzZ commented on code in PR #4748: URL: https://github.com/apache/hive/pull/4748#discussion_r1363427387 ## ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java: ## @@ -62,7 +72,9 @@ protected void analyze(ASTNode tree, Table table, ASTNode tabName

Re: [PR] HIVE-27114: Provide a configurable filter for removing useless properties in Partition objects from listPartitions calls [hive]

2023-10-18 Thread via GitHub
sonarcloud[bot] commented on PR #4726: URL: https://github.com/apache/hive/pull/4726#issuecomment-1767893907 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

Re: [PR] HIVE-27598 - Enhance alter table compact to work for partitioned tabl… [hive]

2023-10-18 Thread via GitHub
veghlaci05 commented on code in PR #4577: URL: https://github.com/apache/hive/pull/4577#discussion_r1363384397 ## ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/compact/AlterTableCompactOperation.java: ## @@ -18,27 +18,27 @@ package org.apache.hadoop.hive.ql.ddl.tabl