zhangbutao commented on PR #5515:
URL: https://github.com/apache/hive/pull/5515#issuecomment-2649993205
> @zhangbutao Thanks for checking the PR, sorry for the delay
>
> Here is the query from trino `metaTableColumns: value_0,value_1,value_2
CREATE TABLE your_table_name ( value_0 STRI
okumin commented on code in PR #5640:
URL: https://github.com/apache/hive/pull/5640#discussion_r1950316421
##
pom.xml:
##
@@ -213,7 +213,7 @@
3.8.4
1.1
2.4.0
-5.2.0
+5.6.0
Review Comment:
Why not 5.7.1 but 5.6.0?
--
This is an automated message fro
okumin commented on PR #5640:
URL: https://github.com/apache/hive/pull/5640#issuecomment-2649937522
I compared the diff between the parent
revision(35589d78ca428f6274e8fb0f6399d70b947581bb) and this branch. All are
expected
```
893,906c893,906
< [INFO]org.apache.curator:apa
okumin commented on code in PR #5622:
URL: https://github.com/apache/hive/pull/5622#discussion_r1950290932
##
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergTableUtil.java:
##
@@ -388,21 +388,13 @@ public static PartitionData toPartitionData(StructLike
Aggarwal-Raghav commented on PR #41:
URL: https://github.com/apache/hive-site/pull/41#issuecomment-2649867960
CC @zabetak, can you please help with the review. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
sonarqubecloud[bot] commented on PR #5639:
URL: https://github.com/apache/hive/pull/5639#issuecomment-2649853563
## [](https://sonarcl
ayushtkn commented on code in PR #5606:
URL: https://github.com/apache/hive/pull/5606#discussion_r1948027716
##
standalone-metastore/metastore-catalog/pom.xml:
##
@@ -0,0 +1,340 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
soumyakanti3578 commented on PR #5510:
URL: https://github.com/apache/hive/pull/5510#issuecomment-2649820562
Thanks @deniskuzZ for reopening the PR. I will look into your suggestions,
and also the failure, and revive this PR soon. :)
--
This is an automated message from the Apache Git Ser
cnauroth commented on code in PR #5504:
URL: https://github.com/apache/hive/pull/5504#discussion_r1950235033
##
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java:
##
@@ -151,40 +145,24 @@ public FileSystem getFs(Path f) throws Me
cnauroth commented on code in PR #5504:
URL: https://github.com/apache/hive/pull/5504#discussion_r1950233561
##
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##
@@ -1796,8 +1796,6 @@ public enum ConfVars {
cnauroth commented on code in PR #5504:
URL: https://github.com/apache/hive/pull/5504#discussion_r1950232995
##
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java:
##
@@ -133,14 +133,8 @@ public FileSystem getFs(Path f) throws Met
okumin commented on code in PR #5639:
URL: https://github.com/apache/hive/pull/5639#discussion_r1950229849
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java:
##
@@ -55,6 +56,7 @@ public DataSource c
zhangbutao commented on PR #5515:
URL: https://github.com/apache/hive/pull/5515#issuecomment-2649766831
@shivjha30 Sorry for the late reply. will check it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
sonarqubecloud[bot] commented on PR #5196:
URL: https://github.com/apache/hive/pull/5196#issuecomment-2649771165
## [](https://sonarcl
okumin commented on code in PR #5639:
URL: https://github.com/apache/hive/pull/5639#discussion_r1950209422
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java:
##
@@ -55,6 +56,7 @@ public DataSource c
shivjha30 commented on PR #5515:
URL: https://github.com/apache/hive/pull/5515#issuecomment-2649749763
@zhangbutao Can you help to review the PR and merge it?
It might stale if not reviewed/merged
--
This is an automated message from the Apache Git Service.
To respond to the message,
zhangbutao commented on code in PR #5504:
URL: https://github.com/apache/hive/pull/5504#discussion_r1950183222
##
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java:
##
@@ -151,40 +145,24 @@ public FileSystem getFs(Path f) throws
zhangbutao commented on code in PR #5504:
URL: https://github.com/apache/hive/pull/5504#discussion_r1950179197
##
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java:
##
@@ -133,14 +133,8 @@ public FileSystem getFs(Path f) throws M
zhangbutao commented on code in PR #5504:
URL: https://github.com/apache/hive/pull/5504#discussion_r1950160888
##
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##
@@ -1796,8 +1796,6 @@ public enum ConfVars {
zhangbutao commented on code in PR #5504:
URL: https://github.com/apache/hive/pull/5504#discussion_r1950136218
##
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##
@@ -1796,8 +1796,6 @@ public enum ConfVars {
sonarqubecloud[bot] commented on PR #5578:
URL: https://github.com/apache/hive/pull/5578#issuecomment-2649627136
## [](https://sonarcl
dengzhhu653 commented on PR #5629:
URL: https://github.com/apache/hive/pull/5629#issuecomment-2649606107
This PR doesn't change any code, so I merge this without a green build to
free the resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
dengzhhu653 merged PR #40:
URL: https://github.com/apache/hive-site/pull/40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apac
dengzhhu653 merged PR #5629:
URL: https://github.com/apache/hive/pull/5629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apach
dengzhhu653 merged PR #5582:
URL: https://github.com/apache/hive/pull/5582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apach
aturoczy commented on code in PR #5606:
URL: https://github.com/apache/hive/pull/5606#discussion_r1950031454
##
standalone-metastore/metastore-catalog/src/main/java/org/apache/iceberg/HiveCachingCatalog.java:
##
@@ -0,0 +1,331 @@
+/*
+ * Licensed to the Apache Software Foundatio
aturoczy commented on code in PR #5606:
URL: https://github.com/apache/hive/pull/5606#discussion_r1950024471
##
standalone-metastore/metastore-catalog/src/main/java/org/apache/iceberg/HiveCachingCatalog.java:
##
@@ -0,0 +1,331 @@
+/*
+ * Licensed to the Apache Software Foundatio
dongjoon-hyun closed pull request #5547: HIVE-28630: Upgrade ORC to 1.9.5
URL: https://github.com/apache/hive/pull/5547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
saihemanth-cloudera commented on code in PR #5582:
URL: https://github.com/apache/hive/pull/5582#discussion_r1949683544
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##
@@ -3362,95 +3362,84 @@ private void updateStatsFor
sonarqubecloud[bot] commented on PR #5636:
URL: https://github.com/apache/hive/pull/5636#issuecomment-2648903127
## [](https://sonarcl
cnauroth commented on code in PR #5504:
URL: https://github.com/apache/hive/pull/5504#discussion_r1949630681
##
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##
@@ -1796,8 +1796,6 @@ public enum ConfVars {
cnauroth commented on code in PR #5504:
URL: https://github.com/apache/hive/pull/5504#discussion_r1949623684
##
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java:
##
@@ -133,14 +133,8 @@ public FileSystem getFs(Path f) throws Met
Aggarwal-Raghav opened a new pull request, #41:
URL: https://github.com/apache/hive-site/pull/41
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
sonarqubecloud[bot] commented on PR #5614:
URL: https://github.com/apache/hive/pull/5614#issuecomment-2648757209
## [](https://sonarcl
ayushtkn commented on code in PR #5504:
URL: https://github.com/apache/hive/pull/5504#discussion_r1949560920
##
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java:
##
@@ -133,14 +133,8 @@ public FileSystem getFs(Path f) throws Met
sonarqubecloud[bot] commented on PR #5629:
URL: https://github.com/apache/hive/pull/5629#issuecomment-2648692155
## [](https://sonarcl
Aggarwal-Raghav commented on code in PR #29:
URL: https://github.com/apache/hive-site/pull/29#discussion_r1949457788
##
content/docs/latest/17022.md:
##
@@ -59,35 +59,35 @@ This configuration will be set to SAML to indicate that the
server will use SAML
hive.server
Aggarwal-Raghav commented on PR #5637:
URL: https://github.com/apache/hive/pull/5637#issuecomment-2648563896
@barking-code , first login to the CI (top right hand side) before directly
opening the URL mentioned in above comments. From CI, you can check which tests
are failing and update/fix
armitage420 commented on PR #5608:
URL: https://github.com/apache/hive/pull/5608#issuecomment-2648524481
@difin Gentle reminder!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
Indhumathi27 commented on code in PR #5614:
URL: https://github.com/apache/hive/pull/5614#discussion_r1949033382
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/PartFilterVisitor.java:
##
@@ -262,4 +262,163 @@ public String
visitQu
Indhumathi27 commented on PR #5614:
URL: https://github.com/apache/hive/pull/5614#issuecomment-2647966520
Thanks @Indhumathi27 for the review and suggestions. I have handled the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
Indhumathi27 commented on code in PR #5614:
URL: https://github.com/apache/hive/pull/5614#discussion_r1949032895
##
ql/src/test/queries/clientpositive/casewhen_isnot_boolean_partition.q:
##
@@ -0,0 +1,77 @@
+create table t1(id int) partitioned by (month int, year string);
+inser
sonarqubecloud[bot] commented on PR #5614:
URL: https://github.com/apache/hive/pull/5614#issuecomment-2647879200
## [](https://sonarcl
deniskuzZ commented on code in PR #5614:
URL: https://github.com/apache/hive/pull/5614#discussion_r1948981279
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/PartFilterVisitor.java:
##
@@ -132,9 +132,11 @@ public TreeNode
visitBetw
deniskuzZ commented on code in PR #5614:
URL: https://github.com/apache/hive/pull/5614#discussion_r1948980217
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/PartFilterVisitor.java:
##
@@ -132,9 +132,11 @@ public TreeNode
visitBetw
sonarqubecloud[bot] commented on PR #5629:
URL: https://github.com/apache/hive/pull/5629#issuecomment-2647817814
## [](https://sonarcl
zabetak commented on code in PR #5639:
URL: https://github.com/apache/hive/pull/5639#discussion_r1948922558
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java:
##
@@ -55,6 +56,7 @@ public DataSource
zabetak commented on code in PR #5639:
URL: https://github.com/apache/hive/pull/5639#discussion_r1948856692
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java:
##
@@ -55,6 +56,7 @@ public DataSource
zabetak commented on code in PR #5639:
URL: https://github.com/apache/hive/pull/5639#discussion_r1948856692
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java:
##
@@ -55,6 +56,7 @@ public DataSource
KiranVelumuri commented on PR #5640:
URL: https://github.com/apache/hive/pull/5640#issuecomment-2647620374
Occurences of older curator-client-5.2.0.jar have been updated with the
upgraded version:
located at
packaging/target/apache-hive-4.0.0.3.4.0-SNAPSHOT-bin.tar.gz/apache-hive-4.0
linghengqian commented on PR #5629:
URL: https://github.com/apache/hive/pull/5629#issuecomment-2647491529
> It also works
- My understanding is that I should document both ways of writing
`compose.yaml`.
--
This is an automated message from the Apache Git Service.
To respon
KiranVelumuri commented on PR #5640:
URL: https://github.com/apache/hive/pull/5640#issuecomment-2647454472
@okumin Could you please review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
dengzhhu653 commented on code in PR #5639:
URL: https://github.com/apache/hive/pull/5639#discussion_r1948721502
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java:
##
@@ -55,6 +56,7 @@ public DataSou
deniskuzZ commented on code in PR #5614:
URL: https://github.com/apache/hive/pull/5614#discussion_r1948704261
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/PartFilterVisitor.java:
##
@@ -262,4 +262,163 @@ public String
visitQuote
zabetak merged PR #29:
URL: https://github.com/apache/hive-site/pull/29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.o
dengzhhu653 commented on PR #5606:
URL: https://github.com/apache/hive/pull/5606#issuecomment-2647326826
Leave some minor comments, rest looks good to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
zabetak commented on code in PR #29:
URL: https://github.com/apache/hive-site/pull/29#discussion_r1948603458
##
content/docs/latest/17022.md:
##
@@ -59,35 +59,35 @@ This configuration will be set to SAML to indicate that the
server will use SAML
hive.server2.saml2.
dengzhhu653 commented on code in PR #5606:
URL: https://github.com/apache/hive/pull/5606#discussion_r1948627370
##
standalone-metastore/metastore-catalog/data/conf/README.txt:
##
@@ -0,0 +1 @@
+Need to force creation of a directory.
Review Comment:
nit: no data or configurat
dengzhhu653 commented on code in PR #5606:
URL: https://github.com/apache/hive/pull/5606#discussion_r1948623396
##
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:
##
@@ -304,8 +304,8 @@ static ThriftHiveMetastore.Ifa
dengzhhu653 commented on code in PR #5606:
URL: https://github.com/apache/hive/pull/5606#discussion_r1948618918
##
standalone-metastore/metastore-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogServer.java:
##
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Fou
dengzhhu653 commented on PR #5629:
URL: https://github.com/apache/hive/pull/5629#issuecomment-2647270394
> * I found a potential drawback of the current PR is that due to the use of
remote HMS, the startup of HS2 is particularly long and requires at least 2
minutes of waiting. According to
barking-code commented on PR #5637:
URL: https://github.com/apache/hive/pull/5637#issuecomment-2647226899
> @barking-code Thanks for locating the issue and providing the fix. Could
you update the output of the failing test cases? Please feel free to ask me if
you have any questions.
https:
sonarqubecloud[bot] commented on PR #5629:
URL: https://github.com/apache/hive/pull/5629#issuecomment-2647223306
## [](https://sonarcl
kasakrisz merged PR #5623:
URL: https://github.com/apache/hive/pull/5623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.
64 matches
Mail list logo
