Re: [PR] GH-46673: [CI][R][Docs] Set empty INSTALL_ARGS options as default [arrow]

2025-06-02 Thread via GitHub
github-actions[bot] commented on PR #46682: URL: https://github.com/apache/arrow/pull/46682#issuecomment-2933746023 Revision: c8a2a1cc6558b7c4b68ebb9fe605cdec12a9f79a Submitted crossbow builds: [ursacomputing/crossbow @ actions-0d4aee9e28](https://github.com/ursacomputing/crossbow/bra

Re: [PR] POC: Sketch out cached filter result API [arrow-rs]

2025-06-02 Thread via GitHub
Dandandan commented on code in PR #7513: URL: https://github.com/apache/arrow-rs/pull/7513#discussion_r2122851868 ## arrow-select/src/filter.rs: ## @@ -337,7 +367,95 @@ impl FilterPredicate { } } -fn filter_array(values: &dyn Array, predicate: &FilterPredicate) -> Resul

Re: [PR] GH-46673: [CI][R][Docs] Set empty INSTALL_ARGS options as default [arrow]

2025-06-02 Thread via GitHub
hiroyuki-sato commented on code in PR #46682: URL: https://github.com/apache/arrow/pull/46682#discussion_r2122870646 ## ci/scripts/r_build.sh: ## @@ -24,6 +24,12 @@ build_dir=${2} : "${BUILD_DOCS_R:=OFF}" +if [ -z "${INSTALL_ARGS}" ] ; then + R_INSTALL_ARGS=() +else + rea

Re: [PR] GH-46673: [CI][R][Docs] Set empty INSTALL_ARGS options as default [arrow]

2025-06-02 Thread via GitHub
hiroyuki-sato commented on PR #46682: URL: https://github.com/apache/arrow/pull/46682#issuecomment-2933741213 @github-actions crossbow submit preview-docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] feat(csharp/src/Drivers/Databricks): Default catalogs edge cases [arrow-adbc]

2025-06-02 Thread via GitHub
toddmeng-db commented on code in PR #2896: URL: https://github.com/apache/arrow-adbc/pull/2896#discussion_r2122866805 ## csharp/src/Drivers/Databricks/DatabricksStatement.cs: ## @@ -41,6 +41,19 @@ internal class DatabricksStatement : SparkStatement, IHiveServer2Statement

Re: [PR] feat(csharp/src/Drivers/Databricks): Default catalogs edge cases [arrow-adbc]

2025-06-02 Thread via GitHub
toddmeng-db commented on PR #2896: URL: https://github.com/apache/arrow-adbc/pull/2896#issuecomment-2933693705 > It's my vague understanding that the behavior of USE depends on whether or not there is a current catalog Thats a good point - here's [the docs](https://docs.databricks.com/aw

Re: [PR] POC: Sketch out cached filter result API [arrow-rs]

2025-06-02 Thread via GitHub
Dandandan commented on code in PR #7513: URL: https://github.com/apache/arrow-rs/pull/7513#discussion_r2122298413 ## arrow-select/src/incremental_batch_builder.rs: ## @@ -0,0 +1,355 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license

Re: [I] [CI] Occasional 403 forbidden from archive.ubuntu.com [arrow]

2025-06-02 Thread via GitHub
pitrou commented on issue #46687: URL: https://github.com/apache/arrow/issues/46687#issuecomment-2933513479 @kou Do you know why this might be happening? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] GH-46642: [Format] Add footnote clarifying REE layout has O(log n) random access [arrow]

2025-06-02 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #46643: URL: https://github.com/apache/arrow/pull/46643#issuecomment-2933648810 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 53b4af4f75e48ec04ae00adcd9afdf7608bf83a4. There were 65

Re: [PR] GH-46528: [CI][Dev] Remove "archery lint" [arrow]

2025-06-02 Thread via GitHub
kou commented on code in PR #46686: URL: https://github.com/apache/arrow/pull/46686#discussion_r2122779895 ## ci/scripts/install_iwyu.sh: ## Review Comment: We'll revisit IWYU in the future. It's tracked by https://github.com/apache/arrow/issues/46543 . ## doc

Re: [PR] feat(csharp/src/Drivers/Databricks): Default catalogs edge cases [arrow-adbc]

2025-06-02 Thread via GitHub
toddmeng-db commented on code in PR #2896: URL: https://github.com/apache/arrow-adbc/pull/2896#discussion_r2122424817 ## csharp/src/Drivers/Databricks/DatabricksConnection.cs: ## @@ -168,18 +168,14 @@ private void ValidateProperties() Properties.TryGetValue(AdbcOpti

Re: [PR] MINOR: [C++] Remove deprecated inclusion [arrow]

2025-06-02 Thread via GitHub
pitrou merged PR #46672: URL: https://github.com/apache/arrow/pull/46672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache

Re: [I] [Java][FlightSQL] Column Duplication When Selecting from no result record in Arrow Flight SQL JDBC Driver [arrow-java]

2025-06-02 Thread via GitHub
bineetsingh30 commented on issue #44: URL: https://github.com/apache/arrow-java/issues/44#issuecomment-2933461833 Hi, shouldn't this be a bug rather than enhancement? This used to work and started breaking after the Arrow 15.0.0 release as @mingnuj mentioned. -- This is an automated messa

Re: [PR] feat: add `row_group_is_[max/min]_value_exact` to StatisticsConverter [arrow-rs]

2025-06-02 Thread via GitHub
etseidl commented on code in PR #7574: URL: https://github.com/apache/arrow-rs/pull/7574#discussion_r2122773095 ## parquet/tests/arrow_reader/mod.rs: ## @@ -987,6 +991,33 @@ fn create_data_batch(scenario: Scenario) -> Vec { make_utf8_batch(vec![Some("e"), Some(

Re: [I] [CI] Occasional 403 forbidden from archive.ubuntu.com [arrow]

2025-06-02 Thread via GitHub
kou commented on issue #46687: URL: https://github.com/apache/arrow/issues/46687#issuecomment-2933559612 https://askubuntu.com/questions/1549622/problem-with-archive-ubuntu-com-most-of-the-servers-are-not-responding/1549646 may be related. archive.ubuntu.com isn't best condition recently

Re: [PR] MINOR: [C++] Remove deprecated inclusion [arrow]

2025-06-02 Thread via GitHub
pitrou commented on PR #46672: URL: https://github.com/apache/arrow/pull/46672#issuecomment-2933502922 > But could you update the PR description before you merge this? Oops, sorry. Done. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] GH-46219: [C++][Parquet] Remove PARQUET_MINIMAL_DEPENDENCY option [arrow]

2025-06-02 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #46274: URL: https://github.com/apache/arrow/pull/46274#issuecomment-2933484744 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 63c2efef576392d599ea444adcf75731cac44ebc. There were 76

Re: [I] [Dev] Use pre-commit-hook instead of "archery lint" for all lints [arrow]

2025-06-02 Thread via GitHub
kou commented on issue #40417: URL: https://github.com/apache/arrow/issues/40417#issuecomment-2933476894 Done. Removed IWYU and clang-tidy from subissues because they aren't used with "archery lint" for now. We can revisit them when we want to use them. -- This is an automated m

[PR] GH-46528: [CI][Dev] Remove "archery lint" [arrow]

2025-06-02 Thread via GitHub
kou opened a new pull request, #46686: URL: https://github.com/apache/arrow/pull/46686 ### Rationale for this change We can use pre-commit instead of "archery lint" for all linters/formatters. ### What changes are included in this PR? * Remove "archery lint" CI job * R

Re: [PR] GH-46673: [CI][R][Docs] Set empty INSTALL_ARGS options as default [arrow]

2025-06-02 Thread via GitHub
kou commented on code in PR #46682: URL: https://github.com/apache/arrow/pull/46682#discussion_r2122684697 ## ci/scripts/r_build.sh: ## @@ -24,6 +24,12 @@ build_dir=${2} : "${BUILD_DOCS_R:=OFF}" +if [ -z "${INSTALL_ARGS}" ] ; then + R_INSTALL_ARGS=() +else + read -r -a R_

Re: [I] [C++] Meson Configuration Broken on Windows [arrow]

2025-06-02 Thread via GitHub
kou commented on issue #46684: URL: https://github.com/apache/arrow/issues/46684#issuecomment-2933455564 Issue resolved by pull request 46685 https://github.com/apache/arrow/pull/46685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] GH-46684: [C++] Fix Meson configuration issue on Windows [arrow]

2025-06-02 Thread via GitHub
kou merged PR #46685: URL: https://github.com/apache/arrow/pull/46685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [PR] GH-46633: [Docs][C++][Python] Update CombineChunks documentation to specify that binary columns can be combined into multiple chunks [arrow]

2025-06-02 Thread via GitHub
AlenkaF commented on PR #46638: URL: https://github.com/apache/arrow/pull/46638#issuecomment-2933359946 Looking at the Conbench report, I do not see how R `tpch` failures could be connected to the changes in this PR. Will dig into it a bit more but feels like this is not connected. -- Th

Re: [PR] feat(go/adbc/driver/snowflake): New setting to enable the maximum timestamp precision to microseconds [arrow-adbc]

2025-06-02 Thread via GitHub
davidhcoe commented on PR #2917: URL: https://github.com/apache/arrow-adbc/pull/2917#issuecomment-2933353670 Based on the response to https://github.com/snowflakedb/gosnowflake/issues/1430, it didn't sound like a fix was going to happen in the gosnowflake driver, so I added this setting to

[PR] feat(go/adbc/driver/snowflake): New setting to enable the maximum timestamp precision to microseconds [arrow-adbc]

2025-06-02 Thread via GitHub
davidhcoe opened a new pull request, #2917: URL: https://github.com/apache/arrow-adbc/pull/2917 Introduces a new setting to set the maximum timestamp precision to Microsecond. Setting this value will convert the default Nanosecond value to Microsecond to avoid the overflow that occurs when

Re: [PR] feat: add `row_group_is_[max/min]_value_exact` to StatisticsConverter [arrow-rs]

2025-06-02 Thread via GitHub
CookiePieWw commented on code in PR #7574: URL: https://github.com/apache/arrow-rs/pull/7574#discussion_r2122610776 ## parquet/tests/arrow_reader/mod.rs: ## @@ -987,6 +991,33 @@ fn create_data_batch(scenario: Scenario) -> Vec { make_utf8_batch(vec![Some("e"), S

Re: [PR] fix(c/driver/postgresql): ingest zoned timestamp as WITH TIME ZONE [arrow-adbc]

2025-06-02 Thread via GitHub
paleolimbot commented on PR #2904: URL: https://github.com/apache/arrow-adbc/pull/2904#issuecomment-2933340769 Got it. No strong preference either way since the point in time is correct, just noting that we're substituting an arbitrary time zone in place of a type that we can at least predi

Re: [I] IllegalStateException: Memory leaked when closing RootAllocator [arrow-java]

2025-06-02 Thread via GitHub
liweiyuan commented on issue #776: URL: https://github.com/apache/arrow-java/issues/776#issuecomment-2933253030 use try-with-resources manage resources, The above GitHub has examples that can reproduce this issue. -- This is an automated message from the Apache Git Service. To respond to

Re: [I] [Dev][R] Organize files for development [arrow]

2025-06-02 Thread via GitHub
eitsupi commented on issue #46661: URL: https://github.com/apache/arrow/issues/46661#issuecomment-2933259345 @amoeba Thanks, that's exactly what you understand. In fact I wasn't even sure which files in `r/tools/` were not needed during installation, so I would be happy to pointed out by

Re: [PR] GH-46684: Fix Meson configuration issue on Windows [arrow]

2025-06-02 Thread via GitHub
github-actions[bot] commented on PR #46685: URL: https://github.com/apache/arrow/pull/46685#issuecomment-2933220395 :warning: GitHub issue #46684 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] GH-46684: Fix Meson configuration issue on Windows [arrow]

2025-06-02 Thread via GitHub
WillAyd opened a new pull request, #46685: URL: https://github.com/apache/arrow/pull/46685 ### Rationale for this change This fixes an issue with the Meson configuration on Windows ### What changes are included in this PR? Fix up incorrect variable name usage ### A

Re: [PR] fix: Make auto_features more user friendly in Meson [arrow-nanoarrow]

2025-06-02 Thread via GitHub
codecov-commenter commented on PR #763: URL: https://github.com/apache/arrow-nanoarrow/pull/763#issuecomment-2933209954 ## [Codecov](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/763?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign

Re: [PR] ci: Bump Meson to ubuntu-latest [arrow-nanoarrow]

2025-06-02 Thread via GitHub
WillAyd merged PR #766: URL: https://github.com/apache/arrow-nanoarrow/pull/766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow

Re: [PR] GH-46673: [CI][R][Docs] Set empty INSTALL_ARGS options as default [arrow]

2025-06-02 Thread via GitHub
hiroyuki-sato commented on code in PR #46682: URL: https://github.com/apache/arrow/pull/46682#discussion_r2122466717 ## ci/scripts/r_build.sh: ## @@ -24,6 +24,12 @@ build_dir=${2} : "${BUILD_DOCS_R:=OFF}" +if [ -z "${INSTALL_ARGS}" ] ; then + R_INSTALL_ARGS=() +else + rea

Re: [PR] GH-46673: [CI][R][Docs] Set empty INSTALL_ARGS options as default [arrow]

2025-06-02 Thread via GitHub
hiroyuki-sato commented on code in PR #46682: URL: https://github.com/apache/arrow/pull/46682#discussion_r2122466717 ## ci/scripts/r_build.sh: ## @@ -24,6 +24,12 @@ build_dir=${2} : "${BUILD_DOCS_R:=OFF}" +if [ -z "${INSTALL_ARGS}" ] ; then + R_INSTALL_ARGS=() +else + rea

Re: [PR] GH-46673: [CI][R][Docs] Set empty INSTALL_ARGS options as default [arrow]

2025-06-02 Thread via GitHub
hiroyuki-sato commented on code in PR #46682: URL: https://github.com/apache/arrow/pull/46682#discussion_r2122466717 ## ci/scripts/r_build.sh: ## @@ -24,6 +24,12 @@ build_dir=${2} : "${BUILD_DOCS_R:=OFF}" +if [ -z "${INSTALL_ARGS}" ] ; then + R_INSTALL_ARGS=() +else + rea

Re: [PR] Optimize `PrimitiveBuilder::append_trusted_len_iter` [arrow-rs]

2025-06-02 Thread via GitHub
alamb commented on PR #7590: URL: https://github.com/apache/arrow-rs/pull/7590#issuecomment-2931618168 🤖 `./gh_compare_arrow.sh` [Benchmark Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_arrow.sh) Running Linux aal-dev 6.11.0-1013-gcp #13~24.04.1-Ubuntu SMP

Re: [PR] chore: bump esbuild from 0.25.0 to 0.25.5 [arrow-js]

2025-06-02 Thread via GitHub
kou merged PR #134: URL: https://github.com/apache/arrow-js/pull/134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

Re: [PR] GH-46673: [CI][R][Docs] Set empty INSTALL_ARGS options as default [arrow]

2025-06-02 Thread via GitHub
kou commented on code in PR #46682: URL: https://github.com/apache/arrow/pull/46682#discussion_r2122435556 ## ci/scripts/r_build.sh: ## @@ -24,6 +24,12 @@ build_dir=${2} : "${BUILD_DOCS_R:=OFF}" +if [ -z "${INSTALL_ARGS}" ] ; then Review Comment: ```suggestion if [ -

Re: [I] [CI][Dev] Lint job failed with timeout [arrow]

2025-06-02 Thread via GitHub
kou commented on issue #46528: URL: https://github.com/apache/arrow/issues/46528#issuecomment-2932999804 We can remove the `archery lint` step after we merge https://github.com/apache/arrow/pull/46664. :-) -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] GH-731: Avro adapter, output dictionary-encoded fields as enums [arrow-java]

2025-06-02 Thread via GitHub
lidavidm commented on PR #779: URL: https://github.com/apache/arrow-java/pull/779#issuecomment-2933011950 (You could also perhaps create a vector implementation that does this unwrapping? Though likely that's more work.) -- This is an automated message from the Apache Git Service. To resp

Re: [I] [CI][Docs] Docs preview jobs failing due to package not found [arrow]

2025-06-02 Thread via GitHub
hiroyuki-sato commented on issue #46673: URL: https://github.com/apache/arrow/issues/46673#issuecomment-2933063802 @thisisnic @AlenkaF Thank you for your comment. I created the PR #46682. I finally set default parameter empty, not `---with-keep.source --no-multiarch`. It keeps t

Re: [PR] feat(csharp/src/Drivers/Databricks): Default catalogs edge cases [arrow-adbc]

2025-06-02 Thread via GitHub
toddmeng-db commented on code in PR #2896: URL: https://github.com/apache/arrow-adbc/pull/2896#discussion_r2122424817 ## csharp/src/Drivers/Databricks/DatabricksConnection.cs: ## @@ -168,18 +168,14 @@ private void ValidateProperties() Properties.TryGetValue(AdbcOpti

Re: [PR] feat(csharp/src/Drivers/Databricks): Default catalogs edge cases [arrow-adbc]

2025-06-02 Thread via GitHub
toddmeng-db commented on code in PR #2896: URL: https://github.com/apache/arrow-adbc/pull/2896#discussion_r2122424817 ## csharp/src/Drivers/Databricks/DatabricksConnection.cs: ## @@ -168,18 +168,14 @@ private void ValidateProperties() Properties.TryGetValue(AdbcOpti

Re: [I] [Dev][R] Organize files for development [arrow]

2025-06-02 Thread via GitHub
amoeba commented on issue #46661: URL: https://github.com/apache/arrow/issues/46661#issuecomment-2933055756 Hi @eitsupi: Do I understand correctly that you'd like to go one step further than just moving these into `r/tools` to get them out of the root of the R package directory? I guess I'd

Re: [PR] GH-46673: [CI][R][Docs] Set empty INSTALL_ARGS options as default [arrow]

2025-06-02 Thread via GitHub
github-actions[bot] commented on PR #46682: URL: https://github.com/apache/arrow/pull/46682#issuecomment-2933049278 Revision: 224c19b2f940210e0a40d505783f7accca2533be Submitted crossbow builds: [ursacomputing/crossbow @ actions-29b57edaf2](https://github.com/ursacomputing/crossbow/bra

Re: [PR] chore: bump @swc/helpers from 0.5.15 to 0.5.17 [arrow-js]

2025-06-02 Thread via GitHub
kou merged PR #131: URL: https://github.com/apache/arrow-js/pull/131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

Re: [PR] chore: bump typescript-eslint from 8.32.1 to 8.33.1 [arrow-js]

2025-06-02 Thread via GitHub
kou merged PR #132: URL: https://github.com/apache/arrow-js/pull/132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

Re: [PR] GH-46673: [CI][R][Docs] Set empty INSTALL_ARGS options as default [arrow]

2025-06-02 Thread via GitHub
hiroyuki-sato commented on PR #46682: URL: https://github.com/apache/arrow/pull/46682#issuecomment-2933046119 @github-actions crossbow submit preview-docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] GH-46270: [C++][Parquet] Clarify GeoStatistics docstring [arrow]

2025-06-02 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #46649: URL: https://github.com/apache/arrow/pull/46649#issuecomment-2933046209 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 8d44eea71a49b42764cc8f07af6d26dce3546489. There were 68

Re: [PR] chore: Bump actions/setup-python from 4 to 5 [arrow-go]

2025-06-02 Thread via GitHub
kou merged PR #396: URL: https://github.com/apache/arrow-go/pull/396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

Re: [I] [C++][Meson] Use gflags wrapdb entry instead of custom CMake wrap [arrow]

2025-06-02 Thread via GitHub
kou commented on issue #46679: URL: https://github.com/apache/arrow/issues/46679#issuecomment-2933045192 Issue resolved by pull request 46680 https://github.com/apache/arrow/pull/46680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] GH-46679: [C++][Meson] Use WrapDB entry for gflags instead of CMake wrapper [arrow]

2025-06-02 Thread via GitHub
kou merged PR #46680: URL: https://github.com/apache/arrow/pull/46680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [I] [CI][Dev][R] Use pre-commit for styler [arrow]

2025-06-02 Thread via GitHub
kou commented on issue #46645: URL: https://github.com/apache/arrow/issues/46645#issuecomment-2933032596 Issue resolved by pull request 46664 https://github.com/apache/arrow/pull/46664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] GH-46673: [CI][R][Docs] Set empty INSTALL_ARGS options as default [arrow]

2025-06-02 Thread via GitHub
github-actions[bot] commented on PR #46682: URL: https://github.com/apache/arrow/pull/46682#issuecomment-2933041983 ``` Unable to match any tasks for `debian-docs` The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/15406293591 ``` -- This is an auto

Re: [PR] chore: Bump actions/setup-python from 4 to 5 [arrow-go]

2025-06-02 Thread via GitHub
kou commented on code in PR #396: URL: https://github.com/apache/arrow-go/pull/396#discussion_r2122416862 ## .github/workflows/benchmark.yml: ## @@ -45,7 +45,7 @@ jobs: with: submodules: recursive - name: Set up Python -uses: actions/setup-pyth

Re: [PR] chore: Bump actions/setup-python from 4 to 5 [arrow-go]

2025-06-02 Thread via GitHub
kou commented on code in PR #396: URL: https://github.com/apache/arrow-go/pull/396#discussion_r2122416445 ## .github/workflows/lint.yml: ## @@ -40,7 +40,7 @@ jobs: with: fetch-depth: 0 - name: Setup Python -uses: actions/setup-python@a26af69be9

Re: [PR] GH-46673: [CI][R][Docs] Set empty INSTALL_ARGS options as default [arrow]

2025-06-02 Thread via GitHub
hiroyuki-sato commented on PR #46682: URL: https://github.com/apache/arrow/pull/46682#issuecomment-2933040768 @github-actions crossbow submit debian-docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] GH-46645: [CI][Dev][R] Use pre-commit for styler [arrow]

2025-06-02 Thread via GitHub
kou merged PR #46664: URL: https://github.com/apache/arrow/pull/46664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [PR] GH-46645: [CI][Dev][R] Use pre-commit for styler [arrow]

2025-06-02 Thread via GitHub
kou commented on code in PR #46664: URL: https://github.com/apache/arrow/pull/46664#discussion_r2122411773 ## r/R/filesystem.R: ## @@ -554,7 +554,8 @@ GcsFileSystem <- R6Class("GcsFileSystem", # Convert from nanoseconds to POSIXct w/ UTC tz if ("expiration" %in% na

Re: [I] [Dev][R] Organize files for development [arrow]

2025-06-02 Thread via GitHub
eitsupi commented on issue #46661: URL: https://github.com/apache/arrow/issues/46661#issuecomment-2933010755 Oh, sorry for the lack of clarity. I did a little checking and it looks like `*/dev/` is not necessarily used in the per-language directories in this repository, but I wanted to sa

Re: [PR] docs: fix target name for c/c++ quickstart [arrow-adbc]

2025-06-02 Thread via GitHub
daipom commented on PR #2906: URL: https://github.com/apache/arrow-adbc/pull/2906#issuecomment-2932982889 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] feat(csharp/src/Drivers/Databricks): Default catalogs edge cases [arrow-adbc]

2025-06-02 Thread via GitHub
eric-wang-1990 commented on code in PR #2896: URL: https://github.com/apache/arrow-adbc/pull/2896#discussion_r2122403046 ## csharp/src/Drivers/Databricks/DatabricksConnection.cs: ## @@ -374,6 +370,27 @@ protected override TOpenSessionReq CreateSessionRequest() retur

Re: [PR] ci: Bump Meson to ubuntu-latest [arrow-nanoarrow]

2025-06-02 Thread via GitHub
WillAyd commented on PR #766: URL: https://github.com/apache/arrow-nanoarrow/pull/766#issuecomment-2933018134 Ended up going a different route since your approval - let me know if this still looks ok -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] GH-731: Avro adapter, output dictionary-encoded fields as enums [arrow-java]

2025-06-02 Thread via GitHub
lidavidm commented on PR #779: URL: https://github.com/apache/arrow-java/pull/779#issuecomment-2933011515 > On reflection, simply decoding a dict-encoded vector is not an option because it will leak. I have pushed an update that will reject dict-encoded fields that are not valid Avro enums

Re: [I] [Dev][R] Organize files for development [arrow]

2025-06-02 Thread via GitHub
kou commented on issue #46661: URL: https://github.com/apache/arrow/issues/46661#issuecomment-2933007727 The current `dev/` has tools for all languages not R specific. (Is `r/dev/` better than `dev/`?) @jonkeane @thisisnic @amoeba @assignUser Do you have any opinion for this? -- Th

Re: [PR] GH-46665: [CI][Crossbow][C++] Use apache/arrow for Alpine Linux [arrow]

2025-06-02 Thread via GitHub
kou merged PR #4: URL: https://github.com/apache/arrow/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [PR] fix(csharp/src/Drivers/Apache/Hive2): improve foreign key handling in GetColumnsExtended [arrow-adbc]

2025-06-02 Thread via GitHub
CurtHagenlocher merged PR #2894: URL: https://github.com/apache/arrow-adbc/pull/2894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [I] [Python] Missing `utf8_zfill` in pyarrow.compute to support `str.zfill` behavior [arrow]

2025-06-02 Thread via GitHub
iabhi4 commented on issue #46683: URL: https://github.com/apache/arrow/issues/46683#issuecomment-2932978615 take -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] feat(go/adbc/driver): initial tracing instrumentation for Snowflake driver [arrow-adbc]

2025-06-02 Thread via GitHub
lidavidm commented on code in PR #2825: URL: https://github.com/apache/arrow-adbc/pull/2825#discussion_r2122349600 ## go/adbc/driver/internal/driverbase/connection.go: ## @@ -183,28 +188,34 @@ func (base *ConnectionImplBase) GetInfo(ctx context.Context, infoCodes []adbc.In

Re: [PR] docs: fix target name for c/c++ quickstart [arrow-adbc]

2025-06-02 Thread via GitHub
lidavidm merged PR #2906: URL: https://github.com/apache/arrow-adbc/pull/2906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.a

Re: [PR] GH-46665: [CI][Crossbow][C++] Use apache/arrow for Alpine Linux [arrow]

2025-06-02 Thread via GitHub
kou commented on PR #4: URL: https://github.com/apache/arrow/pull/4#issuecomment-2932969413 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] [CI][Crossbow][C++] Use apache/arrow for Alpine Linux [arrow]

2025-06-02 Thread via GitHub
kou commented on issue #46665: URL: https://github.com/apache/arrow/issues/46665#issuecomment-2932969885 Issue resolved by pull request 4 https://github.com/apache/arrow/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] chore(java): bump com.google.protobuf:protobuf-java from 4.31.0 to 4.31.1 in /java [arrow-adbc]

2025-06-02 Thread via GitHub
lidavidm merged PR #2909: URL: https://github.com/apache/arrow-adbc/pull/2909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.a

Re: [PR] chore(go/adbc): bump google.golang.org/api from 0.234.0 to 0.235.0 in /go/adbc [arrow-adbc]

2025-06-02 Thread via GitHub
lidavidm merged PR #2913: URL: https://github.com/apache/arrow-adbc/pull/2913 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.a

Re: [PR] feat: add `row_group_is_[max/min]_value_exact` to StatisticsConverter [arrow-rs]

2025-06-02 Thread via GitHub
etseidl commented on code in PR #7574: URL: https://github.com/apache/arrow-rs/pull/7574#discussion_r2122362828 ## parquet/tests/arrow_reader/mod.rs: ## @@ -987,6 +991,33 @@ fn create_data_batch(scenario: Scenario) -> Vec { make_utf8_batch(vec![Some("e"), Some(

Re: [PR] chore(java): bump org.postgresql:postgresql from 42.7.5 to 42.7.6 in /java [arrow-adbc]

2025-06-02 Thread via GitHub
lidavidm merged PR #2910: URL: https://github.com/apache/arrow-adbc/pull/2910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.a

Re: [PR] chore(java): bump com.diffplug.spotless:spotless-maven-plugin from 2.44.4 to 2.44.5 in /java [arrow-adbc]

2025-06-02 Thread via GitHub
lidavidm merged PR #2912: URL: https://github.com/apache/arrow-adbc/pull/2912 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.a

Re: [PR] chore(go/adbc): bump cloud.google.com/go/bigquery from 1.68.0 to 1.69.0 in /go/adbc [arrow-adbc]

2025-06-02 Thread via GitHub
lidavidm merged PR #2914: URL: https://github.com/apache/arrow-adbc/pull/2914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.a

Re: [PR] GH-46599: [C++][Doc][Parquet] Update supported types documentation [arrow]

2025-06-02 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #46620: URL: https://github.com/apache/arrow/pull/46620#issuecomment-2932949774 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1ffc76606b632485d477db532ecc714e69cbb0b7. There were 68

Re: [PR] GH-79: Move `splitAndTransferValidityBuffer` to `BaseValueVector` [arrow-java]

2025-06-02 Thread via GitHub
rtadepalli commented on code in PR #777: URL: https://github.com/apache/arrow-java/pull/777#discussion_r2122364486 ## vector/src/main/java/org/apache/arrow/vector/BaseFixedWidthVector.java: ## @@ -342,7 +340,8 @@ private void allocateBytes(int valueCount) { * slice the sourc

Re: [PR] chore(java): bump dep.org.checkerframework.version from 3.49.3 to 3.49.4 in /java [arrow-adbc]

2025-06-02 Thread via GitHub
lidavidm merged PR #2908: URL: https://github.com/apache/arrow-adbc/pull/2908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.a

[PR] GH-46673: [CI][R][Docs] Set empty INSTALL_ARGS options as default [arrow]

2025-06-02 Thread via GitHub
hiroyuki-sato opened a new pull request, #46682: URL: https://github.com/apache/arrow/pull/46682 ### Rationale for this change This PR fixes the bug introduced in #46527. ### What changes are included in this PR? If the environment variable `INSTALL_ARGS` doesn't set,

Re: [PR] GH-46673: [CI][R][Docs] Set empty INSTALL_ARGS options as default [arrow]

2025-06-02 Thread via GitHub
github-actions[bot] commented on PR #46682: URL: https://github.com/apache/arrow/pull/46682#issuecomment-2932943519 :warning: GitHub issue #46673 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] chore(go/adbc): bump github.com/snowflakedb/gosnowflake from 1.14.0 to 1.14.1 in /go/adbc [arrow-adbc]

2025-06-02 Thread via GitHub
lidavidm merged PR #2915: URL: https://github.com/apache/arrow-adbc/pull/2915 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.a

Re: [I] [C++] Improve Build Time Through ArrayData forward Declarations [arrow]

2025-06-02 Thread via GitHub
Ziy1-Tan commented on issue #45332: URL: https://github.com/apache/arrow/issues/45332#issuecomment-2932941980 take -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] chore(java): bump org.junit:junit-bom from 5.12.2 to 5.13.0 in /java [arrow-adbc]

2025-06-02 Thread via GitHub
lidavidm merged PR #2911: URL: https://github.com/apache/arrow-adbc/pull/2911 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.a

Re: [PR] feat(go/adbc/driver): initial tracing instrumentation for Snowflake driver [arrow-adbc]

2025-06-02 Thread via GitHub
lidavidm commented on PR #2825: URL: https://github.com/apache/arrow-adbc/pull/2825#issuecomment-2932934298 Note that https://github.com/snowflakedb/gosnowflake/commit/d0921865822ada6dbbcc1a673a8810d436b9eb5e (which is in 1.14.1 that I just merged) adds OTel to the Snowflake SDK, if we can

Re: [PR] feat(csharp/src/Drivers/Databricks): Add cloud fetch heartbeat polling tests [arrow-adbc]

2025-06-02 Thread via GitHub
CurtHagenlocher merged PR #2898: URL: https://github.com/apache/arrow-adbc/pull/2898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] GH-774: Consoliate `BitVectorHelper.getValidityBufferSize` and `BaseValueVector.getValidityBufferSizeFromCount` [arrow-java]

2025-06-02 Thread via GitHub
rtadepalli commented on PR #775: URL: https://github.com/apache/arrow-java/pull/775#issuecomment-2932916625 Fixed now. Re-adding that method overrode my static import, have to refer to `BitVectorHelper` explicitly now. -- This is an automated message from the Apache Git Service. To respon

Re: [PR] fix(go/adbc/driver): inject version to built Go drivers [arrow-adbc]

2025-06-02 Thread via GitHub
davidhcoe commented on PR #2916: URL: https://github.com/apache/arrow-adbc/pull/2916#issuecomment-2932909780 > @davidhcoe Can you check this out and test it with your workflows to ensure it works outside of my testing? yes, I will try it out tomorrow. -- This is an automated messag

Re: [PR] Add FixedSizeBinary to `take_kernel` benchmark [arrow-rs]

2025-06-02 Thread via GitHub
alamb merged PR #7592: URL: https://github.com/apache/arrow-rs/pull/7592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache

Re: [PR] feat(arrow/extensions): Add Variant extension type, array, and builder [arrow-go]

2025-06-02 Thread via GitHub
lidavidm commented on code in PR #395: URL: https://github.com/apache/arrow-go/pull/395#discussion_r2122337639 ## arrow/extensions/variant.go: ## @@ -0,0 +1,1536 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See th

Re: [PR] fix(c/driver/postgresql): ingest zoned timestamp as WITH TIME ZONE [arrow-adbc]

2025-06-02 Thread via GitHub
lidavidm commented on PR #2904: URL: https://github.com/apache/arrow-adbc/pull/2904#issuecomment-2932888300 Ah, I will do some more testing...but I think zoned timestamps should be preserved as zoned timestamps (even if the actual metadata isn't preserved) -- This is an automated message

Re: [PR] POC: Sketch out cached filter result API [arrow-rs]

2025-06-02 Thread via GitHub
Dandandan commented on code in PR #7513: URL: https://github.com/apache/arrow-rs/pull/7513#discussion_r2122235843 ## arrow-array/src/builder/generic_bytes_view_builder.rs: ## @@ -406,6 +459,122 @@ impl GenericByteViewBuilder { }; buffer_size + in_progress + tra

Re: [PR] POC: Sketch out cached filter result API [arrow-rs]

2025-06-02 Thread via GitHub
Dandandan commented on code in PR #7513: URL: https://github.com/apache/arrow-rs/pull/7513#discussion_r2122316118 ## arrow-select/src/filter.rs: ## @@ -744,23 +828,82 @@ where GenericByteArray::from(data) } +impl ArrayBuilderExtFilter for GenericByteViewBuilder { +fn

[PR] Fix azure path parsing [arrow-rs-object-store]

2025-06-02 Thread via GitHub
kylebarron opened a new pull request, #399: URL: https://github.com/apache/arrow-rs-object-store/pull/399 # Which issue does this PR close? Closes https://github.com/apache/arrow-rs-object-store/issues/398. # Rationale for this change Is there a spec for each of these URL

Re: [PR] feat(csharp/src/Drivers/Databricks): Default catalogs edge cases [arrow-adbc]

2025-06-02 Thread via GitHub
CurtHagenlocher commented on code in PR #2896: URL: https://github.com/apache/arrow-adbc/pull/2896#discussion_r2122310327 ## csharp/src/Drivers/Databricks/DatabricksStatement.cs: ## @@ -41,6 +41,19 @@ internal class DatabricksStatement : SparkStatement, IHiveServer2Statement

Re: [PR] POC: Sketch out cached filter result API [arrow-rs]

2025-06-02 Thread via GitHub
Dandandan commented on code in PR #7513: URL: https://github.com/apache/arrow-rs/pull/7513#discussion_r2122304178 ## arrow-select/src/incremental_array_builder.rs: ## @@ -0,0 +1,134 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license

Re: [PR] POC: Sketch out cached filter result API [arrow-rs]

2025-06-02 Thread via GitHub
Dandandan commented on code in PR #7513: URL: https://github.com/apache/arrow-rs/pull/7513#discussion_r2122304178 ## arrow-select/src/incremental_array_builder.rs: ## @@ -0,0 +1,134 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license

  1   2   3   4   >