djellemah commented on PR #15597:
URL: https://github.com/apache/datafusion/pull/15597#issuecomment-2970492404
Merge conflict introduced by f40e0db161 on 02-may-2025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
mbutrovich closed issue #1875: [Spark SQL] Fix InsertSuite failure when using
native_iceberg_compat with Spark 3.4.3
URL: https://github.com/apache/datafusion-comet/issues/1875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mbutrovich merged PR #1879:
URL: https://github.com/apache/datafusion-comet/pull/1879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...
andygrove opened a new issue, #1881:
URL: https://github.com/apache/datafusion-comet/issues/1881
### What is the problem the feature request solves?
We currently support three different Parquet scan implementations:
- `native_comet`
- `native_datafusion`
- `native_iceberg_
timsaucer closed pull request #1033: Feat/ffi scalar udf
URL: https://github.com/apache/datafusion-python/pull/1033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
timsaucer closed pull request #1054: enhance sql-using-python-udf example
URL: https://github.com/apache/datafusion-python/pull/1054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
timsaucer commented on PR #1054:
URL:
https://github.com/apache/datafusion-python/pull/1054#issuecomment-2970805134
Closing since no activity. Please reopen if this continues to be an issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
timsaucer closed pull request #1072: 1065/enhancement/add ctx to `__init__.py`
URL: https://github.com/apache/datafusion-python/pull/1072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
timsaucer commented on PR #1072:
URL:
https://github.com/apache/datafusion-python/pull/1072#issuecomment-2970807273
Closing since no activity. Please reopen PR if this continues to be a user's
need.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
timsaucer closed pull request #1073: fix: improve CSV path handling and error
handling in substrait example
URL: https://github.com/apache/datafusion-python/pull/1073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
alamb commented on PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#issuecomment-2971305067
🤖: Benchmark completed
Details
```
Comparing HEAD and topk-dynamic-filters
Benchmark sort_tpch.json
┏━━
alamb commented on PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#issuecomment-2971297789
🤖 `./gh_compare_branch.sh` [Benchmark
Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_branch.sh)
Running
Linux aal-dev 6.11.0-1015-gcp #15~24.04.1-Ubun
adriangb commented on issue #16402:
URL: https://github.com/apache/datafusion/issues/16402#issuecomment-2971321730
Doesn't
https://github.com/apache/datafusion/blob/4dd6923787084548c9ecc6d90c630c2c28ee9259/datafusion/datasource-parquet/src/metrics.rs#L30-L33
cover that?
--
This is an aut
alamb commented on code in PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#discussion_r2145790872
##
datafusion/core/tests/fuzz_cases/topk_filter_pushdown.rs:
##
@@ -0,0 +1,387 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribu
andygrove commented on code in PR #1883:
URL: https://github.com/apache/datafusion-comet/pull/1883#discussion_r2145878327
##
spark/src/test/scala/org/apache/comet/parquet/ParquetReadSuite.scala:
##
@@ -1745,6 +1746,77 @@ abstract class ParquetReadSuite extends CometTestBase {
codecov-commenter commented on PR #1883:
URL:
https://github.com/apache/datafusion-comet/pull/1883#issuecomment-2971338111
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1883?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
ozankabak commented on PR #16398:
URL: https://github.com/apache/datafusion/pull/16398#issuecomment-2970506512
Thanks for the draft -- this is inline with my understanding from your
description. I think it will inch us closer to a good, lasting solution
(especially after your upstream tokio
alamb commented on code in PR #16324:
URL: https://github.com/apache/datafusion/pull/16324#discussion_r2145201108
##
datafusion/core/tests/sql/explain_analyze.rs:
##
@@ -52,43 +54,45 @@ async fn explain_analyze_baseline_metrics() {
let formatted = arrow::util::pretty::prett
alamb commented on PR #16389:
URL: https://github.com/apache/datafusion/pull/16389#issuecomment-2970575208
🤖: Benchmark completed
Details
```
group main
opt-process-unnest
-
robtandy commented on issue #16303:
URL: https://github.com/apache/datafusion/issues/16303#issuecomment-2970581452
Thanks for creating this issue @alamb !!
Regarding the location of the code, if it is in datafusion proper rather
than the CLI, it would be available in datafusion pyt
alamb commented on PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#issuecomment-2970575427
🤖 `./gh_compare_branch.sh` [Benchmark
Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_branch.sh)
Running
Linux aal-dev 6.11.0-1015-gcp #15~24.04.1-Ubun
andygrove commented on PR #1866:
URL:
https://github.com/apache/datafusion-comet/pull/1866#issuecomment-2970625122
> All the tests for first and last are disabled currently:
>
> * [Re-enable tests for FIRST/LAST
#1646](https://github.com/apache/datafusion-comet/issues/1646)
alamb commented on PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#issuecomment-2970721901
🤖: Benchmark completed
Details
```
Comparing HEAD and topk-dynamic-filters
Benchmark clickbench_extended.json
timsaucer closed pull request #1099: build(deps): bump tokio from 1.41.1 to
1.44.2 in /examples/ffi-table-provider
URL: https://github.com/apache/datafusion-python/pull/1099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
timsaucer commented on PR #1099:
URL:
https://github.com/apache/datafusion-python/pull/1099#issuecomment-2970935652
Closing because https://github.com/apache/datafusion-python/pull/1143
updates us to 1.45
--
This is an automated message from the Apache Git Service.
To respond to the mess
dependabot[bot] commented on PR #1099:
URL:
https://github.com/apache/datafusion-python/pull/1099#issuecomment-2970935721
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor v
andygrove commented on code in PR #1747:
URL: https://github.com/apache/datafusion-comet/pull/1747#discussion_r2145246950
##
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##
@@ -105,8 +105,49 @@ case class CometScanRule(session: SparkSession) extends
Rule[Spa
Dandandan commented on code in PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#discussion_r2145258417
##
datafusion/physical-plan/src/topk/mod.rs:
##
@@ -207,6 +221,7 @@ impl TopK {
// Idea: filter out rows >= self.heap.max() early (before passing to
`R
kosiew commented on PR #1141:
URL:
https://github.com/apache/datafusion-python/pull/1141#issuecomment-2970789318
@timsaucer
Thanks for the review and nipping the `panic`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
timsaucer commented on PR #1033:
URL:
https://github.com/apache/datafusion-python/pull/1033#issuecomment-2970802418
Superseded by https://github.com/apache/datafusion-python/pull/1145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
timsaucer commented on PR #1110:
URL:
https://github.com/apache/datafusion-python/pull/1110#issuecomment-2971126021
Superseded by https://github.com/apache/datafusion-python/pull/1145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
timsaucer closed pull request #1110: WIP: scalar UDFs with metadata
URL: https://github.com/apache/datafusion-python/pull/1110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
adriangb commented on code in PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#discussion_r2145547651
##
datafusion/physical-plan/src/sorts/sort.rs:
##
@@ -843,6 +846,8 @@ pub struct SortExec {
common_sort_prefix: Vec,
/// Cache holding plan properties l
parthchandra opened a new pull request, #1883:
URL: https://github.com/apache/datafusion-comet/pull/1883
## Which issue does this PR close?
The mapping between Spark and Parquet for schemas with field ids did not
correctly handle the schemas with nested arrays of structs.
## R
GitHub user niebayes added a comment to the discussion: Search Pushdown (e.g.
Vector Search) Into Table Providers
Cool
GitHub link:
https://github.com/apache/datafusion/discussions/16358#discussioncomment-13461933
This is an automatically sent email for [email protected].
To
andygrove commented on code in PR #1747:
URL: https://github.com/apache/datafusion-comet/pull/1747#discussion_r2145229513
##
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##
@@ -105,8 +105,49 @@ case class CometScanRule(session: SparkSession) extends
Rule[Spa
andygrove commented on issue #1772:
URL:
https://github.com/apache/datafusion-comet/issues/1772#issuecomment-2970650359
This could also be handled in
https://github.com/apache/datafusion-comet/issues/1881
--
This is an automated message from the Apache Git Service.
To respond to the mess
trompa commented on PR #1874:
URL:
https://github.com/apache/datafusion-comet/pull/1874#issuecomment-2970687941
I thinn i can actually just select hour(now()), and parse the query plan,
would that work?
On Fri, Jun 13, 2025, 14:57 Matt Butrovich ***@***.***> wrote:
> *mbutro
alamb commented on PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#issuecomment-2971173365
> > QQuery 25│ 380.03 ms │279.23 ms │ +1.36x faster
>
> ```sql
> SELECT SearchPhrase FROM hits WHERE SearchPhrase <> '' ORDER BY
SearchPhrase LIMIT 10;
>
alamb opened a new issue, #16402:
URL: https://github.com/apache/datafusion/issues/16402
### Is your feature request related to a problem or challenge?
- This is a follow on to the feature added by @adriangb in
https://github.com/apache/datafusion/pull/16014
@adriangb added th
alamb commented on PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#issuecomment-2971198838
I also filed a ticket to add a metric that we can use to see when file
pruning is working:
- https://github.com/apache/datafusion/issues/16402
--
This is an automated message from
simonvandel commented on code in PR #16389:
URL: https://github.com/apache/datafusion/pull/16389#discussion_r2145802029
##
datafusion/sql/src/select.rs:
##
@@ -374,6 +383,14 @@ impl SqlToRel<'_, S> {
fn try_process_aggregate_unnest(&self, input: LogicalPlan) ->
Result {
alamb commented on code in PR #16390:
URL: https://github.com/apache/datafusion/pull/16390#discussion_r2145093532
##
datafusion/physical-plan/src/joins/nested_loop_join.rs:
##
@@ -718,8 +718,6 @@ struct NestedLoopJoinStream {
inner_table: OnceFut,
/// Information of in
alamb commented on PR #16389:
URL: https://github.com/apache/datafusion/pull/16389#issuecomment-2970396033
🤖 `./gh_compare_branch_bench.sh` [Benchmark
Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_branch_bench.sh)
Running
Linux aal-dev 6.11.0-1015-gcp #15~
alamb commented on code in PR #16399:
URL: https://github.com/apache/datafusion/pull/16399#discussion_r2145081087
##
docs/source/contributor-guide/roadmap.md:
##
@@ -46,81 +46,12 @@ make review efficient and avoid surprises.
# Quarterly Roadmap
-A quarterly roadmap will be
alamb commented on PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#issuecomment-2970425995
> @alamb could you kick off your benchmarks run on this branch?
Sorry -- I missed this. I have queued them up and they should be running
shortly
--
This is an automated messag
alamb commented on code in PR #16391:
URL: https://github.com/apache/datafusion/pull/16391#discussion_r2145088320
##
datafusion/functions-table/src/generate_series.rs:
##
@@ -197,11 +197,17 @@ impl TableFunctionImpl for GenerateSeriesFuncImpl {
}
let mut norm
alamb commented on PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#issuecomment-2970437633
> The interesting bit is that this is now faster even with predicate
pushdown turned off thanks to the late partition / stats based pruning @alamb
!! For the case of a single partition
timsaucer commented on PR #1102:
URL:
https://github.com/apache/datafusion-python/pull/1102#issuecomment-2970943961
Superseded by https://github.com/apache/datafusion-python/pull/1143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dependabot[bot] commented on PR #1102:
URL:
https://github.com/apache/datafusion-python/pull/1102#issuecomment-2970944042
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor v
timsaucer closed pull request #1102: build(deps): bump crossbeam-channel from
0.5.13 to 0.5.15 in /examples/ffi-table-provider
URL: https://github.com/apache/datafusion-python/pull/1102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
dependabot[bot] commented on PR #1134:
URL:
https://github.com/apache/datafusion-python/pull/1134#issuecomment-2970939340
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor v
dependabot[bot] commented on PR #1135:
URL:
https://github.com/apache/datafusion-python/pull/1135#issuecomment-2970947128
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor v
timsaucer closed pull request #1135: build(deps): bump uuid from 1.16.0 to
1.17.0
URL: https://github.com/apache/datafusion-python/pull/1135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
timsaucer commented on PR #1135:
URL:
https://github.com/apache/datafusion-python/pull/1135#issuecomment-2970947048
Superseded by https://github.com/apache/datafusion-python/pull/1143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dependabot[bot] commented on PR #1105:
URL:
https://github.com/apache/datafusion-python/pull/1105#issuecomment-2970946553
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor v
andygrove commented on code in PR #1747:
URL: https://github.com/apache/datafusion-comet/pull/1747#discussion_r2145516448
##
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##
@@ -105,8 +105,49 @@ case class CometScanRule(session: SparkSession) extends
Rule[Spa
timsaucer commented on PR #1105:
URL:
https://github.com/apache/datafusion-python/pull/1105#issuecomment-2970946246
Superseded by https://github.com/apache/datafusion-python/pull/1143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
timsaucer closed pull request #1105: build(deps): bump mimalloc from 0.1.43 to
0.1.46
URL: https://github.com/apache/datafusion-python/pull/1105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
Dandandan commented on code in PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#discussion_r2145521489
##
datafusion/physical-plan/src/topk/mod.rs:
##
@@ -207,6 +221,7 @@ impl TopK {
// Idea: filter out rows >= self.heap.max() early (before passing to
`R
timsaucer closed pull request #1134: build(deps): bump tokio from 1.44.2 to
1.45.1
URL: https://github.com/apache/datafusion-python/pull/1134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
timsaucer closed pull request #1090: build(deps): bump astral-sh/setup-uv from
5 to 6
URL: https://github.com/apache/datafusion-python/pull/1090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
andygrove commented on code in PR #1747:
URL: https://github.com/apache/datafusion-comet/pull/1747#discussion_r2145468079
##
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##
@@ -105,8 +105,49 @@ case class CometScanRule(session: SparkSession) extends
Rule[Spa
timsaucer commented on PR #1114:
URL:
https://github.com/apache/datafusion-python/pull/1114#issuecomment-2970893819
@dependabot ignore this major version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
timsaucer closed pull request #1114: build(deps): bump pyo3 from 0.24.1 to
0.24.2
URL: https://github.com/apache/datafusion-python/pull/1114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
timsaucer commented on PR #1109:
URL:
https://github.com/apache/datafusion-python/pull/1109#issuecomment-2970895644
@dependabot ignore this major version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
timsaucer commented on PR #1114:
URL:
https://github.com/apache/datafusion-python/pull/1114#issuecomment-2970893094
Closing because our pyo3 upgrade is controlled by upstream dependency
requirements.
--
This is an automated message from the Apache Git Service.
To respond to the message,
dependabot[bot] commented on PR #1129:
URL:
https://github.com/apache/datafusion-python/pull/1129#issuecomment-2970896425
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor v
dependabot[bot] commented on PR #1114:
URL:
https://github.com/apache/datafusion-python/pull/1114#issuecomment-2970893214
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor v
timsaucer closed pull request #1109: build(deps): bump pyo3 from 0.23.4 to
0.24.1 in /examples/ffi-table-provider
URL: https://github.com/apache/datafusion-python/pull/1109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dependabot[bot] commented on PR #1109:
URL:
https://github.com/apache/datafusion-python/pull/1109#issuecomment-2970895087
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor v
timsaucer commented on PR #1129:
URL:
https://github.com/apache/datafusion-python/pull/1129#issuecomment-2970896750
@dependabot ignore this major version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
timsaucer commented on PR #1129:
URL:
https://github.com/apache/datafusion-python/pull/1129#issuecomment-2970896322
Closing because our pyo3 upgrade is controlled by upstream dependency
requirements.
--
This is an automated message from the Apache Git Service.
To respond to the message,
timsaucer commented on PR #1109:
URL:
https://github.com/apache/datafusion-python/pull/1109#issuecomment-2970894994
Closing because our pyo3 upgrade is controlled by upstream dependency
requirements.
--
This is an automated message from the Apache Git Service.
To respond to the message,
timsaucer closed pull request #1129: build(deps): bump pyo3-build-config from
0.24.1 to 0.25.0
URL: https://github.com/apache/datafusion-python/pull/1129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dependabot[bot] commented on PR #1129:
URL:
https://github.com/apache/datafusion-python/pull/1129#issuecomment-2970896867
OK, I won't notify you about version 0.x.x again, unless you re-open this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
dependabot[bot] commented on PR #1109:
URL:
https://github.com/apache/datafusion-python/pull/1109#issuecomment-2970895746
OK, I won't notify you about version 0.x.x again, unless you re-open this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
timsaucer commented on code in PR #1123:
URL:
https://github.com/apache/datafusion-python/pull/1123#discussion_r2145455758
##
python/datafusion/dataframe.py:
##
@@ -704,38 +694,135 @@ def write_csv(self, path: str | pathlib.Path,
with_header: bool = False) -> None
def wri
andygrove commented on code in PR #1747:
URL: https://github.com/apache/datafusion-comet/pull/1747#discussion_r2145468079
##
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##
@@ -105,8 +105,49 @@ case class CometScanRule(session: SparkSession) extends
Rule[Spa
alamb commented on issue #16302:
URL: https://github.com/apache/datafusion/issues/16302#issuecomment-2970886506
Thanks @xiedeyantu -- I'll try and review it shortly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
andygrove closed issue #1342: This Week in Comet (Jan 26)
URL: https://github.com/apache/datafusion-comet/issues/1342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
dependabot[bot] commented on PR #1114:
URL:
https://github.com/apache/datafusion-python/pull/1114#issuecomment-2970893918
OK, I won't notify you about version 0.x.x again, unless you re-open this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
timsaucer commented on PR #1090:
URL:
https://github.com/apache/datafusion-python/pull/1090#issuecomment-2970901160
Closing because this is already updated in `main`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
alamb commented on PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#issuecomment-2970903681
> And obviously we expect Q23 to get a huge bump once we enable filter
pushdown...
>
> I think the only thing left here is for someone to review in detail 😄
I will do
dependabot[bot] commented on PR #1090:
URL:
https://github.com/apache/datafusion-python/pull/1090#issuecomment-2970901234
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor v
timsaucer commented on PR #1015:
URL:
https://github.com/apache/datafusion-python/pull/1015#issuecomment-2970821413
Original problem was resolved by
https://github.com/apache/datafusion-python/pull/1036 which I believe used part
of this work. Thank you very much for the contribution!
--
parthchandra commented on code in PR #1747:
URL: https://github.com/apache/datafusion-comet/pull/1747#discussion_r2145482367
##
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##
@@ -105,8 +105,49 @@ case class CometScanRule(session: SparkSession) extends
Rule[
parthchandra commented on issue #1882:
URL:
https://github.com/apache/datafusion-comet/issues/1882#issuecomment-2970909374
Metrics aren't really implemented correctly for `native_iceberg_compat` at
the moment so enabling the test won't help. The metrics do need to be corrected.
--
This i
alamb commented on issue #15885:
URL: https://github.com/apache/datafusion/issues/15885#issuecomment-2970916647
I have seen @irenjj / @duongcongtoai / @UBarney / @jonathanc-n working on
this
@xudong963 (a DataFusion committer and PMC member) has experience in this
area and may have
alamb commented on PR #16389:
URL: https://github.com/apache/datafusion/pull/16389#issuecomment-2971026040
> logical_select_all_from_1000 10.80 120.4±0.22ms
? ?/sec1.00 11.1±0.06ms? ?/sec
🚀
The other planning benchmarks look like prett
alamb commented on code in PR #16389:
URL: https://github.com/apache/datafusion/pull/16389#discussion_r2145582029
##
datafusion/sql/src/select.rs:
##
@@ -374,6 +383,14 @@ impl SqlToRel<'_, S> {
fn try_process_aggregate_unnest(&self, input: LogicalPlan) ->
Result {
alamb commented on PR #16392:
URL: https://github.com/apache/datafusion/pull/16392#issuecomment-2971066685
This needs to wait for an arrow-rs update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
alamb commented on code in PR #16388:
URL: https://github.com/apache/datafusion/pull/16388#discussion_r2145600999
##
datafusion/core/src/execution/session_state.rs:
##
@@ -1675,6 +1675,13 @@ impl ContextProvider for SessionContextProvider<'_> {
.get(name)
alamb commented on PR #16077:
URL: https://github.com/apache/datafusion/pull/16077#issuecomment-2971062970
Marking as draft as I think this PR is no longer waiting on feedback and I
am trying to make it easier to find PRs in need of review. Please mark it as
ready for review when it is read
Dandandan commented on code in PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#discussion_r2145572928
##
datafusion/physical-plan/src/sorts/sort.rs:
##
@@ -843,6 +846,8 @@ pub struct SortExec {
common_sort_prefix: Vec,
/// Cache holding plan properties
Dandandan commented on PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#issuecomment-2971038192
I wonder if we see any improvements on the "sort tpch with limit" benchmark?
```cargo run --release --bin dfbench -- sort-tpch --iterations 5 --path
"${TPCH_DIR}" -o "${RESUL
alamb closed pull request #16392: chore(deps): bump prost-build from 0.13.5 to
0.14.0 in the proto group
URL: https://github.com/apache/datafusion/pull/16392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
alamb closed issue #16323: Request to update crates.io ownership
URL: https://github.com/apache/datafusion/issues/16323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
alamb commented on issue #16323:
URL: https://github.com/apache/datafusion/issues/16323#issuecomment-2971079530
I think we are now done with this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
dependabot[bot] commented on PR #16392:
URL: https://github.com/apache/datafusion/pull/16392#issuecomment-2971066993
This pull request was built based on a group rule. Closing it will not
ignore any of these versions in future pull requests.
To ignore these dependencies, configure [ig
1 - 100 of 247 matches
Mail list logo
