On Sun, Jun 7, 2009 at 6:39 PM, Sam Gross colesb...@gmail.com wrote:
The makefile in oophm-plugins-trunk references tools/gecko-sdks, but
that directory isn't in the SVN repo. Is there a plan to put it in
tools? It would be nice if we all used the same gecko sdks. I
assembled a version of
LGTM
Thanks for pointing this out - shouldn't happen again.
kathrin
On Fri, Jun 5, 2009 at 9:11 PM, Scott Blumsco...@google.com wrote:
Hi Kathrin,
I ran into a series of checkstyle violations introduce in this revision.
Please review commit attached patch.
To setup Eclipse to detect
LGTM
The actual patch looks good to me (see only two small comments below),
but I am a little concerned about the unescaping of XML. Please see my
comment below.
http://gwt-code-reviews.appspot.com/33843/diff/1/6
File tools/soyc-vis/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
(right):
http://gwt-code-reviews.appspot.com/33843/diff/1/3
File tools/soyc-vis/src/com/google/gwt/soyc/SoycDashboard.java (left):
http://gwt-code-reviews.appspot.com/33843/diff/1/3#oldcode174
Line 174: return unescaped;
This method looks fishy to me. The first argument to String.replaceAll
is a regex,
On Fri, Jun 5, 2009 at 6:27 PM, Ian Petersenispet...@gmail.com wrote:
Ever since I started using Eclipse, I've always thought that compilers
and make systems should be always on. I'd bet an incremental build
would be hard to pull off first time around, but an always-on GWT
compiler could at
Reviewers: scottb,
Description:
I'm tackling another small issue on the JS side to get myself up to
speed with the code (esp. the SOYC changes throughout) and help shake
out all the cobwebs since my last set of patches :).
This is a simple patch to improve the optimization of if statements.
Thanks, Kathrin! There are few questions inline before I commit it.
http://gwt-code-reviews.appspot.com/33843/diff/1/6
File tools/soyc-vis/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
(right):
http://gwt-code-reviews.appspot.com/33843/diff/1/6#newcode629
Line 629: if (i ==
Author: sco...@google.com
Date: Mon Jun 8 11:02:24 2009
New Revision: 5520
Modified:
releases/1.6/branch-info.txt
releases/1.6/user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java
Log:
Merging trunk c5221 into 1.6 release branch.
Fixes synchronization issues in
Sounds good, see one response below.
http://gwt-code-reviews.appspot.com/33843/diff/1/3#oldcode174
Line 174: return unescaped;
Strange indeed. I have done some digging, and it looks like this method
was never called. It comes in in revision 4221 along with the initial
committed version
Thank you! It is committed at r5521.
http://gwt-code-reviews.appspot.com/33843
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Author: sco...@google.com
Date: Mon Jun 8 13:11:55 2009
New Revision: 5522
Modified:
trunk/user/src/com/google/gwt/user/client/Cookies.java
trunk/user/test/com/google/gwt/user/client/CookieTest.java
Log:
Fixes checkstyle warnings in Cookies CookieTest.
Review by: kprobst
Modified:
Author: j...@google.com
Date: Mon Jun 8 14:25:39 2009
New Revision: 5523
Modified:
trunk/dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js
Log:
Fixes issues 3717 and 3733 by adding some extra latching to avoid creating
the
script frame until the body's done loading.
Patch by:
Author: j...@google.com
Date: Mon Jun 8 14:52:47 2009
New Revision: 5524
Modified:
branches/snapshot-2009.06.02-r5498/branch-info.txt
branches/snapshot-2009.06.02-r5498/dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js
Log:
Merge trunk r5523 into the 6/2 snapshot branch.
svn
Hi,
I'd like to submit a patch (see below) that changes JsArrayT extends
JavaScriptObject to JsArrayT
Motivation:
Support more lightweight code in places where we depend on Javascript
anyway.
In particular, I would like to remove the dependency on LinkedList in
AsyncFragmentLoader in a
Wouldn't this break existing code, such as?
JsArray noGenericParams = ;
SomeJso jso = noGenericParams.get(i).cast();
--
Bob Vawter
Google Web Toolkit Team
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Mon, Jun 8, 2009 at 6:22 PM, Stefan Haustein haust...@google.com wrote:
I'd like to submit a patch (see below) that changes JsArrayT extends
JavaScriptObject to JsArrayT
Motivation:
Support more lightweight code in places where we depend on Javascript
anyway.
In particular, I would
Please also look at the compiled JS. I think the less restrictive bound will
cause the compiler to generate worse code (e.g. dynamic casts in some or all
contexts) which would make it a non-starter.
On Mon, Jun 8, 2009 at 6:22 PM, Stefan Haustein haust...@google.com wrote:
Hi,
I'd like to
In particular, I use my own JsArray/JsMap implementation to avoid JRE
collections in GQuery. Perhaps rather than patching JsArray, there
should just be something like FastArrayList and FastMap which do not
implement JRE Collections, but are nothing more than wrappers around
JS arrays and objects
What you describe, Ray, is definitely going to happen. It has to. I have
begun a design doc for that very thing. I'll float it for comments as soon
as I'm finished with the first draft.
On Mon, Jun 8, 2009 at 8:02 PM, Ray Cromwell cromwell...@gmail.com wrote:
In particular, I use my own
Author: j...@google.com
Date: Mon Jun 8 20:14:29 2009
New Revision: 5525
Modified:
branches/snapshot-2009.06.02-r5498/user/src/com/google/gwt/i18n/rebind/AnnotationsResource.java
branches/snapshot-2009.06.02-r5498/user/src/com/google/gwt/i18n/rebind/ResourceFactory.java
Author: j...@google.com
Date: Mon Jun 8 20:50:17 2009
New Revision: 5526
Modified:
branches/snapshot-2009.06.02-r5498/user/test/com/google/gwt/i18n/client/I18NTest.java
branches/snapshot-2009.06.02-r5498/user/test/com/google/gwt/i18n/rebind/AbstractResourceTest.java
Log:
Test
Author: j...@google.com
Date: Mon Jun 8 22:46:14 2009
New Revision: 5527
Modified:
branches/snapshot-2009.06.02-r5498/user/src/com/google/gwt/i18n/rebind/ResourceFactory.java
Log:
Reinstate public access inadvertently removed in i18n generator rewrite.
Patch by: jat
Review by: scottb
22 matches
Mail list logo
