Daniel Kurka has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 7:
@Manuel good catch.
We do not need to care about the History Frame (I looked it up before
submitting th
Manuel Carrasco Moñino has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 7:
Sorry if I come later to this change, but I am wondering if Should'nt it
preserve gwt specific
Daniel Kurka has submitted this change and it was merged.
Change subject: Adding a DOM clear method to RootPanel
..
Adding a DOM clear method to RootPanel
By calling rootPanel.clear(true) the user can clear
widgets AND DOM ele
Brian Slesinsky has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 6: Code-Review+2
This is a pretty minor change, breakage is unlikely, and I don't think it
matters too m
Goktug Gokdogan has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 6:
It is better to just call it "clear" so that people will need to read the
javadoc instead of making a
Brian Slesinsky has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 6:
Admittedly it's a judgment call. I'm somewhat biased in favor of shorter
names and somewhat against g
Daniel Kurka has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 6:
With that rationale we should name it clearWidgetsAndDom?
--
To view, visit https://gwt-review.googlesour
Brian Slesinsky has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 6:
(1 comment)
I still don't think it's necessary but I'm okay with a helper method if
it's very simple
Hello Matthew Dempsky, Leeroy Jenkins, Brian Slesinsky,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/2512
to look at the new patch set (#6).
Change subject: Adding a DOM clear method to RootPanel
.
Daniel Kurka has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 5:
I would like to see this get landed or abandoned. I think having it would
have a small value, but if Bri
Daniel Kurka has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 4:
(1 comment)
File user/src/com/google/gwt/user/client
Hello Matthew Dempsky, Leeroy Jenkins, Brian Slesinsky,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/2512
to look at the new patch set (#5).
Change subject: Adding a DOM clear method to RootPanel
.
Goktug Gokdogan has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 4:
(1 comment)
As I noted earlier in my comments, I agree with Brian.
With the added removeAllChildren,
Daniel Kurka has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 4:
-Addressed all javadoc issues.
-Moved back to iterating over child elements.
-added test for mixed child e
Daniel Kurka has uploaded a new patch set (#4).
Change subject: Adding a DOM clear method to RootPanel
..
Adding a DOM clear method to RootPanel
By calling rootPanel.clear(true) the user can clear
widgets AND DOM elements locat
Brian Slesinsky has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 3: Code-Review-1
I think this probably isn't worth doing. I don't see why we should change a
public API
Thomas Broyer has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 2:
(1 comment)
File user/src/com/google/gwt/user/clien
Goktug Gokdogan has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 2:
(3 comments)
Daniel, can you also respond to other concerns?
It is a good idea to respond every commen
Daniel Kurka has uploaded a new patch set (#3).
Change subject: Adding a DOM clear method to RootPanel
..
Adding a DOM clear method to RootPanel
By calling rootPanel.clear(true) the user can clear
widgets AND DOM elements locat
Daniel Kurka has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 2:
(1 comment)
File user/src/com/google/gwt/user/client
Thomas Broyer has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 2:
(1 comment)
IMO this should remove all child *nodes*, not only elements.
..
Daniel Kurka has uploaded a new patch set (#2).
Change subject: Adding a DOM clear method to RootPanel
..
Adding a DOM clear method to RootPanel
By calling rootPanel.clear(true) the user can clear
widgets AND DOM elements locat
Brian Slesinsky has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 1:
I like that. Perhaps add Element.removeAllChildren() and put documentation
in root panel's javadoc sh
Goktug Gokdogan has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 1:
(2 comments)
File user/src/com/google/gwt/user/cl
Matthew Dempsky has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 1: Code-Review+1
(2 comments)
File user/src/com/goog
Daniel Kurka has uploaded a new change for review.
https://gwt-review.googlesource.com/2512
Change subject: Adding a DOM clear method to RootPanel
..
Adding a DOM clear method to RootPanel
By calling rootPanel.clear(true) t
26 matches
Mail list logo
