[gwt-contrib] Re: Proposed API Addition - PopupPanel.get/setModal() and PopupPanel.get/setAutoHide()

2008-10-06 Thread Emily Crutcher
+1 to public boolean isAutoHideEnabled() public boolean isModal() Why do we want to change whether auto hide/modality is enabled on an existing popup panel? It seems like if we do this we would need to check for edge cases that currently don't come up. On Mon, Oct 6, 2008 at 12:09 PM, Alex Rudn

[gwt-contrib] Re: Proposed API Addition - PopupPanel.get/setModal() and PopupPanel.get/setAutoHide()

2008-10-06 Thread Emily Crutcher
The specific use case I was thinking of is related to an efficiency patch I was toying with that solves the occasionally-slow popup dragging case. However, Ray + Jason's use cases are much more compelling then mine anyway, especially since mine isn't implemented yet :-). On Mon, Oct 6, 2008 at

[gwt-contrib] Re: Proposed API Addition - PopupPanel.get/setModal() and PopupPanel.get/setAutoHide()

2008-10-06 Thread John LaBanca
@Emily - Looking at the code, I don't think there are any edge cases. We don't do any special setup/teardown if the bits are set, we just check them in onEventPreview. Also, I think its a valid use case to change them. For example, if somebody offers a user defined option to enable autoHide. T

[gwt-contrib] Re: Proposed API Addition - PopupPanel.get/setModal() and PopupPanel.get/setAutoHide()

2008-10-06 Thread Ray Ryan
+1 For one thing, it lets UI templates set their values without requiring custom parsers. Something like four different people have inspected the code for problems at this point and found none. rjrjr On Mon, Oct 6, 2008 at 12:44 PM, Emily Crutcher <[EMAIL PROTECTED]> wrote: > +1 to > public bool

[gwt-contrib] Re: Proposed API Addition - PopupPanel.get/setModal() and PopupPanel.get/setAutoHide()

2008-10-06 Thread Ray Ryan
John, when you do this it would be a good idea to add a test that toggles the bits a couple of times and sees that thing still works, so that we don't break it later. rjrjr On Mon, Oct 6, 2008 at 1:14 PM, Emily Crutcher <[EMAIL PROTECTED]> wrote: > This seems like a pretty persuasive use case. >

[gwt-contrib] Re: Proposed API Addition - PopupPanel.get/setModal() and PopupPanel.get/setAutoHide()

2008-10-06 Thread Emily Crutcher
This seems like a pretty persuasive use case. On Mon, Oct 6, 2008 at 12:47 PM, Ray Ryan <[EMAIL PROTECTED]> wrote: > +1 > > For one thing, it lets UI templates set their values without requiring > custom parsers. Something like four different people have inspected the code > for problems at this

[gwt-contrib] Re: Proposed API Addition - PopupPanel.get/setModal() and PopupPanel.get/setAutoHide()

2008-10-06 Thread Isaac Truett
My use case was re-purposing an existing PopupPanel. Sometimes I needed a modal, auto-hiding panel and other times I needed a non-modal, non-auto-hiding panel. There would only ever be one of these panels showing at any given time. It seemed most efficient in terms of Java code size, complexity, an

[gwt-contrib] Re: Proposed API Addition - PopupPanel.get/setModal() and PopupPanel.get/setAutoHide()

2008-10-06 Thread Jason Essington
@Emily In my case, I needed to create a modal non-autohiding DropDown Panel. however, the problem is that DropDown calls the PopupPanel constructor that creates a non-modal auto-hiding PopupPanel. Currently the only way to flip those bits subsequent to instantiation but prior to display is

[gwt-contrib] Re: Proposed API Addition - PopupPanel.get/setModal() and PopupPanel.get/setAutoHide()

2008-10-06 Thread Alex Rudnick
+1, sounds like a good idea. On Mon, Oct 6, 2008 at 11:54 AM, Jason Essington <[EMAIL PROTECTED]> wrote: > +1 here, as I've recently had to use the violator pattern to flip those > bits. > -jason -- Alex Rudnick swe, gwt, atl --~--~-~--~~~---~--~~ http://groups.

[gwt-contrib] Re: Proposed API Addition - PopupPanel.get/setModal() and PopupPanel.get/setAutoHide()

2008-10-06 Thread Isaac Truett
+1. I was looking for modal/autoHide accessors recently as well. At the time, I didn't see any reason they could/should not be implemented in PopupPanel. On Mon, Oct 6, 2008 at 11:54 AM, Jason Essington <[EMAIL PROTECTED]>wrote: > +1 here, as I've recently had to use the violator pattern to flip

[gwt-contrib] Re: Proposed API Addition - PopupPanel.get/setModal() and PopupPanel.get/setAutoHide()

2008-10-06 Thread Jason Essington
+1 here, as I've recently had to use the violator pattern to flip those bits. -jason On Oct 6, 2008, at 9:44 AM, John LaBanca wrote: > Contributors - > > I propose adding the following accessors and getters to PopupPanel: > public boolean isAutoHideEnabled() > public boolean isModal() > public