[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13654975#comment-13654975
]
Suresh Srinivas commented on HDFS-4352:
---
[~cutting] That seems reasonable and the rig
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13654872#comment-13654872
]
Doug Cutting commented on HDFS-4352:
Best practice is to let the committer who committe
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13653322#comment-13653322
]
Colin Patrick McCabe commented on HDFS-4352:
It seems like there is not a lot o
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13548575#comment-13548575
]
Tsz Wo (Nicholas), SZE commented on HDFS-4352:
--
> However, test-patch failed t
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13548492#comment-13548492
]
Hudson commented on HDFS-4352:
--
Integrated in Hadoop-Mapreduce-trunk #1308 (See
[https://buil
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13548476#comment-13548476
]
Hudson commented on HDFS-4352:
--
Integrated in Hadoop-Hdfs-trunk #1280 (See
[https://builds.ap
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13548369#comment-13548369
]
Hudson commented on HDFS-4352:
--
Integrated in Hadoop-Yarn-trunk #91 (See
[https://builds.apac
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547814#comment-13547814
]
Tsz Wo (Nicholas), SZE commented on HDFS-4352:
--
The reason of reverting HDFS-4
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547756#comment-13547756
]
Suresh Srinivas commented on HDFS-4352:
---
BTW, just a quick glance at the code, the ne
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547723#comment-13547723
]
Suresh Srinivas commented on HDFS-4352:
---
bq. That is inevitable when it comes to matt
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547703#comment-13547703
]
Colin Patrick McCabe commented on HDFS-4352:
Hi Suresh,
I understand that you
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547621#comment-13547621
]
Suresh Srinivas commented on HDFS-4352:
---
bq. We use the builder pattern in many other
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547613#comment-13547613
]
Todd Lipcon commented on HDFS-4352:
---
bq. I think Colin and I have discussed this issue fo
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547594#comment-13547594
]
Colin Patrick McCabe commented on HDFS-4352:
Although I don't feel strongly abo
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547581#comment-13547581
]
Tsz Wo (Nicholas), SZE commented on HDFS-4352:
--
> ... a wrapper for constructo
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547579#comment-13547579
]
Tsz Wo (Nicholas), SZE commented on HDFS-4352:
--
> By the way, I find it very r
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547578#comment-13547578
]
Todd Lipcon commented on HDFS-4352:
---
Yes, newBlockReader is essentially a wrapper for con
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547573#comment-13547573
]
Tsz Wo (Nicholas), SZE commented on HDFS-4352:
--
> I disagree that this "isn't
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547570#comment-13547570
]
Hudson commented on HDFS-4352:
--
Integrated in Hadoop-trunk-Commit #3198 (See
[https://builds.
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547568#comment-13547568
]
Todd Lipcon commented on HDFS-4352:
---
I disagree that this "isn't a good idea". Functions
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547529#comment-13547529
]
Tsz Wo (Nicholas), SZE commented on HDFS-4352:
--
> ... If not, we can revert t
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547460#comment-13547460
]
Suresh Srinivas commented on HDFS-4352:
---
Todd, can you please wait for +1 from jenkin
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546130#comment-13546130
]
Colin Patrick McCabe commented on HDFS-4352:
Hi Nicholas,
HDFS-4353 adds asser
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546016#comment-13546016
]
Tsz Wo (Nicholas), SZE commented on HDFS-4352:
--
The committed patch actually g
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13545582#comment-13545582
]
Tsz Wo (Nicholas), SZE commented on HDFS-4352:
--
> ... you just couldn't see it
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544347#comment-13544347
]
Colin Patrick McCabe commented on HDFS-4352:
oops... hit enter too early. To c
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544346#comment-13544346
]
Colin Patrick McCabe commented on HDFS-4352:
Hi Nicholas,
I added asserts to l
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544162#comment-13544162
]
Colin Patrick McCabe commented on HDFS-4352:
bq. I may miss something. This see
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543896#comment-13543896
]
Hudson commented on HDFS-4352:
--
Integrated in Hadoop-Mapreduce-trunk #1305 (See
[https://buil
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543852#comment-13543852
]
Hudson commented on HDFS-4352:
--
Integrated in Hadoop-Hdfs-trunk #1275 (See
[https://builds.ap
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543761#comment-13543761
]
Hudson commented on HDFS-4352:
--
Integrated in Hadoop-Yarn-trunk #86 (See
[https://builds.apac
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543752#comment-13543752
]
Tsz Wo (Nicholas), SZE commented on HDFS-4352:
--
I may miss something. This se
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543668#comment-13543668
]
Hudson commented on HDFS-4352:
--
Integrated in Hadoop-trunk-Commit #3173 (See
[https://builds.
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543646#comment-13543646
]
Todd Lipcon commented on HDFS-4352:
---
+1, will commit momentarily
> Encap
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543366#comment-13543366
]
Todd Lipcon commented on HDFS-4352:
---
{code}
+ public static class Params {
{code}
Need a
[
https://issues.apache.org/jira/browse/HDFS-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543279#comment-13543279
]
Hadoop QA commented on HDFS-4352:
-
{color:green}+1 overall{color}. Here are the results of
36 matches
Mail list logo
