[
https://issues.apache.org/jira/browse/HDFS-4243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4243:
Affects Version/s: 3.0.0
Status: Patch Available (was: Open)
[
https://issues.apache.org/jira/browse/HDFS-4243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508992#comment-13508992
]
Jing Zhao commented on HDFS-4243:
-
The INode#parent is mainly used by INode#getFullPathName
[
https://issues.apache.org/jira/browse/HDFS-4240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13508994#comment-13508994
]
Jing Zhao commented on HDFS-4240:
-
+1 for the new patch.
In
[
https://issues.apache.org/jira/browse/HDFS-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13511012#comment-13511012
]
Jing Zhao commented on HDFS-4273:
-
I do not think the DFSInputstream#read will be used
[
https://issues.apache.org/jira/browse/HDFS-4293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4293:
Attachment: HDFS-4293.001.patch
The test failure is because in the current copy constructor of
[
https://issues.apache.org/jira/browse/HDFS-4293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4293:
Attachment: HDFS-4293.002.patch
Thanks for the comments Suresh! The new patch addressed your comments.
[
https://issues.apache.org/jira/browse/HDFS-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13533299#comment-13533299
]
Jing Zhao commented on HDFS-3942:
-
Seems the test-patch in branch-1 has some problem with
[
https://issues.apache.org/jira/browse/HDFS-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4244:
Attachment: HDFS-4244.002.patch
Add the implementation and tests.
Support deleting
[
https://issues.apache.org/jira/browse/HDFS-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4230:
Attachment: HDFS-4230.002.patch
Listing all the current snapshottable directories
[
https://issues.apache.org/jira/browse/HDFS-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4244:
Attachment: HDFS-4244.003.patch
HDFS-4244.003.patch: update SnapshotManager#numSnapshots after deletion.
[
https://issues.apache.org/jira/browse/HDFS-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542499#comment-13542499
]
Jing Zhao commented on HDFS-4351:
-
bq. Regarding numOfReplicas, my reading is that it's the
[
https://issues.apache.org/jira/browse/HDFS-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542514#comment-13542514
]
Jing Zhao commented on HDFS-4351:
-
Thanks Andrew! +1 pending Jenkins.
Fix
[
https://issues.apache.org/jira/browse/HDFS-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4230:
Attachment: HDFS-4230.003.patch
Thanks for the comments Nicholas and Suresh!
A new patch is uploaded, in
Jing Zhao created HDFS-4357:
---
Summary: After calling replaceSelf, further operations that should
be processed on the new INode may be applied to the original INode
Key: HDFS-4357
URL:
[
https://issues.apache.org/jira/browse/HDFS-4357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4357:
Summary: After calling replaceSelf, further operations that should be
applied on the new INode may be
[
https://issues.apache.org/jira/browse/HDFS-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4244:
Attachment: HDFS-4244.004.patch
Thanks for the comments Aaron! The new patch addressed your comments 1, 2,
[
https://issues.apache.org/jira/browse/HDFS-4357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4357:
Attachment: HDFS-4357.001.patch
Upload the patch to fix. Also include a simple test case which will fail
[
https://issues.apache.org/jira/browse/HDFS-4357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4357:
Attachment: HDFS-4357.002.patch
Integrate new testcases that update metadata of directories into
[
https://issues.apache.org/jira/browse/HDFS-4357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4357:
Attachment: HDFS-4357.003.patch
Simplified code in the new patch.
After calling
Jing Zhao created HDFS-4361:
---
Summary: When listing snapshottable directories, only return those
where the user has permission to take snapshots
Key: HDFS-4361
URL: https://issues.apache.org/jira/browse/HDFS-4361
[
https://issues.apache.org/jira/browse/HDFS-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544092#comment-13544092
]
Jing Zhao commented on HDFS-4230:
-
bq. Sure, here or separate JIRA doesn't matter to me.
[
https://issues.apache.org/jira/browse/HDFS-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544147#comment-13544147
]
Jing Zhao commented on HDFS-4351:
-
I also run test-patch for Andrew, and the result looks
[
https://issues.apache.org/jira/browse/HDFS-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4230:
Attachment: HDFS-4230.004.patch
New patch uploaded which puts HdfsFileStatus as a field of
[
https://issues.apache.org/jira/browse/HDFS-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4244:
Attachment: HDFS-4244.005.patch
Update the patch: change the type of snapshotDir from String to Path in
[
https://issues.apache.org/jira/browse/HDFS-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4244:
Attachment: HDFS-4244.006.patch
Thanks for the comments Nicholas! Upload the new patch to address all the
[
https://issues.apache.org/jira/browse/HDFS-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13547111#comment-13547111
]
Jing Zhao commented on HDFS-4350:
-
bq. Config strings are still unfortunately hardcoded in
[
https://issues.apache.org/jira/browse/HDFS-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4244:
Attachment: HDFS-4244.007.patch
Update the patch addressing Nicholas's comments. Also add a testcase in
Jing Zhao created HDFS-4381:
---
Summary: Add javadoc for FSImageFormat with description about the
FSImage format with/without localNameINodes
Key: HDFS-4381
URL: https://issues.apache.org/jira/browse/HDFS-4381
[
https://issues.apache.org/jira/browse/HDFS-4381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4381:
Attachment: HDFS-4381.001.patch
Add javadoc for FSImageFormat with description about the FSImage
[
https://issues.apache.org/jira/browse/HDFS-4381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4381:
Status: Patch Available (was: Open)
Add javadoc for FSImageFormat with description about the FSImage
[
https://issues.apache.org/jira/browse/HDFS-4381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4381:
Attachment: HDFS-4381.002.patch
Update the patch to make it compact.
Add javadoc for
[
https://issues.apache.org/jira/browse/HDFS-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4245:
Attachment: editsStored
HDFS-4245.002.patch
Update the patch.
Include
[
https://issues.apache.org/jira/browse/HDFS-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4126:
Attachment: HDFS-4126.001.patch
Initial patch. Also integrate the fsimage saving/loading into
Jing Zhao created HDFS-4395:
---
Summary: INodeDirectorySnapshottable's constructor should take
into account the scenario when passed-in dir is of the type
INodeDirectoryWithSnapshot
Key: HDFS-4395
URL:
[
https://issues.apache.org/jira/browse/HDFS-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552410#comment-13552410
]
Jing Zhao commented on HDFS-4126:
-
With HDFS-4395 all the test can passed. Will update the
[
https://issues.apache.org/jira/browse/HDFS-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4395:
Attachment: HDFS-4395.001.patch
A simple patch is uploaded. This can fix the bug that the diff list may be
[
https://issues.apache.org/jira/browse/HDFS-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552494#comment-13552494
]
Jing Zhao commented on HDFS-4395:
-
Thanks for the comments Nicholas! The new test in
[
https://issues.apache.org/jira/browse/HDFS-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13553015#comment-13553015
]
Jing Zhao commented on HDFS-4098:
-
Seems 4098 does not compile with javac in some JVM
[
https://issues.apache.org/jira/browse/HDFS-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4098:
Attachment: HDFS-4098.compile.patch
The patch HDFS-4098.compile.patch can pass the compiling, but is not
[
https://issues.apache.org/jira/browse/HDFS-4397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13553134#comment-13553134
]
Jing Zhao commented on HDFS-4397:
-
Seems
{noformat}
+ final TripleInteger, INode,
[
https://issues.apache.org/jira/browse/HDFS-4397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13553149#comment-13553149
]
Jing Zhao commented on HDFS-4397:
-
Besides, I think the bug in the original code is that
[
https://issues.apache.org/jira/browse/HDFS-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4126:
Attachment: HDFS-4126.002.patch
Update the patch. With HDFS-4098 the original circular linked list may be
[
https://issues.apache.org/jira/browse/HDFS-4397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13553537#comment-13553537
]
Jing Zhao commented on HDFS-4397:
-
+1 for the patch.
Combined diff may
[
https://issues.apache.org/jira/browse/HDFS-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4144:
Attachment: HDFS-4144.002.patch
Update the patch to cover all the existing metrics about snapshot.
[
https://issues.apache.org/jira/browse/HDFS-4407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554782#comment-13554782
]
Jing Zhao commented on HDFS-4407:
-
The patch looks good. It also passed all the
[
https://issues.apache.org/jira/browse/HDFS-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4131:
Attachment: HDFS-4131.001.patch
Initial patch that only covers the diff computation in NN. A simple
Jing Zhao created HDFS-4414:
---
Summary: Create a DiffReport class to represent the diff between
snapshots to end users
Key: HDFS-4414
URL: https://issues.apache.org/jira/browse/HDFS-4414
Project: Hadoop
[
https://issues.apache.org/jira/browse/HDFS-4414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4414:
Attachment: HDFS-4414.001.patch
Initial patch generated based on the diff with HDFS-4131.
[
https://issues.apache.org/jira/browse/HDFS-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555937#comment-13555937
]
Jing Zhao commented on HDFS-4098:
-
The new patch looks good, and passed all the test on my
[
https://issues.apache.org/jira/browse/HDFS-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13556448#comment-13556448
]
Jing Zhao commented on HDFS-4098:
-
+1 for the new patch.
Support append
[
https://issues.apache.org/jira/browse/HDFS-4414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4414:
Attachment: HDFS-4414+4131.002.patch
HDFS-4414+4131.002.patch:
1. update the patch for recent changes in
[
https://issues.apache.org/jira/browse/HDFS-4414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13556871#comment-13556871
]
Jing Zhao commented on HDFS-4414:
-
Will split the new patch and update HDFS-4131
[
https://issues.apache.org/jira/browse/HDFS-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4126:
Attachment: HDFS-4126.002.patch
Rebase the patch. The currently patch does not support
[
https://issues.apache.org/jira/browse/HDFS-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4131:
Attachment: HDFS-4131.002.patch
Update the patch based on HDFS-4414+4131.002.patch in HDFS-4414: fix the
[
https://issues.apache.org/jira/browse/HDFS-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao reassigned HDFS-4131:
---
Assignee: Jing Zhao (was: Suresh Srinivas)
Add a tool to print the diff between two snapshots
[
https://issues.apache.org/jira/browse/HDFS-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4126:
Attachment: HDFS-4126.003.patch
Thanks for the comments Suresh! Update the patch to address your comments.
[
https://issues.apache.org/jira/browse/HDFS-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13560077#comment-13560077
]
Jing Zhao commented on HDFS-4126:
-
bq. Snapshot in javadoc is missing snapshot name?
The
Jing Zhao created HDFS-4429:
---
Summary: Add unit tests for taking snapshots while file appending
Key: HDFS-4429
URL: https://issues.apache.org/jira/browse/HDFS-4429
Project: Hadoop HDFS
Issue Type:
[
https://issues.apache.org/jira/browse/HDFS-4429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4429:
Attachment: HDFS-4429.000.patch
Initial patch. Part of the change has been included in HDFS-4126. Will
[
https://issues.apache.org/jira/browse/HDFS-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13560332#comment-13560332
]
Jing Zhao commented on HDFS-4350:
-
The patch also looks good to me. One minor issue: the
[
https://issues.apache.org/jira/browse/HDFS-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4131:
Attachment: HDFS-4131.003.patch
Rebase the patch.
Add a tool to print the diff between
[
https://issues.apache.org/jira/browse/HDFS-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13560351#comment-13560351
]
Jing Zhao commented on HDFS-4131:
-
The diff printout from the new testcase
[
https://issues.apache.org/jira/browse/HDFS-4429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4429:
Attachment: HDFS-4429.001.patch
Update the patch:
1. Rebase the patch based on HDFS-4126,
2. In
Jing Zhao created HDFS-4431:
---
Summary: Support snapshot in OfflineImageViewer
Key: HDFS-4431
URL: https://issues.apache.org/jira/browse/HDFS-4431
Project: Hadoop HDFS
Issue Type: Sub-task
Jing Zhao created HDFS-4432:
---
Summary: Support INodeFileUnderConstructionWithSnapshot in FSImage
saving/loading
Key: HDFS-4432
URL: https://issues.apache.org/jira/browse/HDFS-4432
Project: Hadoop HDFS
[
https://issues.apache.org/jira/browse/HDFS-4429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4429:
Attachment: HDFS-4429.002.patch
Add unit tests for taking snapshots while file appending
[
https://issues.apache.org/jira/browse/HDFS-4339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561306#comment-13561306
]
Jing Zhao commented on HDFS-4339:
-
The patch looks good to me. I ran the failed test
[
https://issues.apache.org/jira/browse/HDFS-4429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4429:
Attachment: HDFS-4429.003.patch
Update the patch: in TestSnapshot#testSnapshot, dump the dir tree into
[
https://issues.apache.org/jira/browse/HDFS-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561860#comment-13561860
]
Jing Zhao commented on HDFS-4131:
-
Thanks for the comment Daryn! The above printout is just
[
https://issues.apache.org/jira/browse/HDFS-4436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561976#comment-13561976
]
Jing Zhao commented on HDFS-4436:
-
Seems the INodeDirectoryWithSnapshot#removeChild still
[
https://issues.apache.org/jira/browse/HDFS-4436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561999#comment-13561999
]
Jing Zhao commented on HDFS-4436:
-
+1 for the new patch.
The snapshot
[
https://issues.apache.org/jira/browse/HDFS-4429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4429:
Attachment: HDFS-4429.004.patch
Update the patch based on recent change in HDFS-4436.
Add
[
https://issues.apache.org/jira/browse/HDFS-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13562932#comment-13562932
]
Jing Zhao commented on HDFS-4441:
-
The patch looks good to me. Only some minor issues:
1.
[
https://issues.apache.org/jira/browse/HDFS-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13563182#comment-13563182
]
Jing Zhao commented on HDFS-4441:
-
+1 for the patch.
Refactor
[
https://issues.apache.org/jira/browse/HDFS-4432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4432:
Attachment: HDFS-4432.001.patch
Update the patch.
Support
[
https://issues.apache.org/jira/browse/HDFS-4432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4432:
Attachment: HDFS-4432.002.patch
Update the javadoc of FSImageFormat.
Support
[
https://issues.apache.org/jira/browse/HDFS-4432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4432:
Attachment: HDFS-4432.003.patch
Thanks for the comments Suresh! The new patch addressed your comments.
[
https://issues.apache.org/jira/browse/HDFS-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4131:
Attachment: HDFS-4131.004.patch
Rebase the patch.
Add a tool to print the diff between
[
https://issues.apache.org/jira/browse/HDFS-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4131:
Description: This jira provides internal data structures and computation
processes for calculating the diff
[
https://issues.apache.org/jira/browse/HDFS-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4131:
Description: This jira provides internal data structures and computation
processes for calculating and
[
https://issues.apache.org/jira/browse/HDFS-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4131:
Attachment: HDFS-4131.005.patch
Update the patch. Do not distinguish earlier/later snapshots in
[
https://issues.apache.org/jira/browse/HDFS-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13565793#comment-13565793
]
Jing Zhao commented on HDFS-4447:
-
The patch looks good to me. Some minors:
1. javadoc for
[
https://issues.apache.org/jira/browse/HDFS-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4131:
Attachment: HDFS-4131.006.patch
Update the patch based on Suresh's comments.
Add a tool
[
https://issues.apache.org/jira/browse/HDFS-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4131:
Description:
This jira provides internal data structures and computation processes for
calculating and
[
https://issues.apache.org/jira/browse/HDFS-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4131:
Description:
This jira provides internal data structures and computation processes for
calculating and
[
https://issues.apache.org/jira/browse/HDFS-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4131:
Description:
This jira provides internal data structures and computation processes for
calculating and
[
https://issues.apache.org/jira/browse/HDFS-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13565945#comment-13565945
]
Jing Zhao commented on HDFS-4447:
-
+1 for the patch.
Refactor
[
https://issues.apache.org/jira/browse/HDFS-4339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566048#comment-13566048
]
Jing Zhao commented on HDFS-4339:
-
The new patch looks good. A few more comments:
1. We may
[
https://issues.apache.org/jira/browse/HDFS-4414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4414:
Attachment: HDFS-4414.003.patch
Update the patch based on changes in HDFS-4131. Will add more test later.
[
https://issues.apache.org/jira/browse/HDFS-4414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4414:
Attachment: HDFS-4414.004.patch
Update the patch with new testcases to cover different sequence of from/to
[
https://issues.apache.org/jira/browse/HDFS-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4361:
Attachment: HDFS-4361.001.patch
Add owner check for snapshottable directory list. Also add a corresponding
[
https://issues.apache.org/jira/browse/HDFS-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13567219#comment-13567219
]
Jing Zhao commented on HDFS-4350:
-
The branch-1 patch looks good to me. One minor issue:
[
https://issues.apache.org/jira/browse/HDFS-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4361:
Attachment: HDFS-4361.002.patch
Update the testcase in the patch: instead of disabling the permission check
[
https://issues.apache.org/jira/browse/HDFS-4189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568056#comment-13568056
]
Jing Zhao commented on HDFS-4189:
-
+1 for the patch. Only a very minor issue:
[
https://issues.apache.org/jira/browse/HDFS-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4361:
Attachment: HDFS-4361.003.patch
Update the patch to address Nicholas's comments.
When
[
https://issues.apache.org/jira/browse/HDFS-4189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568102#comment-13568102
]
Jing Zhao commented on HDFS-4189:
-
+1 for the new patch.
rename getter
[
https://issues.apache.org/jira/browse/HDFS-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4361:
Attachment: HDFS-4361.004.patch
When listing snapshottable directories, only return those where the
[
https://issues.apache.org/jira/browse/HDFS-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13569326#comment-13569326
]
Jing Zhao commented on HDFS-4464:
-
The name of deleteSubtreeAndCollectBlocks may be a
[
https://issues.apache.org/jira/browse/HDFS-4414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-4414:
Attachment: HDFS-4414.005.patch
Thanks for the comments Suresh! Upload the new patch. Will create jiras to
[
https://issues.apache.org/jira/browse/HDFS-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13574026#comment-13574026
]
Jing Zhao commented on HDFS-4446:
-
The patch looks good and with the file diff we can
901 - 1000 of 4287 matches
Mail list logo
