[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12917677#action_12917677 ] Namit Jain commented on HIVE-1546: -- I will take a look in more detail, but overall it looks

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12917851#action_12917851 ] Ashutosh Chauhan commented on HIVE-1546: I did it in junit form because John

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12916756#action_12916756 ] John Sichi commented on HIVE-1546: -- Great. I'm actually out on vacation until the end of

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12916758#action_12916758 ] Ashutosh Chauhan commented on HIVE-1546: Hey Namit, Would you like to review it?

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12909799#action_12909799 ] Ashutosh Chauhan commented on HIVE-1546: @John, I took a look at the proposed new

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12909822#action_12909822 ] John Sichi commented on HIVE-1546: -- For the Hive part, it will be good if you can keep the

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12909318#action_12909318 ] Ashutosh Chauhan commented on HIVE-1546: @Namit, Continuing from discussion

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12909432#action_12909432 ] John Sichi commented on HIVE-1546: -- @Ashutosh: I will get back to you soon with a

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12909549#action_12909549 ] John Sichi commented on HIVE-1546: -- I think we can start off with this interface:

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12906041#action_12906041 ] John Sichi commented on HIVE-1546: -- @Namit: the option of putting Howl directly into Hive

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12905640#action_12905640 ] Ashutosh Chauhan commented on HIVE-1546: @Carl, * Ya, the main motivating use case

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12905655#action_12905655 ] John Sichi commented on HIVE-1546: -- @Carl: I understand your concern, but this seemed like

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12905656#action_12905656 ] John Sichi commented on HIVE-1546: -- For the last sentence, I meant If Howl's CLI customized

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12905686#action_12905686 ] Carl Steinbach commented on HIVE-1546: -- bq. we've agreed at the high level on the

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12905687#action_12905687 ] John Sichi commented on HIVE-1546: -- It's the usual tradeoffs on copy-and-paste vs

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12905692#action_12905692 ] Carl Steinbach commented on HIVE-1546: -- What do you think of this option: we check the

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12905706#action_12905706 ] John Sichi commented on HIVE-1546: -- That's fine with me if it doesn't drag in unrelated

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12905707#action_12905707 ] Carl Steinbach commented on HIVE-1546: -- I'm +1 on the approach outlined by John.

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12905711#action_12905711 ] Alan Gates commented on HIVE-1546: -- Using the definitions given in HADOOP-5073, can we call

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12905752#action_12905752 ] Namit Jain commented on HIVE-1546: -- Would it be possible to do it via a hook ? Do you want

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12905757#action_12905757 ] Carl Steinbach commented on HIVE-1546: -- I gather from Ashutosh's latest patch that you

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12905767#action_12905767 ] Namit Jain commented on HIVE-1546: -- Sorry on jumping on this late. I quickly reviewed

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12905353#action_12905353 ] Ashutosh Chauhan commented on HIVE-1546: It is the new test that I wrote for this

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12905390#action_12905390 ] Carl Steinbach commented on HIVE-1546: -- @Ashutosh: Can you provide some background on

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12905406#action_12905406 ] Carl Steinbach commented on HIVE-1546: -- If the main motivation for this ticket is the

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12905410#action_12905410 ] John Sichi commented on HIVE-1546: -- Hi Carl, As mentioned above, this patch originated

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12905411#action_12905411 ] Carl Steinbach commented on HIVE-1546: -- @ John: Good to know, but what's the motivation

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12904834#action_12904834 ] John Sichi commented on HIVE-1546: -- +1. Will commit when tests pass. Ability to plug

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12904397#action_12904397 ] HBase Review Board commented on HIVE-1546: -- Message from: Carl Steinbach

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12903660#action_12903660 ] Ashutosh Chauhan commented on HIVE-1546: bq. What I was thinking in my previous

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12903738#action_12903738 ] John Sichi commented on HIVE-1546: -- Yes, that is what I was envisioning. I think the

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12903746#action_12903746 ] John Sichi commented on HIVE-1546: -- More specifically, for the last suggestion, where we

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12903035#action_12903035 ] John Sichi commented on HIVE-1546: -- Thanks, I took a look. But factory producing factory

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12901641#action_12901641 ] John Sichi commented on HIVE-1546: -- I have published some review comments here:

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12901646#action_12901646 ] HBase Review Board commented on HIVE-1546: -- Message from: John Sichi

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12901654#action_12901654 ] HBase Review Board commented on HIVE-1546: -- Message from: John Sichi

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12900428#action_12900428 ] John Sichi commented on HIVE-1546: -- Thanks Ashutosh, I've reassigned this one to you and

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12900137#action_12900137 ] Ashutosh Chauhan commented on HIVE-1546: Btw, can someone assign this jira to me and

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12899204#action_12899204 ] Ashutosh Chauhan commented on HIVE-1546: This will involve a bit of refactoring and

[jira] Commented: (HIVE-1546) Ability to plug custom Semantic Analyzers for Hive Grammar

[ https://issues.apache.org/jira/browse/HIVE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12899206#action_12899206 ] John Sichi commented on HIVE-1546: -- (Note for other Hive committers: this JIRA originated