Hi Yuv,
> > I thinks, that no good idea. The first approach should work better.
>
> OK, will do the first approach. Is it OK if I commit it?
It's ok.
Thomas
--
You received this message because you are subscribed to the Google Groups
"Hugin and other free panoramic software" group.
A list o
Am Freitag, 24. September 2010 schrieb Yuval Levy:
> On September 24, 2010 02:28:15 am Kornel Benko wrote:
> > I like this idea. Something numbered, so one could remember the history
> > number.
>
> I doubt most users are as diligent as you, Kornel. I for instance would not
> be able to remember
On September 24, 2010 02:28:15 am Kornel Benko wrote:
> I like this idea. Something numbered, so one could remember the history
> number.
I doubt most users are as diligent as you, Kornel. I for instance would not
be able to remember the history number, but I like to read something
descriptive
On September 24, 2010 01:48:55 am T. Modes wrote:
> I thinks, that no good idea. The first approach should work better.
OK, will do the first approach. Is it OK if I commit it?
Yuv
signature.asc
Description: This is a digitally signed message part.
Am Freitag, 24. September 2010 schrieb Yuval Levy:
...
> I have also thought of listing history steps (like
> in a browser's back button), but for this the descriptions in PanoCommand
> need
> to be cleaned up (I already cleand a bit), and some more detail about the
> specific action need to b
Hi Yuv,
> > First, it does not work correctly if you undo/redo a command which
> > changes the number or order of the images (add/remove image, swap
> > images and so on). In this case you switch the active state of not
> > affected images.
>
> Yes. I find this to be a "cosmetic" issue. I might
On September 22, 2010 01:46:17 pm Bart van Andel wrote:
> A more complicated version could auto-undo when you first hide a
> picture and then immediately show it again, without doing anything in
> between. Or even group all successive hide/show actions and remove
> combined hide/show actions (as ne
Hi Thomas,
On September 22, 2010 01:55:55 pm T. Modes wrote:
> Please don't at the current status.
OK, will think of something so that it won't interfere.
> First, it does not work correctly if you undo/redo a command which
> changes the number or order of the images (add/remove image, swap
> i
Hi Yuv,
> Attached is the fixed patch. If there are no further bug reports I'll commit
> it soon.
>
Please don't at the current status. There are two points, which you
don't considered:
First, it does not work correctly if you undo/redo a command which
changes the number or order of the images (
On 22 sep, 19:02, Yuval Levy wrote:
> On September 22, 2010 05:43:19 am Bart van Andel wrote:
>
> > I just read your patch, to see if I could spot a bug
>
> Thank you, Bart! You spotted right. With your fix it no longer segfaults on
> my tests.
Ok great! Exercise completed successfully :-)
I l
On September 22, 2010 05:43:19 am Bart van Andel wrote:
> I just read your patch, to see if I could spot a bug
Thank you, Bart! You spotted right. With your fix it no longer segfaults on
my tests.
Attached is the fixed patch. If there are no further bug reports I'll commit
it soon.
Yuv
diff
I just read your patch, to see if I could spot a bug (without
compiling, as an exercise), and I think I've found one. Can't compile
it myself now because I haven't currently set up a building
environment, but here goes:
Line 175 currently reads:
+while ( (commands[nextCmd]->getName()=="cha
12 matches
Mail list logo
