On Tue, 19 Apr 2016 08:05:26 +0200
Maarten Lankhorst wrote:
> Op 18-04-16 om 18:47 schreef Bob Paauwe:
> > The i915 driver is now using atomic properties and atomic commit
> > to handle the legacy set gamma IOCTL. However, if the driver is
> > configured without atomic (nuc
"panel", GPIOD_OUT_HIGH);
>
It makes sense to restrict this as it isn't valid for other platforms
as written. But is there something similar for other platforms that we
should set up here?
Since it makes sense to limit this today..
Reviewed-by: Bob Paauwe
--
--
B
On Wed, 8 Feb 2017 16:20:54 +0530
Vidya Srinivas wrote:
> From: Uma Shankar
>
> Fix the Sequence to program BXT DSI Latch and ULPS.
>
> Signed-off-by: Uma Shankar
> Signed-off-by: Vidya Srinivas
Reviewed-by: Bob Paauwe
> ---
> drivers/gpu/d
drm_panel_power_off(intel_dsi->panel);
This depends on the previous patch, which I don't think is the
direction we want to go. If the code is reworked to not use the
drm_panel interface, then this would need to change also.
> msleep(i
On Wed, 8 Feb 2017 16:20:56 +0530
Vidya Srinivas wrote:
> From: Uma Shankar
>
> Disable device ready before MIPI port shutdown command.
> This helps to avoid mipi split screen issues.
>
> Signed-off-by: Uma Shankar
> Signed-off-by: Vidya Srinivas
Reviewed-by: Bob Paau
On Wed, 8 Feb 2017 16:20:57 +0530
Vidya Srinivas wrote:
> From: Uma Shankar
>
> Enable support for BXT DSI dual link mode.
>
> Signed-off-by: Uma Shankar
> Signed-off-by: Vidya Srinivas
Reviewed-by: Bob Paauwe
> ---
> drivers/gpu/drm/i915/i915_reg.h | 5 +
o expand
the use of the drm_panel interfaces but instead move to an i915 only
panel interface. This would allow us to have more granular control
over the sequences.
But since this is actually adding new drm_panel interfaces,
Acknowledged-by: Bob Paauwe
> ---
> drivers/gpu/drm/i915/i
gt; return 0;
> @@ -550,6 +547,7 @@ static int vbt_panel_get_modes(struct drm_panel *panel)
> static int vbt_panel_power_on(struct drm_panel *panel)
> {
> generic_exec_sequence(panel, MIPI_SEQ_POWER_ON);
> + generic_exec_sequence(panel, MIPI_SEQ_ASSERT_RESET);
> retur
FIFO status into one function. But that's probably a separate patch.
I like what this is doing.
Reviewed-by: Bob Paauwe
> +void wait_for_dsi_fifo_empty(struct intel_dsi *intel_dsi, enum port port)
> {
> struct drm_encoder *encoder = &intel_dsi->base.base;
>
isable paths. No functional changes.
>
> Signed-off-by: Hans de Goede
> Acked-by: Jani Nikula
Reviewed-by: Bob Paauwe
> ---
> drivers/gpu/drm/i915/intel_dsi.c | 37 -
> 1 file changed, 24 insertions(+), 13 deletions(-)
>
> diff --gi
tel_dsi = enc_to_intel_dsi(&encoder->base);
> - enum port port;
> - u32 temp;
> -
> - DRM_DEBUG_KMS("\n");
> -
> - if (is_vid_mode(intel_dsi)) {
> - for_each_dsi_port(port, intel_dsi->ports)
> -
tting in the middle of them.
>
> This commit purely moves code around, it does not make any
> changes what-so-ever.
>
> Signed-off-by: Hans de Goede
> Acked-by: Jani Nikula
Reviewed-by: Bob Paauwe
> ---
> drivers/gpu/drm/i915/intel_dsi.c | 86
> ---
anel _enable/disable and prepare/unprepare callbacks and instead
> export intel_dsi_exec_vbt_sequence() from intel_dsi_panel_vbt.c
> and call that from intel_dsi_enable/disable().
>
> No functional changes.
>
> Signed-off-by: Hans de Goede
Reviewed-by: Bob Paauwe
> ---
&g
nts are necessary. Maybe if there was
some explanation for why we're using two different mechanisms to
enable/disable backlight instead.
Reviewed-by: Bob Paauwe
> ---
> drivers/gpu/drm/i915/intel_dsi.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --g
> if (IS_BROXTON(dev_priv)) {
> @@ -785,6 +789,7 @@ static void intel_dsi_post_disable(struct intel_encoder
> *encoder,
> I915_WRITE(DSPCLK_GATE_D, val);
> }
>
> + /* Assert reset */
Again, the comment doesn't provide any additional info.
But the rest looks
nable
>
> Signed-off-by: Hans de Goede
Makes sense and looks better too.
Reviewed-by: Bob Paauwe
> ---
> drivers/gpu/drm/i915/intel_dsi.c | 16
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dsi.c
> b/
On Mon, 20 Feb 2017 15:08:38 +0100
Hans de Goede wrote:
> Now that we are no longer bound to the drm_panel_ callbacks, call
> MIPI_SEQ_POWER_ON/OFF at the proper place.
>
> Signed-off-by: Hans de Goede
Reviewed-by: Bob Paauwe
> ---
> drivers/gpu/drm/i915/intel_dsi.c |
lp-00
> + * - MIPIAssertResetPin
> + * - wait t3
> + * - power off
> + * - wait t4
> + */
> +
> static void intel_dsi_pre_enable(struct intel_encoder *encoder,
>struct intel_crtc_state *pipe_config,
>struct drm_co
EQ_POWER_ON);
> intel_dsi_exec_vbt_sequence(intel_dsi, MIPI_SEQ_DEASSERT_RESET);
> intel_dsi_exec_vbt_sequence(intel_dsi, MIPI_SEQ_INIT_OTP);
--
--
Bob Paauwe
bob.j.paa...@intel.com
IOTG / PED Software Organization
Intel Corp. Folsom, CA
(916) 356-
tdown packet then in
>* some next enable sequence send turn on packet error is observed
> + * XXX spec specifies SHUTDOWN before MIPI_SEQ_DISPLAY_OFF for
> + * v3 VBTs, but not for v2 VBTs?
>*/
> intel_dsi_exec_vbt_sequence(intel_dsi, MIPI_SEQ_DISPLAY_OF
I_SEQ_TEAR_OFF);
> intel_dsi_exec_vbt_sequence(intel_dsi, MIPI_SEQ_DISPLAY_OFF);
>
> /* Transition to LP-00 */
--
--
Bob Paauwe
bob.j.paa...@intel.com
IOTG / PED Software Organization
Intel Corp. Folsom, CA
(916) 356-6193
_
PI_SEQ_DISPLAY_ON);
> } else {
> msleep(20); /* XXX */
> for_each_dsi_port(port, intel_dsi->ports)
--
--
Bob Paauwe
bob.j.paa...@intel.com
IOTG / PED Software Organization
Intel Corp. Folsom, CA
(916) 356-6193
_
uence(intel_dsi, MIPI_SEQ_POWER_OFF);
> if (intel_dsi->gpio_panel)
> gpiod_set_value_cansleep(intel_dsi->gpio_panel, 0);
> @@ -814,7 +825,7 @@ static void intel_dsi_post_disable(struct intel_encoder
> *encoder,
>* FIXME As we do wi
On Sat, 25 Feb 2017 11:35:03 +0100
Hans de Goede wrote:
> Hi,
>
> On 24-02-17 18:00, Bob Paauwe wrote:
> > On Mon, 20 Feb 2017 15:08:37 +0100
> > Hans de Goede wrote:
> >
> >> MIPI_SEQ_ASSERT_RESET before POWER_ON is not necessary for 2 reasons:
> >
On Sat, 25 Feb 2017 11:37:50 +0100
Hans de Goede wrote:
> Hi,
>
> On 24-02-17 18:00, Bob Paauwe wrote:
> > On Mon, 20 Feb 2017 15:08:41 +0100
> > Hans de Goede wrote:
> >
> >> Execute the MIPI_SEQ_BACKLIGHT_ON/OFF VBT sequences at the same time as
>
On Sat, 25 Feb 2017 11:42:09 +0100
Hans de Goede wrote:
> Hi,
>
> On 24-02-17 18:02, Bob Paauwe wrote:
> > On Mon, 20 Feb 2017 15:08:42 +0100
> > Hans de Goede wrote:
> >
> >> According to the spec for v2 VBTs we should call MIPI_SEQ_DISPLAY_OFF
> >
On Sat, 25 Feb 2017 11:49:09 +0100
Hans de Goede wrote:
> HI,
>
> On 24-02-17 18:02, Bob Paauwe wrote:
> > On Mon, 20 Feb 2017 15:08:45 +0100
> > Hans de Goede wrote:
> >
> >> For v3 VBTs in vid-mode the delays are part of the VBT sequences, so
>
On Sat, 25 Feb 2017 11:47:32 +0100
Hans de Goede wrote:
> Hi,
>
> On 24-02-17 18:02, Bob Paauwe wrote:
> > On Mon, 20 Feb 2017 15:08:44 +0100
> > Hans de Goede wrote:
> >
> >> According to the spec we should call MIPI_SEQ_TEAR_ON and DISPLAY_ON
>
ug.cgi?id=97061
> Signed-off-by: Hans de Goede
Reviewed-by: Bob Paauwe
> ---
> drivers/gpu/drm/i915/intel_dsi.c | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dsi.c
> b/drivers/gpu/drm/i915/intel_dsi.c
> index
gamma and csc enable bits which default to off. If those are
flipped on, then the CRC's match between a disabled plane and a black
plane.
So it seems to make CRC's match we need to make sure that all planes
(primary/sprite/cursor/bottom) have the same gamma/csc settings.
Chandra had a p
how_bug.cgi?id=89331
> Testcase: igt/kms_universal_plane/universal-plane-pipe-A-functional
> Signed-off-by: Kevin Strasser
Reviewed-by: Bob Paauwe
> ---
> drivers/gpu/drm/i915/intel_display.c | 16 ++--
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/drive
On Mon, 19 Oct 2015 10:13:58 -0700
Kevin Strasser wrote:
> On Mon, Oct 19, 2015 at 12:15:41PM +0200, Daniel Vetter wrote:
> > On Fri, Oct 16, 2015 at 03:53:22PM -0700, Bob Paauwe wrote:
> > > On Thu, 15 Oct 2015 15:41:30 +0300
> > > Ville Syrjälä wrote:
> > >
also gamma/csc corrected, then the disiabled case will match the
black plane case.
testcase: igt/kms_universal_plane/universal-plane-pipe-[ABC]-functional
CC: Konduru, Chandra
cc: Kevin Strasser
Signed-off-by: Bob Paauwe
---
drivers/gpu/drm/i915/i915_reg.h | 10 ++
drivers/gpu/drm
On Tue, 20 Oct 2015 19:13:19 +0300
Ville Syrjälä wrote:
> On Tue, Oct 20, 2015 at 08:48:36AM -0700, Bob Paauwe wrote:
> > On Mon, 19 Oct 2015 10:13:58 -0700
> > Kevin Strasser wrote:
> >
> > > On Mon, Oct 19, 2015 at 12:15:41PM +0200, Daniel Vetter wrote:
> &g
C: Konduru, Chandra
cc: Kevin Strasser
Signed-off-by: Bob Paauwe
---
drivers/gpu/drm/i915/i915_reg.h | 10 ++
drivers/gpu/drm/i915/intel_display.c | 6 ++
2 files changed, 16 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
ind
return ret;
> }
>
> - if (!HAS_PCH_SPLIT(dev))
> + if (HAS_GMCH_DISPLAY(dev))
> intel_gmch_panel_fitting(intel_crtc, pipe_config,
>
> intel_connector->panel.f
that're running on BXT
> where it should have been on anyway.
>
> Cc: Imre Deak
> Cc: Bob Paauwe
> Signed-off-by: Matt Roper
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 13 +
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/gpu/dr
Signed-off-by: Bob Paauwe
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92768
---
drivers/gpu/drm/i915/intel_pm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 647c0ff..fc5097f 100644
--- a
On Tue, 10 Nov 2015 11:04:22 +0200
Mika Kuoppala wrote:
> Bob Paauwe writes:
>
> > Signed-off-by: Bob Paauwe
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92768
> > ---
> > drivers/gpu/drm/i915/intel_pm.c | 4 ++--
> > 1 file changed, 2 insert
frequency. Update the pm_rps tests to reflect that
this is no longer considered a failure.
Signed-off-by: Bob Paauwe
---
tests/pm_rps.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/tests/pm_rps.c b/tests/pm_rps.c
index 74f08f4..e92ca3b 100644
--- a/tests/pm_rps.c
+++ b
On Thu, 12 Nov 2015 10:35:00 +0200
Imre Deak wrote:
> On Wed, 2015-11-11 at 13:36 -0800, Bob Paauwe wrote:
> > On Tue, 10 Nov 2015 11:04:22 +0200
> > Mika Kuoppala wrote:
> >
> > > Bob Paauwe writes:
> > >
> > > > Signed-off-by: Bob Paa
On Thu, 12 Nov 2015 11:18:11 +0200
Imre Deak wrote:
> On ke, 2015-11-11 at 13:37 -0800, Bob Paauwe wrote:
> > Since commit
> >
> > commit aed242ff7ebb697e4dff912bd4dc7ec7192f7581
> > Author: Chris Wilson
> > Date: Wed Mar 18 09:48:21 2015 +
&
-ratio-freq conversions.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92768
> Testcase: igt/pm_rps/basic-api
> Tested-by: Bob Paauwe
> Cc: Bob Paauwe
> Signed-off-by: Imre Deak
> Signed-off-by: Mika Kuoppala
> ---
> drivers/gpu/drm/i915/intel_pm.c | 8 +---
> 1
device *dev,
> + int flags, const char *name);
> struct drm_property_blob *drm_property_create_blob(struct drm_device *dev,
> size_t length,
> const void *data);
> @@ -1495,
raction. What if black really needed
to have alpha set or drm_rgba_t expands to more than 16 bits per color
or we just want to initialize the background color to something other
than black?
> +}
> +
> static void intel_crtc_init(struct drm_device *dev, int pipe)
> {
> struct d
t a/drivers/gpu/drm/i915/intel_sprite.c
> b/drivers/gpu/drm/i915/intel_sprite.c
> index a38b4f3..24f769a 100644
> --- a/drivers/gpu/drm/i915/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/intel_sprite.c
> @@ -817,7 +817,8 @@ static u32 g4x_sprite_ctl(const struct intel_crtc_state
> *crtc_state,
>
915/intel_pm.c | 29 ++-
> > drivers/gpu/drm/i915/intel_sprite.c | 38 +++-
> > include/uapi/drm/drm_fourcc.h| 20 ++
> > 7 files changed, 428 insertions(+), 39 deletions(-)
> >
> > --
> > 1.9.1
> >
> > ___
it more obvious any
differences between the different sequences. Thanks Hans!
The rest of the patches in this series look good too. So for the series:
Reviewed-by: Bob Paauwe
> ---
> Changes in v2:
> -Make the comment a table with 3 columns for easier comparison of the
> 3 sequenc
; between the core and the VBT stuff. Let's keep things that way, but
> without the interface.
>
> BR,
> Jani.
This all looks good to me also, so with the update to patch 5
Reviewed-by: Bob Paauwe
>
> Jani Nikula (7):
> drm/i915/dsi: remove support for m
On Wed, 29 Mar 2017 13:32:55 +0300
Jani Nikula wrote:
> Reduce indent. No functional changes.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Bob Paauwe
> ---
> drivers/gpu/drm/i915/intel_opregion.c | 64
> +--
> 1 file changed, 32 insert
On Wed, 29 Mar 2017 13:32:56 +0300
Jani Nikula wrote:
> Seems more sensible this way, and reduces indent for the more common
> case.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Bob Paauwe
> ---
> drivers/gpu/drm/i915/intel_opregion.c | 41
> +---
On Wed, 29 Mar 2017 13:32:57 +0300
Jani Nikula wrote:
> Leave more breadcrumbs for debuggers.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Bob Paauwe
> ---
> drivers/gpu/drm/i915/intel_opregion.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --gi
f (!intel_load_vbt_firmware(dev_priv))
> + goto out;
I find the condition a bit confusing. It reads to me as "if firmware
not loaded, goto out" which is backwards from what it's really doing.
Since you're ignoring the error return value anyway, making
intel_loa
On Thu, 30 Mar 2017 09:22:19 +0300
Jani Nikula wrote:
> On Wed, 29 Mar 2017, Bob Paauwe wrote:
> > On Wed, 29 Mar 2017 13:32:58 +0300
> > Jani Nikula wrote:
> >
> >> Sometimes it would be most enlightening to debug systems by replacing
> >> the VBT to
sion == 2)
> > @@ -328,11 +354,11 @@ static const u8 *mipi_exec_gpio(struct intel_dsi
> > *intel_dsi, const u8 *data)
> > value = *data++ & 1;
> >
> > if (IS_VALLEYVIEW(dev_priv))
> > - vlv_exec_gpio(dev_priv, gpio_so
On Wed, 21 Dec 2016 08:45:46 +0200
Mika Kahola wrote:
> Hi Bob,
>
> On Tue, 2016-12-20 at 09:53 -0800, Bob Paauwe wrote:
> > On Tue, 13 Dec 2016 16:11:20 +0200
> > Jani Nikula wrote:
> >
> > >
> > > On Mon, 05 Dec 2016, Mika Kahola
On Fri, 6 Jun 2014 22:44:12 +0300
wrote:
> From: Ville Syrjälä
>
> My Fujitsu-Siemens Lifebook S6010 definitely has a VGA connector, but
> the VBT says different. Ignore the VBT for 830M since it seems such
> old machines would generally have a VGA connector.
>
> This is a regression caused by
Add the infrastructure to support plane properties in the intel_plane
structure. Then use that infrastructure to add a property that controls
wether gamma correction is applied to a plane.
The default value is to enable gamma correction on the planes to match the
previous behavior.
Bob Paauwe (2
(Matt)
Add enum definitions for sprite gamma enable/disable
v3: Rename property name to "Sprite Gamma Enabled" (Matt)
Signed-off-by: Bob Paauwe
---
drivers/gpu/drm/i915/i915_drv.h | 5 +
drivers/gpu/drm/i915/intel_drv.h| 6 ++
drivers/gp
Hook up the set_property function pointer to a stub function. The function
will be populated once actual plane properties are created.
Signed-off-by: Bob Paauwe
---
drivers/gpu/drm/i915/intel_sprite.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/i915
There isn't a 'dev' variable that can be referenced here. Use
vm->dev instead.
Signed-off-by: Bob Paauwe
---
drivers/gpu/drm/i915/i915_trace.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_trace.h
b/drivers/gpu/drm/i915/
On Wed, 13 Nov 2013 10:20:47 -0800
Jesse Barnes wrote:
> Retrieve current framebuffer config info from the regs and create an fb
> object for the buffer the BIOS or boot loader left us. This should
> allow for smooth transitions to userspace apps once we finish the
> initial configuration constr
int bpp;
> + bool tiled;
> + int base, offset;
> + int fb_width, fb_height;
> + int pipe_width, pipe_height;
> + int pitch;
> + int size;
> + struct drm_i915_gem_object *obj;
> +};
> +
> struct intel_crtc_config {
> /**
>*
ecific just because there's no generic way to
> do AUX transactions given just a drm_connector. However it's all pretty
> straightforward to port to other drivers.
>
> v2: Add more DPCD registers to dump.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Bob
If the sink does not provide a maximum link rate, then check the
connector configuration before defaulting to the lowest allowed
link rate.
Signed-off-by: Bob Paauwe
---
drivers/gpu/drm/i915/intel_dp.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers
Allow the init-time configuration to specify the bits per color value
that gets used if bits per color is not present in EDID data (or if EDID
is not present).
v2: Use connector->base.name for connector name (Jani)
Signed-off-by: Bob Paauwe
---
drivers/gpu/drm/i915/intel_display.c |
firmware on shutdown (Bob)
Free allocated intel_config_info on shutdown (Bob)
Signed-off-by: Bob Paauwe
---
drivers/gpu/drm/i915/Makefile | 3 +-
drivers/gpu/drm/i915/i915_dma.c | 4 +
drivers/gpu/drm/i915/i915_drv.h | 17 ++
drivers/gpu/drm/i915/i915_params.c |
Allow the configuration file to overide the various panel power
sequence delay values.
Signed-off-by: Bob Paauwe
---
drivers/gpu/drm/i915/intel_dp.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index
This is an example of what an ACPI property table looks like.
Signed-off-by: Bob Paauwe
---
drivers/gpu/drm/i915/i915-properties.asl | 167 +++
1 file changed, 167 insertions(+)
create mode 100644 drivers/gpu/drm/i915/i915-properties.asl
diff --git a/drivers/gpu
Set the initial value of the force audio and broadcast rgb properties
using property values found in the init-time configuration.
v2: Use drm connector name (Jani)
Signed-off-by: Bob Paauwe
---
drivers/gpu/drm/i915/intel_modes.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
To allow us to verify the current backlight max and level values.
Signed-off-by: Bob Paauwe
---
drivers/gpu/drm/i915/i915_debugfs.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
b/drivers/gpu/drm/i915/i915_debugfs.c
index a9b96fd..2bac3bc 100644
Use the init-time configuration setting for scaling_mode to set the
initial value of the scaling_mode connector property.
v2: Use drm connector name (Jani)
Signed-off-by: Bob Paauwe
---
drivers/gpu/drm/i915/intel_dp.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a
So that we verify which values are currently in use.
Signed-off-by: Bob Paauwe
---
drivers/gpu/drm/i915/i915_debugfs.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
b/drivers/gpu/drm/i915/i915_debugfs.c
index 2394924
Allow the configuration file to overide the backlight max and level
settings.
Signed-off-by: Bob Paauwe
---
drivers/gpu/drm/i915/intel_panel.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_panel.c
b/drivers/gpu/drm/i915/intel_panel.c
index d8686ce
m_i915.aml for testing the code.
Bob Paauwe (10):
drm/i915/config: Initial framework
drm/i915/config: Add init-time configuration of bits per color.
drm/i915/config: Add init-time configuration of general connector
properties.
drm/i915/config: Add init-time configuration of dp pa
Date: Wed Oct 29 11:32:36 2014 +0200
drm/i915: Covert remaining platforms to choose DPLLS before
disabling CRTCs
Signed-off-by: Bob Paauwe
CC: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/intel_display.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions
On Mon, 10 Nov 2014 12:40:47 +0200
Ville Syrjälä wrote:
> On Fri, Nov 07, 2014 at 04:07:50PM -0800, Bob Paauwe wrote:
> > The pipe config needs to be initialized before calling crtc_compute_clock
> > since this will update the new_config structure DPLL values. Initializing
>
disabling crtcs
and
commit 00d958817dd3daaa452c221387ddaf23d1e4c06f
Author: Ander Conselvan de Oliveira
Date: Wed Oct 29 11:32:36 2014 +0200
drm/i915: Covert remaining platforms to choose DPLLS before
disabling CRTCs
Signed-off-by: Bob Paauwe
CC: Ander
look at new configuration - Ander
Signed-off-by: Bob Paauwe
CC: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/intel_display.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
On Thu, 13 Nov 2014 10:43:21 -0800
Matt Roper wrote:
> We'll want to call this from the type-agnostic atomic plane helper
> hooks. Since it's not sprite-specific anymore, more it to
> intel_display.c as well.
>
> Signed-off-by: Matt Roper
> ---
> drivers/gpu/drm/i915/intel_display.c | 21
On Thu, 13 Nov 2014 11:12:01 -0800
Matt Roper wrote:
> On Thu, Nov 13, 2014 at 11:11:38AM -0800, Bob Paauwe wrote:
> > On Thu, 13 Nov 2014 10:43:21 -0800
> > Matt Roper wrote:
> >
> > > We'll want to call this from the type-agnostic atomic plane helper
On Thu, 13 Nov 2014 10:43:24 -0800
Matt Roper wrote:
> Add the new driver entrypoints that will be called by the atomic plane
> helpers.
>
> This patch does not actually switch over to the new plane helpers yet,
> so there should be no functional change here. Also note that although
> plane pro
On Thu, 13 Nov 2014 10:43:20 -0800
Matt Roper wrote:
> Signed-off-by: Matt Roper
Reviewed-by: Bob Paauwe
> ---
> drivers/gpu/drm/i915/intel_display.c | 28 ++--
> drivers/gpu/drm/i915/intel_drv.h | 3 +--
> drivers/gpu/drm/i915/intel
On Thu, 13 Nov 2014 10:43:23 -0800
Matt Roper wrote:
> We'll want to use this from the atomic plane helpers, so ensure it can
> be called outside intel_display.c.
>
> Signed-off-by: Matt Roper
Reviewed-by: Bob Paauwe
> ---
> drivers/gpu/drm/i915/intel_display.c |
gt; call that intel_destroy_plane() did is unnecessary since the plane will
> already be disabled due to framebuffer destruction by the point it gets
> called.
>
> Signed-off-by: Matt Roper
Reviewed-by: Bob Paauwe
> ---
> drivers/gpu/drm/i915/intel_display.c | 12 ++-
: igt/kms_universal_plane
> Testcase: igt/kms_cursor_crc
> Signed-off-by: Matt Roper
With the above typo fixed this is
Acknowledged-by: Bob Paauwe
> ---
> drivers/gpu/drm/i915/intel_display.c | 255
> +--
> drivers/gpu/drm/i915/intel_sprite.c | 122 ++
src,dst} fields in intel_plane_state. Drop them.
>
> Signed-off-by: Matt Roper
Reviewed-by: Bob Paauwe
> ---
> drivers/gpu/drm/i915/intel_display.c | 16
> drivers/gpu/drm/i915/intel_drv.h | 6 --
> drivers/gpu/drm/i915/intel_sprite.c | 8
> 3 f
The registers and process differ from other platforms.
Signed-off-by: Bob Paauwe
---
drivers/gpu/drm/i915/intel_display.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index c38c297
state (Ville)
Cc: Ville Syrjälä
Cc: Imre Deak
Cc: Matt Roper
Signed-off-by: Bob Paauwe
Signed-off-by: Matt Roper
---
drivers/gpu/drm/i915/intel_display.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm
Broxton is using a different register and different bit ordering
for rps status capabilities.
Also GT perf freqency register is different for Broxton so update
that.
Signed-off-by: Bob Paauwe
---
drivers/gpu/drm/i915/i915_debugfs.c | 21 -
drivers/gpu/drm/i915/i915_reg.h
() will flag these zero'd out pipe/plane
watermarks and throw errors.
By not clearing all pipe/plane watermark values, only those that
require changes are changed and the remaining stay unchanged.
Signed-off-by: Bob Paauwe
---
drivers/gpu/drm/i915/intel_pm.c | 2 --
1 file changed, 2 dele
Extend this to SKL and BXT as it's needed for these platforms as well.
Signed-off-by: Bob Paauwe
---
drivers/gpu/drm/i915/intel_display.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
primary plane and something displayed on a sprite
plane when the ARGB format is used.
Signed-off-by: Bob Paauwe
---
drivers/gpu/drm/i915/intel_sprite.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/intel_sprite.c
b/drivers/gpu/drm/i915/intel_sprite.c
index 9d8af2f
On Fri, 28 Aug 2015 15:19:04 +0100
Daniel Stone wrote:
> Hi Bob,
>
> On 27 August 2015 at 21:46, Bob Paauwe wrote:
> > Extend this to SKL and BXT as it's needed for these platforms as well.
> >
> > Signed-off-by: Bob Paauwe
> > ---
> > drivers/gpu/
On Fri, 28 Aug 2015 17:12:12 +0100
Daniel Stone wrote:
> Hi,
>
> On 28 August 2015 at 16:55, Bob Paauwe wrote:
> > On Fri, 28 Aug 2015 15:19:04 +0100
> > Daniel Stone wrote:
> >> For both this and the previous patch, cf. the corresponding patch for
> >
Extend this to SKL and BXT as it's needed for these platforms as well.
v2: Change if condition to HAS_DDI() instead of listing each platform
Signed-off-by: Bob Paauwe
---
drivers/gpu/drm/i915/intel_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gp
Damien,
You reviewed v1 and then went on vacation for v2. Any chance you can
review v2?
Thanks,
Bob
On Tue, 21 Jul 2015 10:42:53 -0700
Bob Paauwe wrote:
> Clearing the watermarks for all pipes/planes when updating the
> watermarks for a single CRTC change seems like the wrong thing t
On Fri, 15 May 2015 12:39:20 +0300
Ville Syrjälä wrote:
> On Tue, Feb 24, 2015 at 09:52:16PM +0100, Daniel Vetter wrote:
> > On Tue, Feb 24, 2015 at 10:37:10AM -0800, Bob Paauwe wrote:
> > > On Tue, 24 Feb 2015 14:57:48 +0100
> > > Daniel Vetter wrote:
> > >
On Thu, 21 May 2015 10:37:07 +0200
Daniel Vetter wrote:
> On Wed, May 20, 2015 at 10:07:58AM -0700, Bob Paauwe wrote:
> > On Fri, 15 May 2015 12:39:20 +0300
> > Ville Syrjälä wrote:
> >
> > > On Tue, Feb 24, 2015 at 09:52:16PM +0100, Daniel Vetter wrote:
> &g
specific value (0x00)
The tiled bo is filled with a different value (0xff)
If any bytes in the linear bo get written with 0xff, then the
fence allowed writing beyond the tiled bo boundry.
Signed-off-by: Bob Paauwe
---
tests/Makefile.sources | 1 +
tests/gem_tiled_fence_overflow.c | 134
101 - 200 of 227 matches
Mail list logo
