Hi Pierre,
On Sun, August 31, 2014 14:12, Pierre Joye wrote:
Hi Anatol,
Thanks!
For what I see it should have no impact, either mem usage or perf but
when such offset is used, in 64bit.
However some numbers are better, could you provide some using exclusively
this syntax and using
Hi,
while refining the big string support, it turned out that we've an issue.
The syntax like $s[42] = 'x'; is currently inconsistend, because we have
uint32 for string offsets. This actually means, the behaviour is currently
only available in the old style and can handle not more than 2gb big
On Fri, August 29, 2014 19:41, Andrea Faulds wrote:
On 29 Aug 2014, at 17:39, Anatol Belski anatol@belski.net wrote:
On Fri, August 29, 2014 17:54, Andrea Faulds wrote:
I’d just leave things as they are… though I suppose there might be
some benefit to switching to size_t for string
On Fri, August 29, 2014 18:34, Xinchen Hui wrote:
On Fri, Aug 29, 2014 at 11:49 PM, Anatol Belski anatol@belski.net
wrote:
Hi,
while refining the big string support, it turned out that we've an
issue. The syntax like $s[42] = 'x'; is currently inconsistend, because
we have uint32
Hi Derick,
On Thu, August 28, 2014 17:23, Derick Rethans wrote:
On Fri, 22 Aug 2014, Derick Rethans wrote:
On Fri, 22 Aug 2014, Anatol Belski wrote:
as there are many data type changes, here's an idea on how to simplify
the merges. Git supports custom merge drivers which attracted my
On Wed, August 27, 2014 01:32, Nikita Popov wrote:
On Mon, Aug 18, 2014 at 3:39 PM, Anatol Belski a...@php.net wrote:
Commit:97e9d058f09c12161863e5c3832552eb5da3f3c6
Author:Anatol Belski a...@php.net Mon, 18 Aug 2014 15:39:38
+0200
Parents
Hi Derick,
On Tue, August 26, 2014 10:49, Derick Rethans wrote:
On Fri, 22 Aug 2014, Anatol Belski wrote:
On Fri, August 22, 2014 17:17, Derick Rethans wrote:
On Fri, 22 Aug 2014, Anatol Belski wrote:
On Fri, August 22, 2014 14:54, Derick Rethans wrote:
Yeah, those datatypes should
Hi Tjerk,
On Wed, August 27, 2014 07:34, Tjerk Meesters wrote:
Hi internals,
With the recent merge of int64 the `zend_string` type now uses `size_t`
to store its length, but ZPP (and friends) still use `int *` to store the
parsed string lengths.
Hi Lior,
On Mon, August 25, 2014 11:09, Lior Kaplan wrote:
Hi Anatol,
It seems you've done some changes to the date extension recently, could
you take a look at these two failures.
Dmitry - FYI in case it's phpng related.
Bug #67118 crashes in DateTime when this used after failed
Moin,
On Thu, August 21, 2014 19:23, Dmitry Stogov wrote:
Hi,
Thanks to Anatol and Pierre the 64-bit patch is ready
https://github.com/weltling/php-src
I made quick code review and don't see any technical problems now.
The performance and memory consumption difference is negligible.
Hi,
as there are many data type changes, here's an idea on how to simplify the
merges. Git supports custom merge drivers which attracted my attention, so
I've ended up with the following trick:
=== Add to .git/config ===
[merge 7]
name = Compatibility merge between PHP5 and PHP7
driver
Hi Nikita,
On Fri, August 22, 2014 13:16, Nikita Popov wrote:
Hi internals!
Today the int64 RFC has been merged, despite objections regarding the
naming changes it introduces.
As we were not given a chance to resolve this issue before the merge, a
short proposal has been created, which
On Fri, August 22, 2014 14:15, Pierre Joye wrote:
On Fri, Aug 22, 2014 at 2:01 PM, Derick Rethans der...@php.net wrote:
On Mon, 18 Aug 2014, Anatol Belski wrote:
Commit:e49e163a9ed7d4e38f9ab724003c46c9f1ea2cb4
Author:Anatol Belski a...@php.net Mon, 18 Aug 2014
18:57:55
On Fri, August 22, 2014 14:54, Derick Rethans wrote:
On Fri, 22 Aug 2014, Anatol Belski wrote:
On Fri, August 22, 2014 14:01, Derick Rethans wrote:
On Mon, 18 Aug 2014, Anatol Belski wrote:
Commit:e49e163a9ed7d4e38f9ab724003c46c9f1ea2cb4
Author:Anatol Belski a...@php.net
On Fri, August 22, 2014 17:17, Derick Rethans wrote:
On Fri, 22 Aug 2014, Anatol Belski wrote:
On Fri, August 22, 2014 14:54, Derick Rethans wrote:
Yeah, those datatypes should already be there. What needs fixing to
make it work?
I think now that it's unavoidable to create an arch
Hi Julien,
On Fri, June 13, 2014 16:20, Julien Pauli wrote:
Hi,
I just wrote a patch to add fallocate() syscall support for streams.
It relies on posix_fallocate(), so that it should support many Unixes.
Linux's got a specification with a fallocate() function, more powerful
than the posix
. Dmitry.
On Fri, Oct 18, 2013 at 7:33 PM, Anatol Belski a...@php.net wrote:
Hi,
the pull request https://github.com/php/php-src/pull/500 fixing the bug
#50333 is ready to review. Manual tests done so far on linux and
windows in TS and NTS mode with CLI and Apache show no regression
Hi,
there are two improvements just implemented to the PECL website.
I
Every package is required to have LICENSE or COPYING to be present in
the root of the package. The goal is to enforce the conformance with at
least PHP and BSD licenses. Where by no explicit check for exact license
type is
Hi,
as one could already have seen, the links to the extension DLLs has been
integrated into the PECL website. Basically the builds done until now are
shown. Together with the automatic builds this brings automatic updates
for every new release built for windows. A couple of notes I'd like to
On Thu, August 15, 2013 20:45, Johannes Schlüter wrote:
On Thu, 2013-08-15 at 20:19 +0200, Jordi Boggiano wrote:
And to ensure you never push garbage by accident, run this to tell git
to always only push the branch you're on when you run `git push`:
git config --global push.default current
Hi Nikita,
On Sat, 2013-08-03 at 20:16 +0200, Nikita Popov wrote:
Why can't we always provide the retval ptr, even for functions that don't
return by reference? This would allow returning zvals without having to
copy them first (what RETVAL_ZVAL does).
were it not possible to zval_add_ref()
Jan,
On Fri, 2013-07-19 at 23:25 +0200, Jan Ehrhardt wrote:
Sometimes you run into weird things. Today I learned that upgrading to
ICU51 works perfectly under x64, but x86 stumbles over it and fails to
compile php_intl.dll. No wonder the official builds still stick to
50.1.2.
There was
Hi Jan,
I've just tried to make a snapshot build and it's worked. Please give the
exact way you do it from the start.
Regards
Anatol
On Fri, July 19, 2013 12:44, Jan Ehrhardt wrote:
Julien Pauli in php.internals (Fri, 19 Jul 2013 10:26:54 +0200):
We just released PHP 5.5.1. This release
On Fri, July 19, 2013 14:17, Jan Ehrhardt wrote:
Jan Ehrhardt in php.internals (Fri, 19 Jul 2013 14:03:51 +0200):
http://windows.php.net/downloads/releases/php-5.5.1-src.zip does not
contain a zend_language_parser.c. The php-5.5.1.tar.xz does...
Hi,
On Wed, July 10, 2013 07:51, Pierre Joye wrote:
Substr needs to be refactored to use size_t. Right now, I just raise an
error if Z_STRSIZE INT_MAX (or an overflow would happen). I'd love
to see that cleaned up more.
We should consider moving to int64_t too as well while being at it.
Hi Etienne,
On Mon, June 10, 2013 13:24, Etienne Kneuss wrote:
On Fri, Jun 7, 2013 at 9:27 PM, Gustavo Lopes
glo...@nebm.ist.utl.ptwrote:
On Fri, 07 Jun 2013 14:06:11 +0200, Derick Rethans der...@php.net
wrote:
That's the one where conversion int string for serialization was
On Mon, June 10, 2013 14:04, Etienne Kneuss wrote:
On Mon, Jun 10, 2013 at 1:56 PM, Anatol Belski a...@php.net wrote:
Hi Etienne,
On Mon, June 10, 2013 13:24, Etienne Kneuss wrote:
On Fri, Jun 7, 2013 at 9:27 PM, Gustavo Lopes
glo...@nebm.ist.utl.ptwrote:
On Fri, 07 Jun 2013 14:06:11
Hi Stas,
On Mon, 2013-06-10 at 10:54 -0700, Stas Malyshev wrote:
Hi!
Stas, Johannes? We have to fix this crash, in one way or another. The
current patch is good imo.
I'm ok with this in 5.4 but I'd really like to fix the var_dump issue if
possible.
I've reworked the patch before
Hi Derick,
On Fri, June 7, 2013 12:45, Derick Rethans wrote:
On Thu, 6 Jun 2013, Pierre Joye wrote:
On Jun 6, 2013 6:03 PM, Derick Rethans der...@php.net wrote:
On Thu, 6 Jun 2013, Pierre Joye wrote:
The fix for #53437 is around for some time now. It full fills the
requirements
Hi Derick,
On Fri, June 7, 2013 14:06, Derick Rethans wrote:
On Fri, 7 Jun 2013, Anatol Belski wrote:
On Fri, June 7, 2013 12:45, Derick Rethans wrote:
On Thu, 6 Jun 2013, Pierre Joye wrote:
On Jun 6, 2013 6:03 PM, Derick Rethans der...@php.net wrote:
On Thu, 6 Jun 2013, Pierre Joye
Hi David,
On Fri, 2013-05-24 at 23:28 +0200, David Soria Parra wrote:
Hi Anatol,
I saw your commit 74555e7c26b2c61bb8e67b7d6a6f4d2b8eb3a5f3 added a 4mb
mp3 file. Is it possible to create a much smaller mp3 that helps to
reproduce the same bug? The file blows up the taball file for the
Jan,
On Thu, April 25, 2013 16:21, Jan Ehrhardt wrote:
Remi pointed me in the right direction. I discovered the new packages at
/qa just before I read your replies. It now builds fine with the
exception of php_ssh2.dll. I used these dependencies:
Jan,
On Thu, April 25, 2013 19:10, Jan Ehrhardt wrote:
That was exectly the version:
SSH2 support enabled
extension version 0.12 libssh2 version1.4.2 (or 1.4.3) banner
SSH-2.0-libssh2_1.4.2/3
With the libssh2* files from
Jan,
On Thu, April 25, 2013 21:46, Jan Ehrhardt wrote:
Anatol Belski in php.internals (Thu, 25 Apr 2013 20:12:11 +0200):
Ok, so we must have built some different ways. Anyway that builds I've
mentioned should work and I'll recheck next time I do the ssh2 ext.
The difference probably
Hi,
I just wanted to address again these two patches to be applied in 5.3/5.4
http://git.php.net/?p=php-src.git;a=commitdiff;h=0ee71557ffd285552659b6aa37ea236e3bad493f
http://git.php.net/?p=php-src.git;a=commitdiff;h=fa3fc711d3fb54bf1746138ffcf7f46426921204
Both are in 5.5 already for some
Stas,
how does it look with this one? Please let me know whether it's ok for
5.4. I would go with master otherwise.
Thanks
Anatol
On Mon, 2013-04-01 at 19:13 +0200, Anatol Belski wrote:
Stas,
I've invested more time and here's almost cleaned up patch
http://belski.net/phpz/finfo
Stas,
I've invested more time and here's almost cleaned up patch
http://belski.net/phpz/finfo/finfo_5.14_10.patch.gz
The tests pass, valgrind is happy, as well Windows. I've noticed no
behaviour change, except - as the data is updated and one might see
different (eventually better) results.
Hi,
I've developed a patch for libmagic 5.14 which is available under
http://belski.net/phpz/finfo/finfo_5.14_5.patch.gz . For those willing
to test please overwrite ext/fileinfo/tests/magic with
http://belski.net/phpz/finfo/magic.mgc.gz (not contained in the patch).
I've tested it on Linux and
variation, effectively double or
long. That might coexist in pecl or in core. Any other intrusion would
change the core significantly.
Thanks for your support!
Anatol
On Fri, 2013-03-22 at 11:34 +0100, Anatol Belski wrote:
On Fri, March 22, 2013 10:08, Dmitry Stogov wrote:
Thanks, now I
it's disallowed, but you may get
arguments as longs and then convert them to double. Will it work?
Thanks. Dmitry.
On Thu, Mar 21, 2013 at 9:26 PM, Dmitry Stogov dmi...@zend.com wrote:
I'll able to look only tomorrow morning.
Thanks. Dmitry.
On Thu, Mar 21, 2013 at 8:46 PM, Anatol
that issue and that
could indeed be made better, that's my motivation.
Thanks for the tips.
Anatol
Thanks. Dmitry.
On Fri, Mar 22, 2013 at 12:08 PM, Anatol Belski a...@php.net wrote:
Dmitry,
first of all thanks for taking a look :)
The issue in a few words
- mt_rand reads arguments
Hi Dmitry,
I developed a patch for this one https://bugs.php.net/bug.php?id=64450 .
It's regarding to the long overflow in mt_rand(). The main idea is to work
with the args as double internally and then return php float if it exceeds
the LONG_MAX. I strived to let the old behavior to be
On Wed, March 20, 2013 09:05, Stas Malyshev wrote:
Hi!
The issue is that a warning wouldn't destroy that object. That object
will occasionally segfault PHP. E_ERROR is the simplest solution which
doesn't change the behavior of the normal operations.
Can't we just reset the object data to
Hi,
#62852 and #53437 introduced fixes for the date extension crashing when
unserializing objects. They was applied to 5.5. If there are no
objections, I would backport those to 5.3 and 5.4.
Regards
Anatol
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit:
E_RECOVERABLE or even just E_WARNING.
johannes
Anatol Belski a...@php.net wrote:
Hi,
#62852 and #53437 introduced fixes for the date extension crashing when
unserializing objects. They was applied to 5.5. If there are no
objections, I would backport those to 5.3 and 5.4.
Regards
On Thu, March 14, 2013 12:42, Derick Rethans wrote:
On Wed, 13 Mar 2013, Anatol Belski wrote:
On Mon, 2013-03-11 at 11:42 +, Derick Rethans wrote:
On Mon, 11 Mar 2013, Anatol Belski wrote:
What is the way you had in the mind to achieve the
string-integer conversions?
atoll
On Thu, March 14, 2013 14:14, Anatol Belski wrote:
On Thu, March 14, 2013 12:42, Derick Rethans wrote:
On Wed, 13 Mar 2013, Anatol Belski wrote:
On Mon, 2013-03-11 at 11:42 +, Derick Rethans wrote:
On Mon, 11 Mar 2013, Anatol Belski wrote:
What is the way you had in the mind
On Mon, 2013-03-11 at 11:42 +, Derick Rethans wrote:
Please, no top posting!
On Mon, 11 Mar 2013, Anatol Belski wrote:
On Sun, March 10, 2013 23:11, Derick Rethans wrote:
On Sat, 9 Mar 2013, Anatol Belski wrote:
On Sat, 2013-03-09 at 21:57 +0100, Gustavo Lopes wrote:
I
, Anatol Belski wrote:
On Sat, 2013-03-09 at 21:57 +0100, Gustavo Lopes wrote:
On Sat, 09 Mar 2013 21:36:41 +0100, Derick Rethans der...@php.net
wrote:
On Tue, 5 Mar 2013, Anatol Belski wrote:
I've reworked the patch from
http://nebm.ist.utl.pt/~glopes/misc/date_period_interval_ser.diff
Hi,
On Sat, 2013-03-09 at 21:57 +0100, Gustavo Lopes wrote:
On Sat, 09 Mar 2013 21:36:41 +0100, Derick Rethans der...@php.net wrote:
On Tue, 5 Mar 2013, Anatol Belski wrote:
I've reworked the patch from
http://nebm.ist.utl.pt/~glopes/misc/date_period_interval_ser.diff
(mentioned
Hi,
I wanted just remind about that bug and the patches hanging there. If
there are no objections, I'd commit first to 5.5+ next week. 5.3/5.4 were
also debatable.
Regards
Anatol
On Tue, March 5, 2013 12:46, Anatol Belski wrote:
Sorry, the correct one is bug #53437 ...
On Tue, March 5
Hi,
I've reworked the patch from
http://nebm.ist.utl.pt/~glopes/misc/date_period_interval_ser.diff
(mentioned by tony2001) for bug #63437, that seems to fix the issue. That
patch was ported back to 5.3 and adapted to the current 5.4+. Both
variants are posted to the ticket.
Also the test for bug
Sorry, the correct one is bug #53437 ...
On Tue, March 5, 2013 12:42, Anatol Belski wrote:
Hi,
I've reworked the patch from
http://nebm.ist.utl.pt/~glopes/misc/date_period_interval_ser.diff
(mentioned by tony2001) for bug #63437, that seems to fix the issue. That
patch was ported back
601 - 653 of 653 matches
Mail list logo
