[jira] [Commented] (CALCITE-3871) Remove dependency of org.apiguardian:apiguardian-api

[ https://issues.apache.org/jira/browse/CALCITE-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074298#comment-17074298 ] Vladimir Sitnikov commented on CALCITE-3871: {quote} Restoring apiguardian

[jira] [Commented] (CALCITE-3789) Support validation of UNNEST multiple array columns like Presto

[ https://issues.apache.org/jira/browse/CALCITE-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074288#comment-17074288 ] Will Yu commented on CALCITE-3789: -- [~julianhyde] Make sense. To convert SqlNode to R

[jira] [Commented] (CALCITE-3893) SQL with GROUP_ID may generate wrong plan

[ https://issues.apache.org/jira/browse/CALCITE-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074213#comment-17074213 ] Feng Zhu commented on CALCITE-3893: --- The result is correct. It seems that the rutime

[jira] [Assigned] (CALCITE-3893) SQL with GROUP_ID may generate wrong plan

[ https://issues.apache.org/jira/browse/CALCITE-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu reassigned CALCITE-3893: - Assignee: Feng Zhu > SQL with GROUP_ID may generate wrong plan > -

[jira] [Updated] (CALCITE-3893) SQL with GROUP_ID may generate wrong plan

[ https://issues.apache.org/jira/browse/CALCITE-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3893: -- Fix Version/s: 1.23.0 > SQL with GROUP_ID may generate wrong plan > -

[jira] [Commented] (CALCITE-3871) Remove dependency of org.apiguardian:apiguardian-api

[ https://issues.apache.org/jira/browse/CALCITE-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074185#comment-17074185 ] Danny Chen commented on CALCITE-3871: - Restoring apiguardian as a dependency does n

[jira] [Commented] (CALCITE-3891) Remove use of Pair.zip in RelTraitSet.satisfies

[ https://issues.apache.org/jira/browse/CALCITE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074178#comment-17074178 ] Julian Hyde commented on CALCITE-3891: -- I wrote that code, but since it shows up i

[jira] [Commented] (CALCITE-3789) Support validation of UNNEST multiple array columns like Presto

[ https://issues.apache.org/jira/browse/CALCITE-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074075#comment-17074075 ] Julian Hyde commented on CALCITE-3789: -- I saw some 'design discussion' stuff going

[jira] [Commented] (CALCITE-3876) RelToSqlConverter should not merge a Project that contains a window function that references a window function in input Project

[ https://issues.apache.org/jira/browse/CALCITE-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074039#comment-17074039 ] Julian Hyde commented on CALCITE-3876: -- Please review [PR #1896|https://github.com

[jira] [Updated] (CALCITE-3892) Make junit test classes and methods non-public

[ https://issues.apache.org/jira/browse/CALCITE-3892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-3892: - Fix Version/s: 1.23.0 > Make junit test classes and methods non-public > --

[jira] [Updated] (CALCITE-3876) RelToSqlConverter should not merge a Project that contains a window function that references a window function in input Project

[ https://issues.apache.org/jira/browse/CALCITE-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-3876: - Fix Version/s: 1.23.0 > RelToSqlConverter should not merge a Project that contains a window fun

[jira] [Assigned] (CALCITE-3814) Support JDK 14 and guava-28.2-jre

[ https://issues.apache.org/jira/browse/CALCITE-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde reassigned CALCITE-3814: Assignee: Julian Hyde > Support JDK 14 and guava-28.2-jre >

[jira] [Commented] (CALCITE-3814) Support JDK 14 and guava-28.2-jre

[ https://issues.apache.org/jira/browse/CALCITE-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074037#comment-17074037 ] Julian Hyde commented on CALCITE-3814: -- The upgrade to Gradle 6.3 already happened

[jira] [Resolved] (CALCITE-3880) Add SortExchange support to RelFieldTrimmer

[ https://issues.apache.org/jira/browse/CALCITE-3880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich resolved CALCITE-3880. --- Fix Version/s: 1.23.0 Resolution: Fixed fixed in [8849b62e7baff84dcd4262f47

[jira] [Updated] (CALCITE-3814) Support JDK 14 and guava-28.2-jre

[ https://issues.apache.org/jira/browse/CALCITE-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-3814: - Fix Version/s: 1.23.0 > Support JDK 14 and guava-28.2-jre > - >

[jira] [Updated] (CALCITE-3814) Support JDK 14 and guava-28.2-jre

[ https://issues.apache.org/jira/browse/CALCITE-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-3814: - Summary: Support JDK 14 and guava-28.2-jre (was: Support JDK 14) > Support JDK 14 and guava-28

[jira] [Updated] (CALCITE-3877) In RexWindow, make fields upperBound and lowerBound not-nullable

[ https://issues.apache.org/jira/browse/CALCITE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-3877: - Description: Null lowerBound/upperBond in RexWindow causes NPE in RexShuttle. Here's a test th

[jira] [Updated] (CALCITE-3877) In RexWindow, make fields upperBound and lowerBound not-nullable

[ https://issues.apache.org/jira/browse/CALCITE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-3877: - Summary: In RexWindow, make fields upperBound and lowerBound not-nullable (was: Null lowerBoun

[jira] [Commented] (CALCITE-3892) Make junit test classes and methods non-public

[ https://issues.apache.org/jira/browse/CALCITE-3892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074031#comment-17074031 ] Julian Hyde commented on CALCITE-3892: -- Please review PR [https://github.com/apach

[jira] [Commented] (CALCITE-3877) Null lowerBound/upperBond in RexWindow causes NPE in RexShuttle

[ https://issues.apache.org/jira/browse/CALCITE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074033#comment-17074033 ] Julian Hyde commented on CALCITE-3877: -- Please review PR [https://github.com/apach

[jira] [Commented] (CALCITE-3893) SQL with GROUP_ID may generate wrong plan

[ https://issues.apache.org/jira/browse/CALCITE-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074015#comment-17074015 ] Julian Hyde commented on CALCITE-3893: -- I removed fixVersion because this is curre

[jira] [Updated] (CALCITE-3893) SQL with GROUP_ID may generate wrong plan

[ https://issues.apache.org/jira/browse/CALCITE-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-3893: - Fix Version/s: (was: 1.23.0) > SQL with GROUP_ID may generate wrong plan >

[jira] [Commented] (CALCITE-3893) SQL with GROUP_ID may generate wrong plan

[ https://issues.apache.org/jira/browse/CALCITE-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074011#comment-17074011 ] Julian Hyde commented on CALCITE-3893: -- Does the query produce the wrong results?

[jira] [Commented] (CALCITE-3893) SQL with GROUP_ID may generate wrong plan

[ https://issues.apache.org/jira/browse/CALCITE-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073656#comment-17073656 ] Feng Zhu commented on CALCITE-3893: --- [~icshuo], according to the discussion, we will

[jira] [Commented] (CALCITE-3893) SQL with GROUP_ID may generate wrong plan

[ https://issues.apache.org/jira/browse/CALCITE-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073628#comment-17073628 ] Shuo Cheng commented on CALCITE-3893: - Hi, [~donnyzone], I'm not quite understandin

[jira] [Commented] (CALCITE-3871) Remove dependency of org.apiguardian:apiguardian-api

[ https://issues.apache.org/jira/browse/CALCITE-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073604#comment-17073604 ] Vladimir Sitnikov commented on CALCITE-3871: [~danny0405], please restore a

[jira] [Commented] (CALCITE-3871) Remove dependency of org.apiguardian:apiguardian-api

[ https://issues.apache.org/jira/browse/CALCITE-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073601#comment-17073601 ] Danny Chen commented on CALCITE-3871: - [~vladimirsitnikov] how can we exclude, the

[jira] [Commented] (CALCITE-3893) SQL with GROUP_ID may generate wrong plan

[ https://issues.apache.org/jira/browse/CALCITE-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073547#comment-17073547 ] Feng Zhu commented on CALCITE-3893: --- Hi, [~icshuo], thanks for reporting the problem,

[jira] [Commented] (CALCITE-3893) SQL with GROUP_ID may generate wrong plan

[ https://issues.apache.org/jira/browse/CALCITE-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073506#comment-17073506 ] Shuo Cheng commented on CALCITE-3893: - The plan I suggested may not be rigorous eno

[jira] [Comment Edited] (CALCITE-3871) Remove dependency of org.apiguardian:apiguardian-api

[ https://issues.apache.org/jira/browse/CALCITE-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073502#comment-17073502 ] Stamatis Zampetakis edited comment on CALCITE-3871 at 4/2/20, 8:25 AM: --

[jira] [Commented] (CALCITE-3871) Remove dependency of org.apiguardian:apiguardian-api

[ https://issues.apache.org/jira/browse/CALCITE-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073502#comment-17073502 ] Stamatis Zampetakis commented on CALCITE-3871: -- Sorry my comment was not c

[jira] [Issue Comment Deleted] (CALCITE-3893) SQL with GROUP_ID may generate wrong plan

[ https://issues.apache.org/jira/browse/CALCITE-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuo Cheng updated CALCITE-3893: Comment: was deleted (was: Or like this:) > SQL with GROUP_ID may generate wrong plan >

[jira] [Commented] (CALCITE-3893) SQL with GROUP_ID may generate wrong plan

[ https://issues.apache.org/jira/browse/CALCITE-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073498#comment-17073498 ] Shuo Cheng commented on CALCITE-3893: - Or like this: > SQL with GROUP_ID may gener

[jira] [Commented] (CALCITE-3893) SQL with GROUP_ID may generate wrong plan

[ https://issues.apache.org/jira/browse/CALCITE-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073493#comment-17073493 ] Vladimir Sitnikov commented on CALCITE-3893: {quote}Maybe that we want is:{

[jira] [Updated] (CALCITE-3893) SQL with GROUP_ID may generate wrong plan

[ https://issues.apache.org/jira/browse/CALCITE-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuo Cheng updated CALCITE-3893: Description: Consider the following SQL: {code:java} select deptno, group_id() as g, count(*)

[jira] [Updated] (CALCITE-3893) SQL with GROUP_ID may generate wrong plan

[ https://issues.apache.org/jira/browse/CALCITE-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuo Cheng updated CALCITE-3893: Summary: SQL with GROUP_ID may generate wrong plan (was: Sql with GROUP_ID may generate wrong pl

[jira] [Created] (CALCITE-3893) Sql with GROUP_ID may generate wrong plan

Shuo Cheng created CALCITE-3893: --- Summary: Sql with GROUP_ID may generate wrong plan Key: CALCITE-3893 URL: https://issues.apache.org/jira/browse/CALCITE-3893 Project: Calcite Issue Type: Bug

[jira] [Comment Edited] (CALCITE-3871) Remove dependency of org.apiguardian:apiguardian-api

[ https://issues.apache.org/jira/browse/CALCITE-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073464#comment-17073464 ] Vladimir Sitnikov edited comment on CALCITE-3871 at 4/2/20, 8:05 AM:

[jira] [Commented] (CALCITE-3871) Remove dependency of org.apiguardian:apiguardian-api

[ https://issues.apache.org/jira/browse/CALCITE-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073464#comment-17073464 ] Vladimir Sitnikov commented on CALCITE-3871: {quote}I think it makes sense

[jira] [Commented] (CALCITE-3871) Remove dependency of org.apiguardian:apiguardian-api

[ https://issues.apache.org/jira/browse/CALCITE-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073454#comment-17073454 ] Stamatis Zampetakis commented on CALCITE-3871: -- I think it makes sense to

[jira] [Assigned] (CALCITE-3892) Make junit test classes and methods non-public

[ https://issues.apache.org/jira/browse/CALCITE-3892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde reassigned CALCITE-3892: Assignee: Julian Hyde > Make junit test classes and methods non-public > ---

[jira] [Commented] (CALCITE-3892) Make junit test classes and methods non-public

[ https://issues.apache.org/jira/browse/CALCITE-3892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073434#comment-17073434 ] Julian Hyde commented on CALCITE-3892: -- All code benefits from having tight access