Re: [PR] [FLINK-34522][core] Changing the Time to Duration for StateTtlConfig.Builder.cleanupInRocksdbCompactFilter [flink]

2024-02-26 Thread via GitHub
1996fanrui commented on PR #24387: URL: https://github.com/apache/flink/pull/24387#issuecomment-1965978539 Thanks @XComp for the quick feedback. > But keep in mind that we shouldn't remove the API rightaway for @PublicEvolving APIs but rather keep the old version for at least one

[jira] [Updated] (FLINK-34424) BoundedBlockingSubpartitionWriteReadTest#testRead10ConsumersConcurrent times out

2024-02-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34424: -- Priority: Major (was: Critical) >

[jira] [Updated] (FLINK-34526) Without shuffling data, when a Task Manager is killed, restarting the Flink job takes a considerable amount of time

2024-02-26 Thread junzhong qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] junzhong qin updated FLINK-34526: - Description: In our test case, the pipeline is: !image-2024-02-27-15-50-25-071.png! #

[jira] [Commented] (FLINK-34525) When redundant task managers are enabled, it will still take a considerable amount of time to restart a job if a task manager is killed.

2024-02-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821041#comment-17821041 ] Martijn Visser commented on FLINK-34525: [~easonqin] This isn't really a complete ticket. What

[jira] [Created] (FLINK-34526) Without shuffling data, when a Task Manager is killed, restarting the Flink job takes a considerable amount of time

2024-02-26 Thread junzhong qin (Jira)
junzhong qin created FLINK-34526: Summary: Without shuffling data, when a Task Manager is killed, restarting the Flink job takes a considerable amount of time Key: FLINK-34526 URL:

Re: [PR] [FLINK-34522][core] Changing the Time to Duration for StateTtlConfig.Builder.cleanupInRocksdbCompactFilter [flink]

2024-02-26 Thread via GitHub
XComp commented on code in PR #24387: URL: https://github.com/apache/flink/pull/24387#discussion_r1503776636 ## flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfig.java: ## @@ -531,7 +531,7 @@ public long getQueryTimeAfterNumEntries() { return

Re: [PR] [FLINK-29114][table-planner][filesystem][test] Fix unstable TableSourceITCase#testTableHintWithLogicalTableScanReuse [flink]

2024-02-26 Thread via GitHub
snuyanzin commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1503780455 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/FileSystemTableSink.java: ## @@ -374,7 +374,8 @@ public

Re: [PR] [FLINK-29114][table-planner][filesystem][test] Fix unstable TableSourceITCase#testTableHintWithLogicalTableScanReuse [flink]

2024-02-26 Thread via GitHub
flinkbot commented on PR #24390: URL: https://github.com/apache/flink/pull/24390#issuecomment-1965970037 ## CI report: * ece0f829708723d1a0fedda0b24c20e5f709e116 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-29114) TableSourceITCase#testTableHintWithLogicalTableScanReuse sometimes fails with result mismatch

2024-02-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29114: --- Labels: auto-deprioritized-major pull-request-available test-stability (was:

[PR] [FLINK-29114][table-planner][filesystem][test] Fix unstable TableSourceITCase#testTableHintWithLogicalTableScanReuse [flink]

2024-02-26 Thread via GitHub
LadyForest opened a new pull request, #24390: URL: https://github.com/apache/flink/pull/24390 ## What is the purpose of the change This pull request aims to fix the unstable test case `TableSourceITCase#testTableHintWithLogicalTableScanReuse`. ## Brief change log

[jira] [Commented] (FLINK-29114) TableSourceITCase#testTableHintWithLogicalTableScanReuse sometimes fails with result mismatch

2024-02-26 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821024#comment-17821024 ] Jane Chan commented on FLINK-29114: --- Only this particular case encounters this issue because it writes

[jira] [Updated] (FLINK-34522) StateTtlConfig#cleanupInRocksdbCompactFilter still uses the deprecated Time class

2024-02-26 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-34522: Description: FLINK-32570 deprecated the Time class and refactor all Public or PublicEvolving apis to use

[jira] [Commented] (FLINK-34513) GroupAggregateRestoreTest.testRestore fails

2024-02-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821020#comment-17821020 ] Matthias Pohl commented on FLINK-34513: ---

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-02-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821019#comment-17821019 ] Matthias Pohl commented on FLINK-31472: ---

[jira] [Created] (FLINK-34525) When redundant task managers are enabled, it will still take a considerable amount of time to restart a job if a task manager is killed.

2024-02-26 Thread junzhong qin (Jira)
junzhong qin created FLINK-34525: Summary: When redundant task managers are enabled, it will still take a considerable amount of time to restart a job if a task manager is killed. Key: FLINK-34525 URL:

[jira] [Commented] (FLINK-34224) ChangelogStorageMetricsTest.testAttemptsPerUpload(ChangelogStorageMetricsTest timed out

2024-02-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821017#comment-17821017 ] Matthias Pohl commented on FLINK-34224: ---

[jira] [Commented] (FLINK-26515) RetryingExecutorTest. testDiscardOnTimeout failed on azure

2024-02-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821014#comment-17821014 ] Matthias Pohl commented on FLINK-26515: ---

[jira] [Commented] (FLINK-29114) TableSourceITCase#testTableHintWithLogicalTableScanReuse sometimes fails with result mismatch

2024-02-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821016#comment-17821016 ] Matthias Pohl commented on FLINK-29114: --- Thanks for your efforts. That will reduce the amount of

[jira] [Commented] (FLINK-29114) TableSourceITCase#testTableHintWithLogicalTableScanReuse sometimes fails with result mismatch

2024-02-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821015#comment-17821015 ] Matthias Pohl commented on FLINK-29114: ---

[jira] [Commented] (FLINK-29114) TableSourceITCase#testTableHintWithLogicalTableScanReuse sometimes fails with result mismatch

2024-02-26 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821012#comment-17821012 ] Jane Chan commented on FLINK-29114: --- Update: I added a random UUID to the staging dir, and now the

[jira] [Assigned] (FLINK-29114) TableSourceITCase#testTableHintWithLogicalTableScanReuse sometimes fails with result mismatch

2024-02-26 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan reassigned FLINK-29114: - Assignee: Jane Chan > TableSourceITCase#testTableHintWithLogicalTableScanReuse sometimes fails

[jira] [Comment Edited] (FLINK-34273) git fetch fails

2024-02-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821013#comment-17821013 ] Matthias Pohl edited comment on FLINK-34273 at 2/27/24 7:33 AM: *

[jira] [Commented] (FLINK-34273) git fetch fails

2024-02-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821013#comment-17821013 ] Matthias Pohl commented on FLINK-34273: ---

[jira] [Updated] (FLINK-29114) TableSourceITCase#testTableHintWithLogicalTableScanReuse sometimes fails with result mismatch

2024-02-26 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-29114: -- Attachment: image-2024-02-27-15-32-48-317.png >

[jira] [Commented] (FLINK-29114) TableSourceITCase#testTableHintWithLogicalTableScanReuse sometimes fails with result mismatch

2024-02-26 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821009#comment-17821009 ] Jane Chan commented on FLINK-29114: --- Hi [~mapohl], sorry for the late reply due to a tight time

[jira] [Updated] (FLINK-29114) TableSourceITCase#testTableHintWithLogicalTableScanReuse sometimes fails with result mismatch

2024-02-26 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-29114: -- Attachment: image-2024-02-27-15-26-07-657.png >

[jira] [Updated] (FLINK-29114) TableSourceITCase#testTableHintWithLogicalTableScanReuse sometimes fails with result mismatch

2024-02-26 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-29114: -- Attachment: image-2024-02-27-15-23-49-494.png >

[jira] [Updated] (FLINK-34522) StateTtlConfig#cleanupInRocksdbCompactFilter still uses the deprecated Time class

2024-02-26 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-34522: Description: FLINK-32570 deprecated the Time class and refactor all Public or PublicEvolving apis to use

[jira] [Updated] (FLINK-34522) StateTtlConfig#cleanupInRocksdbCompactFilter still uses the deprecated Time class

2024-02-26 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-34522: Description: FLINK-32570 deprecated the Time class and refactor all Public or PublicEvolving apis to use

[jira] [Commented] (FLINK-34524) Scale down JobManager deployment to 0 before deletion

2024-02-26 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820991#comment-17820991 ] Gyula Fora commented on FLINK-34524: cc [~mateczagany]  > Scale down JobManager deployment to 0

[jira] [Created] (FLINK-34524) Scale down JobManager deployment to 0 before deletion

2024-02-26 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-34524: -- Summary: Scale down JobManager deployment to 0 before deletion Key: FLINK-34524 URL: https://issues.apache.org/jira/browse/FLINK-34524 Project: Flink Issue

[jira] [Commented] (FLINK-18476) PythonEnvUtilsTest#testStartPythonProcess fails

2024-02-26 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820987#comment-17820987 ] lincoln lee commented on FLINK-18476: -

[jira] [Updated] (FLINK-34523) org.apache.maven.surefire:surefire-shared-utils:jar:3.2.2 couldn't be downloaded

2024-02-26 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-34523: Description:

[jira] [Updated] (FLINK-34523) org.apache.maven.surefire:surefire-shared-utils:jar:3.2.2 couldn't be downloaded

2024-02-26 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-34523: Reporter: Lincoln Lee (was: Matthias Pohl) >

[jira] [Created] (FLINK-34523) org.apache.maven.surefire:surefire-shared-utils:jar:3.2.2 couldn't be downloaded

2024-02-26 Thread lincoln lee (Jira)
lincoln lee created FLINK-34523: --- Summary: org.apache.maven.surefire:surefire-shared-utils:jar:3.2.2 couldn't be downloaded Key: FLINK-34523 URL: https://issues.apache.org/jira/browse/FLINK-34523

Re: [PR] [DRAFT][BP-1.19][FLINK-34516] Move CheckpointingMode to flink-core [flink]

2024-02-26 Thread via GitHub
flinkbot commented on PR #24389: URL: https://github.com/apache/flink/pull/24389#issuecomment-1965877089 ## CI report: * 49f84f42f69bb8b5d033a9695278319102897ff8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-29114) TableSourceITCase#testTableHintWithLogicalTableScanReuse sometimes fails with result mismatch

2024-02-26 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820985#comment-17820985 ] lincoln lee commented on FLINK-29114: -

[PR] [DRAFT][BP-1.19][FLINK-34516] Move CheckpointingMode to flink-core [flink]

2024-02-26 Thread via GitHub
Zakelly opened a new pull request, #24389: URL: https://github.com/apache/flink/pull/24389 # Do not merge this for now ## What is the purpose of the change In FLIP-406, we want to merge all options in `ExecutionCheckpointingOptions` to `CheckpointingOptions`, which depends on the

Re: [PR] [FLINK-34522][core] Changing the Time to Duration for StateTtlConfig.Builder.cleanupInRocksdbCompactFilter [flink]

2024-02-26 Thread via GitHub
flinkbot commented on PR #24388: URL: https://github.com/apache/flink/pull/24388#issuecomment-1965866595 ## CI report: * 013012c9c2223fa7241918ccbc7a5a13d1aacf0d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-34522][core] Changing the Time to Duration for StateTtlConfig.Builder.cleanupInRocksdbCompactFilter [flink]

2024-02-26 Thread via GitHub
1996fanrui opened a new pull request, #24388: URL: https://github.com/apache/flink/pull/24388 ## What is the purpose of the change [FLINK-32570](https://issues.apache.org/jira/browse/FLINK-32570) deprecated the Time class and refactor all Public or PublicEvolving apis to use the

[jira] [Updated] (FLINK-34522) StateTtlConfig#cleanupInRocksdbCompactFilter still uses the deprecated Time class

2024-02-26 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-34522: Summary: StateTtlConfig#cleanupInRocksdbCompactFilter still uses the deprecated Time class (was:

Re: [PR] [BP-1.17][FLINK-34518][runtime] Fixes AdaptiveScheduler#suspend bug when the job is suspended during Restarting phase [flink]

2024-02-26 Thread via GitHub
XComp commented on PR #24385: URL: https://github.com/apache/flink/pull/24385#issuecomment-1965838205 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-34522) StateTtlConfig#cleanupInRocksdbCompactFilter still uses the deprecated Time

2024-02-26 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-34522: Summary: StateTtlConfig#cleanupInRocksdbCompactFilter still uses the deprecated Time (was:

Re: [PR] [BP-1.18][FLINK-34518][runtime] Fixes AdaptiveScheduler#suspend bug when the job is suspended during Restarting phase [flink]

2024-02-26 Thread via GitHub
XComp commented on PR #24384: URL: https://github.com/apache/flink/pull/24384#issuecomment-1965830953 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Closed] (FLINK-34351) Release Testing: Verify FLINK-33397 Support Configuring Different State TTLs using SQL Hint

2024-02-26 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-34351. --- Resolution: Fixed [~liyubin117] Thanks! > Release Testing: Verify FLINK-33397 Support Configuring

[jira] [Commented] (FLINK-34351) Release Testing: Verify FLINK-33397 Support Configuring Different State TTLs using SQL Hint

2024-02-26 Thread Yubin Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820968#comment-17820968 ] Yubin Li commented on FLINK-34351: -- [~lincoln.86xy] There is no problem about the test :) > Release

[jira] [Commented] (FLINK-34351) Release Testing: Verify FLINK-33397 Support Configuring Different State TTLs using SQL Hint

2024-02-26 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820965#comment-17820965 ] lincoln lee commented on FLINK-34351: - [~liyubin117] Thanks for your testing! As you posted above,

[jira] [Closed] (FLINK-34354) Release Testing: Verify FLINK-34037 Improve Serialization Configuration and Usage in Flink

2024-02-26 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-34354. --- Resolution: Fixed [~Zakelly]Thanks for your testing! > Release Testing: Verify FLINK-34037 Improve

Re: [PR] [FLINK-34522][core] Changing the Time to Duration for StateTtlConfig.Builder.cleanupInRocksdbCompactFilter [flink]

2024-02-26 Thread via GitHub
flinkbot commented on PR #24387: URL: https://github.com/apache/flink/pull/24387#issuecomment-1965813289 ## CI report: * 791a396f3135b3951c7e178af8b449d7aa4c764f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34351) Release Testing: Verify FLINK-33397 Support Configuring Different State TTLs using SQL Hint

2024-02-26 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-34351: Description: This describes how to verify FLINK-33397: Support Configuring Different State TTLs

[jira] [Updated] (FLINK-34522) StateTtlConfig#cleanupInRocksdbCompactFilter still use the deprecated Time

2024-02-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34522: --- Labels: pull-request-available (was: ) > StateTtlConfig#cleanupInRocksdbCompactFilter

[PR] [FLINK-34522][core] Changing the Time to Duration for StateTtlConfig.Builder.cleanupInRocksdbCompactFilter [flink]

2024-02-26 Thread via GitHub
1996fanrui opened a new pull request, #24387: URL: https://github.com/apache/flink/pull/24387 ## What is the purpose of the change [FLINK-32570](https://issues.apache.org/jira/browse/FLINK-32570) deprecated the Time class and refactor all Public or PublicEvolving apis to use the

[jira] [Created] (FLINK-34522) StateTtlConfig#cleanupInRocksdbCompactFilter still use the deprecated Time

2024-02-26 Thread Rui Fan (Jira)
Rui Fan created FLINK-34522: --- Summary: StateTtlConfig#cleanupInRocksdbCompactFilter still use the deprecated Time Key: FLINK-34522 URL: https://issues.apache.org/jira/browse/FLINK-34522 Project: Flink

Re: [PR] [hotfix][runtime] Remove unneeded requestTaskManagerFileUploadByName [flink]

2024-02-26 Thread via GitHub
flinkbot commented on PR #24386: URL: https://github.com/apache/flink/pull/24386#issuecomment-1965794105 ## CI report: * 8e7d875175306a508fc856990b463a2fdac23960 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33668] Decoupling Shuffle network memory and job topology [flink]

2024-02-26 Thread via GitHub
reswqa commented on code in PR #23851: URL: https://github.com/apache/flink/pull/23851#discussion_r1503610332 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/table/LegacyTableSinkITCase.scala: ## @@ -277,6 +277,7 @@ class

[jira] [Commented] (FLINK-34517) environment configs ignored when calling procedure operation

2024-02-26 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820947#comment-17820947 ] xuyang commented on FLINK-34517: Hi, [~JustinLee] . Do you mean there are some configs lost when

Re: [PR] [FLINK-34050][state] Clean up useless files in deleted ranges during rescaling for RocksdbStateBackend [flink]

2024-02-26 Thread via GitHub
ljz2051 commented on PR #24367: URL: https://github.com/apache/flink/pull/24367#issuecomment-1965740854 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Resolved] (FLINK-34284) Submit Software License Grant to ASF

2024-02-26 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu resolved FLINK-34284. Resolution: Resolved Ververica has signed the Software License Grant and submitted to

Re: [PR] [FLINK-33936][table] Outputting Identical Results in Mini-Batch Aggregation with Set TTL [flink]

2024-02-26 Thread via GitHub
xuyangzhong commented on code in PR #24290: URL: https://github.com/apache/flink/pull/24290#discussion_r1503596812 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/harness/GroupAggregateHarnessTest.scala: ## @@ -220,6 +225,63 @@ class

[jira] [Created] (FLINK-34521) Using the Duration instead of the deprecated Time classes

2024-02-26 Thread Rui Fan (Jira)
Rui Fan created FLINK-34521: --- Summary: Using the Duration instead of the deprecated Time classes Key: FLINK-34521 URL: https://issues.apache.org/jira/browse/FLINK-34521 Project: Flink Issue Type:

[jira] [Closed] (FLINK-34378) Minibatch join disrupted the original order of input records

2024-02-26 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuyang closed FLINK-34378. -- Resolution: Not A Problem > Minibatch join disrupted the original order of input records >

[jira] [Commented] (FLINK-34378) Minibatch join disrupted the original order of input records

2024-02-26 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820924#comment-17820924 ] xuyang commented on FLINK-34378: Thanks for your answer, [~xu_shuai_]. That sounds good to me. I'll

[jira] [Created] (FLINK-34520) Confusing MIT language in the NOTICE file

2024-02-26 Thread Henri Yandell (Jira)
Henri Yandell created FLINK-34520: - Summary: Confusing MIT language in the NOTICE file Key: FLINK-34520 URL: https://issues.apache.org/jira/browse/FLINK-34520 Project: Flink Issue Type: Bug

Re: [PR] [FLINK-34518][runtime] Fixes AdaptiveScheduler#suspend bug when the job is suspended during Restarting phase [flink]

2024-02-26 Thread via GitHub
XComp commented on code in PR #24382: URL: https://github.com/apache/flink/pull/24382#discussion_r1502888533 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java: ## @@ -1031,34 +1028,18 @@ public void suspend(Throwable

Re: [PR] [FLINK-34363] Set artifact version to $project_version if $FLINK_VERSION is not set [flink-connector-shared-utils]

2024-02-26 Thread via GitHub
zentol commented on code in PR #38: URL: https://github.com/apache/flink-connector-shared-utils/pull/38#discussion_r1502941159 ## _utils.sh: ## @@ -68,4 +68,15 @@ function set_pom_version { new_version=$1 ${MVN} org.codehaus.mojo:versions-maven-plugin:2.8.1:set

Re: [PR] [BP-1.17][FLINK-34518][runtime] Fixes AdaptiveScheduler#suspend bug when the job is suspended during Restarting phase [flink]

2024-02-26 Thread via GitHub
flinkbot commented on PR #24385: URL: https://github.com/apache/flink/pull/24385#issuecomment-1964536631 ## CI report: * 4959e98a0962fb60ec35ebaf3401f91ad9678302 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [BP-1.18][FLINK-34518][runtime] Fixes AdaptiveScheduler#suspend bug when the job is suspended during Restarting phase [flink]

2024-02-26 Thread via GitHub
flinkbot commented on PR #24384: URL: https://github.com/apache/flink/pull/24384#issuecomment-1964536181 ## CI report: * 45f7e60bd30f933d74c46a711fa37d8a1c5bbeee UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [BP-1.19][FLINK-34518][runtime] Fixes AdaptiveScheduler#suspend bug when the job is suspended during Restarting phase [flink]

2024-02-26 Thread via GitHub
flinkbot commented on PR #24383: URL: https://github.com/apache/flink/pull/24383#issuecomment-1964535435 ## CI report: * c3afce27305337d176b2cce47358c590787823ad UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34518) Adaptive Scheduler restores from empty state if JM fails during restarting state

2024-02-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34518: -- Affects Version/s: 1.17.2 1.19.0 1.20.0 >

[jira] [Assigned] (FLINK-34518) Adaptive Scheduler restores from empty state if JM fails during restarting state

2024-02-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-34518: - Assignee: Matthias Pohl > Adaptive Scheduler restores from empty state if JM fails

Re: [PR] [FLINK-34518][runtime] Fixes AdaptiveScheduler#suspend bug when the job is suspended during Restarting phase [flink]

2024-02-26 Thread via GitHub
XComp commented on code in PR #24382: URL: https://github.com/apache/flink/pull/24382#discussion_r1502888533 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java: ## @@ -1031,34 +1028,18 @@ public void suspend(Throwable

Re: [PR] [FLINK-34518][runtime] Fixes AdaptiveScheduler#suspend bug when the job is suspended during Restarting phase [flink]

2024-02-26 Thread via GitHub
XComp commented on code in PR #24382: URL: https://github.com/apache/flink/pull/24382#discussion_r1502888533 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java: ## @@ -1031,34 +1028,18 @@ public void suspend(Throwable

Re: [PR] [FLINK-34518][runtime] Fixes AdaptiveScheduler#suspend bug when the job is suspended during Restarting phase [flink]

2024-02-26 Thread via GitHub
zentol commented on code in PR #24382: URL: https://github.com/apache/flink/pull/24382#discussion_r1502844838 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java: ## @@ -1031,34 +1028,18 @@ public void suspend(Throwable

Re: [PR] [FLINK-34518][runtime] Fixes AdaptiveScheduler#suspend bug when the job is suspended during Restarting phase [flink]

2024-02-26 Thread via GitHub
zentol commented on code in PR #24382: URL: https://github.com/apache/flink/pull/24382#discussion_r1502844838 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java: ## @@ -1031,34 +1028,18 @@ public void suspend(Throwable

Re: [PR] [FLINK-34454] Introduce StateRecoveryOptions in flink-core and Rename options [flink]

2024-02-26 Thread via GitHub
Zakelly commented on PR #24368: URL: https://github.com/apache/flink/pull/24368#issuecomment-1964472367 > Thanks for the update. Overall LGTM. Just minor suggestions: > > 1. Update related docs from 'Restore Mode' to 'Claim Mode' to provide clearer guidance for users. > 2.

Re: [PR] [FLINK-34518][runtime] Fixes AdaptiveScheduler#suspend bug when the job is suspended during Restarting phase [flink]

2024-02-26 Thread via GitHub
XComp commented on code in PR #24382: URL: https://github.com/apache/flink/pull/24382#discussion_r1502831868 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java: ## @@ -1031,34 +1028,18 @@ public void suspend(Throwable

Re: [PR] [FLINK-34518][runtime] Fixes AdaptiveScheduler#suspend bug when the job is suspended during Restarting phase [flink]

2024-02-26 Thread via GitHub
XComp commented on code in PR #24382: URL: https://github.com/apache/flink/pull/24382#discussion_r1502831868 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java: ## @@ -1031,34 +1028,18 @@ public void suspend(Throwable

Re: [PR] [FLINK-34518][runtime] Fixes AdaptiveScheduler#suspend bug when the job is suspended during Restarting phase [flink]

2024-02-26 Thread via GitHub
XComp commented on code in PR #24382: URL: https://github.com/apache/flink/pull/24382#discussion_r1502820181 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java: ## @@ -1031,34 +1028,18 @@ public void suspend(Throwable

Re: [PR] [FLINK-34518][runtime] Fixes AdaptiveScheduler#suspend bug when the job is suspended during Restarting phase [flink]

2024-02-26 Thread via GitHub
XComp commented on code in PR #24382: URL: https://github.com/apache/flink/pull/24382#discussion_r1502820181 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java: ## @@ -1031,34 +1028,18 @@ public void suspend(Throwable

Re: [PR] [FLINK-34518][runtime] Fixes AdaptiveScheduler#suspend bug when the job is suspended during Restarting phase [flink]

2024-02-26 Thread via GitHub
XComp commented on code in PR #24382: URL: https://github.com/apache/flink/pull/24382#discussion_r1502820181 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java: ## @@ -1031,34 +1028,18 @@ public void suspend(Throwable

Re: [PR] [FLINK-34518][runtime] Fixes AdaptiveScheduler#suspend bug when the job is suspended during Restarting phase [flink]

2024-02-26 Thread via GitHub
zentol commented on code in PR #24382: URL: https://github.com/apache/flink/pull/24382#discussion_r1502810463 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java: ## @@ -1031,34 +1028,18 @@ public void suspend(Throwable

Re: [PR] [hotfix] [docs] Fix PunctuatedAssigner Scala example [flink]

2024-02-26 Thread via GitHub
HubertChen closed pull request #15917: [hotfix] [docs] Fix PunctuatedAssigner Scala example URL: https://github.com/apache/flink/pull/15917 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Resolved] (FLINK-34504) Avoid the parallelism adjustment when the upstream shuffle type doesn't have keyBy

2024-02-26 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-34504. - Resolution: Fixed > Avoid the parallelism adjustment when the upstream shuffle type doesn't have >

[jira] [Commented] (FLINK-34504) Avoid the parallelism adjustment when the upstream shuffle type doesn't have keyBy

2024-02-26 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820708#comment-17820708 ] Rui Fan commented on FLINK-34504: - Merged to main(1.8.0) via: f4b04ec5f47358829ee279806d2f74b1f1641ee2

Re: [PR] [FLINK-34504][autoscaler] Avoid the parallelism adjustment when the upstream shuffle type doesn't have keyBy [flink-kubernetes-operator]

2024-02-26 Thread via GitHub
1996fanrui merged PR #783: URL: https://github.com/apache/flink-kubernetes-operator/pull/783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-34518][runtime] Fixes AdaptiveScheduler#suspend bug when the job is suspended during Restarting phase [flink]

2024-02-26 Thread via GitHub
flinkbot commented on PR #24382: URL: https://github.com/apache/flink/pull/24382#issuecomment-1964185571 ## CI report: * 8b23a56194f681e62892f32d64aded5c7b42162f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34518) Adaptive Scheduler restores from empty state if JM fails during restarting state

2024-02-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34518: --- Labels: pull-request-available (was: ) > Adaptive Scheduler restores from empty state if

[PR] [FLINK-34518][runtime] Fixes AdaptiveScheduler#suspend bug when the job is suspended during Restarting phase [flink]

2024-02-26 Thread via GitHub
XComp opened a new pull request, #24382: URL: https://github.com/apache/flink/pull/24382 ## What is the purpose of the change See [comment in

[jira] [Updated] (FLINK-34517) environment configs ignored when calling procedure operation

2024-02-26 Thread JustinLee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] JustinLee updated FLINK-34517: -- Description: when calling procedure operation in Flink SQL, the ProcedureContext only contains the

Re: [PR] [DRAFT][FLINK-34516] Move CheckpointingMode to flink-core [flink]

2024-02-26 Thread via GitHub
flinkbot commented on PR #24381: URL: https://github.com/apache/flink/pull/24381#issuecomment-1964137824 ## CI report: * 9bdd237d0322df8853f1b9e6ae658f77b9175237 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34516) Move CheckpointingMode to flink-core

2024-02-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34516: --- Labels: pull-request-available (was: ) > Move CheckpointingMode to flink-core >

[PR] [DRAFT][FLINK-34516] Move CheckpointingMode to flink-core [flink]

2024-02-26 Thread via GitHub
Zakelly opened a new pull request, #24381: URL: https://github.com/apache/flink/pull/24381 ## Do not merge this for now ## What is the purpose of the change In FLIP-406, we want to merge all options in `ExecutionCheckpointingOptions` to `CheckpointingOptions`, which depends on the

Re: [PR] [FLINK-34050][state] Clean up useless files in deleted ranges during rescaling for RocksdbStateBackend [flink]

2024-02-26 Thread via GitHub
ljz2051 commented on code in PR #24367: URL: https://github.com/apache/flink/pull/24367#discussion_r1502571621 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBIncrementalCheckpointUtils.java: ## @@ -153,13 +154,14

[jira] [Comment Edited] (FLINK-34518) Adaptive Scheduler restores from empty state if JM fails during restarting state

2024-02-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820679#comment-17820679 ] Matthias Pohl edited comment on FLINK-34518 at 2/26/24 12:38 PM: -

[jira] [Comment Edited] (FLINK-34518) Adaptive Scheduler restores from empty state if JM fails during restarting state

2024-02-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820679#comment-17820679 ] Matthias Pohl edited comment on FLINK-34518 at 2/26/24 12:29 PM: -

[jira] [Comment Edited] (FLINK-34518) Adaptive Scheduler restores from empty state if JM fails during restarting state

2024-02-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820679#comment-17820679 ] Matthias Pohl edited comment on FLINK-34518 at 2/26/24 12:18 PM: -

Re: [PR] [FLINK-20090][rest] Expose slot sharing group info in REST API [flink]

2024-02-26 Thread via GitHub
flinkbot commented on PR #24380: URL: https://github.com/apache/flink/pull/24380#issuecomment-1964010866 ## CI report: * 2ad534019df4fbcdf6a1c81241d1ef0a4a147137 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34371][runtime] Support EndOfStreamTrigger and isOutputOnlyAfterEndOfStream operator attribute to optimize task deployment [flink]

2024-02-26 Thread via GitHub
yunfengzhou-hub commented on code in PR #24272: URL: https://github.com/apache/flink/pull/24272#discussion_r1502520887 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointFailureReason.java: ## @@ -61,6 +61,8 @@ public enum CheckpointFailureReason {

[jira] [Updated] (FLINK-20090) Expose SlotId / SlotSharingGroup in Rest API

2024-02-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-20090: --- Labels: pull-request-available (was: ) > Expose SlotId / SlotSharingGroup in Rest API >

[jira] [Created] (FLINK-34519) Refine checkpoint scheduling and canceling logic

2024-02-26 Thread Yunfeng Zhou (Jira)
Yunfeng Zhou created FLINK-34519: Summary: Refine checkpoint scheduling and canceling logic Key: FLINK-34519 URL: https://issues.apache.org/jira/browse/FLINK-34519 Project: Flink Issue Type:

  1   2   >