Re: [PR] [FLINK-35242] Optimize schema evolution & add SE IT cases [flink-cdc]

2024-05-24 Thread via GitHub
hk-lrzy commented on code in PR #3339: URL: https://github.com/apache/flink-cdc/pull/3339#discussion_r1614307385 ## flink-cdc-composer/src/main/java/org/apache/flink/cdc/composer/flink/translator/SchemaOperatorTranslator.java: ## @@ -58,12 +59,18 @@ public DataStream translate(

Re: [PR] [FLINK-35242] Optimize schema evolution & add SE IT cases [flink-cdc]

2024-05-24 Thread via GitHub
hk-lrzy commented on code in PR #3339: URL: https://github.com/apache/flink-cdc/pull/3339#discussion_r1612861870 ## flink-cdc-composer/src/main/java/org/apache/flink/cdc/composer/flink/translator/SchemaOperatorTranslator.java: ## @@ -58,12 +59,18 @@ public DataStream translate(

[jira] [Created] (FLINK-35449) MySQL CDC Flink SQL column names are case-sensitive

2024-05-24 Thread linweijiang (Jira)
linweijiang created FLINK-35449: --- Summary: MySQL CDC Flink SQL column names are case-sensitive Key: FLINK-35449 URL: https://issues.apache.org/jira/browse/FLINK-35449 Project: Flink Issue

Re: [PR] [FLINK-33892][runtime] Support Job Recovery from JobMaster Failures for Batch Jobs. [flink]

2024-05-24 Thread via GitHub
JunRuiLee commented on PR #24771: URL: https://github.com/apache/flink/pull/24771#issuecomment-2130666752 Thanks @zhuzhurk for the thorough review. I have refactored the BatchJobRecoveryTest and JMFailoverITCase based on your comments. PTAL. -- This is an automated message from

Re: [PR] [FLINK-35424] Elasticsearch connector 8 supports SSL context [flink-connector-elasticsearch]

2024-05-24 Thread via GitHub
liuml07 commented on code in PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1614242366 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8TestUtils.java: ## @@ -0,0 +1,69 @@

Re: [PR] [FLINK-35424] Elasticsearch connector 8 supports SSL context [flink-connector-elasticsearch]

2024-05-24 Thread via GitHub
reta commented on code in PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1614235030 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8TestUtils.java: ## @@ -0,0 +1,69 @@

Re: [PR] [FLINK-35424] Elasticsearch connector 8 supports SSL context [flink-connector-elasticsearch]

2024-05-24 Thread via GitHub
liuml07 commented on code in PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1614194871 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8TestUtils.java: ## @@ -0,0 +1,69 @@

[jira] [Comment Edited] (FLINK-35285) Autoscaler key group optimization can interfere with scale-down.max-factor

2024-05-24 Thread Trystan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849352#comment-17849352 ] Trystan edited comment on FLINK-35285 at 5/24/24 8:41 PM: -- [~gyfora] is there

Re: [PR] [FLINK-33759] [flink-parquet] Add support for nested array with row/map/array type [flink]

2024-05-24 Thread via GitHub
ViktorCosenza commented on PR #24795: URL: https://github.com/apache/flink/pull/24795#issuecomment-2130263489 > @ViktorCosenza did you rebase? Yes, i did an interactive rebase and then force-pushed the squashed commits -- This is an automated message from the Apache Git Service. To

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-24 Thread via GitHub
dannycranmer commented on code in PR #24839: URL: https://github.com/apache/flink/pull/24839#discussion_r1613883830 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBase.java: ## @@ -54,6 +54,8 @@ public abstract class

Re: [PR] [FLINK-30687][table] Support pushdown for aggregate filters [flink]

2024-05-24 Thread via GitHub
jeyhunkarimov commented on PR #24660: URL: https://github.com/apache/flink/pull/24660#issuecomment-2130159573 Hi @JingGe , I added support for multiple aggregates with the same filter (to push down their filters). Could you please check the PR in your available time? Thanks! -- This is

Re: [PR] [FLINK-33759] [flink-parquet] Add support for nested array with row/map/array type [flink]

2024-05-24 Thread via GitHub
JingGe commented on PR #24795: URL: https://github.com/apache/flink/pull/24795#issuecomment-2130068966 @ViktorCosenza did you rebase? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33759] [flink-parquet] Add support for nested array with row/map/array type [flink]

2024-05-24 Thread via GitHub
JingGe commented on PR #24795: URL: https://github.com/apache/flink/pull/24795#issuecomment-2130067792 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Comment Edited] (FLINK-35285) Autoscaler key group optimization can interfere with scale-down.max-factor

2024-05-24 Thread Trystan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849352#comment-17849352 ] Trystan edited comment on FLINK-35285 at 5/24/24 5:34 PM: -- [~gyfora] is there

[jira] [Commented] (FLINK-35285) Autoscaler key group optimization can interfere with scale-down.max-factor

2024-05-24 Thread Trystan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849352#comment-17849352 ] Trystan commented on FLINK-35285: - [~gyfora] is there maybe another setting that can help tune this? At

Re: [PR] [FLINK-31223][sqlgateway] Introduce getFlinkConfigurationOptions to [flink]

2024-05-24 Thread via GitHub
davidradl commented on PR #24741: URL: https://github.com/apache/flink/pull/24741#issuecomment-2130035074 @reswqa all clean now. I did not backport the 1.19 change at that method was not there at 1.18. I was hoping that I could backport commit 06b3708 which introduces the getMap change to

Re: [PR] [FLINK-35424] Elasticsearch connector 8 supports SSL context [flink-connector-elasticsearch]

2024-05-24 Thread via GitHub
liuml07 commented on code in PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1613758123 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8TestUtils.java: ## @@ -0,0 +1,69 @@

Re: [PR] [FLINK-35424] Elasticsearch connector 8 supports SSL context [flink-connector-elasticsearch]

2024-05-24 Thread via GitHub
reta commented on code in PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1613717772 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8TestUtils.java: ## @@ -0,0 +1,69 @@

Re: [PR] [FLINK-35424][connectors/elasticsearch] Elasticsearch connector 8 supports SSL context [flink-connector-elasticsearch]

2024-05-24 Thread via GitHub
liuml07 commented on code in PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1613711076 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8TestUtils.java: ## @@ -0,0 +1,69 @@

[jira] [Commented] (FLINK-34333) Fix FLINK-34007 LeaderElector bug in 1.18

2024-05-24 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-34333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849337#comment-17849337 ] Pedro Mázala commented on FLINK-34333: -- I've just done it. Thank you for porting it back > Fix

Re: [PR] [FLINK-35446] Fix NPE when disabling checkpoint file merging but restore from merged files [flink]

2024-05-24 Thread via GitHub
flinkbot commented on PR #24840: URL: https://github.com/apache/flink/pull/24840#issuecomment-2129877895 ## CI report: * 5a78e68711f02ccaeb069376270649229d8c53c8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35316][tests] Run CDC E2e test with Flink 1.19 [flink-cdc]

2024-05-24 Thread via GitHub
yuxiqian closed pull request #3305: [FLINK-35316][tests] Run CDC E2e test with Flink 1.19 URL: https://github.com/apache/flink-cdc/pull/3305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-35316][tests] Run CDC E2e test with Flink 1.19 [flink-cdc]

2024-05-24 Thread via GitHub
yuxiqian commented on PR #3305: URL: https://github.com/apache/flink-cdc/pull/3305#issuecomment-2129877441 Addressed in #3348. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-35424][connectors/elasticsearch] Elasticsearch connector 8 supports SSL context [flink-connector-elasticsearch]

2024-05-24 Thread via GitHub
liuml07 commented on code in PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1613694681 ## flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8AsyncSinkBuilder.java: ## @@ -100,16

[jira] [Commented] (FLINK-35411) Optimize wait logic in draining of async state requests

2024-05-24 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849336#comment-17849336 ] Zakelly Lan commented on FLINK-35411: - [~spoon-lz] sure, will do. Thanks for your volunteering. >

[jira] [Commented] (FLINK-35355) Async aggregating state

2024-05-24 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849335#comment-17849335 ] Zakelly Lan commented on FLINK-35355: - Merged into master via

[jira] [Resolved] (FLINK-35355) Async aggregating state

2024-05-24 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan resolved FLINK-35355. - Fix Version/s: 2.0.0 Assignee: Jie Pu Resolution: Fixed > Async aggregating

Re: [PR] [FLINK-35355][State] Internal async aggregating state and corresponding state descriptor [flink]

2024-05-24 Thread via GitHub
Zakelly closed pull request #24810: [FLINK-35355][State] Internal async aggregating state and corresponding state descriptor URL: https://github.com/apache/flink/pull/24810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-35446] Fix NPE when disabling checkpoint file merging but restore from merged files [flink]

2024-05-24 Thread via GitHub
Zakelly commented on PR #24840: URL: https://github.com/apache/flink/pull/24840#issuecomment-2129858482 @fredia @ljz2051 Would you please take a look? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-35355][State] Internal async aggregating state and corresponding state descriptor [flink]

2024-05-24 Thread via GitHub
Zakelly commented on PR #24810: URL: https://github.com/apache/flink/pull/24810#issuecomment-2129836350 CI green, merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-35446) FileMergingSnapshotManagerBase throws a NullPointerException

2024-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35446: --- Labels: pull-request-available test-stability (was: test-stability) >

[PR] [FLINK-35446] Fix NPE when disabling checkpoint file merging but restore from merged files [flink]

2024-05-24 Thread via GitHub
Zakelly opened a new pull request, #24840: URL: https://github.com/apache/flink/pull/24840 ## What is the purpose of the change See FLINK-35446. It seems the file merging is disabled, thus the `FileMergingSnapshotManagerBase#initFileSystem` is never called. And at this time if we

[jira] [Commented] (FLINK-35446) FileMergingSnapshotManagerBase throws a NullPointerException

2024-05-24 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849323#comment-17849323 ] Zakelly Lan commented on FLINK-35446: - [~rskraba] Thanks for letting me know! I'll fix this. >

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-05-24 Thread via GitHub
caicancai commented on code in PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1613512120 ## docs/content/docs/custom-resource/pod-template.md: ## @@ -93,16 +90,18 @@ spec: ``` {{< hint info >}} -When using the operator with Flink

Re: [PR] [FLINK-35424][connectors/elasticsearch] Elasticsearch connector 8 supports SSL context [flink-connector-elasticsearch]

2024-05-24 Thread via GitHub
reta commented on code in PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1613490458 ## flink-connector-elasticsearch8/src/main/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8AsyncSinkBuilder.java: ## @@ -100,16

Re: [PR] [FLINK-35424][connectors/elasticsearch] Elasticsearch connector 8 supports SSL context [flink-connector-elasticsearch]

2024-05-24 Thread via GitHub
reta commented on code in PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1613488632 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8TestUtils.java: ## @@ -0,0 +1,69 @@

[jira] [Updated] (FLINK-35052) Webhook validator should reject unsupported Flink versions

2024-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35052: --- Labels: pull-request-available (was: ) > Webhook validator should reject unsupported Flink

[PR] [FLINK-35052] Reject unsupported versions in the webhook validator [flink-kubernetes-operator]

2024-05-24 Thread via GitHub
afedulov opened a new pull request, #831: URL: https://github.com/apache/flink-kubernetes-operator/pull/831 ## What is the purpose of the change The admission webhook currently does not verify if FlinkDeployment CR utilizes Flink versions that are not supported by the Operator. This

[PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-05-24 Thread via GitHub
caicancai opened a new pull request, #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830 ## What is the purpose of the change *(For example: This pull request adds a new feature to periodically create and maintain savepoints through the `FlinkDeployment`

[jira] [Updated] (FLINK-35448) Translate pod templates documentation into Chinese

2024-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35448: --- Labels: pull-request-available (was: ) > Translate pod templates documentation into

[jira] [Created] (FLINK-35448) Translate pod templates documentation into Chinese

2024-05-24 Thread Caican Cai (Jira)
Caican Cai created FLINK-35448: -- Summary: Translate pod templates documentation into Chinese Key: FLINK-35448 URL: https://issues.apache.org/jira/browse/FLINK-35448 Project: Flink Issue Type:

Re: [PR] [FLINK-34487][ci] Adds Python Wheels nightly GHA workflow [flink]

2024-05-24 Thread via GitHub
morazow commented on PR #24426: URL: https://github.com/apache/flink/pull/24426#issuecomment-2129494739 Test run built wheel artifacts: https://github.com/morazow/flink/actions/runs/9224143298 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [FLINK-33759] [flink-parquet] Add support for nested array with row/map/array type [flink]

2024-05-24 Thread via GitHub
ViktorCosenza commented on PR #24795: URL: https://github.com/apache/flink/pull/24795#issuecomment-2129462557 @JingGe Are you able to trigger the CI manually? I think I't wasnt triggered after the squash because no changes were detected. -- This is an automated message from the Apache

Re: [PR] [FLINK-34746] Switching to the Apache CDN for Dockerfile [flink-docker]

2024-05-24 Thread via GitHub
MartijnVisser commented on PR #190: URL: https://github.com/apache/flink-docker/pull/190#issuecomment-2129446485 @hlteoh37 Done, but I'm not sure if this actually needs to be backported to the other branches. @lincoln-lil do you know? -- This is an automated message from the Apache Git

Re: [PR] [FLINK-34487][ci] Adds Python Wheels nightly GHA workflow [flink]

2024-05-24 Thread via GitHub
morazow commented on PR #24426: URL: https://github.com/apache/flink/pull/24426#issuecomment-2129446733 Hey @XComp, @HuangXingBo , What do you think of the latest commit changes for migration? This way both Linux & MacOS platform use similar build system, we also don't depend

[jira] [Commented] (FLINK-35446) FileMergingSnapshotManagerBase throws a NullPointerException

2024-05-24 Thread Ryan Skraba (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849285#comment-17849285 ] Ryan Skraba commented on FLINK-35446: - [~lijinzhong] or [~zakelly] Do you think this needs a similar

[jira] [Commented] (FLINK-35446) FileMergingSnapshotManagerBase throws a NullPointerException

2024-05-24 Thread Ryan Skraba (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849284#comment-17849284 ] Ryan Skraba commented on FLINK-35446: - * 1.20 Java 11 / Test (module: tests)

[jira] [Commented] (FLINK-35342) MaterializedTableStatementITCase test can check for wrong status

2024-05-24 Thread Ryan Skraba (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849283#comment-17849283 ] Ryan Skraba commented on FLINK-35342: - * 1.20 AdaptiveScheduler / Test (module: table)

[jira] [Commented] (FLINK-28440) EventTimeWindowCheckpointingITCase failed with restore

2024-05-24 Thread Ryan Skraba (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849282#comment-17849282 ] Ryan Skraba commented on FLINK-28440: - * 1.19 Hadoop 3.1.3 / Test (module: tests)

Re: [PR] [FLINK-35129][cdc][postgres] Add checkpoint cycle option for commit offsets [flink-cdc]

2024-05-24 Thread via GitHub
morazow commented on code in PR #3349: URL: https://github.com/apache/flink-cdc/pull/3349#discussion_r1613394340 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-postgres-cdc/src/main/java/org/apache/flink/cdc/connectors/postgres/source/reader/PostgresSourceReader.java:

Re: [PR] [FLINK-31223][sqlgateway] Introduce getFlinkConfigurationOptions to [flink]

2024-05-24 Thread via GitHub
davidradl commented on code in PR #24741: URL: https://github.com/apache/flink/pull/24741#discussion_r1613388125 ## flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/SqlClientTestBase.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-33892][runtime] Support Job Recovery from JobMaster Failures for Batch Jobs. [flink]

2024-05-24 Thread via GitHub
zhuzhurk commented on code in PR #24771: URL: https://github.com/apache/flink/pull/24771#discussion_r1612989352 ## flink-tests/src/test/java/org/apache/flink/test/scheduling/JMFailoverITCase.java: ## @@ -532,9 +508,9 @@ private JobGraph

[jira] [Updated] (FLINK-35447) Flink CDC Document document file had removed but website can access

2024-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35447: --- Labels: pull-request-available (was: ) > Flink CDC Document document file had removed but

Re: [PR] [FLINK-35447][doc-ci] Flink CDC Document document file had removed but website can access [flink-cdc]

2024-05-24 Thread via GitHub
GOODBOY008 commented on PR #3362: URL: https://github.com/apache/flink-cdc/pull/3362#issuecomment-2129373300 @leonardBang PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] [FLINK-35447][doc-ci] Flink CDC Document document file had removed but website can access [flink-cdc]

2024-05-24 Thread via GitHub
GOODBOY008 opened a new pull request, #3362: URL: https://github.com/apache/flink-cdc/pull/3362 Solution: Deletes files from the destination directory that are not present in the source directory. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [FLINK-35434] Support pass exception in StateExecutor to runtime [flink]

2024-05-24 Thread via GitHub
zoltar9264 commented on code in PR #24833: URL: https://github.com/apache/flink/pull/24833#discussion_r1613094184 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStWriteBatchOperation.java: ## @@ -75,7 +74,10 @@ public

[jira] [Created] (FLINK-35447) Flink CDC Document document file had removed but website can access

2024-05-24 Thread Zhongqiang Gong (Jira)
Zhongqiang Gong created FLINK-35447: --- Summary: Flink CDC Document document file had removed but website can access Key: FLINK-35447 URL: https://issues.apache.org/jira/browse/FLINK-35447 Project:

[jira] [Commented] (FLINK-35435) [FLIP-451] Introduce timeout configuration to AsyncSink

2024-05-24 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849272#comment-17849272 ] Ahmed Hamdy commented on FLINK-35435: - [~danny.cranmer] Could you please take a look when you have

Re: [PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-24 Thread via GitHub
flinkbot commented on PR #24839: URL: https://github.com/apache/flink/pull/24839#issuecomment-2129354320 ## CI report: * 2b91a9c92af7d97d492a9c83d43d7c544f85d355 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-35435) [FLIP-451] Introduce timeout configuration to AsyncSink

2024-05-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35435: --- Labels: pull-request-available (was: ) > [FLIP-451] Introduce timeout configuration to

[PR] [FLINK-35435] Add timeout Configuration to Async Sink [flink]

2024-05-24 Thread via GitHub
vahmed-hamdy opened a new pull request, #24839: URL: https://github.com/apache/flink/pull/24839 ## What is the purpose of the change Implementation of [FLIP-451](https://cwiki.apache.org/confluence/display/FLINK/FLIP-451%3A+Introduce+timeout+configuration+to+AsyncSink+API)

[jira] [Created] (FLINK-35446) FileMergingSnapshotManagerBase throws a NullPointerException

2024-05-24 Thread Ryan Skraba (Jira)
Ryan Skraba created FLINK-35446: --- Summary: FileMergingSnapshotManagerBase throws a NullPointerException Key: FLINK-35446 URL: https://issues.apache.org/jira/browse/FLINK-35446 Project: Flink

[jira] [Updated] (FLINK-35445) Update Async Sink documentation for Timeout configuration

2024-05-24 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hamdy updated FLINK-35445: Parent: FLINK-35435 Issue Type: Sub-task (was: Improvement) > Update Async Sink

[jira] [Created] (FLINK-35445) Update Async Sink documentation for Timeout configuration

2024-05-24 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-35445: --- Summary: Update Async Sink documentation for Timeout configuration Key: FLINK-35445 URL: https://issues.apache.org/jira/browse/FLINK-35445 Project: Flink

[jira] [Commented] (FLINK-35435) [FLIP-451] Introduce timeout configuration to AsyncSink

2024-05-24 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849270#comment-17849270 ] Ahmed Hamdy commented on FLINK-35435: - h1. Non-Functional Backward compatibility To assure that we

Re: [PR] [FLINK-35415][base] Fix compatibility with Flink 1.19 [flink-cdc]

2024-05-24 Thread via GitHub
yuxiqian commented on PR #3348: URL: https://github.com/apache/flink-cdc/pull/3348#issuecomment-2129300597 Pushed another commit to resolve CI issue, could @leonardBang please re-trigger the CI? Thanks! -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-33892][runtime] Support Job Recovery from JobMaster Failures for Batch Jobs. [flink]

2024-05-24 Thread via GitHub
zhuzhurk commented on code in PR #24771: URL: https://github.com/apache/flink/pull/24771#discussion_r1612975806 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptivebatch/BatchJobRecoveryTest.java: ## @@ -0,0 +1,1217 @@ +/* + * Licensed to the Apache

[jira] [Updated] (FLINK-35435) [FLIP-451] Introduce timeout configuration to AsyncSink

2024-05-24 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hamdy updated FLINK-35435: Attachment: Screenshot 2024-05-24 at 11.06.30.png Screenshot 2024-05-24 at

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-05-24 Thread via GitHub
davidradl commented on code in PR #24618: URL: https://github.com/apache/flink/pull/24618#discussion_r1613290123 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/lineage/LineageGraph.java: ## @@ -20,13 +20,12 @@ package

Re: [PR] [FLINK-35406] Use inner serializer when casting RAW type to BINARY or… [flink]

2024-05-24 Thread via GitHub
twalthr commented on code in PR #24818: URL: https://github.com/apache/flink/pull/24818#discussion_r1613283206 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionMiscITCase.java: ## @@ -384,4 +410,15 @@ public static class

[jira] [Closed] (FLINK-34746) Switching to the Apache CDN for Dockerfile

2024-05-24 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-34746. -- Resolution: Fixed Fixed in apache/flink-docker@master

Re: [PR] [FLINK-34746] Switching to the Apache CDN for Dockerfile [flink-docker]

2024-05-24 Thread via GitHub
MartijnVisser merged PR #190: URL: https://github.com/apache/flink-docker/pull/190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-35326][hive] add lineage integration for Hive connector [flink]

2024-05-24 Thread via GitHub
davidradl commented on PR #24835: URL: https://github.com/apache/flink/pull/24835#issuecomment-2129222164 Shouldn't this pr go in after [https://github.com/apache/flink/pull/24618](https://github.com/apache/flink/pull/24618) -- This is an automated message from the Apache Git Service.

Re: [PR] [FLINK-34487][ci] Adds Python Wheels nightly GHA workflow [flink]

2024-05-24 Thread via GitHub
morazow commented on code in PR #24426: URL: https://github.com/apache/flink/pull/24426#discussion_r1613261308 ## .github/workflows/nightly.yml: ## @@ -94,3 +94,51 @@ jobs: s3_bucket: ${{ secrets.IT_CASE_S3_BUCKET }} s3_access_key: ${{

[jira] [Updated] (FLINK-35408) Add 30 min tolerance value when validating the time-zone setting

2024-05-24 Thread Xiao Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiao Huang updated FLINK-35408: --- Affects Version/s: cdc-3.1.0 > Add 30 min tolerance value when validating the time-zone setting >

[jira] [Updated] (FLINK-35409) Request more splits if all splits are filtered from addSplits method

2024-05-24 Thread Xiao Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiao Huang updated FLINK-35409: --- Fix Version/s: cdc-3.2.0 > Request more splits if all splits are filtered from addSplits method >

[jira] [Updated] (FLINK-35409) Request more splits if all splits are filtered from addSplits method

2024-05-24 Thread Xiao Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiao Huang updated FLINK-35409: --- Affects Version/s: cdc-3.1.0 > Request more splits if all splits are filtered from addSplits method

[jira] [Updated] (FLINK-35408) Add 30 min tolerance value when validating the time-zone setting

2024-05-24 Thread Xiao Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiao Huang updated FLINK-35408: --- Fix Version/s: cdc-3.2.0 > Add 30 min tolerance value when validating the time-zone setting >

[jira] [Updated] (FLINK-35409) Request more splits if all splits are filtered from addSplits method

2024-05-24 Thread Xiao Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiao Huang updated FLINK-35409: --- Issue Type: Bug (was: Improvement) > Request more splits if all splits are filtered from addSplits

[jira] [Updated] (FLINK-35409) Request more splits if all splits are filtered from addSplits method

2024-05-24 Thread Xiao Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiao Huang updated FLINK-35409: --- Description: Suppose this scenario: A job is still in the snapshot phase, and the remaining

Re: [PR] [FLINK-34487][ci] Adds Python Wheels nightly GHA workflow [flink]

2024-05-24 Thread via GitHub
morazow commented on code in PR #24426: URL: https://github.com/apache/flink/pull/24426#discussion_r1613227700 ## .github/workflows/nightly.yml: ## @@ -94,3 +94,51 @@ jobs: s3_bucket: ${{ secrets.IT_CASE_S3_BUCKET }} s3_access_key: ${{

[jira] [Updated] (FLINK-35408) Add 30 min tolerance value when validating the time-zone setting

2024-05-24 Thread Xiao Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiao Huang updated FLINK-35408: --- Description: Now, MySQL CDC connector will retrieve the offset seconds between the configured

Re: [PR] [FLINK-34487][ci] Adds Python Wheels nightly GHA workflow [flink]

2024-05-24 Thread via GitHub
morazow commented on code in PR #24426: URL: https://github.com/apache/flink/pull/24426#discussion_r1613226372 ## .github/workflows/nightly.yml: ## @@ -94,3 +94,51 @@ jobs: s3_bucket: ${{ secrets.IT_CASE_S3_BUCKET }} s3_access_key: ${{

[jira] [Updated] (FLINK-35408) Add 30 min tolerance value when validating the time-zone setting

2024-05-24 Thread Xiao Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiao Huang updated FLINK-35408: --- Description: Now, MySQL CDC connector will retrieve the number of seconds the database-configured

Re: [PR] [FLINK-34746] Switching to the Apache CDN for Dockerfile [flink-docker]

2024-05-24 Thread via GitHub
hlteoh37 commented on PR #190: URL: https://github.com/apache/flink-docker/pull/190#issuecomment-2129138391 @MartijnVisser can we merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Resolved] (FLINK-35298) Improve metric reporter logic

2024-05-24 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu resolved FLINK-35298. Resolution: Implemented via master: 8e8fd304afdd9668247a8869698e0949806cad7b > Improve metric

[jira] [Assigned] (FLINK-35298) Improve metric reporter logic

2024-05-24 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-35298: -- Assignee: Xiao Huang > Improve metric reporter logic > - > >

[jira] [Updated] (FLINK-35298) Improve metric reporter logic

2024-05-24 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-35298: --- Fix Version/s: cdc-3.2.0 > Improve metric reporter logic > - > >

[jira] [Updated] (FLINK-35298) Improve metric reporter logic

2024-05-24 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-35298: --- Affects Version/s: cdc-3.1.0 > Improve metric reporter logic > - > >

Re: [PR] [FLINK-35298][cdc] improve fetch delay metric reporter logic [flink-cdc]

2024-05-24 Thread via GitHub
leonardBang merged PR #3298: URL: https://github.com/apache/flink-cdc/pull/3298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-35300) Improve MySqlStreamingChangeEventSource to skip null events in event deserializer

2024-05-24 Thread Xiao Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiao Huang updated FLINK-35300: --- Description: As described in title. > Improve MySqlStreamingChangeEventSource to skip null events

Re: [PR] [FLINK-35129][cdc][postgres] Add checkpoint cycle option for commit offsets [flink-cdc]

2024-05-24 Thread via GitHub
leonardBang commented on code in PR #3349: URL: https://github.com/apache/flink-cdc/pull/3349#discussion_r1613201109 ##

[jira] [Updated] (FLINK-35297) Add validation for option connect.timeout

2024-05-24 Thread Xiao Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiao Huang updated FLINK-35297: --- Description: the value of option `connector.timeout` needs to be checked at compile time. > Add

Re: [PR] [FLINK-35129][cdc][postgres] Add checkpoint cycle option for commit offsets [flink-cdc]

2024-05-24 Thread via GitHub
loserwang1024 commented on code in PR #3349: URL: https://github.com/apache/flink-cdc/pull/3349#discussion_r1613185257 ##

Re: [PR] [FLINK-35129][cdc][postgres] Add checkpoint cycle option for commit offsets [flink-cdc]

2024-05-24 Thread via GitHub
loserwang1024 commented on code in PR #3349: URL: https://github.com/apache/flink-cdc/pull/3349#discussion_r1613185257 ##

[jira] [Updated] (FLINK-35298) Improve metric reporter logic

2024-05-24 Thread Xiao Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiao Huang updated FLINK-35298: --- Description: * In snapshot phase, set -1 as the value of currentFetchEventTimeLag metric. *

[jira] [Updated] (FLINK-35295) Improve jdbc connection pool initialization failure message

2024-05-24 Thread Xiao Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiao Huang updated FLINK-35295: --- Description: As described in ticket title. > Improve jdbc connection pool initialization failure

[jira] [Updated] (FLINK-35294) Use source config to check if the filter should be applied in timestamp starting mode

2024-05-24 Thread Xiao Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiao Huang updated FLINK-35294: --- Fix Version/s: cdc-3.2.0 > Use source config to check if the filter should be applied in timestamp

[jira] [Updated] (FLINK-35294) Use source config to check if the filter should be applied in timestamp starting mode

2024-05-24 Thread Xiao Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiao Huang updated FLINK-35294: --- Affects Version/s: cdc-3.1.0 > Use source config to check if the filter should be applied in

[jira] [Commented] (FLINK-34582) release build tools lost the newly added py3.11 packages for mac

2024-05-24 Thread Muhammet Orazov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849229#comment-17849229 ] Muhammet Orazov commented on FLINK-34582: - Ohh no. Yes indeed you are right [~mapohl] , thanks

  1   2   >