Github user vijikarthi closed the pull request at:
https://github.com/apache/flink/pull/2425
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user WangTaoTheTonic commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r106335560
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CookieHandler.java
---
@@ -0,0 +1,130 @@
+/**
+ * Licensed
Github user WangTaoTheTonic commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r106335331
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CookieHandler.java
---
@@ -0,0 +1,130 @@
+/**
+ * Licensed
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r86564819
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -57,24 +61,37 @@
// constructor in
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r86543115
--- Diff: docs/internals/flink_security.md ---
@@ -84,4 +86,79 @@ Security implementation details are based on https://github.com/apache/
##
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r86546406
--- Diff: docs/setup/config.md ---
@@ -125,6 +125,28 @@ Kerberos ticket renewal is abstracted and
automatically handled by the Hadoop/Ka
For
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r86544336
--- Diff: docs/setup/cli.md ---
@@ -217,6 +217,8 @@ Action "run" compiles and runs a program.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r86540839
--- Diff: docs/internals/flink_security.md ---
@@ -84,4 +86,79 @@ Security implementation details are based on https://github.com/apache/
##
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r86540198
--- Diff: docs/internals/flink_security.md ---
@@ -84,4 +86,79 @@ Security implementation details are based on https://github.com/apache/
##
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r86549853
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -715,6 +715,15 @@
/** Flag to enable/disable
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r86550641
--- Diff: flink-dist/src/main/resources/flink-conf.yaml ---
@@ -173,3 +174,13 @@ jobmanager.web.port: 8081
# Override below configuration to provide
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r86550433
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/GlobalConfiguration.java
---
@@ -144,8 +144,15 @@ private static Configuration
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r86544195
--- Diff: docs/internals/flink_security.md ---
@@ -84,4 +86,79 @@ Security implementation details are based on https://github.com/apache/
##
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r86548851
--- Diff: docs/setup/yarn_setup.md ---
@@ -134,6 +140,14 @@ Flink on YARN will only start all requested containers
if enough resources are a
some
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r86542654
--- Diff: docs/internals/flink_security.md ---
@@ -84,4 +86,79 @@ Security implementation details are based on https://github.com/apache/
##
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r86542840
--- Diff: docs/internals/flink_security.md ---
@@ -84,4 +86,79 @@ Security implementation details are based on https://github.com/apache/
##
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r86543731
--- Diff: docs/internals/flink_security.md ---
@@ -28,14 +28,16 @@ This document briefly describes how Flink security
works in the context of vario
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r86546515
--- Diff: docs/setup/yarn_setup.md ---
@@ -101,13 +101,19 @@ Usage:
Optional
-D Dynamic properties
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r86340045
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -788,75 +719,125 @@ private void logAndSysout(String message) {
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r86324769
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -54,24 +58,36 @@
// constructor in order to
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r86321320
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -64,26 +64,25 @@
static final String
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r86322286
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -120,6 +136,15 @@ static LengthFieldBasedFrameDecoder
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r86321008
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -64,26 +64,25 @@
static final String
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r86323404
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServerConnection.java
---
@@ -101,6 +102,14 @@ public void run() {
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r85175840
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -108,6 +111,11 @@
private final Options ALL_OPTIONS;
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r85167083
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -108,6 +111,11 @@
private final Options
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84169656
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -57,24 +61,37 @@
// constructor in order
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84175964
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -442,8 +453,10 @@ public static void
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84174244
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -108,6 +111,11 @@
private final Options
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84170399
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -112,9 +129,9 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84030548
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyConfig.java
---
@@ -91,6 +94,14 @@ public NettyConfig(
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84039282
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1008,6 +1008,9 @@ class JobManager(
case
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84020724
--- Diff: docs/setup/cli.md ---
@@ -217,6 +217,8 @@ Action "run" compiles and runs a program.
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84041338
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -108,6 +111,11 @@
private final Options ALL_OPTIONS;
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84035467
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -492,19 +553,22 @@ public void readFrom(ByteBuf buffer)
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84032194
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -57,24 +61,37 @@
// constructor in order to
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84026759
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobCache.java ---
@@ -272,4 +284,8 @@ private void closeSilently(Closeable closeable) {
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84036664
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestProtocol.java
---
@@ -30,16 +30,29 @@
private
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84035178
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -369,21 +423,24 @@ void readFrom(ByteBuf buffer) throws
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84033402
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -57,24 +61,37 @@
// constructor in order to
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84034881
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -369,21 +423,24 @@ void readFrom(ByteBuf buffer) throws
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84029158
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobUtils.java ---
@@ -393,6 +399,24 @@ static void copyFromRecoveryPath(String recoveryPath,
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84035615
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -527,13 +591,17 @@ void readFrom(ByteBuf buffer) throws
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84034660
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -226,8 +277,9 @@ ByteBuf write(ByteBufAllocator
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84028789
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServerProtocol.java
---
@@ -53,6 +53,9 @@
/** Internal code to identify a
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84035425
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -492,19 +553,22 @@ public void readFrom(ByteBuf buffer)
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84039884
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobServerGetTest.java
---
@@ -18,6 +18,7 @@
package
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84029858
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/execution/librarycache/BlobLibraryCacheManager.java
---
@@ -199,6 +199,11 @@ public int
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84041460
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -108,6 +111,11 @@
private final Options ALL_OPTIONS;
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84030215
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyConfig.java
---
@@ -91,6 +94,14 @@ public NettyConfig(
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84031724
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -57,24 +61,37 @@
// constructor in order to
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84034258
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -131,6 +157,31 @@ protected void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84027778
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobClient.java ---
@@ -725,7 +755,21 @@ else if (response != RETURN_OKAY) {
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84033606
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -57,24 +61,37 @@
// constructor in order to
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84035279
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -424,13 +481,17 @@ public String toString() {
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84031908
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -57,24 +61,37 @@
// constructor in order to
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84034738
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -292,9 +344,10 @@ ByteBuf write(ByteBufAllocator
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84035347
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -424,13 +481,17 @@ public String toString() {
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84041744
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -442,8 +453,10 @@ public static void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84024531
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/GlobalConfiguration.java
---
@@ -144,8 +144,15 @@ private static Configuration
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84034051
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -123,6 +140,15 @@ static LengthFieldBasedFrameDecoder
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84037454
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java
---
@@ -170,7 +176,8 @@ else if
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84024238
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -871,6 +871,19 @@
@Deprecated
public static final
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84021449
--- Diff: docs/setup/yarn_setup.md ---
@@ -101,13 +101,19 @@ Usage:
Optional
-D Dynamic properties
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84041916
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -607,6 +680,18 @@ public int run(String[] args) {
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84039558
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientSecureTest.java
---
@@ -0,0 +1,78 @@
+/*
--- End diff --
There is
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84025817
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
---
@@ -148,7 +148,7 @@
private MetricFetcher
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84020927
--- Diff: docs/setup/cli.md ---
@@ -239,6 +241,7 @@ Action "run" compiles and runs a program.
Zookeeper
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84030447
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobClient.java ---
@@ -88,6 +93,19 @@
*/
public
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84039769
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientTest.java
---
@@ -48,19 +49,18 @@
private static final int
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84033202
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -57,24 +61,37 @@
// constructor in order to
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84033982
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -112,9 +129,9 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84039872
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobServerDeleteTest.java
---
@@ -18,6 +18,7 @@
package
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84024718
--- Diff: flink-dist/src/main/resources/flink-conf.yaml ---
@@ -172,4 +173,14 @@ jobmanager.web.port: 8081
# Override below configuration to provide
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84020950
--- Diff: docs/setup/cli.md ---
@@ -239,6 +241,7 @@ Action "run" compiles and runs a program.
Zookeeper
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84036090
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestProtocol.java
---
@@ -30,16 +30,29 @@
private
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84042013
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -703,6 +796,93 @@ public static File
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84024166
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -871,6 +871,19 @@
@Deprecated
public static final
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84032768
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -57,24 +61,37 @@
// constructor in order to
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84028453
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServerConnection.java
---
@@ -463,6 +482,39 @@ private static String readKey(byte[] buf,
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84035560
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -527,13 +591,17 @@ void readFrom(ByteBuf buffer) throws
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84037462
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java
---
@@ -215,7 +222,8 @@ private void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84025149
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/HttpRequestHandler.java
---
@@ -99,7 +110,43 @@ public void
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84039893
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobServerPutTest.java
---
@@ -18,6 +18,7 @@
package
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84029066
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobUtils.java ---
@@ -393,6 +399,24 @@ static void copyFromRecoveryPath(String recoveryPath,
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84039201
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/akka/AkkaUtils.scala ---
@@ -389,7 +396,22 @@ object AkkaUtils {
""
}
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84028705
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServerConnection.java
---
@@ -463,6 +482,39 @@ private static String readKey(byte[] buf,
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84021839
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
---
@@ -90,6 +90,9 @@
"directory is optional.
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77320960
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -682,6 +774,91 @@ public static File
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77320247
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java ---
@@ -426,4 +440,11 @@ void unregisterConnection(BlobServerConnection
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77320094
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/HttpRequestHandler.java
---
@@ -99,7 +110,43 @@ public void
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77230955
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -682,6 +774,91 @@ public static File
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77227679
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientSecureTest.java
---
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77226096
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java ---
@@ -426,4 +440,11 @@ void
Github user vijikarthi commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77221958
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/HttpRequestHandler.java
---
@@ -99,7 +110,43 @@ public void
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77181460
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationMasterRunner.java
---
@@ -597,6 +610,11 @@ public static ContainerLaunchContext
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77182333
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -682,6 +774,91 @@ public static File
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77182101
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -682,6 +774,91 @@ public static File
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77181663
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -439,8 +450,8 @@ public static void
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77180355
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientSecureTest.java
---
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache
1 - 100 of 113 matches
Mail list logo
