[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5410 ---

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r194239264 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -105,7 +155,24 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r194109528 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -40,22 +42,63 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r194109518 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -105,7 +153,18 @@ public

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r194109540 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -40,22 +42,63 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193965626 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -105,7 +155,24 @@ public

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193964437 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java --- @@ -0,0 +1,70

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193964455 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java --- @@ -0,0 +1,70

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193964429 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java --- @@ -0,0 +1,70

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193964402 --- Diff: flink-connectors/flink-connector-rabbitmq/README.md --- @@ -9,3 +9,7 @@ nor packages binaries from the "RabbitMQ AMQP Java Client". Users that

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193963772 --- Diff: flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java --- @@ -83,7 +103,22 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193963587 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -105,7 +153,18 @@ public

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193377245 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -105,7 +153,18 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193361587 --- Diff: flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java --- @@ -83,7 +103,22 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193360923 --- Diff: flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java --- @@ -83,7 +103,22 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193359300 --- Diff: flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java --- @@ -83,7 +103,22 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193359253 --- Diff: flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java --- @@ -83,7 +103,22 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193358805 --- Diff: flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java --- @@ -66,12 +79,19 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193357238 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -40,22 +42,63 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193356675 --- Diff: flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java --- @@ -124,7 +159,82 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193356713 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -40,22 +42,63 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193356620 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQConnectionConfig.java --- @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193126744 --- Diff: flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java --- @@ -83,7 +103,22 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193101683 --- Diff: flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java --- @@ -83,7 +103,22 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193127128 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -105,7 +153,18 @@ public

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193126347 --- Diff: flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java --- @@ -83,7 +103,22 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193126169 --- Diff: flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java --- @@ -83,7 +103,22 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193125374 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java --- @@ -0,0 +1,70

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193122068 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -40,22 +42,63 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193119522 --- Diff: flink-connectors/flink-connector-rabbitmq/README.md --- @@ -9,3 +9,7 @@ nor packages binaries from the "RabbitMQ AMQP Java Client". Users that

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193070753 --- Diff: flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java --- @@ -66,12 +79,19 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193120662 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -105,7 +153,18 @@ public

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193126219 --- Diff: flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java --- @@ -83,7 +103,22 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193125823 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java --- @@ -0,0 +1,70

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193126189 --- Diff: flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java --- @@ -83,7 +103,22 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193122883 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -40,22 +42,63 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193123998 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java --- @@ -0,0 +1,70

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193010305 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -40,22 +42,63 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193004950 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQConnectionConfig.java --- @@ -109,6

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193010378 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -40,22 +42,63 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r193006836 --- Diff: flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java --- @@ -124,7 +159,82 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r191191853 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -40,22 +40,36 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r191187177 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java --- @@ -0,0

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r191185023 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java --- @@ -0,0

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r191184906 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java --- @@ -0,0

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r191184148 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.java --- @@ -151,7 +151,9 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r191180121 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java --- @@ -0,0

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r191179994 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -40,22 +40,36 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user pduveau commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r191179983 --- Diff: flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java --- @@ -43,14 +49,27 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r190658100 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java --- @@ -0,0 +1,50

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r190888216 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java --- @@ -0,0 +1,50

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r190650550 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java --- @@ -0,0 +1,50

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r190654087 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.java --- @@ -151,7 +151,9 @@ public

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r190888669 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -40,22 +40,36 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r190887946 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java --- @@ -0,0 +1,50

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r190648628 --- Diff: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -40,22 +40,36 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5410#discussion_r190647503 --- Diff: flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java --- @@ -43,14 +49,27 @@

[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

GitHub user pduveau opened a pull request: https://github.com/apache/flink/pull/5410 [FLINK-8468] [RabbitMQ Connector] Take advantage of AMQP features ## The purpose of the change To extend the Sink Connector to take full advantage of AMQP features. The AMQP Message sent