[GitHub] [lucene-solr] muse-dev[bot] commented on a change in pull request #2124: SOLR-8673: Open JSON Facet for extension

2020-12-07 Thread GitBox
muse-dev[bot] commented on a change in pull request #2124: URL: https://github.com/apache/lucene-solr/pull/2124#discussion_r537321555 ## File path: dev-tools/scripts/reproduceJenkinsFailures.py ## @@ -106,7 +108,9 @@ def fetchAndParseJenkinsLog(url, numRetries): tests = {}

[jira] [Resolved] (SOLR-15016) Replica placement plugins should use container plugins API / configs

2020-12-07 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki resolved SOLR-15016. - Fix Version/s: master (9.0) Resolution: Fixed > Replica placement plugins should u

[jira] [Commented] (SOLR-14182) Move metric reporters config from solr.xml to ZK cluster properties

2020-12-07 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245123#comment-17245123 ] Andrzej Bialecki commented on SOLR-14182: - Ok, I see your point Tomas - let's wor

[GitHub] [lucene-solr] mkhludnev opened a new pull request #2125: SOLR-8673: Enable custom aggregate functions by opening up FacetContext

2020-12-07 Thread GitBox
mkhludnev opened a new pull request #2125: URL: https://github.com/apache/lucene-solr/pull/2125 Prior to this change, it was not feasible to write a custom aggregate function in plugin code because the FacetContext class did not expose its fields for access outside its package. Also

[GitHub] [lucene-solr] mkhludnev commented on pull request #2125: SOLR-8673: Enable custom aggregate functions by opening up FacetContext

2020-12-07 Thread GitBox
mkhludnev commented on pull request #2125: URL: https://github.com/apache/lucene-solr/pull/2125#issuecomment-739832339 @timatbw, cherry picking https://github.com/apache/lucene-solr/commit/510f96c69c559c53a4f62281b48937a5f887dcc2 to 8x. I have to add `throws IOException` into the test.

[GitHub] [lucene-solr] mkhludnev merged pull request #2125: SOLR-8673: Enable custom aggregate functions by opening up FacetContext

2020-12-07 Thread GitBox
mkhludnev merged pull request #2125: URL: https://github.com/apache/lucene-solr/pull/2125 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (SOLR-8673) o.a.s.search.facet classes not public/extendable

2020-12-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245130#comment-17245130 ] ASF subversion and git services commented on SOLR-8673: --- Commit 8d63

[jira] [Resolved] (SOLR-15022) RefGuide documentation for /cluster/plugin API

2020-12-07 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki resolved SOLR-15022. - Fix Version/s: master (9.0) Resolution: Fixed > RefGuide documentation for /cluste

[jira] [Commented] (SOLR-15022) RefGuide documentation for /cluster/plugin API

2020-12-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245196#comment-17245196 ] ASF subversion and git services commented on SOLR-15022: Commit 8

[GitHub] [lucene-solr] magibney commented on a change in pull request #2123: SOLR-10732: short circuit calls to searcher#numDocs when base is empty

2020-12-07 Thread GitBox
magibney commented on a change in pull request #2123: URL: https://github.com/apache/lucene-solr/pull/2123#discussion_r537501831 ## File path: solr/core/src/java/org/apache/solr/search/facet/FacetProcessor.java ## @@ -419,7 +419,7 @@ void fillBucket(SimpleOrderedMap bucket, Que

[GitHub] [lucene-solr] munendrasn commented on a change in pull request #2123: SOLR-10732: short circuit calls to searcher#numDocs when base is empty

2020-12-07 Thread GitBox
munendrasn commented on a change in pull request #2123: URL: https://github.com/apache/lucene-solr/pull/2123#discussion_r537503391 ## File path: solr/core/src/java/org/apache/solr/search/facet/FacetProcessor.java ## @@ -419,7 +419,7 @@ void fillBucket(SimpleOrderedMap bucket, Q

[jira] [Commented] (SOLR-15022) RefGuide documentation for /cluster/plugin API

2020-12-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245208#comment-17245208 ] ASF subversion and git services commented on SOLR-15022: Commit 6

[GitHub] [lucene-solr] magibney commented on a change in pull request #2123: SOLR-10732: short circuit calls to searcher#numDocs when base is empty

2020-12-07 Thread GitBox
magibney commented on a change in pull request #2123: URL: https://github.com/apache/lucene-solr/pull/2123#discussion_r537520652 ## File path: solr/core/src/java/org/apache/solr/request/SimpleFacets.java ## @@ -903,7 +910,7 @@ public void execute(Runnable r) { private int

[GitHub] [lucene-solr] magibney commented on a change in pull request #2123: SOLR-10732: short circuit calls to searcher#numDocs when base is empty

2020-12-07 Thread GitBox
magibney commented on a change in pull request #2123: URL: https://github.com/apache/lucene-solr/pull/2123#discussion_r537551055 ## File path: solr/core/src/java/org/apache/solr/request/SimpleFacets.java ## @@ -325,6 +329,9 @@ public void getFacetQueryCount(ParsedParams parsed,

[jira] [Resolved] (SOLR-15021) Fix Typo in 8.7 Release Notes

2020-12-07 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cassandra Targett resolved SOLR-15021. -- Resolution: Duplicate > Fix Typo in 8.7 Release Notes > - >

[jira] [Resolved] (SOLR-15020) Fix Typo in 8.7 Release Notes

2020-12-07 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cassandra Targett resolved SOLR-15020. -- Fix Version/s: 8.8 Resolution: Fixed Fixed with https://github.com/apache/lucen

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-12-07 Thread GitBox
mikemccand commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r537561523 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -51,16 +50,9 @@ * to the provided Directory instanc

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-12-07 Thread GitBox
mikemccand commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r537569680 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -154,14 +146,43 @@ public IndexOutput createOutput(St

[GitHub] [lucene-solr] mikemccand commented on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-12-07 Thread GitBox
mikemccand commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-739974498 Hmm, `gradlew precommit` is angry: ``` > Task :lucene:misc:compileJava /l/directio/lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java:20

[GitHub] [lucene-solr] thelabdude merged pull request #2067: SOLR-14987: Reuse HttpSolrClient per node vs. one per Solr core when using CloudSolrStream

2020-12-07 Thread GitBox
thelabdude merged pull request #2067: URL: https://github.com/apache/lucene-solr/pull/2067 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (SOLR-14987) SolrStream ends up creating a new HttpSolrClient for every replica being queried instead of reusing for the same node

2020-12-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245312#comment-17245312 ] ASF subversion and git services commented on SOLR-14987: Commit 3

[jira] [Created] (LUCENE-9633) Improve match highlighter behavior for degenerate intervals (on non-existing positions)

2020-12-07 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-9633: --- Summary: Improve match highlighter behavior for degenerate intervals (on non-existing positions) Key: LUCENE-9633 URL: https://issues.apache.org/jira/browse/LUCENE-9633

[jira] [Created] (LUCENE-9634) Highlighting of degenerate spans on fields *with offsets* doesn't work properly

2020-12-07 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-9634: --- Summary: Highlighting of degenerate spans on fields *with offsets* doesn't work properly Key: LUCENE-9634 URL: https://issues.apache.org/jira/browse/LUCENE-9634 Project

[jira] [Updated] (LUCENE-9634) Highlighting of degenerate spans on fields *with offsets* doesn't work properly

2020-12-07 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9634: Description: Match highlighter works fine with degenerate interval positions when {{OffsetsFromPos

[GitHub] [lucene-solr] mayya-sharipova opened a new pull request #2126: LUCENE-9628 ScoreMode.TOP_DOCS in bool queries

2020-12-07 Thread GitBox
mayya-sharipova opened a new pull request #2126: URL: https://github.com/apache/lucene-solr/pull/2126 Account for ScoreMode.TOP_DOCS and TOP_DOCS_WITH_SCORES in boolean queries LUCENE-9280 introduced new ScoreModes of TOP_DOCS and TOP_DOCS_WITH_SCORES, but some boolean queries were

[GitHub] [lucene-solr] dweiss opened a new pull request #2127: LUCENE-9633: Improve match highlighter behavior for degenerate intervals

2020-12-07 Thread GitBox
dweiss opened a new pull request #2127: URL: https://github.com/apache/lucene-solr/pull/2127 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2127: LUCENE-9633: Improve match highlighter behavior for degenerate intervals

2020-12-07 Thread GitBox
dweiss commented on a change in pull request #2127: URL: https://github.com/apache/lucene-solr/pull/2127#discussion_r537669124 ## File path: lucene/highlighter/src/test/org/apache/lucene/search/matchhighlight/TestMatchRegionRetriever.java ## @@ -361,6 +374,41 @@ public void te

[jira] [Commented] (LUCENE-9628) Make sure to account for ScoreMode.TOP_DOCS in queries

2020-12-07 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245343#comment-17245343 ] Mayya Sharipova commented on LUCENE-9628: - I've create a PR to address the discu

[jira] [Comment Edited] (LUCENE-9628) Make sure to account for ScoreMode.TOP_DOCS in queries

2020-12-07 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245343#comment-17245343 ] Mayya Sharipova edited comment on LUCENE-9628 at 12/7/20, 5:04 PM: ---

[GitHub] [lucene-solr] gf2121 commented on pull request #2113: LUCENE-9629: Use computed masks

2020-12-07 Thread GitBox
gf2121 commented on pull request #2113: URL: https://github.com/apache/lucene-solr/pull/2113#issuecomment-740050981 There are still several `mask32()` called in `decodeSlow()`, I have fixed it in the newest commit and checked again to make sure that `mask8()`, `mask16()` and `mask32()` ar

[jira] [Comment Edited] (SOLR-15019) Replica placement API needs a way to fetch existing replica metrics

2020-12-07 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245374#comment-17245374 ] Andrzej Bialecki edited comment on SOLR-15019 at 12/7/20, 5:46 PM:

[jira] [Commented] (SOLR-15019) Replica placement API needs a way to fetch existing replica metrics

2020-12-07 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245374#comment-17245374 ] Andrzej Bialecki commented on SOLR-15019: - What common strongly-typed metrics we

[jira] [Commented] (SOLR-8673) o.a.s.search.facet classes not public/extendable

2020-12-07 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245398#comment-17245398 ] Timothy Potter commented on SOLR-8673: -- [~mkhl] it looks like this commit to 8x is ca

[GitHub] [lucene-solr] thelabdude opened a new pull request #2128: SOLR-14987: Reuse HttpSolrClient per node vs. one per Solr core when using CloudSolrStream

2020-12-07 Thread GitBox
thelabdude opened a new pull request #2128: URL: https://github.com/apache/lucene-solr/pull/2128 # Description Backport of #2067 to `branch_8x` For collections with many shards (or aliases with many collections and some shards), `CloudSolrStream` will end up creating a new `Ht

[GitHub] [lucene-solr] thelabdude merged pull request #2128: SOLR-14987: Reuse HttpSolrClient per node vs. one per Solr core when using CloudSolrStream

2020-12-07 Thread GitBox
thelabdude merged pull request #2128: URL: https://github.com/apache/lucene-solr/pull/2128 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (SOLR-14987) SolrStream ends up creating a new HttpSolrClient for every replica being queried instead of reusing for the same node

2020-12-07 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter updated SOLR-14987: -- Fix Version/s: master (9.0) 8.8 Resolution: Fixed Status: R

[jira] [Commented] (SOLR-14987) SolrStream ends up creating a new HttpSolrClient for every replica being queried instead of reusing for the same node

2020-12-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245421#comment-17245421 ] ASF subversion and git services commented on SOLR-14987: Commit 8

[GitHub] [lucene-solr] dsmiley commented on pull request #2123: SOLR-10732: short circuit calls to searcher#numDocs when base is empty

2020-12-07 Thread GitBox
dsmiley commented on pull request #2123: URL: https://github.com/apache/lucene-solr/pull/2123#issuecomment-740122634 Thanks Munendra, I'm glad you moved this from a patch file to GitHub PR -- way more conducive to getting a (good) review. I don't bother with patch files any more because I

[jira] [Commented] (SOLR-15026) MiniSolrCloudCluster can inconsistently get confused about when it's using SSL

2020-12-07 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245463#comment-17245463 ] Timothy Potter commented on SOLR-15026: --- Hi [~hossman] I actually think the right f

[jira] [Commented] (SOLR-14688) First party package implementation design

2020-12-07 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245479#comment-17245479 ] David Smiley commented on SOLR-14688: - I suspect there is something missing where the

[jira] [Commented] (SOLR-8673) o.a.s.search.facet classes not public/extendable

2020-12-07 Thread Tim Owen (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245498#comment-17245498 ] Tim Owen commented on SOLR-8673: Good point, yes I found a similar message when I first po

[GitHub] [lucene-solr] mayya-sharipova opened a new pull request #2129: Fix format indent from 4 to 2 spaces

2020-12-07 Thread GitBox
mayya-sharipova opened a new pull request #2129: URL: https://github.com/apache/lucene-solr/pull/2129 Files in org.apache.lucene.search.comparators package has a wrong indent of 4 spaces instead of 2. This patch fixes only the indent from 4 to correct 2 spaces ---

[jira] [Commented] (SOLR-13237) Not all types of index corruption garuntee a leader will "give up its leadership"

2020-12-07 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245556#comment-17245556 ] Mike Drob commented on SOLR-13237: -- Instead of trying to address the underlying corrupti

[GitHub] [lucene-solr] zacharymorn commented on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-12-07 Thread GitBox
zacharymorn commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-740306114 > Hmm, `gradlew precommit` is angry: > > ``` > > Task :lucene:misc:compileJava > /l/directio/lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirect

[GitHub] [lucene-solr] muse-dev[bot] commented on a change in pull request #1963: SOLR-14827: Refactor schema loading to not use XPath

2020-12-07 Thread GitBox
muse-dev[bot] commented on a change in pull request #1963: URL: https://github.com/apache/lucene-solr/pull/1963#discussion_r537974169 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ## @@ -186,6 +198,20 @@ protected NamedList loadConfigSetFlags(CoreD

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-12-07 Thread GitBox
zacharymorn commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r537974339 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -154,14 +146,43 @@ public IndexOutput createOutput(S

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-12-07 Thread GitBox
zacharymorn commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r537975653 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -51,16 +50,9 @@ * to the provided Directory instan

[GitHub] [lucene-solr] HoustonPutman opened a new pull request #2130: Adding Apache Reporter step in Release Wizard.

2020-12-07 Thread GitBox
HoustonPutman opened a new pull request #2130: URL: https://github.com/apache/lucene-solr/pull/2130 The release wizard doesn't currently tell the RM to add the new release to the apache release reporter. This is a simple change to add that one step at the end of announcing the new v

[jira] [Commented] (SOLR-8673) o.a.s.search.facet classes not public/extendable

2020-12-07 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245647#comment-17245647 ] Mikhail Khludnev commented on SOLR-8673: Sorry to hear that, @thekabdude. I'm on i

[jira] [Comment Edited] (SOLR-8673) o.a.s.search.facet classes not public/extendable

2020-12-07 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245647#comment-17245647 ] Mikhail Khludnev edited comment on SOLR-8673 at 12/8/20, 7:30 AM: --

[jira] [Comment Edited] (SOLR-8673) o.a.s.search.facet classes not public/extendable

2020-12-07 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245647#comment-17245647 ] Mikhail Khludnev edited comment on SOLR-8673 at 12/8/20, 7:31 AM: --