[GitHub] [lucene] bruno-roustant closed pull request #311: LUCENE-10097: Replace TreeMap use by HashMap when unnecessary

bruno-roustant closed pull request #311: URL: https://github.com/apache/lucene/pull/311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-uns

[GitHub] [lucene] bruno-roustant commented on pull request #311: LUCENE-10097: Replace TreeMap use by HashMap when unnecessary

bruno-roustant commented on pull request #311: URL: https://github.com/apache/lucene/pull/311#issuecomment-933206008 Ok, I'm closing this PR and the associated JIRA issue as HashMap + List is too complicated and TreeMap was a deliberated choice for keeping the memory usage low. -- This

[jira] [Commented] (LUCENE-10097) Replace TreeMap use by HashMap when unnecessary

[ https://issues.apache.org/jira/browse/LUCENE-10097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423780#comment-17423780 ] Bruno Roustant commented on LUCENE-10097: - Based on remarks in the PRs, I'm clo

[jira] [Resolved] (LUCENE-10097) Replace TreeMap use by HashMap when unnecessary

[ https://issues.apache.org/jira/browse/LUCENE-10097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant resolved LUCENE-10097. - Resolution: Won't Do > Replace TreeMap use by HashMap when unnecessary > --

[GitHub] [lucene] dweiss commented on a change in pull request #348: LUCENE-10143: Make DataInput/Output short/int/long reads and writes abstract

dweiss commented on a change in pull request #348: URL: https://github.com/apache/lucene/pull/348#discussion_r721096375 ## File path: lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataInput.java ## @@ -103,6 +103,24 @@ public byte readByte() throws EOFException {

[GitHub] [lucene] dweiss commented on a change in pull request #348: LUCENE-10143: Make DataInput/Output short/int/long reads and writes abstract

dweiss commented on a change in pull request #348: URL: https://github.com/apache/lucene/pull/348#discussion_r721097179 ## File path: lucene/core/src/java/org/apache/lucene/codecs/MultiLevelSkipListReader.java ## @@ -319,6 +320,27 @@ public void readBytes(byte[] b, int offset,

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423783#comment-17423783 ] Adrien Grand commented on LUCENE-10143: --- I was thinking of either adding an inter

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423786#comment-17423786 ] Dawid Weiss commented on LUCENE-10143: -- If the experience is similar to java's Buf

[GitHub] [lucene] dweiss merged pull request #340: LUCENE-10139: ExternalRefSorter should return a covariant with a subtype of BytesRefIterator that is Closeable

dweiss merged pull request #340: URL: https://github.com/apache/lucene/pull/340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Commented] (LUCENE-10139) ExternalRefSorter should return a covariant with a subtype of BytesRefIterator that is Closeable

[ https://issues.apache.org/jira/browse/LUCENE-10139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423788#comment-17423788 ] ASF subversion and git services commented on LUCENE-10139: -- Co

[jira] [Resolved] (LUCENE-10139) ExternalRefSorter should return a covariant with a subtype of BytesRefIterator that is Closeable

[ https://issues.apache.org/jira/browse/LUCENE-10139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-10139. -- Fix Version/s: main (9.0) Resolution: Fixed > ExternalRefSorter should return a covari

[jira] [Commented] (LUCENE-10136) Lift the restriction on using 'var' variables

[ https://issues.apache.org/jira/browse/LUCENE-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423789#comment-17423789 ] Dawid Weiss commented on LUCENE-10136: -- So... lazy consensus on this one? :) > Li

[GitHub] [lucene] uschindler commented on pull request #348: LUCENE-10143: Make DataInput/Output short/int/long reads and writes abstract

uschindler commented on pull request #348: URL: https://github.com/apache/lucene/pull/348#issuecomment-933285775 Hi, I am a bit busy and was not yet able to review. I have some comments so please wait with merging... -- This is an automated message from the Apache Git Service. To resp

[GitHub] [lucene] uschindler commented on a change in pull request #348: LUCENE-10143: Make DataInput/Output short/int/long reads and writes abstract

uschindler commented on a change in pull request #348: URL: https://github.com/apache/lucene/pull/348#discussion_r721173204 ## File path: lucene/core/src/java/org/apache/lucene/store/InputStreamDataInput.java ## @@ -33,6 +33,21 @@ public byte readByte() throws IOException {

[GitHub] [lucene] uschindler commented on a change in pull request #348: LUCENE-10143: Make DataInput/Output short/int/long reads and writes abstract

uschindler commented on a change in pull request #348: URL: https://github.com/apache/lucene/pull/348#discussion_r721174730 ## File path: lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataInput.java ## @@ -103,6 +103,24 @@ public byte readByte() throws EOFException {

[jira] [Commented] (LUCENE-10075) NPE on wildcard-based overlapping intervals highlighting

[ https://issues.apache.org/jira/browse/LUCENE-10075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423860#comment-17423860 ] Nikolay Khitrin commented on LUCENE-10075: -- [~romseygeek], thanks for keeping

[GitHub] [lucene] rmuir commented on a change in pull request #348: LUCENE-10143: Make DataInput/Output short/int/long reads and writes abstract

rmuir commented on a change in pull request #348: URL: https://github.com/apache/lucene/pull/348#discussion_r721231734 ## File path: lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataInput.java ## @@ -103,6 +103,24 @@ public byte readByte() throws EOFException {

[GitHub] [lucene] rmuir commented on pull request #348: LUCENE-10143: Make DataInput/Output short/int/long reads and writes abstract

rmuir commented on pull request #348: URL: https://github.com/apache/lucene/pull/348#issuecomment-933349094 if you want tweaks, please, just push commits to my branch. I don't really have time to tackle all the crazy shit ppl want done here, especially during the week. I tried to defer a l

[GitHub] [lucene] rmuir commented on a change in pull request #348: LUCENE-10143: Make DataInput/Output short/int/long reads and writes abstract

rmuir commented on a change in pull request #348: URL: https://github.com/apache/lucene/pull/348#discussion_r721235121 ## File path: lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataInput.java ## @@ -103,6 +103,24 @@ public byte readByte() throws EOFException {

[GitHub] [lucene] rmuir closed pull request #348: LUCENE-10143: Make DataInput/Output short/int/long reads and writes abstract

rmuir closed pull request #348: URL: https://github.com/apache/lucene/pull/348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [lucene] rmuir commented on pull request #348: LUCENE-10143: Make DataInput/Output short/int/long reads and writes abstract

rmuir commented on pull request #348: URL: https://github.com/apache/lucene/pull/348#issuecomment-933351956 I closed this PR as I feel the way folks want to approach it is too risky and will cause bugs. This kind of thing needs to be done *incrementally* to reduce risk. I don

[jira] [Commented] (LUCENE-10075) NPE on wildcard-based overlapping intervals highlighting

[ https://issues.apache.org/jira/browse/LUCENE-10075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423887#comment-17423887 ] Alan Woodward commented on LUCENE-10075: I played with this a bit over the week

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423890#comment-17423890 ] Robert Muir commented on LUCENE-10143: -- I really think we need to devise a differe

[jira] [Commented] (LUCENE-10136) Lift the restriction on using 'var' variables

[ https://issues.apache.org/jira/browse/LUCENE-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423895#comment-17423895 ] Robert Muir commented on LUCENE-10136: -- +1, we should use the latest language feat

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423897#comment-17423897 ] Dawid Weiss commented on LUCENE-10143: -- Sounds reasonable to me. > RateLimitedInd

[GitHub] [lucene] romseygeek merged pull request #347: LUCENE-10118: Fix thread visibility issue in testMergeThreadMessages

romseygeek merged pull request #347: URL: https://github.com/apache/lucene/pull/347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[jira] [Commented] (LUCENE-10118) Expand the log message when CMS.MergeThread completes its merge operation

[ https://issues.apache.org/jira/browse/LUCENE-10118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423899#comment-17423899 ] ASF subversion and git services commented on LUCENE-10118: -- Co

[jira] [Updated] (LUCENE-10144) Resource Leak due to Files.list

[ https://issues.apache.org/jira/browse/LUCENE-10144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated LUCENE-10144: --- Description: See [https://github.com/apache/lucene/blob/d5d6dc079395c47cd6d12dcce3bcfdd2c7d9dc63/buildSrc/

[jira] [Created] (LUCENE-10144) Resource Leak due to Files.list

lujie created LUCENE-10144: -- Summary: Resource Leak due to Files.list Key: LUCENE-10144 URL: https://issues.apache.org/jira/browse/LUCENE-10144 Project: Lucene - Core Issue Type: Bug Rep

[GitHub] [lucene] rmuir commented on a change in pull request #315: Disk write and read of hnsw graph

rmuir commented on a change in pull request #315: URL: https://github.com/apache/lucene/pull/315#discussion_r721296208 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java ## @@ -301,55 +349,62 @@ public KnnGraphValues getGraphVal

[jira] [Created] (LUCENE-10145) Use VarHandles to speedup byte[] comparisons in some cases

Adrien Grand created LUCENE-10145: - Summary: Use VarHandles to speedup byte[] comparisons in some cases Key: LUCENE-10145 URL: https://issues.apache.org/jira/browse/LUCENE-10145 Project: Lucene - Core

[GitHub] [lucene] jpountz opened a new pull request #349: LUCENE-10145: Speed up byte[] comparisons using VarHandles.

jpountz opened a new pull request #349: URL: https://github.com/apache/lucene/pull/349 See https://issues.apache.org/jira/browse/LUCENE-10145. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (LUCENE-10145) Use VarHandles to speedup byte[] comparisons in some cases

[ https://issues.apache.org/jira/browse/LUCENE-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423945#comment-17423945 ] Adrien Grand commented on LUCENE-10145: --- With the linked PR I got 13% faster merg

[GitHub] [lucene] dweiss commented on a change in pull request #349: LUCENE-10145: Speed up byte[] comparisons using VarHandles.

dweiss commented on a change in pull request #349: URL: https://github.com/apache/lucene/pull/349#discussion_r721382416 ## File path: lucene/core/src/java/org/apache/lucene/util/ArrayUtil.java ## @@ -656,4 +657,40 @@ protected int comparePivot(int j) { System.arraycopy(arr

[jira] [Commented] (LUCENE-10080) Use a bit set to count long-tail of singleton FacetLabels?

[ https://issues.apache.org/jira/browse/LUCENE-10080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423959#comment-17423959 ] Greg Miller commented on LUCENE-10080: -- Sound good to me. Thanks [~mdmarshmallow]!

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #315: Disk write and read of hnsw graph

mayya-sharipova commented on a change in pull request #315: URL: https://github.com/apache/lucene/pull/315#discussion_r721410089 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java ## @@ -301,55 +349,62 @@ public KnnGraphValues g

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #315: Disk write and read of hnsw graph

mayya-sharipova commented on a change in pull request #315: URL: https://github.com/apache/lucene/pull/315#discussion_r721410089 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java ## @@ -301,55 +349,62 @@ public KnnGraphValues g

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #315: Disk write and read of hnsw graph

mayya-sharipova commented on a change in pull request #315: URL: https://github.com/apache/lucene/pull/315#discussion_r721410089 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java ## @@ -301,55 +349,62 @@ public KnnGraphValues g

[GitHub] [lucene] rmuir commented on a change in pull request #315: Disk write and read of hnsw graph

rmuir commented on a change in pull request #315: URL: https://github.com/apache/lucene/pull/315#discussion_r721419192 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java ## @@ -301,55 +349,62 @@ public KnnGraphValues getGraphVal

[GitHub] [lucene] rmuir commented on a change in pull request #315: Disk write and read of hnsw graph

rmuir commented on a change in pull request #315: URL: https://github.com/apache/lucene/pull/315#discussion_r721421242 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java ## @@ -301,55 +349,62 @@ public KnnGraphValues getGraphVal

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #315: Disk write and read of hnsw graph

mayya-sharipova commented on a change in pull request #315: URL: https://github.com/apache/lucene/pull/315#discussion_r721427046 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java ## @@ -301,55 +349,62 @@ public KnnGraphValues g

[GitHub] [lucene] rmuir commented on a change in pull request #315: Disk write and read of hnsw graph

rmuir commented on a change in pull request #315: URL: https://github.com/apache/lucene/pull/315#discussion_r721435977 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java ## @@ -301,55 +349,62 @@ public KnnGraphValues getGraphVal

[jira] [Resolved] (LUCENE-10118) Expand the log message when CMS.MergeThread completes its merge operation

[ https://issues.apache.org/jira/browse/LUCENE-10118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-10118. Fix Version/s: main (9.0) Assignee: Alan Woodward Resolution: Fixed > Exp

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #315: Disk write and read of hnsw graph

mayya-sharipova commented on a change in pull request #315: URL: https://github.com/apache/lucene/pull/315#discussion_r721464714 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java ## @@ -301,55 +349,62 @@ public KnnGraphValues g

[GitHub] [lucene] janhoy commented on pull request #344: LUCENE-9809 Adapt Release Wizard to only release Lucene

janhoy commented on pull request #344: URL: https://github.com/apache/lucene/pull/344#issuecomment-933610186 Thanks. I'll try to continue my "simulated release" soon, to flesh out other needed changes, and then the rest must be done by RM during the actual release. -- This is an automate

[GitHub] [lucene] jpountz merged pull request #349: LUCENE-10145: Speed up byte[] comparisons using VarHandles.

jpountz merged pull request #349: URL: https://github.com/apache/lucene/pull/349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[jira] [Commented] (LUCENE-10145) Use VarHandles to speedup byte[] comparisons in some cases

[ https://issues.apache.org/jira/browse/LUCENE-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424024#comment-17424024 ] ASF subversion and git services commented on LUCENE-10145: -- Co

[jira] [Resolved] (LUCENE-10145) Use VarHandles to speedup byte[] comparisons in some cases

[ https://issues.apache.org/jira/browse/LUCENE-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10145. --- Fix Version/s: main (9.0) Resolution: Fixed > Use VarHandles to speedup byte[] compa

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424025#comment-17424025 ] Adrien Grand commented on LUCENE-10143: --- +1 to reopen the PR and merge as-is > R

[GitHub] [lucene] uschindler commented on pull request #349: LUCENE-10145: Speed up byte[] comparisons using VarHandles.

uschindler commented on pull request #349: URL: https://github.com/apache/lucene/pull/349#issuecomment-933657421 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (LUCENE-10145) Use VarHandles to speedup byte[] comparisons in some cases

[ https://issues.apache.org/jira/browse/LUCENE-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424027#comment-17424027 ] Uwe Schindler commented on LUCENE-10145: This is only single long/int compariso

[GitHub] [lucene] uschindler commented on pull request #348: LUCENE-10143: Make DataInput/Output short/int/long reads and writes abstract

uschindler commented on pull request #348: URL: https://github.com/apache/lucene/pull/348#issuecomment-933658907 Hi Robert, all fine. I fully agree if we change this, we should do it only in API. What I mentioned here were just suggestions (brainstorming). -- This is an automated

[jira] [Commented] (LUCENE-10145) Use VarHandles to speedup byte[] comparisons in some cases

[ https://issues.apache.org/jira/browse/LUCENE-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424031#comment-17424031 ] Adrien Grand commented on LUCENE-10145: --- Yes indeed, single long/int. These are c

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424037#comment-17424037 ] Uwe Schindler commented on LUCENE-10143: Hi, in general I am fine with the PR,

[jira] [Comment Edited] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424037#comment-17424037 ] Uwe Schindler edited comment on LUCENE-10143 at 10/4/21, 5:02 PM: ---

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424039#comment-17424039 ] Uwe Schindler commented on LUCENE-10143: My alternate proposal would be to add

[jira] [Comment Edited] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424039#comment-17424039 ] Uwe Schindler edited comment on LUCENE-10143 at 10/4/21, 5:09 PM: ---

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424040#comment-17424040 ] Uwe Schindler commented on LUCENE-10143: bq. +1 to reopen the PR and merge as-i

[GitHub] [lucene] jpountz opened a new pull request #350: LUCENE-10182: Specialize FieldSchema#assertSame for longs.

jpountz opened a new pull request #350: URL: https://github.com/apache/lucene/pull/350 I noticed a bug in `FieldSchema#assertSame` on `docValuesGen`. Since `docValuesGen` is a `long`, we end up calling `assertSame(String label, Object expected, Object actual)` which checks using obj

[jira] [Commented] (LUCENE-10145) Use VarHandles to speedup byte[] comparisons in some cases

[ https://issues.apache.org/jira/browse/LUCENE-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424051#comment-17424051 ] Robert Muir commented on LUCENE-10145: -- If you use the jdk Arrays method, it uses

[jira] [Updated] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-10143: --- Attachment: screenshot-1.png > RateLimitedIndexOutput should delegate writeShort/writeInt/w

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424053#comment-17424053 ] Uwe Schindler commented on LUCENE-10143: Hi, maybe we can use ECJ, not sure. E

[jira] [Commented] (LUCENE-10145) Use VarHandles to speedup byte[] comparisons in some cases

[ https://issues.apache.org/jira/browse/LUCENE-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424057#comment-17424057 ] Uwe Schindler commented on LUCENE-10145: Thanks. I forgot to mention that the A

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424062#comment-17424062 ] Uwe Schindler commented on LUCENE-10143: Maybe we can use project Lombok to aut

[jira] [Comment Edited] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424062#comment-17424062 ] Uwe Schindler edited comment on LUCENE-10143 at 10/4/21, 5:44 PM: ---

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424063#comment-17424063 ] Robert Muir commented on LUCENE-10143: -- {quote} The issue here is more specific to

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424068#comment-17424068 ] Robert Muir commented on LUCENE-10143: -- And none of those issues above are caused

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424075#comment-17424075 ] Robert Muir commented on LUCENE-10143: -- In general, I'm gonna say the "incomplete

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424099#comment-17424099 ] Uwe Schindler commented on LUCENE-10143: bq. In general, I'm gonna say the "inc

[jira] [Comment Edited] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424099#comment-17424099 ] Uwe Schindler edited comment on LUCENE-10143 at 10/4/21, 6:30 PM: ---

[jira] [Comment Edited] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424099#comment-17424099 ] Uwe Schindler edited comment on LUCENE-10143 at 10/4/21, 6:31 PM: ---

[jira] [Comment Edited] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424099#comment-17424099 ] Uwe Schindler edited comment on LUCENE-10143 at 10/4/21, 6:32 PM: ---

[jira] [Comment Edited] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424103#comment-17424103 ] Uwe Schindler edited comment on LUCENE-10143 at 10/4/21, 6:35 PM: ---

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424103#comment-17424103 ] Uwe Schindler commented on LUCENE-10143: qb. ByteBuffersDataInput (also used by

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424104#comment-17424104 ] Robert Muir commented on LUCENE-10143: -- I didn't mean it that way, I mean look at

[jira] [Commented] (LUCENE-10142) use a better RNG for Hnsw vectors

[ https://issues.apache.org/jira/browse/LUCENE-10142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424106#comment-17424106 ] Julie Tibshirani commented on LUCENE-10142: --- Tagging [~mayya] in case you did

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424107#comment-17424107 ] Uwe Schindler commented on LUCENE-10143: bq. One issue: Lots of DataInput/Outpu

[jira] [Updated] (LUCENE-10126) CompetitiveIterator of NumericComparator can wrongly skip documents

[ https://issues.apache.org/jira/browse/LUCENE-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-10126: - Fix Version/s: 8.10.1 8.11 9.10 Resolution: Fixed

[jira] [Commented] (LUCENE-10143) RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong

[ https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424121#comment-17424121 ] Robert Muir commented on LUCENE-10143: -- I also think the DataInput vs IndexInput c

[jira] [Commented] (LUCENE-10119) singleSort should not be set when after is non-null

[ https://issues.apache.org/jira/browse/LUCENE-10119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424127#comment-17424127 ] ASF subversion and git services commented on LUCENE-10119: -- Co

[jira] [Commented] (LUCENE-10126) CompetitiveIterator of NumericComparator can wrongly skip documents

[ https://issues.apache.org/jira/browse/LUCENE-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424128#comment-17424128 ] ASF subversion and git services commented on LUCENE-10126: -- Co

[jira] [Commented] (LUCENE-10106) Sort optimization mistakenly skips the first documents

[ https://issues.apache.org/jira/browse/LUCENE-10106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424126#comment-17424126 ] ASF subversion and git services commented on LUCENE-10106: -- Co

[jira] [Commented] (LUCENE-10119) singleSort should not be set when after is non-null

[ https://issues.apache.org/jira/browse/LUCENE-10119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424134#comment-17424134 ] ASF subversion and git services commented on LUCENE-10119: -- Co

[jira] [Commented] (LUCENE-10106) Sort optimization mistakenly skips the first documents

[ https://issues.apache.org/jira/browse/LUCENE-10106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424133#comment-17424133 ] ASF subversion and git services commented on LUCENE-10106: -- Co

[jira] [Commented] (LUCENE-10126) CompetitiveIterator of NumericComparator can wrongly skip documents

[ https://issues.apache.org/jira/browse/LUCENE-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424135#comment-17424135 ] ASF subversion and git services commented on LUCENE-10126: -- Co

[jira] [Commented] (LUCENE-10119) singleSort should not be set when after is non-null

[ https://issues.apache.org/jira/browse/LUCENE-10119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424140#comment-17424140 ] ASF subversion and git services commented on LUCENE-10119: -- Co

[jira] [Commented] (LUCENE-10126) CompetitiveIterator of NumericComparator can wrongly skip documents

[ https://issues.apache.org/jira/browse/LUCENE-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424141#comment-17424141 ] ASF subversion and git services commented on LUCENE-10126: -- Co

[jira] [Commented] (LUCENE-10106) Sort optimization mistakenly skips the first documents

[ https://issues.apache.org/jira/browse/LUCENE-10106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424139#comment-17424139 ] ASF subversion and git services commented on LUCENE-10106: -- Co

[jira] [Created] (LUCENE-10146) Add VectorSimilarityFunction.COSINE

Julie Tibshirani created LUCENE-10146: - Summary: Add VectorSimilarityFunction.COSINE Key: LUCENE-10146 URL: https://issues.apache.org/jira/browse/LUCENE-10146 Project: Lucene - Core Issue

[jira] [Created] (LUCENE-10147) KnnVectorQuery can produce negative scores

Julie Tibshirani created LUCENE-10147: - Summary: KnnVectorQuery can produce negative scores Key: LUCENE-10147 URL: https://issues.apache.org/jira/browse/LUCENE-10147 Project: Lucene - Core

[GitHub] [lucene-solr] gsmiller merged pull request #2587: LUCENE-10134: ConcurrentSortedSetDocValuesFacetCounts shouldn't share liveDocs Bits across threads

gsmiller merged pull request #2587: URL: https://github.com/apache/lucene-solr/pull/2587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[jira] [Commented] (LUCENE-10134) TestSortedSetDocValuesFacets fails with Bits shared between threads

[ https://issues.apache.org/jira/browse/LUCENE-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424219#comment-17424219 ] ASF subversion and git services commented on LUCENE-10134: -- Co

[GitHub] [lucene] gsmiller opened a new pull request #351: LUCENE-10134: Add CHANGES entry

gsmiller opened a new pull request #351: URL: https://github.com/apache/lucene/pull/351 No PR needed. Using only as a mechanism for merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] [Updated] (LUCENE-10134) TestSortedSetDocValuesFacets fails with Bits shared between threads

[ https://issues.apache.org/jira/browse/LUCENE-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller updated LUCENE-10134: - Fix Version/s: 8.11 > TestSortedSetDocValuesFacets fails with Bits shared between threads > ---

[GitHub] [lucene] gsmiller merged pull request #351: LUCENE-10134: Add CHANGES entry

gsmiller merged pull request #351: URL: https://github.com/apache/lucene/pull/351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (LUCENE-10134) TestSortedSetDocValuesFacets fails with Bits shared between threads

[ https://issues.apache.org/jira/browse/LUCENE-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424226#comment-17424226 ] ASF subversion and git services commented on LUCENE-10134: -- Co

[jira] [Commented] (LUCENE-9488) Update release process to work with Gradle.

[ https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424231#comment-17424231 ] Jan Høydahl commented on LUCENE-9488: - Thanks for the pointer. I committed and teste

[jira] [Commented] (LUCENE-9488) Update release process to work with Gradle.

[ https://issues.apache.org/jira/browse/LUCENE-9488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424236#comment-17424236 ] Jan Høydahl commented on LUCENE-9488: - The gradle build needs to assemble source pac

[jira] [Commented] (LUCENE-9997) Revisit smoketester for 9.0 build

[ https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424237#comment-17424237 ] Jan Høydahl commented on LUCENE-9997: - Perhaps this is the time to pick this up, bef

[jira] [Commented] (LUCENE-9431) UnifiedHighlighter: Make WEIGHT_MATCHES the default

[ https://issues.apache.org/jira/browse/LUCENE-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424264#comment-17424264 ] Animesh Pandey commented on LUCENE-9431: [~dsmiley] Hi, I wanted to confirm if m

  1   2   >