[jira] [Updated] (MSHADE-411) When Shade finds overlapping classes, clarify which class is added to final artifact

2022-03-10 Thread John Hendrikx (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Hendrikx updated MSHADE-411: - Description: For example: [WARNING] mediasystem-jfx-2.0.0-SNAPSHOT.jar, javafx-controls-16-win.

[jira] [Created] (MSHADE-411) When Shade finds overlapping classes, clarify which class is added to final artifact

2022-03-10 Thread John Hendrikx (Jira)
John Hendrikx created MSHADE-411: Summary: When Shade finds overlapping classes, clarify which class is added to final artifact Key: MSHADE-411 URL: https://issues.apache.org/jira/browse/MSHADE-411 Pr

[GitHub] [maven-shared-utils] pzygielo commented on pull request #95: (doc) Throw more descriptive NPEx

2022-03-10 Thread GitBox
pzygielo commented on pull request #95: URL: https://github.com/apache/maven-shared-utils/pull/95#issuecomment-1064843016 May I ask for review, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [maven-surefire] slawekjaranowski commented on pull request #485: [SUREFIRE-2036] Fix JUnit 5 with configured provider

2022-03-10 Thread GitBox
slawekjaranowski commented on pull request #485: URL: https://github.com/apache/maven-surefire/pull/485#issuecomment-1064840915 @roxspring thanks for collaboration -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[jira] [Closed] (SUREFIRE-2036) Regression: 3.0.0-M5 fails with configured JUnit 5 provider

2022-03-10 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed SUREFIRE-2036. - Resolution: Fixed > Regression: 3.0.0-M5 fails with configured JUnit 5 provide

[jira] [Assigned] (SUREFIRE-2036) Regression: 3.0.0-M5 fails with configured JUnit 5 provider

2022-03-10 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned SUREFIRE-2036: - Assignee: Slawomir Jaranowski > Regression: 3.0.0-M5 fails with confi

[GitHub] [maven-surefire] slawekjaranowski merged pull request #485: [SUREFIRE-2036] Fix JUnit 5 with configured provider

2022-03-10 Thread GitBox
slawekjaranowski merged pull request #485: URL: https://github.com/apache/maven-surefire/pull/485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-surefire] olamy commented on pull request #485: [SUREFIRE-2036] Fix JUnit 5 with configured provider

2022-03-10 Thread GitBox
olamy commented on pull request #485: URL: https://github.com/apache/maven-surefire/pull/485#issuecomment-1064833320 > once this is merged, could you push a snapshot to repository.apache.org? I would like to test it with our build early. Thanks @dantran once is merged to master bran

[GitHub] [maven-jxr] slawekjaranowski opened a new pull request #52: [JXR-165] Upgrade Maven Reporting to 3.1.0

2022-03-10 Thread GitBox
slawekjaranowski opened a new pull request #52: URL: https://github.com/apache/maven-jxr/pull/52 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/JXR) filed

[jira] [Commented] (MPLUGIN-394) Report-Mojo doesn't respect input encoding

2022-03-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504742#comment-17504742 ] ASF GitHub Bot commented on MPLUGIN-394: hboutemy commented on a change in pull

[GitHub] [maven-plugin-tools] hboutemy commented on a change in pull request #73: [MPLUGIN-394] Respect input encoding

2022-03-10 Thread GitBox
hboutemy commented on a change in pull request #73: URL: https://github.com/apache/maven-plugin-tools/pull/73#discussion_r824427199 ## File path: maven-plugin-plugin/src/it/mplugin-394_report-encoding/invoker.properties ## @@ -0,0 +1,18 @@ +# Licensed to the Apache Software Fo

[GitHub] [maven] laeubi commented on pull request #690: [MNG-7429] The classloader containing build extension should be used throughout the build

2022-03-10 Thread GitBox
laeubi commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064784340 Just for references as I recently added support for project-scoped WorkspaceReaders, if you like to support such components one needs to add explicit support for them similar to:

[GitHub] [maven] laeubi commented on pull request #690: [MNG-7429] The classloader containing build extension should be used throughout the build

2022-03-10 Thread GitBox
laeubi commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064779022 > but other think defining extensions in the pom is preferable Just in case you don't know it (and to save you from to much hassle) it is no longer required to define core-ext

[GitHub] [maven-help-plugin] dependabot[bot] closed pull request #48: Bump maven-project-info-reports-plugin from 3.1.2 to 3.2.1

2022-03-10 Thread GitBox
dependabot[bot] closed pull request #48: URL: https://github.com/apache/maven-help-plugin/pull/48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-help-plugin] dependabot[bot] commented on pull request #48: Bump maven-project-info-reports-plugin from 3.1.2 to 3.2.1

2022-03-10 Thread GitBox
dependabot[bot] commented on pull request #48: URL: https://github.com/apache/maven-help-plugin/pull/48#issuecomment-1064754525 Superseded by #53. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-help-plugin] dependabot[bot] opened a new pull request #53: Bump maven-project-info-reports-plugin from 3.1.2 to 3.2.2

2022-03-10 Thread GitBox
dependabot[bot] opened a new pull request #53: URL: https://github.com/apache/maven-help-plugin/pull/53 Bumps [maven-project-info-reports-plugin](https://github.com/apache/maven-project-info-reports-plugin) from 3.1.2 to 3.2.2. Commits https://github.com/apache/maven-project-

[GitHub] [maven-jlink-plugin] dependabot[bot] commented on pull request #91: Bump mockito-core from 4.2.0 to 4.3.1

2022-03-10 Thread GitBox
dependabot[bot] commented on pull request #91: URL: https://github.com/apache/maven-jlink-plugin/pull/91#issuecomment-1064753692 Superseded by #99. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven-jlink-plugin] dependabot[bot] closed pull request #91: Bump mockito-core from 4.2.0 to 4.3.1

2022-03-10 Thread GitBox
dependabot[bot] closed pull request #91: URL: https://github.com/apache/maven-jlink-plugin/pull/91 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-jlink-plugin] dependabot[bot] opened a new pull request #99: Bump mockito-core from 4.2.0 to 4.4.0

2022-03-10 Thread GitBox
dependabot[bot] opened a new pull request #99: URL: https://github.com/apache/maven-jlink-plugin/pull/99 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.2.0 to 4.4.0. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases.

[GitHub] [maven-surefire] dantran commented on pull request #485: [SUREFIRE-2036] Fix JUnit 5 with configured provider

2022-03-10 Thread GitBox
dantran commented on pull request #485: URL: https://github.com/apache/maven-surefire/pull/485#issuecomment-1064739628 @Tibor17 once this is merged, could you push a snapshot to repository.apache.org? I would like to test it with our build early. Thanks -- This is an automated message

[GitHub] [maven-resolver] caiwei-ebay commented on a change in pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

2022-03-10 Thread GitBox
caiwei-ebay commented on a change in pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#discussion_r824343285 ## File path: maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/collect/DependencyResolutionSkipperTest.java ## @@ -0,0 +1,214

[GitHub] [maven-resolver] caiwei-ebay edited a comment on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

2022-03-10 Thread GitBox
caiwei-ebay edited a comment on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1064718770 > There is a regression. Have a look at: [mng-5669.zip](https://github.com/apache/maven-resolver/files/8226394/mng-5669.zip) Please diff the sorted logfiles and

[GitHub] [maven-resolver] caiwei-ebay commented on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

2022-03-10 Thread GitBox
caiwei-ebay commented on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1064718770 > There is a regression. Have a look at: [mng-5669.zip](https://github.com/apache/maven-resolver/files/8226394/mng-5669.zip) Please diff the sorted logfiles and you wi

[GitHub] [maven-resolver] caiwei-ebay commented on a change in pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

2022-03-10 Thread GitBox
caiwei-ebay commented on a change in pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#discussion_r824343285 ## File path: maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/collect/DependencyResolutionSkipperTest.java ## @@ -0,0 +1,214

[GitHub] [maven-compiler-plugin] olamy merged pull request #100: Bump mockito-core from 4.3.1 to 4.4.0

2022-03-10 Thread GitBox
olamy merged pull request #100: URL: https://github.com/apache/maven-compiler-plugin/pull/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[GitHub] [maven-surefire] olamy commented on pull request #478: [SUREFIRE-1426] Fork crash doesn't fail build with -Dmaven.test.failure.ignore=true

2022-03-10 Thread GitBox
olamy commented on pull request #478: URL: https://github.com/apache/maven-surefire/pull/478#issuecomment-1064657277 > @Tibor17 I hope I answered all your concerns and we can now merge this? @Tibor17 ping -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [maven-surefire] Tibor17 commented on pull request #485: [SUREFIRE-2036] Fix JUnit 5 with configured provider

2022-03-10 Thread GitBox
Tibor17 commented on pull request #485: URL: https://github.com/apache/maven-surefire/pull/485#issuecomment-1064651932 @roxspring LGTM. It looks complete, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Updated] (SUREFIRE-2036) Regression: 3.0.0-M5 fails with configured JUnit 5 provider

2022-03-10 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-2036: --- Fix Version/s: 3.0.0-M6 > Regression: 3.0.0-M5 fails with configured JUnit 5 provider > --

[jira] [Updated] (JXR-166) Two versions of velocity engines on plugin classpath

2022-03-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/JXR-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated JXR-166: - Affects Version/s: 3.2.0 > Two versions of velocity engines on plugin classpath > --

[jira] [Assigned] (JXR-165) Upgrade Maven Reporting to 3.1.0

2022-03-10 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/JXR-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned JXR-165: --- Assignee: Slawomir Jaranowski > Upgrade Maven Reporting to 3.1.0 >

[GitHub] [maven-verifier] slawekjaranowski commented on pull request #9: [MSHARED-1043] Deprecate methods leveraging JUnit4 assertions

2022-03-10 Thread GitBox
slawekjaranowski commented on pull request #9: URL: https://github.com/apache/maven-verifier/pull/9#issuecomment-1064592627 It is standard way, first deprecated method with documentation how should be replace - and we do this step. Next we release major version with removed methods i

[jira] [Commented] (JXR-157) Upgrade Velocity templating engine

2022-03-10 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/JXR-157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504638#comment-17504638 ] Slawomir Jaranowski commented on JXR-157: - ok, now we have two version of velocity .

[jira] [Created] (JXR-166) Two versions of velocity engines on plugin classpath

2022-03-10 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created JXR-166: --- Summary: Two versions of velocity engines on plugin classpath Key: JXR-166 URL: https://issues.apache.org/jira/browse/JXR-166 Project: Maven JXR Issue

[jira] [Commented] (JXR-157) Upgrade Velocity templating engine

2022-03-10 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/JXR-157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504634#comment-17504634 ] Sylwester Lachiewicz commented on JXR-157: -- Yes, next step is to fix dixia-sitetool

[jira] [Created] (JXR-165) Upgrade Maven Reporting to 3.1.0

2022-03-10 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created JXR-165: --- Summary: Upgrade Maven Reporting to 3.1.0 Key: JXR-165 URL: https://issues.apache.org/jira/browse/JXR-165 Project: Maven JXR Issue Type: Dependency upg

[jira] [Commented] (JXR-157) Upgrade Velocity templating engine

2022-03-10 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/JXR-157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504623#comment-17504623 ] Slawomir Jaranowski commented on JXR-157: - [~slachiewicz] [~khmarbaise]  What benef

[GitHub] [maven] gnodet commented on pull request #690: [MNG-7429] The classloader containing build extension should be used throughout the build

2022-03-10 Thread GitBox
gnodet commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064530792 > Just another observation, it seems `MojosExecutionStrategy` was jsut intorduced in maven `3.9.x` so how could it be a regression from `3.8.x`? Because it has been developed

[GitHub] [maven-jxr] dependabot[bot] commented on pull request #44: Bump wagon-provider-api from 2.8 to 3.5.1

2022-03-10 Thread GitBox
dependabot[bot] commented on pull request #44: URL: https://github.com/apache/maven-jxr/pull/44#issuecomment-1064524263 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor ver

[GitHub] [maven-jxr] slawekjaranowski closed pull request #44: Bump wagon-provider-api from 2.8 to 3.5.1

2022-03-10 Thread GitBox
slawekjaranowski closed pull request #44: URL: https://github.com/apache/maven-jxr/pull/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[jira] [Commented] (MPLUGIN-394) Report-Mojo doesn't respect input encoding

2022-03-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504579#comment-17504579 ] ASF GitHub Bot commented on MPLUGIN-394: michael-o commented on a change in pull

[GitHub] [maven-plugin-tools] michael-o commented on a change in pull request #73: [MPLUGIN-394] Respect input encoding

2022-03-10 Thread GitBox
michael-o commented on a change in pull request #73: URL: https://github.com/apache/maven-plugin-tools/pull/73#discussion_r824149087 ## File path: maven-plugin-plugin/src/it/mplugin-394_report-encoding/invoker.properties ## @@ -0,0 +1,18 @@ +# Licensed to the Apache Software F

[GitHub] [maven-verifier] elharo commented on pull request #9: [MSHARED-1043] Deprecate methods leveraging JUnit4 assertions

2022-03-10 Thread GitBox
elharo commented on pull request #9: URL: https://github.com/apache/maven-verifier/pull/9#issuecomment-1064485060 It's more of a long term concern. Is anyone who's not the Maven project using this? If so, it's going to be really hard to remove the deprecated methods. I agree that i

[GitHub] [maven-resolver] michael-o commented on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

2022-03-10 Thread GitBox
michael-o commented on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1064417880 There is a regression. Have a look at: [mng-5669.zip](https://github.com/apache/maven-resolver/files/8226394/mng-5669.zip) Please diff the sorted logfiles and you will

[GitHub] [maven-verifier] kwin commented on pull request #9: [MSHARED-1043] Deprecate methods leveraging JUnit4 assertions

2022-03-10 Thread GitBox
kwin commented on pull request #9: URL: https://github.com/apache/maven-verifier/pull/9#issuecomment-1064373755 > I'm a little concerned that this is somewhat incompatible with existing usage. This code should be fully backwards-compatible as no existing methods are removed/modifie

[jira] [Commented] (MNG-7429) The classloader containing build extensions should be used throughout the build

2022-03-10 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504508#comment-17504508 ] Michael Osipov commented on MNG-7429: - At least we can set the reactor CL for build ext

[jira] [Updated] (MNG-7429) The classloader containing build extensions should be used throughout the build

2022-03-10 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7429: Summary: The classloader containing build extensions should be used throughout the build (was: The c

[jira] [Created] (MPOM-309) Upgrade TagList Maven Plugin from 2.4 to 3.0.0

2022-03-10 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MPOM-309: Summary: Upgrade TagList Maven Plugin from 2.4 to 3.0.0 Key: MPOM-309 URL: https://issues.apache.org/jira/browse/MPOM-309 Project: Maven POMs Issue T

[jira] [Created] (MPOM-308) Upgrade Maven PMD Plugin from 3.15.0 to 3.16.0

2022-03-10 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MPOM-308: Summary: Upgrade Maven PMD Plugin from 3.15.0 to 3.16.0 Key: MPOM-308 URL: https://issues.apache.org/jira/browse/MPOM-308 Project: Maven POMs Issue T

[GitHub] [maven] laeubi commented on pull request #690: [MNG-7429] The classloader containing build extension should be used throughout the build

2022-03-10 Thread GitBox
laeubi commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064296345 Just another observation, it seems `MojosExecutionStrategy` was jsut intorduced in maven `3.9.x` so how could it be a regression from `3.8.x`? -- This is an automated message from

[GitHub] [maven] laeubi commented on pull request #690: [MNG-7429] The classloader containing build extension should be used throughout the build

2022-03-10 Thread GitBox
laeubi commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064292516 > Actually, the one that cause problems is the [BuildCacheMojosExecutionStrategy](https://github.com/apache/maven-build-cache-extension/blob/master/src/main/java/org/apache/maven/bui

[GitHub] [maven] laeubi commented on pull request #690: [MNG-7429] The classloader containing build extension should be used throughout the build

2022-03-10 Thread GitBox
laeubi commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064278668 Just one thing I'm curious about: Why is the mavencache not used as a core-extension? I would suspect that this will give much more powerful and stable integration than just integra

[GitHub] [maven] laeubi commented on pull request #690: [MNG-7429] The classloader containing build extension should be used throughout the build

2022-03-10 Thread GitBox
laeubi commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064275379 > I've added a commit to revert [e327be3](https://github.com/apache/maven/commit/e327be3d85918a23a5ba48d752143a6dbf8b83f7) because it's useless. It is not useless but prevent

[GitHub] [maven] gnodet edited a comment on pull request #690: [MNG-7429] The classloader containing build extension should be used throughout the build

2022-03-10 Thread GitBox
gnodet edited a comment on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064264508 I've added a commit to revert https://github.com/apache/maven/commit/e327be3d85918a23a5ba48d752143a6dbf8b83f7 because it's useless. This restores the behavior from 3.

[GitHub] [maven] gnodet commented on pull request #690: [MNG-7429] The classloader containing build extension should be used throughout the build

2022-03-10 Thread GitBox
gnodet commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064264508 I've added a commit to revert https://github.com/apache/maven/commit/e327be3d85918a23a5ba48d752143a6dbf8b83f7 because it's useless. This restores the behavior from 3.8.4 whe

[GitHub] [maven] gnodet commented on pull request #690: [MNG-7429] The classloader containing build extension should be used throughout the build

2022-03-10 Thread GitBox
gnodet commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064222692 > > It _was_ leaking : the current PR still reverts at the end of the build. > > I don't think this is enough... as mentioned in the change, there is even this classloader use

[jira] [Commented] (MNG-7429) The classloader containing build extension should be used throughout the build

2022-03-10 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504363#comment-17504363 ] Christoph Läubrich commented on MNG-7429: - I don't think there is one classlaoder f

[GitHub] [maven] laeubi commented on pull request #690: [MNG-7429] The classloader containing build extension should be used throughout the build

2022-03-10 Thread GitBox
laeubi commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064186425 > It _was_ leaking : the current PR still reverts at the end of the build. I don't think this is enough... as mentioned in the change, there is even this classloader used late

[jira] [Updated] (MNG-7429) The classloader containing build extension should be used throughout the build

2022-03-10 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-7429: - Labels: Regression (was: ) > The classloader containing build extension should be used throughout

[jira] [Updated] (MNG-7429) The classloader containing build extension should be used throughout the build

2022-03-10 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-7429: - Summary: The classloader containing build extension should be used throughout the build (was: The

[jira] [Created] (MNG-7429) The classloader containing build extension is not used throughout the build

2022-03-10 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MNG-7429: Summary: The classloader containing build extension is not used throughout the build Key: MNG-7429 URL: https://issues.apache.org/jira/browse/MNG-7429 Project: Maven

[GitHub] [maven] gnodet commented on pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
gnodet commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064151253 > @gnodet Does this apply to 3.8.x? I guess we need a new JIRA issue to clearly document this problem/regression. @michael-o It does apply to 3.8.x, and yes, I'll create a JIR

[GitHub] [maven] laeubi commented on pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
laeubi commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064143527 Do you refer to https://github.com/apache/maven-build-cache-extension/blob/master/src/main/java/org/apache/maven/buildcache/CacheLifecycleParticipant.java ? Why do you make this a s

[GitHub] [maven] laeubi commented on pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
laeubi commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064140324 > The reason is that the extension defines a component with a session scope. By the way I already noticed that SessionScoped components are actually hard to implement, I used

[GitHub] [maven] laeubi commented on pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
laeubi commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064134506 > Also, about the _last project_ point, I think in most cases, only the top level project has a specific classloader. If it is not the last then "the last one that has a speci

[GitHub] [maven] laeubi commented on pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
laeubi commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064130054 But this does actually shows that an project classlaoder is leaked. I don't see how reverting this makes the situation better (beside that 'it has worked before') as obviously here

[GitHub] [maven] michael-o edited a comment on pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
michael-o edited a comment on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064129782 @gnodet Does this apply to 3.8.x? I guess we need a new JIRA issue to clearly document this problem/regression. -- This is an automated message from the Apache Git Servi

[GitHub] [maven] michael-o commented on pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
michael-o commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064129782 @gnodet Does this apply to 3.8.x? I guess we need a new JIRA issue to clearly document this problem/regressin. -- This is an automated message from the Apache Git Service. To r

[GitHub] [maven] gnodet edited a comment on pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
gnodet edited a comment on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064126265 > But why/how does it breaks them? As described in the PR this currently leaks the CCL of the _last_ project in the chain, and even if it makes extensions work somehow it is

[GitHub] [maven] gnodet commented on pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
gnodet commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064126265 > But why/how does it breaks them? As described in the PR this currently leaks the CCL of the _last_ project in the chain, and even if it makes extensions work somehow it is clearly

[jira] [Created] (MPOM-307) Upgrade Maven Dependency Plugin from 3.2.0 to 3.3.0

2022-03-10 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MPOM-307: Summary: Upgrade Maven Dependency Plugin from 3.2.0 to 3.3.0 Key: MPOM-307 URL: https://issues.apache.org/jira/browse/MPOM-307 Project: Maven POMs Is

[GitHub] [maven] laeubi edited a comment on pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
laeubi edited a comment on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064122112 But why/how does it breaks them? As described in the PR this currently leaks the CCL of the *last* project in the chain, and even if it makes extensions work somehow it is cl

[GitHub] [maven] laeubi commented on pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
laeubi commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064122112 But why/how does it breaks them? As described in the PR this currently leaks the CCL of the *last* project in the chain, and even if it makes extensions work somehow it is clearly b

[GitHub] [maven] gnodet commented on pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
gnodet commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064120857 > This looks like another issue that is only similar to the other fix, but why should anything be reverted? It's not another issue. The https://github.com/apache/maven/commi

[jira] [Created] (MPOM-306) Upgrade Maven Compiler Plugin from 3.10.0 to 3.10.1

2022-03-10 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MPOM-306: Summary: Upgrade Maven Compiler Plugin from 3.10.0 to 3.10.1 Key: MPOM-306 URL: https://issues.apache.org/jira/browse/MPOM-306 Project: Maven POMs Is

[jira] [Commented] (MRELEASE-1080) Maven v3.8.4 exits with non-zero status from release:perform or :prepare even when successful

2022-03-10 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504300#comment-17504300 ] Michael Osipov commented on MRELEASE-1080: -- Here is likely your answer: http

[GitHub] [maven] laeubi commented on pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
laeubi commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064116419 This looks like another issue that is only similar to the other fix, but why should anything be reverted? -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [maven] gnodet commented on pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
gnodet commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064115889 > > > What is a build extension is declared in a submodule only? > > > > > > You mean "what if" ? That's my point, I don't think there are solid expectations wrt to the re

[GitHub] [maven] michael-o commented on pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
michael-o commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064111957 > > What is a build extension is declared in a submodule only? > > You mean "what if" ? That's my point, I don't think there are solid expectations wrt to the reactor hiera

[GitHub] [maven-resolver] michael-o commented on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

2022-03-10 Thread GitBox
michael-o commented on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1064109525 I will leave @ibabiankou at least a week to test and respond. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Commented] (MRELEASE-1080) Maven v3.8.4 exits with non-zero status from release:perform or :prepare even when successful

2022-03-10 Thread Mirko Klemm (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504291#comment-17504291 ] Mirko Klemm commented on MRELEASE-1080: --- Oh yes, possibly. But versions before 3

[jira] [Created] (MPOM-305) Set minimum enforced Maven version to 3.2.5

2022-03-10 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MPOM-305: Summary: Set minimum enforced Maven version to 3.2.5 Key: MPOM-305 URL: https://issues.apache.org/jira/browse/MPOM-305 Project: Maven POMs Issue Type

[GitHub] [maven-resolver] michael-o commented on a change in pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…

2022-03-10 Thread GitBox
michael-o commented on a change in pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#discussion_r823761761 ## File path: maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/collect/DependencyResolutionSkipperTest.java ## @@ -0,0 +1,214 @@

[GitHub] [maven] gnodet edited a comment on pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
gnodet edited a comment on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064107249 > What is a build extension is declared in a submodule only? You mean "what if" ? That's my point, I don't think there are solid expectations wrt to the reactor hier

[GitHub] [maven] gnodet commented on pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
gnodet commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064107249 > What is a build extension is declared in a submodule only? You mean "what if" ? -- This is an automated message from the Apache Git Service. To respond to the message, ple

[jira] [Commented] (MRELEASE-1080) Maven v3.8.4 exits with non-zero status from release:perform or :prepare even when successful

2022-03-10 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504288#comment-17504288 ] Michael Osipov commented on MRELEASE-1080: -- This reminds me of https://githu

[jira] (MRELEASE-1080) Maven v3.8.4 exits with non-zero status from release:perform or :prepare even when successful

2022-03-10 Thread Mirko Klemm (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1080 ] Mirko Klemm deleted comment on MRELEASE-1080: --- was (Author: JIRAUSER286414): Investigated further: There seems to be an internal WARNING which also occurs only under GIT bash. During rel

[GitHub] [maven] michael-o commented on pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
michael-o commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064095385 What is a build extension is declared in a submodule only? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [maven] michael-o edited a comment on pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
michael-o edited a comment on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064075575 This does not supersede e327be3d85918a23a5ba48d752143a6dbf8b83f7, but complements it? -- This is an automated message from the Apache Git Service. To respond to the mess

[jira] [Created] (MPOM-304) Upgrade Maven Project Info Reports Plugin from 3.1.2 to 3.2.2

2022-03-10 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MPOM-304: Summary: Upgrade Maven Project Info Reports Plugin from 3.1.2 to 3.2.2 Key: MPOM-304 URL: https://issues.apache.org/jira/browse/MPOM-304 Project: Maven POMs

[jira] [Commented] (MRELEASE-1080) Maven v3.8.4 exits with non-zero status from release:perform or :prepare even when successful

2022-03-10 Thread Mirko Klemm (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504285#comment-17504285 ] Mirko Klemm commented on MRELEASE-1080: --- Investigated further: There seems to be

[jira] [Commented] (MRELEASE-1080) Maven v3.8.4 exits with non-zero status from release:perform or :prepare even when successful

2022-03-10 Thread Mirko Klemm (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504281#comment-17504281 ] Mirko Klemm commented on MRELEASE-1080: --- Yes, just checked: * In Windows CMD, %

[GitHub] [maven] gnodet commented on pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
gnodet commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064078828 > This does not supersede [e327be3](https://github.com/apache/maven/commit/e327be3d85918a23a5ba48d752143a6dbf8b83f7) but complements it? Yes, I actually don't think the first

[GitHub] [maven] michael-o commented on pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
michael-o commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064076137 @laeubi can you check also? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [maven] michael-o commented on pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
michael-o commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064075575 This does not supersede e327be3d85918a23a5ba48d752143a6dbf8b83f7 but complements it? -- This is an automated message from the Apache Git Service. To respond to the message, ple

[jira] [Commented] (MRELEASE-1080) Maven v3.8.4 exits with non-zero status from release:perform or :prepare even when successful

2022-03-10 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504266#comment-17504266 ] Michael Osipov commented on MRELEASE-1080: -- Does it work with Windows Command

[GitHub] [maven] gnodet opened a new pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
gnodet opened a new pull request #690: URL: https://github.com/apache/maven/pull/690 This fixes problems when using build extensions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (MRELEASE-1080) Maven v3.8.4 exits with non-zero status from release:perform or :prepare even when successful

2022-03-10 Thread Mirko Klemm (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mirko Klemm updated MRELEASE-1080: -- Environment: Windows 10, Git for Windows Bourne Again Shell, Maven 3.8.4 was:Windows 10,

[jira] [Updated] (MRELEASE-1080) Maven v3.8.4 exits with non-zero status from release:perform or :prepare even when successful

2022-03-10 Thread Mirko Klemm (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mirko Klemm updated MRELEASE-1080: -- Summary: Maven v3.8.4 exits with non-zero status from release:perform or :prepare even when

[jira] [Commented] (MRELEASE-1080) Maven v3.8.0 exits with non-zero status from release:perform or :prepare even when successful

2022-03-10 Thread Mirko Klemm (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504251#comment-17504251 ] Mirko Klemm commented on MRELEASE-1080: --- OK - now upgraded to Maven 3.8.4. Behav

[jira] [Created] (MPOM-303) Rename property maven.plugin.tools.version to mavenPluginToolsVersion

2022-03-10 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MPOM-303: Summary: Rename property maven.plugin.tools.version to mavenPluginToolsVersion Key: MPOM-303 URL: https://issues.apache.org/jira/browse/MPOM-303 Project: Mave

  1   2   >