[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
JonZeolla commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417045301 ## File path: docker/scripts/docker_run_create_topic_in_kafka.sh ## @@ -80,7 +80,10 @@ echo "Running docker_run_create_topic_in_kafka with

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
ottobackwards commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417042597 ## File path: docker/scripts/docker_run_create_topic_in_kafka.sh ## @@ -80,7 +80,10 @@ echo "Running docker_run_create_topic_in_kafka

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
ottobackwards commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417041687 ## File path: docker/containers/zookeeper/Dockerfile ## @@ -16,20 +14,4 @@ # See the License for the specific language governing

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
ottobackwards commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417041583 ## File path: docker/containers/kafka/Dockerfile ## @@ -16,20 +14,4 @@ # See the License for the specific language governing

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
ottobackwards commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417041527 ## File path: docker/containers/kafka/Dockerfile ## @@ -16,20 +14,4 @@ # See the License for the specific language governing

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
ottobackwards commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417041583 ## File path: docker/containers/kafka/Dockerfile ## @@ -16,20 +14,4 @@ # See the License for the specific language governing

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
ottobackwards commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417041000 ## File path: docker/README.md ## @@ -209,33 +140,21 @@ testing scripts to be added to a pull request, and subsequently to a test

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
JonZeolla commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417038403 ## File path: docker/scripts/docker_run_create_topic_in_kafka.sh ## @@ -80,7 +80,10 @@ echo "Running docker_run_create_topic_in_kafka with

[GitHub] [metron-bro-plugin-kafka] JonZeolla opened a new pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
JonZeolla opened a new pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42 ## Contributor Comments This is a first step towards `docker-compose` in our end to end tests. ### Testing Run `./run_end_to_end.sh` and `./finish_end_to_end.sh` ##

[GitHub] [metron] JonZeolla commented on pull request #1580: METRON-2348 fix prepare-commit

2020-04-27 Thread GitBox
JonZeolla commented on pull request #1580: URL: https://github.com/apache/metron/pull/1580#issuecomment-620020230 +1 by inspection, pending successful CI This is an automated message from the Apache Git Service. To respond

[GitHub] [metron] ottobackwards opened a new pull request #1580: METRON-2348 fix prepare-commit

2020-04-27 Thread GitBox
ottobackwards opened a new pull request #1580: URL: https://github.com/apache/metron/pull/1580 Fix the prepare-commit script by changing the check for "Status" to instead two checks, for the PR being open, and it being cleanly mergable. NOTE: this adds a dependency on

[GitHub] [metron-bro-plugin-kafka] nickwallen commented on pull request #41: METRON-2346: Update kafka plugin testing dependencies

2020-04-27 Thread GitBox
nickwallen commented on pull request #41: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/41#issuecomment-619990282 +1 Thanks @JonZeolla ! This is an automated message from the Apache Git Service. To respond to

[GitHub] [metron-bro-plugin-kafka] JonZeolla opened a new pull request #41: METRON-2346: Update kafka plugin testing dependencies

2020-04-27 Thread GitBox
JonZeolla opened a new pull request #41: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/41 ## Contributor Comments As a part of the bro rename to zeek, our testing environment broke. To test, run `./run_end_to_end.sh` and confirm it now succeeds. ## Pull Request

[GitHub] [metron] zhaoyim commented on pull request #1578: METRON-2250 Missing services in HDP 3.1 metron mpack and installer stuck

2020-04-26 Thread GitBox
zhaoyim commented on pull request #1578: URL: https://github.com/apache/metron/pull/1578#issuecomment-619671872 @nickwallen I saw in the 'feature/METRON-2088-support-hdp-3.1' branch already implements the 'colocateService' interface to fix the issue. So please ignore my fix. Thanks!

[GitHub] [metron] zhaoyim commented on pull request #1578: METRON-2250 Missing services in HDP 3.1 metron mpack and installer stuck

2020-04-26 Thread GitBox
zhaoyim commented on pull request #1578: URL: https://github.com/apache/metron/pull/1578#issuecomment-619668666 @nickwallen Thanks for your suggestion. I will close this pr and resubmit to 'feature/METRON-2088-support-hdp-3.1'

[GitHub] [metron] tomyerex opened a new pull request #1579: Metron-2345 "metron on cent os 7" documentation does not exist

2020-04-26 Thread GitBox
tomyerex opened a new pull request #1579: URL: https://github.com/apache/metron/pull/1579 ## Contributor Comments Update to address issue identified in Metron-2345 (https://issues.apache.org/jira/browse/METRON-2345) and the lack of documentation for CentOS 7 development build, i.e.,

[GitHub] [metron] nickwallen commented on pull request #1578: METRON-2250 Missing services in HDP 3.1 metron mpack and installer stuck

2020-04-26 Thread GitBox
nickwallen commented on pull request #1578: URL: https://github.com/apache/metron/pull/1578#issuecomment-619544762 Thanks for the contribution @zhaoyim. Instead of submitting this PR against master, you could submit it against the feature branch with the HDP-3.1 upgrade;

[GitHub] [metron] zhaoyim commented on pull request #1578: METRON-2250 Missing services in HDP 3.1 metron mpack and installer stuck

2020-04-25 Thread GitBox
zhaoyim commented on pull request #1578: URL: https://github.com/apache/metron/pull/1578#issuecomment-619465410 @ottobackwards Do you means the HDP 3.1? HDP 3.1 use ambari 2.7.3. Also the fix is also can used in ambari 2.4+ , because from ambari 2.4 it introduce the service advisor. And

[GitHub] [metron] ottobackwards commented on pull request #1578: METRON-2250 Missing services in HDP 3.1 metron mpack and installer stuck

2020-04-25 Thread GitBox
ottobackwards commented on pull request #1578: URL: https://github.com/apache/metron/pull/1578#issuecomment-619376122 We currently don't support 3.1. There is feature branch where that work is being done. You may want to send an email to the dev@ list and ask about the status.

[GitHub] [metron] zhaoyim opened a new pull request #1578: METRON-2250 Missing services in HDP 3.1 metron mpack and installer stuck

2020-04-24 Thread GitBox
zhaoyim opened a new pull request #1578: URL: https://github.com/apache/metron/pull/1578 ## Contributor Comments [Please place any comments here. A description of the problem/enhancement, how to reproduce the issue, your testing methodology, etc.] ## Pull Request Checklist

[GitHub] [metron-bro-plugin-kafka] asfgit closed pull request #38: METRON-2288 bro-kafka-plugin Should have own RC scripts

2020-02-27 Thread GitBox
asfgit closed pull request #38: METRON-2288 bro-kafka-plugin Should have own RC scripts URL: https://github.com/apache/metron-bro-plugin-kafka/pull/38 This is an automated message from the Apache Git Service. To respond to

[GitHub] [metron] ottobackwards closed pull request #1261: METRON-1860 new developer option for ansible in docker to deploy to vagrant

2020-02-27 Thread GitBox
ottobackwards closed pull request #1261: METRON-1860 new developer option for ansible in docker to deploy to vagrant URL: https://github.com/apache/metron/pull/1261 This is an automated message from the Apache Git Service.

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on issue #38: METRON-2288 bro-kafka-plugin Should have own RC scripts

2020-02-27 Thread GitBox
ottobackwards commented on issue #38: METRON-2288 bro-kafka-plugin Should have own RC scripts URL: https://github.com/apache/metron-bro-plugin-kafka/pull/38#issuecomment-592006039 I"m going to merge this This is an

[GitHub] [metron] mmiklavc commented on issue #1552: METRON-2341 [dependabot] Bump nimbus-jose-jwt from 4.41.2 to 7.9 in /metron-interface/metron-rest

2020-01-16 Thread GitBox
mmiklavc commented on issue #1552: METRON-2341 [dependabot] Bump nimbus-jose-jwt from 4.41.2 to 7.9 in /metron-interface/metron-rest URL: https://github.com/apache/metron/pull/1552#issuecomment-575449364 For posterity: Since there's no dependabot repo to merge from, I merged this in

[GitHub] [metron] dependabot[bot] commented on issue #1552: METRON-2341 [dependabot] Bump nimbus-jose-jwt from 4.41.2 to 7.9 in /metron-interface/metron-rest

2020-01-16 Thread GitBox
dependabot[bot] commented on issue #1552: METRON-2341 [dependabot] Bump nimbus-jose-jwt from 4.41.2 to 7.9 in /metron-interface/metron-rest URL: https://github.com/apache/metron/pull/1552#issuecomment-575449327 OK, I won't notify you again about this release, but will get in touch when a

[GitHub] [metron] asfgit closed pull request #1552: METRON-2341 [dependabot] Bump nimbus-jose-jwt from 4.41.2 to 7.9 in /metron-interface/metron-rest

2020-01-16 Thread GitBox
asfgit closed pull request #1552: METRON-2341 [dependabot] Bump nimbus-jose-jwt from 4.41.2 to 7.9 in /metron-interface/metron-rest URL: https://github.com/apache/metron/pull/1552 This is an automated message from the

[GitHub] [metron] mmiklavc commented on issue #1552: Bump nimbus-jose-jwt from 4.41.2 to 7.9 in /metron-interface/metron-rest

2020-01-15 Thread GitBox
mmiklavc commented on issue #1552: Bump nimbus-jose-jwt from 4.41.2 to 7.9 in /metron-interface/metron-rest URL: https://github.com/apache/metron/pull/1552#issuecomment-574901014 +1 by verification on full dev. The reason I tested Knox is because the affected library, jwt, is used for

[GitHub] [metron] sziszo commented on issue #1576: METRON-2336 Stack advisor provides some components multiple times (santal)

2020-01-14 Thread GitBox
sziszo commented on issue #1576: METRON-2336 Stack advisor provides some components multiple times (santal) URL: https://github.com/apache/metron/pull/1576#issuecomment-574336293 Afaik it can be merged. This is an automated

[GitHub] [metron] ottobackwards commented on issue #1282: METRON-1881: Update the bro plugin used in metron development

2020-01-14 Thread GitBox
ottobackwards commented on issue #1282: METRON-1881: Update the bro plugin used in metron development URL: https://github.com/apache/metron/pull/1282#issuecomment-574329851 +1 This is an automated message from the Apache Git

[GitHub] [metron] mmiklavc commented on issue #1552: Bump nimbus-jose-jwt from 4.41.2 to 7.9 in /metron-interface/metron-rest

2020-01-14 Thread GitBox
mmiklavc commented on issue #1552: Bump nimbus-jose-jwt from 4.41.2 to 7.9 in /metron-interface/metron-rest URL: https://github.com/apache/metron/pull/1552#issuecomment-574302303 I created a Jira for this - https://issues.apache.org/jira/browse/METRON-2341

[GitHub] [metron] mmiklavc commented on issue #1282: METRON-1881: Update the bro plugin used in metron development

2020-01-14 Thread GitBox
mmiklavc commented on issue #1282: METRON-1881: Update the bro plugin used in metron development URL: https://github.com/apache/metron/pull/1282#issuecomment-574270322 > +1 by inspection. > > @ottobackwards anything you need to see? Bump - @ottobackwards?

[GitHub] [metron] mmiklavc commented on issue #1576: METRON-2336 Stack advisor provides some components multiple times (santal)

2020-01-13 Thread GitBox
mmiklavc commented on issue #1576: METRON-2336 Stack advisor provides some components multiple times (santal) URL: https://github.com/apache/metron/pull/1576#issuecomment-574027778 Is there anything further holding this up or can this be merged?

[GitHub] [metron] nickwallen commented on a change in pull request #1577: METRON-2330: Add global profile in foreach desc

2020-01-10 Thread GitBox
nickwallen commented on a change in pull request #1577: METRON-2330: Add global profile in foreach desc URL: https://github.com/apache/metron/pull/1577#discussion_r365295072 ## File path: site/current-book/metron-analytics/metron-profiler-common/index.html ## @@ -289,7

[GitHub] [metron] DimDroll opened a new pull request #1577: METRON-2330: Add global profile in foreach desc

2020-01-09 Thread GitBox
DimDroll opened a new pull request #1577: METRON-2330: Add global profile in foreach desc URL: https://github.com/apache/metron/pull/1577 ## Contributor Comments I had a hard time figuring out the reason behind using exactly 'global'. So shedding a little more light on it. ##

[GitHub] [metron] justinleet commented on issue #1282: METRON-1881: Update the bro plugin used in metron development

2019-12-17 Thread GitBox
justinleet commented on issue #1282: METRON-1881: Update the bro plugin used in metron development URL: https://github.com/apache/metron/pull/1282#issuecomment-566789863 +1 by inspection. @ottobackwards anything you need to see?

[GitHub] [metron] JonZeolla commented on issue #1282: METRON-1881: Update the bro plugin used in metron development

2019-12-13 Thread GitBox
JonZeolla commented on issue #1282: METRON-1881: Update the bro plugin used in metron development URL: https://github.com/apache/metron/pull/1282#issuecomment-565662697 Yeah should be good Jon Zeolla On Fri, Dec 13, 2019, 4:40 PM Otto Fowler wrote: > So I landed

[GitHub] [metron] asfgit closed pull request #1533: METRON-2292: [UI] Manual query can't be saved on the Alerts UI

2019-12-13 Thread GitBox
asfgit closed pull request #1533: METRON-2292: [UI] Manual query can't be saved on the Alerts UI URL: https://github.com/apache/metron/pull/1533 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [metron] sardell commented on issue #1533: METRON-2292: [UI] Manual query can't be saved on the Alerts UI

2019-12-13 Thread GitBox
sardell commented on issue #1533: METRON-2292: [UI] Manual query can't be saved on the Alerts UI URL: https://github.com/apache/metron/pull/1533#issuecomment-565620887 @ruffle1986 I'm actually unable to reproduce the bug now. I think I might've been using an old VM build before to test,

[GitHub] [metron] ottobackwards commented on issue #1282: METRON-1881: Update the bro plugin used in metron development

2019-12-13 Thread GitBox
ottobackwards commented on issue #1282: METRON-1881: Update the bro plugin used in metron development URL: https://github.com/apache/metron/pull/1282#issuecomment-565618330 So I landed https://github.com/apache/metron-bro-plugin-kafka/pull/36, and I believe this would be good to go now.

[GitHub] [metron] asfgit closed pull request #1527: METRON-2276: [UI] Performance: Switching back from manual filtering fires a "full query"

2019-12-13 Thread GitBox
asfgit closed pull request #1527: METRON-2276: [UI] Performance: Switching back from manual filtering fires a "full query" URL: https://github.com/apache/metron/pull/1527 This is an automated message from the Apache Git

[GitHub] [metron] justinleet commented on issue #1282: METRON-1881: Update the bro plugin used in metron development

2019-12-13 Thread GitBox
justinleet commented on issue #1282: METRON-1881: Update the bro plugin used in metron development URL: https://github.com/apache/metron/pull/1282#issuecomment-565605449 @JonZeolla @ottobackwards Is this good to go, and is it something we should try to get into 0.7.2 (or whatever it winds

[GitHub] [metron] sardell commented on issue #1527: METRON-2276: [UI] Performance: Switching back from manual filtering fires a "full query"

2019-12-13 Thread GitBox
sardell commented on issue #1527: METRON-2276: [UI] Performance: Switching back from manual filtering fires a "full query" URL: https://github.com/apache/metron/pull/1527#issuecomment-565509712 Great question. We were hoping to get some feedback from users regarding whether or not the

[GitHub] [metron] ruffle1986 edited a comment on issue #1533: METRON-2292: [UI] Manual query can't be saved on the Alerts UI

2019-12-13 Thread GitBox
ruffle1986 edited a comment on issue #1533: METRON-2292: [UI] Manual query can't be saved on the Alerts UI URL: https://github.com/apache/metron/pull/1533#issuecomment-565441784 According to the gif, I tried to reproduce the problem by following the exact same steps. Could you please

[GitHub] [metron] sardell commented on issue #1575: METRON-2335: [UI] Implement synchronization between browser user state and Hbase user state

2019-12-13 Thread GitBox
sardell commented on issue #1575: METRON-2335: [UI] Implement synchronization between browser user state and Hbase user state URL: https://github.com/apache/metron/pull/1575#issuecomment-565442931 @ruffle1986 Thanks for the thorough explanation. > So basically it's an issue on the

[GitHub] [metron] ruffle1986 commented on issue #1533: METRON-2292: [UI] Manual query can't be saved on the Alerts UI

2019-12-13 Thread GitBox
ruffle1986 commented on issue #1533: METRON-2292: [UI] Manual query can't be saved on the Alerts UI URL: https://github.com/apache/metron/pull/1533#issuecomment-565441784 According to the gif, I tried to reproduce the problem by following the exact same steps. Could you please provide a

[GitHub] [metron] ruffle1986 commented on issue #1527: METRON-2276: [UI] Performance: Switching back from manual filtering fires a "full query"

2019-12-13 Thread GitBox
ruffle1986 commented on issue #1527: METRON-2276: [UI] Performance: Switching back from manual filtering fires a "full query" URL: https://github.com/apache/metron/pull/1527#issuecomment-565431032 What's the status of this PR?

[GitHub] [metron] ruffle1986 commented on issue #1575: METRON-2335: [UI] Implement synchronization between browser user state and Hbase user state

2019-12-13 Thread GitBox
ruffle1986 commented on issue #1575: METRON-2335: [UI] Implement synchronization between browser user state and Hbase user state URL: https://github.com/apache/metron/pull/1575#issuecomment-565408917 Good points, @sardell .  This PR is focusing on the replacement of the services

[GitHub] [metron] MohanDV commented on issue #1576: METRON-2336 Stack advisor provides some components multiple times (santal)

2019-12-13 Thread GitBox
MohanDV commented on issue #1576: METRON-2336 Stack advisor provides some components multiple times (santal) URL: https://github.com/apache/metron/pull/1576#issuecomment-565393251 +1 by verification . Thanks for the fix @sziszo !

[GitHub] [metron] sardell edited a comment on issue #1575: METRON-2335: [UI] Implement synchronization between browser user state and Hbase user state

2019-12-12 Thread GitBox
sardell edited a comment on issue #1575: METRON-2335: [UI] Implement synchronization between browser user state and Hbase user state URL: https://github.com/apache/metron/pull/1575#issuecomment-565151301 I tested all of the user settings you mentioned with full dev and everything works

[GitHub] [metron] sardell commented on issue #1575: METRON-2335: [UI] Implement synchronization between browser user state and Hbase user state

2019-12-12 Thread GitBox
sardell commented on issue #1575: METRON-2335: [UI] Implement synchronization between browser user state and Hbase user state URL: https://github.com/apache/metron/pull/1575#issuecomment-565151301 I tested all of the user settings you mentioned with full dev and everything works great

[GitHub] [metron] sziszo edited a comment on issue #1576: METRON-2336 Stack advisor provides some components multiple times (santal)

2019-12-12 Thread GitBox
sziszo edited a comment on issue #1576: METRON-2336 Stack advisor provides some components multiple times (santal) URL: https://github.com/apache/metron/pull/1576#issuecomment-565076744 @MohanDV That's weird, I could reproduce it on a 5 node cluster as well. I tested with the following

[GitHub] [metron] sziszo commented on issue #1576: METRON-2336 Stack advisor provides some components multiple times (santal)

2019-12-12 Thread GitBox
sziszo commented on issue #1576: METRON-2336 Stack advisor provides some components multiple times (santal) URL: https://github.com/apache/metron/pull/1576#issuecomment-565076744 @MohanDV That's weird, I could reproduce it on a 5 node cluster as well. I tested with the following steps:

[GitHub] [metron] ruffle1986 commented on issue #1575: METRON-2335: [UI] Implement synchronization between browser user state and Hbase user state

2019-12-12 Thread GitBox
ruffle1986 commented on issue #1575: METRON-2335: [UI] Implement synchronization between browser user state and Hbase user state URL: https://github.com/apache/metron/pull/1575#issuecomment-564994299 @sardell found a race condition in the app during testing. I tested the changes with the

[GitHub] [metron] MohanDV commented on issue #1576: METRON-2336 Stack advisor provides some components multiple times (santal)

2019-12-12 Thread GitBox
MohanDV commented on issue #1576: METRON-2336 Stack advisor provides some components multiple times (santal) URL: https://github.com/apache/metron/pull/1576#issuecomment-564990485 @sziszo I couldn't reproduce the issue on a 5 node cluster with 2.0.0.0-4 mpack, do we have steps to

[GitHub] [metron] ruffle1986 commented on issue #1575: METRON-2335: [UI] Implement synchronization between browser user state and Hbase user state

2019-12-12 Thread GitBox
ruffle1986 commented on issue #1575: METRON-2335: [UI] Implement synchronization between browser user state and Hbase user state URL: https://github.com/apache/metron/pull/1575#issuecomment-564975083 I'm closing and re-opening the PR to force Travis to run the build again.

[GitHub] [metron] ruffle1986 closed pull request #1575: METRON-2335: [UI] Implement synchronization between browser user state and Hbase user state

2019-12-12 Thread GitBox
ruffle1986 closed pull request #1575: METRON-2335: [UI] Implement synchronization between browser user state and Hbase user state URL: https://github.com/apache/metron/pull/1575 This is an automated message from the Apache

[GitHub] [metron] ruffle1986 opened a new pull request #1575: METRON-2335: [UI] Implement synchronization between browser user state and Hbase user state

2019-12-12 Thread GitBox
ruffle1986 opened a new pull request #1575: METRON-2335: [UI] Implement synchronization between browser user state and Hbase user state URL: https://github.com/apache/metron/pull/1575 ## Contributor Comments Link to the original JIRA:

[GitHub] [metron] anandsubbu commented on a change in pull request #1572: METRON-2327 - Support for SOLR time-based arrays

2019-12-12 Thread GitBox
anandsubbu commented on a change in pull request #1572: METRON-2327 - Support for SOLR time-based arrays URL: https://github.com/apache/metron/pull/1572#discussion_r357038892 ## File path: metron-platform/metron-solr/metron-solr-common/src/main/scripts/create_configset.sh

[GitHub] [metron] anandsubbu commented on a change in pull request #1572: METRON-2327 - Support for SOLR time-based arrays

2019-12-12 Thread GitBox
anandsubbu commented on a change in pull request #1572: METRON-2327 - Support for SOLR time-based arrays URL: https://github.com/apache/metron/pull/1572#discussion_r357046733 ## File path: metron-platform/metron-solr/metron-solr-common/README.md ## @@ -164,3 +164,142 @@

[GitHub] [metron] anandsubbu commented on a change in pull request #1572: METRON-2327 - Support for SOLR time-based arrays

2019-12-12 Thread GitBox
anandsubbu commented on a change in pull request #1572: METRON-2327 - Support for SOLR time-based arrays URL: https://github.com/apache/metron/pull/1572#discussion_r357051130 ## File path: metron-platform/metron-solr/metron-solr-common/README.md ## @@ -164,3 +164,142 @@

[GitHub] [metron] anandsubbu commented on a change in pull request #1572: METRON-2327 - Support for SOLR time-based arrays

2019-12-12 Thread GitBox
anandsubbu commented on a change in pull request #1572: METRON-2327 - Support for SOLR time-based arrays URL: https://github.com/apache/metron/pull/1572#discussion_r357032259 ## File path: metron-platform/metron-solr/metron-solr-common/src/main/scripts/create_configset.sh

[GitHub] [metron] nickwallen commented on issue #1576: METRON-2336 Stack advisor provides some components multiple times (santal)

2019-12-11 Thread GitBox
nickwallen commented on issue #1576: METRON-2336 Stack advisor provides some components multiple times (santal) URL: https://github.com/apache/metron/pull/1576#issuecomment-564723245 I ran this up in the dev environment and it looks good. Will be interested in @MohanDV 's feedback too.

[GitHub] [metron] sziszo opened a new pull request #1576: METRON-2336 Stack advisor provides some components multiple times (santal)

2019-12-11 Thread GitBox
sziszo opened a new pull request #1576: METRON-2336 Stack advisor provides some components multiple times (santal) URL: https://github.com/apache/metron/pull/1576 ## Contributor Comments Customer is in Ambari 2.7.4.0-118 and metron mpack version hcp-ambari-mpack-2.0.0.0-4 Currently

[GitHub] [metron] ruffle1986 opened a new pull request #1575: METRON-2335: [UI] Implement synchronization between browser user state and Hbase user state

2019-12-11 Thread GitBox
ruffle1986 opened a new pull request #1575: METRON-2335: [UI] Implement synchronization between browser user state and Hbase user state URL: https://github.com/apache/metron/pull/1575 ## Contributor Comments Link to the original JIRA:

[GitHub] [metron] tigerquoll commented on a change in pull request #1572: METRON-2327 - Support for SOLR time-based arrays

2019-12-08 Thread GitBox
tigerquoll commented on a change in pull request #1572: METRON-2327 - Support for SOLR time-based arrays URL: https://github.com/apache/metron/pull/1572#discussion_r355248137 ## File path: metron-platform/metron-solr/metron-solr-common/README.md ## @@ -164,3 +164,142 @@

[GitHub] [metron] asfgit closed pull request #1554: METRON-2307: Migrate to JUnit5

2019-12-07 Thread GitBox
asfgit closed pull request #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [metron] asfgit closed pull request #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures

2019-12-06 Thread GitBox
asfgit closed pull request #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures URL: https://github.com/apache/metron/pull/1568 This is an automated message from the Apache

[GitHub] [metron] ottobackwards commented on issue #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures

2019-12-06 Thread GitBox
ottobackwards commented on issue #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures URL: https://github.com/apache/metron/pull/1568#issuecomment-562734214 No, I am fine with _any_ improvement.

[GitHub] [metron] justinleet commented on issue #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures

2019-12-06 Thread GitBox
justinleet commented on issue #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures URL: https://github.com/apache/metron/pull/1568#issuecomment-562721005 @ottobackwards Are you okay with this approach, or should we keep looking for an

[GitHub] [metron] nickwallen commented on issue #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures

2019-12-06 Thread GitBox
nickwallen commented on issue #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures URL: https://github.com/apache/metron/pull/1568#issuecomment-562709295 +1 Thanks @justinleet

[GitHub] [metron] justinleet commented on issue #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures

2019-12-06 Thread GitBox
justinleet commented on issue #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures URL: https://github.com/apache/metron/pull/1568#issuecomment-562708346 @nickwallen Should be fixed with a proper exit code in the main script and a more

[GitHub] [metron] nickwallen commented on issue #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures

2019-12-06 Thread GitBox
nickwallen commented on issue #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures URL: https://github.com/apache/metron/pull/1568#issuecomment-562699207 All the changes are looking good. I am just seeing one issue with the validation. I

[GitHub] [metron] justinleet commented on issue #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures

2019-12-06 Thread GitBox
justinleet commented on issue #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures URL: https://github.com/apache/metron/pull/1568#issuecomment-562633094 I believe `package` is insufficient, it needs to be `install`, because the deps are

[GitHub] [metron] ottobackwards commented on issue #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures

2019-12-06 Thread GitBox
ottobackwards commented on issue #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures URL: https://github.com/apache/metron/pull/1568#issuecomment-562624975 https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle

[GitHub] [metron] justinleet commented on issue #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures

2019-12-06 Thread GitBox
justinleet commented on issue #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures URL: https://github.com/apache/metron/pull/1568#issuecomment-562622645 I moved over to skip.npm in the Travis builds. I haven't run that locally, I'm just

[GitHub] [metron] nickwallen commented on issue #1554: METRON-2307: Migrate to JUnit5

2019-12-06 Thread GitBox
nickwallen commented on issue #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#issuecomment-562604594 Many thanks @justinleet! Kudos for the contribution. This is an automated message from

[GitHub] [metron] nickwallen commented on a change in pull request #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures

2019-12-06 Thread GitBox
nickwallen commented on a change in pull request #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures URL: https://github.com/apache/metron/pull/1568#discussion_r354871862 ## File path: .travis.yml ## @@ -60,6 +60,7 @@

[GitHub] [metron] mmiklavc commented on issue #1554: METRON-2307: Migrate to JUnit5

2019-12-06 Thread GitBox
mmiklavc commented on issue #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#issuecomment-562596371 +1. Huge contribution @justinleet, thanks and nice work! This is an automated message

[GitHub] [metron] justinleet commented on a change in pull request #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures

2019-12-06 Thread GitBox
justinleet commented on a change in pull request #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures URL: https://github.com/apache/metron/pull/1568#discussion_r354862975 ## File path: .travis.yml ## @@ -60,6 +60,7 @@

[GitHub] [metron] ottobackwards commented on issue #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures

2019-12-06 Thread GitBox
ottobackwards commented on issue #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures URL: https://github.com/apache/metron/pull/1568#issuecomment-562590955 Can't we just run it as part of the root pom? Like the last module in the list or

[GitHub] [metron] nickwallen commented on a change in pull request #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures

2019-12-06 Thread GitBox
nickwallen commented on a change in pull request #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures URL: https://github.com/apache/metron/pull/1568#discussion_r354855951 ## File path: .travis.yml ## @@ -60,6 +60,7 @@

[GitHub] [metron] nickwallen commented on a change in pull request #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures

2019-12-06 Thread GitBox
nickwallen commented on a change in pull request #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures URL: https://github.com/apache/metron/pull/1568#discussion_r354855217 ## File path: .travis.yml ## @@ -60,6 +60,7 @@

[GitHub] [metron] justinleet commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5

2019-12-06 Thread GitBox
justinleet commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#discussion_r354852050 ## File path: metron-stellar/stellar-common/pom.xml ## @@ -230,11 +230,29 @@

[GitHub] [metron] justinleet commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5

2019-12-06 Thread GitBox
justinleet commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#discussion_r354851199 ## File path: metron-platform/metron-solr/metron-solr-common/pom.xml ## @@ -199,10 +199,15 @@

[GitHub] [metron] justinleet commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5

2019-12-06 Thread GitBox
justinleet commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#discussion_r354849397 ## File path: metron-analytics/metron-profiler-client/pom.xml ## @@ -122,8 +122,7 @@

[GitHub] [metron] mmiklavc commented on issue #1554: METRON-2307: Migrate to JUnit5

2019-12-05 Thread GitBox
mmiklavc commented on issue #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#issuecomment-562367370 @justinleet 2 minor comments and I think we're about there. This is an automated message

[GitHub] [metron] mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5

2019-12-05 Thread GitBox
mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#discussion_r354600534 ## File path: metron-platform/metron-solr/metron-solr-common/pom.xml ## @@ -199,10 +199,15 @@

[GitHub] [metron] mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5

2019-12-05 Thread GitBox
mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#discussion_r354598708 ## File path: metron-interface/pom.xml ## @@ -48,12 +48,6 @@ metron-rest-client -

[GitHub] [metron] mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5

2019-12-05 Thread GitBox
mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#discussion_r354597565 ## File path: metron-analytics/metron-profiler-client/pom.xml ## @@ -122,8 +122,7 @@

[GitHub] [metron] justinleet commented on a change in pull request #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures

2019-12-05 Thread GitBox
justinleet commented on a change in pull request #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures URL: https://github.com/apache/metron/pull/1568#discussion_r354474158 ## File path: dev-utilities/build-utils/list_dependencies.sh

[GitHub] [metron] justinleet commented on a change in pull request #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures

2019-12-05 Thread GitBox
justinleet commented on a change in pull request #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures URL: https://github.com/apache/metron/pull/1568#discussion_r354473625 ## File path: .travis.yml ## @@ -60,6 +60,7 @@

[GitHub] [metron] justinleet commented on issue #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures

2019-12-05 Thread GitBox
justinleet commented on issue #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures URL: https://github.com/apache/metron/pull/1568#issuecomment-562250993 @nickwallen Check out the ticket itself, I explain a bit more exactly what's happening

[GitHub] [metron] nickwallen commented on a change in pull request #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures

2019-12-05 Thread GitBox
nickwallen commented on a change in pull request #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures URL: https://github.com/apache/metron/pull/1568#discussion_r354464275 ## File path: dev-utilities/build-utils/list_dependencies.sh

[GitHub] [metron] asfgit closed pull request #1574: METRON-2332 Enable Tuning of the Profiler's Parallelism from Ambari

2019-12-05 Thread GitBox
asfgit closed pull request #1574: METRON-2332 Enable Tuning of the Profiler's Parallelism from Ambari URL: https://github.com/apache/metron/pull/1574 This is an automated message from the Apache Git Service. To respond to

[GitHub] [metron] anandsubbu commented on issue #1574: METRON-2332 Enable Tuning of the Profiler's Parallelism from Ambari

2019-12-05 Thread GitBox
anandsubbu commented on issue #1574: METRON-2332 Enable Tuning of the Profiler's Parallelism from Ambari URL: https://github.com/apache/metron/pull/1574#issuecomment-562043656 +1. Works as described! Spun up full dev and was able to make the changes as per the PR description. This

[GitHub] [metron] nickwallen opened a new pull request #1574: METRON-2332 Enable Tuning of the Profiler's Parallelism from Ambari

2019-12-04 Thread GitBox
nickwallen opened a new pull request #1574: METRON-2332 Enable Tuning of the Profiler's Parallelism from Ambari URL: https://github.com/apache/metron/pull/1574 When running the Streaming Profiler in Storm, tuning the parallelism of each component requires a user to edit the Flux file at

[GitHub] [metron] sardell commented on issue #1569: METRON-2325: Wrong validation message appears when clicking on input of existing group

2019-12-04 Thread GitBox
sardell commented on issue #1569: METRON-2325: Wrong validation message appears when clicking on input of existing group URL: https://github.com/apache/metron/pull/1569#issuecomment-561719481 This work has been merged into the feature branch.  As a result, I'm going to close this PR out.

[GitHub] [metron] sardell closed pull request #1569: METRON-2325: Wrong validation message appears when clicking on input of existing group

2019-12-04 Thread GitBox
sardell closed pull request #1569: METRON-2325: Wrong validation message appears when clicking on input of existing group URL: https://github.com/apache/metron/pull/1569 This is an automated message from the Apache Git

[GitHub] [metron] anandsubbu commented on a change in pull request #1572: METRON-2327 - Support for SOLR time-based arrays

2019-12-04 Thread GitBox
anandsubbu commented on a change in pull request #1572: METRON-2327 - Support for SOLR time-based arrays URL: https://github.com/apache/metron/pull/1572#discussion_r353655928 ## File path: metron-platform/metron-solr/metron-solr-common/README.md ## @@ -164,3 +164,142 @@

[GitHub] [metron] anandsubbu commented on a change in pull request #1572: METRON-2327 - Support for SOLR time-based arrays

2019-12-04 Thread GitBox
anandsubbu commented on a change in pull request #1572: METRON-2327 - Support for SOLR time-based arrays URL: https://github.com/apache/metron/pull/1572#discussion_r353655928 ## File path: metron-platform/metron-solr/metron-solr-common/README.md ## @@ -164,3 +164,142 @@

<    1   2   3   4   5   6   7   8   9   10   >