virajjasani commented on a change in pull request #920:
URL: https://github.com/apache/phoenix/pull/920#discussion_r509509727
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##
@@ -4364,17 +4353,17 @@ public void deleteMutexCe
[
https://issues.apache.org/jira/browse/PHOENIX-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220539#comment-17220539
]
ASF GitHub Bot commented on PHOENIX-6129:
-
virajjasani commented on a change in
[
https://issues.apache.org/jira/browse/PHOENIX-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220561#comment-17220561
]
Hadoop QA commented on PHOENIX-6124:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|
stoty commented on pull request #918:
URL: https://github.com/apache/phoenix/pull/918#issuecomment-716398034
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 9s | Doc
[
https://issues.apache.org/jira/browse/PHOENIX-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220564#comment-17220564
]
ASF GitHub Bot commented on PHOENIX-6178:
-
stoty commented on pull request #918
stoty commented on pull request #918:
URL: https://github.com/apache/phoenix/pull/918#issuecomment-716472323
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 5m 36s | Doc
[
https://issues.apache.org/jira/browse/PHOENIX-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220622#comment-17220622
]
ASF GitHub Bot commented on PHOENIX-6178:
-
stoty commented on pull request #918
[
https://issues.apache.org/jira/browse/PHOENIX-6206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220660#comment-17220660
]
ASF GitHub Bot commented on PHOENIX-6206:
-
stoty opened a new pull request #940
stoty opened a new pull request #940:
URL: https://github.com/apache/phoenix/pull/940
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
stoty commented on pull request #940:
URL: https://github.com/apache/phoenix/pull/940#issuecomment-71308
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 6m 51s | Doc
[
https://issues.apache.org/jira/browse/PHOENIX-6206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220799#comment-17220799
]
ASF GitHub Bot commented on PHOENIX-6206:
-
stoty commented on pull request #940
[
https://issues.apache.org/jira/browse/PHOENIX-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220857#comment-17220857
]
ASF GitHub Bot commented on PHOENIX-6129:
-
ChinmaySKulkarni commented on a chan
ChinmaySKulkarni commented on a change in pull request #920:
URL: https://github.com/apache/phoenix/pull/920#discussion_r512142414
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##
@@ -4364,17 +4353,17 @@ public void deleteMu
stoty closed pull request #940:
URL: https://github.com/apache/phoenix/pull/940
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/PHOENIX-6206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220892#comment-17220892
]
ASF GitHub Bot commented on PHOENIX-6206:
-
stoty closed pull request #940:
URL:
jpisaac closed pull request #916:
URL: https://github.com/apache/phoenix/pull/916
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
[
https://issues.apache.org/jira/browse/PHOENIX-6171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220914#comment-17220914
]
ASF GitHub Bot commented on PHOENIX-6171:
-
jpisaac closed pull request #916:
UR
ChinmaySKulkarni merged pull request #920:
URL: https://github.com/apache/phoenix/pull/920
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/PHOENIX-6171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220931#comment-17220931
]
ASF GitHub Bot commented on PHOENIX-6171:
-
jpisaac opened a new pull request #9
[
https://issues.apache.org/jira/browse/PHOENIX-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220933#comment-17220933
]
ASF GitHub Bot commented on PHOENIX-6129:
-
ChinmaySKulkarni merged pull request
jpisaac commented on pull request #916:
URL: https://github.com/apache/phoenix/pull/916#issuecomment-716754717
@yanxinyi @ChinmaySKulkarni rebased and fixed conflicts
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/PHOENIX-6171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220935#comment-17220935
]
ASF GitHub Bot commented on PHOENIX-6171:
-
jpisaac commented on pull request #9
[
https://issues.apache.org/jira/browse/PHOENIX-6171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220950#comment-17220950
]
ASF GitHub Bot commented on PHOENIX-6171:
-
ChinmaySKulkarni commented on a chan
ChinmaySKulkarni commented on a change in pull request #916:
URL: https://github.com/apache/phoenix/pull/916#discussion_r509545181
##
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewTTLIT.java
##
@@ -61,22 +62,31 @@
private static final Logger LOGGER =
[
https://issues.apache.org/jira/browse/PHOENIX-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220957#comment-17220957
]
Hadoop QA commented on PHOENIX-5998:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|
[
https://issues.apache.org/jira/browse/PHOENIX-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220981#comment-17220981
]
Chinmay Kulkarni commented on PHOENIX-6129:
---
Committed to master and 4.x. Tha
stoty commented on pull request #910:
URL: https://github.com/apache/phoenix/pull/910#issuecomment-716808023
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 4m 20s | Doc
[
https://issues.apache.org/jira/browse/PHOENIX-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220994#comment-17220994
]
ASF GitHub Bot commented on PHOENIX-5998:
-
stoty commented on pull request #936
stoty commented on pull request #936:
URL: https://github.com/apache/phoenix/pull/936#issuecomment-716821761
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 6m 31s | Doc
gjacoby126 commented on pull request #935:
URL: https://github.com/apache/phoenix/pull/935#issuecomment-716834823
Three tests failed (IndexExtendedIT, UpgradeIT, ImmutableIndexIT), but two
were timeouts (the index tests), and all pass when run locally so appear to be
flappers.
[
https://issues.apache.org/jira/browse/PHOENIX-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221000#comment-17221000
]
ASF GitHub Bot commented on PHOENIX-6186:
-
gjacoby126 commented on pull request
stoty commented on pull request #916:
URL: https://github.com/apache/phoenix/pull/916#issuecomment-716842752
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 5m 18s | Doc
[
https://issues.apache.org/jira/browse/PHOENIX-6171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221004#comment-17221004
]
ASF GitHub Bot commented on PHOENIX-6171:
-
stoty commented on pull request #916
kadirozde commented on a change in pull request #936:
URL: https://github.com/apache/phoenix/pull/936#discussion_r512309864
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/iterate/UngroupedAggregatingResultIterator.java
##
@@ -36,19 +37,33 @@ public UngroupedAggreg
[
https://issues.apache.org/jira/browse/PHOENIX-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221014#comment-17221014
]
ASF GitHub Bot commented on PHOENIX-5998:
-
kadirozde commented on a change in p
[
https://issues.apache.org/jira/browse/PHOENIX-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221015#comment-17221015
]
ASF GitHub Bot commented on PHOENIX-5998:
-
kadirozde commented on pull request
kadirozde commented on pull request #936:
URL: https://github.com/apache/phoenix/pull/936#issuecomment-716862262
@ChinmaySKulkarni, @gjacoby126, or anyone else who wants to review this PR,
if you do not have any questions or comments, can I get your approval? Thanks
--
[
https://issues.apache.org/jira/browse/PHOENIX-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221016#comment-17221016
]
Hadoop QA commented on PHOENIX-6129:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|
gjacoby126 commented on pull request #936:
URL: https://github.com/apache/phoenix/pull/936#issuecomment-716864823
@kadirozde - UpsertSelectIT seems to have crashed in the last test run. (And
timeouts for SequencePointInTimeIT and IndexToolForNonTxGlobalIndexIT). Have
these passed elsewhere
[
https://issues.apache.org/jira/browse/PHOENIX-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221019#comment-17221019
]
ASF GitHub Bot commented on PHOENIX-5998:
-
gjacoby126 commented on pull request
[
https://issues.apache.org/jira/browse/PHOENIX-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221020#comment-17221020
]
Hadoop QA commented on PHOENIX-6129:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|
kadirozde commented on pull request #936:
URL: https://github.com/apache/phoenix/pull/936#issuecomment-716866775
> @kadirozde - UpsertSelectIT seems to have crashed in the last test run.
(And timeouts for SequencePointInTimeIT and IndexToolForNonTxGlobalIndexIT).
Have these passed elsewher
[
https://issues.apache.org/jira/browse/PHOENIX-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221023#comment-17221023
]
ASF GitHub Bot commented on PHOENIX-5998:
-
kadirozde commented on pull request
[
https://issues.apache.org/jira/browse/PHOENIX-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221024#comment-17221024
]
Chinmay Kulkarni commented on PHOENIX-6186:
---
[~gjacoby] As far as naming goes
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221046#comment-17221046
]
Xinyi Yan commented on PHOENIX-5712:
Hi [~larsh], I upload a new patch that retriev
[
https://issues.apache.org/jira/browse/PHOENIX-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221024#comment-17221024
]
Chinmay Kulkarni edited comment on PHOENIX-6186 at 10/27/20, 12:28 AM:
--
stoty commented on pull request #936:
URL: https://github.com/apache/phoenix/pull/936#issuecomment-716904144
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 4s | Doc
[
https://issues.apache.org/jira/browse/PHOENIX-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221057#comment-17221057
]
ASF GitHub Bot commented on PHOENIX-5998:
-
stoty commented on pull request #936
ChinmaySKulkarni commented on a change in pull request #935:
URL: https://github.com/apache/phoenix/pull/935#discussion_r512334756
##
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java
##
@@ -387,6 +388,31 @@ public void testViewUsesTableLocalIndex() thr
ChinmaySKulkarni commented on a change in pull request #935:
URL: https://github.com/apache/phoenix/pull/935#discussion_r512338581
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/AddColumnMutator.java
##
@@ -399,6 +399,10 @@ public MetaDataMutationResul
[
https://issues.apache.org/jira/browse/PHOENIX-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221059#comment-17221059
]
ASF GitHub Bot commented on PHOENIX-6186:
-
ChinmaySKulkarni commented on a chan
ChinmaySKulkarni commented on a change in pull request #935:
URL: https://github.com/apache/phoenix/pull/935#discussion_r512347866
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
##
@@ -3048,7 +3048,13 @@ public boolean isViewReferenced()
[
https://issues.apache.org/jira/browse/PHOENIX-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221060#comment-17221060
]
ASF GitHub Bot commented on PHOENIX-6186:
-
ChinmaySKulkarni commented on a chan
[
https://issues.apache.org/jira/browse/PHOENIX-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221058#comment-17221058
]
ASF GitHub Bot commented on PHOENIX-6186:
-
ChinmaySKulkarni commented on a chan
ChinmaySKulkarni commented on pull request #936:
URL: https://github.com/apache/phoenix/pull/936#issuecomment-716908659
@kadirozde The changes are substantial and I will need some heads-down time
to review them. If it is urgent, please feel free to rely on other's reviews
and don't wait fo
[
https://issues.apache.org/jira/browse/PHOENIX-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221064#comment-17221064
]
ASF GitHub Bot commented on PHOENIX-5998:
-
ChinmaySKulkarni commented on pull r
ChinmaySKulkarni edited a comment on pull request #936:
URL: https://github.com/apache/phoenix/pull/936#issuecomment-716908659
@kadirozde The changes are substantial and I will need some heads-down time
to review them. If it is urgent, please feel free to rely on other's reviews
and don't
[
https://issues.apache.org/jira/browse/PHOENIX-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221065#comment-17221065
]
ASF GitHub Bot commented on PHOENIX-5998:
-
ChinmaySKulkarni edited a comment on
[
https://issues.apache.org/jira/browse/PHOENIX-6171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221103#comment-17221103
]
ASF GitHub Bot commented on PHOENIX-6171:
-
jpisaac commented on a change in pul
jpisaac commented on a change in pull request #916:
URL: https://github.com/apache/phoenix/pull/916#discussion_r512392228
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
##
@@ -2639,6 +2646,20 @@ private MetaDataMutationResult
jpisaac commented on a change in pull request #916:
URL: https://github.com/apache/phoenix/pull/916#discussion_r512394047
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
##
@@ -2077,6 +2077,13 @@ private PTable createTableInternal(CreateT
[
https://issues.apache.org/jira/browse/PHOENIX-6171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221108#comment-17221108
]
ASF GitHub Bot commented on PHOENIX-6171:
-
jpisaac commented on a change in pul
jpisaac commented on a change in pull request #916:
URL: https://github.com/apache/phoenix/pull/916#discussion_r512394047
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
##
@@ -2077,6 +2077,13 @@ private PTable createTableInternal(CreateT
[
https://issues.apache.org/jira/browse/PHOENIX-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221095#comment-17221095
]
ASF GitHub Bot commented on PHOENIX-5998:
-
kadirozde commented on pull request
kadirozde commented on pull request #936:
URL: https://github.com/apache/phoenix/pull/936#issuecomment-716946162
> @kadirozde The changes are substantial and I will need some heads-down
time to review them. If it is urgent, please feel free to rely on other's
reviews and don't wait for me.
[
https://issues.apache.org/jira/browse/PHOENIX-6171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221109#comment-17221109
]
ASF GitHub Bot commented on PHOENIX-6171:
-
jpisaac commented on a change in pul
[
https://issues.apache.org/jira/browse/PHOENIX-6171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221105#comment-17221105
]
ASF GitHub Bot commented on PHOENIX-6171:
-
jpisaac commented on a change in pul
jpisaac commented on a change in pull request #916:
URL: https://github.com/apache/phoenix/pull/916#discussion_r512393224
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
##
@@ -2639,6 +2646,20 @@ private MetaDataMutationResult
jpisaac commented on pull request #916:
URL: https://github.com/apache/phoenix/pull/916#issuecomment-716962568
@ChinmaySKulkarni @yanxinyi Addressed review comments and rebased to resolve
merge conflicts.
This is an automate
[
https://issues.apache.org/jira/browse/PHOENIX-6171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221123#comment-17221123
]
ASF GitHub Bot commented on PHOENIX-6171:
-
jpisaac commented on pull request #9
[
https://issues.apache.org/jira/browse/PHOENIX-6144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221153#comment-17221153
]
Istvan Toth commented on PHOENIX-6144:
--
shading protobuf-java into phoenix-client-
stoty closed pull request #918:
URL: https://github.com/apache/phoenix/pull/918
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/PHOENIX-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221163#comment-17221163
]
ASF GitHub Bot commented on PHOENIX-6178:
-
stoty closed pull request #918:
URL:
stoty commented on pull request #916:
URL: https://github.com/apache/phoenix/pull/916#issuecomment-717021826
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35s | Doc
[
https://issues.apache.org/jira/browse/PHOENIX-6171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221177#comment-17221177
]
ASF GitHub Bot commented on PHOENIX-6171:
-
stoty commented on pull request #916
stoty opened a new pull request #941:
URL: https://github.com/apache/phoenix/pull/941
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
[
https://issues.apache.org/jira/browse/PHOENIX-6208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221180#comment-17221180
]
ASF GitHub Bot commented on PHOENIX-6208:
-
stoty opened a new pull request #941
77 matches
Mail list logo