[PR] Fix behavior change config VALIDATE_VIEW_LOCATION_OVERLAP [polaris]

2025-03-18 Thread via GitHub
eric-maynard opened a new pull request, #1201: URL: https://github.com/apache/polaris/pull/1201 The BehaviorChangeConfiguration added in #1124 as an example actually has the wrong config name; this fix is also picked up in #1170 but per [this comment](https://github.com/apache/polaris/pull/

Re: [PR] Add annotation @BehaviorChangeSince for behavior-change flags [polaris]

2025-03-18 Thread via GitHub
eric-maynard commented on code in PR #1170: URL: https://github.com/apache/polaris/pull/1170#discussion_r2002452891 ## polaris-core/src/main/java/org/apache/polaris/core/config/BehaviorChangeProcessor.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Refactor EntityCache into an interface [polaris]

2025-03-18 Thread via GitHub
eric-maynard commented on code in PR #1193: URL: https://github.com/apache/polaris/pull/1193#discussion_r2002459383 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/cache/EntityCacheInterface.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Add annotation @BehaviorChangeSince for behavior-change flags [polaris]

2025-03-18 Thread via GitHub
eric-maynard commented on code in PR #1170: URL: https://github.com/apache/polaris/pull/1170#discussion_r2002457481 ## polaris-core/src/main/java/org/apache/polaris/core/config/BehaviorChangeConfiguration.java: ## @@ -37,9 +37,10 @@ protected BehaviorChangeConfiguration( su

Re: [PR] Add annotation @BehaviorChangeSince for behavior-change flags [polaris]

2025-03-18 Thread via GitHub
eric-maynard commented on code in PR #1170: URL: https://github.com/apache/polaris/pull/1170#discussion_r2002440025 ## build-logic/src/main/kotlin/polaris-java.gradle.kts: ## @@ -160,6 +160,45 @@ tasks.withType(Jar::class).configureEach { } } +class StaleBehaviorChangeConf

Re: [PR] Add annotation @BehaviorChangeSince for behavior-change flags [polaris]

2025-03-18 Thread via GitHub
eric-maynard commented on code in PR #1170: URL: https://github.com/apache/polaris/pull/1170#discussion_r2002452891 ## polaris-core/src/main/java/org/apache/polaris/core/config/BehaviorChangeProcessor.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Add annotation @BehaviorChangeSince for behavior-change flags [polaris]

2025-03-18 Thread via GitHub
eric-maynard commented on code in PR #1170: URL: https://github.com/apache/polaris/pull/1170#discussion_r2002452496 ## polaris-core/src/main/java/org/apache/polaris/core/config/BehaviorChangeProcessor.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Fix updating the storage config [polaris]

2025-03-18 Thread via GitHub
eric-maynard commented on code in PR #1191: URL: https://github.com/apache/polaris/pull/1191#discussion_r2002437112 ## polaris-core/src/main/java/org/apache/polaris/core/entity/CatalogEntity.java: ## @@ -240,6 +246,21 @@ public Builder setStorageConfigurationInfo( }

Re: [I] The 0.9.0 docs don't show in the site [polaris]

2025-03-18 Thread via GitHub
jbonofre commented on issue #1200: URL: https://github.com/apache/polaris/issues/1200#issuecomment-2735365285 I published the doc and asf-site branch is up to date. Let me check why it's not up to date on website. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Polaris Spark Plugin: setup repository code structure and build [polaris]

2025-03-18 Thread via GitHub
snazy commented on code in PR #1190: URL: https://github.com/apache/polaris/pull/1190#discussion_r2000438375 ## gradle.properties: ## @@ -28,3 +28,5 @@ org.gradle.configuration-cache=false #org.gradle.configuration-cache-problems=warn # bump the Gradle daemon heap size (you ca

[I] The 0.9.0 docs don't show in the site [polaris]

2025-03-18 Thread via GitHub
flyrain opened a new issue, #1200: URL: https://github.com/apache/polaris/issues/1200 ### Describe the bug Here is the current website, no 0.9.0 related doc showed. https://github.com/user-attachments/assets/71e739b9-95e4-4c78-b760-9ed32153c2df"; /> Here is the expected one, bui

Re: [PR] Update EclipseLink doc to 4.0 [polaris]

2025-03-18 Thread via GitHub
flyrain merged PR #1198: URL: https://github.com/apache/polaris/pull/1198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apa

Re: [PR] Update EclipseLink doc to 4.0 [polaris]

2025-03-18 Thread via GitHub
flyrain commented on PR #1198: URL: https://github.com/apache/polaris/pull/1198#issuecomment-2735238136 Thanks @MonkeyCanCode for the fix! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [I] Cleanup tasks failing with value too long for type character varying(255) [polaris]

2025-03-18 Thread via GitHub
MonkeyCanCode commented on issue #1195: URL: https://github.com/apache/polaris/issues/1195#issuecomment-2735238983 > i see this concern here though : https://github.com/apache/polaris/blob/main/service/common/src/main/java/org/apache/polaris/service/task/TableCleanupTaskHandler.java#L180

Re: [PR] Sync psql persistence [polaris]

2025-03-18 Thread via GitHub
MonkeyCanCode commented on PR #1187: URL: https://github.com/apache/polaris/pull/1187#issuecomment-2735235248 @adutra removed the change in 0.9.0 (as it is released doc). EclipseLink doc updated in https://github.com/apache/polaris/pull/1198. I think the 4.0 doc is a lot easier to search.

Re: [PR] Update EclipseLink doc to 4.0 [polaris]

2025-03-18 Thread via GitHub
MonkeyCanCode commented on code in PR #1198: URL: https://github.com/apache/polaris/pull/1198#discussion_r2002342743 ## site/content/in-dev/0.9.0/metastores.md: ## @@ -34,7 +34,7 @@ metaStoreManager: persistence-unit: polaris ``` -`conf-file` must point to an [EclipseLink

Re: [PR] Update EclipseLink doc to 4.0 [polaris]

2025-03-18 Thread via GitHub
MonkeyCanCode commented on code in PR #1198: URL: https://github.com/apache/polaris/pull/1198#discussion_r2002341505 ## site/content/in-dev/0.9.0/metastores.md: ## @@ -34,7 +34,7 @@ metaStoreManager: persistence-unit: polaris ``` -`conf-file` must point to an [EclipseLink

Re: [PR] Move Polaris client into root dir [polaris]

2025-03-18 Thread via GitHub
MonkeyCanCode commented on PR #1172: URL: https://github.com/apache/polaris/pull/1172#issuecomment-2735217724 @flyrain / @eric-maynard can one of your help perform a final review before this get merge? -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] Move Polaris client into root dir [polaris]

2025-03-18 Thread via GitHub
MonkeyCanCode commented on code in PR #1172: URL: https://github.com/apache/polaris/pull/1172#discussion_r2002331934 ## regtests/pyspark-setup.sh: ## @@ -18,14 +18,14 @@ # under the License. # -if [ ! -d ~/polaris-venv ]; then - python3 -m venv ~/polaris-venv +if [ ! -d ~/p

Re: [PR] Update EclipseLink doc to 4.0 [polaris]

2025-03-18 Thread via GitHub
flyrain commented on code in PR #1198: URL: https://github.com/apache/polaris/pull/1198#discussion_r2002339846 ## site/content/in-dev/0.9.0/metastores.md: ## @@ -34,7 +34,7 @@ metaStoreManager: persistence-unit: polaris ``` -`conf-file` must point to an [EclipseLink config

Re: [PR] Update EclipseLink doc to 4.0 [polaris]

2025-03-18 Thread via GitHub
flyrain commented on code in PR #1198: URL: https://github.com/apache/polaris/pull/1198#discussion_r2002338268 ## site/content/in-dev/0.9.0/metastores.md: ## @@ -34,7 +34,7 @@ metaStoreManager: persistence-unit: polaris ``` -`conf-file` must point to an [EclipseLink config

Re: [PR] Fix spark download and add check/cleanup [polaris]

2025-03-18 Thread via GitHub
flyrain commented on PR #1184: URL: https://github.com/apache/polaris/pull/1184#issuecomment-2735209153 Thanks @MonkeyCanCode for the change. Thanks @dimas-b for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Event Listeners [polaris]

2025-03-18 Thread via GitHub
snazy commented on code in PR #922: URL: https://github.com/apache/polaris/pull/922#discussion_r2000620772 ## service/common/src/main/java/org/apache/polaris/service/events/DefaultPolarisEventListener.java: ## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] Fix spark download and add check/cleanup [polaris]

2025-03-18 Thread via GitHub
flyrain merged PR #1184: URL: https://github.com/apache/polaris/pull/1184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apa

Re: [PR] Sync psql persistence [polaris]

2025-03-18 Thread via GitHub
MonkeyCanCode commented on code in PR #1187: URL: https://github.com/apache/polaris/pull/1187#discussion_r2002304434 ## site/content/in-dev/0.9.0/metastores.md: ## @@ -101,6 +101,11 @@ The following shows a sample configuration for integrating Polaris with Postgres

Re: [PR] Fix spark download and add check/cleanup [polaris]

2025-03-18 Thread via GitHub
MonkeyCanCode commented on code in PR #1184: URL: https://github.com/apache/polaris/pull/1184#discussion_r2002290252 ## regtests/run.sh: ## @@ -20,7 +20,7 @@ # Run without args to run all tests, or single arg for single test. SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0

Re: [PR] Refactors to support generic tables [polaris]

2025-03-18 Thread via GitHub
gh-yzou commented on code in PR #1147: URL: https://github.com/apache/polaris/pull/1147#discussion_r2002279058 ## polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisPrivilege.java: ## @@ -41,22 +41,22 @@ public enum PolarisPrivilege { TABLE_CREATE(6, PolarisEnti

Re: [PR] Upgrade Iceberg to 1.8 [polaris]

2025-03-18 Thread via GitHub
gh-yzou commented on code in PR #1126: URL: https://github.com/apache/polaris/pull/1126#discussion_r2002258178 ## quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/BasePolarisCatalogTest.java: ## @@ -151,6 +151,8 @@ public Map getConfigOverrides() {

Re: [PR] Polaris Spark Plugin: setup repository code structure and build [polaris]

2025-03-18 Thread via GitHub
gh-yzou commented on code in PR #1190: URL: https://github.com/apache/polaris/pull/1190#discussion_r2002208249 ## plugins/spark/build.gradle.kts: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. S

Re: [PR] Polaris Spark Plugin: setup repository code structure and build [polaris]

2025-03-18 Thread via GitHub
gh-yzou commented on code in PR #1190: URL: https://github.com/apache/polaris/pull/1190#discussion_r2002210944 ## plugins/spark/src/test/java/org/apache/polaris/spark/SparkCatalogTest.java: ## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Polaris Spark Plugin: setup repository code structure and build [polaris]

2025-03-18 Thread via GitHub
gh-yzou commented on code in PR #1190: URL: https://github.com/apache/polaris/pull/1190#discussion_r2002209924 ## plugins/spark/build.gradle.kts: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. S

Re: [PR] Polaris Spark Plugin: setup repository code structure and build [polaris]

2025-03-18 Thread via GitHub
gh-yzou commented on code in PR #1190: URL: https://github.com/apache/polaris/pull/1190#discussion_r2002209025 ## plugins/spark/README.md: ## @@ -0,0 +1,36 @@ + + +# Polaris Spark Plugin + +The Polaris Spark plugin provides an implementation for SparkCatalog, which communicates

Re: [PR] Polaris Spark Plugin: setup repository code structure and build [polaris]

2025-03-18 Thread via GitHub
gh-yzou commented on code in PR #1190: URL: https://github.com/apache/polaris/pull/1190#discussion_r2002209738 ## plugins/spark/README.md: ## @@ -0,0 +1,36 @@ + + +# Polaris Spark Plugin + +The Polaris Spark plugin provides an implementation for SparkCatalog, which communicates

Re: [PR] Polaris Spark Plugin: setup repository code structure and build [polaris]

2025-03-18 Thread via GitHub
gh-yzou commented on code in PR #1190: URL: https://github.com/apache/polaris/pull/1190#discussion_r2002206360 ## gradle/libs.versions.toml: ## @@ -27,6 +27,7 @@ scala212 = "2.12.19" spark35 = "3.5.5" slf4j = "2.0.17" swagger = "1.6.15" +icebergspark = "1.8.0" Review Comment

Re: [PR] Rename classes in transactional persistence package [polaris]

2025-03-18 Thread via GitHub
flyrain commented on PR #1197: URL: https://github.com/apache/polaris/pull/1197#issuecomment-2735022910 > LGTM ! Sidenote, they are public classes, do we have a deprecation model ? We discussed a bit before, but I don't think we have any formal conclusion yet. I'd suggest to follow si

Re: [PR] Rename classes in transactional persistence package [polaris]

2025-03-18 Thread via GitHub
flyrain commented on code in PR #1197: URL: https://github.com/apache/polaris/pull/1197#discussion_r2002111989 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/transactional/TreeMapTransactionalPersistenceImpl.java: ## @@ -42,15 +42,15 @@ import org.apache.pola

[PR] Rename classes in transactional persistence package [polaris]

2025-03-18 Thread via GitHub
flyrain opened a new pull request, #1197: URL: https://github.com/apache/polaris/pull/1197 This PR is renaming only without logic. The goal is to make the name consistent with the package transactional persistence package. -- This is an automated message from the Apache Git Service. To re

Re: [PR] Policy Store: Add PolicyEntity and PolicyTypes [polaris]

2025-03-18 Thread via GitHub
flyrain merged PR #1133: URL: https://github.com/apache/polaris/pull/1133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apa

Re: [PR] Polaris Spark Plugin: setup repository code structure and build [polaris]

2025-03-18 Thread via GitHub
gh-yzou commented on code in PR #1190: URL: https://github.com/apache/polaris/pull/1190#discussion_r2001958228 ## plugins/spark/src/main/java/org/apache/polaris/spark/SparkCatalog.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [I] Polaris persistence / unclear behavior when creating entites with the same name [polaris]

2025-03-18 Thread via GitHub
flyrain commented on issue #767: URL: https://github.com/apache/polaris/issues/767#issuecomment-2734692349 It's not possible to create two tables with the same name as the name checking is within the transaction. See details here, https://github.com/apache/polaris/blob/b1f7c68b1cb29dfdc

Re: [PR] Polaris Spark Plugin: setup repository code structure and build [polaris]

2025-03-18 Thread via GitHub
gh-yzou commented on code in PR #1190: URL: https://github.com/apache/polaris/pull/1190#discussion_r2001968396 ## plugins/spark/src/test/java/org/apache/polaris/spark/SparkCatalogTest.java: ## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] Polaris Spark Plugin: setup repository code structure and build [polaris]

2025-03-18 Thread via GitHub
gh-yzou commented on code in PR #1190: URL: https://github.com/apache/polaris/pull/1190#discussion_r2001751823 ## gradle.properties: ## @@ -28,3 +28,5 @@ org.gradle.configuration-cache=false #org.gradle.configuration-cache-problems=warn # bump the Gradle daemon heap size (you

Re: [PR] Refactor EntityCache into an interface [polaris]

2025-03-18 Thread via GitHub
flyrain commented on code in PR #1193: URL: https://github.com/apache/polaris/pull/1193#discussion_r2001957771 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/cache/EntityCacheInterface.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] Polaris Spark Plugin: setup repository code structure and build [polaris]

2025-03-18 Thread via GitHub
gh-yzou commented on code in PR #1190: URL: https://github.com/apache/polaris/pull/1190#discussion_r2001882264 ## plugins/spark/build.gradle.kts: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. S

Re: [PR] Upgrade Iceberg to 1.8 [polaris]

2025-03-18 Thread via GitHub
flyrain commented on PR #1126: URL: https://github.com/apache/polaris/pull/1126#issuecomment-2734351164 cc @gh-yzou -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] Polaris Spark Plugin: setup repository code structure and build [polaris]

2025-03-18 Thread via GitHub
gh-yzou commented on code in PR #1190: URL: https://github.com/apache/polaris/pull/1190#discussion_r2001794533 ## gradle/libs.versions.toml: ## @@ -27,6 +27,7 @@ scala212 = "2.12.19" spark35 = "3.5.5" slf4j = "2.0.17" swagger = "1.6.15" +icebergspark = "1.8.0" Review Comment

Re: [PR] Polaris Spark Plugin: setup repository code structure and build [polaris]

2025-03-18 Thread via GitHub
gh-yzou commented on code in PR #1190: URL: https://github.com/apache/polaris/pull/1190#discussion_r2001751823 ## gradle.properties: ## @@ -28,3 +28,5 @@ org.gradle.configuration-cache=false #org.gradle.configuration-cache-problems=warn # bump the Gradle daemon heap size (you

Re: [PR] Polaris Spark Plugin: setup repository code structure and build [polaris]

2025-03-18 Thread via GitHub
RussellSpitzer commented on code in PR #1190: URL: https://github.com/apache/polaris/pull/1190#discussion_r2001726637 ## plugins/spark/src/test/java/org/apache/polaris/spark/SparkCatalogTest.java: ## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Polaris Spark Plugin: setup repository code structure and build [polaris]

2025-03-18 Thread via GitHub
RussellSpitzer commented on code in PR #1190: URL: https://github.com/apache/polaris/pull/1190#discussion_r2001712316 ## plugins/spark/src/main/java/org/apache/polaris/spark/SparkCatalog.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] Polaris Spark Plugin: setup repository code structure and build [polaris]

2025-03-18 Thread via GitHub
RussellSpitzer commented on code in PR #1190: URL: https://github.com/apache/polaris/pull/1190#discussion_r2001705704 ## plugins/spark/build.gradle.kts: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreeme

Re: [PR] Polaris Spark Plugin: setup repository code structure and build [polaris]

2025-03-18 Thread via GitHub
RussellSpitzer commented on code in PR #1190: URL: https://github.com/apache/polaris/pull/1190#discussion_r2001682579 ## gradle/libs.versions.toml: ## @@ -27,6 +27,7 @@ scala212 = "2.12.19" spark35 = "3.5.5" slf4j = "2.0.17" swagger = "1.6.15" +icebergspark = "1.8.0" Review

Re: [PR] Polaris Spark Plugin: setup repository code structure and build [polaris]

2025-03-18 Thread via GitHub
RussellSpitzer commented on code in PR #1190: URL: https://github.com/apache/polaris/pull/1190#discussion_r2001690243 ## plugins/spark/README.md: ## @@ -0,0 +1,36 @@ + + +# Polaris Spark Plugin + +The Polaris Spark plugin provides an implementation for SparkCatalog, which commu

Re: [PR] Polaris Spark Plugin: setup repository code structure and build [polaris]

2025-03-18 Thread via GitHub
gh-yzou commented on code in PR #1190: URL: https://github.com/apache/polaris/pull/1190#discussion_r2001644367 ## gradle.properties: ## @@ -28,3 +28,5 @@ org.gradle.configuration-cache=false #org.gradle.configuration-cache-problems=warn # bump the Gradle daemon heap size (you

Re: [PR] Fix updating the storage config [polaris]

2025-03-18 Thread via GitHub
XJDKC commented on PR #1191: URL: https://github.com/apache/polaris/pull/1191#issuecomment-2734130935 > This change adds even more higher-level concerns into persistence related code. > > We already have hard dependencies from persistence code to object-storage specifics. I'm -1 on a

Re: [PR] Fix updating the storage config [polaris]

2025-03-18 Thread via GitHub
XJDKC commented on PR #1191: URL: https://github.com/apache/polaris/pull/1191#issuecomment-2734138043 > This change adds even more higher-level concerns into persistence related code. > > We already have hard dependencies from persistence code to object-storage specifics. I'm -1 on a

[PR] main: Update dependency ch.qos.logback:logback-classic to v1.5.18 [polaris]

2025-03-18 Thread via GitHub
renovate-bot opened a new pull request, #1196: URL: https://github.com/apache/polaris/pull/1196 This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ch.qos.logback:logback-classic](http://logback.qos.ch)

Re: [PR] Fix updating the storage config [polaris]

2025-03-18 Thread via GitHub
XJDKC closed pull request #1191: Fix updating the storage config URL: https://github.com/apache/polaris/pull/1191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] Fix updating the storage config [polaris]

2025-03-18 Thread via GitHub
XJDKC commented on code in PR #1191: URL: https://github.com/apache/polaris/pull/1191#discussion_r2001587260 ## polaris-core/src/main/java/org/apache/polaris/core/entity/CatalogEntity.java: ## @@ -205,6 +205,7 @@ public Builder() { public Builder(CatalogEntity original) {

Re: [PR] Event Listeners [polaris]

2025-03-18 Thread via GitHub
andrew4699 commented on code in PR #922: URL: https://github.com/apache/polaris/pull/922#discussion_r2001532609 ## service/common/src/main/java/org/apache/polaris/service/events/AfterTaskAttemptedEvent.java: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Event Listeners [polaris]

2025-03-18 Thread via GitHub
andrew4699 commented on code in PR #922: URL: https://github.com/apache/polaris/pull/922#discussion_r2001545021 ## service/common/src/main/java/org/apache/polaris/service/events/AfterTableCommitedEvent.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Event Listeners [polaris]

2025-03-18 Thread via GitHub
andrew4699 commented on code in PR #922: URL: https://github.com/apache/polaris/pull/922#discussion_r2001560091 ## service/common/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java: ## @@ -1229,11 +1243,14 @@ public void doRefresh() {

Re: [PR] API Spec: Add ConnectionConfigInfo to ExternalCatalog [polaris]

2025-03-18 Thread via GitHub
sfc-gh-rxing commented on code in PR #1026: URL: https://github.com/apache/polaris/pull/1026#discussion_r2001543512 ## spec/polaris-management-service.yml: ## @@ -850,9 +850,92 @@ components: - $ref: "#/components/schemas/Catalog" - type: object prop

Re: [I] Cleanup tasks failing with value too long for type character varying(255) [polaris]

2025-03-18 Thread via GitHub
singhpk234 commented on issue #1195: URL: https://github.com/apache/polaris/issues/1195#issuecomment-2734039899 internal properties and properties are already text, which version are you using https://github.com/apache/polaris/blob/main/extension/persistence/jpa-model/src/main/java/org/apac

Re: [PR] Event Listeners [polaris]

2025-03-18 Thread via GitHub
andrew4699 commented on code in PR #922: URL: https://github.com/apache/polaris/pull/922#discussion_r2001535434 ## service/common/src/main/java/org/apache/polaris/service/events/BeforeRequestRateLimitedEvent.java: ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Event Listeners [polaris]

2025-03-18 Thread via GitHub
andrew4699 commented on code in PR #922: URL: https://github.com/apache/polaris/pull/922#discussion_r2001532609 ## service/common/src/main/java/org/apache/polaris/service/events/AfterTaskAttemptedEvent.java: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Event Listeners [polaris]

2025-03-18 Thread via GitHub
andrew4699 commented on code in PR #922: URL: https://github.com/apache/polaris/pull/922#discussion_r2001522875 ## service/common/src/main/java/org/apache/polaris/service/events/PolarisEventListener.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Event Listeners [polaris]

2025-03-18 Thread via GitHub
andrew4699 commented on code in PR #922: URL: https://github.com/apache/polaris/pull/922#discussion_r2001497996 ## service/common/src/main/java/org/apache/polaris/service/catalog/IcebergCatalogAdapter.java: ## @@ -127,6 +128,7 @@ public class IcebergCatalogAdapter private fin

Re: [PR] Event Listeners [polaris]

2025-03-18 Thread via GitHub
andrew4699 commented on code in PR #922: URL: https://github.com/apache/polaris/pull/922#discussion_r2001501674 ## service/common/src/main/java/org/apache/polaris/service/catalog/PolarisCatalogHandlerWrapper.java: ## @@ -123,6 +124,7 @@ public class PolarisCatalogHandlerWrapper

Re: [PR] Event Listeners [polaris]

2025-03-18 Thread via GitHub
andrew4699 commented on code in PR #922: URL: https://github.com/apache/polaris/pull/922#discussion_r2001497996 ## service/common/src/main/java/org/apache/polaris/service/catalog/IcebergCatalogAdapter.java: ## @@ -127,6 +128,7 @@ public class IcebergCatalogAdapter private fin

Re: [PR] Refactors to support generic tables [polaris]

2025-03-18 Thread via GitHub
snazy commented on code in PR #1147: URL: https://github.com/apache/polaris/pull/1147#discussion_r2001457448 ## polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisPrivilege.java: ## @@ -41,22 +41,22 @@ public enum PolarisPrivilege { TABLE_CREATE(6, PolarisEntity

Re: [PR] Refactors to support generic tables [polaris]

2025-03-18 Thread via GitHub
eric-maynard commented on code in PR #1147: URL: https://github.com/apache/polaris/pull/1147#discussion_r2001453980 ## polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisPrivilege.java: ## @@ -41,22 +41,22 @@ public enum PolarisPrivilege { TABLE_CREATE(6, Polari

Re: [PR] Refactors to support generic tables [polaris]

2025-03-18 Thread via GitHub
eric-maynard commented on code in PR #1147: URL: https://github.com/apache/polaris/pull/1147#discussion_r2001450910 ## quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/IcebergCatalogTest.java: ## @@ -140,7 +141,8 @@ import software.amazon.awssdk.services

Re: [PR] Refactors to support generic tables [polaris]

2025-03-18 Thread via GitHub
eric-maynard commented on code in PR #1147: URL: https://github.com/apache/polaris/pull/1147#discussion_r2001450421 ## quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/GenericTableCatalogTest.java: ## @@ -0,0 +1,311 @@ +/* + * Licensed to the Apache Softw

Re: [PR] Refactors to support generic tables [polaris]

2025-03-18 Thread via GitHub
flyrain commented on code in PR #1147: URL: https://github.com/apache/polaris/pull/1147#discussion_r2001405982 ## service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/DefaultCatalogPrefixParser.java: ## @@ -16,13 +16,14 @@ * specific language governing permi

Re: [PR] Fix spark download and add check/cleanup [polaris]

2025-03-18 Thread via GitHub
MonkeyCanCode commented on code in PR #1184: URL: https://github.com/apache/polaris/pull/1184#discussion_r2001206759 ## regtests/run.sh: ## @@ -20,7 +20,7 @@ # Run without args to run all tests, or single arg for single test. SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0

[I] Cleanup tasks failing with value too long for type character varying(255) [polaris]

2025-03-18 Thread via GitHub
george-zubrienko opened a new issue, #1195: URL: https://github.com/apache/polaris/issues/1195 ### Describe the bug When a table is dropped using DROP_WITH_PURGE (default in Trino connector), Polaris fails to drop the table data from the underlying storage, throwing this: ```

Re: [I] Performing any transactions in MinIO server like creating tables throws "Unable to process: Failed to get subscoped credentials" [polaris]

2025-03-18 Thread via GitHub
george-zubrienko commented on issue #1146: URL: https://github.com/apache/polaris/issues/1146#issuecomment-2733186619 > [@george-zubrienko](https://github.com/george-zubrienko) Hmm, even having the dummy role and setting those env vars, I got the same error. FYI, this is my Polaris CLI to c

Re: [PR] Move Polaris client into root dir [polaris]

2025-03-18 Thread via GitHub
MonkeyCanCode commented on PR #1172: URL: https://github.com/apache/polaris/pull/1172#issuecomment-2733141388 > @MonkeyCanCode I've reorganized the project layout inside the Docker container. Local tests for `client/python`, `t_hello_world:hello_world.sh`, and `t_pyspark:test_spark_sql_s3_w

[I] IPv6 Bind Address not applied to management API [polaris]

2025-03-18 Thread via GitHub
george-zubrienko opened a new issue, #1194: URL: https://github.com/apache/polaris/issues/1194 ### Describe the bug Providing `JAVA_OPTS` with value `-Djava.net.preferIPv6Addresses=true -Dquarkus.http.host=[::]` via `extraEnv` allows me to bind API host to ipv6 address successfully.

Re: [PR] Fix updating the storage config [polaris]

2025-03-18 Thread via GitHub
snazy commented on code in PR #1191: URL: https://github.com/apache/polaris/pull/1191#discussion_r2000802932 ## polaris-core/src/main/java/org/apache/polaris/core/entity/CatalogEntity.java: ## @@ -205,6 +205,7 @@ public Builder() { public Builder(CatalogEntity original) {

Re: [I] Polaris persistence / unclear behavior when creating entites with the same name [polaris]

2025-03-18 Thread via GitHub
snazy commented on issue #767: URL: https://github.com/apache/polaris/issues/767#issuecomment-2732359907 > Could you provide a way to reproduce the bug? We cannot just feel it's a bug. See issue description, but it's _for example_ the "disconnect of the name resolution vs technical I

Re: [PR] Use soft values in the EntityCache; approximate entity size [polaris]

2025-03-18 Thread via GitHub
snazy commented on PR #490: URL: https://github.com/apache/polaris/pull/490#issuecomment-2732340120 (Just commenting in general) Background: Nessie's cache keeps _serialized_ representations of the cached object to limit the _amount_ of _reachable_ (from GC roots) Java objects - it

Re: [PR] Refactors to support generic tables [polaris]

2025-03-18 Thread via GitHub
snazy commented on code in PR #1147: URL: https://github.com/apache/polaris/pull/1147#discussion_r2000488173 ## polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisPrivilege.java: ## @@ -41,22 +41,22 @@ public enum PolarisPrivilege { TABLE_CREATE(6, PolarisEntity

Re: [PR] Polaris Spark Plugin: setup repository code structure and build [polaris]

2025-03-18 Thread via GitHub
snazy commented on PR #1190: URL: https://github.com/apache/polaris/pull/1190#issuecomment-2732059112 > @snazy For this PR, i really intended to only do the plugin code structure and build setup, it doesn't contain any actual function implementations (most operations throws UnsupportedOpera

Re: [PR] Event Listeners [polaris]

2025-03-18 Thread via GitHub
flyrain commented on code in PR #922: URL: https://github.com/apache/polaris/pull/922#discussion_r2000180253 ## service/common/src/main/java/org/apache/polaris/service/events/PolarisEvent.java: ## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on