[GitHub] [solr] ijioio edited a comment on pull request #479: SOLR-15842: Fix async backup response

2022-01-12 Thread GitBox
ijioio edited a comment on pull request #479: URL: https://github.com/apache/solr/pull/479#issuecomment-1010953596 > It seems like you and @cpoerschke are in favor of removing Response altogether, just leaving response. I think it would be fine to change Response -> message and leave the i

[jira] [Commented] (SOLR-15862) Various minor cleanups for 9.0

2022-01-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475080#comment-17475080 ] ASF subversion and git services commented on SOLR-15862: Commit d

[jira] [Commented] (SOLR-15862) Various minor cleanups for 9.0

2022-01-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475082#comment-17475082 ] ASF subversion and git services commented on SOLR-15862: Commit 7

[jira] [Commented] (SOLR-15862) Various minor cleanups for 9.0

2022-01-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475081#comment-17475081 ] ASF subversion and git services commented on SOLR-15862: Commit e

[jira] [Commented] (SOLR-15919) Deprecate File based APIs in SolrZKClient and create new Path-based APIs

2022-01-12 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475074#comment-17475074 ] Shawn Heisey commented on SOLR-15919: - >From your email to dev: {quote}It would be a

[jira] [Commented] (SOLR-15862) Various minor cleanups for 9.0

2022-01-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475060#comment-17475060 ] ASF subversion and git services commented on SOLR-15862: Commit e

[jira] [Commented] (SOLR-15862) Various minor cleanups for 9.0

2022-01-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475061#comment-17475061 ] ASF subversion and git services commented on SOLR-15862: Commit 7

[jira] [Commented] (SOLR-15862) Various minor cleanups for 9.0

2022-01-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475059#comment-17475059 ] ASF subversion and git services commented on SOLR-15862: Commit d

[jira] [Created] (SOLR-15919) Deprecate File based APIs in SolrZKClient and create new Path-based APIs

2022-01-12 Thread Mike Drob (Jira)
Mike Drob created SOLR-15919: Summary: Deprecate File based APIs in SolrZKClient and create new Path-based APIs Key: SOLR-15919 URL: https://issues.apache.org/jira/browse/SOLR-15919 Project: Solr

[jira] [Updated] (SOLR-15919) Deprecate File based APIs in SolrZKClient and create new Path-based APIs

2022-01-12 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-15919: - Security: (was: Public) > Deprecate File based APIs in SolrZKClient and create new Path-based APIs >

[jira] [Created] (SOLR-15918) Many NodeExistsExceptions when uploading a configset

2022-01-12 Thread Mike Drob (Jira)
Mike Drob created SOLR-15918: Summary: Many NodeExistsExceptions when uploading a configset Key: SOLR-15918 URL: https://issues.apache.org/jira/browse/SOLR-15918 Project: Solr Issue Type: Task

[jira] [Commented] (SOLR-15862) Various minor cleanups for 9.0

2022-01-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475046#comment-17475046 ] ASF subversion and git services commented on SOLR-15862: Commit e

[jira] [Commented] (SOLR-15862) Various minor cleanups for 9.0

2022-01-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475045#comment-17475045 ] ASF subversion and git services commented on SOLR-15862: Commit d

[jira] [Commented] (SOLR-15862) Various minor cleanups for 9.0

2022-01-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475047#comment-17475047 ] ASF subversion and git services commented on SOLR-15862: Commit 7

[jira] [Commented] (SOLR-15917) Rename 'contrib' as 'module'

2022-01-12 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475039#comment-17475039 ] David Smiley commented on SOLR-15917: - Although I like the name "modules" (my idea or

[GitHub] [solr] janhoy merged pull request #514: New dev-tools/scripts/cherrypick.sh

2022-01-12 Thread GitBox
janhoy merged pull request #514: URL: https://github.com/apache/solr/pull/514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr] dsmiley commented on pull request #520: SOLR-15912 Update Guava to 31.0.1

2022-01-12 Thread GitBox
dsmiley commented on pull request #520: URL: https://github.com/apache/solr/pull/520#issuecomment-1011612102 I believe you can also now remove the guava exclusion in core's build.gradle because we now choose the most recent Gradle. -- This is an automated message from the Apache Git Serv

[GitHub] [solr] janhoy merged pull request #521: SOLR-15862 Fix linter warnings about guava Strings, removing unused variable

2022-01-12 Thread GitBox
janhoy merged pull request #521: URL: https://github.com/apache/solr/pull/521 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr] janhoy commented on a change in pull request #519: Script to scaffold a new contrib module

2022-01-12 Thread GitBox
janhoy commented on a change in pull request #519: URL: https://github.com/apache/solr/pull/519#discussion_r783548683 ## File path: dev-tools/scripts/addContrib.py ## @@ -0,0 +1,170 @@ +#!/usr/bin/env python3 +# -*- coding: utf-8 -*- +# Licensed to the Apache Software Foundatio

[GitHub] [solr] janhoy commented on a change in pull request #518: SOLR-15907 Move JWT auth plugin to contrib

2022-01-12 Thread GitBox
janhoy commented on a change in pull request #518: URL: https://github.com/apache/solr/pull/518#discussion_r783540085 ## File path: solr/contrib/jwt-auth/src/java/org/apache/solr/security/JWTAuthPlugin.java ## @@ -104,15 +102,31 @@ @Deprecated(since = "9.0") // Remove in 10

[GitHub] [solr] janhoy commented on a change in pull request #518: SOLR-15907 Move JWT auth plugin to contrib

2022-01-12 Thread GitBox
janhoy commented on a change in pull request #518: URL: https://github.com/apache/solr/pull/518#discussion_r783538516 ## File path: solr/core/build.gradle ## @@ -115,9 +115,6 @@ dependencies { testImplementation 'org.slf4j:jcl-over-slf4j' - // JWT Auth plugin - api 'or

[jira] [Commented] (SOLR-15914) bin/solr argument to add contribs to classpath

2022-01-12 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475020#comment-17475020 ] Jan Høydahl commented on SOLR-15914: +1 also to rename contribs as modules. Created S

[jira] [Created] (SOLR-15917) Rename 'contrib' as 'module'

2022-01-12 Thread Jira
Jan Høydahl created SOLR-15917: -- Summary: Rename 'contrib' as 'module' Key: SOLR-15917 URL: https://issues.apache.org/jira/browse/SOLR-15917 Project: Solr Issue Type: Improvement Security

[GitHub] [solr] magibney commented on a change in pull request #513: SOLR-9376: [xml] and [json] RawValue DocTransformers should work in cloud mode

2022-01-12 Thread GitBox
magibney commented on a change in pull request #513: URL: https://github.com/apache/solr/pull/513#discussion_r783530761 ## File path: solr/core/src/java/org/apache/solr/response/RawShimTextResponseWriter.java ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [solr] magibney commented on a change in pull request #513: SOLR-9376: [xml] and [json] RawValue DocTransformers should work in cloud mode

2022-01-12 Thread GitBox
magibney commented on a change in pull request #513: URL: https://github.com/apache/solr/pull/513#discussion_r783524161 ## File path: solr/core/src/java/org/apache/solr/response/TextResponseWriter.java ## @@ -55,6 +58,10 @@ protected Calendar cal; // reusable calendar ins

[GitHub] [solr] magibney commented on a change in pull request #513: SOLR-9376: [xml] and [json] RawValue DocTransformers should work in cloud mode

2022-01-12 Thread GitBox
magibney commented on a change in pull request #513: URL: https://github.com/apache/solr/pull/513#discussion_r783523080 ## File path: solr/core/src/java/org/apache/solr/response/transform/RawValueTransformerFactory.java ## @@ -109,19 +131,8 @@ public String getName() @Ove

[GitHub] [solr] magibney commented on a change in pull request #513: SOLR-9376: [xml] and [json] RawValue DocTransformers should work in cloud mode

2022-01-12 Thread GitBox
magibney commented on a change in pull request #513: URL: https://github.com/apache/solr/pull/513#discussion_r783522121 ## File path: solr/core/src/test/org/apache/solr/response/TestRawTransformer.java ## @@ -16,55 +16,151 @@ */ package org.apache.solr.response; +import or

[GitHub] [solr] magibney commented on a change in pull request #513: SOLR-9376: [xml] and [json] RawValue DocTransformers should work in cloud mode

2022-01-12 Thread GitBox
magibney commented on a change in pull request #513: URL: https://github.com/apache/solr/pull/513#discussion_r783515256 ## File path: solr/core/src/test/org/apache/solr/response/TestRawTransformer.java ## @@ -16,55 +16,151 @@ */ package org.apache.solr.response; +import or

[GitHub] [solr] murblanc commented on pull request #512: SOLR-15209: Make the LegacyAssignStrategy the DefaultPlacementPlugin

2022-01-12 Thread GitBox
murblanc commented on pull request #512: URL: https://github.com/apache/solr/pull/512#issuecomment-1011537027 I hope eventually we can make another placement plugin (the affinity placement one) the default placement, but I don't have time any time soon to look at the tests, understand them

[jira] [Commented] (SOLR-15915) Move ref guide away from using jcenter repo

2022-01-12 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475003#comment-17475003 ] Jan Høydahl commented on SOLR-15915: Status of the JCenter outage: [https://status.gr

[jira] [Commented] (SOLR-15915) Move ref guide away from using jcenter repo

2022-01-12 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474996#comment-17474996 ] Jan Høydahl commented on SOLR-15915: One more argument for SOLR-15556.. > Move ref g

[GitHub] [solr] epugh commented on pull request #513: SOLR-9376: [xml] and [json] RawValue DocTransformers should work in cloud mode

2022-01-12 Thread GitBox
epugh commented on pull request #513: URL: https://github.com/apache/solr/pull/513#issuecomment-1011490212 @magibney i just did my first Review in github with some comments... I'd love to hear your thoughts on my comments, and then I'd love to give it a test and commit! -- This is an

[GitHub] [solr] epugh commented on a change in pull request #513: SOLR-9376: [xml] and [json] RawValue DocTransformers should work in cloud mode

2022-01-12 Thread GitBox
epugh commented on a change in pull request #513: URL: https://github.com/apache/solr/pull/513#discussion_r783061509 ## File path: solr/core/src/java/org/apache/solr/response/RawShimTextResponseWriter.java ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Created] (SOLR-15916) Remove "dist/" from distribution

2022-01-12 Thread David Smiley (Jira)
David Smiley created SOLR-15916: --- Summary: Remove "dist/" from distribution Key: SOLR-15916 URL: https://issues.apache.org/jira/browse/SOLR-15916 Project: Solr Issue Type: Improvement Sec

[jira] [Commented] (SOLR-15914) bin/solr argument to add contribs to classpath

2022-01-12 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474975#comment-17474975 ] David Smiley commented on SOLR-15914: - Huge +1 to make including contribs/* this easy

[jira] [Commented] (SOLR-15914) bin/solr argument to add contribs to classpath

2022-01-12 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474971#comment-17474971 ] Cassandra Targett commented on SOLR-15914: -- bq. As we make these add-ons more nu

[GitHub] [solr] dsmiley commented on a change in pull request #518: SOLR-15907 Move JWT auth plugin to contrib

2022-01-12 Thread GitBox
dsmiley commented on a change in pull request #518: URL: https://github.com/apache/solr/pull/518#discussion_r783453312 ## File path: solr/core/build.gradle ## @@ -115,9 +115,6 @@ dependencies { testImplementation 'org.slf4j:jcl-over-slf4j' - // JWT Auth plugin - api 'o

[jira] [Commented] (SOLR-15915) Move ref guide away from using jcenter repo

2022-01-12 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474965#comment-17474965 ] Cassandra Targett commented on SOLR-15915: -- OK, thanks - feels like it should be

[jira] [Commented] (SOLR-15915) Move ref guide away from using jcenter repo

2022-01-12 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474964#comment-17474964 ] Mike Drob commented on SOLR-15915: -- 2.1.0-alpha.1 still depends on a too old version of

[jira] [Commented] (SOLR-15915) Move ref guide away from using jcenter repo

2022-01-12 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474958#comment-17474958 ] Mike Drob commented on SOLR-15915: -- [~ctargett] this is going to end up upgrading the ve

[jira] [Commented] (SOLR-15915) Move ref guide away from using jcenter repo

2022-01-12 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474941#comment-17474941 ] Mike Drob commented on SOLR-15915: -- the version of the gradle plugin that we use still d

[GitHub] [solr] janhoy merged pull request #501: Dynamically discover lucene version for use in build

2022-01-12 Thread GitBox
janhoy merged pull request #501: URL: https://github.com/apache/solr/pull/501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr] janhoy commented on pull request #521: Suppressing some linter warnings, removing unused variable

2022-01-12 Thread GitBox
janhoy commented on pull request #521: URL: https://github.com/apache/solr/pull/521#issuecomment-1011425940 > Instead of using `com.google.common.base.Strings.repeat` we can use the instance method on `java.lang.String` Ah, importing a `Strings` class from elsewhere was really confus

[jira] [Commented] (SOLR-15197) Support temporal graph queries with DAY and WEEKDAY windows

2022-01-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474936#comment-17474936 ] ASF subversion and git services commented on SOLR-15197: Commit 2

[jira] [Commented] (SOLR-15902) PackageManagerCLITest.testPackageManager fails on main

2022-01-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474935#comment-17474935 ] ASF subversion and git services commented on SOLR-15902: Commit 2

[jira] [Commented] (SOLR-15902) PackageManagerCLITest.testPackageManager fails on main

2022-01-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474937#comment-17474937 ] ASF subversion and git services commented on SOLR-15902: Commit 1

[jira] [Commented] (SOLR-15902) PackageManagerCLITest.testPackageManager fails on main

2022-01-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474934#comment-17474934 ] ASF subversion and git services commented on SOLR-15902: Commit 9

[jira] [Commented] (SOLR-15197) Support temporal graph queries with DAY and WEEKDAY windows

2022-01-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474932#comment-17474932 ] ASF subversion and git services commented on SOLR-15197: Commit 3

[jira] [Commented] (SOLR-15197) Support temporal graph queries with DAY and WEEKDAY windows

2022-01-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474928#comment-17474928 ] ASF subversion and git services commented on SOLR-15197: Commit 2

[jira] [Created] (SOLR-15915) Move ref guide away from using jcenter repo

2022-01-12 Thread Mike Drob (Jira)
Mike Drob created SOLR-15915: Summary: Move ref guide away from using jcenter repo Key: SOLR-15915 URL: https://issues.apache.org/jira/browse/SOLR-15915 Project: Solr Issue Type: Task Secur

[jira] [Updated] (SOLR-15915) Move ref guide away from using jcenter repo

2022-01-12 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-15915: - Security: (was: Public) > Move ref guide away from using jcenter repo > -

[jira] [Updated] (SOLR-15915) Move ref guide away from using jcenter repo

2022-01-12 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-15915: - Priority: Blocker (was: Major) > Move ref guide away from using jcenter repo > -

[GitHub] [solr] HoustonPutman commented on a change in pull request #510: SOLR-15908 Document or fix error-prone patterns relating to tests

2022-01-12 Thread GitBox
HoustonPutman commented on a change in pull request #510: URL: https://github.com/apache/solr/pull/510#discussion_r783394917 ## File path: solr/core/src/test/org/apache/solr/handler/export/TestExportWriter.java ## @@ -684,13 +684,13 @@ public void testMultipleSorts() throws Ex

[jira] [Commented] (SOLR-15902) PackageManagerCLITest.testPackageManager fails on main

2022-01-12 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474914#comment-17474914 ] Jan Høydahl commented on SOLR-15902: Let's bring back the {{@AwaitsFix}} on this? >

[jira] [Commented] (SOLR-15902) PackageManagerCLITest.testPackageManager fails on main

2022-01-12 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474889#comment-17474889 ] Houston Putman commented on SOLR-15902: --- This fails now because the PackageManager

[GitHub] [solr] madrob commented on a change in pull request #510: SOLR-15908 Document or fix error-prone patterns relating to tests

2022-01-12 Thread GitBox
madrob commented on a change in pull request #510: URL: https://github.com/apache/solr/pull/510#discussion_r783339215 ## File path: solr/test-framework/src/java/org/apache/solr/cloud/api/collections/AbstractIncrementalBackupTest.java ## @@ -510,11 +510,7 @@ private void assert

[GitHub] [solr] madrob commented on a change in pull request #510: SOLR-15908 Document or fix error-prone patterns relating to tests

2022-01-12 Thread GitBox
madrob commented on a change in pull request #510: URL: https://github.com/apache/solr/pull/510#discussion_r783338351 ## File path: solr/core/src/test/org/apache/solr/handler/export/TestExportWriter.java ## @@ -684,13 +684,13 @@ public void testMultipleSorts() throws Exception

[jira] [Reopened] (SOLR-15902) PackageManagerCLITest.testPackageManager fails on main

2022-01-12 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman reopened SOLR-15902: --- > PackageManagerCLITest.testPackageManager fails on main > --

[GitHub] [solr] HoustonPutman commented on a change in pull request #510: SOLR-15908 Document or fix error-prone patterns relating to tests

2022-01-12 Thread GitBox
HoustonPutman commented on a change in pull request #510: URL: https://github.com/apache/solr/pull/510#discussion_r783314160 ## File path: solr/core/src/test/org/apache/solr/update/TestExceedMaxTermLength.java ## @@ -72,23 +72,18 @@ public void testExceededMaxTermLength(){

[GitHub] [solr-operator] thelabdude commented on issue #390: auto certificate renewal with restartOnTLSSecretUpdate and cert-manager fails

2022-01-12 Thread GitBox
thelabdude commented on issue #390: URL: https://github.com/apache/solr-operator/issues/390#issuecomment-1011288225 thanks Nik ... Solr is getting configured with the keystore as the truststore, which is likely the cause of the problem here (since once the new cert is loaded, it's not trus

[GitHub] [solr] madrob opened a new pull request #522: SIP-14 Use Embedded ZK in Tests

2022-01-12 Thread GitBox
madrob opened a new pull request #522: URL: https://github.com/apache/solr/pull/522 This is a draft PR for the first stage of SIP-14 https://cwiki.apache.org/confluence/display/SOLR/SIP-14+Embedded+Zookeeper Not all father tests are passing yet, but I wanted to put it up sooner than

[GitHub] [solr] dweiss commented on a change in pull request #518: SOLR-15907 Move JWT auth plugin to contrib

2022-01-12 Thread GitBox
dweiss commented on a change in pull request #518: URL: https://github.com/apache/solr/pull/518#discussion_r783281998 ## File path: solr/core/build.gradle ## @@ -115,9 +115,6 @@ dependencies { testImplementation 'org.slf4j:jcl-over-slf4j' - // JWT Auth plugin - api 'or

[GitHub] [solr] madrob commented on a change in pull request #518: SOLR-15907 Move JWT auth plugin to contrib

2022-01-12 Thread GitBox
madrob commented on a change in pull request #518: URL: https://github.com/apache/solr/pull/518#discussion_r783272786 ## File path: solr/contrib/jwt-auth/src/java/org/apache/solr/security/JWTAuthPlugin.java ## @@ -104,15 +102,31 @@ @Deprecated(since = "9.0") // Remove in 10

[GitHub] [solr] arobinski commented on pull request #488: SOLR-15883 Fix a problem in OpenExchangeRatesOrgProvider: introduce a parameter so that it downloads currency rates while indexing not while s

2022-01-12 Thread GitBox
arobinski commented on pull request #488: URL: https://github.com/apache/solr/pull/488#issuecomment-1011258926 @janhoy I tried doing as you wrote. I created an ExecutorService using `ExecutorUtil.newMDCAwareSingleThreadExecutor` . It's on line 70 in OpenExchangeRatesOrgProvider.java. It ge

[GitHub] [solr] madrob commented on pull request #521: Suppressing some linter warnings, removing unused variable

2022-01-12 Thread GitBox
madrob commented on pull request #521: URL: https://github.com/apache/solr/pull/521#issuecomment-1011251295 Looking at the linter suggestion, I think we should act on it instead of suppressing. Instead of using `com.google.common.base.Strings.repeat` we can use the instance method o

[jira] [Commented] (SOLR-15902) PackageManagerCLITest.testPackageManager fails on main

2022-01-12 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474692#comment-17474692 ] Jan Høydahl commented on SOLR-15902: This test still fails on main here {code:java} >

[GitHub] [solr] janhoy commented on a change in pull request #518: SOLR-15907 Move JWT auth plugin to contrib

2022-01-12 Thread GitBox
janhoy commented on a change in pull request #518: URL: https://github.com/apache/solr/pull/518#discussion_r783237654 ## File path: solr/contrib/jwt-auth/src/java/org/apache/solr/security/JWTIssuerConfig.java ## @@ -408,8 +428,8 @@ private HttpsJwks create(String url) { }

[GitHub] [solr] HoustonPutman commented on a change in pull request #512: SOLR-15209: Make the LegacyAssignStrategy the DefaultPlacementPlugin

2022-01-12 Thread GitBox
HoustonPutman commented on a change in pull request #512: URL: https://github.com/apache/solr/pull/512#discussion_r783237167 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/plugins/DefaultPlacementFactory.java ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apa

[GitHub] [solr] HoustonPutman commented on pull request #512: SOLR-15209: Make the LegacyAssignStrategy the DefaultPlacementPlugin

2022-01-12 Thread GitBox
HoustonPutman commented on pull request #512: URL: https://github.com/apache/solr/pull/512#issuecomment-1011222062 > I see you're considering [SOLR-15209](https://issues.apache.org/jira/browse/SOLR-15209) as making `LegacyAssignStrategy` the default placement, when it originally was (and s

[GitHub] [solr] janhoy commented on a change in pull request #518: SOLR-15907 Move JWT auth plugin to contrib

2022-01-12 Thread GitBox
janhoy commented on a change in pull request #518: URL: https://github.com/apache/solr/pull/518#discussion_r783231303 ## File path: solr/contrib/jwt-auth/src/java/org/apache/solr/security/JWTIssuerConfig.java ## @@ -408,8 +428,8 @@ private HttpsJwks create(String url) { }

[jira] [Commented] (SOLR-15914) bin/solr argument to add contribs to classpath

2022-01-12 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474661#comment-17474661 ] Houston Putman commented on SOLR-15914: --- I am also perfectly fine moving the libs i

[GitHub] [solr] janhoy commented on a change in pull request #518: SOLR-15907 Move JWT auth plugin to contrib

2022-01-12 Thread GitBox
janhoy commented on a change in pull request #518: URL: https://github.com/apache/solr/pull/518#discussion_r783226802 ## File path: solr/contrib/jwt-auth/src/java/org/apache/solr/security/JWTAuthPlugin.java ## @@ -104,15 +102,31 @@ @Deprecated(since = "9.0") // Remove in 10

[GitHub] [solr] madrob commented on a change in pull request #518: SOLR-15907 Move JWT auth plugin to contrib

2022-01-12 Thread GitBox
madrob commented on a change in pull request #518: URL: https://github.com/apache/solr/pull/518#discussion_r783218761 ## File path: solr/contrib/jwt-auth/src/java/org/apache/solr/security/JWTAuthPlugin.java ## @@ -104,15 +102,31 @@ @Deprecated(since = "9.0") // Remove in 10

[GitHub] [solr] janhoy commented on a change in pull request #521: Suppressing some linter warnings, removing unused variable

2022-01-12 Thread GitBox
janhoy commented on a change in pull request #521: URL: https://github.com/apache/solr/pull/521#discussion_r783217977 ## File path: solr/contrib/s3-repository/src/test/org/apache/solr/s3/S3BackupRepositoryTest.java ## @@ -246,7 +248,7 @@ public void testRandomAccessInput() thr

[GitHub] [solr] madrob commented on a change in pull request #521: Suppressing some linter warnings, removing unused variable

2022-01-12 Thread GitBox
madrob commented on a change in pull request #521: URL: https://github.com/apache/solr/pull/521#discussion_r783215453 ## File path: solr/contrib/s3-repository/src/test/org/apache/solr/s3/S3BackupRepositoryTest.java ## @@ -246,7 +248,7 @@ public void testRandomAccessInput() thr

[GitHub] [solr] janhoy opened a new pull request #521: Suppressing some linter warnings, removing unused variable

2022-01-12 Thread GitBox
janhoy opened a new pull request #521: URL: https://github.com/apache/solr/pull/521 I got this failure on `gradlew check` on main, for class `S3BackupRepositoryTest`: ``` [InlineMeInliner] `Strings.repeat()` should be inlined ``` Have not seen the same from Jenkins, but

[GitHub] [solr] risdenk commented on a change in pull request #476: SOLR-15880

2022-01-12 Thread GitBox
risdenk commented on a change in pull request #476: URL: https://github.com/apache/solr/pull/476#discussion_r783204525 ## File path: solr/solr-ref-guide/src/neural-search.adoc ## @@ -0,0 +1,320 @@ += Neural Search +// Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [solr] risdenk commented on a change in pull request #476: SOLR-15880

2022-01-12 Thread GitBox
risdenk commented on a change in pull request #476: URL: https://github.com/apache/solr/pull/476#discussion_r783202537 ## File path: solr/solr-ref-guide/src/neural-search.adoc ## @@ -0,0 +1,320 @@ += Neural Search +// Licensed to the Apache Software Foundation (ASF) under one +

[jira] [Commented] (SOLR-15914) bin/solr argument to add contribs to classpath

2022-01-12 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474627#comment-17474627 ] Jan Høydahl commented on SOLR-15914: Also, I don't get why we need to have the dist/

[GitHub] [solr] uschindler edited a comment on pull request #501: Dynamically discover lucene version for use in build

2022-01-12 Thread GitBox
uschindler edited a comment on pull request #501: URL: https://github.com/apache/solr/pull/501#issuecomment-1011150139 > Maven coordinates only exist in maven. Gradle has module paths - build inclusion is kind of hacking these two worlds together. What's in that file is a result of trial-a

[jira] [Created] (SOLR-15914) bin/solr argument to add contribs to classpath

2022-01-12 Thread Jira
Jan Høydahl created SOLR-15914: -- Summary: bin/solr argument to add contribs to classpath Key: SOLR-15914 URL: https://issues.apache.org/jira/browse/SOLR-15914 Project: Solr Issue Type: Improveme

[GitHub] [solr] uschindler edited a comment on pull request #501: Dynamically discover lucene version for use in build

2022-01-12 Thread GitBox
uschindler edited a comment on pull request #501: URL: https://github.com/apache/solr/pull/501#issuecomment-1011150139 > Maven coordinates only exist in maven. Gradle has module paths - build inclusion is kind of hacking these two worlds together. What's in that file is a result of trial-a

[GitHub] [solr] uschindler edited a comment on pull request #501: Dynamically discover lucene version for use in build

2022-01-12 Thread GitBox
uschindler edited a comment on pull request #501: URL: https://github.com/apache/solr/pull/501#issuecomment-1011150139 > Maven coordinates only exist in maven. Gradle has module paths - build inclusion is kind of hacking these two worlds together. What's in that file is a result of trial-a

[GitHub] [solr] uschindler commented on pull request #501: Dynamically discover lucene version for use in build

2022-01-12 Thread GitBox
uschindler commented on pull request #501: URL: https://github.com/apache/solr/pull/501#issuecomment-1011150139 > Maven coordinates only exist in maven. Gradle has module paths - build inclusion is kind of hacking these two worlds together. What's in that file is a result of trial-and-erro

[GitHub] [solr] janhoy commented on a change in pull request #518: SOLR-15907 Move JWT auth plugin to contrib

2022-01-12 Thread GitBox
janhoy commented on a change in pull request #518: URL: https://github.com/apache/solr/pull/518#discussion_r783150980 ## File path: solr/contrib/jwt-auth/build.gradle ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[GitHub] [solr] janhoy commented on a change in pull request #518: SOLR-15907 Move JWT auth plugin to contrib

2022-01-12 Thread GitBox
janhoy commented on a change in pull request #518: URL: https://github.com/apache/solr/pull/518#discussion_r783150407 ## File path: solr/contrib/jwt-auth/build.gradle ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[GitHub] [solr] janhoy commented on a change in pull request #519: Script to scaffold a new contrib module

2022-01-12 Thread GitBox
janhoy commented on a change in pull request #519: URL: https://github.com/apache/solr/pull/519#discussion_r783149106 ## File path: dev-tools/scripts/addContrib.py ## @@ -0,0 +1,170 @@ +#!/usr/bin/env python3 +# -*- coding: utf-8 -*- +# Licensed to the Apache Software Foundatio

[GitHub] [solr] janhoy commented on a change in pull request #519: Script to scaffold a new contrib module

2022-01-12 Thread GitBox
janhoy commented on a change in pull request #519: URL: https://github.com/apache/solr/pull/519#discussion_r783147589 ## File path: dev-tools/scripts/addContrib.py ## @@ -0,0 +1,170 @@ +#!/usr/bin/env python3 +# -*- coding: utf-8 -*- +# Licensed to the Apache Software Foundatio

[GitHub] [solr] dweiss commented on a change in pull request #519: Script to scaffold a new contrib module

2022-01-12 Thread GitBox
dweiss commented on a change in pull request #519: URL: https://github.com/apache/solr/pull/519#discussion_r783121786 ## File path: dev-tools/scripts/addContrib.py ## @@ -0,0 +1,170 @@ +#!/usr/bin/env python3 +# -*- coding: utf-8 -*- +# Licensed to the Apache Software Foundatio

[GitHub] [solr] epugh commented on pull request #515: SOLR-15910: Fork semver4j library to fix semver bugs.

2022-01-12 Thread GitBox
epugh commented on pull request #515: URL: https://github.com/apache/solr/pull/515#issuecomment-1011075619 Maybe for an adjacent library, just having a fixed version that lives as someone's personal fork in Github would also be okay? Versus bringing in this code to the Solr project itself

[jira] [Created] (SOLR-15913) Override the use of the word Overriden with Overridden in Code

2022-01-12 Thread David Eric Pugh (Jira)
David Eric Pugh created SOLR-15913: -- Summary: Override the use of the word Overriden with Overridden in Code Key: SOLR-15913 URL: https://issues.apache.org/jira/browse/SOLR-15913 Project: Solr

[jira] [Commented] (SOLR-15501) GCSBackupRepository - allow bucket connection without credentials

2022-01-12 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474537#comment-17474537 ] Jason Gerlowski commented on SOLR-15501: {quote}Are you going to re-classify this

[GitHub] [solr] janhoy commented on a change in pull request #519: Script to scaffold a new contrib module

2022-01-12 Thread GitBox
janhoy commented on a change in pull request #519: URL: https://github.com/apache/solr/pull/519#discussion_r783085882 ## File path: dev-tools/scripts/addContrib.py ## @@ -0,0 +1,170 @@ +#!/usr/bin/env python3 +# -*- coding: utf-8 -*- +# Licensed to the Apache Software Foundatio

[jira] [Updated] (SOLR-15501) GCSBackupRepository - allow bucket connection without credentials

2022-01-12 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-15501: --- Issue Type: Bug (was: Improvement) > GCSBackupRepository - allow bucket connection without c

[GitHub] [solr] janhoy opened a new pull request #520: SOLR-15912 Update Guava to 31.0.1

2022-01-12 Thread GitBox
janhoy opened a new pull request #520: URL: https://github.com/apache/solr/pull/520 https://issues.apache.org/jira/browse/SOLR-15912 sonatype lift complained... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[jira] [Created] (SOLR-15912) Update Guava to 31.0.1

2022-01-12 Thread Jira
Jan Høydahl created SOLR-15912: -- Summary: Update Guava to 31.0.1 Key: SOLR-15912 URL: https://issues.apache.org/jira/browse/SOLR-15912 Project: Solr Issue Type: Task Security Level: Public

[GitHub] [solr] epugh commented on pull request #513: SOLR-9376: [xml] and [json] RawValue DocTransformers should work in cloud mode

2022-01-12 Thread GitBox
epugh commented on pull request #513: URL: https://github.com/apache/solr/pull/513#issuecomment-1011029402 Thanks for the explanation, and the use of `wt=javabin` makes sense on the _why_ this is happening. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [solr] alessandrobenedetti commented on a change in pull request #476: SOLR-15880

2022-01-12 Thread GitBox
alessandrobenedetti commented on a change in pull request #476: URL: https://github.com/apache/solr/pull/476#discussion_r783023194 ## File path: solr/solr-ref-guide/src/neural-search.adoc ## @@ -0,0 +1,320 @@ += Neural Search +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [solr] alessandrobenedetti commented on a change in pull request #476: SOLR-15880

2022-01-12 Thread GitBox
alessandrobenedetti commented on a change in pull request #476: URL: https://github.com/apache/solr/pull/476#discussion_r783023194 ## File path: solr/solr-ref-guide/src/neural-search.adoc ## @@ -0,0 +1,320 @@ += Neural Search +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [solr] alessandrobenedetti commented on a change in pull request #476: SOLR-15880

2022-01-12 Thread GitBox
alessandrobenedetti commented on a change in pull request #476: URL: https://github.com/apache/solr/pull/476#discussion_r783023972 ## File path: solr/solr-ref-guide/src/neural-search.adoc ## @@ -0,0 +1,320 @@ += Neural Search +// Licensed to the Apache Software Foundation (ASF)

  1   2   >