[GitHub] [solr] mkhludnev commented on pull request #1310: fix typo in comment (#1305)

2023-01-23 Thread via GitHub
mkhludnev commented on PR #1310: URL: https://github.com/apache/solr/pull/1310#issuecomment-1401475305 cc @renatoh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [solr] mkhludnev opened a new pull request, #1310: fix typo in comment (#1305)

2023-01-23 Thread via GitHub
mkhludnev opened a new pull request, #1310: URL: https://github.com/apache/solr/pull/1310 Co-authored-by: Renato Haeberli <> Cherry-pick #1305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [solr] dsmiley commented on a diff in pull request #1303: Add temporary pipeline to test Solr using machines provided by Crave.io

2023-01-23 Thread via GitHub
dsmiley commented on code in PR #1303: URL: https://github.com/apache/solr/pull/1303#discussion_r1084829522 ## .github/workflows/tests-via-crave.yml: ## @@ -0,0 +1,38 @@ +name: Solr Tests + +on: + pull_request: +branches: + - 'main' + +jobs: + test: +name: Run

[jira] [Assigned] (SOLR-16629) Replace SolrSingleThreaded and SolrThreadSafe annotations with JCIP

2023-01-23 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley reassigned SOLR-16629: --- Assignee: David Smiley > Replace SolrSingleThreaded and SolrThreadSafe annotations with

[GitHub] [solr] dsmiley commented on a diff in pull request #1303: Add temporary pipeline to test Solr using machines provided by Crave.io

2023-01-23 Thread via GitHub
dsmiley commented on code in PR #1303: URL: https://github.com/apache/solr/pull/1303#discussion_r1084822103 ## .github/workflows/solrj-test-crave.yml: ## @@ -0,0 +1,41 @@ +name: SolrJ Tests + +on: + pull_request: +branches: + - 'main' +paths: + -

[GitHub] [solr] uvatbc commented on a diff in pull request #1303: Add temporary pipeline to test Solr using machines provided by Crave.io

2023-01-23 Thread via GitHub
uvatbc commented on code in PR #1303: URL: https://github.com/apache/solr/pull/1303#discussion_r1084786595 ## .github/workflows/solrj-test-crave.yml: ## @@ -0,0 +1,41 @@ +name: SolrJ Tests + +on: + pull_request: +branches: + - 'main' +paths: + -

[GitHub] [solr] elyograg commented on a diff in pull request #1303: Add temporary pipeline to test Solr using machines provided by Crave.io

2023-01-23 Thread via GitHub
elyograg commented on code in PR #1303: URL: https://github.com/apache/solr/pull/1303#discussion_r1084781451 ## .github/workflows/solrj-test-crave.yml: ## @@ -0,0 +1,41 @@ +name: SolrJ Tests + +on: + pull_request: +branches: + - 'main' +paths: + -

[GitHub] [solr] uvatbc commented on a diff in pull request #1303: Add temporary pipeline to test Solr using machines provided by Crave.io

2023-01-23 Thread via GitHub
uvatbc commented on code in PR #1303: URL: https://github.com/apache/solr/pull/1303#discussion_r1084776393 ## .github/workflows/solrj-test-crave.yml: ## @@ -0,0 +1,41 @@ +name: SolrJ Tests + +on: + pull_request: +branches: + - 'main' +paths: + -

[GitHub] [solr] uvatbc commented on a diff in pull request #1303: Add temporary pipeline to test Solr using machines provided by Crave.io

2023-01-23 Thread via GitHub
uvatbc commented on code in PR #1303: URL: https://github.com/apache/solr/pull/1303#discussion_r1084774842 ## .github/workflows/solrj-test-crave.yml: ## @@ -0,0 +1,41 @@ +name: SolrJ Tests + +on: + pull_request: +branches: + - 'main' +paths: + -

[GitHub] [solr] uvatbc commented on a diff in pull request #1303: Add temporary pipeline to test Solr using machines provided by Crave.io

2023-01-23 Thread via GitHub
uvatbc commented on code in PR #1303: URL: https://github.com/apache/solr/pull/1303#discussion_r1084774519 ## .github/workflows/solrj-test-crave.yml: ## @@ -0,0 +1,41 @@ +name: SolrJ Tests Review Comment: Fixed. -- This is an automated message from the Apache Git

[GitHub] [solr] uvatbc commented on a diff in pull request #1303: Add temporary pipeline to test Solr using machines provided by Crave.io

2023-01-23 Thread via GitHub
uvatbc commented on code in PR #1303: URL: https://github.com/apache/solr/pull/1303#discussion_r1084774129 ## .github/workflows/solrj-test-crave.yml: ## @@ -0,0 +1,41 @@ +name: SolrJ Tests + +on: + pull_request: +branches: + - 'main' +paths: + -

[GitHub] [solr] uvatbc commented on a diff in pull request #1303: Add temporary pipeline to test Solr using machines provided by Crave.io

2023-01-23 Thread via GitHub
uvatbc commented on code in PR #1303: URL: https://github.com/apache/solr/pull/1303#discussion_r1084773938 ## .github/workflows/solrj-test-crave.yml: ## @@ -0,0 +1,41 @@ +name: SolrJ Tests + +on: + pull_request: +branches: + - 'main' +paths: + -

[GitHub] [solr] dsmiley commented on a diff in pull request #1303: Add temporary pipeline to test Solr using machines provided by Crave.io

2023-01-23 Thread via GitHub
dsmiley commented on code in PR #1303: URL: https://github.com/apache/solr/pull/1303#discussion_r1084758269 ## .github/workflows/solrj-test-crave.yml: ## @@ -0,0 +1,41 @@ +name: SolrJ Tests + +on: + pull_request: +branches: + - 'main' +paths: + -

[jira] [Resolved] (SOLR-16121) Create CONTRIBUTING.md in the git repo's top-level folder

2023-01-23 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-16121. Resolution: Duplicate > Create CONTRIBUTING.md in the git repo's top-level folder >

[GitHub] [solr] dsmiley commented on a diff in pull request #1286: SOLR-16615: Reuse Jersey apps for cores with the same configset

2023-01-23 Thread via GitHub
dsmiley commented on code in PR #1286: URL: https://github.com/apache/solr/pull/1286#discussion_r1084625105 ## solr/core/src/java/org/apache/solr/core/ConfigOverlay.java: ## @@ -34,15 +34,15 @@ * performed on tbhis gives a new copy of the object with the changed value */

[jira] [Resolved] (SOLR-15682) Add a CONTRIBUTING file

2023-01-23 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-15682. -- Resolution: Duplicate > Add a CONTRIBUTING file > --- > > Key:

[jira] [Resolved] (SOLR-16602) Update Ref Guide steps for Packages

2023-01-23 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-16602. -- Fix Version/s: main (10.0) 9.2 9.1.1 Resolution: Fixed

[GitHub] [solr] epugh commented on pull request #1273: SOLR-16610: Support Copy n Paste of Command Line commands in Ref Guide

2023-01-23 Thread via GitHub
epugh commented on PR #1273: URL: https://github.com/apache/solr/pull/1273#issuecomment-1401054406 Finished all the tutorials, which I guess are the most likely to have straight up cut'n'paste? -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (SOLR-16634) "gradlew check" fails with OOM on fresh clone

2023-01-23 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680030#comment-17680030 ] Michael Gibney commented on SOLR-16634: --- Yeah, you really have to run localSettings first.

[jira] [Commented] (SOLR-16634) "gradlew check" fails with OOM on fresh clone

2023-01-23 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680012#comment-17680012 ] Kevin Risden commented on SOLR-16634: - [~ichattopadhyaya] go ahead and take my comment out of

[jira] [Commented] (SOLR-16438) Shard split should be able to set preferred leaders on other replicas

2023-01-23 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680011#comment-17680011 ] Bruno Roustant commented on SOLR-16438: --- Thanks [~houston] for the reminder. I'm going to look at

[jira] [Commented] (SOLR-16438) Shard split should be able to set preferred leaders on other replicas

2023-01-23 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680009#comment-17680009 ] Houston Putman commented on SOLR-16438: --- [~broustant] could you look into the failing test? >

[jira] [Created] (SOLR-16634) "gradlew check" fails with OOM on fresh clone

2023-01-23 Thread Ishan Chattopadhyaya (Jira)
Ishan Chattopadhyaya created SOLR-16634: --- Summary: "gradlew check" fails with OOM on fresh clone Key: SOLR-16634 URL: https://issues.apache.org/jira/browse/SOLR-16634 Project: Solr

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680008#comment-17680008 ] Ishan Chattopadhyaya commented on SOLR-15616: - I've opened a new issue about the broken

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17680002#comment-17680002 ] Noble Paul commented on SOLR-15616: --- {quote} you should have reverted the change immediately.  {quote}

[jira] [Comment Edited] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2023-01-23 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679980#comment-17679980 ] Ishan Chattopadhyaya edited comment on SOLR-16347 at 1/23/23 7:40 PM:

[jira] [Commented] (SOLR-16615) Colocated cores with the same configset should share resources

2023-01-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679998#comment-17679998 ] ASF subversion and git services commented on SOLR-16615: Commit

[jira] [Commented] (SOLR-16615) Colocated cores with the same configset should share resources

2023-01-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679997#comment-17679997 ] ASF subversion and git services commented on SOLR-16615: Commit

[GitHub] [solr] mkhludnev commented on pull request #1308: Apache 9x

2023-01-23 Thread via GitHub
mkhludnev commented on PR #1308: URL: https://github.com/apache/solr/pull/1308#issuecomment-1400870955 Absolutely, @HoustonPutman https://github.com/apache/solr/pull/1305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (SOLR-16615) Colocated cores with the same configset should share resources

2023-01-23 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679995#comment-17679995 ] Jason Gerlowski commented on SOLR-16615: Yes, that was definitely from a commit I merged this

[GitHub] [solr] epugh commented on pull request #1273: SOLR-16610: Support Copy n Paste of Command Line commands in Ref Guide

2023-01-23 Thread via GitHub
epugh commented on PR #1273: URL: https://github.com/apache/solr/pull/1273#issuecomment-1400853122 The multiline `curl` command even worked!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [solr] HoustonPutman commented on pull request #1273: SOLR-16610: Support Copy n Paste of Command Line commands in Ref Guide

2023-01-23 Thread via GitHub
HoustonPutman commented on PR #1273: URL: https://github.com/apache/solr/pull/1273#issuecomment-1400849355 +1 from me > I get that... Does it deal properly with the multiple line thing? I tested it locally and it works as expected, only copying the lines that start with `$`.

[GitHub] [solr] HoustonPutman commented on pull request #1308: Apache 9x

2023-01-23 Thread via GitHub
HoustonPutman commented on PR #1308: URL: https://github.com/apache/solr/pull/1308#issuecomment-1400846172 Did this go to `main` first? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [solr] mkhludnev commented on pull request #1308: Apache 9x

2023-01-23 Thread via GitHub
mkhludnev commented on PR #1308: URL: https://github.com/apache/solr/pull/1308#issuecomment-1400838707 Yeah! Right. Appreciate. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [solr] mkhludnev merged pull request #1308: Apache 9x

2023-01-23 Thread via GitHub
mkhludnev merged PR #1308: URL: https://github.com/apache/solr/pull/1308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (SOLR-16618) Admin UI Analysis page should include dynamic fields

2023-01-23 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679987#comment-17679987 ] Eric Pugh edited comment on SOLR-16618 at 1/23/23 7:02 PM: --- That makes sense.

[jira] [Commented] (SOLR-16618) Admin UI Analysis page should include dynamic fields

2023-01-23 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679987#comment-17679987 ] Eric Pugh commented on SOLR-16618: -- That makes sense. I'm not sure that I can propose a realistic N...

[jira] [Commented] (SOLR-16618) Admin UI Analysis page should include dynamic fields

2023-01-23 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679985#comment-17679985 ] Michael Gibney commented on SOLR-16618: --- Yeah I'm not sure about making this routine; I guess my

[jira] [Commented] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2023-01-23 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679980#comment-17679980 ] Ishan Chattopadhyaya commented on SOLR-16347: - bq. It's not the distaste. The perf runs are

[jira] [Updated] (SOLR-16633) SolrZkClient read with retry operations should support timeout

2023-01-23 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-16633: -- Description: If {{retryOnConnLoss=true}} is passed to

[jira] [Comment Edited] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2023-01-23 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679978#comment-17679978 ] Noble Paul edited comment on SOLR-16347 at 1/23/23 6:48 PM: {quote} but

[jira] [Comment Edited] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2023-01-23 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679978#comment-17679978 ] Noble Paul edited comment on SOLR-16347 at 1/23/23 6:48 PM: {quote} but

[jira] [Comment Edited] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2023-01-23 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679978#comment-17679978 ] Noble Paul edited comment on SOLR-16347 at 1/23/23 6:48 PM: {quote} but

[jira] [Commented] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2023-01-23 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679978#comment-17679978 ] Noble Paul commented on SOLR-16347: --- {quote} but there's no technical issue to using it afaict, beyond

[jira] [Commented] (SOLR-16618) Admin UI Analysis page should include dynamic fields

2023-01-23 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679976#comment-17679976 ] Eric Pugh commented on SOLR-16618: -- Do we need a seperate JIRA for "Solr Admin UI adapts to very complex

[jira] [Commented] (SOLR-16618) Admin UI Analysis page should include dynamic fields

2023-01-23 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679973#comment-17679973 ] Eric Pugh commented on SOLR-16618: -- Definitely haven't considered that, either for this PR or any other

[jira] [Commented] (SOLR-16618) Admin UI Analysis page should include dynamic fields

2023-01-23 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679960#comment-17679960 ] Michael Gibney commented on SOLR-16618: --- Sorry to weigh in belatedly here: I have a concern about

[jira] [Commented] (SOLR-16615) Colocated cores with the same configset should share resources

2023-01-23 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679958#comment-17679958 ] Chris M. Hostetter commented on SOLR-16615: --- This seems related and bad... {noformat} Build:

[GitHub] [solr] stillalex commented on pull request #1304: SOLR-16618 Admin UI Analysis page should include dynamic fields

2023-01-23 Thread via GitHub
stillalex commented on PR #1304: URL: https://github.com/apache/solr/pull/1304#issuecomment-1400790967 > Sure! I can buy that. So... leave the todo? It otherwise looks good to merge. yep, leave the todo. there is only that string matching issue in the combo which I don't know how to

[GitHub] [solr] epugh commented on pull request #1273: SOLR-16610: Support Copy n Paste of Command Line commands in Ref Guide

2023-01-23 Thread via GitHub
epugh commented on PR #1273: URL: https://github.com/apache/solr/pull/1273#issuecomment-1400751651 @risdenk so the `console` seemed to work out really nicely Thoughts? Love a +1 before I start plowing through the Ref Guide ;-) -- This is an automated message from the Apache Git

[GitHub] [solr] epugh commented on pull request #1304: SOLR-16618 Admin UI Analysis page should include dynamic fields

2023-01-23 Thread via GitHub
epugh commented on PR #1304: URL: https://github.com/apache/solr/pull/1304#issuecomment-1400748206 > Sure! I can buy that. So... leave the todo? It otherwise looks good to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [solr-operator] HoustonPutman commented on a diff in pull request #520: Use correct user for chmod command in cp-solr-xml init container

2023-01-23 Thread via GitHub
HoustonPutman commented on code in PR #520: URL: https://github.com/apache/solr-operator/pull/520#discussion_r1084366285 ## controllers/util/solr_util.go: ## @@ -594,6 +594,21 @@ func generateSolrSetupInitContainers(solrCloud *solr.SolrCloud, solrCloudStatus }

[GitHub] [solr-operator] HoustonPutman merged pull request #518: Update local_tutorial.md

2023-01-23 Thread via GitHub
HoustonPutman merged PR #518: URL: https://github.com/apache/solr-operator/pull/518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [solr-operator] HoustonPutman commented on pull request #516: Fix SolrBackup not taking backups when the collections field is omitted

2023-01-23 Thread via GitHub
HoustonPutman commented on PR #516: URL: https://github.com/apache/solr-operator/pull/516#issuecomment-1400737473 This looks good to me! We can merge this before the e2e tests, and add a test for it after that is merged! -- This is an automated message from the Apache Git Service. To

[GitHub] [solr-operator] HoustonPutman commented on a diff in pull request #520: Use correct user for chmod command in cp-solr-xml init container

2023-01-23 Thread via GitHub
HoustonPutman commented on code in PR #520: URL: https://github.com/apache/solr-operator/pull/520#discussion_r1084358734 ## controllers/util/solr_util.go: ## @@ -594,6 +594,21 @@ func generateSolrSetupInitContainers(solrCloud *solr.SolrCloud, solrCloudStatus }

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679930#comment-17679930 ] Ishan Chattopadhyaya commented on SOLR-15616: - Thanks [~dsmiley]! :-) > Allow thread metrics

[GitHub] [solr] stillalex commented on pull request #1304: SOLR-16618 Admin UI Analysis page should include dynamic fields

2023-01-23 Thread via GitHub
stillalex commented on PR #1304: URL: https://github.com/apache/solr/pull/1304#issuecomment-1400705981 > How hard would it be to change the query to submit when you click the button? Are there other places we link to the schema analysis page and have it auto run, so that requiring a button

[jira] [Commented] (SOLR-16615) Colocated cores with the same configset should share resources

2023-01-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679898#comment-17679898 ] ASF subversion and git services commented on SOLR-16615: Commit

[GitHub] [solr] epugh commented on pull request #1304: SOLR-16618 Admin UI Analysis page should include dynamic fields

2023-01-23 Thread via GitHub
epugh commented on PR #1304: URL: https://github.com/apache/solr/pull/1304#issuecomment-1400650619 > > I see the ? from the bool... I was trying to figure out if there is something we could put there, like "Bool" or something? But regardless, I like how this works... > > I would

[GitHub] [solr] epugh commented on pull request #1304: SOLR-16618 Admin UI Analysis page should include dynamic fields

2023-01-23 Thread via GitHub
epugh commented on PR #1304: URL: https://github.com/apache/solr/pull/1304#issuecomment-1400648984 > I started thinking about another param... but that feels a bit like the `goto` statement of web dev. How hard would it be to change the query to submit when you click the button?

[jira] [Commented] (SOLR-16615) Colocated cores with the same configset should share resources

2023-01-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679879#comment-17679879 ] ASF subversion and git services commented on SOLR-16615: Commit

[GitHub] [solr] gerlowskija merged pull request #1286: SOLR-16615: Reuse Jersey apps for cores with the same configset

2023-01-23 Thread via GitHub
gerlowskija merged PR #1286: URL: https://github.com/apache/solr/pull/1286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679877#comment-17679877 ] David Smiley commented on SOLR-15616: - Ishan, if "gradlew check" or precommit isn't working for you

[GitHub] [solr] stillalex commented on pull request #1304: SOLR-16618 Admin UI Analysis page should include dynamic fields

2023-01-23 Thread via GitHub
stillalex commented on PR #1304: URL: https://github.com/apache/solr/pull/1304#issuecomment-1400620486 > Maybe we don't need the default value if we just show the page, but don't submit it to the backend, which then avoids the error message. I agree with this idea, but the way the

[GitHub] [solr] stillalex commented on pull request #1304: SOLR-16618 Admin UI Analysis page should include dynamic fields

2023-01-23 Thread via GitHub
stillalex commented on PR #1304: URL: https://github.com/apache/solr/pull/1304#issuecomment-1400615323 > I see the ? from the bool... I was trying to figure out if there is something we could put there, like "Bool" or something? But regardless, I like how this works... I would keep

[jira] [Commented] (SOLR-16556) Solr stream expression: Implement Page Streaming Decorator to allow results to be displayed with pagination.

2023-01-23 Thread Maulin (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679873#comment-17679873 ] Maulin commented on SOLR-16556: --- Hi [~jbernste] Did you get a chance to look into this? Please let me know

[jira] [Assigned] (SOLR-16618) Admin UI Analysis page should include dynamic fields

2023-01-23 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh reassigned SOLR-16618: Assignee: Eric Pugh > Admin UI Analysis page should include dynamic fields >

[GitHub] [solr] epugh commented on pull request #1304: SOLR-16618 Admin UI Analysis page should include dynamic fields

2023-01-23 Thread via GitHub
epugh commented on PR #1304: URL: https://github.com/apache/solr/pull/1304#issuecomment-1400580787 https://user-images.githubusercontent.com/22395/214085226-599d3a5b-1b6d-40e5-a1d4-88355f5172f7.png;> Ahh... Now I see the `@todo` reasonI wonder if the right fix is to pick

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679862#comment-17679862 ] Ishan Chattopadhyaya commented on SOLR-15616: - !Screenshot from 2023-01-23 21-18-19.png! I

[jira] [Updated] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya updated SOLR-15616: Attachment: Screenshot from 2023-01-23 21-18-19.png > Allow thread metrics to be

[GitHub] [solr] epugh commented on pull request #1304: SOLR-16618 Admin UI Analysis page should include dynamic fields

2023-01-23 Thread via GitHub
epugh commented on PR #1304: URL: https://github.com/apache/solr/pull/1304#issuecomment-1400570621 https://user-images.githubusercontent.com/22395/214083749-158ac761-ba50-4820-b221-5b52cd4293c6.png;> I see the `?` from the bool... I was trying to figure out if there is something we

[jira] [Comment Edited] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679855#comment-17679855 ] Ishan Chattopadhyaya edited comment on SOLR-15616 at 1/23/23 3:39 PM:

[jira] [Comment Edited] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679855#comment-17679855 ] Ishan Chattopadhyaya edited comment on SOLR-15616 at 1/23/23 3:38 PM:

[GitHub] [solr] epugh commented on a diff in pull request #1304: SOLR-16618 Admin UI Analysis page should include dynamic fields

2023-01-23 Thread via GitHub
epugh commented on code in PR #1304: URL: https://github.com/apache/solr/pull/1304#discussion_r1084211406 ## solr/webapp/web/js/angular/controllers/analysis.js: ## @@ -21,33 +21,64 @@ solrAdminApp.controller('AnalysisController', $scope.refresh = function() {

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679855#comment-17679855 ] Ishan Chattopadhyaya commented on SOLR-15616: - bq. you made not 1 but 2 commits that broke

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679852#comment-17679852 ] Kevin Risden commented on SOLR-15616: - {quote}That is a ridiculous statement right there{quote} I

[jira] [Resolved] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya resolved SOLR-15616. - Fix Version/s: 9.2 Resolution: Fixed I'm hoping the gradlew check is back

[jira] [Comment Edited] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679847#comment-17679847 ] Ishan Chattopadhyaya edited comment on SOLR-15616 at 1/23/23 3:22 PM:

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679849#comment-17679849 ] Ishan Chattopadhyaya commented on SOLR-15616: - bq. What is the contents of gradle.properties?

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679847#comment-17679847 ] Ishan Chattopadhyaya commented on SOLR-15616: - bq. You are explicitly working AGAINST the

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679843#comment-17679843 ] Kevin Risden commented on SOLR-15616: - What is the contents of gradle.properties? > Allow thread

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679841#comment-17679841 ] Ishan Chattopadhyaya commented on SOLR-15616: - bq. It is fixed. I hope you're right. But,

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679837#comment-17679837 ] Kevin Risden commented on SOLR-15616: - > If a system with 64GB RAM is running into OOM errors with

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679835#comment-17679835 ] Ishan Chattopadhyaya commented on SOLR-15616: - If a system with 64GB RAM is running into OOM

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679833#comment-17679833 ] Ishan Chattopadhyaya commented on SOLR-15616: - Did the localSettings thing now, and it is

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679832#comment-17679832 ] Ishan Chattopadhyaya commented on SOLR-15616: - Running the gradlew check after a "git clean

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679831#comment-17679831 ] Kevin Risden commented on SOLR-15616: - Rm only solr/modules/jaegertracer-configurator since its there

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679830#comment-17679830 ] Ishan Chattopadhyaya commented on SOLR-15616: - After localSettings thing, I see unrelated

[jira] [Comment Edited] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2023-01-23 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679826#comment-17679826 ] Jason Gerlowski edited comment on SOLR-16347 at 1/23/23 2:44 PM: - I was

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679827#comment-17679827 ] Kevin Risden commented on SOLR-15616: - {quote}I do `git clean -fdx` every time before running these

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679828#comment-17679828 ] ASF subversion and git services commented on SOLR-15616: Commit

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679829#comment-17679829 ] ASF subversion and git services commented on SOLR-15616: Commit

[jira] [Comment Edited] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679827#comment-17679827 ] Kevin Risden edited comment on SOLR-15616 at 1/23/23 2:44 PM: -- {quote}I do

[jira] [Commented] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2023-01-23 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679826#comment-17679826 ] Jason Gerlowski commented on SOLR-16347: I was offline/afk last week. I'd hoped to merge the fix

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679825#comment-17679825 ] Ishan Chattopadhyaya commented on SOLR-15616: - I do `git clean -fdx` every time before

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679824#comment-17679824 ] Kevin Risden commented on SOLR-15616: - {code:java} IMPORTANT. This is the first time you ran the

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679823#comment-17679823 ] Ishan Chattopadhyaya commented on SOLR-15616: - Still can't run this gradlew check thing due

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679820#comment-17679820 ] ASF subversion and git services commented on SOLR-15616: Commit

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679819#comment-17679819 ] ASF subversion and git services commented on SOLR-15616: Commit

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679808#comment-17679808 ] ASF subversion and git services commented on SOLR-15616: Commit

  1   2   >