[GitHub] [solr] janhoy commented on a diff in pull request #1792: add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end)

janhoy commented on code in PR #1792: URL: https://github.com/apache/solr/pull/1792#discussion_r1311966439 ## solr/CHANGES.txt: ## @@ -147,6 +149,8 @@ Bug Fixes * SOLR-16916: Use of the JSON Query DSL should ignore the defType parameter (Christina Chortaria, Max Kadel, Ryan

[GitHub] [solr] janhoy commented on a diff in pull request #1792: add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end)

janhoy commented on code in PR #1792: URL: https://github.com/apache/solr/pull/1792#discussion_r1311948300 ## solr/CHANGES.txt: ## @@ -147,6 +149,8 @@ Bug Fixes * SOLR-16916: Use of the JSON Query DSL should ignore the defType parameter (Christina Chortaria, Max Kadel, Ryan

[GitHub] [solr] janhoy commented on a diff in pull request #1792: add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end)

janhoy commented on code in PR #1792: URL: https://github.com/apache/solr/pull/1792#discussion_r1311708090 ## solr/core/src/java/org/apache/solr/servlet/LoadAdminUiServlet.java: ## @@ -60,20 +66,49 @@ public void doGet(HttpServletRequest _request, HttpServletResponse _response)

[GitHub] [solr] janhoy commented on a diff in pull request #1792: add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end)

janhoy commented on code in PR #1792: URL: https://github.com/apache/solr/pull/1792#discussion_r1311699269 ## solr/server/etc/jetty.xml: ## @@ -99,6 +100,7 @@ Review Comment: Ok, turned out to be much simpler. Just leaving the `HeaderPatternRule

[GitHub] [solr] janhoy commented on a diff in pull request #1792: add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end)

janhoy commented on code in PR #1792: URL: https://github.com/apache/solr/pull/1792#discussion_r1311360400 ## solr/server/etc/jetty.xml: ## @@ -99,6 +100,7 @@ Review Comment: Ok, think I found a nice generic way of doing it: ```patch diff

[GitHub] [solr] janhoy commented on a diff in pull request #1792: add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end)

janhoy commented on code in PR #1792: URL: https://github.com/apache/solr/pull/1792#discussion_r1311324407 ## solr/server/etc/jetty.xml: ## @@ -99,6 +100,7 @@ Review Comment: If there's an easy way to provide a "fallback" if the header is not se

[GitHub] [solr] janhoy commented on a diff in pull request #1792: add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end)

janhoy commented on code in PR #1792: URL: https://github.com/apache/solr/pull/1792#discussion_r1311274572 ## solr/server/etc/jetty.xml: ## @@ -99,6 +100,7 @@ Review Comment: @rmuir You added the CSP stuff to `jetty.xml`. Do you see a reason to

[GitHub] [solr] janhoy commented on a diff in pull request #1792: add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end)

janhoy commented on code in PR #1792: URL: https://github.com/apache/solr/pull/1792#discussion_r1310867905 ## solr/solr-ref-guide/modules/deployment-guide/pages/jwt-authentication-plugin.adoc: ## @@ -85,6 +85,8 @@ jwk ; As an alternative to `jwksUrl` you may pr

[GitHub] [solr] janhoy commented on a diff in pull request #1792: add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end)

janhoy commented on code in PR #1792: URL: https://github.com/apache/solr/pull/1792#discussion_r1301667152 ## solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTIssuerConfig.java: ## @@ -64,12 +72,18 @@ public class JWTIssuerConfig { private WellKnownDiscoveryConf

[GitHub] [solr] janhoy commented on a diff in pull request #1792: add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end)

janhoy commented on code in PR #1792: URL: https://github.com/apache/solr/pull/1792#discussion_r1297811474 ## solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java: ## @@ -847,9 +851,11 @@ protected String generateAuthDataHeader() { Map data = new H

[GitHub] [solr] janhoy commented on a diff in pull request #1792: add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end)

janhoy commented on code in PR #1792: URL: https://github.com/apache/solr/pull/1792#discussion_r1296170780 ## solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java: ## @@ -847,9 +851,11 @@ protected String generateAuthDataHeader() { Map data = new H

[GitHub] [solr] janhoy commented on a diff in pull request #1792: add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end)

janhoy commented on code in PR #1792: URL: https://github.com/apache/solr/pull/1792#discussion_r1296161226 ## solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java: ## @@ -847,9 +851,11 @@ protected String generateAuthDataHeader() { Map data = new H

[GitHub] [solr] janhoy commented on a diff in pull request #1792: add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end)

janhoy commented on code in PR #1792: URL: https://github.com/apache/solr/pull/1792#discussion_r1292849716 ## solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTIssuerConfig.java: ## @@ -315,6 +327,24 @@ public JWTIssuerConfig setAuthorizationEndpoint(String authori