[
https://issues.apache.org/jira/browse/LUCENE-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839187#action_12839187
]
Uwe Schindler commented on LUCENE-2285:
---
Hi Shai,
I applied the patch to a fresh ch
[
https://issues.apache.org/jira/browse/LUCENE-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839187#action_12839187
]
Uwe Schindler edited comment on LUCENE-2285 at 2/27/10 8:08 AM:
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839191#action_12839191
]
Uwe Schindler commented on LUCENE-2037:
---
Erick,
thats already fixed in trunk with m
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839191#action_12839191
]
Uwe Schindler edited comment on LUCENE-2037 at 2/27/10 8:16 AM:
[
https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-2037:
--
Attachment: LUCENE-2037-LegacyChecker.patch
Here the patch for the additional assertion to tes
[
https://issues.apache.org/jira/browse/LUCENE-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839197#action_12839197
]
Uwe Schindler commented on LUCENE-2285:
---
Maybe the patch is also outdated, i goes ag
[
https://issues.apache.org/jira/browse/LUCENE-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839202#action_12839202
]
Shai Erera commented on LUCENE-2285:
Ok I see the problem now - because there are so m
[
https://issues.apache.org/jira/browse/LUCENE-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839203#action_12839203
]
Shai Erera commented on LUCENE-2285:
Strange ... something's wrong w/ eclipse and how
[
https://issues.apache.org/jira/browse/LUCENE-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839208#action_12839208
]
Shai Erera commented on LUCENE-2285:
Googling around I see it's a known problem in Ecl
[
https://issues.apache.org/jira/browse/LUCENE-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839211#action_12839211
]
Uwe Schindler commented on LUCENE-2285:
---
bq. Strange ... something's wrong w/ eclips
[
https://issues.apache.org/jira/browse/LUCENE-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839212#action_12839212
]
Shai Erera commented on LUCENE-2285:
Ok, perhaps you misunderstood me. I suggested to
[
https://issues.apache.org/jira/browse/LUCENE-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839216#action_12839216
]
Uwe Schindler commented on LUCENE-2285:
---
I understood that, I just wanted to say tha
[
https://issues.apache.org/jira/browse/LUCENE-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839219#action_12839219
]
Shai Erera commented on LUCENE-2285:
Ok then we understand each other. Indeed I have a
[
https://issues.apache.org/jira/browse/LUCENE-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839224#action_12839224
]
Uwe Schindler commented on LUCENE-2285:
---
bq. When a method declares it returns an in
> LUCENE-1990-te20100212.patch, LUCENE-1990-te20100223.patch,
> LUCENE-1990-te20100226.patch, LUCENE-1990-te20100226b.patch,
> LUCENE-1990-te20100226c.patch, LUCENE-1990.patch,
> LUCENE-1990_PerformanceMeasurements20100104.zip, perf-mkm-20100227.txt,
> performance-te20100226.txt
>
&
[
https://issues.apache.org/jira/browse/LUCENE-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-1990:
---
Attachment: perf-mkm-20100227.txt
{quote}
bq. Airplane blocking snow drifts!? Where
[
https://issues.apache.org/jira/browse/LUCENE-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839242#action_12839242
]
Robert Muir commented on LUCENE-2285:
-
bq. Googling around I see it's a known problem
[
https://issues.apache.org/jira/browse/LUCENE-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839254#action_12839254
]
Shai Erera commented on LUCENE-2285:
bq. copy the entire patch to clipboard
Super Rob
[
https://issues.apache.org/jira/browse/LUCENE-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839254#action_12839254
]
Shai Erera edited comment on LUCENE-2285 at 2/27/10 3:00 PM:
-
[
https://issues.apache.org/jira/browse/LUCENE-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839256#action_12839256
]
Robert Muir commented on LUCENE-2285:
-
bq. In my internal project, I also make use of
[
https://issues.apache.org/jira/browse/LUCENE-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839258#action_12839258
]
Shai Erera commented on LUCENE-2285:
bq. I'd be curious to know what you did
Ok, now
[
https://issues.apache.org/jira/browse/LUCENE-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839259#action_12839259
]
Uwe Schindler commented on LUCENE-2285:
---
bq. UnicodeUtil
I reverted the whole clas
i wanted to continue this here to not clog up the issue!
Shai Erera commented on LUCENE-2285:
> bq. I'd be curious to know what you did
>
> Ok, now you've made me compare the two :). I'm happy to see we both did the
> same thing, only you call your buffer 'current' while I call it 'buf'.
> Beside
[
https://issues.apache.org/jira/browse/LUCENE-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839262#action_12839262
]
Uwe Schindler commented on LUCENE-2285:
---
I will commit the current patch soon and po
[
https://issues.apache.org/jira/browse/LUCENE-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-2089:
---
Attachment: LUCENE-2089.patch
New rev of gen.py, that uses packed arrays for the sta
[
https://issues.apache.org/jira/browse/LUCENE-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-2089:
---
Attachment: LUCENE-2089.patch
New patch... just fixes a few small things Uwe noticed
Hi Robert, the EMPTY_ARGS stuff is just in SnowballProgram. I didn't touch
the generated code, besides handling calling deprecated API.
We've actually taken the same approach I think :). In my Analyzer, the user
passes a Locale to create the proper Analyzer. The analyzer comes
pre-configured w/ al
Can you open an issue for the new object[]? its sad about the hungarian
issue. I'm inclined to think we should add savoy's and default to it
instead. I don't see this as code duplication, as its a different alg.
Normally just don't spend a lot of effort towards adding alternative
stemmers, but h
[
https://issues.apache.org/jira/browse/LUCENE-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler resolved LUCENE-2285.
---
Resolution: Fixed
Committed revision: 917019
I will attach the open changes as separate pat
[
https://issues.apache.org/jira/browse/LUCENE-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-2285:
--
Attachment: LUCENE-2285-remaining+generated.patch
LUCENE-2285-remaining.patch
[
https://issues.apache.org/jira/browse/LUCENE-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839307#action_12839307
]
Robert Muir commented on LUCENE-2089:
-
Mike, this is awesome. I ran benchmarks: we are
Create EMPTY_ARGS constsant in SnowballProgram instead of allocating new
Object[0]
--
Key: LUCENE-2288
URL: https://issues.apache.org/jira/browse/LUCENE-2288
Project: Luc
[
https://issues.apache.org/jira/browse/LUCENE-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-2288:
---
Attachment: LUCENE--2288.patch
Patch w/ the trivial change.
> Create EMPTY_ARGS constsant in Snowba
I created LUCENE-2288 for handling the Object[] thingy in SnowballProgram
(and Class[] in Among).
Shai
On Sat, Feb 27, 2010 at 8:48 PM, Robert Muir wrote:
> Can you open an issue for the new object[]? its sad about the hungarian
> issue. I'm inclined to think we should add savoy's and default
[
https://issues.apache.org/jira/browse/LUCENE-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839311#action_12839311
]
Shai Erera commented on LUCENE-2288:
Forgot to mention all analysis tests pass.
> Cre
Calls to SegmentInfos.message should be wrapped w/ infoStream != null checks
Key: LUCENE-2289
URL: https://issues.apache.org/jira/browse/LUCENE-2289
Project: Lucene - Java
[
https://issues.apache.org/jira/browse/LUCENE-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-2289:
---
Attachment: LUCENE--2289.patch
Patch w/ the proposed changes.
> Calls to SegmentInfos.message shoul
[
https://issues.apache.org/jira/browse/LUCENE-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir reassigned LUCENE-2288:
---
Assignee: Robert Muir
> Create EMPTY_ARGS constsant in SnowballProgram instead of allocating
[
https://issues.apache.org/jira/browse/LUCENE-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839315#action_12839315
]
Robert Muir commented on LUCENE-2288:
-
thanks Shai, the patch looks good to me, though
[
https://issues.apache.org/jira/browse/LUCENE-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839362#action_12839362
]
Shai Erera commented on LUCENE-2285:
Thanks Uwe for committing this. I think that furt
[
https://issues.apache.org/jira/browse/LUCENE-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839364#action_12839364
]
Shai Erera commented on LUCENE-2288:
Thanks Robert. I never checked if those methods a
I uploaded the file to
http://wiki.apache.org/lucene-java/HowToContribute(bottom of the
page). But I don't see any good spot to stuff it in the
README. There is no pointer to the HowToContribute page at all, nor to the
code formatting styles ... what do you think - create such section at the
bottom
Hi
Do you think it's worth to make some of the isDeleted method impls final,
like in ReadOnlySegmentReader and (maybe) DirectoryReader? I'm thinking the
classes that are perceived as final could benefit from that, since their
impl could be inlined. Maybe just make these classes final entirely?
Sh
43 matches
Mail list logo
