On Wed, 11 Sep 2024 18:06:11 GMT, Jonathan Gibbons wrote:
> Please review this doc-only fix to indicate that the `StandardDoclet` class
> is the one used by default by the _javadoc_ tool.
Looks good to me.
-
Marked as reviewed by hannesw (Reviewer).
PR Review: https://git.openjdk
Please review a simple JavaScript change to avoid the `ResizeObserver` callback
to interrupt smooth scrolling on Chrome browsers when an page with an anchor is
loaded. Unfortunately, Chrome is susceptible to interrupt smooth scrolling if a
script accesses the DOM while scrolling. Since the `Resi
Please review a CSS fix for javadoc-generated API documentation to avoid a CSS
being applied to elements it is not meant for. The rule in question was in
JDK-8308659 when we added scrollable container `div` elements. Since elements
with non-visible `overflow` prevent [margin
collapse](https://w
On Wed, 4 Sep 2024 15:56:55 GMT, Jonathan Gibbons wrote:
>> Please review an update to "clean up" the direct use of HtmlTree
>> constructors.
>>
>> Hitherto, many/most instances of `HtmlTree` were created by static factory
>> methods. This update extends that convention.
>> In most cases, thi
On Tue, 3 Sep 2024 20:31:34 GMT, Jonathan Gibbons wrote:
>> Please review an update to "clean up" the direct use of HtmlTree
>> constructors.
>>
>> Hitherto, many/most instances of `HtmlTree` were created by static factory
>> methods. This update extends that convention.
>> In most cases, thi
On Thu, 29 Aug 2024 20:10:13 GMT, Jonathan Gibbons wrote:
> Please review an update to "clean up" the direct use of HtmlTree constructors.
>
> Hitherto, many/most instances of `HtmlTree` were created by static factory
> methods. This update extends that convention.
> In most cases, this is by
On Thu, 29 Aug 2024 20:10:13 GMT, Jonathan Gibbons wrote:
> Please review an update to "clean up" the direct use of HtmlTree constructors.
>
> Hitherto, many/most instances of `HtmlTree` were created by static factory
> methods. This update extends that convention.
> In most cases, this is by
On Mon, 19 Aug 2024 16:35:29 GMT, Nizar Benalla wrote:
>> Can I please get a review for this simple change? It's an attempt to improve
>> the code example in doclet package.
>> Here are the generated docs with the [new code
>> example.](https://cr.openjdk.org/~nbenalla/GeneratedDocs/newDocletEx
On Mon, 19 Aug 2024 14:39:36 GMT, Hannes Wallnöfer wrote:
> Please review a patch to suppress the `PREVIEW` and `RESTRICTED` superscript
> labels for JavaDoc tags that generate plain links such as `{@linkplain ...}`.
> The rationale is that the purpose of plain links is usually to
On Mon, 12 Aug 2024 12:59:13 GMT, Hannes Wallnöfer wrote:
> Please review a simple change to switch to a [better suited
> API](https://developer.mozilla.org/en-US/docs/Web/API/ResizeObserver) to
> track changes in document size in `javadoc`-generated pages. In addition to
> ch
Please review a patch to suppress the `PREVIEW` and `RESTRICTED` superscript
labels for JavaDoc tags that generate plain links such as `{@linkplain ...}`.
The rationale is that the purpose of plain links is usually to have the label
not "stick out" of the local context, which makes the superscri
On Tue, 2 Jul 2024 14:44:39 GMT, Hannes Wallnöfer wrote:
>> @hns
>> [role="cell"](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/cell_role)
>> should be used within row element. But the code here has row styles as
>> `col-first even
On Mon, 24 Jun 2024 06:50:24 GMT, psoujany wrote:
>> The scrollable element `` with non-interactive content is not tabbable.
>> Grid columns in the javadoc stylesheet has overflow: auto, which is failing
>> Accessibility checks.
>> https://bugs.openjdk.org/browse/JDK-8325690
>
> psoujany has up
Please review a simple change to switch to a [better suited
API](https://developer.mozilla.org/en-US/docs/Web/API/ResizeObserver) to track
changes in document size in `javadoc`-generated pages. In addition to changes
in the size of the browser viewport, the new code handles changes coming from
On Wed, 7 Aug 2024 15:18:59 GMT, Hannes Wallnöfer wrote:
> Please review a JavaDoc change to make it possible to link to type parameter
> documentation from automatically generated signatures as well as user-defined
> `{@link ...}` and `@see ...` tags. The solution consists in wrap
On Thu, 8 Aug 2024 06:28:31 GMT, Hannes Wallnöfer wrote:
> > One question/suggestion, perhaps for followup work. I get that you do not
> > want the visual clutter of linking to locally defined type parameters, but
> > would it help to give a short tooltip (i.e. `title`
On Wed, 7 Aug 2024 21:04:08 GMT, Jonathan Gibbons wrote:
>> Hannes Wallnöfer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> More post-merge cleanup
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/
On Wed, 7 Aug 2024 20:12:18 GMT, Jonathan Gibbons wrote:
> Just from reading that alone, (and not reading code or sample output yet)
> that seems mildly questionable, in that we otherwise generally encourage the
> provision of `@param` tags for all parameters, whether they are type-level or
>
On Wed, 7 Aug 2024 21:32:44 GMT, Jonathan Gibbons wrote:
> One question/suggestion, perhaps for followup work. I get that you do not
> want the visual clutter of linking to locally defined type parameters, but
> would it help to give a short tooltip (i.e. `title` attribute) in this
> situation
gnature shown in the main
> heading of the page.
>
> - When type parameter documentation is displayed as link target, it is
> rendered with a visual highlight, which is similar to the one used for
> `{@index ...}` tags but fades out after a few seconds. The purpose is to mak
gnature shown in the main
> heading of the page.
>
> - When type parameter documentation is displayed as link target, it is
> rendered with a visual highlight, which is similar to the one used for
> `{@index ...}` tags but fades out after a few seconds. The purpose is to make
Please review a JavaDoc change to make it possible to link to type parameter
documentation from automatically generated signatures as well as user-defined
`{@link ...}` and `@see ...` tags. The solution consists in wrapping type
parameter documentation into ``
elements for generic classes and `
On Fri, 2 Aug 2024 17:26:48 GMT, Jonathan Gibbons wrote:
>> Please review a change to reorganize the internal low-level support for HTML
>> in the jdk.javadoc module.
>>
>> Hitherto, there are two separate sets of classes for low-level support for
>> HTML in the `jdk.javadoc` module: one, in d
On Wed, 31 Jul 2024 18:00:11 GMT, Jonathan Gibbons wrote:
>> Please review a change to reorganize the internal low-level support for HTML
>> in the jdk.javadoc module.
>>
>> Hitherto, there are two separate sets of classes for low-level support for
>> HTML in the `jdk.javadoc` module: one, in
On Wed, 24 Jul 2024 22:09:46 GMT, Jonathan Gibbons wrote:
>> Please review a change to reorganize the internal low-level support for HTML
>> in the jdk.javadoc module.
>>
>> Hitherto, there are two separate sets of classes for low-level support for
>> HTML in the `jdk.javadoc` module: one, in
On Wed, 24 Jul 2024 22:09:46 GMT, Jonathan Gibbons wrote:
>> Please review a change to reorganize the internal low-level support for HTML
>> in the jdk.javadoc module.
>>
>> Hitherto, there are two separate sets of classes for low-level support for
>> HTML in the `jdk.javadoc` module: one, in
On Wed, 24 Jul 2024 22:09:46 GMT, Jonathan Gibbons wrote:
>> Please review a change to reorganize the internal low-level support for HTML
>> in the jdk.javadoc module.
>>
>> Hitherto, there are two separate sets of classes for low-level support for
>> HTML in the `jdk.javadoc` module: one, in
On Mon, 22 Jul 2024 15:08:02 GMT, Archie Cobbs wrote:
>> This needs to be coordinated with @hns who is working on similar issues. He
>> is currently OOTO, but will be back soon.
>
>> This needs to be coordinated with @hns who is working on similar issues. He
>> is currently OOTO, but will be ba
On Wed, 26 Jun 2024 23:00:27 GMT, Jonathan Gibbons wrote:
> Please review a change to reorganize the internal low-level support for HTML
> in the jdk.javadoc module.
>
> Hitherto, there are two separate sets of classes for low-level support for
> HTML in the `jdk.javadoc` module: one, in docli
On Mon, 24 Jun 2024 08:04:08 GMT, psoujany wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Table.java
>> line 341:
>>
>>> 339: cell.addStyle(tabClass);
>>> 340: if (!matchFound) {
>>> 341: cell.put(HtmlAttr.RO
On Mon, 1 Jul 2024 15:19:22 GMT, Pavel Rappo wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/taglets/SnippetTaglet.java
>> line 498:
>>
>>> 496: return null;
>>> 497: }
>>> 498: return (lastPeriod == fileName.length() - 1) ? null :
On Fri, 14 Jun 2024 16:35:54 GMT, Hannes Wallnöfer wrote:
> Please review a change to slightly adjust the proportion between the side bar
> and the main content area in API documentation pages, making the side bar a
> bit slimmer and leaving more space for the main content area.
On Fri, 14 Jun 2024 12:50:44 GMT, psoujany wrote:
>> The scrollable element `` with non-interactive content is not tabbable.
>> Grid columns in the javadoc stylesheet has overflow: auto, which is failing
>> Accessibility checks.
>> https://bugs.openjdk.org/browse/JDK-8325690
>
> psoujany has up
Please review a change to slightly adjust the proportion between the side bar
and the main content area in API documentation pages, making the side bar a bit
slimmer and leaving more space for the main content area. The ratio between
side bar and main content used to be 1 : 2.6, it is now 1 : 3.
On Wed, 12 Jun 2024 09:02:20 GMT, Hannes Wallnöfer wrote:
>> I suggest one of
>>
>> 1. Add a `boolean global;` member to the enum, and provide a second
>> constructor that allows that boolean member to be set true. For example,
>>
>> WIDTH,
>> ST
On Tue, 11 Jun 2024 21:58:46 GMT, Jonathan Gibbons wrote:
>>> If we are ordering the entries, we can use comparable to check that an attr
>>> is greater than the start of the global attr, something like
>>>
>>> ```java
>>> private static boolean isGlobalAttr(Attr value) {
>>> return value.c
On Wed, 22 May 2024 08:39:12 GMT, Hannes Wallnöfer wrote:
> Please review a simple patch to exclude preview visitor classes meant to
> support future preview features from the Preview API page.
>
> The test adds an sample element annotated
On Wed, 5 Jun 2024 11:04:06 GMT, Pavel Rappo wrote:
>> Hannes Wallnöfer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review feedback
>
> test/langtools/jdk/javadoc/doclet/testPreview/TestPr
On Thu, 23 May 2024 10:39:52 GMT, Hannes Wallnöfer wrote:
> Please review a patch to fix a NPE thrown when a `@since` tag inherited by a
> nested class contains a nested inline tag. The solution is to make
> `CommentHelper.getDocTreePath(DocTree)` able to handle block tags inheri
On Thu, 23 May 2024 10:39:52 GMT, Hannes Wallnöfer wrote:
> Please review a patch to fix a NPE thrown when a `@since` tag inherited by a
> nested class contains a nested inline tag. The solution is to make
> `CommentHelper.getDocTreePath(DocTree)` able to handle block tags inheri
On Mon, 3 Jun 2024 12:33:31 GMT, psoujany wrote:
>> The scrollable element `` with non-interactive content is not tabbable.
>> Grid columns in the javadoc stylesheet has overflow: auto, which is failing
>> Accessibility checks.
>> https://bugs.openjdk.org/browse/JDK-8325690
>
> psoujany has upd
On Fri, 31 May 2024 20:58:31 GMT, Jonathan Gibbons wrote:
> > To clarify, I'm not too concerned with how we call an action whereby a
> > nested class gets its `@since` tag from the enclosing class; but yes,
> > "inheritance" might not be ideal. What I'm concerned with is the fact that
> > the
On Mon, 27 May 2024 09:50:38 GMT, psoujany wrote:
>> The scrollable element `` with non-interactive content is not tabbable.
>> Grid columns in the javadoc stylesheet has overflow: auto, which is failing
>> Accessibility checks.
>> https://bugs.openjdk.org/browse/JDK-8325690
>
> psoujany has up
On Mon, 27 May 2024 09:50:38 GMT, psoujany wrote:
>> The scrollable element `` with non-interactive content is not tabbable.
>> Grid columns in the javadoc stylesheet has overflow: auto, which is failing
>> Accessibility checks.
>> https://bugs.openjdk.org/browse/JDK-8325690
>
> psoujany has up
On Tue, 28 May 2024 12:28:53 GMT, Hannes Wallnöfer wrote:
> Please review a simple fix to make DocLint report an error when linking to
> non-declared types in `{@link}` or `@see` tags. This has been implemented
> when the Standard Doclet is running without DocLint in
> [JDK-82
subclasses.
>
> I compared the JDI API documentation with and without this patch and there
> were no changes except for the breadcrumb links for nested classes.
Hannes Wallnöfer has updated the pull request incrementally with one additional
commit since the last revision:
Addre
On Wed, 29 May 2024 19:39:14 GMT, Hannes Wallnöfer wrote:
> Please review a patch to change the breadcrumb sub-navigation in API docs to
> display nested classes as separate links.
>
> The change itself is simple, I replaced the `getBreadCrumbLink` method in
> `HtmlDocl
On Fri, 31 May 2024 10:01:17 GMT, Hannes Wallnöfer wrote:
>> Please review a simple patch to exclude preview visitor classes meant to
>> support future preview features from the Preview API page.
>>
>> The test adds an sample elemen
EP` annotation) to make sure it is not listed in the Preview API page. The
> test itself does not have to be modified, as it would fail without the change
> in `PreviewAPIListBuilder.java`.
Hannes Wallnöfer has updated the pull request incrementally with one additional
commit since the l
Please review a patch to change the breadcrumb sub-navigation in API docs to
display nested classes as separate links.
The change itself is simple, I replaced the `getBreadCrumbLink` method in
`HtmlDocletWriter` which returned a link for a single element with a new
`addBreadCrumbLinks` method
Please review a simple fix to make DocLint report an error when linking to
non-declared types in `{@link}` or `@see` tags. This has been implemented when
the Standard Doclet is running without DocLint in
[JDK-8284030](https://bugs.openjdk.org/browse/JDK-8284030), but needs to be
implemented in
On Mon, 13 May 2024 23:08:51 GMT, Jonathan Gibbons wrote:
> Please review a relatively simple update to the generated Help page, as part
> of the ongoing campaign to improve the documentation around the overall use
> of `@since` tags.
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/
On Tue, 30 Apr 2024 10:52:23 GMT, psoujany wrote:
>> The scrollable element `` with non-interactive content is not tabbable.
>> Grid columns in the javadoc stylesheet has overflow: auto, which is failing
>> Accessibility checks.
>> https://bugs.openjdk.org/browse/JDK-8325690
>
> psoujany has up
On Thu, 23 May 2024 13:59:19 GMT, Hannes Wallnöfer wrote:
>> Please review a simple patch to exclude preview visitor classes meant to
>> support future preview features from the Preview API page.
>>
>> The test adds an sample elemen
EP` annotation) to make sure it is not listed in the Preview API page. The
> test itself does not have to be modified, as it would fail without the change
> in `PreviewAPIListBuilder.java`.
Hannes Wallnöfer has updated the pull request with a new target base due to a
merge or a reba
EP` annotation) to make sure it is not listed in the Preview API page. The
> test itself does not have to be modified, as it would fail without the change
> in `PreviewAPIListBuilder.java`.
Hannes Wallnöfer has updated the pull request incrementally with one additional
commit since th
Please review a patch to fix a NPE thrown when a `@since` tag inherited by a
nested class contains a nested inline tag. The solution is to make
`CommentHelper.getDocTreePath(DocTree)` able to handle block tags inherited by
nested classes.
-
Commit messages:
- JDK-8332039: Cannot i
On Wed, 22 May 2024 08:39:12 GMT, Hannes Wallnöfer wrote:
> Please review a simple patch to exclude preview visitor classes meant to
> support future preview features from the Preview API page.
>
> The test adds an sample element annotated
On Wed, 22 May 2024 11:26:02 GMT, Chen Liang wrote:
>> Please review a simple patch to exclude preview visitor classes meant to
>> support future preview features from the Preview API page.
>>
>> The test adds an sample element annotated with the new
>> `PreviewFeature.Feature.LANGUAGE_MODEL`
Please review a simple patch to exclude preview visitor classes meant to
support future preview features from the Preview API page.
The test adds an sample element annotated with the new
`PreviewFeature.Feature.LANGUAGE_MODEL` constant (which does not have a `@JEP`
annotation) to make sure it
On Thu, 16 May 2024 10:56:26 GMT, Hannes Wallnöfer wrote:
> Please review a change to improve the layout of definition lists used to
> display block tags:
>
> - Add indentation to the `` elements used for block tag details
> - Set the margin of lists within block tag details
On Fri, 29 Mar 2024 09:39:18 GMT, Hannes Wallnöfer wrote:
> Please review an enhancement to detect [JavaScript
> modules](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules)
> when added to `javadoc` with the `--add-script` option, which require a
> dif
On Tue, 9 Apr 2024 13:06:28 GMT, Hannes Wallnöfer wrote:
> Please review an update to the `jdk-default.css` stylesheet used for
> specifications and tool guides. The original purpose was to make use of the
> Dejavu web fonts provided by the API docs and to update the navigation bar to
On Thu, 16 May 2024 18:17:31 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module `j
On Wed, 15 May 2024 21:04:36 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module `j
On Thu, 16 May 2024 11:21:14 GMT, Pavel Rappo wrote:
>> Please review a change to improve the layout of definition lists used to
>> display block tags:
>>
>> - Add indentation to the `` elements used for block tag details
>> - Set the margin of lists within block tag details so they do not ap
Please review a change to improve the layout of definition lists used to
display block tags:
- Add indentation to the `` elements used for block tag details
- Set the margin of lists within block tag details so they do not appear as
nested lists, except for lists with CSS classes `tag-list` or
> Please review an enhancement to detect [JavaScript
> modules](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules)
> when added to `javadoc` with the `--add-script` option, which require a
> different `type` attribute in the HTML `
On Tue, 14 May 2024 22:25:13 GMT, Jonathan Gibbons wrote:
> Is there a reason to want the main font size to be different between the API
> pages and spec pages?
I did not want to change the font size in this patch. I started by changing the
font size to 14 px, but went back to the initial 10 p
On Thu, 18 Apr 2024 12:11:56 GMT, Hannes Wallnöfer wrote:
> Please review a change to move a long-running shellsupport test from
> langtools tier1 to tier2, while modifying the tier1 test to only retrieve doc
> comments for members of `java.lang.StringBuilder`, which is where [the
&
On Fri, 10 May 2024 16:15:36 GMT, Hannes Wallnöfer wrote:
> Please review a patch to update to the javadoc man page to add the
> `--no-fonts` option and fix a typo.
This pull request has now been integrated.
Changeset: 1484153c
Author:Hannes Wallnöfer
URL:
https://git.openj
Please review a patch to update to the javadoc man page to add the `--no-fonts`
option and fix a typo.
-
Commit messages:
- JDK-8332080: Update troff man page for javadoc
Changes: https://git.openjdk.org/jdk/pull/19181/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19181&
On Fri, 10 May 2024 13:42:43 GMT, Hannes Wallnöfer wrote:
>> Please review a change to move a long-running shellsupport test from
>> langtools tier1 to tier2, while modifying the tier1 test to only retrieve
>> doc comments for members of `java.lang.StringBuilder`, w
langtools tier2, which is not a perfect match for the test, but close
> enough and helps to keep langtools `TEST.groups` file simple.
Hannes Wallnöfer has updated the pull request incrementally with one additional
commit since the last revision:
Change quick test to run on a random subset o
On Fri, 29 Mar 2024 09:39:18 GMT, Hannes Wallnöfer wrote:
> Please review an enhancement to detect [JavaScript
> modules](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules)
> when added to `javadoc` with the `--add-script` option, which require a
> dif
Please review an enhancement to detect [JavaScript
modules](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules)
when added to `javadoc` with the `--add-script` option, which require a
different `type` attribute in the HTML `
On Fri, 26 Apr 2024 15:14:04 GMT, Hannes Wallnöfer wrote:
> Please review a change to print a terminal message if the documentation
> generated by `HtmlDoclet` contains any diagnostic marker elements for invalid
> input. The message is printed after the documentation has been gene
On Fri, 26 Apr 2024 18:05:14 GMT, Jonathan Gibbons wrote:
> The feature is good, but I'm surprised to see it being tested in
> DocLintTest.java.
I admit I took a shortcut there, using `DocLintTest` for something it wasn't
meant to do. The test had to be updated anyway, and it had both the inva
Please review a change to print a terminal message if the documentation
generated by `HtmlDoclet` contains any diagnostic marker elements for invalid
input. The message is printed after the documentation has been generated and
before the error/warning count with the purpose to let the user know
langtools tier2, which is not a perfect match for the test, but close
> enough and helps to keep langtools `TEST.groups` file simple.
Hannes Wallnöfer has updated the pull request incrementally with one additional
commit since the last revision:
Move FullJavaDocHelperTest.java into its
On Fri, 12 Apr 2024 11:11:47 GMT, Hannes Wallnöfer wrote:
> Please review a change to update jQuery from version 3.6.1 to 3.7.1 in
> JavaDoc. The jQuery compressed and uncompressed files were obtained from
> https://jquery.com/download/. Changes were tested against javadoc tests as
Please review a change to move a long-running shellsupport test from langtools
tier1 to tier2, while modifying the tier1 test to only retrieve doc comments
for members of `java.lang.StringBuilder`, which is where [the original
bug](https://bugs.openjdk.org/browse/JDK-8189778) occurred. This red
On Fri, 12 Apr 2024 11:11:47 GMT, Hannes Wallnöfer wrote:
> Please review a change to update jQuery from version 3.6.1 to 3.7.1 in
> JavaDoc. The jQuery compressed and uncompressed files were obtained from
> https://jquery.com/download/. Changes were tested against javadoc tests as
On Fri, 12 Apr 2024 11:11:47 GMT, Hannes Wallnöfer wrote:
> Please review a change to update jQuery from version 3.6.1 to 3.7.1 in
> JavaDoc. The jQuery compressed and uncompressed files were obtained from
> https://jquery.com/download/. Changes were tested against javadoc tests as
Please review a change to update jQuery from version 3.6.1 to 3.7.1 in JavaDoc.
The jQuery compressed and uncompressed files were obtained from
https://jquery.com/download/. Changes were tested against javadoc tests as well
as manually using a selection of browsers (Firefox, Chrome, Safari).
[
Please review an update to the `jdk-default.css` stylesheet used for
specifications and tool guides. The original purpose was to make use of the
Dejavu web fonts provided by the API docs and to update the navigation bar to
match the one in the API docs. However, the updates include some other fi
On Wed, 20 Mar 2024 19:04:04 GMT, Jonathan Gibbons wrote:
> Please review changes to the support for `since`, `author`, and `version`
> tags, such that if there are no such tags on a nested class, the doclet will
> look for any such tags in enclosing classes.
Looks good. I'll leave it to you a
On Tue, 30 Jan 2024 16:13:42 GMT, Hannes Wallnöfer wrote:
> This change adds the DejaVu web fonts that were previously maintained
> externally to the open repository so they are available both in JDK API
> documentation and any API documentation generated with the `javadoc` tool.
&g
e copied
> to the output tree and used correctly in browsers.
>
> Once #17411 is integrated, `dejavu.css` should also be added to the list of
> files checked by the new "pass-through" test.
Hannes Wallnöfer has updated the pull request incrementally with two additional
On Mon, 11 Mar 2024 13:37:54 GMT, Hannes Wallnöfer wrote:
> Please review a change to improve the user experience and implementation for
> the checkbox-based interface to selectively display content on API summary
> pages:
>
> - Add a checkbox to toggle (select/unselect) al
waysShowDefaultTab(boolean)` setter as it is
> redundant and can be replaced by `!renderTabs`.
> - Consolidate the code to generate checkboxes into a new protected
> `SummaryListWriter.getCheckbox` method.
Hannes Wallnöfer has updated the pull request incrementally with one additional
com
On Mon, 11 Mar 2024 18:09:41 GMT, Pavel Rappo wrote:
> if you check "all" and then uncheck something else, then "all" will remain
> selected. That is a confusing state.
I agree, but I think the behavior of the checkbox is as it should be, and it's
the label that is slightly misleading. The int
On Tue, 12 Mar 2024 20:09:37 GMT, Jonathan Gibbons wrote:
> Please review a conceptually simple change, to move a large anonymous inner
> class to be a named inner class.
>
> While most of the code is simply moved, two simple changes were necessary.
> In `visitEscape` and `visitText` the vari
Please review a change to improve the user experience and implementation for
the checkbox-based interface to selectively display content on API summary
pages:
- Add a checkbox to toggle (select/unselect) all checkboxes in the page.
- Remove the `Table.setAlwaysShowDefaultTab(boolean)` setter a
On Thu, 7 Mar 2024 14:29:39 GMT, Hannes Wallnöfer wrote:
> Please review a simple fix to make sure inline tags are always closed in
> summary tables, even when the tags are closed after the first sentence in the
> original doc comment.
>
> I decided to colocate the functio
#x27;t comically
> long. Suggestions are welcome of course.
Hannes Wallnöfer has updated the pull request incrementally with one additional
commit since the last revision:
Review feedback
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18154/files
- new: https://git.o
On Fri, 8 Mar 2024 10:16:51 GMT, Guoxiong Li wrote:
>> Please review a simple fix to make sure inline tags are always closed in
>> summary tables, even when the tags are closed after the first sentence in
>> the original doc comment.
>>
>> I decided to colocate the functionality to track open
Please review a simple fix to make sure inline tags are always closed in
summary tables, even when the tags are closed after the first sentence in the
original doc comment.
I decided to colocate the functionality to track open inline tags with the
existing `ignoreNonInlineTag` method that filt
On Wed, 6 Mar 2024 09:25:51 GMT, psoujany wrote:
>> The current stylesheet has the following rule at line 688:
>>
>>
>> .summary-table > div, .details-table > div {
>> text-align:left;
>> padding: 8px 3px 3px 7px;
>> overflow: auto hidden;
>> scrollbar-width: thin;
>> }
>>
>>
On Wed, 28 Feb 2024 17:12:04 GMT, Jonathan Gibbons wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java
>> line 1601:
>>
>>> 1599: : eKind != ElementKind.OTHER ? 1 // module,
>>> package, class, interface
>>> 1600:
1 - 100 of 364 matches
Mail list logo
