Review Request: JDK-8155955: packager needs to determine the root modules to create JRE image

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8155955/webrev.00/ This provides some utility methods for packager to determine the platform modules to help packager independent of any API change. This helper class will ultimately move to the packager implementation when FX upgrades its boot JD

Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8136930/webrev.00/ -modulepath, -addmods, -limitmods, -XaddExports, -XaddReads, -Xpatch are java launcher options in the current implementation. Custom launchers will have to use -D to set some system properties to configure module syste

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

> On Jun 4, 2016, at 12:05 AM, Alan Bateman wrote: > >> On 04/06/2016 07:47, Mandy Chung wrote: >> >> Webrev: >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8136930/webrev.00/ > There's an update to java.lang.System::getProperties that is miss

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

id you think about using -J for specifying either VM options or module > options (the user really don't care) for custom launchers like we use -J to > specify VM option to javac ? > > cheers, > Rémi > > ----- Mail original - >> De: "Mandy Chung" >

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

out the launchers created by jlink, > this one need a -J like option, not a JNI invoked piece of C. > > cheers, > Rémi > > ----- Mail original - >> De: "Mandy Chung" >> À: "Remi Forax" >> Cc: "jigsaw-dev" , "hotspot-r

Re: Review Request: JDK-8155955: packager needs to determine the root modules to create JRE image

> On Jun 4, 2016, at 10:01 AM, Alan Bateman wrote: > > On 04/06/2016 17:01, Kevin Rushforth wrote: > >> What the packager needs is a means at runtime to get the same set of JRE >> modules that an application in the unnamed module reads by default. If there >> is a better way to provide this,

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

> On Jun 5, 2016, at 5:50 PM, David Holmes wrote: > > > Taking an initial look at the VM changes ... > > I may be missing the full context but you seem to be checking only that some > prefix matches the expected property format, not that the entire value is > valid eg. if passed jdk.module.p

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

"-Djdk.module.path” 204 #define MODULE_UPGRADE_PATH_PROPERTY "-Djdk.module.upgrade.path" It may be good to consider having #define for all module property names and used consistently. Mandy > On Jun 3, 2016, at 11:47 PM, Mandy Chung wrote: > > Webrev: > http://cr.openjdk.ja

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

> On Jun 8, 2016, at 10:30 AM, Dmitry Dmitriev > wrote: > > Hello Mandy, > > As I understand all these options are tested by following tests: > jdk/test/tools/launcher/modules. I.e. no additional tests are required for > moving these options to the VM(except 2 new tests)? > Correct. The o

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

> On Jun 8, 2016, at 3:37 PM, Coleen Phillimore > wrote: > > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8136930/webrev.01/jdk/src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java.udiff.html > > + /** > + * Gets and remove the named system property > + */ > + private static

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

Adding jigsaw-dev where the code review is posted. See [1] for Coleen’s review comment. > On Jun 8, 2016, at 4:53 PM, David Holmes wrote: > > On 9/06/2016 8:37 AM, Coleen Phillimore wrote: >> >> >> I have to ask why Hotspot convention was violated with this new option >> syntax? These optio

Re: RFR 8158855: Fix remaining module dependences in java/lang

Hi Shura, test/java/lang/Class/GetModuleTest.java This can use java.base/jdk.internal.misc.Unsafe instead. Other @modules looks okay. Regarding the executeTestJava change, if you drop the VM options, this test will only exercise the default launcher setting. The hotspot nightlies depend on

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

Harold has incorporated feedback from David, Coleen, Lois and others and updated webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8136930/webrev.02/ The only change compared to webrev.01 is in hotspot arguments.{cpp,hpp} and a new ModuleOptionsTest.java. I see concerns from Coleen on

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

> On Jun 10, 2016, at 12:53 PM, Alan Bateman wrote: > > On 10/06/2016 17:38, Daniel D. Daugherty wrote: > >> >> I just re-read this... >> >> A space in the VM option? As in '-addmods'? That's a >> completely new idea for VM options processing and one that we took >> great pains to avoid when

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

> On Jun 10, 2016, at 7:18 AM, Coleen Phillimore > wrote: > >> Just to put more context on this patch. We are cleaning up the command line >> option handling and trying to get things more consistent. It will take a >> number of steps. One of the patches to proceed this one is an entry point

Re: RFR: 8158272 & 8158468 (tools/jlink/plugins/IncludeLocalesPluginTest.java bug fixes)

> On Jun 10, 2016, at 12:08 AM, Masayoshi Okutsu > wrote: > > (re-sending to include jigsaw-dev) > > Hi, > > Please review fixes for 8158272 and 8158468. The test had several problems. > > : > Webrev: > http://cr.openjdk.java.net/~okutsu/9/8158272.8158468/webrev.00 It’s good that you replac

Re: RFR JDK-8159206 - All jlink tests failing

> On Jun 10, 2016, at 12:20 PM, Jim Laskey (Oracle) > wrote: > > http://cr.openjdk.java.net/~jlaskey/8159206/webrev/index.html > https://bugs.openjdk.java.net/browse/JDK-8159206 >

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

> On Jun 12, 2016, at 11:33 AM, Alan Bateman wrote: > > > > On 12/06/2016 13:44, Wang Weijun wrote: >> I was about to send out a new webrev (CCC just approved) but noticed a >> behavior change. >> >> Although "-addprovider SUN" is useless it still worked when I posted >> webrev.03, but now

Re: RFR: 8158272 & 8158468 (tools/jlink/plugins/IncludeLocalesPluginTest.java bug fixes)

> On Jun 12, 2016, at 11:10 PM, Masayoshi Okutsu > wrote: > > On 6/11/2016 5:53 AM, Mandy Chung wrote: >>> On Jun 10, 2016, at 12:08 AM, Masayoshi Okutsu >>> wrote: >>> >>> (re-sending to include jigsaw-dev) >>> >>> Hi,

Re: RFR: 8159334: ModuleDescriptor retains overlapping sets for all and concealed packages

> On Jun 13, 2016, at 4:38 AM, Claes Redestad wrote: > > Hi, > > afraid I found some subtle bugs with some tests I forgot to check earlier: > > http://cr.openjdk.java.net/~redestad/8159334/webrev.02/ This looks fine. It’d be good if you verify with -testset core to get a good coverage. Man

Re: JDK-8153362: [jigsaw] Add javac -Xlint warning to list exposed types which are not accessible

I agree JSObject.getWindow(Applet) should have forRemoval=true, as I raised in awt-dev thread. The confusion there was when the API marked forRemoval=true in JDK 9 and when it should really be removed. Mandy > On Jun 13, 2016, at 12:53 PM, Philip Race wrote: > > Alan, > > See the comment h

Re: RFR 8158855: Fix remaining module dependences in java/lang

> On Jun 14, 2016, at 3:53 PM, Alexandre (Shura) Iline > wrote: > > Hi. > > After some offline conversations it was decided to leave the tests which > depend on absence of “-limitmods” in VM options for later. I have created a > separate bug ti track that: > https://bugs.openjdk.java.net/bro

Re: RFR JDK-8159206 - All jlink tests failing

I reviewed http://cr.openjdk.java.net/~jlaskey/8159206/webrev Looks much cleaner. Thanks for the update 342 StringSharingPlugin(String[] patterns) throws IOException { 343 this(ResourceFilter.includeFilter(Arrays.asList(patterns))); 344 } Looks like it’s not used except the n

Re: Review Request: JDK-8155955: packager needs to determine the root modules to create JRE image

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8155955/webrev.02 With further discussion with Chris Bensen and others, we agree that the packager would require the presence of the packaged module of jdk.packager to be present matching the runtime version of the image being created. The packag

Re: RFR JDK-8159206 - All jlink tests failing

> On Jun 15, 2016, at 9:34 AM, Jim Laskey (Oracle) > wrote: > > Webrev updated in place. Looks good. Mandy

Re: RFR 8158855: Fix remaining module dependences in java/lang

> On Jun 14, 2016, at 4:00 PM, Mandy Chung wrote: > > >> On Jun 14, 2016, at 3:53 PM, Alexandre (Shura) Iline >> wrote: >> >> Hi. >> >> After some offline conversations it was decided to leave the tests which >> depend on absence of “-l

Re: 8159248: ModuleFinder.of spec + 8158456: ModuleDescriptor.read does not verify dependence on java.base

> On Jun 16, 2016, at 8:33 AM, Alan Bateman wrote: > > I need a Reviewer for a patch is to address two conformance issues. > > One is that the ModuleFinder.of(Path...) javadoc doesn't make it clear that > an exception is thrown when a module descriptor cannot be created for an > automatic mod

Re: 8159248: ModuleFinder.of spec + 8158456: ModuleDescriptor.read does not verify dependence on java.base

> On Jun 16, 2016, at 9:44 AM, Alan Bateman wrote: > > On 16/06/2016 17:31, Mandy Chung wrote: > >> : >> ModuleFinder.of spec describes the possible cases where FindException may be >> thrown by a module finder’s find or findAll methods. >> >&

Re: RFR: 8154399, 8159096, export packages containing standard javadoc doclet

> On Jun 16, 2016, at 7:28 PM, Jonathan Gibbons > wrote: > > Please review this simple fix for two related aspects of the same problem: > > Export the "standard doclet" used by javadoc, such that it is possible to > derive alternative doclets, either by delegation or subtyping. > > In JDK 9,

Re: [9] RFR: 8159781: jlink --include-locales fails with java.util.regex.PatternSyntaxException

> On Jun 17, 2016, at 3:29 PM, Naoto Sato wrote: > > Decided to fix this separately from the other include locales issues. Here is > the bug and the proposed fix: > > https://bugs.openjdk.java.net/browse/JDK-8159781 > http://cr.openjdk.java.net/~naoto/8159781/webrev.00/ The change looks okay.

Re: Review Request: JDK-8155955: packager needs to determine the root modules to create JRE image

> On Jun 18, 2016, at 7:45 AM, Alan Bateman wrote: > > On 15/06/2016 19:49, Mandy Chung wrote: > >> With further discussion with Chris Bensen and others, we agree that the >> packager would require the presence of the packaged module of jdk.packager >> to b

Re: [9] RFR: 8159781: jlink --include-locales fails with java.util.regex.PatternSyntaxException

> I will modify the "regex:" prepending as you suggested. >> >> Naoto >> >> On 6/17/16 3:50 PM, Mandy Chung wrote: >>> >>>> On Jun 17, 2016, at 3:29 PM, Naoto Sato wrote: >>>> >>>> Decided to fix thi

Re: [9] RFR: 8159781: jlink --include-locales fails with java.util.regex.PatternSyntaxException

> On Jun 21, 2016, at 9:53 PM, Naoto Sato wrote: > > Modified line 243-246 to avoid generating a new List instance with > Collectors.toList(): > > http://cr.openjdk.java.net/~naoto/8159781/webrev.03/ +1 Mandy

Review request: JDK-8159596 Add java --dry-run

Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8159596/webrev.00/ `java --dry-run` will create the VM, load the main, locate the static void main method, and exit (with 0) instead of executing the method. As all module options are processed and the boot layer is created, this would b

Re: RFR 8153238: Improve test/tools/jlink/JLinkTest.java not to hard code the number of plugins

> On Jun 24, 2016, at 9:54 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8153238/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8153238 86 if (builtInPlugins.size() < numPlugins) { What about just count the plugins defi

Re: RFR 8160346: JLinkTest.java should compute exact number of plugins from jdk.jlink module [ was Re: RFR 8153238: Improve test/tools/jlink/JLinkTest.java not to hard code the number of plugins]

> On Jun 27, 2016, at 4:19 AM, Sundararajan Athijegannathan > wrote: > > Sorry I had that test change already. I've filed another bug to track > your suggestions. > > Please review http://cr.openjdk.java.net/~sundar/8160346/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8160346 +1

Re: Review request: JDK-8159596 Add java --dry-run

016 at 10:48 AM, Raymond Gallardo > wrote: > Hi Mandy, > > Does this enhancement need to be doc'd? If so, could you add a subtask > (component = docs)? > > Thanks, > --Raymond > > On 24/06/2016 9:49 AM, Mandy Chung wrote: > Webrev: >http://cr.openjd

Re: No jrt-fs.jar in JRE?

> On Jun 24, 2016, at 10:07 PM, Jayaprakash Arthanareeswaran > wrote: > > My experiment to use the jrt-fs.jar from the JDK to load the system classes > in JRE failed. May be I am not > doing something right. Is that even supposed to work if I done the right > way? You said JRE. If you mean th

Re: RFR: 8158670: Fix @modules in java/lang/SecurityManager/CheckSecurityProvider.java

I’m including security-dev which would be a better list to review this test fix. Valerie, Does this test have to be order-sensitive? I think this test would be cleaner to make it order-insensitive and simply test the security provider initialization. See my comments below. > On Jun 27, 201

Re: RFR: JDK-8160459 - jlink minor code clean up

> On Jun 28, 2016, at 8:09 AM, Jim Laskey (Oracle) > wrote: > > http://cr.openjdk.java.net/~jlaskey/8160459/webrev/index.html > > https://bugs.openjdk.java.net/browse/JDK-8160459 >

Re: Review request: JDK-8159596 Add java --dry-run

a real run > only? I think if the dry run also throws an exception, you should set the > exit code to 1. If I read the diff wrong, my apologies :-) > > Cheers, > Paul > > On Mon, Jun 27, 2016 at 12:36 PM, Mandy Chung wrote: > -XshowSettings would probably be a go

Re: RFR: 8158670: Fix @modules in java/lang/SecurityManager/CheckSecurityProvider.java

t;> pass. >> >> This would help to avoid the additional test creation, but it will add >> another silently passing test, which is less clean. >> >> Mandy? >> >> Shura >> >>> If yes, then we can leave out the platform-specific providers

Re: RFR 8160641: PostProcessingPlugin and ExecutableImage should not be part of plugin API

> On Jun 30, 2016, at 4:08 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8160641/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8160641 Looks okay to me. The copyright start year is changed in ExecutableImage.java and PostProcessor.

Re: Review request: JDK-8159596 Add java --dry-run

owing: > > Hello from > > > In order to prevent user code from being executed, main class should not be > initialized. But is it possible to check for the presence of a method in a > class without initializing it? Maybe the check for the presence of main

Re: Review request: JDK-8159596 Add java --dry-run

> On Jun 30, 2016, at 9:44 PM, David Holmes wrote: > > I had assumed that initialization was desirable as part of checking that > everything was specified correctly. If not then --dry-run would seem to do > very little compared to just running -version, and so doesn't really seem to > carry i

Re: Review request: JDK-8159596 Add java --dry-run

> On Jun 30, 2016, at 10:15 PM, David Holmes wrote: > > On 1/07/2016 3:00 PM, Mandy Chung wrote: >> >>> On Jun 30, 2016, at 9:44 PM, David Holmes wrote: >>> >>> I had assumed that initialization was desirable as part of checking that >>> ev

Re: Review request: JDK-8159596 Add java --dry-run

> On Jul 1, 2016, at 12:48 AM, David Holmes wrote: > > Okay so back to my original statement - if all this does is ensure the main > class is found does it really carry its weight as a new argument? > Are you suggesting for java —-dry-run to run or not to load main class? Are you thinking

Re: Review request: JDK-8159596 Add java --dry-run

> On Jul 2, 2016, at 1:01 AM, David Holmes wrote: > > On 2/07/2016 1:17 AM, Mandy Chung wrote: >> >>> On Jul 1, 2016, at 12:48 AM, David Holmes wrote: >>> >>> Okay so back to my original statement - if all this does is ensure the main >>>

hg: jigsaw/jake: 8 new changesets

Changeset: a420707436c6 Author:erikj Date: 2016-06-08 15:13 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/a420707436c6 8136771: Implement the license-swap logic as a make target Reviewed-by: tbell + make/CreateHgtipFiles.gmk ! make/GensrcModuleInfo.gmk ! make/Main.gmk ! mak

hg: jigsaw/jake/corba: 4 new changesets

Changeset: 7514ad67e185 Author:msheppar Date: 2016-06-21 00:40 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/7514ad67e185 8146975: NullPointerException in IIOPInputStream.inputClassFields Reviewed-by: chegar, rriggs, coffeys ! src/java.corba/share/classes/com/sun/corb

hg: jigsaw/jake/langtools: 9 new changesets

Changeset: 4ca6a3272035 Author:jjg Date: 2016-06-20 13:21 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/4ca6a3272035 8159537: create build file to generate diags reports for all locales Reviewed-by: mcimadamore + make/diags-examples.xml ! test/tools/javac/diags/HT

hg: jigsaw/jake/hotspot: 4 new changesets

Changeset: 9789c3ca3a3d Author:csahu Date: 2016-05-24 16:02 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/9789c3ca3a3d 8150900: Implement diagnostic_pd Reviewed-by: twisti, gziemski, kevinw ! src/os/aix/vm/globals_aix.hpp ! src/os/bsd/vm/globals_bsd.hpp ! src/os/lin

hg: jigsaw/jake/jaxp: 2 new changesets

Changeset: 011b11d2aae2 Author:amurillo Date: 2016-06-30 22:10 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/011b11d2aae2 Added tag jdk-9+125 for changeset 493eb91ec32a ! .hgtags Changeset: bde9e53f9a92 Author:mchung Date: 2016-07-02 14:42 -0700 URL: ht

hg: jigsaw/jake/jaxws: 3 new changesets

Changeset: 5b0570e3db29 Author:dfuchs Date: 2016-06-24 16:00 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/5b0570e3db29 8150173: JAXBContext.newInstance causes PrivilegedActionException when createContext's declared in abstract class extended by discovered JAXB imple

hg: jigsaw/jake/jdk: 39 new changesets

Changeset: 59c4daf11af4 Author:bpb Date: 2016-06-20 14:08 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/59c4daf11af4 8136738: InputStream documentation for IOException in skip() is unclear or incorrect Summary: Clarify javadoc of skip(). Reviewed-by: rriggs, prappo ! s

hg: jigsaw/jake/nashorn: 7 new changesets

Changeset: 2e53f4d1445d Author:hannesw Date: 2016-06-22 16:30 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/2e53f4d1445d 8159977: typeof operator does not see lexical bindings declared in other scripts Reviewed-by: sundar ! src/jdk.scripting.nashorn/share/classes/j

Re: Review request: JDK-8159596 Add java --dry-run

> On Jul 2, 2016, at 2:02 PM, Peter Levart wrote: > > What about extending the behavior of -version option so that when it is > specified together with other startup options like -mp, -m, -cp, MainClass, > ... it would behave just like --dry-run has been designed to work? I don't see any issu

Re: RFR: 8158670: Fix @modules in java/lang/SecurityManager/CheckSecurityProvider.java

> On Jul 1, 2016, at 6:20 PM, Alexandre (Shura) Iline > wrote: > > Please review the new version of the fix. > http://cr.openjdk.java.net/~shurailine/8158670/webrev.01/ This looks much better. Small comment: you can use Layer::findModule and also Optional::ifPresent, like this: boot.findMod

Re: Review request: JDK-8159596 Add java --dry-run

> On Jul 3, 2016, at 9:30 AM, Peter Levart wrote: > > > ...OTOH the quasi-graphical tree display (the idea is stolen from "mvn > dependency:tree" command) has some additional useful info such as "uses of a > service that was not satisfied" and in my opinion better visualizes a global > view

Re: Questions on deprivileging a module

> On Jul 5, 2016, at 12:15 AM, Wang Weijun wrote: > >>> 1. How does updating /make/common/Modules.gmk affect an exploded build? >> The mappings are used for both exploded and images build so the >> configuration in this make file is for both. > > I see. BTW, which file contain the mappings? I

Re: Strange test failure when referencing a class in a deprivileged module

> On Jul 5, 2016, at 8:11 AM, Alan Bateman wrote: > > On 05/07/2016 09:22, Wang Weijun wrote: > >>> On Jul 5, 2016, at 11:53 AM, Wang Weijun wrote: >>> >>> The exception is at the end of this mail. The test passes if I change >>> X.go() to calling a method inside this class >> Update: any ca

Re: RFR: 8158670: Fix @modules in java/lang/SecurityManager/CheckSecurityProvider.java

> On Jul 5, 2016, at 12:42 PM, Alexandre (Shura) Iline > wrote: > > This made sense, than you, Mandy. > > Please review new version: > http://cr.openjdk.java.net/~shurailine/8158670/webrev.02/ You can use Layer::findModule instead of Configuration::findModule. You can also use List::equals.

Re: RFR: 8158670: Fix @modules in java/lang/SecurityManager/CheckSecurityProvider.java

> On Jul 5, 2016, at 1:53 PM, Alexandre (Shura) Iline > wrote: > > >> On Jul 5, 2016, at 1:36 PM, Mandy Chung wrote: >> >> >>> On Jul 5, 2016, at 12:42 PM, Alexandre (Shura) Iline >>> wrote: >>> >>> This made se

Re: RFR 8161055: Remove plugin ordering by isAfter, isBefore.

> On Jul 8, 2016, at 4:19 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8161055/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8161055 +1 It’s good to see the plugin API being cleaned up. Mandy

Re: RFR 8163116: jlink exclude VM plugin does not fully support cross platform image creation

> On Aug 4, 2016, at 6:36 PM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8163116/webrev.00/ for > https://bugs.openjdk.java.net/browse/JDK-8163116 Looks fine and it’s right to use the os.name from java.base module descriptor to determine the tar

Review request 8136930: Simplify use of module-system options by custom launchers

This patch renames the module-system options to GNU-style as specified in JEP 293 [1] (see below for the new proposed option names). This addresses the problems discussed in [2] that the launcher will pass the module-system options down to the VM in the form of =. This provides a consistent way t

Re: RFR 8159487: Add JAVA_VERSION, OS_NAME, OS_ARCH properties in release file

Hi Sundar, > On Aug 2, 2016, at 5:12 AM, Alan Bateman wrote: > > On 02/08/2016 04:39, Sundararajan Athijegannathan wrote: > >> Please review http://cr.openjdk.java.net/~sundar/8159487/webrev.00/ for >> https://bugs.openjdk.java.net/browse/JDK-8159487 >> >> OS_NAME, OS_ARCH, OS_VERSION properti

Re: ResourceBundleProvider(s) design

Hi Peter, Sorry for the delay in reply. Still catching up on mails from vacation. > On Aug 4, 2016, at 3:26 AM, Peter Levart wrote: > > > On 08/04/2016 11:21 AM, Peter Levart wrote: >> If the providing module declares the service type, then the consuming module >> will have an explicit depen

Re: Review request 8136930: Simplify use of module-system options by custom launchers

On Aug 8, 2016, at 3:57 AM, Sundararajan Athijegannathan wrote: > > Nashorn portion of the changes look fine - except for minor comment: > > $jdk9-dev/nashorn/buildtools/nasgen/build.properties > > needs to be fixed as well [uses -XaddExports] Fixed. diff --git a/buildtools/nasgen/project.pr

Re: Review request 8136930: Simplify use of module-system options by custom launchers

> On Aug 8, 2016, at 3:51 AM, Alan Bateman wrote: > > On 05/08/2016 21:11, Mandy Chung wrote: > >> This patch renames the module-system options to GNU-style as specified >> in JEP 293 [1] (see below for the new proposed option names). This >> addresses the prob

Re: Review request 8136930: Simplify use of module-system options by custom launchers

Kumar, Thanks for the review. > On Aug 8, 2016, at 2:46 PM, Kumar Srinivasan > wrote: > > > I looked at the launcher specified changes, some minor > nits... > > jdk/src/java.base/share/native/libjli/java.c > > +def_len = JLI_StrLen(option)+1+JLI_StrLen(arg)+1; > spaces after operators.

Re: Review request 8136930: Simplify use of module-system options by custom launchers

> On Aug 8, 2016, at 3:56 PM, Jonathan Gibbons > wrote: > > > > On 08/08/2016 03:02 PM, Mandy Chung wrote: >>> >In javap.properties then there is a typo in "instead whitespace" (missing >>> >"of"). Also probably best to say a &q

Re: "exports dynamic" in JDK 9-ea+130?

> On Aug 10, 2016, at 2:44 AM, Paul Bakker wrote: > > Hello, > > I was under the impression that the "exports dynamic" syntax already landed > in the JDK builds, but it seems to give a build error in 9-ea+130. Should > this be working or is this not part of the build yet? > No, it’s only in

Re: Review request 8136930: Simplify use of module-system options by custom launchers

wrote: > > Hi, Mandy. > > Could you help to identify what tests in the JTreg suite(s) require more work > to switch to the new options? > > Or the other way around: which tests have been fixed with this commit? > > Thank you. > > >> On Aug 5, 2016, at 1

Re: Review request 8136930: Simplify use of module-system options by custom launchers

ectly updated. We have verified the pit and hotspot tests. Note that the old options continue to work. Testing won’t find any tests needed to be converted to use new options, if that’s what you intend to find. >> >> On 08/11/2016 09:16 AM, Alexandre (Shura) Iline wrote: >>

hg: jigsaw/jake: 40 new changesets

Changeset: 03e2c69ce64a Author:valeriep Date: 2016-07-27 01:26 + URL: http://hg.openjdk.java.net/jigsaw/jake/rev/03e2c69ce64a 8159488: Deprivilege java.xml.crypto Summary: Moved java.xml.crypto module from boot modules to platform modules Reviewed-by: mullan ! make/common/Modul

hg: jigsaw/jake/corba: 3 new changesets

Changeset: f7e1d5337c2e Author:amurillo Date: 2016-08-04 17:32 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/f7e1d5337c2e Added tag jdk-9+130 for changeset 77f9692d5976 ! .hgtags Changeset: 1ab4b9399c4c Author:lana Date: 2016-08-11 15:47 + URL: htt

hg: jigsaw/jake/jaxp: 11 new changesets

Changeset: 794a2f7c2bb6 Author:snikandrova Date: 2016-07-27 18:23 +0300 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/794a2f7c2bb6 8021787: javax.xml.datatype.XMLGregorianCalendar.getMonth() return is documented wrong Reviewed-by: joehw, rriggs ! src/java.xml/share/classes/

hg: jigsaw/jake/jaxws: 4 new changesets

Changeset: 9df85348a932 Author:amurillo Date: 2016-08-04 17:32 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/9df85348a932 Added tag jdk-9+130 for changeset 39c6293131d9 ! .hgtags Changeset: 783e7e2c587f Author:rriggs Date: 2016-08-08 10:15 -0400 URL: h

hg: jigsaw/jake/jdk: 176 new changesets

Changeset: cfa705d1f4e2 Author:naoto Date: 2016-07-26 10:53 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/cfa705d1f4e2 8162343: non-ASCII characters in source code comments (.hpp) Reviewed-by: rriggs ! src/java.base/share/native/libjimage/imageDecompressor.hpp ! src/jav

hg: jigsaw/jake/nashorn: 9 new changesets

Changeset: 9d87093a1a97 Author:sdama Date: 2016-07-27 15:53 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/9d87093a1a97 8160801: add documentation for NativeString Reviewed-by: mhaupt ! src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/resources/F

Re: RFR: 8163126 Wrong @modules in some of jdk/* tests

> On Aug 16, 2016, at 10:17 AM, Alexandre (Shura) Iline > wrote: > > Hi. > > Please review fixes related to module dependencies in a few jdk tests: > http://cr.openjdk.java.net/~shurailine/8163126/webrev.00/index.html Looks okay. I will sponsor this patch for you. Mandy

hg: jigsaw/jake/jaxws: 5 new changesets

Changeset: b41e7cd5f414 Author:mchung Date: 2016-08-10 15:49 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/b41e7cd5f414 8136930: Simplify use of module-system options by custom launchers Reviewed-by: alanb, ksrini, henryjen, sundar ! src/jdk.xml.bind/share/classes/com

hg: jigsaw/jake/langtools: Merge

Changeset: 19130450ad62 Author:mchung Date: 2016-08-19 16:30 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/19130450ad62 Merge ! src/jdk.jdeps/share/classes/com/sun/tools/javap/JavapTask.java

hg: jigsaw/jake/jdk: 35 new changesets

Changeset: ef0ba6e50464 Author:bpb Date: 2016-08-09 07:43 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ef0ba6e50464 8163431: probeContentType/Basic.java fails after changes for JDK-8146215 Summary: Allow multiple legal MIME type interpretations for certain extensions. R

hg: jigsaw/jake: 5 new changesets

Changeset: 8b1d348ad6a2 Author:mchung Date: 2016-08-10 15:49 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/8b1d348ad6a2 8136930: Simplify use of module-system options by custom launchers Reviewed-by: alanb, ksrini, henryjen, sundar ! common/autoconf/boot-jdk.m4 ! common/aut

hg: jigsaw/jake/corba: 2 new changesets

Changeset: 8b243cd19bff Author:lana Date: 2016-08-18 21:01 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/8b243cd19bff Added tag jdk-9+132 for changeset 1ab4b9399c4c ! .hgtags Changeset: d4a7b03f7cd4 Author:mchung Date: 2016-08-19 16:30 -0700 URL: http:

hg: jigsaw/jake/hotspot: 6 new changesets

Changeset: 3cfddcb268e3 Author:hseigel Date: 2016-08-10 15:48 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/3cfddcb268e3 8136930: Simplify use of module-system options by custom launchers Reviewed-by: coleenp, lfoltan, mchung ! src/jdk.vm.ci/share/classes/jdk.vm.ci

hg: jigsaw/jake/jaxp: 8 new changesets

Changeset: 55f2b1691a7b Author:lana Date: 2016-08-04 13:58 +0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/55f2b1691a7b 8163145: Remove two null line in the end of message.properties Reviewed-by: joehw, rriggs Contributed-by: li.ji...@oracle.com ! src/java.xml/share/cla

hg: jigsaw/jake/nashorn: 6 new changesets

Changeset: 3487086f145a Author:sdama Date: 2016-08-10 09:21 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/3487086f145a 8134304: NPE in initialization of OptimisticTypesPersistence Reviewed-by: hannesw, jlaskey, mhaupt ! src/jdk.scripting.nashorn/share/classes/jdk/n

hg: jigsaw/jake/jdk: Fixup merge issue

Changeset: a0f2a493ec38 Author:mchung Date: 2016-08-19 21:58 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/a0f2a493ec38 Fixup merge issue ! test/com/sun/corba/transport/KeepAliveSockets.java ! test/javax/xml/bind/xjc/8145039/JaxbMarshallTest.java ! test/sun/rmi/rmic/cla

hg: jigsaw/jake/jdk: Minor test merge cleanup

Changeset: 801659c39b01 Author:mchung Date: 2016-08-20 12:06 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/801659c39b01 Minor test merge cleanup ! test/ProblemList.txt ! test/sun/security/krb5/auto/TEST.properties ! test/sun/security/util/Resources/NewNamesFormat.java

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

> On Aug 12, 2016, at 5:33 PM, Steve Drach wrote: > > I didn’t have it right ;-) It turns out a JarFile stream of versioned > entries was more interesting than I initially thought. Here’s another > webrev. It’s not clear to me if I should include the change to JarFile in > this changeset o

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

> On Aug 22, 2016, at 1:35 PM, Chris Hegarty wrote: > > >> On 22 Aug 2016, at 19:24, Steve Drach wrote: >>> >>> Er, I thought the plan was for the set of concealed packages to be the >>> same. It's okay for the ConcealedPackages in the base section to include >>> "empty" packages. >> >> I

Re: RFR: 8156499 Update jlink to support creating images with modules that are packaged as multi-release JARs

> On Aug 22, 2016, at 2:56 PM, Steve Drach wrote: > > Is a jar tool that takes a -d option lurking somewhere? The latest one I > have does not have that option. It’s in jdk-9+132 and has been in jdk9/dev for 1.5 weeks (see JDK-8136930). It was -p previously. $ jar -h Usage: jar [OPTION.

Re: RFR 8147491: module graph consistency checks after jlink plugins operate on module pool

> On Aug 25, 2016, at 7:18 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8147491/webrev.01/ for > https://bugs.openjdk.java.net/browse/JDK-8147491 I think ResourcePoolConfiguration::validate should simply use all modules in the resource pool a

Re: RFR 8147491: module graph consistency checks after jlink plugins operate on module pool

> On Aug 25, 2016, at 10:15 AM, Paul Sandoz wrote: > > >> On 25 Aug 2016, at 09:33, Mandy Chung wrote: >> >> >>> On Aug 25, 2016, at 7:18 AM, Sundararajan Athijegannathan >>> wrote: >>> >>> Please review http

Re: RFR 8147491: module graph consistency checks after jlink plugins operate on module pool

> On Aug 25, 2016, at 9:24 PM, Sundararajan Athijegannathan > wrote: > > Hi Mandy, Paul, > > Thanks for the reviews. Updated webrev as per suggestions: > > http://cr.openjdk.java.net/~sundar/8147491/webrev.02/ Looks good. Mandy

Re: RFR 8164800: Cross targeting Windows

> On Aug 26, 2016, at 7:54 AM, Sundararajan Athijegannathan > wrote: > > Hi, > > Fixed as suggested: http://cr.openjdk.java.net/~sundar/8164800/webrev.02/ Looks fine. Something to consider as a future cleanup - jlink should know the target platform information up front. It may be worth sto

Review Request: JDK-8160851: Remove old module-related options

This patch removes the old module options from java, javac, javadoc, etc. The new options are in jdk-9+132 [1]. I did a scan on the jdk9/dev forest to replace any remaining reference to the old options. I find some tests in jdk9/hs/hotspot using the old options that I will file a separate iss

  1   2   3   4   5   6   7   8   9   10   >