[jira] [Updated] (KAFKA-9942) --entity-default flag is not working for alternating / describing configs in AdminClient

2020-05-04 Thread Cheng Tan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cheng Tan updated KAFKA-9942: - Description: {quote}$ bin/kafka-configs.sh --bootstrap-server localhost:9092 --alter --add-config produc

[GitHub] [kafka] dajac opened a new pull request #8609: KAFKA-9946; StopReplicaRequest deletePartition changes may cause premature topic deletion handling in controller

2020-05-04 Thread GitBox
dajac opened a new pull request #8609: URL: https://github.com/apache/kafka/pull/8609 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes

[GitHub] [kafka] edoardocomar commented on a change in pull request #4204: KAFKA-5238: BrokerTopicMetrics can be recreated after topic is deleted

2020-05-04 Thread GitBox
edoardocomar commented on a change in pull request #4204: URL: https://github.com/apache/kafka/pull/4204#discussion_r419313971 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1035,11 +1035,13 @@ class ReplicaManager(val config: KafkaConfig, val

[GitHub] [kafka] d8tltanc opened a new pull request #8610: KAKFA-9942: --entity-default flag is not working for alternating / describing configs in AdminClient

2020-05-04 Thread GitBox
d8tltanc opened a new pull request #8610: URL: https://github.com/apache/kafka/pull/8610 *More detailed description of your change, The client-side passes an empty string "" to the server controller indicating that the quota changes apply to the default entity. However, the server logic

[GitHub] [kafka] showuon opened a new pull request #8611: MINOR: Format the notation content for better readability

2020-05-04 Thread GitBox
showuon opened a new pull request #8611: URL: https://github.com/apache/kafka/pull/8611 **before:** ![image](https://user-images.githubusercontent.com/43372967/80954688-745c4580-8e30-11ea-9330-fe7f6321adce.png) Here, the notation words are not in different format, makes it hard to

[jira] [Updated] (KAFKA-9934) Information and doc update needed for support of AclAuthorizer when protocol is PLAINTEXT

2020-05-04 Thread kaushik srinivas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kaushik srinivas updated KAFKA-9934: Issue Type: Bug (was: Improvement) > Information and doc update needed for support of AclA

[jira] [Updated] (KAFKA-9933) Need doc update on the AclAuthorizer when SASL_SSL is the protocol used.

2020-05-04 Thread kaushik srinivas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kaushik srinivas updated KAFKA-9933: Issue Type: Bug (was: Improvement) > Need doc update on the AclAuthorizer when SASL_SSL is

[jira] [Commented] (KAFKA-9934) Information and doc update needed for support of AclAuthorizer when protocol is PLAINTEXT

2020-05-04 Thread kaushik srinivas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098822#comment-17098822 ] kaushik srinivas commented on KAFKA-9934: - Hi [~ijuma] Need your inputs on this

[jira] [Commented] (KAFKA-9933) Need doc update on the AclAuthorizer when SASL_SSL is the protocol used.

2020-05-04 Thread kaushik srinivas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098824#comment-17098824 ] kaushik srinivas commented on KAFKA-9933: - Hi  [~ijuma] Need your inputs. We en

[GitHub] [kafka] nizhikov commented on pull request #8592: KAFKA-3184: Add Checkpoint for In-memory State Store

2020-05-04 Thread GitBox
nizhikov commented on pull request #8592: URL: https://github.com/apache/kafka/pull/8592#issuecomment-623398837 retest this This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [kafka] nizhikov edited a comment on pull request #8592: KAFKA-3184: Add Checkpoint for In-memory State Store

2020-05-04 Thread GitBox
nizhikov edited a comment on pull request #8592: URL: https://github.com/apache/kafka/pull/8592#issuecomment-623398837 failure unrelated This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [kafka] nizhikov commented on pull request #8592: KAFKA-3184: Add Checkpoint for In-memory State Store

2020-05-04 Thread GitBox
nizhikov commented on pull request #8592: URL: https://github.com/apache/kafka/pull/8592#issuecomment-623399649 retest this please This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [kafka] nizhikov edited a comment on pull request #8592: KAFKA-3184: Add Checkpoint for In-memory State Store

2020-05-04 Thread GitBox
nizhikov edited a comment on pull request #8592: URL: https://github.com/apache/kafka/pull/8592#issuecomment-623398837 retest this please This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [kafka] nizhikov removed a comment on pull request #8592: KAFKA-3184: Add Checkpoint for In-memory State Store

2020-05-04 Thread GitBox
nizhikov removed a comment on pull request #8592: URL: https://github.com/apache/kafka/pull/8592#issuecomment-623398837 retest this please This is an automated message from the Apache Git Service. To respond to the me

[jira] [Commented] (KAFKA-9933) Need doc update on the AclAuthorizer when SASL_SSL is the protocol used.

2020-05-04 Thread kaushik srinivas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098850#comment-17098850 ] kaushik srinivas commented on KAFKA-9933: - Hi [~ijuma] We see when SASL (GSSAPI

[jira] [Updated] (KAFKA-8120) Getting NegativeArraySizeException when using Kafka Connect to send data to Kafka

2020-05-04 Thread Jun Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Wang updated KAFKA-8120: Attachment: gen-mongodump.sh.txt > Getting NegativeArraySizeException when using Kafka Connect to send data

[jira] [Updated] (KAFKA-8120) Getting NegativeArraySizeException when using Kafka Connect to send data to Kafka

2020-05-04 Thread Jun Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Wang updated KAFKA-8120: Attachment: test.txt > Getting NegativeArraySizeException when using Kafka Connect to send data to > Kafka

[GitHub] [kafka] wj1918 opened a new pull request #8612: KAFKA-8120 Getting NegativeArraySizeException when using Kafka Connect

2020-05-04 Thread GitBox
wj1918 opened a new pull request #8612: URL: https://github.com/apache/kafka/pull/8612 1. Trigger buffer expansion when buffer does not extract a line 2. Limit buffer size to Integer.MAX_VALUE 3. Using single loop inside FileStreamSourceTask.poll 4. Close the stream before throw

[jira] [Commented] (KAFKA-8120) Getting NegativeArraySizeException when using Kafka Connect to send data to Kafka

2020-05-04 Thread Jun Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098935#comment-17098935 ] Jun Wang commented on KAFKA-8120: - Steps to reproduce and verify with kafka 2.5 1. run a

[GitHub] [kafka] ijuma commented on pull request #8607: KAFKA-9731: Disable immediate fetch response for hw propagation if replica selector is not defined

2020-05-04 Thread GitBox
ijuma commented on pull request #8607: URL: https://github.com/apache/kafka/pull/8607#issuecomment-623470067 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[jira] [Updated] (KAFKA-8120) Getting NegativeArraySizeException when using Kafka Connect to send data to Kafka

2020-05-04 Thread Jun Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Wang updated KAFKA-8120: Affects Version/s: 2.5.0 > Getting NegativeArraySizeException when using Kafka Connect to send data to > K

[GitHub] [kafka] lbradstreet commented on pull request #8609: KAFKA-9946; StopReplicaRequest deletePartition changes may cause premature topic deletion handling in controller

2020-05-04 Thread GitBox
lbradstreet commented on pull request #8609: URL: https://github.com/apache/kafka/pull/8609#issuecomment-623488567 I haven't reviewed the PR, but I can confirm that I no longer see the premature deletion behaviour that lead me to report KAFKA-9946.

[GitHub] [kafka] bbejeck commented on pull request #8504: KAFKA-9298: reuse mapped stream error in joins

2020-05-04 Thread GitBox
bbejeck commented on pull request #8504: URL: https://github.com/apache/kafka/pull/8504#issuecomment-623500291 >Is she? I guess it's clearly document that the name is use for repartition topics, too, but it might still be an unexpected "side effect"? But I see the point that it's not too e

[GitHub] [kafka] cadonna opened a new pull request #8613: KAFKA-6145: Set HighAvailabilityTaskAssignor as default in streams_upgrade_test.py

2020-05-04 Thread GitBox
cadonna opened a new pull request #8613: URL: https://github.com/apache/kafka/pull/8613 This PR sets HighAvailabilityTaskAssignor as default task assignor in streams_upgrade_test.py. The verification of the test needed to be modified to because the HighAvailabilityTaskAssignor surfaced

[GitHub] [kafka] cadonna commented on a change in pull request #8613: KAFKA-6145: Set HighAvailabilityTaskAssignor as default in streams_upgrade_test.py

2020-05-04 Thread GitBox
cadonna commented on a change in pull request #8613: URL: https://github.com/apache/kafka/pull/8613#discussion_r419496703 ## File path: tests/kafkatest/tests/streams/streams_upgrade_test.py ## @@ -532,20 +532,22 @@ def do_rolling_bounce(self, processor, counter, current_genera

[GitHub] [kafka] cadonna commented on a change in pull request #8613: KAFKA-6145: Set HighAvailabilityTaskAssignor as default in streams_upgrade_test.py

2020-05-04 Thread GitBox
cadonna commented on a change in pull request #8613: URL: https://github.com/apache/kafka/pull/8613#discussion_r419496703 ## File path: tests/kafkatest/tests/streams/streams_upgrade_test.py ## @@ -532,20 +532,22 @@ def do_rolling_bounce(self, processor, counter, current_genera

[GitHub] [kafka] cadonna commented on pull request #8613: KAFKA-6145: Set HighAvailabilityTaskAssignor as default in streams_upgrade_test.py

2020-05-04 Thread GitBox
cadonna commented on pull request #8613: URL: https://github.com/apache/kafka/pull/8613#issuecomment-623520934 Call for review: @vvcephei @ableegoldman This is an automated message from the Apache Git Service. To respond to

[jira] [Comment Edited] (KAFKA-8120) Getting NegativeArraySizeException when using Kafka Connect to send data to Kafka

2020-05-04 Thread Jun Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098935#comment-17098935 ] Jun Wang edited comment on KAFKA-8120 at 5/4/20, 3:09 PM: -- Steps

[GitHub] [kafka] cadonna commented on pull request #8613: KAFKA-6145: Set HighAvailabilityTaskAssignor as default in streams_upgrade_test.py

2020-05-04 Thread GitBox
cadonna commented on pull request #8613: URL: https://github.com/apache/kafka/pull/8613#issuecomment-623525749 System tests job: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3928/ This is an automated me

[GitHub] [kafka] dajac commented on pull request #8311: KAFKA-9434: automated protocol for alterReplicaLogDirs

2020-05-04 Thread GitBox
dajac commented on pull request #8311: URL: https://github.com/apache/kafka/pull/8311#issuecomment-623538567 @tombentley Did you consider adding a loop in at the end of the `handleResponse` that would complete any non-completed future related to the current `brokerId` with an exception?

[jira] [Commented] (KAFKA-9942) --entity-default flag is not working for alternating / describing configs in AdminClient

2020-05-04 Thread Cheng Tan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099083#comment-17099083 ] Cheng Tan commented on KAFKA-9942: -- [https://github.com/apache/kafka/pull/8610] Patch he

[GitHub] [kafka] C0urante commented on pull request #8608: KAFKA-9950: Construct new ConfigDef for MirrorTaskConfig before defining new properties

2020-05-04 Thread GitBox
C0urante commented on pull request #8608: URL: https://github.com/apache/kafka/pull/8608#issuecomment-623571317 Thanks Ryanne! @rhauch, @kkonstantine could one of you take a look at this when you have a chance? This i

[GitHub] [kafka] C0urante commented on pull request #7823: KAFKA-9228: Force reconfiguration of tasks if converter or Kafka client configs are changed

2020-05-04 Thread GitBox
C0urante commented on pull request #7823: URL: https://github.com/apache/kafka/pull/7823#issuecomment-623571767 Closing as I have no plans to work on this any time in the near future. This is an automated message from the Apa

[GitHub] [kafka] C0urante commented on pull request #6644: KAFKA-8299: Add generic-safe getConfiguredInstance() methods to AbstractConfig

2020-05-04 Thread GitBox
C0urante commented on pull request #6644: URL: https://github.com/apache/kafka/pull/6644#issuecomment-623572029 Closing as I have no plans to work on this any time in the near future. This is an automated message from the Apa

[GitHub] [kafka] cadonna commented on a change in pull request #8613: KAFKA-6145: Set HighAvailabilityTaskAssignor as default in streams_upgrade_test.py

2020-05-04 Thread GitBox
cadonna commented on a change in pull request #8613: URL: https://github.com/apache/kafka/pull/8613#discussion_r419496703 ## File path: tests/kafkatest/tests/streams/streams_upgrade_test.py ## @@ -532,20 +532,22 @@ def do_rolling_bounce(self, processor, counter, current_genera

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-05-04 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r419580652 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/HerderConnectorContext.java ## @@ -16,30 +16,64 @@ */ package org.apache.k

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-05-04 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r419583360 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java ## @@ -191,32 +192,71 @@ public synchronized

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-05-04 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r419585005 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java ## @@ -191,32 +192,71 @@ public synchronized

[GitHub] [kafka] tombentley commented on pull request #8311: KAFKA-9434: automated protocol for alterReplicaLogDirs

2020-05-04 Thread GitBox
tombentley commented on pull request #8311: URL: https://github.com/apache/kafka/pull/8311#issuecomment-623591202 @dajac yes, fair point. And I notice now that create and delete topics response handlers are already doing this (though the error messages in those cases don't really make much

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-05-04 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r419593948 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java ## @@ -266,31 +422,51 @@ public void close() {

[GitHub] [kafka] hachikuji commented on a change in pull request #8602: KAFKA-9947; Ensure proper shutdown of components in `TransactionsBounceTest`

2020-05-04 Thread GitBox
hachikuji commented on a change in pull request #8602: URL: https://github.com/apache/kafka/pull/8602#discussion_r419595855 ## File path: core/src/test/scala/integration/kafka/api/TransactionsBounceTest.scala ## @@ -130,13 +129,10 @@ class TransactionsBounceTest extends Kafka

[GitHub] [kafka] chia7712 commented on a change in pull request #8605: MINOR: align the constructor of KafkaConsumer to KafkaProducer

2020-05-04 Thread GitBox
chia7712 commented on a change in pull request #8605: URL: https://github.com/apache/kafka/pull/8605#discussion_r419596851 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java ## @@ -662,12 +641,27 @@ public KafkaConsumer(Properties properti

[jira] [Resolved] (KAFKA-9918) SslEngineFactory is NOT closed when channel is closing

2020-05-04 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-9918. Fix Version/s: 2.6.0 Resolution: Fixed > SslEngineFactory is NOT closed when channel

[GitHub] [kafka] hachikuji commented on a change in pull request #8585: KAFKA-9938; Debug consumer should be able to fetch from followers

2020-05-04 Thread GitBox
hachikuji commented on a change in pull request #8585: URL: https://github.com/apache/kafka/pull/8585#discussion_r419609984 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -949,8 +949,11 @@ class ReplicaManager(val config: KafkaConfig, else

[jira] [Created] (KAFKA-9951) More testing of ReplicaSelector

2020-05-04 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-9951: -- Summary: More testing of ReplicaSelector Key: KAFKA-9951 URL: https://issues.apache.org/jira/browse/KAFKA-9951 Project: Kafka Issue Type: Improvement

[GitHub] [kafka] mjsax commented on pull request #8600: KAFKA-9928: Fix flaky GlobalKTableEOSIntegrationTest

2020-05-04 Thread GitBox
mjsax commented on pull request #8600: URL: https://github.com/apache/kafka/pull/8600#issuecomment-623612153 All three runs timed out. Retest this please. This is an automated message from the Apache Git Service. To re

[jira] [Commented] (KAFKA-9929) Support reverse iterator on WindowStore

2020-05-04 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099187#comment-17099187 ] Guozhang Wang commented on KAFKA-9929: -- Hi [~jeqo], thanks for reporting this reques

[jira] [Comment Edited] (KAFKA-9929) Support reverse iterator on WindowStore

2020-05-04 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099187#comment-17099187 ] Guozhang Wang edited comment on KAFKA-9929 at 5/4/20, 5:59 PM:

[jira] [Commented] (KAFKA-9859) kafka-streams-application-reset tool doesn't take into account topics generated by KTable foreign key join operation

2020-05-04 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099190#comment-17099190 ] Guozhang Wang commented on KAFKA-9859: -- [~lkokhreidze] Do you want to send a PR to r

[jira] [Commented] (KAFKA-9859) kafka-streams-application-reset tool doesn't take into account topics generated by KTable foreign key join operation

2020-05-04 Thread Levani Kokhreidze (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099196#comment-17099196 ] Levani Kokhreidze commented on KAFKA-9859: -- Hi [~guozhang], Was meaning to do i

[jira] [Assigned] (KAFKA-9859) kafka-streams-application-reset tool doesn't take into account topics generated by KTable foreign key join operation

2020-05-04 Thread Levani Kokhreidze (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Levani Kokhreidze reassigned KAFKA-9859: Assignee: Levani Kokhreidze > kafka-streams-application-reset tool doesn't take in

[GitHub] [kafka] hachikuji commented on pull request #8607: KAFKA-9731: Disable immediate fetch response for hw propagation if replica selector is not defined

2020-05-04 Thread GitBox
hachikuji commented on pull request #8607: URL: https://github.com/apache/kafka/pull/8607#issuecomment-623617879 @ijuma Thanks for the patch. I think the change makes sense. Part of me is inclined to drop the logic for immediate propagation of high watermark entirely. Instead, we could say

[GitHub] [kafka] hachikuji edited a comment on pull request #8607: KAFKA-9731: Disable immediate fetch response for hw propagation if replica selector is not defined

2020-05-04 Thread GitBox
hachikuji edited a comment on pull request #8607: URL: https://github.com/apache/kafka/pull/8607#issuecomment-623617879 @ijuma Thanks for the patch. I think the change makes sense. Part of me is inclined to drop the logic for the immediate propagation of the high watermark entirely. Instea

[GitHub] [kafka] ijuma commented on pull request #8607: KAFKA-9731: Disable immediate fetch response for hw propagation if replica selector is not defined

2020-05-04 Thread GitBox
ijuma commented on pull request #8607: URL: https://github.com/apache/kafka/pull/8607#issuecomment-623620280 @hachikuji I was thinking the exact same thing. :) I thought this PR could be the simple one we can backport and then we can discuss the larger change separately as you suggested.

[jira] [Created] (KAFKA-9952) Reconsider immediate propagation of hw when replica selector is used

2020-05-04 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-9952: -- Summary: Reconsider immediate propagation of hw when replica selector is used Key: KAFKA-9952 URL: https://issues.apache.org/jira/browse/KAFKA-9952 Project: Kafka

[GitHub] [kafka] hachikuji commented on pull request #8607: KAFKA-9731: Disable immediate fetch response for hw propagation if replica selector is not defined

2020-05-04 Thread GitBox
hachikuji commented on pull request #8607: URL: https://github.com/apache/kafka/pull/8607#issuecomment-623630601 Filed this issue: https://issues.apache.org/jira/browse/KAFKA-9952. This is an automated message from the Apache

[jira] [Commented] (KAFKA-3184) Add Checkpoint for In-memory State Store

2020-05-04 Thread Nikolay Izhikov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099287#comment-17099287 ] Nikolay Izhikov commented on KAFKA-3184: [~guozhang] > we need to make the check

[GitHub] [kafka] DivLoic opened a new pull request #8614: KAFKA-7472: add the HeaderFrom and HeaderTo SMTs

2020-05-04 Thread GitBox
DivLoic opened a new pull request #8614: URL: https://github.com/apache/kafka/pull/8614 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing s

[GitHub] [kafka] vvcephei commented on a change in pull request #8613: KAFKA-6145: Set HighAvailabilityTaskAssignor as default in streams_upgrade_test.py

2020-05-04 Thread GitBox
vvcephei commented on a change in pull request #8613: URL: https://github.com/apache/kafka/pull/8613#discussion_r419693644 ## File path: tests/kafkatest/tests/streams/streams_upgrade_test.py ## @@ -532,20 +532,22 @@ def do_rolling_bounce(self, processor, counter, current_gener

[jira] [Commented] (KAFKA-7472) Implement KIP-145 transformations

2020-05-04 Thread Loic DIVAD (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099316#comment-17099316 ] Loic DIVAD commented on KAFKA-7472: --- Hi, I would like to suggest the PR: [https://githu

[GitHub] [kafka] vvcephei commented on pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-05-04 Thread GitBox
vvcephei commented on pull request #8540: URL: https://github.com/apache/kafka/pull/8540#issuecomment-623680367 Thanks @mjsax (and sorry I didn't see your comment before). The ticket indicates that it was introduced in 2.5 (https://issues.apache.org/jira/browse/KAFKA-9127). I

[GitHub] [kafka] vvcephei edited a comment on pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-05-04 Thread GitBox
vvcephei edited a comment on pull request #8540: URL: https://github.com/apache/kafka/pull/8540#issuecomment-623680367 Thanks @mjsax (and sorry I didn't see your comment before). The ticket indicates that it was introduced in 2.5 (https://issues.apache.org/jira/browse/KAFKA-9127 , l

[jira] [Comment Edited] (KAFKA-3184) Add Checkpoint for In-memory State Store

2020-05-04 Thread Nikolay Izhikov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099287#comment-17099287 ] Nikolay Izhikov edited comment on KAFKA-3184 at 5/4/20, 8:15 PM: --

[GitHub] [kafka] vvcephei commented on a change in pull request #8596: KAFKA-9821: persist followup rebalance in assignment and consolidate rebalance triggering mechanisms

2020-05-04 Thread GitBox
vvcephei commented on a change in pull request #8596: URL: https://github.com/apache/kafka/pull/8596#discussion_r419705427 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -877,7 +877,7 @@ public static final String STREAMS_METADAT

[GitHub] [kafka] ableegoldman commented on pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-05-04 Thread GitBox
ableegoldman commented on pull request #8540: URL: https://github.com/apache/kafka/pull/8540#issuecomment-623690181 @vvcephei yeah the regression was only introduced in 2.5, so we only _need_ to backport it that far. But I actually would agree that we should backport it to 2.4 as well: in

[GitHub] [kafka] ableegoldman commented on a change in pull request #8596: KAFKA-9821: persist followup rebalance in assignment and consolidate rebalance triggering mechanisms

2020-05-04 Thread GitBox
ableegoldman commented on a change in pull request #8596: URL: https://github.com/apache/kafka/pull/8596#discussion_r419711999 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -877,7 +877,7 @@ public static final String STREAMS_MET

[GitHub] [kafka] hachikuji commented on pull request #8609: KAFKA-9946; StopReplicaRequest deletePartition changes may cause premature topic deletion handling in controller

2020-05-04 Thread GitBox
hachikuji commented on pull request #8609: URL: https://github.com/apache/kafka/pull/8609#issuecomment-623696783 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] vvcephei commented on a change in pull request #8596: KAFKA-9821: persist followup rebalance in assignment and consolidate rebalance triggering mechanisms

2020-05-04 Thread GitBox
vvcephei commented on a change in pull request #8596: URL: https://github.com/apache/kafka/pull/8596#discussion_r419718314 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -877,7 +877,7 @@ public static final String STREAMS_METADAT

[GitHub] [kafka] vvcephei commented on a change in pull request #8596: KAFKA-9821: persist followup rebalance in assignment and consolidate rebalance triggering mechanisms

2020-05-04 Thread GitBox
vvcephei commented on a change in pull request #8596: URL: https://github.com/apache/kafka/pull/8596#discussion_r419718786 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -877,7 +877,7 @@ public static final String STREAMS_METADAT

[GitHub] [kafka] vvcephei commented on pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-05-04 Thread GitBox
vvcephei commented on pull request #8540: URL: https://github.com/apache/kafka/pull/8540#issuecomment-623697876 Thanks for the clarification. I'll see about backporting to 2.4... This is an automated message from the Apache G

[GitHub] [kafka] vvcephei commented on pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-05-04 Thread GitBox
vvcephei commented on pull request #8540: URL: https://github.com/apache/kafka/pull/8540#issuecomment-623701299 Actually @ableegoldman , the cherry-pick to 2.4 isn't straightforward. Do you mind doing a separate PR for it? T

[GitHub] [kafka] lbradstreet commented on a change in pull request #8609: KAFKA-9946; StopReplicaRequest deletePartition changes may cause premature topic deletion handling in controller

2020-05-04 Thread GitBox
lbradstreet commented on a change in pull request #8609: URL: https://github.com/apache/kafka/pull/8609#discussion_r419725599 ## File path: core/src/main/scala/kafka/controller/ControllerChannelManager.scala ## @@ -590,7 +569,26 @@ abstract class AbstractControllerBrokerReques

[GitHub] [kafka] vvcephei commented on pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-05-04 Thread GitBox
vvcephei commented on pull request #8540: URL: https://github.com/apache/kafka/pull/8540#issuecomment-623705234 Or, if it's too much trouble, we can just note on the ticket that it _could_ be backported, but isn't (yet) This

[jira] [Created] (KAFKA-9953) support multiple consumerGroupCoordinators in TransactionManager

2020-05-04 Thread Joost van de Wijgerd (Jira)
Joost van de Wijgerd created KAFKA-9953: --- Summary: support multiple consumerGroupCoordinators in TransactionManager Key: KAFKA-9953 URL: https://issues.apache.org/jira/browse/KAFKA-9953 Project:

[GitHub] [kafka] cmccabe commented on pull request #8527: Remove dependencies on deprecated --zookeeper command flags in junit tests

2020-05-04 Thread GitBox
cmccabe commented on pull request #8527: URL: https://github.com/apache/kafka/pull/8527#issuecomment-623716775 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Assigned] (KAFKA-7472) Implement KIP-145 transformations

2020-05-04 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch reassigned KAFKA-7472: Assignee: Loic DIVAD (was: Randall Hauch) > Implement KIP-145 transformations >

[jira] [Commented] (KAFKA-7472) Implement KIP-145 transformations

2020-05-04 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099377#comment-17099377 ] Randall Hauch commented on KAFKA-7472: -- Thanks, [~loicmdivad]. I'll take a look shor

[GitHub] [kafka] ijuma commented on pull request #8607: KAFKA-9731: Disable immediate fetch response for hw propagation if replica selector is not defined

2020-05-04 Thread GitBox
ijuma commented on pull request #8607: URL: https://github.com/apache/kafka/pull/8607#issuecomment-623757017 I added a test. @mumrah @gwenshap maybe one of you can take a quick look? This is an automated message from the Apac

[GitHub] [kafka] cmccabe commented on a change in pull request #8610: KAKFA-9942: --entity-default flag is not working for alternating / describing configs in AdminClient

2020-05-04 Thread GitBox
cmccabe commented on a change in pull request #8610: URL: https://github.com/apache/kafka/pull/8610#discussion_r419793865 ## File path: core/src/main/scala/kafka/zk/KafkaZkClient.scala ## @@ -329,11 +329,13 @@ class KafkaZkClient private[zk] (zooKeeperClient: ZooKeeperClient,

[GitHub] [kafka] cmccabe commented on a change in pull request #8610: KAKFA-9942: --entity-default flag is not working for alternating / describing configs in AdminClient

2020-05-04 Thread GitBox
cmccabe commented on a change in pull request #8610: URL: https://github.com/apache/kafka/pull/8610#discussion_r419793778 ## File path: core/src/main/scala/kafka/zk/KafkaZkClient.scala ## @@ -329,11 +329,13 @@ class KafkaZkClient private[zk] (zooKeeperClient: ZooKeeperClient,

[GitHub] [kafka] cmccabe commented on a change in pull request #8610: KAKFA-9942: --entity-default flag is not working for alternating / describing configs in AdminClient

2020-05-04 Thread GitBox
cmccabe commented on a change in pull request #8610: URL: https://github.com/apache/kafka/pull/8610#discussion_r419794980 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -473,10 +474,11 @@ object ConfigCommand extends Config { } private def descr

[GitHub] [kafka] cmccabe commented on pull request #8610: KAKFA-9942: --entity-default flag is not working for alternating / describing configs in AdminClient

2020-05-04 Thread GitBox
cmccabe commented on pull request #8610: URL: https://github.com/apache/kafka/pull/8610#issuecomment-623768582 Thanks for this, @d8tltanc . It seems like there are still some debug log message left in? Also, we definitely need a test for this one. -

[GitHub] [kafka] hachikuji commented on a change in pull request #8609: KAFKA-9946; StopReplicaRequest deletePartition changes may cause premature topic deletion handling in controller

2020-05-04 Thread GitBox
hachikuji commented on a change in pull request #8609: URL: https://github.com/apache/kafka/pull/8609#discussion_r419803119 ## File path: core/src/main/scala/kafka/controller/ControllerChannelManager.scala ## @@ -590,7 +569,26 @@ abstract class AbstractControllerBrokerRequestB

[jira] [Created] (KAFKA-9954) Config command didn't validate the unsupported user config change

2020-05-04 Thread Cheng Tan (Jira)
Cheng Tan created KAFKA-9954: Summary: Config command didn't validate the unsupported user config change Key: KAFKA-9954 URL: https://issues.apache.org/jira/browse/KAFKA-9954 Project: Kafka Issu

[GitHub] [kafka] guozhangwang commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-04 Thread GitBox
guozhangwang commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r419795444 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -247,6 +270,20 @@ void initializeSto

[GitHub] [kafka] d8tltanc opened a new pull request #8615: KAFKA-9954: Config command didn't validate the unsupported user config change

2020-05-04 Thread GitBox
d8tltanc opened a new pull request #8615: URL: https://github.com/apache/kafka/pull/8615 *More detailed description of your change, Throw an error when users are trying to alter user configs with AdminClient *Summary of testing strategy (including rationale) for the feature or b

[GitHub] [kafka] d8tltanc commented on pull request #8610: KAKFA-9942: --entity-default flag is not working for alternating / describing configs in AdminClient

2020-05-04 Thread GitBox
d8tltanc commented on pull request #8610: URL: https://github.com/apache/kafka/pull/8610#issuecomment-623785708 Thanks @cmccabe for the initial review. I'll remove all the warning logs after the tests pass. This is an auto

[jira] [Assigned] (KAFKA-9954) Config command didn't validate the unsupported user config change

2020-05-04 Thread Cheng Tan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cheng Tan reassigned KAFKA-9954: Assignee: Cheng Tan > Config command didn't validate the unsupported user config change >

[GitHub] [kafka] ijuma commented on pull request #8607: KAFKA-9731: Disable immediate fetch response for hw propagation if replica selector is not defined

2020-05-04 Thread GitBox
ijuma commented on pull request #8607: URL: https://github.com/apache/kafka/pull/8607#issuecomment-623787840 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] ableegoldman opened a new pull request #8616: KAFKA-9127: don't create StreamThreads for global-only topology (2.4)

2020-05-04 Thread GitBox
ableegoldman opened a new pull request #8616: URL: https://github.com/apache/kafka/pull/8616 Copy of [pull/8540](https://github.com/apache/kafka/pull/8540) targeted at 2.4 This is an automated message from the Apache Git Ser

[GitHub] [kafka] ableegoldman commented on pull request #8616: KAFKA-9127: don't create StreamThreads for global-only topology (2.4)

2020-05-04 Thread GitBox
ableegoldman commented on pull request #8616: URL: https://github.com/apache/kafka/pull/8616#issuecomment-623792498 @vvcephei This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] ableegoldman commented on a change in pull request #8596: KAFKA-9821: persist followup rebalance in assignment and consolidate rebalance triggering mechanisms

2020-05-04 Thread GitBox
ableegoldman commented on a change in pull request #8596: URL: https://github.com/apache/kafka/pull/8596#discussion_r419827086 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -877,7 +877,7 @@ public static final String STREAMS_MET

[GitHub] [kafka] ableegoldman commented on a change in pull request #8613: KAFKA-6145: Set HighAvailabilityTaskAssignor as default in streams_upgrade_test.py

2020-05-04 Thread GitBox
ableegoldman commented on a change in pull request #8613: URL: https://github.com/apache/kafka/pull/8613#discussion_r419829020 ## File path: tests/kafkatest/tests/streams/streams_upgrade_test.py ## @@ -532,20 +532,22 @@ def do_rolling_bounce(self, processor, counter, current_g

[GitHub] [kafka] ableegoldman commented on a change in pull request #8613: KAFKA-6145: Set HighAvailabilityTaskAssignor as default in streams_upgrade_test.py

2020-05-04 Thread GitBox
ableegoldman commented on a change in pull request #8613: URL: https://github.com/apache/kafka/pull/8613#discussion_r419829020 ## File path: tests/kafkatest/tests/streams/streams_upgrade_test.py ## @@ -532,20 +532,22 @@ def do_rolling_bounce(self, processor, counter, current_g

[GitHub] [kafka] efeg commented on a change in pull request #8579: KAFKA-9930: Prevent ReplicaFetcherThread from throwing UnknownTopicOrPartitionException upon topic creation and deletion.

2020-05-04 Thread GitBox
efeg commented on a change in pull request #8579: URL: https://github.com/apache/kafka/pull/8579#discussion_r419833344 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -382,6 +382,11 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] efeg commented on a change in pull request #8579: KAFKA-9930: Prevent ReplicaFetcherThread from throwing UnknownTopicOrPartitionException upon topic creation and deletion.

2020-05-04 Thread GitBox
efeg commented on a change in pull request #8579: URL: https://github.com/apache/kafka/pull/8579#discussion_r419833344 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -382,6 +382,11 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] jeffkbkim opened a new pull request #8617: MINOR: MockAdminClient should return InvalidReplicationFactorException if brokers.size < replicationFactor

2020-05-04 Thread GitBox
jeffkbkim opened a new pull request #8617: URL: https://github.com/apache/kafka/pull/8617 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* * `MockAdminClient` sho

[jira] [Commented] (KAFKA-9660) KAFKA-1 build a kafka-exporter by java

2020-05-04 Thread Li Wei (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099499#comment-17099499 ] Li Wei commented on KAFKA-9660: --- [~sujayopensource]  i am sorry for reply late. you can re

[jira] [Created] (KAFKA-9955) Exceptions thrown from SinkTask::close shadow other exceptions

2020-05-04 Thread Greg Harris (Jira)
Greg Harris created KAFKA-9955: -- Summary: Exceptions thrown from SinkTask::close shadow other exceptions Key: KAFKA-9955 URL: https://issues.apache.org/jira/browse/KAFKA-9955 Project: Kafka Iss

[GitHub] [kafka] omkreddy commented on pull request #8617: MINOR: MockAdminClient should return InvalidReplicationFactorException if brokers.size < replicationFactor

2020-05-04 Thread GitBox
omkreddy commented on pull request #8617: URL: https://github.com/apache/kafka/pull/8617#issuecomment-623842653 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

  1   2   >