[
https://issues.apache.org/jira/browse/KAFKA-9343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160993#comment-17160993
]
Shuo Zhang commented on KAFKA-9343:
---
[~bbejeck], [~bwittwer] ,
I found it(KAFKA-9343)
pwebbitrs commented on pull request #5785:
URL: https://github.com/apache/kafka/pull/5785#issuecomment-660878440
Hi. what is the current status of this issue? We're hitting the overflow
problem now.
This is an automated m
pwebbitrs edited a comment on pull request #5785:
URL: https://github.com/apache/kafka/pull/5785#issuecomment-660878440
Hi. what is the current status of this issue? We're hitting the overflow
problem now. We're on Scala 2.12; Kafka 2.5.0.
---
rajinisivaram commented on pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#issuecomment-660881955
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log o
[
https://issues.apache.org/jira/browse/KAFKA-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161043#comment-17161043
]
Boris Churzin commented on KAFKA-3039:
--
We just noticed the same "Truncated 'topic'
rajinisivaram commented on a change in pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#discussion_r457195568
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -864,9 +868,12 @@ object KafkaConfig {
val NumQuotaSamplesDoc = "The number
rajinisivaram commented on a change in pull request #8954:
URL: https://github.com/apache/kafka/pull/8954#discussion_r457270288
##
File path: core/src/test/scala/integration/kafka/api/BaseQuotaTest.scala
##
@@ -335,12 +339,31 @@ abstract class QuotaTestClients(topic: String,
rajinisivaram opened a new pull request #9044:
URL: https://github.com/apache/kafka/pull/9044
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgra
dajac commented on a change in pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#discussion_r457306361
##
File path: core/src/main/scala/kafka/server/ControllerMutationQuotaManager.scala
##
@@ -0,0 +1,240 @@
+/**
+ * Licensed to the Apache Software Foundation (
dajac commented on a change in pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#discussion_r457315050
##
File path:
core/src/test/scala/unit/kafka/server/ControllerMutationQuotaTest.scala
##
@@ -0,0 +1,352 @@
+/**
+ * Licensed under the Apache License, Versio
rajinisivaram commented on a change in pull request #8768:
URL: https://github.com/apache/kafka/pull/8768#discussion_r457308585
##
File path: core/src/test/scala/unit/kafka/network/ConnectionQuotasTest.scala
##
@@ -70,37 +80,38 @@ class ConnectionQuotasTest {
blockedPe
dajac commented on pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#issuecomment-660988365
@rajinisivaram I just pushed an update which addresses your comments.
This is an automated message from the Apache G
rajinisivaram commented on pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#issuecomment-660994921
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, plea
rhauch commented on pull request #9040:
URL: https://github.com/apache/kafka/pull/9040#issuecomment-660996930
@gharris1727 Thanks for the proposed fix. I've started a build for this
branch: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4047/
---
rhauch commented on pull request #9043:
URL: https://github.com/apache/kafka/pull/9043#issuecomment-660997300
@gharris1727 Thanks for the proposed fix. I've started a build for this
branch: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4046/
---
rhauch edited a comment on pull request #9040:
URL: https://github.com/apache/kafka/pull/9040#issuecomment-660996930
@gharris1727 Thanks for the proposed fix. I've started a system test build
for this branch:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4047/
---
rhauch edited a comment on pull request #9043:
URL: https://github.com/apache/kafka/pull/9043#issuecomment-660997300
@gharris1727 Thanks for the proposed fix. I've started a system test build
for this branch:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4046/
---
rhauch opened a new pull request #9045:
URL: https://github.com/apache/kafka/pull/9045
I had to add these one-by-one in order to build the AK 2.6.0 RCs.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and
omkreddy commented on pull request #9041:
URL: https://github.com/apache/kafka/pull/9041#issuecomment-661008449
@rajinisivaram Thanks for the review.
@rhauch I would like to merge the PR to 2.6 branch,
This is an aut
rhauch commented on pull request #9041:
URL: https://github.com/apache/kafka/pull/9041#issuecomment-661016389
@omkreddy sounds good to backport to the `2.6` branch.
This is an automated message from the Apache Git Service.
To
omkreddy closed pull request #9041:
URL: https://github.com/apache/kafka/pull/9041
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
dajac commented on a change in pull request #8768:
URL: https://github.com/apache/kafka/pull/8768#discussion_r457390034
##
File path:
clients/src/main/java/org/apache/kafka/common/metrics/MetricConfig.java
##
@@ -97,5 +99,13 @@ public MetricConfig recordLevel(Sensor.RecordingL
rhauch commented on pull request #9043:
URL: https://github.com/apache/kafka/pull/9043#issuecomment-661046699
All 69 Connect system tests passed:
http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-07-20--001.1595250965--gharris1727--bounce-recovery--c0
mumrah commented on pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#issuecomment-661049255
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
rhauch merged pull request #9040:
URL: https://github.com/apache/kafka/pull/9040
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
rhauch merged pull request #9043:
URL: https://github.com/apache/kafka/pull/9043
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
rhauch commented on pull request #9040:
URL: https://github.com/apache/kafka/pull/9040#issuecomment-661046734
All 69 Connect system tests passed:
http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-07-20--001.1595250901--gharris1727--wait-for-join--2d22
dajac commented on pull request #8954:
URL: https://github.com/apache/kafka/pull/8954#issuecomment-661056556
@rajinisivaram Thanks for the review. I just pushed an updated that
addressed your comment.
This is an automated me
[
https://issues.apache.org/jira/browse/KAFKA-10286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch updated KAFKA-10286:
--
Fix Version/s: 2.7.0
2.5.1
2.4.2
2.6.0
[
https://issues.apache.org/jira/browse/KAFKA-10295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch updated KAFKA-10295:
--
Fix Version/s: 2.7.0
2.5.1
2.4.2
2.6.0
mumrah commented on a change in pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#discussion_r457416269
##
File path:
clients/src/main/java/org/apache/kafka/common/protocol/RecordsWriter.java
##
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundat
mumrah commented on a change in pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#discussion_r457416269
##
File path:
clients/src/main/java/org/apache/kafka/common/protocol/RecordsWriter.java
##
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundat
[
https://issues.apache.org/jira/browse/KAFKA-10286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch resolved KAFKA-10286.
---
Reviewer: Randall Hauch
Resolution: Fixed
> Connect system tests should wait for worke
[
https://issues.apache.org/jira/browse/KAFKA-10295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch resolved KAFKA-10295.
---
Reviewer: Randall Hauch
Resolution: Fixed
> ConnectDistributedTest.test_bounce should
rajinisivaram commented on pull request #8954:
URL: https://github.com/apache/kafka/pull/8954#issuecomment-661074391
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log o
ijuma commented on a change in pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#discussion_r457496688
##
File path:
clients/src/main/java/org/apache/kafka/common/protocol/RecordsWriter.java
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software Foundati
ijuma commented on a change in pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#discussion_r457496688
##
File path:
clients/src/main/java/org/apache/kafka/common/protocol/RecordsWriter.java
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software Foundati
ijuma commented on a change in pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#discussion_r457496688
##
File path:
clients/src/main/java/org/apache/kafka/common/protocol/RecordsWriter.java
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software Foundati
rajinisivaram commented on pull request #8933:
URL: https://github.com/apache/kafka/pull/8933#issuecomment-661112802
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, plea
ijuma commented on a change in pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#discussion_r457513713
##
File path:
clients/src/main/java/org/apache/kafka/common/protocol/RecordsWriter.java
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software Foundati
mumrah commented on a change in pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#discussion_r457546281
##
File path:
clients/src/main/java/org/apache/kafka/common/protocol/RecordsWriter.java
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software Foundat
mumrah commented on a change in pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#discussion_r457546281
##
File path:
clients/src/main/java/org/apache/kafka/common/protocol/RecordsWriter.java
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software Foundat
abbccdda commented on pull request #9012:
URL: https://github.com/apache/kafka/pull/9012#issuecomment-661193368
2/3 green with only flaky test failure
This is an automated message from the Apache Git Service.
To respond to th
ijuma commented on a change in pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#discussion_r457562415
##
File path:
clients/src/main/java/org/apache/kafka/common/protocol/RecordsWriter.java
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software Foundati
abbccdda commented on a change in pull request #9012:
URL: https://github.com/apache/kafka/pull/9012#discussion_r457563117
##
File path:
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala
##
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foundat
abbccdda commented on a change in pull request #9012:
URL: https://github.com/apache/kafka/pull/9012#discussion_r457569580
##
File path:
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala
##
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foundat
abbccdda commented on a change in pull request #9012:
URL: https://github.com/apache/kafka/pull/9012#discussion_r457569155
##
File path:
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala
##
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foundat
ning2008wisc commented on pull request #9029:
URL: https://github.com/apache/kafka/pull/9029#issuecomment-661219342
Probably @mimaison could take the final review and approve it. Thanks
This is an automated message from the A
kkonstantine commented on pull request #9040:
URL: https://github.com/apache/kafka/pull/9040#issuecomment-661228560
Thanks for the fix @gharris1727. It's good to stabilize these tests, they've
been relatively flaky for some time.
W/r/t the actual fix I have to notice that we've been
[
https://issues.apache.org/jira/browse/KAFKA-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161423#comment-17161423
]
Guozhang Wang commented on KAFKA-10179:
---
I agree with Almog and Rohan’s arguments
[
https://issues.apache.org/jira/browse/KAFKA-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161425#comment-17161425
]
Brian Byrne commented on KAFKA-10278:
-
Hi [~kaushik srinivas],
If I understand corr
[
https://issues.apache.org/jira/browse/KAFKA-10277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-10277:
Labels: beginner newbie (was: )
> Relax non-null key requirement for KStream-GlobalKTable
[
https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161440#comment-17161440
]
Almog Gavra commented on KAFKA-8037:
I'm not totally sure I'm understanding the solut
[
https://issues.apache.org/jira/browse/KAFKA-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161468#comment-17161468
]
Konstantin Lalafaryan commented on KAFKA-10253:
---
[~ChrisEgerton] Do you ne
gharris1727 commented on pull request #9040:
URL: https://github.com/apache/kafka/pull/9040#issuecomment-661296268
@kkonstantine In my investigation for this fix, I noticed that the long join
was happening in the first worker to join the group, as it was creating the
`connect-offsets` topi
omkreddy edited a comment on pull request #8312:
URL: https://github.com/apache/kafka/pull/8312#issuecomment-660478715
@tombentley After this change, `adminClient.describeConnfigs()` is not
backward compatible with older kafka broker versions. It seems, older brokers
are receiving empty c
omkreddy edited a comment on pull request #8312:
URL: https://github.com/apache/kafka/pull/8312#issuecomment-660478715
@tombentley After this change, `adminClient.describeConnfigs()` is not
backward compatible with older kafka broker versions. It seems, older brokers
are receiving empty c
[
https://issues.apache.org/jira/browse/KAFKA-10274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161519#comment-17161519
]
John Roesler commented on KAFKA-10274:
--
Hi [~hachikuji] ,
I'm trying to get a gree
[
https://issues.apache.org/jira/browse/KAFKA-10274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161519#comment-17161519
]
John Roesler edited comment on KAFKA-10274 at 7/20/20, 8:36 PM:
--
junrao commented on pull request #8935:
URL: https://github.com/apache/kafka/pull/8935#issuecomment-661322853
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
omkreddy opened a new pull request #9046:
URL: https://github.com/apache/kafka/pull/9046
- After #8312, older brokers are returning empty configs, with latest
adminClient. Old brokers are receiving empty configNames in
`AdminManageer.describeConfigs()` method. Older brokers does not han
[
https://issues.apache.org/jira/browse/KAFKA-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantin Lalafaryan resolved KAFKA-10253.
---
Resolution: Not A Problem
Seems like we have found a problem, and it is rela
vvcephei merged pull request #9027:
URL: https://github.com/apache/kafka/pull/9027
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
[
https://issues.apache.org/jira/browse/KAFKA-10174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-10174:
Fix Version/s: (was: 2.7)
2.7.0
> Prefer --bootstrap-server ducktap
vvcephei commented on pull request #9027:
URL: https://github.com/apache/kafka/pull/9027#issuecomment-661343321
Thanks @ableegoldman ! Merged to trunk.
This is an automated message from the Apache Git Service.
To respond to t
[
https://issues.apache.org/jira/browse/KAFKA-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-10243:
Fix Version/s: (was: 2.7)
2.7.0
> ConcurrentModificationException w
mjsax commented on a change in pull request #8864:
URL: https://github.com/apache/kafka/pull/8864#discussion_r457703608
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaStatusBackingStore.java
##
@@ -148,6 +148,7 @@ public KafkaStatusBackingSto
Matthias J. Sax created KAFKA-10297:
---
Summary: Don't use deprecated producer config `retries`
Key: KAFKA-10297
URL: https://issues.apache.org/jira/browse/KAFKA-10297
Project: Kafka
Issue Ty
[
https://issues.apache.org/jira/browse/KAFKA-10274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161560#comment-17161560
]
John Roesler commented on KAFKA-10274:
--
FWIW, I cherry-picked both of these fixes o
mjsax commented on a change in pull request #8864:
URL: https://github.com/apache/kafka/pull/8864#discussion_r457707335
##
File path: core/src/main/scala/kafka/tools/ConsoleProducer.scala
##
@@ -146,7 +148,7 @@ object ConsoleProducer {
.describedAs("size")
.ofType
mjsax commented on a change in pull request #8864:
URL: https://github.com/apache/kafka/pull/8864#discussion_r457707688
##
File path:
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
##
@@ -662,6 +662,7 @@ public void testInvalidTopicNames() throw
[
https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161565#comment-17161565
]
Guozhang Wang commented on KAFKA-8037:
--
There are some more discussions on related i
[
https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161565#comment-17161565
]
Guozhang Wang edited comment on KAFKA-8037 at 7/20/20, 9:54 PM:
---
[
https://issues.apache.org/jira/browse/KAFKA-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-7878:
---
Component/s: KafkaConnect
> Connect Task already exists in this worker when failed to create consumer
mjsax commented on pull request #8844:
URL: https://github.com/apache/kafka/pull/8844#issuecomment-661445423
I am not really familiar with connect code base. Would leave it to @rhauch
or @kkonstantine to have a look.
This is
mjsax commented on a change in pull request #8200:
URL: https://github.com/apache/kafka/pull/8200#discussion_r457751610
##
File path:
streams/src/main/java/org/apache/kafka/streams/errors/InvalidStateStoreException.java
##
@@ -18,13 +18,8 @@
/**
- * Indicates that there w
ableegoldman commented on a change in pull request #9028:
URL: https://github.com/apache/kafka/pull/9028#discussion_r457756031
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/ResetIntegrationTest.java
##
@@ -68,52 +92,224 @@ public void after() throws
mjsax commented on a change in pull request #8690:
URL: https://github.com/apache/kafka/pull/8690#discussion_r457759030
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/RoundRobinPartitioner.java
##
@@ -65,12 +65,20 @@ public int partition(String topic, Ob
mjsax commented on pull request #8690:
URL: https://github.com/apache/kafka/pull/8690#issuecomment-661469237
It seem we should add a test that verifies that the producer does the right
thing when configures with the RoundRobinPartitioner? Only unit testing the
`RoundRoubinPartitioner` migh
mjsax commented on pull request #9000:
URL: https://github.com/apache/kafka/pull/9000#issuecomment-661472161
There is a checkstyle error:
```
Task :streams:checkstyleTest
12:00:03 [ant:checkstyle] [ERROR]
/home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams/src/te
mjsax commented on pull request #8864:
URL: https://github.com/apache/kafka/pull/8864#issuecomment-661474056
Updates this PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on
mjsax closed pull request #8120:
URL: https://github.com/apache/kafka/pull/8120
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mjsax closed pull request #8122:
URL: https://github.com/apache/kafka/pull/8122
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
soarez commented on pull request #9000:
URL: https://github.com/apache/kafka/pull/9000#issuecomment-661501744
Thanks @mjsax . I've addressed the Checkstyle issue.
I don't think I'm able to close the original PR. In this Github repository
I'm only able to close PRs that I've authored
junrao merged pull request #8935:
URL: https://github.com/apache/kafka/pull/8935
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161675#comment-17161675
]
John Roesler commented on KAFKA-8037:
-
Thanks for your thoughts, [~guozhang] .
It re
[
https://issues.apache.org/jira/browse/KAFKA-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161666#comment-17161666
]
Greg Harris commented on KAFKA-5756:
I was able to reproduce this race condition with
vitojeng commented on pull request #8200:
URL: https://github.com/apache/kafka/pull/8200#issuecomment-661643910
> Thanks for the update @vitojeng -- a few more nits. Overall LGTM. Will
merge after addressed.
Thanks @mjsax for the reviewing, just updated,
--
vitojeng edited a comment on pull request #8200:
URL: https://github.com/apache/kafka/pull/8200#issuecomment-661643910
> Thanks for the update @vitojeng -- a few more nits. Overall LGTM. Will
merge after addressed.
Thanks @mjsax for the reviewing, just updated.
89 matches
Mail list logo
