[
https://issues.apache.org/jira/browse/KAFKA-7421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214685#comment-17214685
]
Goltseva Taisiia edited comment on KAFKA-7421 at 10/16/20, 6:25 AM:
---
vamossagar12 commented on pull request #9432:
URL: https://github.com/apache/kafka/pull/9432#issuecomment-709801023
Thanks @mjsax . I thought these were time out related tests so ended up
removing them. Thanks for the feedback :)
---
[
https://issues.apache.org/jira/browse/KAFKA-10472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Huynh Quang Thao updated KAFKA-10472:
-
Comment: was deleted
(was: If Wiki you mentioned is Confluence, then yes, I have already
[
https://issues.apache.org/jira/browse/KAFKA-10472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215195#comment-17215195
]
Huynh Quang Thao commented on KAFKA-10472:
--
If Wiki you mentioned is Confluence
chia7712 opened a new pull request #9449:
URL: https://github.com/apache/kafka/pull/9449
make it more readable :)
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documen
[
https://issues.apache.org/jira/browse/KAFKA-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sophie Blee-Goldman reassigned KAFKA-6687:
--
Assignee: Sophie Blee-Goldman
> Allow to read a topic multiple times
> ---
vvcephei commented on pull request #9448:
URL: https://github.com/apache/kafka/pull/9448#issuecomment-709715895
Hey @bbejeck , I don't suppose you have time to look at this? I figured I'd
ask you, since it needs to be cherry-picked to 2.7 as well.
-
vvcephei opened a new pull request #9448:
URL: https://github.com/apache/kafka/pull/9448
Add deprecation annotations to the methods replaced in KIP-478.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and
chia7712 commented on pull request #9401:
URL: https://github.com/apache/kafka/pull/9401#issuecomment-709709526
@hachikuji Could you please take a look?
This is an automated message from the Apache Git Service.
To respond to
chia7712 closed pull request #9355:
URL: https://github.com/apache/kafka/pull/9355
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
[
https://issues.apache.org/jira/browse/KAFKA-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215130#comment-17215130
]
John Roesler commented on KAFKA-10336:
--
Hi [~bbejeck] , sorry for the delay.
I do
[
https://issues.apache.org/jira/browse/KAFKA-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10336:
-
Priority: Critical (was: Blocker)
> Rolling upgrade with Suppression may throw exceptions
> ---
[
https://issues.apache.org/jira/browse/KAFKA-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10336:
-
Fix Version/s: (was: 2.7.0)
2.8.0
> Rolling upgrade with Suppression may
feyman2016 commented on a change in pull request #9270:
URL: https://github.com/apache/kafka/pull/9270#discussion_r506001704
##
File path:
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala
##
@@ -3789,6 +3844,41 @@ class GroupCoordinatorTest {
feyman2016 commented on a change in pull request #9270:
URL: https://github.com/apache/kafka/pull/9270#discussion_r506001704
##
File path:
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala
##
@@ -3789,6 +3844,41 @@ class GroupCoordinatorTest {
dongjinleekr commented on pull request #7891:
URL: https://github.com/apache/kafka/pull/7891#issuecomment-709690814
Rebased onto the latest trunk.
@hachikuji @bbejeck @kkonstantine Could you include this PR to 2.7?
Thi
jolshan opened a new pull request #9447:
URL: https://github.com/apache/kafka/pull/9447
This part of the code is a little confusing, so I thought I should fix this
comment.
When creating a builder for UpdateMetadataRequest, the topic name is set in
UpdateMetadataPartitionState. For
mjsax commented on pull request #9368:
URL: https://github.com/apache/kafka/pull/9368#issuecomment-709641131
Updated.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
[
https://issues.apache.org/jira/browse/KAFKA-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215066#comment-17215066
]
Ron Dagostino commented on KAFKA-10592:
---
Hi [~nizhikov]. I believe the problem ma
mjsax merged pull request #9384:
URL: https://github.com/apache/kafka/pull/9384
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mjsax commented on pull request #9432:
URL: https://github.com/apache/kafka/pull/9432#issuecomment-709635418
Follow up PR: https://github.com/apache/kafka/pull/9446
This is an automated message from the Apache Git Service.
To
ableegoldman commented on pull request #9446:
URL: https://github.com/apache/kafka/pull/9446#issuecomment-709625902
heads up @mjsax @guozhangwang
This is an automated message from the Apache Git Service.
To respond to the me
ableegoldman commented on a change in pull request #9446:
URL: https://github.com/apache/kafka/pull/9446#discussion_r505901801
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -704,8 +700,9 @@ private boolean
ableegoldman commented on a change in pull request #9446:
URL: https://github.com/apache/kafka/pull/9446#discussion_r505901990
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -1235,7 +1232,7 @@ private boolea
ableegoldman commented on a change in pull request #9446:
URL: https://github.com/apache/kafka/pull/9446#discussion_r505901265
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -434,7 +430,7 @@ private boolean
ableegoldman commented on a change in pull request #9446:
URL: https://github.com/apache/kafka/pull/9446#discussion_r505900644
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -330,75 +331,61 @@ public GroupAs
ableegoldman opened a new pull request #9446:
URL: https://github.com/apache/kafka/pull/9446
Minor followup to KAFKA-10559
I noticed that we were converting any and all TaskAssignmentException to the
INCOMPLETE_SOURCE_TOPIC_METADATA error code to shut down all the clients. Since
the
[
https://issues.apache.org/jira/browse/KAFKA-10559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-10559:
Affects Version/s: 2.7.0
> Don't shutdown the entire app upon TimeoutException during inte
[
https://issues.apache.org/jira/browse/KAFKA-10559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-10559:
Labels: (was: pull-request-available)
> Don't shutdown the entire app upon TimeoutExcept
mjsax commented on pull request #9432:
URL: https://github.com/apache/kafka/pull/9432#issuecomment-709619232
Thanks for the PR @vamossagar12!
No ideal to just remove the test instead of adjusting them, but we can do
this in a follow up PR. @ableegoldman told me she will take care of
mjsax merged pull request #9432:
URL: https://github.com/apache/kafka/pull/9432
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ableegoldman commented on pull request #9432:
URL: https://github.com/apache/kafka/pull/9432#issuecomment-709610635
LGTM
Looks like the Java 8 build may have stalled? The Java 11 & 15 builds both
passed a while ago
Th
rhauch commented on pull request #9425:
URL: https://github.com/apache/kafka/pull/9425#issuecomment-709604738
@kkonstantine thanks for the suggestion. I rebased and added a commit with
more unit tests for `AbstractHerder.generateResult(...)`.
--
abbccdda commented on a change in pull request #9103:
URL: https://github.com/apache/kafka/pull/9103#discussion_r505852939
##
File path: clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java
##
@@ -251,7 +253,8 @@ public Struct parseResponse(short version, ByteBuf
abbccdda commented on a change in pull request #9103:
URL: https://github.com/apache/kafka/pull/9103#discussion_r505842904
##
File path: clients/src/main/java/org/apache/kafka/common/protocol/Errors.java
##
@@ -338,7 +339,9 @@
INCONSISTENT_VOTER_SET(94, "Indicates that the
[
https://issues.apache.org/jira/browse/KAFKA-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214975#comment-17214975
]
Nikolay Izhikov commented on KAFKA-10592:
-
[~rndgstn] Why you unassign from me?
hachikuji commented on a change in pull request #9103:
URL: https://github.com/apache/kafka/pull/9103#discussion_r505765664
##
File path: clients/src/main/java/org/apache/kafka/common/protocol/Errors.java
##
@@ -338,7 +339,9 @@
INCONSISTENT_VOTER_SET(94, "Indicates that th
[
https://issues.apache.org/jira/browse/KAFKA-10602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantine Karantasis resolved KAFKA-10602.
Resolution: Fixed
> DLQ Reporter throws NPE when reporting from different
[
https://issues.apache.org/jira/browse/KAFKA-10602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantine Karantasis updated KAFKA-10602:
---
Fix Version/s: 2.6.1
2.7.0
> DLQ Reporter throws NPE when
kkonstantine merged pull request #9422:
URL: https://github.com/apache/kafka/pull/9422
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kkonstantine commented on pull request #9422:
URL: https://github.com/apache/kafka/pull/9422#issuecomment-709525339
The single failure in JDK 8 is unrelated.
This is an automated message from the Apache Git Service.
To respo
[
https://issues.apache.org/jira/browse/KAFKA-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantine Karantasis resolved KAFKA-10611.
Resolution: Fixed
> Merge log error to avoid double error
> --
[
https://issues.apache.org/jira/browse/KAFKA-10340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantine Karantasis updated KAFKA-10340:
---
Fix Version/s: 2.6.1
2.7.0
> Source connectors should rep
kkonstantine merged pull request #9149:
URL: https://github.com/apache/kafka/pull/9149
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kkonstantine commented on pull request #9149:
URL: https://github.com/apache/kafka/pull/9149#issuecomment-709501599
The failure on JDK 15 is unrelated
This is an automated message from the Apache Git Service.
To respond to th
gquintana opened a new pull request #9445:
URL: https://github.com/apache/kafka/pull/9445
Improve broker logs when a client authenticates using Plain mechanism and
wrong password.
This helps identifying wihich client is misconfigured.
--
[
https://issues.apache.org/jira/browse/KAFKA-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ron Dagostino reassigned KAFKA-10592:
-
Assignee: Manikumar
> system tests not running after python3 merge
> --
[
https://issues.apache.org/jira/browse/KAFKA-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ron Dagostino reassigned KAFKA-10592:
-
Assignee: (was: Nikolay Izhikov)
> system tests not running after python3 merge
> -
garyrussell opened a new pull request #9444:
URL: https://github.com/apache/kafka/pull/9444
Doc fix for KAFKA-8305; mention its alternate use.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build s
cyrusv commented on pull request #8918:
URL: https://github.com/apache/kafka/pull/8918#issuecomment-709483443
@rhauch, thanks for the review, I've made the requested changes.
This is an automated message from the Apache Git S
zhaohaidao commented on a change in pull request #9311:
URL: https://github.com/apache/kafka/pull/9311#discussion_r505722145
##
File path:
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala
##
@@ -381,9 +388,14 @@ class TransactionCoordinator(broker
zhaohaidao commented on a change in pull request #9311:
URL: https://github.com/apache/kafka/pull/9311#discussion_r505721580
##
File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala
##
@@ -671,6 +782,57 @@ class KafkaApisTest {
}
}
+ @Test
+ def
shou
abbccdda commented on a change in pull request #9270:
URL: https://github.com/apache/kafka/pull/9270#discussion_r505721807
##
File path:
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala
##
@@ -3789,6 +3844,41 @@ class GroupCoordinatorTest {
zhaohaidao commented on a change in pull request #9311:
URL: https://github.com/apache/kafka/pull/9311#discussion_r505722044
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
##
@@ -1438,7 +1455,8 @@ public void handleRespo
[
https://issues.apache.org/jira/browse/KAFKA-8531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214863#comment-17214863
]
Gary Russell commented on KAFKA-8531:
-
[~mjsax] Will do; I just didn't think it worth
rajinisivaram commented on pull request #9434:
URL: https://github.com/apache/kafka/pull/9434#issuecomment-709478153
@hachikuji Thanks for the review, have addressed the comments
This is an automated message from the Apache G
rajinisivaram commented on a change in pull request #9434:
URL: https://github.com/apache/kafka/pull/9434#discussion_r505716961
##
File path: core/src/main/scala/kafka/server/FetchSession.scala
##
@@ -77,7 +77,8 @@ class CachedPartition(val topic: String,
rajinisivaram commented on a change in pull request #9434:
URL: https://github.com/apache/kafka/pull/9434#discussion_r505716802
##
File path: core/src/main/scala/kafka/cluster/Partition.scala
##
@@ -1162,6 +1162,13 @@ class Partition(val topicPartition: TopicPartition,
loc
junrao merged pull request #9436:
URL: https://github.com/apache/kafka/pull/9436
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
zhaohaidao commented on a change in pull request #9311:
URL: https://github.com/apache/kafka/pull/9311#discussion_r505708598
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
##
@@ -1198,18 +1209,22 @@ boolean canBumpEpoch(
zhaohaidao commented on a change in pull request #9311:
URL: https://github.com/apache/kafka/pull/9311#discussion_r505707007
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
##
@@ -1198,18 +1209,22 @@ boolean canBumpEpoch(
[
https://issues.apache.org/jira/browse/KAFKA-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sophie Blee-Goldman reopened KAFKA-8940:
Assignee: (was: Guozhang Wang)
This failed again with
{code:java}
min fail: k
guozhangwang merged pull request #9416:
URL: https://github.com/apache/kafka/pull/9416
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/KAFKA-10613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214839#comment-17214839
]
Guozhang Wang edited comment on KAFKA-10613 at 10/15/20, 5:07 PM:
[
https://issues.apache.org/jira/browse/KAFKA-10613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-10613:
--
Affects Version/s: 2.1.0
2.2.0
2.3.0
[
https://issues.apache.org/jira/browse/KAFKA-10613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-10613:
--
Issue Type: Bug (was: Improvement)
> Broker should not set leader epoch if the list-offset re
[
https://issues.apache.org/jira/browse/KAFKA-10613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang resolved KAFKA-10613.
---
Fix Version/s: 2.7.0
Resolution: Fixed
> Broker should not set leader epoch if the li
[
https://issues.apache.org/jira/browse/KAFKA-10613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-10613:
--
Component/s: (was: streams)
core
> Broker should not set leader epoch if
[
https://issues.apache.org/jira/browse/KAFKA-10613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214839#comment-17214839
]
Guozhang Wang commented on KAFKA-10613:
---
When we introduce the new version 4 in li
guozhangwang commented on pull request #9438:
URL: https://github.com/apache/kafka/pull/9438#issuecomment-709462107
Cherry-picking to 2.7 as well since it has a reasonably large impact for any
old versioned clients. cc @bbejeck
guozhangwang commented on pull request #9438:
URL: https://github.com/apache/kafka/pull/9438#issuecomment-709461497
Updated the unit tests and merged to trunk.
This is an automated message from the Apache Git Service.
To resp
guozhangwang merged pull request #9438:
URL: https://github.com/apache/kafka/pull/9438
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rajinisivaram commented on a change in pull request #9434:
URL: https://github.com/apache/kafka/pull/9434#discussion_r505698143
##
File path: core/src/main/scala/kafka/cluster/Partition.scala
##
@@ -1162,6 +1162,13 @@ class Partition(val topicPartition: TopicPartition,
loc
tombentley commented on pull request #9441:
URL: https://github.com/apache/kafka/pull/9441#issuecomment-709457342
I assumed the scheduler would be using a heap to prioritize scheduled tasks,
and that wouldn't preserve the order of submitted tasks with the same scheduled
time. Since `System
[
https://issues.apache.org/jira/browse/KAFKA-10472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214831#comment-17214831
]
Huynh Quang Thao edited comment on KAFKA-10472 at 10/15/20, 4:52 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-10472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214831#comment-17214831
]
Huynh Quang Thao commented on KAFKA-10472:
--
Ì Wiki you mentioned is Confluence,
guozhangwang commented on pull request #9084:
URL: https://github.com/apache/kafka/pull/9084#issuecomment-709448776
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
hachikuji commented on pull request #9441:
URL: https://github.com/apache/kafka/pull/9441#issuecomment-709447330
@tombentley Actually I missed the holding of the `replicaStateChangeLock`
inside `ReplicaManager.becomeLeaderOrFollower`. So the reordering I suggested
above seems not possible.
guozhangwang closed pull request #9011:
URL: https://github.com/apache/kafka/pull/9011
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
hachikuji commented on a change in pull request #9434:
URL: https://github.com/apache/kafka/pull/9434#discussion_r505678344
##
File path: core/src/main/scala/kafka/cluster/Partition.scala
##
@@ -1162,6 +1162,13 @@ class Partition(val topicPartition: TopicPartition,
localLo
[
https://issues.apache.org/jira/browse/KAFKA-8531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214819#comment-17214819
]
Matthias J. Sax commented on KAFKA-8531:
[~grussell] of course. Note thought, tha
tombentley commented on pull request #9441:
URL: https://github.com/apache/kafka/pull/9441#issuecomment-709439774
@hachikuji, yes I see that although replica manager might be synchronized it
doesn't prevent the race. I was already working on introducing the epoch into
the group coordinator
[
https://issues.apache.org/jira/browse/KAFKA-10472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214818#comment-17214818
]
Matthias J. Sax commented on KAFKA-10472:
-
You need to create an account (note t
mimaison commented on pull request #9343:
URL: https://github.com/apache/kafka/pull/9343#issuecomment-709434733
@kkonstantine @rhauch can you take a look?
This is an automated message from the Apache Git Service.
To respond t
hachikuji commented on pull request #9441:
URL: https://github.com/apache/kafka/pull/9441#issuecomment-709432283
@tombentley Thanks for the patch. I think the problem is in the callback
inside `KafkaApis.handleLeaderAndIsrRequest`. With two concurrent
`LeaderAndIsr` requests, there is no g
rajinisivaram commented on pull request #9443:
URL: https://github.com/apache/kafka/pull/9443#issuecomment-709429966
Merging to trunk without waiting for builds since this is only changing a
system test.
This is an automated
rajinisivaram merged pull request #9443:
URL: https://github.com/apache/kafka/pull/9443
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rondagostino commented on pull request #9443:
URL: https://github.com/apache/kafka/pull/9443#issuecomment-709427515
@rajinisivaram could you review?
All 9 system tests pass:
http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-10-15--001.160277674
rondagostino opened a new pull request #9443:
URL: https://github.com/apache/kafka/pull/9443
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of test
mimaison commented on pull request #9313:
URL: https://github.com/apache/kafka/pull/9313#issuecomment-709415966
@scanterog I've rekicked the build
This is an automated message from the Apache Git Service.
To respond to the me
scanterog edited a comment on pull request #9313:
URL: https://github.com/apache/kafka/pull/9313#issuecomment-709412233
> Thanks @scanterog, the changes look good now. I've left a couple of very
minor comments that would be nice to address. I'll be happy to merge then
Thanks. There's
scanterog commented on pull request #9313:
URL: https://github.com/apache/kafka/pull/9313#issuecomment-709412233
> Thanks @scanterog, the changes look good now. I've left a couple of very
minor comments that would be nice to address. I'll be happy to merge then
Thanks. There's one te
lct45 edited a comment on pull request #9383:
URL: https://github.com/apache/kafka/pull/9383#issuecomment-709396656
> Why do we use a size-1 byte array instead of a single byte for this field?
@vvcephei There's a `RecordsFieldType` already created for `byte[]` but not
one for `byte`
[
https://issues.apache.org/jira/browse/KAFKA-8531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214773#comment-17214773
]
Gary Russell commented on KAFKA-8531:
-
The docs for default.replication.factor should
lct45 commented on pull request #9383:
URL: https://github.com/apache/kafka/pull/9383#issuecomment-709396656
> Why do we use a size-1 byte array instead of a single byte for this field?
@vvcephei There's a `RecordsFieldType` already created for `byte[]` but not
one for `byte` so to get t
ijuma merged pull request #9440:
URL: https://github.com/apache/kafka/pull/9440
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ijuma commented on pull request #9440:
URL: https://github.com/apache/kafka/pull/9440#issuecomment-709381048
JDK 15 flaky test failure is unrelated:
> StateDirectoryTest.shouldCleanupObsoleteStateDirectoriesOnlyOnce
Other builds passed.
---
cadonna commented on a change in pull request #9416:
URL: https://github.com/apache/kafka/pull/9416#discussion_r505588367
##
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##
@@ -908,6 +908,7 @@ class GroupCoordinator(val brokerId: Int,
* @par
cadonna commented on a change in pull request #9416:
URL: https://github.com/apache/kafka/pull/9416#discussion_r505572558
##
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##
@@ -908,6 +908,7 @@ class GroupCoordinator(val brokerId: Int,
* @par
[
https://issues.apache.org/jira/browse/KAFKA-7421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214685#comment-17214685
]
Goltseva Taisiia edited comment on KAFKA-7421 at 10/15/20, 1:30 PM:
---
1 - 100 of 117 matches
Mail list logo