[jira] [Created] (KAFKA-12889) log clean group consider empty log segment to avoid empty log left

2021-06-04 Thread qiang Liu (Jira)
qiang Liu created KAFKA-12889: - Summary: log clean group consider empty log segment to avoid empty log left Key: KAFKA-12889 URL: https://issues.apache.org/jira/browse/KAFKA-12889 Project: Kafka

[GitHub] [kafka] dajac opened a new pull request #10817: MINOR: Log member id of the leader when assignment are received

2021-06-04 Thread GitBox
dajac opened a new pull request #10817: URL: https://github.com/apache/kafka/pull/10817 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade not

[GitHub] [kafka] iamgd67 opened a new pull request #10818: KAFKA-12889: log clean group consider empty log segment to avoid empty log left

2021-06-04 Thread GitBox
iamgd67 opened a new pull request #10818: URL: https://github.com/apache/kafka/pull/10818 more detail see jira [KAFKA-12889](https://issues.apache.org/jira/browse/KAFKA-12889) to avoid log index 4 byte relative offset overflow, log cleaner group check log segments offset to make sur

[GitHub] [kafka] ijuma commented on a change in pull request #10794: KAFKA-12677: parse envelope response to check if not_controller error existed

2021-06-04 Thread GitBox
ijuma commented on a change in pull request #10794: URL: https://github.com/apache/kafka/pull/10794#discussion_r645343056 ## File path: build.gradle ## @@ -829,6 +829,7 @@ project(':core') { testImplementation(libs.jfreechart) { exclude group: 'junit', module: 'juni

[jira] [Commented] (KAFKA-12889) log clean group consider empty log segment to avoid empty log left

2021-06-04 Thread qiang Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357114#comment-17357114 ] qiang Liu commented on KAFKA-12889: --- create a pull request on github > log clean grou

[GitHub] [kafka] ijuma commented on pull request #10809: MINOR: Style fixes to KafkaRaftClient

2021-06-04 Thread GitBox
ijuma commented on pull request #10809: URL: https://github.com/apache/kafka/pull/10809#issuecomment-854423913 You don't have to revert it, but can you please get a committer approval? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] junrao commented on a change in pull request #10753: KAFKA-12803: Support reassigning partitions when in KRaft mode

2021-06-04 Thread GitBox
junrao commented on a change in pull request #10753: URL: https://github.com/apache/kafka/pull/10753#discussion_r644352228 ## File path: metadata/src/main/java/org/apache/kafka/controller/RemovingAndAddingReplicas.java ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [kafka] vitojeng commented on pull request #10668: MINOR: Apply try-with-resource to KafkaStreamsTest

2021-06-04 Thread GitBox
vitojeng commented on pull request #10668: URL: https://github.com/apache/kafka/pull/10668#issuecomment-853445357 Thanks @mjsax ! Please take a look.🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [kafka] guozhangwang commented on pull request #10552: KAFKA-12675: improve the sticky general assignor scalability and performance

2021-06-04 Thread GitBox
guozhangwang commented on pull request #10552: URL: https://github.com/apache/kafka/pull/10552#issuecomment-853411553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For qu

[GitHub] [kafka] guozhangwang commented on a change in pull request #10798: KAFKA-9168: Adding direct byte buffer support to rocksdb state store

2021-06-04 Thread GitBox
guozhangwang commented on a change in pull request #10798: URL: https://github.com/apache/kafka/pull/10798#discussion_r644356441 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -505,6 +506,14 @@ private void closeOpenIterato

[GitHub] [kafka] mjsax commented on a change in pull request #10731: KAFKA-12815: Update JavaDocs of ValueTransformerWithKey

2021-06-04 Thread GitBox
mjsax commented on a change in pull request #10731: URL: https://github.com/apache/kafka/pull/10731#discussion_r644507242 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableTransformValues.java ## @@ -158,7 +158,11 @@ public void init(final Pr

[GitHub] [kafka] showuon closed pull request #9672: MINOR: work in progress for Eos test(don't review)

2021-06-04 Thread GitBox
showuon closed pull request #9672: URL: https://github.com/apache/kafka/pull/9672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[jira] [Updated] (KAFKA-9929) Support reverse iterator on WindowStore

2021-06-04 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-9929: --- Labels: kip (was: needs-kip) > Support reverse iterator on WindowStore > ---

[jira] [Updated] (KAFKA-9929) Support reverse iterator on WindowStore

2021-06-04 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-9929: --- Description: KIP-617: [https://cwiki.apache.org/confluence/display/KAFKA/KIP-617%3A+Allow+Ka

[GitHub] [kafka] hachikuji commented on pull request #10804: KAFKA-12877: fix KRPC files with missing flexibleVersions annotations

2021-06-04 Thread GitBox
hachikuji commented on pull request #10804: URL: https://github.com/apache/kafka/pull/10804#issuecomment-854102079 The patch makes sense to me. One alternative to consider is to invert the flexible version specification. Basically get rid of "flexibleVersions" and instead add a "legacyVers

[GitHub] [kafka] mjsax commented on pull request #10668: MINOR: Apply try-with-resource to KafkaStreamsTest

2021-06-04 Thread GitBox
mjsax commented on pull request #10668: URL: https://github.com/apache/kafka/pull/10668#issuecomment-853547323 Thanks @vitojeng! Merged to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kafka] cmccabe merged pull request #10752: KAFKA-12620 Allocate Producer IDs in KRaft controller

2021-06-04 Thread GitBox
cmccabe merged pull request #10752: URL: https://github.com/apache/kafka/pull/10752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] vvcephei commented on a change in pull request #10731: KAFKA-12815: Update JavaDocs of ValueTransformerWithKey

2021-06-04 Thread GitBox
vvcephei commented on a change in pull request #10731: URL: https://github.com/apache/kafka/pull/10731#discussion_r645017943 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableTransformValues.java ## @@ -158,7 +158,11 @@ public void init(final

[GitHub] [kafka] dongjinleekr commented on pull request #10698: KAFKA-12770: introduce `checkstyleVersion` build option (for overriding CheckStyle project-defined dependency version)

2021-06-04 Thread GitBox
dongjinleekr commented on pull request #10698: URL: https://github.com/apache/kafka/pull/10698#issuecomment-853729405 Cool. Working Like a charm. `./gradlew checkstyleMain checkstyleTest`: ![1](https://user-images.githubusercontent.com/2375128/120622109-7bbdaa80-c499-11eb-97ea-11c

[GitHub] [kafka] showuon commented on a change in pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

2021-06-04 Thread GitBox
showuon commented on a change in pull request #10471: URL: https://github.com/apache/kafka/pull/10471#discussion_r644562533 ## File path: core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala ## @@ -151,7 +148,7 @@ class ReassignPartitionsIntegrat

[GitHub] [kafka] cadonna commented on pull request #10664: KAFKA-12749: Changelog topic config on suppressed KTable lost

2021-06-04 Thread GitBox
cadonna commented on pull request #10664: URL: https://github.com/apache/kafka/pull/10664#issuecomment-853748677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [kafka] mjsax merged pull request #10668: MINOR: Apply try-with-resource to KafkaStreamsTest

2021-06-04 Thread GitBox
mjsax merged pull request #10668: URL: https://github.com/apache/kafka/pull/10668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] cmccabe merged pull request #10787: KAFKA-12864: Move KafkaEventQueue into server-common

2021-06-04 Thread GitBox
cmccabe merged pull request #10787: URL: https://github.com/apache/kafka/pull/10787 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] showuon commented on pull request #10794: KAFKA-12677: parse envelope response to check if not_controller error existed

2021-06-04 Thread GitBox
showuon commented on pull request #10794: URL: https://github.com/apache/kafka/pull/10794#issuecomment-853761494 @hachikuji @mumrah @abbccdda @cmccabe , call for review. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] socutes commented on pull request #10749: KAFKA-12773: Use UncheckedIOException when wrapping IOException

2021-06-04 Thread GitBox
socutes commented on pull request #10749: URL: https://github.com/apache/kafka/pull/10749#issuecomment-853456306 @jsancio Code format fix completed! Thank you very much for your Review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [kafka] saddays commented on pull request #10781: MINOR: Reduce duplicate authentication check

2021-06-04 Thread GitBox
saddays commented on pull request #10781: URL: https://github.com/apache/kafka/pull/10781#issuecomment-853546556 > I don't think this is correct, since we are verifying the node authentication status after request being disconnected. Do you recall the reasoning for calling this API like th

[GitHub] [kafka] cadonna merged pull request #10664: KAFKA-12749: Changelog topic config on suppressed KTable lost

2021-06-04 Thread GitBox
cadonna merged pull request #10664: URL: https://github.com/apache/kafka/pull/10664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] mdedetrich commented on pull request #10652: KAFKA-9726 IdentityReplicationPolicy

2021-06-04 Thread GitBox
mdedetrich commented on pull request #10652: URL: https://github.com/apache/kafka/pull/10652#issuecomment-853663746 @mimaison As my PR at https://github.com/apache/kafka/pull/10648 has been superseded by this one, would it be possible to do a quick review of it? Afaik its ready and @ryanne

[GitHub] [kafka] showuon commented on pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

2021-06-04 Thread GitBox
showuon commented on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-853823700 @ijuma , please help review this PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [kafka] guozhangwang merged pull request #10552: KAFKA-12675: improve the sticky general assignor scalability and performance

2021-06-04 Thread GitBox
guozhangwang merged pull request #10552: URL: https://github.com/apache/kafka/pull/10552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [kafka] cadonna commented on a change in pull request #10664: KAFKA-12749: Changelog topic config on suppressed KTable lost

2021-06-04 Thread GitBox
cadonna commented on a change in pull request #10664: URL: https://github.com/apache/kafka/pull/10664#discussion_r644644247 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/suppress/EagerBufferConfigImpl.java ## @@ -28,13 +28,7 @@ private fin

[GitHub] [kafka] abbccdda merged pull request #10809: MINOR: Style fixes to KafkaRaftClient

2021-06-04 Thread GitBox
abbccdda merged pull request #10809: URL: https://github.com/apache/kafka/pull/10809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [kafka] ijuma commented on a change in pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

2021-06-04 Thread GitBox
ijuma commented on a change in pull request #10471: URL: https://github.com/apache/kafka/pull/10471#discussion_r644793036 ## File path: core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala ## @@ -128,11 +126,10 @@ class ReassignPartitionsIntegrat

[GitHub] [kafka] hachikuji commented on pull request #10793: KAFKA-12338: Remove useless MetadataParser

2021-06-04 Thread GitBox
hachikuji commented on pull request #10793: URL: https://github.com/apache/kafka/pull/10793#issuecomment-853495182 @dengziming Thanks for the patch. Looks like the parser has some additional validations which are not present in `MetadataRecordSerde`. Are any of them worth porting over? -

[GitHub] [kafka] hachikuji edited a comment on pull request #10804: KAFKA-12877: fix KRPC files with missing flexibleVersions annotations

2021-06-04 Thread GitBox
hachikuji edited a comment on pull request #10804: URL: https://github.com/apache/kafka/pull/10804#issuecomment-854102079 The patch makes sense to me. One alternative to consider is to inverting the flexible version specification. Basically get rid of "flexibleVersions" and instead add a "

[GitHub] [kafka] dejan2609 edited a comment on pull request #10698: KAFKA-12770: introduce `checkstyleVersion` build option (for overriding CheckStyle project-defined dependency version)

2021-06-04 Thread GitBox
dejan2609 edited a comment on pull request #10698: URL: https://github.com/apache/kafka/pull/10698#issuecomment-853408053 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. Fo

[GitHub] [kafka] showuon commented on a change in pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

2021-06-04 Thread GitBox
showuon commented on a change in pull request #10811: URL: https://github.com/apache/kafka/pull/10811#discussion_r644741927 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -731,10 +731,11 @@ object ConfigCommand extends Config { class ConfigCommandOpt

[GitHub] [kafka] cadonna commented on a change in pull request #10798: KAFKA-9168: Adding direct byte buffer support to rocksdb state store

2021-06-04 Thread GitBox
cadonna commented on a change in pull request #10798: URL: https://github.com/apache/kafka/pull/10798#discussion_r644552319 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -505,6 +506,14 @@ private void closeOpenIterators()

[jira] [Created] (KAFKA-12890) Consumer group stuck in `CompletingRebalance`

2021-06-04 Thread David Jacot (Jira)
David Jacot created KAFKA-12890: --- Summary: Consumer group stuck in `CompletingRebalance` Key: KAFKA-12890 URL: https://issues.apache.org/jira/browse/KAFKA-12890 Project: Kafka Issue Type: Bug

[GitHub] [kafka] showuon edited a comment on pull request #10794: KAFKA-12677: parse envelope response to check if not_controller error existed

2021-06-04 Thread GitBox
showuon edited a comment on pull request #10794: URL: https://github.com/apache/kafka/pull/10794#issuecomment-853761494 @hachikuji @mumrah @abbccdda @cmccabe , call for review since the tests keep failing. Thank you. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] showuon commented on pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

2021-06-04 Thread GitBox
showuon commented on pull request #10471: URL: https://github.com/apache/kafka/pull/10471#issuecomment-853665420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [kafka] jlprat commented on pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes

2021-06-04 Thread GitBox
jlprat commented on pull request #10784: URL: https://github.com/apache/kafka/pull/10784#issuecomment-854078089 Any chance any of you has time to check this? cc @mjsax @vvcephei @guozhangwang Thanks! -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [kafka] mdedetrich edited a comment on pull request #10648: KAFKA-9726: Add IdentityReplicationPolicy for MM2

2021-06-04 Thread GitBox
mdedetrich edited a comment on pull request #10648: URL: https://github.com/apache/kafka/pull/10648#issuecomment-835180661 @mimaison I have just renamed `LegacyReplicationPolicy` to `IdentityReplicationPolicy` and forced pushed the branch. @ryannedolan I will have a look at https://

[GitHub] [kafka] mjsax commented on a change in pull request #10810: MINOR: Improve Kafka Streams JavaDocs with regard to record metadata

2021-06-04 Thread GitBox
mjsax commented on a change in pull request #10810: URL: https://github.com/apache/kafka/pull/10810#discussion_r644509797 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java ## @@ -158,32 +165,52 @@ Cancellable schedule(final Duration i

[GitHub] [kafka] vamossagar12 commented on a change in pull request #10798: KAFKA-9168: Adding direct byte buffer support to rocksdb state store

2021-06-04 Thread GitBox
vamossagar12 commented on a change in pull request #10798: URL: https://github.com/apache/kafka/pull/10798#discussion_r644616944 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -505,6 +506,14 @@ private void closeOpenIterato

[GitHub] [kafka] guozhangwang commented on pull request #10646: KAFKA-8897 Follow-up: Consolidate the global state stores

2021-06-04 Thread GitBox
guozhangwang commented on pull request #10646: URL: https://github.com/apache/kafka/pull/10646#issuecomment-854262242 @cadonna 1. Filed a ticket for KStreams to enforce shutdown on illegal-X exceptions as a future work. 2. Let the global state mgr to do closing before throwing il

[GitHub] [kafka] tombentley commented on a change in pull request #9441: KAFKA-10614: Ensure group state (un)load is executed in the submitted order

2021-06-04 Thread GitBox
tombentley commented on a change in pull request #9441: URL: https://github.com/apache/kafka/pull/9441#discussion_r644571665 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -279,30 +279,33 @@ class KafkaApis(val requestChannel: RequestChannel, new

[GitHub] [kafka] vvcephei commented on a change in pull request #10810: MINOR: Improve Kafka Streams JavaDocs with regard to record metadata

2021-06-04 Thread GitBox
vvcephei commented on a change in pull request #10810: URL: https://github.com/apache/kafka/pull/10810#discussion_r645023265 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java ## @@ -158,32 +165,52 @@ Cancellable schedule(final Duratio

[GitHub] [kafka] cadonna commented on a change in pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

2021-06-04 Thread GitBox
cadonna commented on a change in pull request #10428: URL: https://github.com/apache/kafka/pull/10428#discussion_r644711679 ## File path: core/src/main/java/kafka/metrics/FilteringJmxReporter.java ## @@ -51,7 +50,7 @@ public void updatePredicate(Predicate predicate) {

[GitHub] [kafka] dongjinleekr commented on a change in pull request #10507: KAFKA-8410: Migrating stateful operators to new Processor API

2021-06-04 Thread GitBox
dongjinleekr commented on a change in pull request #10507: URL: https://github.com/apache/kafka/pull/10507#discussion_r644545454 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/AbstractStream.java ## @@ -16,6 +16,10 @@ */ package org.apache.ka

[GitHub] [kafka] dengziming commented on pull request #10793: KAFKA-12338: Remove useless MetadataParser

2021-06-04 Thread GitBox
dengziming commented on pull request #10793: URL: https://github.com/apache/kafka/pull/10793#issuecomment-853911013 @hachikuji Thanks for the remindings, I think the validations in `read` are useful and I copied them to `MetadataRecordSerde`, but not sure whether the `DEFAULT_FRAME_VERSION

[GitHub] [kafka] guozhangwang commented on a change in pull request #10609: KAFKA-12648: Pt. 1 - Add NamedTopology to protocol and state directory structure

2021-06-04 Thread GitBox
guozhangwang commented on a change in pull request #10609: URL: https://github.com/apache/kafka/pull/10609#discussion_r644343550 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/SubscriptionInfo.java ## @@ -125,6 +130,29 @@ public int

[GitHub] [kafka] dejan2609 commented on pull request #10698: KAFKA-12770: introduce `checkstyleVersion` build option (for overriding CheckStyle project-defined dependency version)

2021-06-04 Thread GitBox
dejan2609 commented on pull request #10698: URL: https://github.com/apache/kafka/pull/10698#issuecomment-853408053 Just tagging @ijuma here again (to come back up to the surface). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [kafka] dengziming commented on a change in pull request #10793: KAFKA-12338: Remove useless MetadataParser

2021-06-04 Thread GitBox
dengziming commented on a change in pull request #10793: URL: https://github.com/apache/kafka/pull/10793#discussion_r645205625 ## File path: server-common/src/main/java/org/apache/kafka/server/common/serialization/AbstractApiMessageSerde.java ## @@ -69,16 +76,42 @@ public void

[GitHub] [kafka] dejan2609 commented on pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

2021-06-04 Thread GitBox
dejan2609 commented on pull request #10428: URL: https://github.com/apache/kafka/pull/10428#issuecomment-853411084 Shameless plug and related to CheckStyle: ⏩ #10698 (needs a review / approval). -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [kafka] hachikuji commented on a change in pull request #10793: KAFKA-12338: Remove useless MetadataParser

2021-06-04 Thread GitBox
hachikuji commented on a change in pull request #10793: URL: https://github.com/apache/kafka/pull/10793#discussion_r645084226 ## File path: server-common/src/main/java/org/apache/kafka/server/common/serialization/AbstractApiMessageSerde.java ## @@ -69,16 +76,42 @@ public void

[GitHub] [kafka] dongjinleekr commented on pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

2021-06-04 Thread GitBox
dongjinleekr commented on pull request #10428: URL: https://github.com/apache/kafka/pull/10428#issuecomment-853821984 @cadonna Here it is, with the following: 1. making server-common to ignore import orders. 2. rebasing onto the latest trunk. +1. It seems like we can make the eclipse

[GitHub] [kafka] ryannedolan commented on pull request #10652: KAFKA-9726 IdentityReplicationPolicy

2021-06-04 Thread GitBox
ryannedolan commented on pull request #10652: URL: https://github.com/apache/kafka/pull/10652#issuecomment-854215843 None of the failing tests are related. Ready to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] dongjinleekr commented on pull request #10678: TRIVIAL: Fix type inconsistencies, unthrown exceptions, etc

2021-06-04 Thread GitBox
dongjinleekr commented on pull request #10678: URL: https://github.com/apache/kafka/pull/10678#issuecomment-853838170 @ableegoldman Could you have a look? :pray: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] ijuma edited a comment on pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

2021-06-04 Thread GitBox
ijuma edited a comment on pull request #10471: URL: https://github.com/apache/kafka/pull/10471#issuecomment-854399316 Unrelated test failures: > Build / JDK 11 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic() > Build / JDK 11 and Scala 2.13

[GitHub] [kafka] ijuma commented on a change in pull request #10805: KAFKA-12436 KIP-720 Deprecate MirrorMaker v1

2021-06-04 Thread GitBox
ijuma commented on a change in pull request #10805: URL: https://github.com/apache/kafka/pull/10805#discussion_r645317670 ## File path: core/src/main/scala/kafka/tools/MirrorMaker.scala ## @@ -58,7 +58,10 @@ import scala.util.{Failure, Success, Try} *enable.auto.c

[GitHub] [kafka] ijuma commented on pull request #10809: MINOR: Style fixes to KafkaRaftClient

2021-06-04 Thread GitBox
ijuma commented on pull request #10809: URL: https://github.com/apache/kafka/pull/10809#issuecomment-854385011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries a

[GitHub] [kafka] ijuma commented on pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

2021-06-04 Thread GitBox
ijuma commented on pull request #10471: URL: https://github.com/apache/kafka/pull/10471#issuecomment-854399316 Unrelated test failures: > Build / JDK 11 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic() | 16 sec | 1 > -- | -- | -- > Buil

[GitHub] [kafka] mjsax commented on pull request #10813: KAFKA-9559: Change default serde to be `null`

2021-06-04 Thread GitBox
mjsax commented on pull request #10813: URL: https://github.com/apache/kafka/pull/10813#issuecomment-854379331 How confident are we, that we covered most cases to avoid NPE and throw ConfigException? Seems it's still many places that we need to cover, and I am wondering if we follow the ri

[GitHub] [kafka] mjsax commented on a change in pull request #10813: KAFKA-9559: Change default serde to be `null`

2021-06-04 Thread GitBox
mjsax commented on a change in pull request #10813: URL: https://github.com/apache/kafka/pull/10813#discussion_r645299252 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/ChangedSerializer.java ## @@ -40,7 +40,10 @@ public ChangedSerializer(final

[GitHub] [kafka] abbccdda commented on pull request #10809: MINOR: Style fixes to KafkaRaftClient

2021-06-04 Thread GitBox
abbccdda commented on pull request #10809: URL: https://github.com/apache/kafka/pull/10809#issuecomment-854402436 @ijuma That's a good call, should I revert it? It was just a styling change PR. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] ijuma commented on a change in pull request #10794: KAFKA-12677: parse envelope response to check if not_controller error existed

2021-06-04 Thread GitBox
ijuma commented on a change in pull request #10794: URL: https://github.com/apache/kafka/pull/10794#discussion_r645318499 ## File path: build.gradle ## @@ -829,6 +829,7 @@ project(':core') { testImplementation(libs.jfreechart) { exclude group: 'junit', module: 'juni

[GitHub] [kafka] showuon commented on a change in pull request #10794: KAFKA-12677: parse envelope response to check if not_controller error existed

2021-06-04 Thread GitBox
showuon commented on a change in pull request #10794: URL: https://github.com/apache/kafka/pull/10794#discussion_r645321936 ## File path: build.gradle ## @@ -829,6 +829,7 @@ project(':core') { testImplementation(libs.jfreechart) { exclude group: 'junit', module: 'ju

[GitHub] [kafka] socutes commented on pull request #10815: KAFKA-12885: Add the --timeout property to kafka-leader-election.sh

2021-06-04 Thread GitBox
socutes commented on pull request #10815: URL: https://github.com/apache/kafka/pull/10815#issuecomment-854395260 @showuon , please help review this PR. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [kafka] ijuma merged pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

2021-06-04 Thread GitBox
ijuma merged pull request #10471: URL: https://github.com/apache/kafka/pull/10471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] ijuma commented on pull request #9302: KAFKA-10149: Allow auto preferred leader election when partitions are reassigning

2021-06-04 Thread GitBox
ijuma commented on pull request #9302: URL: https://github.com/apache/kafka/pull/9302#issuecomment-854395748 Is this still relevant? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] jlprat commented on a change in pull request #10810: MINOR: Improve Kafka Streams JavaDocs with regard to record metadata

2021-06-04 Thread GitBox
jlprat commented on a change in pull request #10810: URL: https://github.com/apache/kafka/pull/10810#discussion_r645405935 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java ## @@ -158,32 +165,52 @@ Cancellable schedule(final Duration

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

2021-06-04 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r643465477 ## File path: core/src/test/scala/unit/kafka/log/LocalLogTest.scala ## @@ -0,0 +1,734 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

2021-06-04 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r645434947 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1500,50 +1325,67 @@ class Log(@volatile private var _dir: File, } } -delete

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

2021-06-04 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r645437282 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1500,50 +1325,67 @@ class Log(@volatile private var _dir: File, } } -delete

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

2021-06-04 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r645437580 ## File path: core/src/test/scala/unit/kafka/log/LocalLogTest.scala ## @@ -0,0 +1,734 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

2021-06-04 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r645439534 ## File path: core/src/test/scala/unit/kafka/log/LocalLogTest.scala ## @@ -0,0 +1,734 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

2021-06-04 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r645439645 ## File path: core/src/test/scala/unit/kafka/log/LocalLogTest.scala ## @@ -0,0 +1,734 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

2021-06-04 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r645441207 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -246,17 +262,17 @@ object LogLoader extends Logging { return fn } catch

[jira] [Created] (KAFKA-12891) Add --files and --file-separator options to the ConsoleProducer

2021-06-04 Thread Wenbing Shen (Jira)
Wenbing Shen created KAFKA-12891: Summary: Add --files and --file-separator options to the ConsoleProducer Key: KAFKA-12891 URL: https://issues.apache.org/jira/browse/KAFKA-12891 Project: Kafka

[GitHub] [kafka] sarwarbhuiyan commented on pull request #7499: KAFKA-5682: Include partitions in exceptions raised during consumer record deserialization/validation

2021-06-04 Thread GitBox
sarwarbhuiyan commented on pull request #7499: URL: https://github.com/apache/kafka/pull/7499#issuecomment-854551022 KIP passed voting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [kafka] kowshik commented on pull request #10280: KAFKA-12554: Refactor Log layer

2021-06-04 Thread GitBox
kowshik commented on pull request #10280: URL: https://github.com/apache/kafka/pull/10280#issuecomment-854616475 @junrao Thanks for the review! I've addressed the comments in e201295e03e0ea8a7102983888d1a7afc66d384a, and have also rebased this PR onto most recent commit in `trunk`. It is r

[GitHub] [kafka] kowshik edited a comment on pull request #10280: KAFKA-12554: Refactor Log layer

2021-06-04 Thread GitBox
kowshik edited a comment on pull request #10280: URL: https://github.com/apache/kafka/pull/10280#issuecomment-854616475 @junrao Thanks for the review! I've addressed your comments in e201295e03e0ea8a7102983888d1a7afc66d384a, and have also rebased this PR onto most recent commit in `trunk`.

[GitHub] [kafka] kowshik edited a comment on pull request #10280: KAFKA-12554: Refactor Log layer

2021-06-04 Thread GitBox
kowshik edited a comment on pull request #10280: URL: https://github.com/apache/kafka/pull/10280#issuecomment-854616475 @junrao Thanks for the review! I've addressed your comments in e201295e03e0ea8a7102983888d1a7afc66d384a, and have also rebased this PR onto most recent commit in `trunk`.

[GitHub] [kafka] kowshik opened a new pull request #10819: MINOR: LogLoader: Add log identifier at few missing areas

2021-06-04 Thread GitBox
kowshik opened a new pull request #10819: URL: https://github.com/apache/kafka/pull/10819 While reading the code, I noticed that `LogLoader` had a few points where the log identifier was not printed as part of the log message. I've fixed it in this PR. **Tests:** Rely on existing

[GitHub] [kafka] kowshik commented on pull request #10819: MINOR: LogLoader: Add log identifier in few missing areas

2021-06-04 Thread GitBox
kowshik commented on pull request #10819: URL: https://github.com/apache/kafka/pull/10819#issuecomment-854621853 @junrao Please could you help review this small change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (KAFKA-12847) Dockerfile needed for kafka system tests needs changes

2021-06-04 Thread Abhijit Mane (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357273#comment-17357273 ] Abhijit Mane commented on KAFKA-12847: -- Thanks [~chia7712] I guess my detailed exp

[GitHub] [kafka] showuon commented on a change in pull request #10794: KAFKA-12677: parse envelope response to check if not_controller error existed

2021-06-04 Thread GitBox
showuon commented on a change in pull request #10794: URL: https://github.com/apache/kafka/pull/10794#discussion_r645522757 ## File path: build.gradle ## @@ -829,6 +829,7 @@ project(':core') { testImplementation(libs.jfreechart) { exclude group: 'junit', module: 'ju

[jira] [Created] (KAFKA-12892) InvalidACLException thrown in tests caused jenkins build unstable

2021-06-04 Thread Luke Chen (Jira)
Luke Chen created KAFKA-12892: - Summary: InvalidACLException thrown in tests caused jenkins build unstable Key: KAFKA-12892 URL: https://issues.apache.org/jira/browse/KAFKA-12892 Project: Kafka

[GitHub] [kafka] showuon opened a new pull request #10820: KAFKA-12892: disable testChrootExistsAndRootIsLocked

2021-06-04 Thread GitBox
showuon opened a new pull request #10820: URL: https://github.com/apache/kafka/pull/10820 Detail is described in https://issues.apache.org/jira/browse/KAFKA-12892. Thanks. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Ver

[GitHub] [kafka] showuon commented on pull request #10820: KAFKA-12892: disable testChrootExistsAndRootIsLocked

2021-06-04 Thread GitBox
showuon commented on pull request #10820: URL: https://github.com/apache/kafka/pull/10820#issuecomment-854722099 @ijuma @omkreddy , could you take a look? This test keeps failing the jenkins build, I think we should disable it before we know how to avoid breaking jenkins build. Thanks. -

[GitHub] [kafka] ijuma commented on pull request #10820: KAFKA-12892: disable testChrootExistsAndRootIsLocked

2021-06-04 Thread GitBox
ijuma commented on pull request #10820: URL: https://github.com/apache/kafka/pull/10820#issuecomment-854724264 @omkreddy I will leave it to you to review this since you reviewed the original PR. If this is failing often, it makes sense to disable temporarily, but we need a JIRA to fix the

[jira] [Updated] (KAFKA-12892) InvalidACLException thrown in tests caused jenkins build unstable

2021-06-04 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-12892: -- Description: In KAFKA-12866, we fixed the issue that Kafka required ZK root access even when using a

[GitHub] [kafka] showuon commented on pull request #10820: KAFKA-12892: disable testChrootExistsAndRootIsLocked

2021-06-04 Thread GitBox
showuon commented on pull request #10820: URL: https://github.com/apache/kafka/pull/10820#issuecomment-854725411 @ijuma , KAFKA-12892 is the JIRA ticket. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (KAFKA-12892) InvalidACLException thrown in tests caused jenkins build unstable

2021-06-04 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357362#comment-17357362 ] Luke Chen commented on KAFKA-12892: --- I tried to set the original root acl back, but it

[jira] [Created] (KAFKA-12893) MM2 fails to replicate if starting two+ nodes same time

2021-06-04 Thread Tommi Vainikainen (Jira)
Tommi Vainikainen created KAFKA-12893: - Summary: MM2 fails to replicate if starting two+ nodes same time Key: KAFKA-12893 URL: https://issues.apache.org/jira/browse/KAFKA-12893 Project: Kafka

[jira] [Commented] (KAFKA-12893) MM2 fails to replicate if starting two+ nodes same time

2021-06-04 Thread Daniel Urban (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357372#comment-17357372 ] Daniel Urban commented on KAFKA-12893: -- You might be hitting the issue of MM2 not r

[jira] [Created] (KAFKA-12894) KIP-750: Drop support for Java 8 in Kafka 4.0 (deprecate in 3.0)

2021-06-04 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-12894: --- Summary: KIP-750: Drop support for Java 8 in Kafka 4.0 (deprecate in 3.0) Key: KAFKA-12894 URL: https://issues.apache.org/jira/browse/KAFKA-12894 Project: Kafka

[jira] [Created] (KAFKA-12895) KIP-751: Drop support for Scala 2.12 in Kafka 4.0 (deprecate in 3.0)

2021-06-04 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-12895: --- Summary: KIP-751: Drop support for Scala 2.12 in Kafka 4.0 (deprecate in 3.0) Key: KAFKA-12895 URL: https://issues.apache.org/jira/browse/KAFKA-12895 Project: Kafka

[jira] [Created] (KAFKA-12896) Group rebalance loop caused by repeated group leader JoinGroups

2021-06-04 Thread Lucas Bradstreet (Jira)
Lucas Bradstreet created KAFKA-12896: Summary: Group rebalance loop caused by repeated group leader JoinGroups Key: KAFKA-12896 URL: https://issues.apache.org/jira/browse/KAFKA-12896 Project: Kafk

  1   2   >