dajac commented on pull request #10743:
URL: https://github.com/apache/kafka/pull/10743#issuecomment-855188637
@mimaison Could you briefly describe the core changes that you have made in
the PR? That would be helpful to dive into it. Thanks!
--
This is an automated message from the
gonzur commented on pull request #10824:
URL: https://github.com/apache/kafka/pull/10824#issuecomment-855168047
@mjsax pull request is up. Will be back later if there are any problems with
the build.
--
This is an automated message from the Apache Git Service.
To respond to the
gonzur opened a new pull request #10824:
URL: https://github.com/apache/kafka/pull/10824
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
Now factors in
socutes commented on a change in pull request #10815:
URL: https://github.com/apache/kafka/pull/10815#discussion_r645914909
##
File path: core/src/main/scala/kafka/admin/LeaderElectionCommand.scala
##
@@ -283,6 +284,14 @@ private final class LeaderElectionCommandOptions(args:
showuon commented on pull request #10820:
URL: https://github.com/apache/kafka/pull/10820#issuecomment-855153747
Triggering another test to make sure disabling the test won't break the
build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
junrao commented on a change in pull request #10823:
URL: https://github.com/apache/kafka/pull/10823#discussion_r645905158
##
File path:
metadata/src/main/java/org/apache/kafka/controller/StripedReplicaPlacer.java
##
@@ -412,14 +433,9 @@ public StripedReplicaPlacer(Random
hachikuji commented on a change in pull request #10793:
URL: https://github.com/apache/kafka/pull/10793#discussion_r645883390
##
File path:
server-common/src/main/java/org/apache/kafka/server/common/serialization/AbstractApiMessageSerde.java
##
@@ -69,16 +75,44 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-12370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-12370:
--
Description:
Currently in KafkaStreams we have two groups of metadata getter:
1.
{code}
guozhangwang commented on pull request #9441:
URL: https://github.com/apache/kafka/pull/9441#issuecomment-855018136
Made another pass on the patch. LGTM! I think we can merge after resolved
the conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the
guozhangwang commented on a change in pull request #9441:
URL: https://github.com/apache/kafka/pull/9441#discussion_r645870784
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -279,30 +279,33 @@ class KafkaApis(val requestChannel: RequestChannel,
guozhangwang commented on a change in pull request #10731:
URL: https://github.com/apache/kafka/pull/10731#discussion_r645869785
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableTransformValues.java
##
@@ -158,7 +158,11 @@ public void
rondagostino opened a new pull request #10823:
URL: https://github.com/apache/kafka/pull/10823
https://github.com/apache/kafka/pull/10494 introduced a bug in the KRaft
controller where the controller will loop forever in `StripedReplicaPlacer`
trying to identify the racks on which to
[
https://issues.apache.org/jira/browse/KAFKA-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ron Dagostino updated KAFKA-12897:
--
Description: https://github.com/apache/kafka/pull/10494 introduced a bug in
the KRaft
[
https://issues.apache.org/jira/browse/KAFKA-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ron Dagostino updated KAFKA-12897:
--
Summary: KRaft Controller cannot create topic with multiple partitions on a
single broker
mumrah commented on pull request #10809:
URL: https://github.com/apache/kafka/pull/10809#issuecomment-854951503
@ijuma i'll send something out on the devs list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
ijuma commented on pull request #10809:
URL: https://github.com/apache/kafka/pull/10809#issuecomment-854951206
@mumrah We haven't and it would be good to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mumrah edited a comment on pull request #10809:
URL: https://github.com/apache/kafka/pull/10809#issuecomment-854947155
@ijuma we should be able to configure the repo to require an approval from a
committer for `trunk` PRs, have we looked into this? Similarly, we can set up
CODEOWNERS for
mumrah commented on pull request #10809:
URL: https://github.com/apache/kafka/pull/10809#issuecomment-854947155
@ijuma we should be able to configure the repo to require an approval from a
committer, have we looked into this? Similarly, we can set up CODEOWNERS for
different areas of the
kpatelatwork opened a new pull request #10822:
URL: https://github.com/apache/kafka/pull/10822
Implements
[KIP-745](https://cwiki.apache.org/confluence/display/KAFKA/KIP-745%3A+Connect+API+to+restart+connector+and+tasks)
Testing strategy
- [ ] Unit tests added for all possible
[
https://issues.apache.org/jira/browse/KAFKA-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357532#comment-17357532
]
Chia-Ping Tsai commented on KAFKA-12847:
{quote}
string literal "UID" itself whose value can't
[
https://issues.apache.org/jira/browse/KAFKA-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-12847:
---
Attachment: 截圖 2021-06-05 上午1.53.17.png
> Dockerfile needed for kafka system tests needs
[
https://issues.apache.org/jira/browse/KAFKA-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357529#comment-17357529
]
Chia-Ping Tsai commented on KAFKA-12847:
{quote}
Are you able to run sysTests as is after
mimaison commented on pull request #10743:
URL: https://github.com/apache/kafka/pull/10743#issuecomment-854895087
@rajinisivaram @tombentley @dajac Can you take a look? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
soarez opened a new pull request #10821:
URL: https://github.com/apache/kafka/pull/10821
Having the `testChrootExistsAndRootIsLocked` test in a separate
`ZookeeperTestHarness` isn't enough to prevent the ACL changes to the ZK root
from affecting other integration tests. So instead, let's
junrao merged pull request #10819:
URL: https://github.com/apache/kafka/pull/10819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
hachikuji commented on pull request #10814:
URL: https://github.com/apache/kafka/pull/10814#issuecomment-854841705
@abbccdda Thanks. Fallout from the upgrade to argparse4j. I will push
another commit today to fix it.
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/KAFKA-12896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357446#comment-17357446
]
David Jacot commented on KAFKA-12896:
-
I have found a bug while investigating this one:
[
https://issues.apache.org/jira/browse/KAFKA-12896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot reassigned KAFKA-12896:
---
Assignee: David Jacot
> Group rebalance loop caused by repeated group leader JoinGroups
>
David Jacot created KAFKA-12898:
---
Summary: Owned partitions in the subscription must be sorted
Key: KAFKA-12898
URL: https://issues.apache.org/jira/browse/KAFKA-12898
Project: Kafka
Issue
guozhangwang merged pull request #10646:
URL: https://github.com/apache/kafka/pull/10646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
wenbingshen commented on a change in pull request #10815:
URL: https://github.com/apache/kafka/pull/10815#discussion_r645660141
##
File path: core/src/main/scala/kafka/admin/LeaderElectionCommand.scala
##
@@ -283,6 +284,14 @@ private final class
satishd commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r645659750
##
File path:
raft/src/main/java/org/apache/kafka/raft/metadata/AbstractApiMessageSerde.java
##
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/KAFKA-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ron Dagostino updated KAFKA-12897:
--
Description: https://github.com/apache/kafka/pull/10494 introduced a bug in
the KRaft
[
https://issues.apache.org/jira/browse/KAFKA-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ron Dagostino updated KAFKA-12897:
--
Summary: KRaft Controller cannot create topic with replication factor
greater than number of
[
https://issues.apache.org/jira/browse/KAFKA-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ron Dagostino updated KAFKA-12897:
--
Description: https://github.com/apache/kafka/pull/10494 introduced a bug in
the KRaft
[
https://issues.apache.org/jira/browse/KAFKA-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ron Dagostino updated KAFKA-12897:
--
Summary: KRaft Controller cannot create topic with more replicas than racks
(was: KRaft
Ron Dagostino created KAFKA-12897:
-
Summary: KRaft Controller cannot create topic with more partitions
than racks
Key: KAFKA-12897
URL: https://issues.apache.org/jira/browse/KAFKA-12897
Project:
ryannedolan commented on a change in pull request #10805:
URL: https://github.com/apache/kafka/pull/10805#discussion_r645646248
##
File path: core/src/main/scala/kafka/tools/MirrorMaker.scala
##
@@ -58,7 +58,10 @@ import scala.util.{Failure, Success, Try}
*
[
https://issues.apache.org/jira/browse/KAFKA-12892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez reassigned KAFKA-12892:
---
Assignee: Igor Soarez
> InvalidACLException thrown in tests caused jenkins build unstable
Lucas Bradstreet created KAFKA-12896:
Summary: Group rebalance loop caused by repeated group leader
JoinGroups
Key: KAFKA-12896
URL: https://issues.apache.org/jira/browse/KAFKA-12896
Project:
Ismael Juma created KAFKA-12895:
---
Summary: KIP-751: Drop support for Scala 2.12 in Kafka 4.0
(deprecate in 3.0)
Key: KAFKA-12895
URL: https://issues.apache.org/jira/browse/KAFKA-12895
Project: Kafka
Ismael Juma created KAFKA-12894:
---
Summary: KIP-750: Drop support for Java 8 in Kafka 4.0 (deprecate
in 3.0)
Key: KAFKA-12894
URL: https://issues.apache.org/jira/browse/KAFKA-12894
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-12893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357372#comment-17357372
]
Daniel Urban commented on KAFKA-12893:
--
You might be hitting the issue of MM2 not running the
Tommi Vainikainen created KAFKA-12893:
-
Summary: MM2 fails to replicate if starting two+ nodes same time
Key: KAFKA-12893
URL: https://issues.apache.org/jira/browse/KAFKA-12893
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-12892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357362#comment-17357362
]
Luke Chen commented on KAFKA-12892:
---
I tried to set the original root acl back, but it failed. That
showuon commented on pull request #10820:
URL: https://github.com/apache/kafka/pull/10820#issuecomment-854725411
@ijuma , KAFKA-12892 is the JIRA ticket. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
[
https://issues.apache.org/jira/browse/KAFKA-12892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-12892:
--
Description:
In KAFKA-12866, we fixed the issue that Kafka required ZK root access even when
using a
ijuma commented on pull request #10820:
URL: https://github.com/apache/kafka/pull/10820#issuecomment-854724264
@omkreddy I will leave it to you to review this since you reviewed the
original PR. If this is failing often, it makes sense to disable temporarily,
but we need a JIRA to fix the
showuon commented on pull request #10820:
URL: https://github.com/apache/kafka/pull/10820#issuecomment-854722099
@ijuma @omkreddy , could you take a look? This test keeps failing the
jenkins build, I think we should disable it before we know how to avoid
breaking jenkins build. Thanks.
showuon opened a new pull request #10820:
URL: https://github.com/apache/kafka/pull/10820
Detail is described in https://issues.apache.org/jira/browse/KAFKA-12892.
Thanks.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ]
Luke Chen created KAFKA-12892:
-
Summary: InvalidACLException thrown in tests caused jenkins build
unstable
Key: KAFKA-12892
URL: https://issues.apache.org/jira/browse/KAFKA-12892
Project: Kafka
showuon commented on a change in pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#discussion_r645522757
##
File path: build.gradle
##
@@ -829,6 +829,7 @@ project(':core') {
testImplementation(libs.jfreechart) {
exclude group: 'junit', module:
[
https://issues.apache.org/jira/browse/KAFKA-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17357273#comment-17357273
]
Abhijit Mane commented on KAFKA-12847:
--
Thanks [~chia7712]
I guess my detailed explanation was not
kowshik commented on pull request #10819:
URL: https://github.com/apache/kafka/pull/10819#issuecomment-854621853
@junrao Please could you help review this small change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kowshik opened a new pull request #10819:
URL: https://github.com/apache/kafka/pull/10819
While reading the code, I noticed that `LogLoader` had a few points where
the log identifier was not printed as part of the log message. I've fixed it in
this PR.
**Tests:**
Rely on
kowshik edited a comment on pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#issuecomment-854616475
@junrao Thanks for the review! I've addressed your comments in
e201295e03e0ea8a7102983888d1a7afc66d384a, and have also rebased this PR onto
most recent commit in
kowshik edited a comment on pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#issuecomment-854616475
@junrao Thanks for the review! I've addressed your comments in
e201295e03e0ea8a7102983888d1a7afc66d384a, and have also rebased this PR onto
most recent commit in
kowshik commented on pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#issuecomment-854616475
@junrao Thanks for the review! I've addressed the comments in
e201295e03e0ea8a7102983888d1a7afc66d384a, and have also rebased this PR onto
most recent commit in `trunk`. It is
sarwarbhuiyan commented on pull request #7499:
URL: https://github.com/apache/kafka/pull/7499#issuecomment-854551022
KIP passed voting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Wenbing Shen created KAFKA-12891:
Summary: Add --files and --file-separator options to the
ConsoleProducer
Key: KAFKA-12891
URL: https://issues.apache.org/jira/browse/KAFKA-12891
Project: Kafka
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r645441207
##
File path: core/src/main/scala/kafka/log/LogLoader.scala
##
@@ -246,17 +262,17 @@ object LogLoader extends Logging {
return fn
} catch
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r645439645
##
File path: core/src/test/scala/unit/kafka/log/LocalLogTest.scala
##
@@ -0,0 +1,734 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r645439534
##
File path: core/src/test/scala/unit/kafka/log/LocalLogTest.scala
##
@@ -0,0 +1,734 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r645437580
##
File path: core/src/test/scala/unit/kafka/log/LocalLogTest.scala
##
@@ -0,0 +1,734 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r645437282
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -1500,50 +1325,67 @@ class Log(@volatile private var _dir: File,
}
}
-
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r645434947
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -1500,50 +1325,67 @@ class Log(@volatile private var _dir: File,
}
}
-
kowshik commented on a change in pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#discussion_r643465477
##
File path: core/src/test/scala/unit/kafka/log/LocalLogTest.scala
##
@@ -0,0 +1,734 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
jlprat commented on a change in pull request #10810:
URL: https://github.com/apache/kafka/pull/10810#discussion_r645405935
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java
##
@@ -158,32 +165,52 @@ Cancellable schedule(final Duration
ijuma commented on pull request #9302:
URL: https://github.com/apache/kafka/pull/9302#issuecomment-854395748
Is this still relevant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ijuma merged pull request #10471:
URL: https://github.com/apache/kafka/pull/10471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
showuon commented on a change in pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#discussion_r645321936
##
File path: build.gradle
##
@@ -829,6 +829,7 @@ project(':core') {
testImplementation(libs.jfreechart) {
exclude group: 'junit', module:
socutes commented on pull request #10815:
URL: https://github.com/apache/kafka/pull/10815#issuecomment-854395260
@showuon , please help review this PR. Thanks！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
ijuma commented on a change in pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#discussion_r645318499
##
File path: build.gradle
##
@@ -829,6 +829,7 @@ project(':core') {
testImplementation(libs.jfreechart) {
exclude group: 'junit', module:
abbccdda commented on pull request #10809:
URL: https://github.com/apache/kafka/pull/10809#issuecomment-854402436
@ijuma That's a good call, should I revert it? It was just a styling change
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message,
mjsax commented on a change in pull request #10813:
URL: https://github.com/apache/kafka/pull/10813#discussion_r645299252
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/ChangedSerializer.java
##
@@ -40,7 +40,10 @@ public ChangedSerializer(final
mjsax commented on pull request #10813:
URL: https://github.com/apache/kafka/pull/10813#issuecomment-854379331
How confident are we, that we covered most cases to avoid NPE and throw
ConfigException? Seems it's still many places that we need to cover, and I am
wondering if we follow the
ijuma commented on pull request #10471:
URL: https://github.com/apache/kafka/pull/10471#issuecomment-854399316
Unrelated test failures:
> Build / JDK 11 and Scala 2.13 /
kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic() | 16
sec | 1
> -- | -- | --
>
ijuma commented on pull request #10809:
URL: https://github.com/apache/kafka/pull/10809#issuecomment-854385011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries
ijuma commented on a change in pull request #10805:
URL: https://github.com/apache/kafka/pull/10805#discussion_r645317670
##
File path: core/src/main/scala/kafka/tools/MirrorMaker.scala
##
@@ -58,7 +58,10 @@ import scala.util.{Failure, Success, Try}
*
ijuma edited a comment on pull request #10471:
URL: https://github.com/apache/kafka/pull/10471#issuecomment-854399316
Unrelated test failures:
> Build / JDK 11 and Scala 2.13 /
kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic()
> Build / JDK 11 and Scala
dongjinleekr commented on pull request #10678:
URL: https://github.com/apache/kafka/pull/10678#issuecomment-853838170
@ableegoldman Could you have a look? :pray:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
ryannedolan commented on pull request #10652:
URL: https://github.com/apache/kafka/pull/10652#issuecomment-854215843
None of the failing tests are related. Ready to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dongjinleekr commented on pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#issuecomment-853821984
@cadonna Here it is, with the following: 1. making server-common to ignore
import orders. 2. rebasing onto the latest trunk.
+1. It seems like we can make the
hachikuji commented on a change in pull request #10793:
URL: https://github.com/apache/kafka/pull/10793#discussion_r645084226
##
File path:
server-common/src/main/java/org/apache/kafka/server/common/serialization/AbstractApiMessageSerde.java
##
@@ -69,16 +76,42 @@ public void
dejan2609 commented on pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#issuecomment-853411084
Shameless plug and related to CheckStyle: ⏩ #10698 (needs a review /
approval).
--
This is an automated message from the Apache Git Service.
To respond to the
dengziming commented on a change in pull request #10793:
URL: https://github.com/apache/kafka/pull/10793#discussion_r645205625
##
File path:
server-common/src/main/java/org/apache/kafka/server/common/serialization/AbstractApiMessageSerde.java
##
@@ -69,16 +76,42 @@ public
dejan2609 commented on pull request #10698:
URL: https://github.com/apache/kafka/pull/10698#issuecomment-853408053
Just tagging @ijuma here again (to come back up to the surface).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
guozhangwang commented on a change in pull request #10609:
URL: https://github.com/apache/kafka/pull/10609#discussion_r644343550
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/SubscriptionInfo.java
##
@@ -125,6 +130,29 @@ public
dengziming commented on pull request #10793:
URL: https://github.com/apache/kafka/pull/10793#issuecomment-853911013
@hachikuji Thanks for the remindings, I think the validations in `read` are
useful and I copied them to `MetadataRecordSerde`, but not sure whether the
dongjinleekr commented on a change in pull request #10507:
URL: https://github.com/apache/kafka/pull/10507#discussion_r644545454
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/AbstractStream.java
##
@@ -16,6 +16,10 @@
*/
package
cadonna commented on a change in pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#discussion_r644711679
##
File path: core/src/main/java/kafka/metrics/FilteringJmxReporter.java
##
@@ -51,7 +50,7 @@ public void updatePredicate(Predicate predicate) {
vvcephei commented on a change in pull request #10810:
URL: https://github.com/apache/kafka/pull/10810#discussion_r645023265
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java
##
@@ -158,32 +165,52 @@ Cancellable schedule(final
tombentley commented on a change in pull request #9441:
URL: https://github.com/apache/kafka/pull/9441#discussion_r644571665
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -279,30 +279,33 @@ class KafkaApis(val requestChannel: RequestChannel,
new
guozhangwang commented on pull request #10646:
URL: https://github.com/apache/kafka/pull/10646#issuecomment-854262242
@cadonna
1. Filed a ticket for KStreams to enforce shutdown on illegal-X exceptions
as a future work.
2. Let the global state mgr to do closing before throwing
vamossagar12 commented on a change in pull request #10798:
URL: https://github.com/apache/kafka/pull/10798#discussion_r644616944
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -505,6 +506,14 @@ private void
mjsax commented on a change in pull request #10810:
URL: https://github.com/apache/kafka/pull/10810#discussion_r644509797
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java
##
@@ -158,32 +165,52 @@ Cancellable schedule(final Duration
mdedetrich edited a comment on pull request #10648:
URL: https://github.com/apache/kafka/pull/10648#issuecomment-835180661
@mimaison I have just renamed `LegacyReplicationPolicy` to
`IdentityReplicationPolicy` and forced pushed the branch.
@ryannedolan I will have a look at
jlprat commented on pull request #10784:
URL: https://github.com/apache/kafka/pull/10784#issuecomment-854078089
Any chance any of you has time to check this? cc @mjsax @vvcephei
@guozhangwang
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the
showuon commented on pull request #10471:
URL: https://github.com/apache/kafka/pull/10471#issuecomment-853665420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
showuon edited a comment on pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#issuecomment-853761494
@hachikuji @mumrah @abbccdda @cmccabe , call for review since the tests keep
failing. Thank you.
--
This is an automated message from the Apache Git Service.
To
1 - 100 of 150 matches
Mail list logo
