satishd commented on a change in pull request #10579:
URL: https://github.com/apache/kafka/pull/10579#discussion_r657674359
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java
##
@@ -0,0 +1,336 @@
+/*
[
https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17369200#comment-17369200
]
Luke Chen commented on KAFKA-12993:
---
on it~
> Formatting of Streams 'Memory Management' docs is
[
https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-12993:
-
Assignee: Luke Chen
> Formatting of Streams 'Memory Management' docs is messed up
>
izzyacademy commented on a change in pull request #10926:
URL: https://github.com/apache/kafka/pull/10926#discussion_r658404890
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java
##
@@ -341,6 +341,7 @@ private void
izzyacademy commented on a change in pull request #10926:
URL: https://github.com/apache/kafka/pull/10926#discussion_r658404524
##
File path: streams/src/test/java/org/apache/kafka/streams/TopologyTest.java
##
@@ -62,6 +62,7 @@
import static org.junit.Assert.assertThrows;
izzyacademy commented on a change in pull request #10926:
URL: https://github.com/apache/kafka/pull/10926#discussion_r658404143
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindows.java
##
@@ -83,16 +92,52 @@ private TimeWindows(final long sizeMs,
izzyacademy commented on a change in pull request #10926:
URL: https://github.com/apache/kafka/pull/10926#discussion_r658403881
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/SlidingWindows.java
##
@@ -78,6 +82,43 @@
private SlidingWindows(final
showuon commented on pull request #10916:
URL: https://github.com/apache/kafka/pull/10916#issuecomment-868113564
@omkreddy @soarez , please help review this PR to reenable the
testChrootExistsAndRootIsLocked test
. Thanks.
cc @ijuma
--
This is an automated message from the Apache
[
https://issues.apache.org/jira/browse/KAFKA-12938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-12938:
-
Assignee: Luke Chen
> Fix and reenable testChrootExistsAndRootIsLocked
>
[
https://issues.apache.org/jira/browse/KAFKA-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Israel Ekpo updated KAFKA-12994:
Description:
Due to the API changes for KIP-633 a lot of deprecation warnings have been
izzyacademy commented on a change in pull request #10926:
URL: https://github.com/apache/kafka/pull/10926#discussion_r658381873
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/InternalTopicIntegrationTest.java
##
@@ -71,6 +71,7 @@
/**
* Tests
Israel Ekpo created KAFKA-12994:
---
Summary: Migrate all Tests to New API and Remove Suppression for
Deprecation Warnings related to KIP-633
Key: KAFKA-12994
URL: https://issues.apache.org/jira/browse/KAFKA-12994
izzyacademy commented on pull request #10740:
URL: https://github.com/apache/kafka/pull/10740#issuecomment-868099381
Closing this PR. A new PR #10926 has been opened.
https://github.com/apache/kafka/pull/10926
--
This is an automated message from the Apache Git Service.
To respond
izzyacademy closed pull request #10740:
URL: https://github.com/apache/kafka/pull/10740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
satishd commented on pull request #10579:
URL: https://github.com/apache/kafka/pull/10579#issuecomment-868083433
Thanks @ccding for the review. Addressed them with the latest commit
https://github.com/apache/kafka/commit/25c4ccb7c5ad44963a9708f0df67b982cf91ac15
--
This is an automated
satishd commented on a change in pull request #10579:
URL: https://github.com/apache/kafka/pull/10579#discussion_r658361692
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerManager.java
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to
[
https://issues.apache.org/jira/browse/KAFKA-12993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12993:
---
Component/s: docs
> Formatting of Streams 'Memory Management' docs is
A. Sophie Blee-Goldman created KAFKA-12993:
--
Summary: Formatting of Streams 'Memory Management' docs is messed
up
Key: KAFKA-12993
URL: https://issues.apache.org/jira/browse/KAFKA-12993
jsancio commented on a change in pull request #10812:
URL: https://github.com/apache/kafka/pull/10812#discussion_r658353741
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -1049,6 +1052,7 @@ object KafkaConfig {
jsancio commented on a change in pull request #10812:
URL: https://github.com/apache/kafka/pull/10812#discussion_r658352517
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -1049,6 +1052,7 @@ object KafkaConfig {
Jose Armando Garcia Sancio created KAFKA-12992:
--
Summary: Make kraft configuration properties public
Key: KAFKA-12992
URL: https://issues.apache.org/jira/browse/KAFKA-12992
Project: Kafka
izzyacademy commented on a change in pull request #10926:
URL: https://github.com/apache/kafka/pull/10926#discussion_r658351347
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/InternalTopicIntegrationTest.java
##
@@ -71,6 +71,7 @@
/**
* Tests
[
https://issues.apache.org/jira/browse/KAFKA-10724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-10724:
---
Labels: kip-500 (was: )
> Command to run single quorum in raft is
[
https://issues.apache.org/jira/browse/KAFKA-12714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-12714:
---
Labels: kip-500 (was: )
> Kafka 2.8 server not starting on Windows
[
https://issues.apache.org/jira/browse/KAFKA-12712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-12712:
---
Labels: kip-500 (was: )
> KRaft: Missing controller.quorom.voters
ableegoldman commented on pull request #10740:
URL: https://github.com/apache/kafka/pull/10740#issuecomment-868022579
@izzyacademy yeah, go ahead and close this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-12958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-12958:
---
Summary: Add simulation invariant for leadership and snapshot (was:
ableegoldman commented on a change in pull request #10926:
URL: https://github.com/apache/kafka/pull/10926#discussion_r658345192
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindows.java
##
@@ -83,16 +92,52 @@ private TimeWindows(final long sizeMs,
cmccabe commented on pull request #10812:
URL: https://github.com/apache/kafka/pull/10812#issuecomment-868003253
I realize this is a bit messy to test, but it would be good to have a test
that the QuorumController really did trigger a snapshot after X bytes of
records were added to the
cmccabe commented on a change in pull request #10812:
URL: https://github.com/apache/kafka/pull/10812#discussion_r658332589
##
File path:
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java
##
@@ -367,6 +435,36 @@ private void checkSnapshotContents(
cmccabe commented on a change in pull request #10812:
URL: https://github.com/apache/kafka/pull/10812#discussion_r658330688
##
File path:
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java
##
@@ -282,7 +285,71 @@ public void testSnapshotSaveAndLoad()
cmccabe commented on a change in pull request #10812:
URL: https://github.com/apache/kafka/pull/10812#discussion_r658330409
##
File path:
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java
##
@@ -269,7 +269,10 @@ public void testSnapshotSaveAndLoad()
cmccabe commented on a change in pull request #10812:
URL: https://github.com/apache/kafka/pull/10812#discussion_r658329637
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -877,6 +880,35 @@ private void replay(ApiMessage message,
cmccabe commented on a change in pull request #10812:
URL: https://github.com/apache/kafka/pull/10812#discussion_r658329119
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -877,6 +880,35 @@ private void replay(ApiMessage message,
cmccabe commented on a change in pull request #10812:
URL: https://github.com/apache/kafka/pull/10812#discussion_r658327187
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -374,6 +375,7 @@ object KafkaConfig {
val BrokerSessionTimeoutMsProp =
cmccabe commented on a change in pull request #10812:
URL: https://github.com/apache/kafka/pull/10812#discussion_r658327187
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -374,6 +375,7 @@ object KafkaConfig {
val BrokerSessionTimeoutMsProp =
cmccabe commented on a change in pull request #10812:
URL: https://github.com/apache/kafka/pull/10812#discussion_r658323339
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -1049,6 +1052,7 @@ object KafkaConfig {
cmccabe commented on a change in pull request #10812:
URL: https://github.com/apache/kafka/pull/10812#discussion_r658320488
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -1049,6 +1052,7 @@ object KafkaConfig {
cmccabe commented on a change in pull request #10812:
URL: https://github.com/apache/kafka/pull/10812#discussion_r658322252
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -74,6 +74,7 @@ object Defaults {
val InitialBrokerRegistrationTimeoutMs = 6
cmccabe commented on a change in pull request #10812:
URL: https://github.com/apache/kafka/pull/10812#discussion_r658320488
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -1049,6 +1052,7 @@ object KafkaConfig {
cmccabe opened a new pull request #10927:
URL: https://github.com/apache/kafka/pull/10927
Use MockConfigRepository rather than CachedConfigRepository in unit
tests. This is useful for an upcoming change that will remove
CachedConfigRepository.
--
This is an automated message from
izzyacademy commented on pull request #10740:
URL: https://github.com/apache/kafka/pull/10740#issuecomment-867906034
I could not update this branch and PR with my new changes to trunk.
I have created a new PR
https://github.com/apache/kafka/pull/10926
@ableegoldman @mjsax
izzyacademy opened a new pull request #10926:
URL: https://github.com/apache/kafka/pull/10926
[KAFKA-8613] Make grace period mandatory
KIP-633 New APIs for Controlling Grace Period for Windowed Operations
- Added API changes by KIP-633 for JoinWindows, SessionWindows,
izzyacademy closed pull request #10924:
URL: https://github.com/apache/kafka/pull/10924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
izzyacademy commented on pull request #10924:
URL: https://github.com/apache/kafka/pull/10924#issuecomment-867897115
I will close this one and resolve the conflicts before opening the next one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dajac commented on pull request #10879:
URL: https://github.com/apache/kafka/pull/10879#issuecomment-867875878
Merged to trunk and 2.8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-12967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-12967.
-
Resolution: Fixed
> DescribeQuorum API should be forwarded from brokers
>
hachikuji merged pull request #10900:
URL: https://github.com/apache/kafka/pull/10900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
xinzhuxiansheng opened a new pull request #10925:
URL: https://github.com/apache/kafka/pull/10925
When refer to the return "Check whether the last offset of the last batch in
this segment overflows the indexes", if the result is not expected, the path of
the segment should be printed so
niket-goel commented on a change in pull request #10899:
URL: https://github.com/apache/kafka/pull/10899#discussion_r658138278
##
File path:
raft/src/test/java/org/apache/kafka/snapshot/SnapshotWriterReaderTest.java
##
@@ -37,6 +43,52 @@
private final int localId = 0;
niket-goel commented on a change in pull request #10899:
URL: https://github.com/apache/kafka/pull/10899#discussion_r658137972
##
File path:
raft/src/test/java/org/apache/kafka/snapshot/SnapshotWriterReaderTest.java
##
@@ -37,6 +43,52 @@
private final int localId = 0;
niket-goel commented on a change in pull request #10899:
URL: https://github.com/apache/kafka/pull/10899#discussion_r658132063
##
File path: metadata/src/test/java/org/apache/kafka/metalog/LocalLogManager.java
##
@@ -541,6 +541,8 @@ public void resign(int epoch) {
jsancio commented on a change in pull request #10899:
URL: https://github.com/apache/kafka/pull/10899#discussion_r658125257
##
File path:
raft/src/test/java/org/apache/kafka/snapshot/SnapshotWriterReaderTest.java
##
@@ -37,6 +43,52 @@
private final int localId = 0;
[
https://issues.apache.org/jira/browse/KAFKA-12336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bill Bejeck updated KAFKA-12336:
Fix Version/s: 2.8.1
> custom stream naming does not work while calling stream[K,
[
https://issues.apache.org/jira/browse/KAFKA-12336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368968#comment-17368968
]
Bill Bejeck commented on KAFKA-12336:
-
cherry-picked to 2.8
> custom stream naming does not work
bbejeck commented on pull request #10190:
URL: https://github.com/apache/kafka/pull/10190#issuecomment-867800402
cherry-picked to 2.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mimaison commented on pull request #10221:
URL: https://github.com/apache/kafka/pull/10221#issuecomment-867792968
@kkonstantine @tombentley As you voted on the KIP, can you take a look at
this PR? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/KAFKA-12988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated KAFKA-12988:
---
Summary: Change RLMM add/updateRemoteLogSegmentMetadata and
edoardocomar commented on a change in pull request #10221:
URL: https://github.com/apache/kafka/pull/10221#discussion_r658097481
##
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceConnectorTest.java
##
@@ -234,6 +234,6 @@ public void
mimaison commented on pull request #10743:
URL: https://github.com/apache/kafka/pull/10743#issuecomment-867772697
@tombentley @dajac @skaundinya15 Thanks for the reviews! I believe I've
addressed all your comments now.
--
This is an automated message from the Apache Git Service.
To
edoardocomar commented on a change in pull request #10221:
URL: https://github.com/apache/kafka/pull/10221#discussion_r658094350
##
File path:
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java
##
@@ -220,6 +220,9 @@ public MirrorClientConfig
edoardocomar commented on a change in pull request #10221:
URL: https://github.com/apache/kafka/pull/10221#discussion_r658091005
##
File path:
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java
##
@@ -202,6 +205,10 @@
private static
[
https://issues.apache.org/jira/browse/KAFKA-12336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368949#comment-17368949
]
Bill Bejeck commented on KAFKA-12336:
-
merged into trunk
> custom stream naming does not work while
[
https://issues.apache.org/jira/browse/KAFKA-12336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bill Bejeck updated KAFKA-12336:
Fix Version/s: 3.0.0
> custom stream naming does not work while calling stream[K,
[
https://issues.apache.org/jira/browse/KAFKA-12336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bill Bejeck resolved KAFKA-12336.
-
Resolution: Fixed
> custom stream naming does not work while calling stream[K, V](topicPattern:
bbejeck commented on pull request #10190:
URL: https://github.com/apache/kafka/pull/10190#issuecomment-867765677
Thanks @g1geordie for the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
bbejeck commented on pull request #10190:
URL: https://github.com/apache/kafka/pull/10190#issuecomment-867765408
merged #10190 into trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
bbejeck merged pull request #10190:
URL: https://github.com/apache/kafka/pull/10190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
bbejeck commented on pull request #10190:
URL: https://github.com/apache/kafka/pull/10190#issuecomment-867764005
```
Build / JDK 11 and Scala 2.13 / [1] tlsProtocol=TLSv1.2, useInlinePem=false
– org.apache.kafka.common.network.SslTransportLayerTest
15s
Build / JDK 11 and Scala
[
https://issues.apache.org/jira/browse/KAFKA-12991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-12991.
-
Fix Version/s: 2.8.1
3.0.0
Reviewer: A. Sophie Blee-Goldman
dajac merged pull request #10879:
URL: https://github.com/apache/kafka/pull/10879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
David Jacot created KAFKA-12991:
---
Summary: Fix unsafe access to `AbstractCoordinator.state`
Key: KAFKA-12991
URL: https://issues.apache.org/jira/browse/KAFKA-12991
Project: Kafka
Issue Type:
dajac commented on pull request #10879:
URL: https://github.com/apache/kafka/pull/10879#issuecomment-867735409
Failed tests are not related:
```
Build / JDK 11 and Scala 2.13 /
org.apache.kafka.common.network.SslTransportLayerTest.[1] tlsProtocol=TLSv1.2,
useInlinePem=false
Build
mimaison commented on a change in pull request #10743:
URL: https://github.com/apache/kafka/pull/10743#discussion_r658016506
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4806,7 +4275,7 @@ public ListTransactionsResult
cadonna commented on pull request #10840:
URL: https://github.com/apache/kafka/pull/10840#issuecomment-867665743
> Regarding the SourceConnectorsIntegrationTest failing in Jenkins, do you
agree that is unrelated?
Yes, I agree!
--
This is an automated message from the Apache Git
showuon commented on pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#issuecomment-867662039
@hachikuji , call for review. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
IgnacioAcunaF commented on a change in pull request #10858:
URL: https://github.com/apache/kafka/pull/10858#discussion_r657960159
##
File path: core/src/test/scala/unit/kafka/admin/ConsumerGroupServiceTest.scala
##
@@ -62,6 +62,92 @@ class ConsumerGroupServiceTest {
skaundinya15 commented on a change in pull request #10743:
URL: https://github.com/apache/kafka/pull/10743#discussion_r657960058
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/internals/CoordinatorKey.java
##
@@ -24,7 +24,7 @@
public final String
skaundinya15 commented on a change in pull request #10743:
URL: https://github.com/apache/kafka/pull/10743#discussion_r657957425
##
File path: clients/src/main/resources/common/message/FindCoordinatorRequest.json
##
@@ -23,12 +23,16 @@
// Version 2 is the same as version 1.
[
https://issues.apache.org/jira/browse/KAFKA-12378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368821#comment-17368821
]
Nurlan Turdaliev edited comment on KAFKA-12378 at 6/24/21, 1:03 PM:
jolshan commented on a change in pull request #10923:
URL: https://github.com/apache/kafka/pull/10923#discussion_r657920858
##
File path:
core/src/test/scala/unit/kafka/server/TopicIdWithOldInterBrokerProtocolTest.scala
##
@@ -94,7 +94,8 @@ class
[
https://issues.apache.org/jira/browse/KAFKA-12378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368821#comment-17368821
]
Nurlan Turdaliev commented on KAFKA-12378:
--
Voting here, at least a warning somewhere in the
Piotr Rybarczyk created KAFKA-12990:
---
Summary: Infinite Loop in producing event to kafka
Key: KAFKA-12990
URL: https://issues.apache.org/jira/browse/KAFKA-12990
Project: Kafka
Issue Type:
jlprat commented on pull request #10840:
URL: https://github.com/apache/kafka/pull/10840#issuecomment-867593067
Hi @cadonna I'll try to fix address the comments either today or tomorrow.
Regarding the `SourceConnectorsIntegrationTest` failing in Jenkins, do you
agree that is
mimaison commented on a change in pull request #10743:
URL: https://github.com/apache/kafka/pull/10743#discussion_r657891229
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/internals/CoordinatorKey.java
##
@@ -24,7 +24,7 @@
public final String idValue;
cadonna commented on a change in pull request #10840:
URL: https://github.com/apache/kafka/pull/10840#discussion_r657813645
##
File path: docs/streams/upgrade-guide.html
##
@@ -121,10 +121,23 @@ Streams API
The public topicGroupId and partition fields
on TaskId
[
https://issues.apache.org/jira/browse/KAFKA-12761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomasz Kaszuba updated KAFKA-12761:
---
Description:
If I understand correctly the following
mimaison commented on a change in pull request #10743:
URL: https://github.com/apache/kafka/pull/10743#discussion_r657884154
##
File path:
clients/src/main/java/org/apache/kafka/common/errors/NoBatchedFindCoordinatorsException.java
##
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the
mimaison commented on a change in pull request #10743:
URL: https://github.com/apache/kafka/pull/10743#discussion_r657881689
##
File path: clients/src/test/java/org/apache/kafka/clients/MockClient.java
##
@@ -245,10 +246,18 @@ public void send(ClientRequest request, long now)
dajac commented on a change in pull request #10858:
URL: https://github.com/apache/kafka/pull/10858#discussion_r657874082
##
File path: core/src/test/scala/unit/kafka/admin/ConsumerGroupServiceTest.scala
##
@@ -62,6 +62,92 @@ class ConsumerGroupServiceTest {
verify(admin,
mimaison commented on a change in pull request #10743:
URL: https://github.com/apache/kafka/pull/10743#discussion_r657873384
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/internals/CoordinatorKey.java
##
@@ -24,7 +24,7 @@
public final String idValue;
mimaison commented on a change in pull request #10743:
URL: https://github.com/apache/kafka/pull/10743#discussion_r657870204
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/DescribeConsumerGroupsResult.java
##
@@ -34,39 +35,40 @@
[
https://issues.apache.org/jira/browse/KAFKA-12989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-12989:
Description:
The `MockClient` offers the possibility to prepare an unsupported version
response
David Jacot created KAFKA-12989:
---
Summary: `MockClient` should respect the request matcher passed to
`prepareUnsupportedVersionResponse`
Key: KAFKA-12989
URL: https://issues.apache.org/jira/browse/KAFKA-12989
[
https://issues.apache.org/jira/browse/KAFKA-12989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-12989:
Issue Type: Bug (was: Improvement)
> `MockClient` should respect the request matcher passed to
mimaison commented on a change in pull request #10743:
URL: https://github.com/apache/kafka/pull/10743#discussion_r657863835
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/DeleteConsumerGroupsResult.java
##
@@ -29,9 +32,9 @@
*/
mimaison commented on a change in pull request #10743:
URL: https://github.com/apache/kafka/pull/10743#discussion_r657856869
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/FindCoordinatorResponse.java
##
@@ -95,4 +96,21 @@ public static
mimaison commented on a change in pull request #10743:
URL: https://github.com/apache/kafka/pull/10743#discussion_r657856438
##
File path: clients/src/main/resources/common/message/FindCoordinatorRequest.json
##
@@ -23,12 +23,16 @@
// Version 2 is the same as version 1.
showuon commented on a change in pull request #10923:
URL: https://github.com/apache/kafka/pull/10923#discussion_r657826290
##
File path:
core/src/test/scala/unit/kafka/server/TopicIdWithOldInterBrokerProtocolTest.scala
##
@@ -94,7 +94,8 @@ class
hachikuji commented on a change in pull request #10913:
URL: https://github.com/apache/kafka/pull/10913#discussion_r657804676
##
File path: raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java
##
@@ -1159,18 +1164,20 @@ void readBatch(BatchReader reader) {
1 - 100 of 123 matches
Mail list logo
